ira/wip.git
15 years agoRename same_net to same_net_v4 for consistency with Samba 3.
Jelmer Vernooij [Thu, 23 Oct 2008 17:56:09 +0000 (19:56 +0200)]
Rename same_net to same_net_v4 for consistency with Samba 3.

15 years agoUse sockaddr_storage only where we rely on the size, use sockaddr
Jelmer Vernooij [Thu, 23 Oct 2008 17:53:15 +0000 (19:53 +0200)]
Use sockaddr_storage only where we rely on the size, use sockaddr
otherwise (to clarify we can also pass in structs smaller than
sockaddr_storage, such as sockaddr_in).

15 years agoRemove support for obsolete data type "ipv4address"
Jelmer Vernooij [Thu, 23 Oct 2008 16:56:37 +0000 (18:56 +0200)]
Remove support for obsolete data type "ipv4address"

15 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba
Jelmer Vernooij [Thu, 23 Oct 2008 16:50:34 +0000 (18:50 +0200)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba

15 years agoUse libutil genrand.
Jelmer Vernooij [Thu, 23 Oct 2008 16:46:35 +0000 (18:46 +0200)]
Use libutil genrand.

15 years agos3-build: remove duplicate svcctl bits and re-run make samba3-idl.
Günther Deschner [Thu, 23 Oct 2008 16:34:28 +0000 (18:34 +0200)]
s3-build: remove duplicate svcctl bits and re-run make samba3-idl.

Guenther

15 years agoidl: add svcctl specific access bits.
Günther Deschner [Thu, 23 Oct 2008 16:33:49 +0000 (18:33 +0200)]
idl: add svcctl specific access bits.

Guenther

15 years agoMerge branch 'master' of git://git.samba.org/samba
Jelmer Vernooij [Thu, 23 Oct 2008 16:04:16 +0000 (18:04 +0200)]
Merge branch 'master' of git://git.samba.org/samba

Conflicts:
lib/util/asn1_proto.h

15 years agoInline asn1_proto.h since the API is stable and public.
Jelmer Vernooij [Thu, 23 Oct 2008 16:03:20 +0000 (18:03 +0200)]
Inline asn1_proto.h since the API is stable and public.

15 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba
Jelmer Vernooij [Thu, 23 Oct 2008 15:51:30 +0000 (17:51 +0200)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba

15 years agoMake use of a large buffer for smbclient put command
Volker Lendecke [Thu, 23 Oct 2008 15:42:45 +0000 (17:42 +0200)]
Make use of a large buffer for smbclient put command

15 years agoOptimize x_fread to speed up the smbclient put command
Volker Lendecke [Thu, 23 Oct 2008 13:43:36 +0000 (15:43 +0200)]
Optimize x_fread to speed up the smbclient put command

15 years agoImport talloc_stack into util library.
Jelmer Vernooij [Thu, 23 Oct 2008 15:27:30 +0000 (17:27 +0200)]
Import talloc_stack into util library.

15 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba
Jelmer Vernooij [Thu, 23 Oct 2008 15:12:16 +0000 (17:12 +0200)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba

15 years agoMerge branch 'master' of git://git.samba.org/samba
Jelmer Vernooij [Thu, 23 Oct 2008 15:04:16 +0000 (17:04 +0200)]
Merge branch 'master' of git://git.samba.org/samba

15 years agoShare codepages.
Jelmer Vernooij [Thu, 23 Oct 2008 14:58:11 +0000 (16:58 +0200)]
Share codepages.

15 years agos3-docs: fix typos in locator manpage found by metze.
Günther Deschner [Thu, 23 Oct 2008 14:44:29 +0000 (16:44 +0200)]
s3-docs: fix typos in locator manpage found by metze.

Guenther

15 years agoselftest.pl: Silence verbose tdbsam output.
Jelmer Vernooij [Thu, 23 Oct 2008 14:42:45 +0000 (16:42 +0200)]
selftest.pl: Silence verbose tdbsam output.

15 years agos3-docs: add very basic winbind_krb5_locator.7 manpage.
Günther Deschner [Thu, 23 Oct 2008 14:40:23 +0000 (16:40 +0200)]
s3-docs: add very basic winbind_krb5_locator.7 manpage.

Guenther

15 years agoUse WERR_FILE_EXISTS which is the equivalent of WERR_ALREADY_EXISTS
Jelmer Vernooij [Thu, 23 Oct 2008 13:37:39 +0000 (15:37 +0200)]
Use WERR_FILE_EXISTS which is the equivalent of WERR_ALREADY_EXISTS
previously present in Samba 3.

15 years agoUse common error definitions.
Jelmer Vernooij [Thu, 23 Oct 2008 13:35:21 +0000 (15:35 +0200)]
Use common error definitions.

15 years agos3-build: fix another build warning with the new ASN1 code.
Günther Deschner [Thu, 23 Oct 2008 09:45:41 +0000 (11:45 +0200)]
s3-build: fix another build warning with the new ASN1 code.

Guenther

15 years agonetapi: fix add_GROUP_USERS_INFO_X_buffer.
Günther Deschner [Thu, 23 Oct 2008 01:32:38 +0000 (03:32 +0200)]
netapi: fix add_GROUP_USERS_INFO_X_buffer.

Guenther

15 years agonetapi: fix NetUserGetGroups_r returning partial results.
Günther Deschner [Thu, 23 Oct 2008 01:32:15 +0000 (03:32 +0200)]
netapi: fix NetUserGetGroups_r returning partial results.

Guenther

15 years agos3-samr-server: unify callback convention: _samr_UserSetInfo.
Günther Deschner [Thu, 23 Oct 2008 01:31:32 +0000 (03:31 +0200)]
s3-samr-server: unify callback convention: _samr_UserSetInfo.

Guenther

15 years agos3-samr-server: unify callback convention: _samr_QueryDomainInfo.
Günther Deschner [Thu, 23 Oct 2008 01:30:58 +0000 (03:30 +0200)]
s3-samr-server: unify callback convention: _samr_QueryDomainInfo.

Guenther

15 years agos3-samr-server: fix return code in _samr_QueryDisplayInformation.
Günther Deschner [Thu, 23 Oct 2008 01:30:14 +0000 (03:30 +0200)]
s3-samr-server: fix return code in _samr_QueryDisplayInformation.

Guenther

15 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba
Jelmer Vernooij [Thu, 23 Oct 2008 02:58:08 +0000 (04:58 +0200)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba

15 years agoFix header file installation.
Jelmer Vernooij [Thu, 23 Oct 2008 02:57:44 +0000 (04:57 +0200)]
Fix header file installation.

15 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba into master-devel
Andrew Bartlett [Thu, 23 Oct 2008 01:56:30 +0000 (12:56 +1100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba into master-devel

15 years agoClarify the linked attribute module behaviour with comments
Andrew Bartlett [Thu, 23 Oct 2008 01:50:22 +0000 (12:50 +1100)]
Clarify the linked attribute module behaviour with comments

15 years agoImport NTSTATUS defines from Samba 3.
Jelmer Vernooij [Thu, 23 Oct 2008 01:29:20 +0000 (03:29 +0200)]
Import NTSTATUS defines from Samba 3.

15 years agoImport WERROR defines from Samba 3.
Jelmer Vernooij [Thu, 23 Oct 2008 01:25:00 +0000 (03:25 +0200)]
Import WERROR defines from Samba 3.

15 years agoImport new DOS error codes from Samba 3.
Jelmer Vernooij [Thu, 23 Oct 2008 01:13:08 +0000 (03:13 +0200)]
Import new DOS error codes from Samba 3.

15 years agoMove libcli-util error code to top-level.
Jelmer Vernooij [Thu, 23 Oct 2008 01:11:19 +0000 (03:11 +0200)]
Move libcli-util error code to top-level.

15 years agoRemove unused copy of tables.pl
Jelmer Vernooij [Thu, 23 Oct 2008 01:07:27 +0000 (03:07 +0200)]
Remove unused copy of tables.pl

15 years agoRemove unused copy of ndrdump.c.
Jelmer Vernooij [Thu, 23 Oct 2008 01:04:48 +0000 (03:04 +0200)]
Remove unused copy of ndrdump.c.

15 years agos4-smbtorture: fix build warning.
Günther Deschner [Thu, 23 Oct 2008 00:18:09 +0000 (02:18 +0200)]
s4-smbtorture: fix build warning.

Guenther

15 years agos3-build: fix some const build warnings.
Günther Deschner [Wed, 22 Oct 2008 23:43:41 +0000 (01:43 +0200)]
s3-build: fix some const build warnings.

Guenther

15 years agonetapi: NetGroupEnum_r needs to handle servers with no groups.
Günther Deschner [Wed, 22 Oct 2008 23:43:06 +0000 (01:43 +0200)]
netapi: NetGroupEnum_r needs to handle servers with no groups.

Guenther

15 years agos3-samr-server: _samr_DeleteUser needs to wipe out the user_handle on success.
Günther Deschner [Wed, 22 Oct 2008 23:42:27 +0000 (01:42 +0200)]
s3-samr-server: _samr_DeleteUser needs to wipe out the user_handle on success.

Guenther

15 years agos3-samr-server: fix access check in _samr_QuerySecurity().
Günther Deschner [Wed, 22 Oct 2008 21:16:19 +0000 (23:16 +0200)]
s3-samr-server: fix access check in _samr_QuerySecurity().

Guenther

15 years agos3-build: fix the build.
Günther Deschner [Wed, 22 Oct 2008 20:44:04 +0000 (22:44 +0200)]
s3-build: fix the build.

Guenther

15 years agoFix net rpc vampire, based on an *amazing* piece of debugging work by "Cooper S....
Jeremy Allison [Wed, 22 Oct 2008 20:21:23 +0000 (13:21 -0700)]
Fix net rpc vampire, based on an *amazing* piece of debugging work by "Cooper S. Blake" <the_analogkid@yahoo.com>.

"I believe I have found two bugs in the 3.2 code and one bug that
carried on to the 3.3 branch.  In the 3.2 code, everything is
located in the utils/net_rpc_samsync.c file.  What I believe is the
first problem is that fetch_database() is calling
samsync_fix_delta_array() with rid_crypt set to true, which means
the password hashes are unencrypted from the RID encryption.
However, I believe this call is redundant, and the corresponding
call for samdump has rid_crypt set to false.  So I think the
rid_crypt param should be false in fetch_database().

If you follow the code, it makes its way to sam_account_from_delta()
where the password hashes are decrypted a second time by calling
sam_pwd_hash().  I believe this is what is scrambling my passwords.

These methods were refactored somewhere in the 3.3 branch.  Now the
net_rpc_samsync.c class calls rpc_vampire_internals, which calls
libnet/libnet_samsync.c, which calls samsync_fix_delta_array() with
rid_crypt always set to false.  I think that's correct.  But the
second bug has carried through in the sam_account_from_delta()
function:

 208         if (memcmp(r->ntpassword.hash, zero_buf, 16) != 0) {
 209                 sam_pwd_hash(r->rid, r->ntpassword.hash, lm_passwd, 0);
 210                 pdb_set_lanman_passwd(account, lm_passwd, PDB_CHANGED);
 211         }
 212
 213         if (memcmp(r->lmpassword.hash, zero_buf, 16) != 0) {
 214                 sam_pwd_hash(r->rid, r->lmpassword.hash, nt_passwd, 0);
 215                 pdb_set_nt_passwd(account, nt_passwd, PDB_CHANGED);

If you look closely you'll see that the nt hash is going into the
lm_passwd variable and the decrypted value is being set in the lanman
hash, and the lanman hash is being decrypted and put into the nt hash
field.  So the LanMan and NT hashes look like they're being put in
the opposite fields."

Fix this by removing the rid_crypt parameter.
Jeremy.

15 years agos3-build: temporarily add asn1_proto file.
Günther Deschner [Wed, 22 Oct 2008 19:57:26 +0000 (21:57 +0200)]
s3-build: temporarily add asn1_proto file.

Jelmer, how can we get this autogenerated from samba3 in the non merged-build
case ?

Guenther

15 years agos3-asn1: make all of s3 asn1 code do a proper asn1_init() first.
Günther Deschner [Wed, 22 Oct 2008 17:23:49 +0000 (19:23 +0200)]
s3-asn1: make all of s3 asn1 code do a proper asn1_init() first.

Guenther

15 years agos3-asn1/spnego: use OIDs including dots.
Günther Deschner [Wed, 22 Oct 2008 16:57:59 +0000 (18:57 +0200)]
s3-asn1/spnego: use OIDs including dots.

Guenther

15 years agos3: use shared asn1 code.
Günther Deschner [Wed, 22 Oct 2008 12:06:08 +0000 (14:06 +0200)]
s3: use shared asn1 code.

Guenther

15 years agos3-spnego: move spnego defines to spnego.h
Günther Deschner [Wed, 22 Oct 2008 12:01:53 +0000 (14:01 +0200)]
s3-spnego: move spnego defines to spnego.h

Guenther

15 years agolib-util: merge from s3 asn1.
Günther Deschner [Wed, 22 Oct 2008 12:03:43 +0000 (14:03 +0200)]
lib-util: merge from s3 asn1.

Guenther

15 years agolib-util: fix c++ compile warning.
Günther Deschner [Wed, 22 Oct 2008 12:02:31 +0000 (14:02 +0200)]
lib-util: fix c++ compile warning.

Guenther

15 years agoSlightly simplify reply_sesssetup_blob(): Remove an else branch
Volker Lendecke [Wed, 22 Oct 2008 15:01:28 +0000 (17:01 +0200)]
Slightly simplify reply_sesssetup_blob(): Remove an else branch

15 years agoDon't push the data out to the client in reply_sesssetup_blob()
Volker Lendecke [Wed, 22 Oct 2008 14:59:08 +0000 (16:59 +0200)]
Don't push the data out to the client in reply_sesssetup_blob()

Sending the data at this level breaks the assumption at higher levels that
req->outbuf == NULL means this request is deferred. It also breaks potential
chaining (Kerberos session setup and tcon X in one request)

15 years agoRemove unused header file.
Jelmer Vernooij [Wed, 22 Oct 2008 15:00:49 +0000 (17:00 +0200)]
Remove unused header file.

15 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba
Jelmer Vernooij [Wed, 22 Oct 2008 14:57:46 +0000 (16:57 +0200)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba

15 years agomasktest: Avoid creating new memory context, use dynamic allocation.
Jelmer Vernooij [Wed, 22 Oct 2008 14:56:06 +0000 (16:56 +0200)]
masktest: Avoid creating new memory context, use dynamic allocation.

15 years agoChange some dynamic allocations back to static buffers to fix build.
Jelmer Vernooij [Wed, 22 Oct 2008 14:49:56 +0000 (16:49 +0200)]
Change some dynamic allocations back to static buffers to fix build.

15 years agoFix a debug message in send_nt_replies()
Volker Lendecke [Wed, 22 Oct 2008 14:14:26 +0000 (16:14 +0200)]
Fix a debug message in send_nt_replies()

15 years agoFix bug 5840: Segfault in "rpcclient lsaaddacctrights"
Volker Lendecke [Wed, 22 Oct 2008 12:26:05 +0000 (14:26 +0200)]
Fix bug 5840: Segfault in "rpcclient lsaaddacctrights"

15 years agoChange buffer size back to 256, just to be sure.
Jelmer Vernooij [Wed, 22 Oct 2008 03:24:00 +0000 (05:24 +0200)]
Change buffer size back to 256, just to be sure.

15 years agoRepel pstring to nsswitch/.
Jelmer Vernooij [Wed, 22 Oct 2008 03:14:14 +0000 (05:14 +0200)]
Repel pstring to nsswitch/.

15 years agoRemove pstring usage.
Jelmer Vernooij [Wed, 22 Oct 2008 02:30:54 +0000 (04:30 +0200)]
Remove pstring usage.

15 years agoRemove pstring usages.
Jelmer Vernooij [Wed, 22 Oct 2008 02:25:00 +0000 (04:25 +0200)]
Remove pstring usages.

15 years agoRequire separate option for quicktest include list rather than making
Jelmer Vernooij [Wed, 22 Oct 2008 02:09:17 +0000 (04:09 +0200)]
Require separate option for quicktest include list rather than making
assumptions about it.

15 years agoFix path for quicktest.
Jelmer Vernooij [Wed, 22 Oct 2008 02:05:22 +0000 (04:05 +0200)]
Fix path for quicktest.

15 years agoUse standard types.
Jelmer Vernooij [Wed, 22 Oct 2008 01:41:24 +0000 (03:41 +0200)]
Use standard types.

15 years agoCope with MAXIMUM_ALLOWED_ACCESS requests when opening handles.
Jeremy Allison [Wed, 22 Oct 2008 01:05:48 +0000 (18:05 -0700)]
Cope with MAXIMUM_ALLOWED_ACCESS requests when opening handles.
Jeremy.

15 years agoDon't include a (relative path) srcdir in samba4-data.mk.
Jelmer Vernooij [Tue, 21 Oct 2008 16:49:43 +0000 (18:49 +0200)]
Don't include a (relative path) srcdir in samba4-data.mk.

15 years agoFix AC_SEARCH_LIBS_EXT() usage.
Jelmer Vernooij [Tue, 21 Oct 2008 16:33:38 +0000 (18:33 +0200)]
Fix AC_SEARCH_LIBS_EXT() usage.

15 years agoAllow running individual tests in the testsuite, normalize test names, fix some tests.
Jelmer Vernooij [Tue, 21 Oct 2008 16:26:46 +0000 (18:26 +0200)]
Allow running individual tests in the testsuite, normalize test names, fix some tests.

15 years agoUse socket wrapper for selftest.pl, find binaries correctly.
Jelmer Vernooij [Tue, 21 Oct 2008 15:48:05 +0000 (17:48 +0200)]
Use socket wrapper for selftest.pl, find binaries correctly.

15 years agoSpecify skip list to selftest.pl, make make target depend on test
Jelmer Vernooij [Tue, 21 Oct 2008 15:32:07 +0000 (17:32 +0200)]
Specify skip list to selftest.pl, make make target depend on test
binaries.

15 years agoCorrectly report when merged-build is used in developer mode.
Jelmer Vernooij [Tue, 21 Oct 2008 15:23:48 +0000 (17:23 +0200)]
Correctly report when merged-build is used in developer mode.

15 years agoMerge branch 'selftest' of git://git.samba.org/jelmer/samba
Jelmer Vernooij [Tue, 21 Oct 2008 15:19:23 +0000 (17:19 +0200)]
Merge branch 'selftest' of git://git.samba.org/jelmer/samba

15 years agoMerge branch 'master' of git://git.samba.org/samba
Jelmer Vernooij [Tue, 21 Oct 2008 14:58:35 +0000 (16:58 +0200)]
Merge branch 'master' of git://git.samba.org/samba

15 years agoSilence undefined variable warnings.
Jelmer Vernooij [Tue, 21 Oct 2008 14:45:09 +0000 (16:45 +0200)]
Silence undefined variable warnings.

15 years agoRemove unused global variables.
Jelmer Vernooij [Tue, 21 Oct 2008 14:33:25 +0000 (16:33 +0200)]
Remove unused global variables.

15 years agoAutomatically enable merged build (for more complete 'make test') when possible durin...
Jelmer Vernooij [Tue, 21 Oct 2008 14:04:54 +0000 (16:04 +0200)]
Automatically enable merged build (for more complete 'make test') when possible during developer builds.

15 years agoRemove duplicate searching of Samba 4 directory for tags.
Jelmer Vernooij [Tue, 21 Oct 2008 14:03:45 +0000 (16:03 +0200)]
Remove duplicate searching of Samba 4 directory for tags.

15 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba into regsrv
Jelmer Vernooij [Tue, 21 Oct 2008 13:53:28 +0000 (15:53 +0200)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba into regsrv

15 years agoFix double free.
Jelmer Vernooij [Tue, 21 Oct 2008 13:51:04 +0000 (15:51 +0200)]
Fix double free.

15 years agoFix the build.
Jelmer Vernooij [Tue, 21 Oct 2008 13:47:34 +0000 (15:47 +0200)]
Fix the build.

15 years agoFix two trivial typos
Volker Lendecke [Tue, 21 Oct 2008 13:27:48 +0000 (15:27 +0200)]
Fix two trivial typos

15 years agoCreate a function out of pam_sm_close_session to delete the credentials.
Andreas Schneider [Mon, 20 Oct 2008 14:30:45 +0000 (16:30 +0200)]
Create a function out of pam_sm_close_session to delete the credentials.

This is the way the creds should be deleted. Now we have back a
close_session function which can be used for other things.

15 years agoDelete the krb5 ccname variable from the PAM environment if set.
Andreas Schneider [Mon, 20 Oct 2008 12:54:11 +0000 (14:54 +0200)]
Delete the krb5 ccname variable from the PAM environment if set.

If winbind sets the KRB5CCNAME variable it should unset it when
the cache gets destroyed.

15 years agoSet the right return value if wbc_status is set to an error.
Andreas Schneider [Mon, 20 Oct 2008 12:51:00 +0000 (14:51 +0200)]
Set the right return value if wbc_status is set to an error.

15 years agoRevert "Registry server LDB backend: Don't make copies of the same type"
Jelmer Vernooij [Tue, 21 Oct 2008 12:57:41 +0000 (14:57 +0200)]
Revert "Registry server LDB backend: Don't make copies of the same type"

The original data pointer may go away so we do want to make copies in
this case.

This reverts commit 625359b2e266105022309df8985720108ecd6f67.

15 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba into regsrv
Jelmer Vernooij [Tue, 21 Oct 2008 12:51:13 +0000 (14:51 +0200)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba into regsrv

Conflicts:
source4/lib/registry/ldb.c
source4/rpc_server/winreg/rpc_winreg.c

15 years agoRegistry server LDB backend: Don't make copies of the same type
Matthias Dieter Wallnöfer [Fri, 19 Sep 2008 10:48:15 +0000 (12:48 +0200)]
Registry server LDB backend: Don't make copies of the same type

15 years agoRegistry server LDB backend REG_BINARY type: Save it directly in LDB
Matthias Dieter Wallnöfer [Fri, 19 Sep 2008 10:39:53 +0000 (12:39 +0200)]
Registry server LDB backend REG_BINARY type: Save it directly in LDB

With this patch the REG_BINARY type is saved directly in a LDB registry database rather than converted in a hex-string.

15 years agoRegistry RPC server: Reintroduce the "key" variable for better readability
Matthias Dieter Wallnöfer [Fri, 19 Sep 2008 10:29:38 +0000 (12:29 +0200)]
Registry RPC server: Reintroduce the "key" variable for better readability

The "key" variable points to our working key in the hive (h->data).

15 years agoRegistry server LDB backend REG_SZ type: Always use UTF8 encoding
Matthias Dieter Wallnöfer [Thu, 18 Sep 2008 17:52:52 +0000 (19:52 +0200)]
Registry server LDB backend REG_SZ type: Always use UTF8 encoding

We should save data OS independent in the LDB files.

15 years agoRegistry server LDB backend REG_SZ type: Fix up the empty string problem
Matthias Dieter Wallnöfer [Thu, 18 Sep 2008 14:51:48 +0000 (16:51 +0200)]
Registry server LDB backend REG_SZ type: Fix up the empty string problem

This fixes up the empty string problem in a better way without the need of changing the character conversion code.

15 years agoRevert "Fix for the empty string (REG_SZ) problem"
Matthias Dieter Wallnöfer [Thu, 18 Sep 2008 14:15:05 +0000 (16:15 +0200)]
Revert "Fix for the empty string (REG_SZ) problem"

This reverts commit d994520885301f1dfd04363bab05c9238ce5ae05.
This shouldn't be fixed in the general character conversion library but directly in the registry library.

15 years agoRegistry server: Fixes up the patch with "type" != NULL (used in "EnumValue" and...
Matthias Dieter Wallnöfer [Mon, 15 Sep 2008 17:21:38 +0000 (19:21 +0200)]
Registry server: Fixes up the patch with "type" != NULL (used in "EnumValue" and "QueryValue")

This prevents the server to segfault if the input data type is NULL.

15 years agoRevert "Registry server: Enhances commit "type" != NULL (when getting values)"
Matthias Dieter Wallnöfer [Mon, 15 Sep 2008 17:14:31 +0000 (19:14 +0200)]
Revert "Registry server: Enhances commit "type" != NULL (when getting values)"

This reverts commit 32d00f5e2c5a67dac806ee07f030f3ac2ad108f9.
This patch hasn't been right. Repost it in the right way.

15 years agoRegistry server: Enhances commit "type" != NULL (when getting values)
Matthias Dieter Wallnöfer [Mon, 15 Sep 2008 16:28:11 +0000 (18:28 +0200)]
Registry server: Enhances commit "type" != NULL (when getting values)

15 years agoRegistry server "reg_ldb_unpack_value": Tests demonstrate that also "type" doesn...
Matthias Dieter Wallnöfer [Mon, 15 Sep 2008 16:21:45 +0000 (18:21 +0200)]
Registry server "reg_ldb_unpack_value": Tests demonstrate that also "type" doesn't has to be NULL

15 years agoRevert "Registry server "reg_ldb_unpack_value": Let "data" pointer be NULL"
Matthias Dieter Wallnöfer [Mon, 15 Sep 2008 15:21:35 +0000 (17:21 +0200)]
Revert "Registry server "reg_ldb_unpack_value": Let "data" pointer be NULL"

This reverts commit 82f50ea69f3aece4ac654ffdfa627babd8aadc25.
Cause: Windows (2000) doesn't accept the "data" pointer set to NULL

15 years agoRegistry server "reg_ldb_unpack_value": Let "data" pointer be NULL
Matthias Dieter Wallnöfer [Mon, 15 Sep 2008 13:13:25 +0000 (15:13 +0200)]
Registry server "reg_ldb_unpack_value": Let "data" pointer be NULL

Prevent segfaults in some client applications (e.g. regdiff)