14 years agor25060: Fix formatting, remove trailing spaces and cut lines longer than 80 chars
Simo Sorce [Mon, 10 Sep 2007 16:56:51 +0000 (16:56 +0000)]
r25060: Fix formatting, remove trailing spaces and cut lines longer than 80 chars
(This used to be commit 7a4d4658904a601ae42ec1804db06cda734553d2)

14 years agor25059: Apply to 3.2 as well
Simo Sorce [Mon, 10 Sep 2007 16:21:55 +0000 (16:21 +0000)]
r25059: Apply to 3.2 as well
(This used to be commit 17a7d33b3bede85d6d64ecadfa065e71739517be)

14 years agor25057: Add a schema file ready to be used in Fedora/RedHat Directory Server
Simo Sorce [Mon, 10 Sep 2007 15:14:39 +0000 (15:14 +0000)]
r25057: Add a schema file ready to be used in Fedora/RedHat Directory Server
(This used to be commit 501e8b6c79afdefb9955b92e5c25dbe1033ab518)

14 years agor25055: Add file_id_string_tos
Volker Lendecke [Mon, 10 Sep 2007 10:56:07 +0000 (10:56 +0000)]
r25055: Add file_id_string_tos

This removes file_id_string_static and file_id_string_static2
(This used to be commit 638c848c9afe374feb30e34c494f89b2a6c64f7b)

14 years agor25049: Set new, more secure defaults for Samba 3.2.
Andrew Bartlett [Mon, 10 Sep 2007 02:14:18 +0000 (02:14 +0000)]
r25049: Set new, more secure defaults for Samba 3.2.

Andrew Bartlett
(This used to be commit 87d39f61b498c1327c2b3a818e41bb6451fe7518)

14 years agor25040: Add "net sam rights"
Volker Lendecke [Sat, 8 Sep 2007 20:30:51 +0000 (20:30 +0000)]
r25040: Add "net sam rights"

Not strictly in the SAM, but close enough. This command acts directly on
the local tdb, no running smbd required

This also changes the root-only check to a warning
(This used to be commit 0c5657b5eff60e3c52de8fbb4ce9346d0341854c)

14 years agor25036: Fix a become/unbecome_root() pair
Volker Lendecke [Sat, 8 Sep 2007 17:08:59 +0000 (17:08 +0000)]
r25036: Fix a become/unbecome_root() pair
(This used to be commit 9e53f50e9489a5f6cfa40eed59be39e8a294db7d)

14 years agor25032: Contact an off site DC if non is available on site.
Lars Müller [Sat, 8 Sep 2007 14:56:11 +0000 (14:56 +0000)]
r25032: Contact an off site DC if non is available on site.
(This used to be commit 50879e6de5101b6c5ab8b3fb954f1d2a48530716)

14 years agor25030: ip_srv_nonsite and count_nonsite are initialized in get_kdc_list() in any
Lars Müller [Sat, 8 Sep 2007 13:53:08 +0000 (13:53 +0000)]
r25030: ip_srv_nonsite and count_nonsite are initialized in get_kdc_list() in any
(This used to be commit 287604a1c7dc7dede4b278de92ad8233f597d0b6)

14 years agor25025: Remove an unused function
Volker Lendecke [Sat, 8 Sep 2007 10:30:11 +0000 (10:30 +0000)]
r25025: Remove an unused function
(This used to be commit 858f7b7d786ca352ffebb56b9fda40c636acef74)

14 years agor25024: Fix a whole bunch of Coverity bugs
Volker Lendecke [Sat, 8 Sep 2007 09:15:08 +0000 (09:15 +0000)]
r25024: Fix a whole bunch of Coverity bugs

The callers of get_domain_group_from_sid() with some justification
expected map->gid to be initialized when get_domain_group_from_sid
returned True.
(This used to be commit bc8b74dbfec965ede7bf45118d1a863b28d000fd)

14 years agor25023: Coverity #455. Not actually a bug, but this clarifies
Jeremy Allison [Sat, 8 Sep 2007 05:35:10 +0000 (05:35 +0000)]
r25023: Coverity #455. Not actually a bug, but this clarifies
the code a lot.
(This used to be commit 5ba12eefbed209a8a6b474da479efd190f91638e)

14 years agor25022: Fix coverity #395. Resource leak on error.
Jeremy Allison [Sat, 8 Sep 2007 05:18:08 +0000 (05:18 +0000)]
r25022: Fix coverity #395. Resource leak on error.
(This used to be commit 6a237600b825f4df2241277bdd80e98669f69685)

14 years agor25021: Fix coverity #435. Use of -1.
Jeremy Allison [Sat, 8 Sep 2007 05:12:17 +0000 (05:12 +0000)]
r25021: Fix coverity #435. Use of -1.
(This used to be commit f789186086b55a81c52e05d1f8c97c33b69131bd)

14 years agor25020: Fix coverity #374, possible null deref.
Jeremy Allison [Sat, 8 Sep 2007 04:57:17 +0000 (04:57 +0000)]
r25020: Fix coverity #374, possible null deref.
(This used to be commit 82b3656b4b26ff63d894eed975d73ef3c8b5d2b2)

14 years agor25019: Fix coverity bug #105, run #332. Use of uninitialized variable.
Jeremy Allison [Sat, 8 Sep 2007 04:45:59 +0000 (04:45 +0000)]
r25019: Fix coverity bug #105, run #332. Use of uninitialized variable.
(This used to be commit a58de8cee51c1396a2607ee743c92d58d7703547)

14 years agor25011: We don't use mangle_map any more.
Jeremy Allison [Fri, 7 Sep 2007 22:54:43 +0000 (22:54 +0000)]
r25011: We don't use mangle_map any more.
(This used to be commit 2e0999c1df33c192fee5f739070a0e4c3d22dff8)

14 years agor25009: Large patch discussed with Volker. Move unix_convert to a talloc-based
Jeremy Allison [Fri, 7 Sep 2007 20:57:01 +0000 (20:57 +0000)]
r25009: Large patch discussed with Volker. Move unix_convert to a talloc-based
interface. More development will come on top of this. Remove the
"mangled map" parameter.
(This used to be commit dee8beba7a92b8a3f68bbcc59fd0a827f68c7736)

14 years agor25002: Refactor out code duplication created by the previous
Michael Adam [Fri, 7 Sep 2007 15:45:39 +0000 (15:45 +0000)]
r25002: Refactor out code duplication created by the previous
unification of r24998.

(This used to be commit 6026d132537f2fb2a963fa54377a926fa99eeb35)

14 years agor24999: Use the new regval_compose() function in regval_ctr_addvalue().
Michael Adam [Fri, 7 Sep 2007 14:54:30 +0000 (14:54 +0000)]
r24999: Use the new regval_compose() function in regval_ctr_addvalue().

(This used to be commit dab9ffe602eaca478a73f3b882f543629ce3001e)

14 years agor24998: Add a function regval_compose() to compose a REGISTRY_VALUE from
Michael Adam [Fri, 7 Sep 2007 14:41:49 +0000 (14:41 +0000)]
r24998: Add a function regval_compose() to compose a REGISTRY_VALUE from
input data. Use this function in a first step to refactor
the canonicalization code of smbconf_store_values().

(This used to be commit f4caa2d7d412e2b9bb2a1ce71514551569ccf373)

14 years agor24996: Eliminate more trailing spaces...
Michael Adam [Fri, 7 Sep 2007 13:54:56 +0000 (13:54 +0000)]
r24996: Eliminate more trailing spaces...
(This used to be commit 1ee1b75113c7035c8882fe53981dba7cfc3aa187)

14 years agor24993: Apply some const
Volker Lendecke [Fri, 7 Sep 2007 12:13:16 +0000 (12:13 +0000)]
r24993: Apply some const
(This used to be commit 613b9fcd18bcc29bf5313e2287b53b8de430d17e)

14 years agor24991: Kill all those lots of trailing whitespaces from secrets.c.
Michael Adam [Fri, 7 Sep 2007 09:14:44 +0000 (09:14 +0000)]
r24991: Kill all those lots of trailing whitespaces from secrets.c.
These red bars in vi really hurt my eyes... :-o

(This used to be commit 2e99e141c3254fe072756697b8db3cbd4e4f1db4)

14 years agor24990: Kill an incredible amount of trailing whitespaces...
Michael Adam [Fri, 7 Sep 2007 08:54:48 +0000 (08:54 +0000)]
r24990: Kill an incredible amount of trailing whitespaces...
Further reformat get_trust_pw to conform to coding rules.

(This used to be commit b9e76a479e933084b1ee081ef5d8bd6bdbd7fadf)

14 years agor24981: - Use the formal syntax for calling functions through pointers. I've wanted
Derrell Lipman [Thu, 6 Sep 2007 13:21:31 +0000 (13:21 +0000)]
r24981: - Use the formal syntax for calling functions through pointers.  I've wanted
  to make this change for ages, but now with the issue of "open" requiring it,
  this is the time to just do all of them.

(This used to be commit e746aaaf4db7099252ef048da7857bd488cb681f)

14 years agor24978: move domain_init_recv() near the functions that uses it
Stefan Metzmacher [Thu, 6 Sep 2007 11:08:44 +0000 (11:08 +0000)]
r24978: move domain_init_recv() near the functions that uses it

(This used to be commit 18e830a935d4712bfbff54f94b531e30cea8a1f9)

14 years agor24977: Ensure negative caching for name2sid, sid2name and rids2names
Rafal Szczesniak [Thu, 6 Sep 2007 11:07:58 +0000 (11:07 +0000)]
r24977: Ensure negative caching for name2sid, sid2name and rids2names

(This used to be commit 3a9b5eabf97e892e761184da37465d850b5d774c)

14 years agor24974: catch SIGINT and SIGQUIT like SIGTERM
Stefan Metzmacher [Thu, 6 Sep 2007 10:51:17 +0000 (10:51 +0000)]
r24974: catch SIGINT and SIGQUIT like SIGTERM

(This used to be commit ab15f5c3e72df6272db9a4431f720f604fcf40f2)

14 years agor24970: Polish some comments and add my (C).
Michael Adam [Wed, 5 Sep 2007 16:01:27 +0000 (16:01 +0000)]
r24970: Polish some comments and add my (C).

(This used to be commit aa043bb446ec8ab90a8e61c590be8d33b6a2d42d)

14 years agor24969: Fwd port "open" patch
Simo Sorce [Wed, 5 Sep 2007 12:53:56 +0000 (12:53 +0000)]
r24969: Fwd port "open" patch
(This used to be commit 113d62682ae8b045ff0132a743a32f3bc4856d54)

14 years agor24955: Reformat some object lists in to minimize the diff.
Michael Adam [Tue, 4 Sep 2007 14:54:00 +0000 (14:54 +0000)]
r24955: Reformat some object lists in to minimize the diff.
(This used to be commit 5d94c3dab2dfab68f170e18e6af9374026f6f194)

14 years agor24954: Fix the build without krb5.
Günther Deschner [Tue, 4 Sep 2007 14:32:28 +0000 (14:32 +0000)]
r24954: Fix the build without krb5.

(This used to be commit 9df961914c3119eb6b20ecdc05d963480dea3521)

14 years agor24952: Set the kdc locator env vars. This makes the krb5 locator plugin fully
Günther Deschner [Tue, 4 Sep 2007 14:06:33 +0000 (14:06 +0000)]
r24952: Set the kdc locator env vars. This makes the krb5 locator plugin fully
operational (from within winbindd and outside).

(This used to be commit 800645d5388d7df1f8cf31b4218bfc7dd5b4d12a)

14 years agor24951: Warn if "os level" > 255
Volker Lendecke [Tue, 4 Sep 2007 13:21:24 +0000 (13:21 +0000)]
r24951: Warn if "os level" > 255

Thanks to Karolin Seeger <>
(This used to be commit 3abf06efc1286090caf380eb685e90ba7f412748)

14 years agor24949: Remove some static buffers
Volker Lendecke [Tue, 4 Sep 2007 10:15:04 +0000 (10:15 +0000)]
r24949: Remove some static buffers
(This used to be commit df648d47ff3c4e24f439fda839653bda98323100)

14 years agor24943: Some stackframes
Volker Lendecke [Tue, 4 Sep 2007 05:39:06 +0000 (05:39 +0000)]
r24943: Some stackframes
(This used to be commit cddb9f11d5fafcd3797cb242775c37f0c04d4f15)

14 years agor24920: Reformatting.
Günther Deschner [Mon, 3 Sep 2007 12:23:45 +0000 (12:23 +0000)]
r24920: Reformatting.

(This used to be commit 62426a055513c309a381d0d96d60edc07e6dfcdf)

14 years agor24903: One more tick in #if 0 code
Volker Lendecke [Sun, 2 Sep 2007 17:50:05 +0000 (17:50 +0000)]
r24903: One more tick in #if 0 code
(This used to be commit e0b4fb55e3176785a85d66efece15d0a366a35f1)

14 years agor24902: DEBUG might use talloc_tos() itself...
Volker Lendecke [Sun, 2 Sep 2007 17:48:01 +0000 (17:48 +0000)]
r24902: DEBUG might use talloc_tos() itself...
(This used to be commit 1b39374a173bf6b40426000d010d092e94afc4d7)

14 years agor24879: Activate the winbindd cache-validation message handler.
Michael Adam [Sun, 2 Sep 2007 00:32:57 +0000 (00:32 +0000)]
r24879: Activate the winbindd cache-validation message handler.
Now the winbindd cache can be checked at runtime by
calling "smbcontrol winbindd validate-cache".

For the execution of the validation code, I fork a child
and in the child restore the default SIGCHLD handler in
order for the fork/waitpid mechanism of tdb_validate to work.

(This used to be commit f379a5c47d5004a5a66b6c12ec119c739b9e146d)

14 years agor24877: Don't panic in tdb validation code when the fork or waitpid fails.
Michael Adam [Sun, 2 Sep 2007 00:23:02 +0000 (00:23 +0000)]
r24877: Don't panic in tdb validation code when the fork or waitpid fails.
Return error instead.

(This used to be commit 9b25355dd66519afd548fecbf2da7608b024a35b)

14 years agor24864: - Correct failure of libsmbclient against a version of Windows found on a NAS
Derrell Lipman [Sat, 1 Sep 2007 18:34:50 +0000 (18:34 +0000)]
r24864: - Correct failure of libsmbclient against a version of Windows found on a NAS
  device.  The device resets a NBT connection on port 139 when it receives a
  NetBIOS keepalive request.  That request should be supported when NetBIOS is
  in use; Windows is behaving badly.

  libsmbclient needs a way to determine if a connection is still alive, and
  was using a NetBIOS keepalive request if port 139 was in use (on the
  assumption that it was probably NBT), and getpeername() when port 139 was
  not being used (assuming naked transport).

  This patch simplifies the code by exclusively using getpeername() to check
  whether a connection is still alive.  The NetBIOS keepalive request is
  optional anyway (with preference being given to using TCP mechanisms for the
  same purpose), so this should be both simpler and more reliable.

(This used to be commit 1f122352b02e3f4be9ac2d638b18807dafd05429)

14 years agor24853: Rename function as Jerry asked.
Rafal Szczesniak [Fri, 31 Aug 2007 21:25:53 +0000 (21:25 +0000)]
r24853: Rename function as Jerry asked.

(This used to be commit 86af9fedad71697f22cc739518340f7753b8f9da)

14 years agor24848: Make tdb_validate() take an open tdb handle instead of a file name.
Michael Adam [Fri, 31 Aug 2007 16:30:40 +0000 (16:30 +0000)]
r24848: Make tdb_validate() take an open tdb handle instead of a file name.
A new wrapper tdb_validate_open() takes a filename an opens and closes
the tdb before and after calling tdb_validate() respectively.

winbindd_validata_cache_nobackup() now dynamically calls one of
the above functions depending on whether the cache tdb has already
been opened or not.

(This used to be commit dc0b08e6590caa4974fd4d9f34f39f261d1f1dee)

14 years agor24847: Change standard failure return code of tdb_validate from "-1" to "1".
Michael Adam [Fri, 31 Aug 2007 15:51:05 +0000 (15:51 +0000)]
r24847: Change standard failure return code of tdb_validate from "-1" to "1".
(This is more safely used with casts from int to uint8, e.g.)

(This used to be commit cb3583b39212688a627a29bbddb2e98497714d42)

14 years agor24845: Fix a segfault in smbcontrol when called with parameters but no extra args.
Michael Adam [Fri, 31 Aug 2007 15:34:26 +0000 (15:34 +0000)]
r24845: Fix a segfault in smbcontrol when called with parameters but no extra args.

(This used to be commit f1bbf9bc18fc615a5660674f8346b4a7bed50044)

14 years agor24843: Add a "validate-cache" control message to winbindd.
Michael Adam [Fri, 31 Aug 2007 15:24:43 +0000 (15:24 +0000)]
r24843: Add a "validate-cache" control message to winbindd.
So there is a new subcommand "smbcontrol winbindd validate-cache" now.

This change provides the infrastructure:
The function currently returns "true" unconditionally.
The call of a real cache validation function will be incorporated
in subsequent changes.

(This used to be commit ef92d505c04397614cb0dd5ede967e9017a5e302)

14 years agor24842: Fix build warning.
Günther Deschner [Fri, 31 Aug 2007 15:01:50 +0000 (15:01 +0000)]
r24842: Fix build warning.

(This used to be commit 205ef6ab3e9332a2a4a4f775c2cdddbcd3ec739d)

14 years agor24841: The locator has no dependencies to ldap libs anymore. Also fix the build.
Günther Deschner [Fri, 31 Aug 2007 14:58:26 +0000 (14:58 +0000)]
r24841: The locator has no dependencies to ldap libs anymore. Also fix the build.

(This used to be commit ce7c816083db6fc844b936a14dd593fe1ef07374)

14 years agor24838: Now for real: build the locator, if we can.
Günther Deschner [Fri, 31 Aug 2007 13:51:02 +0000 (13:51 +0000)]
r24838: Now for real: build the locator, if we can.

(This used to be commit 28f9b8d98dabd9ba8e812ca01bcf4fc192fb5e44)

14 years agor24836: Initialize some uninitialized variables.
Michael Adam [Fri, 31 Aug 2007 13:39:51 +0000 (13:39 +0000)]
r24836: Initialize some uninitialized variables.
This prevents a segfault when get_kdc_ip_string() is called
with sitename == NULL.

(This used to be commit 58d31e057b57bc69a96e63aabba9aa1da5418d83)

14 years agor24833: Move locator to nsswitch (does not belong to libads anymore).
Günther Deschner [Fri, 31 Aug 2007 12:21:18 +0000 (12:21 +0000)]
r24833: Move locator to nsswitch (does not belong to libads anymore).

(This used to be commit af90c6949c929c82d4390b2f87a420bd598275dd)

14 years agor24832: In the winbind-locator recursion case, try to pick up the kdc from the
Günther Deschner [Fri, 31 Aug 2007 12:18:21 +0000 (12:18 +0000)]
r24832: In the winbind-locator recursion case, try to pick up the kdc from the

(This used to be commit 7f42fe4e08c0899f5e8addbc5135d87af193ee68)

14 years agor24830: Add a winbindd cache validation function that does not do
Michael Adam [Fri, 31 Aug 2007 10:47:42 +0000 (10:47 +0000)]
r24830: Add a winbindd cache validation function that does not do
backup and corrupt file handling. (To be used in subsequent
(This used to be commit b3dcadbed0b4a1b7bb2e83df2c66bca9dcbcad60)

14 years agor24829: Make use of a variable, that is available... :-)
Michael Adam [Fri, 31 Aug 2007 10:30:14 +0000 (10:30 +0000)]
r24829: Make use of a variable, that is available... :-)
(This used to be commit 90626652084c2ada6b2eb041db652720c03a1c3b)

14 years agor24828: Give smbcontrol an initial talloc stackframe.
Michael Adam [Fri, 31 Aug 2007 10:06:37 +0000 (10:06 +0000)]
r24828: Give smbcontrol an initial talloc stackframe.
(This used to be commit 55020b07b5568104091352fd3ae21e2b29e34501)

14 years agor24827: Give smbstatus an initial talloc stackframe.
Michael Adam [Fri, 31 Aug 2007 09:54:30 +0000 (09:54 +0000)]
r24827: Give smbstatus an initial talloc stackframe.
Rewrite main() so as to exit only at a single point
where the stack frame is freed, too.

(This used to be commit dbe38995ec6d2251562a3b10e750bbd681008e16)

14 years agor24826: Fix two memleaks in idmap_cache.c, bug 4917
Volker Lendecke [Fri, 31 Aug 2007 09:39:11 +0000 (09:39 +0000)]
r24826: Fix two memleaks in idmap_cache.c, bug 4917

Thanks again to Patrick Rynhart for persisting :-)

Simo, please check!
(This used to be commit 0a9171f9efc2322954c0d06757b91d9124ab8a8e)

14 years agor24825: Give testparm an initial talloc stackframe, so it does not complain
Michael Adam [Fri, 31 Aug 2007 09:15:57 +0000 (09:15 +0000)]
r24825: Give testparm an initial talloc stackframe, so it does not complain
it is leaking.
(This used to be commit 705336ee1098a2c4d6e933dfa3e2f2968fa717ad)

14 years agor24824: Create an initial talloc stackframe for the net binary.
Michael Adam [Fri, 31 Aug 2007 09:10:54 +0000 (09:10 +0000)]
r24824: Create an initial talloc stackframe for the net binary.
(This used to be commit c97600b96f6315df8ab0d7ad186423ab75dd4ab5)

14 years agor24813: Reformat to 80 columns.
Jeremy Allison [Thu, 30 Aug 2007 23:07:10 +0000 (23:07 +0000)]
r24813: Reformat to 80 columns.
(This used to be commit c6c8f5a897602d53876fe75e86283d97a394037d)

14 years agor24811: Simple reformatting to fit the 80 columns rule.
Jeremy Allison [Thu, 30 Aug 2007 21:46:42 +0000 (21:46 +0000)]
r24811: Simple reformatting to fit the 80 columns rule.
(This used to be commit 0cdf046dae8ba0741bb7786aa4e85c34fc35dade)

14 years agor24809: Consolidate the use of temporary talloc contexts.
Volker Lendecke [Thu, 30 Aug 2007 19:48:31 +0000 (19:48 +0000)]
r24809: Consolidate the use of temporary talloc contexts.

This adds the two functions talloc_stackframe() and talloc_tos().

 * When a new talloc stackframe is allocated with talloc_stackframe(), then
 * the TALLOC_CTX returned with talloc_tos() is reset to that new
 * frame. Whenever that stack frame is TALLOC_FREE()'ed, then the reverse
 * happens: The previous talloc_tos() is restored.
 * This API is designed to be robust in the sense that if someone forgets to
 * TALLOC_FREE() a stackframe, then the next outer one correctly cleans up and
 * resets the talloc_tos().

The original motivation for this patch was to get rid of the
sid_string_static & friends buffers. Explicitly passing talloc context
everywhere clutters code too much for my taste, so an implicit
talloc_tos() is introduced here. Many of these static buffers are
replaced by a single static pointer.

The intended use would thus be that low-level functions can rather
freely push stuff to talloc_tos, the upper layers clean up by freeing
the stackframe. The more of these stackframes are used and correctly
freed the more exact the memory cleanup happens.

This patch removes the main_loop_talloc_ctx, tmp_talloc_ctx and
lp_talloc_ctx (did I forget any?)

So, never do a

tmp_ctx = talloc_init("foo");

anymore, instead, use

tmp_ctx = talloc_stackframe()


(This used to be commit 6585ea2cb7f417e14540495b9c7380fe9c8c717b)

14 years agor24808: Fix the same problem Volker noticed.
Jeremy Allison [Thu, 30 Aug 2007 17:34:47 +0000 (17:34 +0000)]
r24808: Fix the same problem Volker noticed.

For some funny reason us4/gcc seems to fall over the '

(This used to be commit 229e02d732c1612c7dc4510325da1dcf50050a95)

14 years agor24807: Add WINBINDD_LOCATOR_KDC_ADDRESS env which will be used for the case when the
Günther Deschner [Thu, 30 Aug 2007 16:24:51 +0000 (16:24 +0000)]
r24807: Add WINBINDD_LOCATOR_KDC_ADDRESS env which will be used for the case when the
locator gets called from within winbindd.

(This used to be commit 46dbd6034ec2c6475f428cd2d5cce56268bc34a7)

14 years agor24806: Fix the build, sorry...
Günther Deschner [Thu, 30 Aug 2007 16:02:22 +0000 (16:02 +0000)]
r24806: Fix the build, sorry...

(This used to be commit cd1fccaf8f2ad6e6e4c51909aa7a925efc0a13c4)

14 years agor24805: When we can build the locator, build it.
Günther Deschner [Thu, 30 Aug 2007 15:55:59 +0000 (15:55 +0000)]
r24805: When we can build the locator, build it.

(This used to be commit 91d10fe1598b92090a94286f84395caa1bdf7a41)

14 years agor24804: As a temporary workaround, also try to guess the server's principal in the
Günther Deschner [Thu, 30 Aug 2007 15:39:51 +0000 (15:39 +0000)]
r24804: As a temporary workaround, also try to guess the server's principal in the
"not_defined_in_RFC4178@please_ignore" case to make at least LDAP SASL binds
succeed with windows server 2008.

(This used to be commit f5b3de4d3069eaa750240e3422bac5cb169b6c0a)

14 years agor24803: For some funny reason us4/gcc seems to fall over the '
Volker Lendecke [Thu, 30 Aug 2007 14:55:32 +0000 (14:55 +0000)]
r24803: For some funny reason us4/gcc seems to fall over the '
(This used to be commit 08e309e955eea58df1eb88f848386eb2acbd31ba)

14 years agor24802: Activate new tests
Volker Lendecke [Thu, 30 Aug 2007 14:16:20 +0000 (14:16 +0000)]
r24802: Activate new tests

(This used to be commit 1f396cc237e3861b216d03a7af9e461578cf448a)

14 years agor24801: When told to ignore the winbind cache also do so while trying to store entries.
Günther Deschner [Thu, 30 Aug 2007 11:26:17 +0000 (11:26 +0000)]
r24801: When told to ignore the winbind cache also do so while trying to store entries.
Thanks Michael for pointing this out.

(This used to be commit c7047604446c3fc33b5e14833267ac8ad3a906b1)

14 years agor24799: Prefer IP address to dns name when replying in winbindd dsgetdcname.
Günther Deschner [Thu, 30 Aug 2007 09:52:21 +0000 (09:52 +0000)]
r24799: Prefer IP address to dns name when replying in winbindd dsgetdcname.

(This used to be commit e5cc09c72f4acc851ed53ca02def5d692000d0da)

14 years agor24797: Fix logic in dsgetdcname().
Günther Deschner [Thu, 30 Aug 2007 09:15:07 +0000 (09:15 +0000)]
r24797: Fix logic in dsgetdcname().

(This used to be commit aca2d78db139ed32bcedec9861e83cb8c42809cf)

14 years agor24791: Fix logic error in timeout of blocking lock processing found by
Jeremy Allison [Wed, 29 Aug 2007 20:49:09 +0000 (20:49 +0000)]
r24791: Fix logic error in timeout of blocking lock processing found by
Ronnie. If a lock timeout expires, we must check we can get the
lock before responding with failure. Volker is writing a torture test.
(This used to be commit 45380f356b99d575645873b05af17c504b091dc8)

14 years agor24789: Add implementation of machine-authenticated connection to netlogon
Rafal Szczesniak [Wed, 29 Aug 2007 19:55:13 +0000 (19:55 +0000)]
r24789: Add implementation of machine-authenticated connection to netlogon
pipe used when connecting to win2k and newer domain controllers. The
server may be configured to deny anonymous netlogon connections which
would stop domain join verification step. Still, winnt domains require
such smb sessions not to be authenticated using machine credentials.
Creds employed in smb session cannot have a username in upn form, so
provide the separate function to use machine account.

(This used to be commit 30d99d8ac3379caadc5bdb353977149d1ee16403)

14 years agor24788: Cleanup some linking msgs and remove references to libmsrpc
Gerald Carter [Wed, 29 Aug 2007 19:03:20 +0000 (19:03 +0000)]
r24788: Cleanup some linking msgs and remove references to libmsrpc
in SAMBA_3_2_0
(This used to be commit ba05dc013fd14a7c8c3d7775dad9a70d45289de0)

14 years agor24786: Fix another build warning.
Günther Deschner [Wed, 29 Aug 2007 14:50:04 +0000 (14:50 +0000)]
r24786: Fix another build warning.

(This used to be commit 29a56dcc78c49653bcf72dea6313fd4852de8f72)

14 years agor24785: Put checks in parentheses.
Günther Deschner [Wed, 29 Aug 2007 14:35:32 +0000 (14:35 +0000)]
r24785: Put checks in parentheses.

(This used to be commit d8197aca5a4a509d318124f708fe15c35a2b4e11)

14 years agor24784: Initialize uninitalized data to prevent segfaults.
Michael Adam [Wed, 29 Aug 2007 14:34:15 +0000 (14:34 +0000)]
r24784: Initialize uninitalized data to prevent segfaults.
Thanks to Volker for the hint!

(This used to be commit 3b7ed3ea881dc59b77a067d5d3738e9e03b6c538)

14 years agor24783: Remove unused off_t type.
Günther Deschner [Wed, 29 Aug 2007 14:08:29 +0000 (14:08 +0000)]
r24783: Remove unused off_t type.

(This used to be commit 85c816c27f2b9d20dfaf411b12ec1803a49574ce)

14 years agor24782: Fix C++ warnings
Volker Lendecke [Wed, 29 Aug 2007 13:56:52 +0000 (13:56 +0000)]
r24782: Fix C++ warnings
(This used to be commit f7e8df81ef9e1deadb1251e5e5959e90a4432f40)

14 years agor24781: Fix build warning.
Günther Deschner [Wed, 29 Aug 2007 13:52:07 +0000 (13:52 +0000)]
r24781: Fix build warning.

(This used to be commit 71307c371fea917b91214df7a24cd91170d40dd9)

14 years agor24778: Make sure krb5 locator requests go to a separate locator winbind child.
Günther Deschner [Wed, 29 Aug 2007 12:43:23 +0000 (12:43 +0000)]
r24778: Make sure krb5 locator requests go to a separate locator winbind child.

(This used to be commit fb9228b8d167552f0a046ab674f66d4e5b73f5b6)

14 years agor24776: Remove accidentially commited flag checks.
Günther Deschner [Wed, 29 Aug 2007 12:35:20 +0000 (12:35 +0000)]
r24776: Remove accidentially commited flag checks.

(This used to be commit 1efc5009a4b72a5a4c600ca3af7dc7cf05f74353)

14 years agor24773: Fix a ctdb connection lockup
Volker Lendecke [Wed, 29 Aug 2007 11:46:44 +0000 (11:46 +0000)]
r24773: Fix a ctdb connection lockup

The lockup could happen when packet_read_sync() gets two packets in a row, the
first one being an async message, and the second one being the response to a
ctdb request.

Also add some debug msg to ctdb_conn.c, and cut off the "locking key" messages
to only dump 20 hex chars at debug level 10. >10 will dump everything.
(This used to be commit 0a55880a240b619810371a19144dd0a75208adfe)

14 years agor24771: Use infolevel 25 to set the machine account's password (just like winxp).
Rafal Szczesniak [Wed, 29 Aug 2007 11:02:04 +0000 (11:02 +0000)]
r24771: Use infolevel 25 to set the machine account's password (just like winxp).
This correctly updates pwdLastSet field on win2k3 server.

(This used to be commit dd6d44c1665121cff9ccc2c09580169ca4d330b9)

14 years agor24769: Merge error handling for locator plugin.
Günther Deschner [Wed, 29 Aug 2007 10:12:43 +0000 (10:12 +0000)]
r24769: Merge error handling for locator plugin.

(This used to be commit b83626676ca37437e62b826923fbd1d985eb7ce6)

14 years agor24764: Fix second TALLOC_SIZE definition. Still watching the
Jeremy Allison [Wed, 29 Aug 2007 04:06:09 +0000 (04:06 +0000)]
r24764: Fix second TALLOC_SIZE definition. Still watching the
build farm to see I didn't stuff this up...
(This used to be commit 4ca43172d9feae92060ddefb76a97622bca32d1b)

14 years agor24762: Fix the build, missed TALLOC_SIZE -> talloc_named_const.
Jeremy Allison [Wed, 29 Aug 2007 01:48:46 +0000 (01:48 +0000)]
r24762: Fix the build, missed TALLOC_SIZE -> talloc_named_const.
(This used to be commit e2d924248ef4c8158e80bfffa5d734b9723112ce)

14 years agor24759: Comment out the _nonnull calls for 3.2.x, as agreed with tridge.
Jeremy Allison [Wed, 29 Aug 2007 01:23:31 +0000 (01:23 +0000)]
r24759: Comment out the _nonnull calls for 3.2.x, as agreed with tridge.
Leaving the commented out code for now, in case I need to re-test
some stuff.
(This used to be commit 343be0464342aac14a9592fd73a71b7589ba34d5)

14 years agor24752: Make sure to return properly when the locator is called from within winbindd.
Günther Deschner [Tue, 28 Aug 2007 16:39:03 +0000 (16:39 +0000)]
r24752: Make sure to return properly when the locator is called from within winbindd.

(This used to be commit 6cf7187e88b4d4c1dfe90fcab459e39a0dbd3a11)

14 years agor24750: Fix one more caller of name_resolve_bcast().
Michael Adam [Tue, 28 Aug 2007 15:38:03 +0000 (15:38 +0000)]
r24750: Fix one more caller of  name_resolve_bcast().

(This used to be commit 757b5c1bd7ff3d6bbf99753c1b617338ee837531)

14 years agor24749: Increase debuglevel.
Günther Deschner [Tue, 28 Aug 2007 15:31:42 +0000 (15:31 +0000)]
r24749: Increase debuglevel.

(This used to be commit d82c1638b8ada43cfcbf9f71586c4c6849902c7e)

14 years agor24748: Remove all dependencies to samba internals and convert the krb5 locator plugin
Günther Deschner [Tue, 28 Aug 2007 15:26:59 +0000 (15:26 +0000)]
r24748: Remove all dependencies to samba internals and convert the krb5 locator plugin
into a tiny winbindd DsGetDcName client. This still does not solve the case of
using the locator from within winbindd itself but at least gencache.tdb and
others are no longer corrupted.

(This used to be commit 908e7963b8b2dd9b149f526a53dbb5dc7662bbef)

14 years agor24747: Add WINBINDD_DSGETDCNAME call.
Günther Deschner [Tue, 28 Aug 2007 15:20:54 +0000 (15:20 +0000)]

(This used to be commit 429496a4ccb5c4f4eda11f1b522629889b972c71)

14 years agor24746: As the winbindd pipe is officially broken since a while: split out request
Günther Deschner [Tue, 28 Aug 2007 15:16:42 +0000 (15:16 +0000)]
r24746: As the winbindd pipe is officially broken since a while: split out request
specfic and generic flags in a winbindd_request.

It turns out that the WBFLAG_RECURSE flag is the only non-PAM specific flag we
put into the "flags" field of a winbind request anyway. Now each request
command can use the entire space of the "flags" field.

(This used to be commit 18b29763d1ea0e9198f45bafa460dd68cb69a3d5)

14 years agor24745: Merge Simo's shared lib build fix from svn r22842 that was lost
Gerald Carter [Tue, 28 Aug 2007 15:12:11 +0000 (15:12 +0000)]
r24745: Merge Simo's shared lib build fix from svn r22842 that was lost
somehow.  Don't include the PIE_FLAGS when building shared libs.
(This used to be commit 22f2f1e033a7a6877c6b8a0847179728a408af85)

14 years agor24744: Increase length by what we got from recv, not from ioctl
Volker Lendecke [Tue, 28 Aug 2007 15:09:47 +0000 (15:09 +0000)]
r24744: Increase length by what we got from recv, not from ioctl
(This used to be commit 23c8f4f74bfb761894034ce9375258411c80d74d)

14 years agor24743: Fix build warning.
Günther Deschner [Tue, 28 Aug 2007 15:07:13 +0000 (15:07 +0000)]
r24743: Fix build warning.

(This used to be commit 579fb55b7556dc90b42f77d5fc9e9c31f34974e5)