Jelmer Vernooij [Tue, 21 Oct 2008 14:58:35 +0000 (16:58 +0200)]
Merge branch 'master' of git://git.samba.org/samba
Jelmer Vernooij [Tue, 21 Oct 2008 14:45:09 +0000 (16:45 +0200)]
Silence undefined variable warnings.
Jelmer Vernooij [Tue, 21 Oct 2008 14:33:25 +0000 (16:33 +0200)]
Remove unused global variables.
Jelmer Vernooij [Tue, 21 Oct 2008 14:04:54 +0000 (16:04 +0200)]
Automatically enable merged build (for more complete 'make test') when possible during developer builds.
Jelmer Vernooij [Tue, 21 Oct 2008 14:03:45 +0000 (16:03 +0200)]
Remove duplicate searching of Samba 4 directory for tags.
Jelmer Vernooij [Tue, 21 Oct 2008 13:53:28 +0000 (15:53 +0200)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba into regsrv
Jelmer Vernooij [Tue, 21 Oct 2008 13:51:04 +0000 (15:51 +0200)]
Fix double free.
Jelmer Vernooij [Tue, 21 Oct 2008 13:47:34 +0000 (15:47 +0200)]
Fix the build.
Volker Lendecke [Tue, 21 Oct 2008 13:27:48 +0000 (15:27 +0200)]
Fix two trivial typos
Andreas Schneider [Mon, 20 Oct 2008 14:30:45 +0000 (16:30 +0200)]
Create a function out of pam_sm_close_session to delete the credentials.
This is the way the creds should be deleted. Now we have back a
close_session function which can be used for other things.
Andreas Schneider [Mon, 20 Oct 2008 12:54:11 +0000 (14:54 +0200)]
Delete the krb5 ccname variable from the PAM environment if set.
If winbind sets the KRB5CCNAME variable it should unset it when
the cache gets destroyed.
Andreas Schneider [Mon, 20 Oct 2008 12:51:00 +0000 (14:51 +0200)]
Set the right return value if wbc_status is set to an error.
Jelmer Vernooij [Tue, 21 Oct 2008 12:57:41 +0000 (14:57 +0200)]
Revert "Registry server LDB backend: Don't make copies of the same type"
The original data pointer may go away so we do want to make copies in
this case.
This reverts commit
625359b2e266105022309df8985720108ecd6f67.
Jelmer Vernooij [Tue, 21 Oct 2008 12:51:13 +0000 (14:51 +0200)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba into regsrv
Conflicts:
source4/lib/registry/ldb.c
source4/rpc_server/winreg/rpc_winreg.c
Matthias Dieter Wallnöfer [Fri, 19 Sep 2008 10:48:15 +0000 (12:48 +0200)]
Registry server LDB backend: Don't make copies of the same type
Matthias Dieter Wallnöfer [Fri, 19 Sep 2008 10:39:53 +0000 (12:39 +0200)]
Registry server LDB backend REG_BINARY type: Save it directly in LDB
With this patch the REG_BINARY type is saved directly in a LDB registry database rather than converted in a hex-string.
Matthias Dieter Wallnöfer [Fri, 19 Sep 2008 10:29:38 +0000 (12:29 +0200)]
Registry RPC server: Reintroduce the "key" variable for better readability
The "key" variable points to our working key in the hive (h->data).
Matthias Dieter Wallnöfer [Thu, 18 Sep 2008 17:52:52 +0000 (19:52 +0200)]
Registry server LDB backend REG_SZ type: Always use UTF8 encoding
We should save data OS independent in the LDB files.
Matthias Dieter Wallnöfer [Thu, 18 Sep 2008 14:51:48 +0000 (16:51 +0200)]
Registry server LDB backend REG_SZ type: Fix up the empty string problem
This fixes up the empty string problem in a better way without the need of changing the character conversion code.
Matthias Dieter Wallnöfer [Thu, 18 Sep 2008 14:15:05 +0000 (16:15 +0200)]
Revert "Fix for the empty string (REG_SZ) problem"
This reverts commit
d994520885301f1dfd04363bab05c9238ce5ae05.
This shouldn't be fixed in the general character conversion library but directly in the registry library.
Matthias Dieter Wallnöfer [Mon, 15 Sep 2008 17:21:38 +0000 (19:21 +0200)]
Registry server: Fixes up the patch with "type" != NULL (used in "EnumValue" and "QueryValue")
This prevents the server to segfault if the input data type is NULL.
Matthias Dieter Wallnöfer [Mon, 15 Sep 2008 17:14:31 +0000 (19:14 +0200)]
Revert "Registry server: Enhances commit "type" != NULL (when getting values)"
This reverts commit
32d00f5e2c5a67dac806ee07f030f3ac2ad108f9.
This patch hasn't been right. Repost it in the right way.
Matthias Dieter Wallnöfer [Mon, 15 Sep 2008 16:28:11 +0000 (18:28 +0200)]
Registry server: Enhances commit "type" != NULL (when getting values)
Matthias Dieter Wallnöfer [Mon, 15 Sep 2008 16:21:45 +0000 (18:21 +0200)]
Registry server "reg_ldb_unpack_value": Tests demonstrate that also "type" doesn't has to be NULL
Matthias Dieter Wallnöfer [Mon, 15 Sep 2008 15:21:35 +0000 (17:21 +0200)]
Revert "Registry server "reg_ldb_unpack_value": Let "data" pointer be NULL"
This reverts commit
82f50ea69f3aece4ac654ffdfa627babd8aadc25.
Cause: Windows (2000) doesn't accept the "data" pointer set to NULL
Matthias Dieter Wallnöfer [Mon, 15 Sep 2008 13:13:25 +0000 (15:13 +0200)]
Registry server "reg_ldb_unpack_value": Let "data" pointer be NULL
Prevent segfaults in some client applications (e.g. regdiff)
Matthias Dieter Wallnöfer [Mon, 15 Sep 2008 10:27:10 +0000 (12:27 +0200)]
Registry server: Cosmetic corrections
Matthias Dieter Wallnöfer [Sun, 14 Sep 2008 01:51:35 +0000 (03:51 +0200)]
Cleanups of server files
Cosmetic corrections
Matthias Dieter Wallnöfer [Sat, 13 Sep 2008 11:32:39 +0000 (13:32 +0200)]
Registry server: More work to be compatible
Some fixup's and assure, that we send only initialized values.
Matthias Dieter Wallnöfer [Sat, 13 Sep 2008 10:10:00 +0000 (12:10 +0200)]
ldb_get_value_by_id: Fix the return of the default value
The return of the values of a certain key has been broken since I've introduced the default value.
Now the behaviour is correct: If no default value exists, start with index zero to fetch the other values. Otherwise let zero be the default value and enumerate the others starting with one.
Matthias Dieter Wallnöfer [Fri, 12 Sep 2008 16:36:04 +0000 (18:36 +0200)]
reg_ldb_unpack_value: Change "CH_UTF8" in "CH_UNIX"
It's better to use "CH_UNIX" for unpacking, because the system charset doesn't have to be UTF8 and we should be compatible with "reg_ldb_pack_value".
Matthias Dieter Wallnöfer [Fri, 12 Sep 2008 14:31:57 +0000 (16:31 +0200)]
ldb_del_value: Free key data also when removing the default attribute
Matthias Dieter Wallnöfer [Tue, 9 Sep 2008 15:54:08 +0000 (17:54 +0200)]
Fixes for the WINREG RPC server
This changes the WINREG RPC server through some corrections into the Windows-like behaviour.
Compared with Windows 2000 and tested through Windows 2000 Registry Editor.
Matthias Dieter Wallnöfer [Tue, 9 Sep 2008 15:49:41 +0000 (17:49 +0200)]
Fix for allowing the REG_BINARY type and introducing the default attribute
The REG_BINARY type is converted and stored in the LDB database as a leaf object with string-data.
The default attribute is saved directly in the hive object as the "data"-string.
Matthias Dieter Wallnöfer [Tue, 9 Sep 2008 15:44:41 +0000 (17:44 +0200)]
Fix for the empty string (REG_SZ) problem
I enhanced the "utf8_push" function, who finally accepts now also the char sequence "" with length 1 as valid UTF8 string.
Jelmer Vernooij [Tue, 21 Oct 2008 12:29:38 +0000 (14:29 +0200)]
Prevent warning about directory already existing.
Jelmer Vernooij [Tue, 21 Oct 2008 12:23:42 +0000 (14:23 +0200)]
Fix rpcecho test.
Günther Deschner [Tue, 21 Oct 2008 10:26:05 +0000 (12:26 +0200)]
s3-build: fix the build.
Guenther
Günther Deschner [Mon, 20 Oct 2008 23:19:49 +0000 (01:19 +0200)]
s3-lsa-server: fix _lsa_GetUserName.
Guenther
Jeremy Allison [Mon, 20 Oct 2008 23:51:37 +0000 (16:51 -0700)]
Remove the requirement for ldap call made as root. Add in security
checks for all SAMR calls.
Jeremy.
Jeremy Allison [Mon, 20 Oct 2008 23:38:25 +0000 (16:38 -0700)]
Merge branch 'master' of ssh://jra@git.samba.org/data/git/samba
Jeremy Allison [Mon, 20 Oct 2008 23:34:56 +0000 (16:34 -0700)]
Fix warnings.
Jeremy.
Günther Deschner [Mon, 20 Oct 2008 20:06:58 +0000 (22:06 +0200)]
s3-rpcclient: fix cmd_lsa build.
Guenther
Günther Deschner [Mon, 20 Oct 2008 20:06:44 +0000 (22:06 +0200)]
s3-build: re-run make samba3-idl.
Guenther
Günther Deschner [Mon, 20 Oct 2008 20:05:04 +0000 (22:05 +0200)]
idl: merge from s4 lsa.idl to s3.
Guenther
Jelmer Vernooij [Mon, 20 Oct 2008 19:35:10 +0000 (21:35 +0200)]
Merge branch 'master' of git://git.samba.org/samba
Conflicts:
source3/include/proto.h
Jelmer Vernooij [Mon, 20 Oct 2008 19:33:41 +0000 (21:33 +0200)]
Add source4/ to include path because librpc/gen_ndr is still in source?/
Volker Lendecke [Mon, 20 Oct 2008 16:25:13 +0000 (18:25 +0200)]
Fix a valgrind error in idmap_ad_sids_to_unixids()
We need to initialize all mappings in case we don't find anything.
Simo, please check!
Volker
Günther Deschner [Mon, 20 Oct 2008 18:16:03 +0000 (20:16 +0200)]
s3-samr-server: be consistent when reporting we do password complexity.
Guenther
Jelmer Vernooij [Mon, 20 Oct 2008 17:51:07 +0000 (19:51 +0200)]
Add missing prototypes for samba3-specific libndr/util.c
Jelmer Vernooij [Mon, 20 Oct 2008 17:50:49 +0000 (19:50 +0200)]
Sync syntax of srvsvc.idl with samba3.
Günther Deschner [Mon, 20 Oct 2008 17:21:10 +0000 (19:21 +0200)]
s3-build: no need to duplicate generated ndr_ prototypes.
Guenther
Günther Deschner [Mon, 20 Oct 2008 16:29:57 +0000 (18:29 +0200)]
s3-build: no need to duplicate generated srv_ prototypes.
Guenther
Jelmer Vernooij [Mon, 20 Oct 2008 17:35:55 +0000 (19:35 +0200)]
Include generated header files rather than using manually written
prototypes.
Jelmer Vernooij [Mon, 20 Oct 2008 17:20:12 +0000 (19:20 +0200)]
Move orpc to top-level directory.
Jelmer Vernooij [Mon, 20 Oct 2008 17:14:55 +0000 (19:14 +0200)]
Remove unused function str_list_match.
Jelmer Vernooij [Mon, 20 Oct 2008 17:14:47 +0000 (19:14 +0200)]
Move WMI support code to top-level.
Jelmer Vernooij [Mon, 20 Oct 2008 16:59:51 +0000 (18:59 +0200)]
Make sure prototypes are always included, make some functions static and
remove some unused functions.
Jelmer Vernooij [Mon, 20 Oct 2008 16:59:45 +0000 (18:59 +0200)]
Fix crypto test.
Jelmer Vernooij [Mon, 20 Oct 2008 15:16:04 +0000 (17:16 +0200)]
Import comments about opcodes from Samba 3.
Jelmer Vernooij [Mon, 20 Oct 2008 15:15:17 +0000 (17:15 +0200)]
Move discard_const hack to memory.hso it can be used by Samba 3.
Jelmer Vernooij [Mon, 20 Oct 2008 14:52:00 +0000 (16:52 +0200)]
Remove unused macro CONST_ADD.
Jelmer Vernooij [Mon, 20 Oct 2008 14:46:19 +0000 (16:46 +0200)]
Remove unused define for crypt (now in libreplace).
Günther Deschner [Mon, 20 Oct 2008 13:53:24 +0000 (15:53 +0200)]
Revert "s4: fix the build after winreg idl changes."
This reverts commit
61db229c08a601780da09ee4f2f4f1eb32ec3aa0.
Günther Deschner [Mon, 20 Oct 2008 13:47:46 +0000 (15:47 +0200)]
s4: fix the build after winreg idl changes.
Guenther
Jelmer Vernooij [Mon, 20 Oct 2008 11:24:16 +0000 (13:24 +0200)]
Provide two symbols to allow ndrdump compiled by Samba 3 to be used for
Samba 4.
Jelmer Vernooij [Mon, 20 Oct 2008 11:21:43 +0000 (13:21 +0200)]
Fix merged build; use full libroken rather than just a couple of object files.
Jelmer Vernooij [Mon, 20 Oct 2008 11:21:29 +0000 (13:21 +0200)]
Add missing asn1 object.
Jelmer Vernooij [Mon, 20 Oct 2008 11:19:39 +0000 (13:19 +0200)]
Use tables in Samba 3 ndrdump.
Jelmer Vernooij [Mon, 20 Oct 2008 10:28:13 +0000 (12:28 +0200)]
Fix names in winreg torture tests.
Jelmer Vernooij [Mon, 20 Oct 2008 10:28:07 +0000 (12:28 +0200)]
Also build all other Samba 4 binaries during merged build.
Jelmer Vernooij [Mon, 20 Oct 2008 10:20:53 +0000 (12:20 +0200)]
Also move wireshark conformance file.
Jelmer Vernooij [Mon, 20 Oct 2008 10:19:57 +0000 (12:19 +0200)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba into crypt
Jelmer Vernooij [Mon, 20 Oct 2008 10:19:01 +0000 (12:19 +0200)]
Regenerate pidl output.
Jelmer Vernooij [Mon, 20 Oct 2008 09:53:20 +0000 (11:53 +0200)]
Share winreg.idl.
Günther Deschner [Mon, 20 Oct 2008 09:21:45 +0000 (11:21 +0200)]
s3: forgot to remove old copy of krb5pac.idl.
Guenther
Günther Deschner [Mon, 20 Oct 2008 09:11:19 +0000 (11:11 +0200)]
idl: finally share krb5_pac.idl.
Guenther
Andrew Bartlett [Mon, 20 Oct 2008 06:48:59 +0000 (17:48 +1100)]
Rework mkrelease.sh to exclude Samba3 files
This matches my proposal to samba-technical, and should allow a Samba4
release to be made shortly.
Andrew Bartlett
Andrew Bartlett [Mon, 20 Oct 2008 05:12:37 +0000 (16:12 +1100)]
Make the updated RPC-LSA pass against Win2008, and Samba4 to match
Matthias Dieter Wallnöfer [Mon, 20 Oct 2008 04:50:07 +0000 (15:50 +1100)]
LSA Patch for User Manager
New (major) patch
=================
- Enhances the "lsa.idl" file in the sense that it adds more values to
"PolicyInformation" to improve the "lsa_QueryInfoPolicy*" calls.
- Adds a minimal implementation for "AuditEvents" (also lsa_QueryInfoPolicy*
calls) to enable the "Audit" option in the "User Manager for Domains" (at least
readable).
- Adds to the "lsa.idl" file the system access mode flags needed for the calls
"lsa_*SystemAccessAccount".
- Fill in the "lsa_GetSystemAccessAccount" for enabling the "User Rights"
option in the "User Manager for Domains" (at least readable).
- Merge the two similar torture tests of the "lsa_QueryInfoPolicy*" calls in
one using "if"'s for a few separations.
- Add a torture test for "lsa_GetSystemAccessAccount".
- Some cosmetic-only changes (unifications) in output strings in the "LSA"
torture test.
The work has been done using the Microsoft WSPP docs.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Andrew Bartlett [Mon, 20 Oct 2008 04:19:01 +0000 (15:19 +1100)]
Mark clearTextPassword as a privilaged attribute
Andrew Bartlett [Mon, 20 Oct 2008 03:22:37 +0000 (14:22 +1100)]
Actually test the kpasswd server
This uses kpasswd operated as a blackbox, assisted by the newly
imported rkpty tool.
Andrew Bartlett
Andrew Bartlett [Mon, 20 Oct 2008 03:21:21 +0000 (14:21 +1100)]
Ensure the hdb_method structure is not on the stack.
We supply this to krb5 as a plugin, so we must keep it around as long
as the krb5_context.
Andrew Bartlett
Andrew Bartlett [Mon, 20 Oct 2008 01:18:01 +0000 (12:18 +1100)]
Add samba4kpasswd and rkpty binaries
smaba4kpasswd will be used to test the kpasswdd componet of the KDC
(which is up until now untested), and rkpty is an expect-like wrapper
we can use to blackbox that utility.
Andrew Bartlett
Jelmer Vernooij [Mon, 20 Oct 2008 08:53:56 +0000 (10:53 +0200)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba into crypt
Jelmer Vernooij [Mon, 20 Oct 2008 08:53:26 +0000 (10:53 +0200)]
Export variables correctly for blackbox tests (thanks metze).
Jelmer Vernooij [Mon, 20 Oct 2008 08:45:42 +0000 (10:45 +0200)]
Rename BAD to BAD_DATA since the first is already defined on SunOS.
Jelmer Vernooij [Mon, 20 Oct 2008 08:38:03 +0000 (10:38 +0200)]
Don't assume crypt.h is present even if crypt() is.
Jelmer Vernooij [Mon, 20 Oct 2008 08:18:02 +0000 (10:18 +0200)]
Fix blackbox tests on IPv6-only hosts.
Volker Lendecke [Sun, 19 Oct 2008 20:37:27 +0000 (22:37 +0200)]
Fix 64-bit printf warnings
Volker Lendecke [Sun, 19 Oct 2008 13:30:12 +0000 (15:30 +0200)]
Fix nonempty blank lines
Volker Lendecke [Sun, 19 Oct 2008 13:17:12 +0000 (15:17 +0200)]
"fn_new"->"fn" in smb_messages[], we got beyond that :-)
Volker Lendecke [Sun, 19 Oct 2008 12:50:55 +0000 (14:50 +0200)]
Use a direct compare instead of calling strncmp in valid_smb_header
Volker Lendecke [Sun, 19 Oct 2008 11:44:11 +0000 (13:44 +0200)]
Move the global hosts_allow() check out of the processing loop
Jelmer Vernooij [Sun, 19 Oct 2008 14:07:00 +0000 (16:07 +0200)]
Move Samba4-specific code out of selftest.
Jelmer Vernooij [Sun, 19 Oct 2008 13:47:36 +0000 (15:47 +0200)]
Use _EXT version of autoconf macro.
Kai Blin [Sun, 19 Oct 2008 11:05:19 +0000 (13:05 +0200)]
vlp: Move closer to the code tested.
Jelmer Vernooij [Sun, 19 Oct 2008 12:54:16 +0000 (14:54 +0200)]
Make sure crypt libs get included.
Jelmer Vernooij [Sun, 19 Oct 2008 12:53:55 +0000 (14:53 +0200)]
Fix typo.
Jelmer Vernooij [Sun, 19 Oct 2008 12:50:25 +0000 (14:50 +0200)]
Fix formatting in selftest help output.