ira/wip.git
11 years agoRevert "Document _talloc"
Volker Lendecke [Sun, 22 Mar 2009 08:47:59 +0000 (09:47 +0100)]
Revert "Document _talloc"

This reverts commit 2ce70d4f5a30973b4cc083dbbb38b519007a31bd.

11 years agoRevert "Document TALLOC_FREE()"
Volker Lendecke [Sun, 22 Mar 2009 08:47:51 +0000 (09:47 +0100)]
Revert "Document TALLOC_FREE()"

This reverts commit 3f81649b8dcadb3bd424f41d803dbd59f770b9ba.

11 years agoRevert "Document talloc_parent, talloc_parent_name and talloc_is_parent"
Volker Lendecke [Sun, 22 Mar 2009 08:47:44 +0000 (09:47 +0100)]
Revert "Document talloc_parent, talloc_parent_name and talloc_is_parent"

This reverts commit 986c2e01cca0be993f1e52d3a27819f4044bfe4b.

11 years agoRevert "Document talloc_zero_array()"
Volker Lendecke [Sun, 22 Mar 2009 08:47:37 +0000 (09:47 +0100)]
Revert "Document talloc_zero_array()"

This reverts commit 59dff5745528a3efe585cdeb03e2bedd6b2e404a.

11 years agoDocument talloc_zero_array()
Volker Lendecke [Sat, 21 Mar 2009 22:57:14 +0000 (23:57 +0100)]
Document talloc_zero_array()

11 years agoDocument talloc_parent, talloc_parent_name and talloc_is_parent
Volker Lendecke [Sat, 21 Mar 2009 22:49:30 +0000 (23:49 +0100)]
Document talloc_parent, talloc_parent_name and talloc_is_parent

11 years agoDocument TALLOC_FREE()
Volker Lendecke [Sat, 21 Mar 2009 19:02:50 +0000 (20:02 +0100)]
Document TALLOC_FREE()

11 years agoDocument _talloc
Volker Lendecke [Sat, 21 Mar 2009 19:02:42 +0000 (20:02 +0100)]
Document _talloc

11 years agoAdd a talloc_internal "module"
Volker Lendecke [Sat, 21 Mar 2009 19:02:19 +0000 (20:02 +0100)]
Add a talloc_internal "module"

11 years agoDocument talloc_pool()
Volker Lendecke [Sat, 21 Mar 2009 18:48:54 +0000 (19:48 +0100)]
Document talloc_pool()

11 years agoReformatting
Volker Lendecke [Sat, 21 Mar 2009 15:58:54 +0000 (16:58 +0100)]
Reformatting

11 years agoAdd some initial hook to the front page
Volker Lendecke [Sat, 21 Mar 2009 15:52:13 +0000 (16:52 +0100)]
Add some initial hook to the front page

11 years agoAdd a default "undocumented" module
Volker Lendecke [Sat, 21 Mar 2009 15:50:58 +0000 (16:50 +0100)]
Add a default "undocumented" module

11 years agoDelete talloc_guide.txt
Volker Lendecke [Sat, 21 Mar 2009 15:40:33 +0000 (16:40 +0100)]
Delete talloc_guide.txt

11 years agoConvert the contents of talloc_guide.txt to doxygen-style talloc.h comments
Volker Lendecke [Sat, 21 Mar 2009 11:43:08 +0000 (12:43 +0100)]
Convert the contents of talloc_guide.txt to doxygen-style talloc.h comments

talloc_guide.txt was partly outdated, and as going through talloc.h now shows
it was incomplete.

11 years agoAdd a basic Doxyfile for talloc
Volker Lendecke [Sat, 21 Mar 2009 09:17:24 +0000 (10:17 +0100)]
Add a basic Doxyfile for talloc

11 years agos3:nmbd: implement a MAILSLOT => CLDAP proxy for NETLOGON_SAMLOGON requests
Stefan Metzmacher [Wed, 28 Jan 2009 09:10:12 +0000 (10:10 +0100)]
s3:nmbd: implement a MAILSLOT => CLDAP proxy for NETLOGON_SAMLOGON requests

This will be used as part a the franky setup, where nmbd will forward
the MAILSLOT requests to the local samba4 CLDAP server.

"nmbd_proxy_logon:cldap_server = 127.0.0.1" would configure
and activate this feature.

metze

11 years agoselftest/Samba3: always use the same timeout for all servers
Stefan Metzmacher [Fri, 20 Mar 2009 15:18:47 +0000 (16:18 +0100)]
selftest/Samba3: always use the same timeout for all servers

metze

11 years agos4:selftest: rename SMBD_VALGRIND => SAMBA_VALGRIND
Stefan Metzmacher [Fri, 20 Mar 2009 15:11:14 +0000 (16:11 +0100)]
s4:selftest: rename SMBD_VALGRIND => SAMBA_VALGRIND

metze

11 years agos4:smbd: the name of the binary is "samba" now
Stefan Metzmacher [Fri, 20 Mar 2009 14:13:39 +0000 (15:13 +0100)]
s4:smbd: the name of the binary is "samba" now

metze

11 years agosocket_wrapper: fix connect() for dgram sockets, if the destination isn't there yet
Stefan Metzmacher [Fri, 20 Mar 2009 15:27:17 +0000 (16:27 +0100)]
socket_wrapper: fix connect() for dgram sockets, if the destination isn't there yet

metze

11 years agos4/provision: Use existing serverrole variable.
Matthias Dieter Wallnoefer [Sat, 21 Mar 2009 02:07:00 +0000 (03:07 +0100)]
s4/provision: Use existing serverrole variable.

Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
11 years agopyldb: Let conversion to LDIF up to the user of the API rather than doing
Jelmer Vernooij [Sat, 21 Mar 2009 01:19:25 +0000 (02:19 +0100)]
pyldb: Let conversion to LDIF up to the user of the API rather than doing
it implicitly.

11 years agoRemove unnecessary duplication of string in memory.
Jelmer Vernooij [Sat, 21 Mar 2009 00:00:18 +0000 (01:00 +0100)]
Remove unnecessary duplication of string in memory.

11 years agoAdapt Zahari's test to the generic LDB Python tests.
Jelmer Vernooij [Fri, 20 Mar 2009 21:58:15 +0000 (22:58 +0100)]
Adapt Zahari's test to the generic LDB Python tests.

11 years agoSetting nTSecurityDescriptor via LDAP fails
zahari [Fri, 20 Mar 2009 10:03:29 +0000 (12:03 +0200)]
Setting nTSecurityDescriptor via LDAP fails

Fix for the problem was substitute talloc_strndup() with
talloc_memdup(), allocate 1 more character and put null character
('\0') in the extra place so data copied is null terminated.

Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
11 years agoAdd more comments.
Jelmer Vernooij [Fri, 20 Mar 2009 21:52:57 +0000 (22:52 +0100)]
Add more comments.

11 years agos3-spoolss: _spoolss_EnumPrinters level 3 always returns WERR_UNKNOWN_LEVEL.
Günther Deschner [Fri, 20 Mar 2009 15:03:54 +0000 (16:03 +0100)]
s3-spoolss: _spoolss_EnumPrinters level 3 always returns WERR_UNKNOWN_LEVEL.

Guenther

11 years agos3-spoolss: implement enumprinters_level4.
Günther Deschner [Fri, 20 Mar 2009 14:53:17 +0000 (15:53 +0100)]
s3-spoolss: implement enumprinters_level4.

Guenther

11 years agos3-spoolss: implement enumprinters_level5.
Günther Deschner [Fri, 20 Mar 2009 14:49:57 +0000 (15:49 +0100)]
s3-spoolss: implement enumprinters_level5.

Guenther

11 years agos3-spoolss: use enum_all_printers_info_level for level 1 and 2.
Günther Deschner [Fri, 20 Mar 2009 14:48:10 +0000 (15:48 +0100)]
s3-spoolss: use enum_all_printers_info_level for level 1 and 2.

Guenther

11 years agos3-spoolss: add enum_all_printers_info_level().
Günther Deschner [Fri, 20 Mar 2009 14:44:31 +0000 (15:44 +0100)]
s3-spoolss: add enum_all_printers_info_level().

Guenther

11 years agos3-spoolss: apply some const in spoolss server.
Günther Deschner [Fri, 20 Mar 2009 14:14:09 +0000 (15:14 +0100)]
s3-spoolss: apply some const in spoolss server.

Guenther

11 years agos3-rpcclient: allow to set flags in enumprinters command.
Günther Deschner [Fri, 20 Mar 2009 13:47:13 +0000 (14:47 +0100)]
s3-rpcclient: allow to set flags in enumprinters command.

Guenther

11 years agoFix uninstallman.
Matthias Dieter Wallnoefer [Fri, 20 Mar 2009 15:22:02 +0000 (16:22 +0100)]
Fix uninstallman.

Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
11 years agoselftest/Samba3: use the same sequence of signals to shutdown samba3 as with the...
Stefan Metzmacher [Fri, 20 Mar 2009 13:25:15 +0000 (14:25 +0100)]
selftest/Samba3: use the same sequence of signals to shutdown samba3 as with the shell scripts

When we kill the timelimit process with SIGKILL, it can't kill its
children...

metze

11 years agos3-netapi: Fix Coverity #774 (REVERSE_INULL).
Günther Deschner [Fri, 20 Mar 2009 10:21:36 +0000 (11:21 +0100)]
s3-netapi: Fix Coverity #774 (REVERSE_INULL).

Guenther

11 years agos3-netapi: Fix Coverity #775 (REVERSE_INULL).
Günther Deschner [Fri, 20 Mar 2009 10:19:59 +0000 (11:19 +0100)]
s3-netapi: Fix Coverity #775 (REVERSE_INULL).

Guenther

11 years agos3-netapi: Fix Coverity #776 (REVERSE_INULL).
Günther Deschner [Fri, 20 Mar 2009 10:17:50 +0000 (11:17 +0100)]
s3-netapi: Fix Coverity #776 (REVERSE_INULL).

Guenther

11 years agos3-krb5: Fix Coverity #762 (REVERSE_INULL).
Günther Deschner [Fri, 20 Mar 2009 10:11:04 +0000 (11:11 +0100)]
s3-krb5: Fix Coverity #762 (REVERSE_INULL).

Guenther

11 years agos3-net: Fix Coverity #861 (UNINIT).
Günther Deschner [Fri, 20 Mar 2009 10:07:21 +0000 (11:07 +0100)]
s3-net: Fix Coverity #861 (UNINIT).

Guenther

11 years agos3-net: Fix Coverity #898 (UNINIT).
Günther Deschner [Fri, 20 Mar 2009 10:04:59 +0000 (11:04 +0100)]
s3-net: Fix Coverity #898 (UNINIT).

Guenther

11 years agos3-spoolss: pure comsetics.
Günther Deschner [Thu, 19 Mar 2009 11:53:01 +0000 (12:53 +0100)]
s3-spoolss: pure comsetics.

sorry, I just need to do that.

Guenther

11 years agos3-krb5: Fix Coverity #722 (RESOURCE_LEAK).
Günther Deschner [Thu, 19 Mar 2009 15:42:54 +0000 (16:42 +0100)]
s3-krb5: Fix Coverity #722 (RESOURCE_LEAK).

Guenther

11 years agos3-net: Fix Coverity #886 (FORWARD_NULL).
Günther Deschner [Thu, 19 Mar 2009 15:18:29 +0000 (16:18 +0100)]
s3-net: Fix Coverity #886 (FORWARD_NULL).

Guenther

11 years agos3-samr: try to to fix password_expired flag handling.
Günther Deschner [Thu, 27 Nov 2008 16:49:25 +0000 (17:49 +0100)]
s3-samr: try to to fix password_expired flag handling.

Guenther

11 years agos4:build: include ../libcli/cldap/config.mk
Stefan Metzmacher [Fri, 20 Mar 2009 09:14:35 +0000 (10:14 +0100)]
s4:build: include ../libcli/cldap/config.mk

This fixes commit 84a140f18722518eb0f40737085dd3b3958a3a02,
sorry!

metze

11 years agoFix crash in async_smb.c
Bo Yang [Wed, 4 Mar 2009 10:10:20 +0000 (18:10 +0800)]
Fix crash in async_smb.c

11 years agos4:fullschema Use server-side sort to make the output deterministic
Andrew Bartlett [Fri, 20 Mar 2009 05:47:34 +0000 (16:47 +1100)]
s4:fullschema Use server-side sort to make the output deterministic

11 years agos4:ldb Allow paged_searches to be mixed with other controls
Andrew Bartlett [Fri, 20 Mar 2009 05:45:52 +0000 (16:45 +1100)]
s4:ldb Allow paged_searches to be mixed with other controls

I want to mix this with the server-side sort in particular.

Andrew Bartlett

11 years agos4: Remove autogenerated attributes from minschema and fullschema output
Andrew Bartlett [Fri, 20 Mar 2009 05:18:40 +0000 (16:18 +1100)]
s4: Remove autogenerated attributes from minschema and fullschema output

These attributes will be generated by Samba on import, and do not need
to be in the schema file.

Andrew Bartlett

11 years agoAdd minschema like tool to extract and dump the full schema from AD
Andrew Bartlett [Fri, 20 Mar 2009 05:07:49 +0000 (16:07 +1100)]
Add minschema like tool to extract and dump the full schema from AD

11 years agos4:minschma Fix aggregate schema generation in minschema
Andrew Bartlett [Fri, 20 Mar 2009 02:55:43 +0000 (13:55 +1100)]
s4:minschma Fix aggregate schema generation in minschema

The conversion from EJS to python I did with Jelmer this morning was
not quite complete, due mostly to the difference between print in EJS
and python (python implies a newline).

Andrew Bartlett

11 years agos4:ldb Ensure to pass down options to LDB from python
Andrew Bartlett [Fri, 20 Mar 2009 05:25:01 +0000 (16:25 +1100)]
s4:ldb Ensure to pass down options to LDB from python

This is needed for things such as to load modules, like the
paged_searches module.

Andrew Bartlett

11 years agos4:ldb Fix the paged_searches module
Andrew Bartlett [Fri, 20 Mar 2009 05:26:42 +0000 (16:26 +1100)]
s4:ldb Fix the paged_searches module

This simplifies the code, removes presumptions about being the only
control in the reply, and allows it to function against Windows 2008.

For searches which did not require a paged result, the module was
simply returning a failure when the compleated search did not include
a paged result control.

Andrew Bartlett

11 years agoMerge branch 'master' of git://git.samba.org/samba into minschema
Jelmer Vernooij [Fri, 20 Mar 2009 00:30:36 +0000 (01:30 +0100)]
Merge branch 'master' of git://git.samba.org/samba into minschema

11 years agoFix up minschema after the conversion from JavaScript.
Jelmer Vernooij [Fri, 20 Mar 2009 00:29:31 +0000 (01:29 +0100)]
Fix up minschema after the conversion from JavaScript.

Pair programmed over the phone with Andrew :-)

11 years agopyldb: Improve exception message when a list is expected.
Jelmer Vernooij [Thu, 19 Mar 2009 23:33:43 +0000 (00:33 +0100)]
pyldb: Improve exception message when a list is expected.

11 years agoadd a versiontest program to print samba_version_string().
Michael Adam [Thu, 19 Mar 2009 22:56:12 +0000 (23:56 +0100)]
add a versiontest program to print samba_version_string().

This is to allow for testing samba_version_string() without
the need to compile any of the larger binaries like smbd or net...

Michael

11 years agoversion: fix handling of SAMBA_VERSION_VENDOR_PATCH.
Michael Adam [Thu, 19 Mar 2009 22:55:21 +0000 (23:55 +0100)]
version: fix handling of SAMBA_VERSION_VENDOR_PATCH.

We need a string version of this, or else version.c does not compile.

Michael

11 years agos3: Fix a free of an uninitialized variable in winbind_get_sid_aliases
Dan Sledz [Thu, 19 Mar 2009 21:53:34 +0000 (21:53 +0000)]
s3: Fix a free of an uninitialized variable in winbind_get_sid_aliases

11 years agos3:libads: use libcli/cldap code
Stefan Metzmacher [Tue, 24 Feb 2009 18:05:33 +0000 (19:05 +0100)]
s3:libads: use libcli/cldap code

metze

11 years agos3:build: compile lib/tsocket and libcli/cldap
Stefan Metzmacher [Tue, 24 Feb 2009 17:27:45 +0000 (18:27 +0100)]
s3:build: compile lib/tsocket and libcli/cldap

metze

11 years agomove source4/libcli/cldap => libcli/cldap
Stefan Metzmacher [Wed, 18 Mar 2009 16:43:11 +0000 (17:43 +0100)]
move source4/libcli/cldap => libcli/cldap

metze

11 years agos4:cldap: rewrite the cldap library based on tsocket
Stefan Metzmacher [Fri, 13 Feb 2009 12:13:54 +0000 (13:13 +0100)]
s4:cldap: rewrite the cldap library based on tsocket

metze

11 years agolib/util: build tevent_unix.o and tevent_ntstatus.o as UTIL_TEVENT subsystem
Stefan Metzmacher [Thu, 26 Feb 2009 13:33:52 +0000 (14:33 +0100)]
lib/util: build tevent_unix.o and tevent_ntstatus.o as UTIL_TEVENT subsystem

metze

11 years agolib/tsocket: add tsocket_guide.txt section with specific details about bsd style...
Stefan Metzmacher [Wed, 18 Mar 2009 14:59:36 +0000 (15:59 +0100)]
lib/tsocket: add tsocket_guide.txt section with specific details about bsd style sockets

metze

11 years agolib/tsocket: add a fast path to tsocket_writev_send/recv()
Stefan Metzmacher [Wed, 11 Mar 2009 16:27:03 +0000 (17:27 +0100)]
lib/tsocket: add a fast path to tsocket_writev_send/recv()

This is similar to the tsocket_sendto_send/recv() fast path.

metze

11 years agolib/tsocket: add a fast path to tsocket_sendto_send/recv()
Stefan Metzmacher [Wed, 11 Mar 2009 16:11:22 +0000 (17:11 +0100)]
lib/tsocket: add a fast path to tsocket_sendto_send/recv()

By first trying to send data without waiting for the socket
to become writeable we gain about 10-20% performance in the
LDAP-BENCH-CLDAP test.

metze

11 years agolib/tsocket: add tsocket_guide.txt section about the async _send/recv() helper functions
Stefan Metzmacher [Wed, 18 Mar 2009 10:14:38 +0000 (11:14 +0100)]
lib/tsocket: add tsocket_guide.txt section about the async _send/recv() helper functions

metze

11 years agolib/tsocket: add tsocket_readv_send/recv()
Stefan Metzmacher [Wed, 11 Mar 2009 14:51:07 +0000 (15:51 +0100)]
lib/tsocket: add tsocket_readv_send/recv()

metze

11 years agolib/tsocket: add tsocket_writev_queue_send/recv()
Stefan Metzmacher [Wed, 11 Mar 2009 13:26:15 +0000 (14:26 +0100)]
lib/tsocket: add tsocket_writev_queue_send/recv()

metze

11 years agolib/tsocket: add tsocket_writev_send/recv()
Stefan Metzmacher [Wed, 11 Mar 2009 13:10:47 +0000 (14:10 +0100)]
lib/tsocket: add tsocket_writev_send/recv()

metze

11 years agolib/tsocket: add tsocket_connect_send/recv()
Stefan Metzmacher [Wed, 18 Feb 2009 08:19:09 +0000 (09:19 +0100)]
lib/tsocket: add tsocket_connect_send/recv()

metze

11 years agolib/tsocket: add tsocket_sendto_queue_send/recv()
Stefan Metzmacher [Wed, 18 Feb 2009 09:00:50 +0000 (10:00 +0100)]
lib/tsocket: add tsocket_sendto_queue_send/recv()

metze

11 years agolib/tsocket: add tsocket_sendto_send/recv()
Stefan Metzmacher [Tue, 10 Mar 2009 20:12:31 +0000 (21:12 +0100)]
lib/tsocket: add tsocket_sendto_send/recv()

metze

11 years agolib/tsocket: add tsocket_recvfrom_send/recv()
Stefan Metzmacher [Wed, 18 Feb 2009 08:23:32 +0000 (09:23 +0100)]
lib/tsocket: add tsocket_recvfrom_send/recv()

metze

11 years agolib/tsocket: add an implementation for bsd style sockets.
Stefan Metzmacher [Thu, 26 Feb 2009 14:37:44 +0000 (15:37 +0100)]
lib/tsocket: add an implementation for bsd style sockets.

metze

11 years agolib/tsocket: add a tsocket_guide.txt with a description of the design
Stefan Metzmacher [Wed, 11 Mar 2009 09:25:07 +0000 (10:25 +0100)]
lib/tsocket: add a tsocket_guide.txt with a description of the design

metze

11 years agolib/tsocket: add some useful helper functions
Stefan Metzmacher [Wed, 18 Feb 2009 08:14:26 +0000 (09:14 +0100)]
lib/tsocket: add some useful helper functions

metze

11 years agolib/tsocket: add generic socket abstraction layer
Stefan Metzmacher [Wed, 18 Feb 2009 08:10:54 +0000 (09:10 +0100)]
lib/tsocket: add generic socket abstraction layer

This will replace source4/lib/socket/.

metze

11 years agofix build on old Heimdal based systems
Björn Jacke [Mon, 16 Mar 2009 00:51:09 +0000 (01:51 +0100)]
fix build on old Heimdal based systems

Signed-off-by: Günther Deschner <gd@samba.org>
11 years agotevent: fix the nesting logic
Stefan Metzmacher [Thu, 19 Mar 2009 13:31:43 +0000 (14:31 +0100)]
tevent: fix the nesting logic

Only tevent_loop_once and tevent_loop_until() should care
about the nesting level.

This fixes the samba3 printing code where we use tevent_loop_wait()
and don't allow nested events.

We still call the nesting hook for all levels, we need to decide
if we really want this...

metze

11 years agos3:libsmb: always create bytes array in cli_trans code
Stefan Metzmacher [Wed, 18 Mar 2009 07:46:38 +0000 (08:46 +0100)]
s3:libsmb: always create bytes array in cli_trans code

Otherwise we return NO_MEMORY without a reason for fragmented trans
requests, as talloc_append_blob() returns buf if we append a 0 length
blob. When we pass buf = NULL we'll get back NULL and then assume
NO_MEMORY...

metze

11 years agos3:libsmb: fix smb signing for fragmented trans/trans2/nttrans requests
Stefan Metzmacher [Wed, 18 Mar 2009 06:56:51 +0000 (07:56 +0100)]
s3:libsmb: fix smb signing for fragmented trans/trans2/nttrans requests

Before we send the secondary requests we need to remove the
old mid=>seqnum mapping and reset cli->mid and make the new
mid=>seqnum mapping "persistent".

The bug we had in cli_send_trans was this:
The first cli_send_smb() incremented cli->mid
and the secondary requests used the incremented mid,
but as cli->outbuf still had the correct mid,
we send the correct mid to the server. The real problem
was that the cli_send_smb() function stored the seqnum
under the wrong mid.

cli_send_nttrans() was totally broken and now follows the
same logic as cli_send_trans().

The good thing is that in practice the problem is unlikely to happen,
because max_xmit is large enough to avoid secondary requests.

metze

11 years agos3:lib/util_sock: use sys_recv() instead of sys_read() on sockets
Stefan Metzmacher [Thu, 19 Mar 2009 08:06:38 +0000 (09:06 +0100)]
s3:lib/util_sock: use sys_recv() instead of sys_read() on sockets

This ways the pcap support in socket wrapper sees the received data.

metze

11 years agofix some typos
Björn Jacke [Wed, 18 Mar 2009 18:05:52 +0000 (19:05 +0100)]
fix some typos

Signed-off-by: Michael Adam <obnox@samba.org>
11 years agoModify simple POSIX open test to use filenames containing a ':'
Jeremy Allison [Thu, 19 Mar 2009 04:49:32 +0000 (21:49 -0700)]
Modify simple POSIX open test to use filenames containing a ':'
character. Should stop regressions of bug #6196.
Jeremy.

11 years agoAllow DFS client paths to work when POSIX pathnames have been
Jeremy Allison [Thu, 19 Mar 2009 03:56:48 +0000 (20:56 -0700)]
Allow DFS client paths to work when POSIX pathnames have been
selected (we need to path in pathname /that/look/like/this).
Jeremy.

11 years agoMerge branch 'master' of ssh://jra@git.samba.org/data/git/samba
Jeremy Allison [Thu, 19 Mar 2009 03:02:26 +0000 (20:02 -0700)]
Merge branch 'master' of ssh://jra@git.samba.org/data/git/samba

11 years agoFix bug #6196 - Unable to serve files with colons to Linux CIFS/VFS client
Jeremy Allison [Thu, 19 Mar 2009 03:00:28 +0000 (20:00 -0700)]
Fix bug #6196 - Unable to serve files with colons to Linux CIFS/VFS client
Looks like the pathname parsing for POSIX paths got
broken when the code for doing Windows streams parsing got added.
Jeremy.

11 years agouse the tevent nesting code to avoid the uid problem in the VFS
Andrew Tridgell [Thu, 19 Mar 2009 00:23:49 +0000 (11:23 +1100)]
use the tevent nesting code to avoid the uid problem in the VFS
backend

The vfs_unixuid module changes the uid of the process when executing
operations on behalf of the user. Within the VFS backend we may rely
on semi-async calls, such as winbind calls, which will call the event
loop again. To cope with this we need to ensure that while inside
those calls we revert the uid to root, then revert back to the
connected user when we have finished with the semi-async calls.

11 years agofixed a logic bug in the tevent nesting code
Andrew Tridgell [Thu, 19 Mar 2009 00:21:36 +0000 (11:21 +1100)]
fixed a logic bug in the tevent nesting code

The event nesting code never triggered as nesting.level was never
greater than 1. The main event loop needs to increase the nesting
level by 1.

I also added a paranoia check to the nesting setup call. The API as
currently written cannot support multiple nesting hooks, so we need to
abort if multiple hooks are tried.

11 years agos3 onefs: Correctly error out when the read returns EOF
Tim Prouty [Wed, 18 Mar 2009 21:49:50 +0000 (21:49 +0000)]
s3 onefs: Correctly error out when the read returns EOF

Also add some more debugging.

11 years agoFix bug #6195 - Migrating from 3.0.x to 3.3.x can fail to update passdb.tdb correctly.
Jeremy Allison [Wed, 18 Mar 2009 22:44:13 +0000 (15:44 -0700)]
Fix bug #6195 - Migrating from 3.0.x to 3.3.x can fail to update passdb.tdb correctly.
This is a really nasty one to fix as in order to successfully update the
passdb.tdb we must do the equivalent of a tdbbackup to move to the new hash
values before we do the upgrade.
Jeremy.

11 years agos3: remove POLICY_HND.
Günther Deschner [Wed, 18 Mar 2009 21:49:41 +0000 (22:49 +0100)]
s3: remove POLICY_HND.

Guenther

11 years agos3-rpc_parse: remove some unused parsing code.
Günther Deschner [Wed, 18 Mar 2009 14:09:57 +0000 (15:09 +0100)]
s3-rpc_parse: remove some unused parsing code.

Guenther

11 years agos3-spoolss: fix _spoolss_GetPrinterData printerserver handle query error code.
Günther Deschner [Wed, 18 Mar 2009 20:54:26 +0000 (21:54 +0100)]
s3-spoolss: fix _spoolss_GetPrinterData printerserver handle query error code.

When _spoolss_GetPrinterData receives a query on a printserver handle for a
value that we have not stored or do not provide, we need to return
WERR_INVALID_PARAM, not WERR_BADFILE. Tested with w2k and w2k3 servers.
Found by torture test.

Guenther

11 years agos3-spoolss: fix _spoolss_EnumPrinterDataEx error path.
Günther Deschner [Wed, 18 Mar 2009 20:36:40 +0000 (21:36 +0100)]
s3-spoolss: fix _spoolss_EnumPrinterDataEx error path.

When a windows clients queries the "" key, we need to make sure to return with
the appropriate error (WERR_INVALID_PARAM in that case), and not fall through
to the buffer size handling macros. Found by torture test.

Guenther

11 years agos3-rpc_parse: remove unused BUFFER5 and UNISTR3.
Günther Deschner [Wed, 18 Mar 2009 11:22:22 +0000 (12:22 +0100)]
s3-rpc_parse: remove unused BUFFER5 and UNISTR3.

Guenther