ira/wip.git
12 years agos4: Fix parsing of CSDVersion: treat this field as an string null terminated.
Matthieu Patou [Fri, 11 Sep 2009 15:57:04 +0000 (19:57 +0400)]
s4: Fix parsing of CSDVersion: treat this field as an string null terminated.

 CDSVersion field contains one utf16 string and then garbage which pertubated the parsing.
 We use subcontext to clearly define the size of the whole blob and then let the parser to find
 the real length of the string.
 This is a fix for bug 6706, many thanks to Gunter for the PIDL guidelines.

12 years agos3:dbwrap_ctdb: set dmaster in ctdb_transaction_store() also when updating an existin...
Michael Adam [Fri, 11 Sep 2009 11:23:34 +0000 (13:23 +0200)]
s3:dbwrap_ctdb: set dmaster in ctdb_transaction_store() also when updating an existing record

not only when creating a record.

This matches commit e9194a130327d6b05a8ab90bd976475b0e93b06d from ctdb-master.

Michael

12 years agotalloc:mksyms: allow characters after closing functions parenthesis.
Michael Adam [Fri, 11 Sep 2009 12:54:30 +0000 (14:54 +0200)]
talloc:mksyms: allow characters after closing functions parenthesis.

Michael

12 years agotalloc:mksyms: allow double pointer return value of functions.
Michael Adam [Fri, 11 Sep 2009 12:54:02 +0000 (14:54 +0200)]
talloc:mksyms: allow double pointer return value of functions.

Michael

12 years agos3:mksyms: fix spelling...
Michael Adam [Fri, 11 Sep 2009 13:36:57 +0000 (15:36 +0200)]
s3:mksyms: fix spelling...

Michael

12 years agotevent:mksyms: fix spelling...
Michael Adam [Fri, 11 Sep 2009 13:36:34 +0000 (15:36 +0200)]
tevent:mksyms: fix spelling...

Michael

12 years agotalloc:mksigs: allow PRINTF_ATTRIBUTE(..) macros function types as funcion args
Michael Adam [Fri, 11 Sep 2009 13:20:34 +0000 (15:20 +0200)]
talloc:mksigs: allow PRINTF_ATTRIBUTE(..) macros function types as funcion args

Michael

12 years agotalloc:mksigs: normalize bool -> _Bool
Michael Adam [Fri, 11 Sep 2009 13:16:03 +0000 (15:16 +0200)]
talloc:mksigs: normalize bool -> _Bool

Michael

12 years agotalloc:mksigs: ignore symbols (like _DEPRECATED_) after closing function parentheses
Michael Adam [Fri, 11 Sep 2009 13:11:16 +0000 (15:11 +0200)]
talloc:mksigs: ignore symbols (like _DEPRECATED_) after closing function parentheses

Michael

12 years agotalloc:mksigs: correctly ignode multiline function typedefs
Michael Adam [Fri, 11 Sep 2009 13:01:46 +0000 (15:01 +0200)]
talloc:mksigs: correctly ignode multiline function typedefs

by first concatenating multilint parentheses and removing typefes afterwards.

Michael

12 years agotalloc:mksigs: ignore struct forward declarations.
Michael Adam [Fri, 11 Sep 2009 12:55:52 +0000 (14:55 +0200)]
talloc:mksigs: ignore struct forward declarations.

Michael

12 years agotalloc:mksyms: allow characters after closing functions parenthesis.
Michael Adam [Fri, 11 Sep 2009 12:54:30 +0000 (14:54 +0200)]
talloc:mksyms: allow characters after closing functions parenthesis.

Michael

12 years agotalloc:mksyms: allow double pointer return value of functions.
Michael Adam [Fri, 11 Sep 2009 12:54:02 +0000 (14:54 +0200)]
talloc:mksyms: allow double pointer return value of functions.

Michael

12 years agotdb:mksigs: allow PRINTF_ATTRIBUTE(..) macros function types as funcion args
Michael Adam [Fri, 11 Sep 2009 13:20:34 +0000 (15:20 +0200)]
tdb:mksigs: allow PRINTF_ATTRIBUTE(..) macros function types as funcion args

Michael

12 years agotdb:mksigs: normalize bool -> _Bool
Michael Adam [Fri, 11 Sep 2009 13:16:03 +0000 (15:16 +0200)]
tdb:mksigs: normalize bool -> _Bool

Michael

12 years agotdb:mksigs: ignore symbols (like _DEPRECATED_) after closing function parentheses
Michael Adam [Fri, 11 Sep 2009 13:11:16 +0000 (15:11 +0200)]
tdb:mksigs: ignore symbols (like _DEPRECATED_) after closing function parentheses

Michael

12 years agotdb:mksigs: correctly ignode multiline function typedefs
Michael Adam [Fri, 11 Sep 2009 13:01:46 +0000 (15:01 +0200)]
tdb:mksigs: correctly ignode multiline function typedefs

by first concatenating multilint parentheses and removing typefes afterwards.

Michael

12 years agotdb:mksigs: ignore struct forward declarations.
Michael Adam [Fri, 11 Sep 2009 12:55:52 +0000 (14:55 +0200)]
tdb:mksigs: ignore struct forward declarations.

Michael

12 years agotdb:mksyms: allow characters after closing functions parenthesis.
Michael Adam [Fri, 11 Sep 2009 12:54:30 +0000 (14:54 +0200)]
tdb:mksyms: allow characters after closing functions parenthesis.

Michael

12 years agotdb:mksyms: allow double pointer return value of functions.
Michael Adam [Fri, 11 Sep 2009 12:54:02 +0000 (14:54 +0200)]
tdb:mksyms: allow double pointer return value of functions.

Michael

12 years agotevent:signatures: add _tevent_req_cancel and tevent_req_set_cancel_fn
Michael Adam [Fri, 11 Sep 2009 13:08:37 +0000 (15:08 +0200)]
tevent:signatures: add _tevent_req_cancel and tevent_req_set_cancel_fn

introduced in 45e4be0d96abdc729252df1e97bb9a56302e5a4a

Michael

12 years agotevent:exports: add _tevent_req_cancel and tevent_req_set_cancel_fn.
Michael Adam [Fri, 11 Sep 2009 12:57:59 +0000 (14:57 +0200)]
tevent:exports: add _tevent_req_cancel and tevent_req_set_cancel_fn.

These were added in 45e4be0d96abdc729252df1e97bb9a56302e5a4a

Michael

12 years agotevent:mksigs: allow PRINTF_ATTRIBUTE(..) macros function types as funcion args
Michael Adam [Fri, 11 Sep 2009 13:20:34 +0000 (15:20 +0200)]
tevent:mksigs: allow PRINTF_ATTRIBUTE(..) macros function types as funcion args

Michael

12 years agotevent:mksigs: normalize bool -> _Bool
Michael Adam [Fri, 11 Sep 2009 13:16:03 +0000 (15:16 +0200)]
tevent:mksigs: normalize bool -> _Bool

Michael

12 years agotevent:mksigs: ignore symbols (like _DEPRECATED_) after closing function parentheses
Michael Adam [Fri, 11 Sep 2009 13:11:16 +0000 (15:11 +0200)]
tevent:mksigs: ignore symbols (like _DEPRECATED_) after closing function parentheses

Michael

12 years agotevent:mksigs: correctly ignode multiline function typedefs
Michael Adam [Fri, 11 Sep 2009 13:01:46 +0000 (15:01 +0200)]
tevent:mksigs: correctly ignode multiline function typedefs

by first concatenating multilint parentheses and removing typefes afterwards.

Michael

12 years agotevent:mksigs: ignore struct forward declarations.
Michael Adam [Fri, 11 Sep 2009 12:55:52 +0000 (14:55 +0200)]
tevent:mksigs: ignore struct forward declarations.

Michael

12 years agotevent:mksyms: allow characters after closing functions parenthesis.
Michael Adam [Fri, 11 Sep 2009 12:54:30 +0000 (14:54 +0200)]
tevent:mksyms: allow characters after closing functions parenthesis.

Michael

12 years agotevent:mksyms: allow double pointer return value of functions.
Michael Adam [Fri, 11 Sep 2009 12:54:02 +0000 (14:54 +0200)]
tevent:mksyms: allow double pointer return value of functions.

Michael

12 years agotevent: add abi_checks to "make test"
Michael Adam [Fri, 11 Sep 2009 12:00:25 +0000 (14:00 +0200)]
tevent: add abi_checks to "make test"

Michael

12 years agotevent: remove filese generated by "make abi_checks" in "make clean".
Michael Adam [Fri, 11 Sep 2009 11:39:44 +0000 (13:39 +0200)]
tevent: remove filese generated by "make abi_checks" in "make clean".

Michael

12 years agotevent: add a make target "make abi_checks"
Michael Adam [Fri, 11 Sep 2009 11:39:15 +0000 (13:39 +0200)]
tevent: add a make target "make abi_checks"

Michael

12 years agotevent: move the original abi_checks script to script/abi_checks_gcc.sh
Michael Adam [Fri, 28 Aug 2009 14:04:47 +0000 (16:04 +0200)]
tevent: move the original abi_checks script to script/abi_checks_gcc.sh

Michael

12 years agotevent: add script/abi_checks.sh. check for abi changes without gcc magic.
Michael Adam [Fri, 28 Aug 2009 13:53:12 +0000 (15:53 +0200)]
tevent: add script/abi_checks.sh. check for abi changes without gcc magic.

USAGE: abi_checks.sh LIBRARY_NAME header1 [header2 ...]

This creates symbol signature lists using the mksyms and mksigs scripts
and compares them with the checked in lists.

Michael

12 years agotevent: add script to extract signatures from header files.
Michael Adam [Fri, 28 Aug 2009 13:08:19 +0000 (15:08 +0200)]
tevent: add script to extract signatures from header files.

This produces output like the output gcc produces when
invoked with the -aux-info switch.

Run like this: cat include/tevent.h | ./script/mksigs.pl

This simple parser is probably too coarse to handle all
possible header files, but it treats tevent.h correctly...

Michael

12 years agotevent: add scripts to extract library symbols (exports file) from headers
Michael Adam [Fri, 28 Aug 2009 13:01:17 +0000 (15:01 +0200)]
tevent: add scripts to extract library symbols (exports file) from headers

Michael

12 years agos4-vampire: cope with no invocationID when vampiring the schema
Andrew Tridgell [Fri, 11 Sep 2009 13:26:39 +0000 (23:26 +1000)]
s4-vampire: cope with no invocationID when vampiring the schema

12 years agos4-drs: fixed the ldap SPN in AddEntry
Andrew Tridgell [Fri, 11 Sep 2009 13:14:07 +0000 (23:14 +1000)]
s4-drs: fixed the ldap SPN in AddEntry

12 years agos4-provision: revert _gc_tcp priority
Andrew Tridgell [Fri, 11 Sep 2009 13:13:39 +0000 (23:13 +1000)]
s4-provision: revert _gc_tcp priority

thanks to id10ts for spotting this. I was a victim of emacs zone mode,
which increaed it with each edit.

12 years agos4-repl: refresh the partitions on each cycle
Andrew Tridgell [Fri, 11 Sep 2009 12:47:11 +0000 (22:47 +1000)]
s4-repl: refresh the partitions on each cycle

The KCC might have changed repsFrom, which is stored in the partitions
structure

12 years agos4-smbtorture: fix remaining lsa lookup call unknowns. sorry...
Günther Deschner [Fri, 11 Sep 2009 12:33:30 +0000 (14:33 +0200)]
s4-smbtorture: fix remaining lsa lookup call unknowns. sorry...

Guenther

12 years agos4-kcc: add a very simple KCC
Andrew Tridgell [Fri, 11 Sep 2009 11:46:58 +0000 (21:46 +1000)]
s4-kcc: add a very simple KCC

A KCC is a 'Knowledge Consistency Checker', a fancy name for a daemon
that works out who will replicate with who in a AD domain. This
implements an extremely simple KCC task that just wants to replicate
with everyone :-)

12 years agos4-repl: don't update replPropertyMetaData for non-replicated attributes
Andrew Tridgell [Fri, 11 Sep 2009 11:45:35 +0000 (21:45 +1000)]
s4-repl: don't update replPropertyMetaData for non-replicated attributes

thanks to Metze for spotting this

12 years agos4-idl: added the IDL for the DsReplica* calls
Andrew Tridgell [Fri, 11 Sep 2009 10:14:11 +0000 (20:14 +1000)]
s4-idl: added the IDL for the DsReplica* calls

12 years agos3-rpcclient: add lookupsids3 command.
Günther Deschner [Fri, 11 Sep 2009 11:58:52 +0000 (13:58 +0200)]
s3-rpcclient: add lookupsids3 command.

Guenther

12 years agolsa: fill in more unknowns in lsa_LookupSid calls.
Günther Deschner [Fri, 11 Sep 2009 11:55:44 +0000 (13:55 +0200)]
lsa: fill in more unknowns in lsa_LookupSid calls.

Guenther

12 years agos4:ldb_map_outbound - fix memory leak
Matthias Dieter Wallnöfer [Fri, 11 Sep 2009 11:35:55 +0000 (13:35 +0200)]
s4:ldb_map_outbound - fix memory leak

Patch from Andrew Kroeger wasn't fully correct - we need a "talloc_free" after
the "if (ac->r_current == NULL)" statement.

12 years agonetlogon.idl: indent correctly
Matthias Dieter Wallnöfer [Fri, 11 Sep 2009 11:25:53 +0000 (13:25 +0200)]
netlogon.idl: indent correctly

12 years agolsa: use lsa_LookupNamesLevel in lsa_LookupSids{2,3}.
Günther Deschner [Fri, 11 Sep 2009 10:16:35 +0000 (12:16 +0200)]
lsa: use lsa_LookupNamesLevel in lsa_LookupSids{2,3}.

Guenther

12 years agos4-repl: on every ldb modify we need to update replPropertyMetaData
Andrew Tridgell [Fri, 11 Sep 2009 09:07:38 +0000 (19:07 +1000)]
s4-repl: on every ldb modify we need to update replPropertyMetaData

Every time we change a ldb object with the repl_meta_data module
loaded we need to update the replPropertyMetaData attribute to fix the
timestamps and USNs of the attributes being changed.

12 years agos4-repl: don't add the RDN if it is already there
Andrew Tridgell [Fri, 11 Sep 2009 08:01:27 +0000 (18:01 +1000)]
s4-repl: don't add the RDN if it is already there

12 years agos4-ldb: don't remove a message element beyond the end of the array
Andrew Tridgell [Fri, 11 Sep 2009 08:00:42 +0000 (18:00 +1000)]
s4-ldb: don't remove a message element beyond the end of the array

12 years agos3-rpcclient: make netlogon credential setup also work for interdomain trusts.
Günther Deschner [Thu, 10 Sep 2009 22:20:59 +0000 (00:20 +0200)]
s3-rpcclient: make netlogon credential setup also work for interdomain trusts.

Guenther

12 years agos3-rpcclient: avoid using lp_workgroup() unconditionally for crypto.
Günther Deschner [Thu, 10 Sep 2009 20:56:05 +0000 (22:56 +0200)]
s3-rpcclient: avoid using lp_workgroup() unconditionally for crypto.

Guenther

12 years agos3-rpc_client: add dcerpc_transport_t to cli_rpc_pipe_open_schannel().
Günther Deschner [Thu, 10 Sep 2009 20:32:34 +0000 (22:32 +0200)]
s3-rpc_client: add dcerpc_transport_t to cli_rpc_pipe_open_schannel().

Guenther

12 years agos3-rpc_client: add dcerpc_transport_t to cli_rpc_pipe_open_spnego_ntlmssp and cli_rpc...
Günther Deschner [Thu, 10 Sep 2009 20:23:21 +0000 (22:23 +0200)]
s3-rpc_client: add dcerpc_transport_t to cli_rpc_pipe_open_spnego_ntlmssp and cli_rpc_pipe_open_ntlmssp.

Guenther

12 years agos3-rpcclient: use cli_rpc_pipe_open_noauth_transport in rpcclient.
Günther Deschner [Thu, 10 Sep 2009 20:22:24 +0000 (22:22 +0200)]
s3-rpcclient: use cli_rpc_pipe_open_noauth_transport in rpcclient.

Guenther

12 years agos3-rpc_client: add cli_rpc_pipe_open_noauth_transport.
Günther Deschner [Tue, 4 Nov 2008 17:40:24 +0000 (18:40 +0100)]
s3-rpc_client: add cli_rpc_pipe_open_noauth_transport.

Guenther

12 years agos4-provision: use DNS name, not domain name
Andrew Tridgell [Fri, 11 Sep 2009 07:14:01 +0000 (17:14 +1000)]
s4-provision: use DNS name, not domain name

The SPNs end in the DNS domain name

12 years agos4-drs: actually call the new drsuapi_add_SPNs() code
Andrew Tridgell [Fri, 11 Sep 2009 07:13:28 +0000 (17:13 +1000)]
s4-drs: actually call the new drsuapi_add_SPNs() code

An early return here didn't do any good :-)

12 years agos4-drs: add the magic DRS SPNs on AddEntry
Andrew Tridgell [Fri, 11 Sep 2009 05:15:39 +0000 (15:15 +1000)]
s4-drs: add the magic DRS SPNs on AddEntry

When a DsAddEntry is used to create a nTDSDSA object we need to also
create the SPNs for the NTDS GUID in the servers machine account.

12 years agos4/provision: add the nTDSDSA GUID based DNS entries and SPNs
Andrew Tridgell [Fri, 11 Sep 2009 03:39:31 +0000 (13:39 +1000)]
s4/provision: add the nTDSDSA GUID based DNS entries and SPNs

The DNS entries and SPNs are needed for samba<->samba DRS
replication. This patch adds them for a standalone DC configure. A
separate patch will add them for the vampire configure

12 years agos4/drs: parentGUID needs to be specififcally asked for
Andrew Tridgell [Thu, 10 Sep 2009 13:03:07 +0000 (23:03 +1000)]
s4/drs: parentGUID needs to be specififcally asked for

Right now parentGUID is a normal attribute in s4, but it should be
generated, which means we need to ask for it in a search if we want to
use it.

12 years agos4/libcli: when we get a DNS lookup failure show the name
Andrew Tridgell [Thu, 10 Sep 2009 13:01:49 +0000 (23:01 +1000)]
s4/libcli: when we get a DNS lookup failure show the name

When tracking down complex connection problems its useful knowing what
name lookups failed.

12 years agos4/tort: RPC-DRSUAPI test case refactored to match torture architecture
Kamen Mazdrashki [Thu, 10 Sep 2009 22:39:19 +0000 (01:39 +0300)]
s4/tort: RPC-DRSUAPI test case refactored to match torture architecture

12 years agos4/tort: code clean up using torture_drsuapi_assert_call() macro
Kamen Mazdrashki [Thu, 10 Sep 2009 22:17:57 +0000 (01:17 +0300)]
s4/tort: code clean up using torture_drsuapi_assert_call() macro

After this change, when a test fails, it gives
reasonable failure message.

12 years agos4/tort: assert macro for drsuapi dcerpc call
Kamen Mazdrashki [Thu, 10 Sep 2009 20:44:00 +0000 (23:44 +0300)]
s4/tort: assert macro for drsuapi dcerpc call

The macro actually wraps common code pattern used in
almost every test for DRSUAPI interface

12 years agos4/tort: Propagate torture_context and use torture_comment
Kamen Mazdrashki [Thu, 10 Sep 2009 20:43:32 +0000 (23:43 +0300)]
s4/tort: Propagate torture_context and use torture_comment

NOTE: Not every place where printf is used is replaced by
torture_comment. Future work shall "missed" printfs also.

12 years agos3-schannel: remove last schannel hand-marshalling function.
Günther Deschner [Fri, 11 Sep 2009 00:56:00 +0000 (02:56 +0200)]
s3-schannel: remove last schannel hand-marshalling function.

Guenther

12 years agos3-schannel: use NL_AUTH_SIGNATURE for schannel sign & seal (client & server).
Günther Deschner [Fri, 11 Sep 2009 00:52:25 +0000 (02:52 +0200)]
s3-schannel: use NL_AUTH_SIGNATURE for schannel sign & seal (client & server).

Guenther

12 years agos3-errors: add NT_STATUS_RPC_NT_PROCNUM_OUT_OF_RANGE.
Günther Deschner [Fri, 11 Sep 2009 00:49:30 +0000 (02:49 +0200)]
s3-errors: add NT_STATUS_RPC_NT_PROCNUM_OUT_OF_RANGE.

Guenther

12 years agos3-schannel: remove unused code.
Günther Deschner [Fri, 11 Sep 2009 00:21:33 +0000 (02:21 +0200)]
s3-schannel: remove unused code.

Guenther

12 years agos3-schannel: use NL_AUTH_MESSAGE for schannel bind reply.
Günther Deschner [Fri, 11 Sep 2009 00:20:59 +0000 (02:20 +0200)]
s3-schannel: use NL_AUTH_MESSAGE for schannel bind reply.

Guenther

12 years agoschannel: more work on reponse NL_AUTH_MESSAGES.
Günther Deschner [Fri, 11 Sep 2009 00:18:59 +0000 (02:18 +0200)]
schannel: more work on reponse NL_AUTH_MESSAGES.

Guenther

12 years agos3-nterr: add NT_STATUS_RPC_NT_PROTOCOL_ERROR to nt_errstr().
Günther Deschner [Fri, 11 Sep 2009 00:17:51 +0000 (02:17 +0200)]
s3-nterr: add NT_STATUS_RPC_NT_PROTOCOL_ERROR to nt_errstr().

Guenther

12 years agos3-util: add get/set_cmdline_auth_info_domain to user_auth_info struct.
Günther Deschner [Thu, 10 Sep 2009 20:53:44 +0000 (22:53 +0200)]
s3-util: add get/set_cmdline_auth_info_domain to user_auth_info struct.

Guenther

12 years agos3-rpcclient: add lookupnames4 command.
Günther Deschner [Thu, 10 Sep 2009 21:33:37 +0000 (23:33 +0200)]
s3-rpcclient: add lookupnames4 command.

Guenther

12 years agos3-rpcclient: add ncacn transport handling for rpcclient.
Günther Deschner [Thu, 10 Sep 2009 19:14:29 +0000 (21:14 +0200)]
s3-rpcclient: add ncacn transport handling for rpcclient.

Guenther

12 years agos3-rpc_client: add enum dcerpc_transport_t to rpc_cli_transport struct.
Günther Deschner [Thu, 10 Sep 2009 17:59:37 +0000 (19:59 +0200)]
s3-rpc_client: add enum dcerpc_transport_t to rpc_cli_transport struct.

Guenther

12 years agos4:setup Updated Display Specifiers from Microsoft (with #s)
Andrew Bartlett [Thu, 10 Sep 2009 21:25:11 +0000 (07:25 +1000)]
s4:setup Updated Display Specifiers from Microsoft (with #s)

This fixes the issue with the original files that they didn't have a
leading # in front of the comments, which caused our parsing scripts
much pain.  The files are now exactly as delivered.

Andrew Bartlett

12 years agos4: Pass WINBINDD_SOCKET_DIR var in order to overide the location of the Winbind...
Matthieu Patou [Thu, 10 Sep 2009 19:33:16 +0000 (23:33 +0400)]
s4: Pass WINBINDD_SOCKET_DIR var in order to overide the location of the Winbind socket

12 years agos4:ldb_map: Don't free ares too early.
Andrew Kroeger [Thu, 10 Sep 2009 15:04:47 +0000 (10:04 -0500)]
s4:ldb_map: Don't free ares too early.

As found when running "make test" with the MALLOC_CHECK_ and MALLOC_PERTURB_
environment variables set.

12 years agos4/tort: CRACKNAMES tests to use private structure for testing.
Kamen Mazdrashki [Thu, 10 Sep 2009 10:47:14 +0000 (13:47 +0300)]
s4/tort: CRACKNAMES tests to use private structure for testing.

DsCrackNamesPrivate structure basically inherits DsPrivate
structure while adding few test-specific members.

12 years agos4/tort: Make common setup/teardown drsuapi test funcs really common
Kamen Mazdrashki [Thu, 10 Sep 2009 10:45:10 +0000 (13:45 +0300)]
s4/tort: Make common setup/teardown drsuapi test funcs really common

12 years agos4/tort: CrackNames test update to work against W2K3.
Kamen Mazdrashki [Wed, 9 Sep 2009 14:07:27 +0000 (17:07 +0300)]
s4/tort: CrackNames test update to work against W2K3.

DRSUAPI_DS_NAME_FORMAT_UKNOWN added to 'known-to-fail'
responses as this actually means to ask AD to resolve
a name from FQDN format to Unknown format.

12 years agoutil_strlist: Add some more "const"s - small correction
Matthias Dieter Wallnöfer [Thu, 10 Sep 2009 20:05:49 +0000 (22:05 +0200)]
util_strlist: Add some more "const"s - small correction

12 years agoutil_strlist: Add some more "const"s
Matthias Dieter Wallnöfer [Thu, 10 Sep 2009 05:17:40 +0000 (07:17 +0200)]
util_strlist: Add some more "const"s

12 years agoFix bug 6707 - 3.4.1 segfault in parsing configs.
Marc Aurele La France [Thu, 10 Sep 2009 16:52:11 +0000 (09:52 -0700)]
Fix bug 6707 - 3.4.1 segfault in parsing configs.
Fixes an occasional segfault caused by an out-of-bounds reference in config file parsing.

12 years agos4:srvsvc: Fix logic on error checking.
Andrew Kroeger [Mon, 7 Sep 2009 12:52:37 +0000 (07:52 -0500)]
s4:srvsvc: Fix logic on error checking.

12 years agos4:pwsettings: Added blackbox tests.
Andrew Kroeger [Tue, 8 Sep 2009 11:01:18 +0000 (06:01 -0500)]
s4:pwsettings: Added blackbox tests.

The added tests include basic validation that the script runs and accepts all
custom arguments.  The tests also verify changes to the password complexity,
minimum password length, and minimum password length settings.

12 years agotestprogs:subunit.sh: Add function for expected failures.
Andrew Kroeger [Tue, 8 Sep 2009 21:01:26 +0000 (16:01 -0500)]
testprogs:subunit.sh: Add function for expected failures.

The testit_expect_failure() function is like the testit() function, with
reversed error detection logic.  This reversal only affects the pass/fail logic
and logging - the original return code from the command is still returned to the
calling script.

12 years agos4:pwsettings: Show default values in help messages.
Andrew Kroeger [Tue, 8 Sep 2009 07:34:56 +0000 (02:34 -0500)]
s4:pwsettings: Show default values in help messages.

12 years agos4:pwsettings: Add 'default' option for password complexity.
Andrew Kroeger [Tue, 8 Sep 2009 07:34:30 +0000 (02:34 -0500)]
s4:pwsettings: Add 'default' option for password complexity.

12 years agos4:pwsettings: Added validation.
Andrew Kroeger [Mon, 7 Sep 2009 08:38:33 +0000 (03:38 -0500)]
s4:pwsettings: Added validation.

Validate that each field is within its allowed range.  Also validate that the
maximum password age is greater than the minimum password length (if the maximum
password age is set).

I could not find these values documented anywhere in the WSPP docs.  I used the
values shown in the W2K8 GPMC, as it appears that the GPMC actuaally performs
the validation of values.

12 years agos4:pwsettings: Don't assume a value for pwdProperties.
Andrew Kroeger [Mon, 7 Sep 2009 07:04:55 +0000 (02:04 -0500)]
s4:pwsettings: Don't assume a value for pwdProperties.

If we cannot retrieve the value, do not assume a particular value.  The fact
that we could not retrieve the value indicates a larger problem that we don't
want to make worse bypossibly clearing bit fields in the pwdProperties
attribute.

12 years agos4:pwsettings: Run all updates as a single modify() operation.
Andrew Kroeger [Mon, 7 Sep 2009 06:47:35 +0000 (01:47 -0500)]
s4:pwsettings: Run all updates as a single modify() operation.

This ensures that all changes are made, or none are made.  It also makes it
possible to do validation as we go and abort in case of an error, while always
leaving things in a consistent state.

12 years agos4:pwsettings: Added --quiet option.
Andrew Kroeger [Mon, 7 Sep 2009 06:05:11 +0000 (01:05 -0500)]
s4:pwsettings: Added --quiet option.

Also changed all non-error status output to use the message() function, which
respects the --quiet option.

12 years agos4:netlogon - Put the "supported encryption types" more back in the "LogonGetDomainIn...
Matthias Dieter Wallnöfer [Wed, 9 Sep 2009 22:59:50 +0000 (00:59 +0200)]
s4:netlogon - Put the "supported encryption types" more back in the "LogonGetDomainInfo" call

They're needed only at the end.

12 years agoRevert "s4: Let the "setpassword" script finally use the "samdb_set_password" routine"
Matthias Dieter Wallnöfer [Wed, 9 Sep 2009 22:46:51 +0000 (00:46 +0200)]
Revert "s4: Let the "setpassword" script finally use the "samdb_set_password" routine"

This reverts commit fdd62e9699b181a140292689fcd88a559bc26211.

abartlet and I agreed that this isn't the right way to enforce the password
policies. Sooner or later we've to control them anyway on the directory level.

12 years agos4/torture: fixed lots of crash bugs in the DRS tests
Andrew Tridgell [Thu, 10 Sep 2009 12:58:11 +0000 (22:58 +1000)]
s4/torture: fixed lots of crash bugs in the DRS tests