Matthias Dieter Wallnöfer [Fri, 25 Sep 2009 20:41:14 +0000 (22:41 +0200)]
s3/s4:samr.idl - Corrects the "userPwdChangeFailureInformation" structure
This I've done according to WSPP doc MS-SAMR 2.2.7.23.
Jeremy Allison [Wed, 7 Oct 2009 22:43:43 +0000 (15:43 -0700)]
Oops. Don't break the build..
Jeremy.
Jeremy Allison [Wed, 7 Oct 2009 22:39:38 +0000 (15:39 -0700)]
Make the logic a lot clearer and fix the comment to match.
Jeremy
Matthias Dieter Wallnöfer [Tue, 6 Oct 2009 07:28:38 +0000 (09:28 +0200)]
s4:ldb - SQLite: port some constraints from the TDB backend also to the SQLITE one
Matthias Dieter Wallnöfer [Wed, 7 Oct 2009 10:38:00 +0000 (12:38 +0200)]
s4:subtree_delete - Make the initialisation of the child counter more clear
Matthias Dieter Wallnöfer [Tue, 6 Oct 2009 15:18:04 +0000 (17:18 +0200)]
s4:ldap.py - Further enhancements
- Enhance test for "distinguishedName"
- Add a test for single-valued attributes
- Add a test for multi-valued attributes
- Add a test for empty messages
- Add a test for empty attributes
Matthias Dieter Wallnöfer [Wed, 7 Oct 2009 21:49:29 +0000 (23:49 +0200)]
s4:ldb - add a check which has to be done on beginning of a "modify" operation
Matthias Dieter Wallnöfer [Tue, 6 Oct 2009 19:53:05 +0000 (21:53 +0200)]
s4:ldap server - remove unused error handlings
Those error cases should be handled by LDB itself to be available on all
connection methods and not only over LDAP.
Matthias Dieter Wallnöfer [Tue, 6 Oct 2009 07:30:53 +0000 (09:30 +0200)]
s4:ldb_tdb - Rework/Various
- Unify the error handling method with "done" mark in all longer functions
- Fix up result codes to match more the real MS AD
- Some cosmetic fixups
Jeremy Allison [Wed, 7 Oct 2009 22:14:50 +0000 (15:14 -0700)]
Correct fix for bug 6781 - Cannot rename subfolders in Explorer view with recent versions of Samba.
Without this fix, renaming a directory ./a to ./b, whilst a directory ./aa was already open
would fail.
Jeremy.
Aravind Srinivasan [Wed, 7 Oct 2009 03:16:38 +0000 (20:16 -0700)]
s4/torture: Ported SMBv1 RAW-OPEN tests to SMB2-CREATE
Four tests were ported from raw/open.c
One new tests added LEADING-SLASH, which tests that a server provides
the proper error when a relative path is given to a CREATE PDU
with a leading "/".
Aravind Srinivasan [Wed, 7 Oct 2009 03:12:09 +0000 (20:12 -0700)]
s4/torture: convert all printf to torture_comments
Aravind Srinivasan [Wed, 7 Oct 2009 03:25:15 +0000 (20:25 -0700)]
s4/torture: Ported SMBv1 RAW-STREAMS tests to SMB2-STREAMS
Kai Blin [Wed, 7 Oct 2009 13:45:17 +0000 (15:45 +0200)]
AD-Bench: A first go at an Active Directory benchmark.
Günther Deschner [Tue, 6 Oct 2009 15:46:25 +0000 (17:46 +0200)]
s3-winbindd: libwbclient: implement secure channel verification for specific domains in wbcCheckTrustCredentials().
Guenther
Günther Deschner [Wed, 7 Oct 2009 08:43:53 +0000 (10:43 +0200)]
wbinfo: allow to check trusts via "wbinfo -t --domain DOMAINNAME".
Guenther
Günther Deschner [Tue, 6 Oct 2009 15:45:24 +0000 (17:45 +0200)]
libwbclient: implement secure channel verification for specific domains in wbcCheckTrustCredentials().
Guenther
Günther Deschner [Tue, 6 Oct 2009 15:50:15 +0000 (17:50 +0200)]
s3-netlogon: pure cosmetic indent fixes in _netr_LogonControl2Ex().
Guenther
Günther Deschner [Wed, 7 Oct 2009 08:34:15 +0000 (10:34 +0200)]
s3: re-run make samba3-idl.
Guenther
Andrew Tridgell [Wed, 7 Oct 2009 05:21:28 +0000 (16:21 +1100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba
Andrew Tridgell [Wed, 7 Oct 2009 05:20:16 +0000 (16:20 +1100)]
s4-drs: fixed a memory error introduced yesterday
ids is retrurned via _ids, so it needs to be on the passed in mem_ctx
Steven Danneman [Sat, 3 Oct 2009 00:02:20 +0000 (17:02 -0700)]
s4/torture: Add server target of OneFS
I've added a "--target=onefs" which lists expected deviation in the
OneFS SMB server implementation compared to a Windows machine.
I've added this in a generic way using a list of module specific
parameters. This list currently only contains the absence of
SACL support but will be added to as additional server differences
are defined.
I'd liked to use this abstraction for defining the differences between
a WinXP and Win7 server as well.
Aravind Srinivasan [Tue, 6 Oct 2009 23:57:34 +0000 (16:57 -0700)]
s4/torture: Add SMB sharemode/access mask tests
Test several thousand permutations of create mask and sharemodes on file
and directory opens.
These tests use a checked-in results table derived from a WinXP server to
verify correct server behavior.
CREATEX_ACCESS
CREATEX_SHAREMODES_FILE
CREATEX_SHAREMODES_DIR
MAXIMUM_ALLOWED
Aravind Srinivasan [Tue, 6 Oct 2009 23:43:43 +0000 (16:43 -0700)]
s4/torture: change comments to torture_failures
This allows the frameworks that wrap smbtorture to detect errors
better.
Jeremy Allison [Wed, 7 Oct 2009 00:18:15 +0000 (17:18 -0700)]
Test creating and deleting a bad symlink using the POSIX calls. Ensure
we don't regress on bug 6769.
Jeremy.
Andrew Tridgell [Tue, 6 Oct 2009 23:55:35 +0000 (10:55 +1100)]
torture: disable the ValidatePassword test
This test causes problems on non-sealed connections against windows
Andrew Tridgell [Tue, 6 Oct 2009 23:05:26 +0000 (10:05 +1100)]
s4-torture: removed an accidental commit of a local test hack
Sorry about that ....
Andrew Tridgell [Tue, 6 Oct 2009 19:39:03 +0000 (06:39 +1100)]
tdr: teach TDR about uint1632 enums
TDB doesn't have NDR64, but it needs to know how to map the new types
from pidl
Andrew Tridgell [Tue, 6 Oct 2009 09:49:14 +0000 (20:49 +1100)]
pidl: update PIDL tests for uint1632 enums
Andrew Tridgell [Tue, 6 Oct 2009 09:47:42 +0000 (20:47 +1100)]
idl: recompile IDL for uint1632 change
Andrew Tridgell [Tue, 6 Oct 2009 09:47:09 +0000 (20:47 +1100)]
pidl: get the alignment right for uint1632 enums (NDR64)
The default enum in NDR63 is 32 bits, not 16 bits. We need a uint1632
type to get the alignment right.
Volker Lendecke [Tue, 6 Oct 2009 19:31:02 +0000 (21:31 +0200)]
s3:winbind: Make query_user_list in winbindd_rpc a bit more readable
Matthias Dieter Wallnöfer [Tue, 6 Oct 2009 17:27:17 +0000 (19:27 +0200)]
s4:various LDB modules - "build_request" functions - propagate result codes back
It's very useful to know the exact result code when something fails and not
only a generic (by the module) created one.
Sure, there are some exception cases with specific results (special message
constellations, attributes, values...) which shouldn't be changed at all
(examples of them are in the "ldap.py" test). Therefore I looked very
carefully to not change them.
Matthias Dieter Wallnöfer [Tue, 6 Oct 2009 17:26:15 +0000 (19:26 +0200)]
s4:rootdse module - intendation fixup
Matthias Dieter Wallnöfer [Tue, 6 Oct 2009 17:24:28 +0000 (19:24 +0200)]
s4:acl module - intendation fix and comment enhancement
Abhidnya P Chirmule [Tue, 6 Oct 2009 15:14:56 +0000 (17:14 +0200)]
s3: Add access_mask to the flock VFS call
Günther Deschner [Mon, 5 Oct 2009 15:05:38 +0000 (17:05 +0200)]
s3-winbindd: make sure to reset connections when machine account password change chain was broken.
Guenther
Günther Deschner [Mon, 5 Oct 2009 15:04:52 +0000 (17:04 +0200)]
s3-netlogon: setup NETLOGON credential chain in rpccli_netlogon_set_trust_password() only when needed.
Guenther
Ronnie Sahlberg [Sun, 4 Oct 2009 05:57:57 +0000 (16:57 +1100)]
add trailer alignment to structures
ronnie sahlberg [Tue, 6 Oct 2009 06:49:59 +0000 (17:49 +1100)]
PIDL fix for using external types with wireshark backend
List,
Please review this patch to pidl.
Basically, we need to process the wireshark conformance file BEFORE
we process the idl file since this file may define external types
and set the alignment for them (using the TYPE directive).
Otherwise pidl will default all external types to use 4byte alignment
which breaks (much more often) on NDR64
regards
ronnie sahlberg
From
8f86903fc353d0906bd82e72ce19c5af09beb001 Mon Sep 17 00:00:00 2001
From: Ronnie Sahlberg <ronniesahlberg@gmail.com>
Date: Mon, 5 Oct 2009 15:22:43 +1100
Subject: [PATCH] In the PIDL wireshark backend, we define external types in the conformance
file using the TYPE directive.
If we declare external types here, we must parse this file before we process
the IDL file, or else these external types will all default to 4byte padding
(pidl assumes all unknown types are 4byte aligned).
Make sure we read the conformance file and create these new types before
we parse the idl file.
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
Andrew Tridgell [Tue, 6 Oct 2009 08:05:15 +0000 (19:05 +1100)]
s4-provision: match win2003 functional level
We are now defaulting to win2003 functional level, and see to report
the right revisions of our db and schema
Andrew Tridgell [Tue, 6 Oct 2009 07:59:47 +0000 (18:59 +1100)]
s4-drs: added some debug lines to DsAddEntry()
Andrew Tridgell [Tue, 6 Oct 2009 07:59:30 +0000 (18:59 +1100)]
s4-drs: take advantage of system session auth in dsbind
Now that the bind opens samdb with the right credentials, we no longer
need the re-open in updaterefs and getncchanges
Andrew Tridgell [Tue, 6 Oct 2009 07:58:41 +0000 (18:58 +1100)]
s4-drs: fixed error message for drs_security_level_check
Andrew Tridgell [Tue, 6 Oct 2009 07:58:13 +0000 (18:58 +1100)]
s4-drs: open samdb with system credentials when authorised
When a DC connects to DRS, open the samdb with system session
credentials, so that we don't have to re-open it each time on other
calls.
Andrew Tridgell [Tue, 6 Oct 2009 07:57:06 +0000 (18:57 +1100)]
s4-ldb: fixed error on single value error
When you try to add a 2nd value to a single valued attribute you get
LDB_ERR_ATTRIBUTE_OR_VALUE_EXISTS. w2k8-r2 join to s4 relies on this
error, doing a replace after it sees the error
Andrew Tridgell [Tue, 6 Oct 2009 07:55:14 +0000 (18:55 +1100)]
s4-repl: added RELAX control and fix transactions
Added the RELAX control to dsdb_origin_objects_commit(), as it needs
to modify system objects. This patch also fixes the use of ldb
transactions in that function, and fixes a memory leak.
Andrew Bartlett [Mon, 5 Oct 2009 23:59:36 +0000 (10:59 +1100)]
s4:drs-development Scripts to assist testing of DRS replication with AD
These scripts, originally by tridge, allow developers to easily
reproduce the same domain join senerio time after time.
They need documentation, and the template named.conf and zone files
for hosting an AD domain are not provided. However, I hope to have
the provision script provide these shortly.
They assume a local 'bind' set up to read PREFIX/private/named.conf
(as per the provision instructions).
Ensure you edit the 'vars' file to match your local setup.
Andrew Bartlett
Andrew Bartlett [Fri, 2 Oct 2009 02:01:33 +0000 (12:01 +1000)]
s4:param Remove duplicate argument to python provision
Andrew Bartlett [Fri, 2 Oct 2009 02:01:00 +0000 (12:01 +1000)]
s4:provision Remove unused parameters from provision scripts
Andrew Tridgell [Mon, 5 Oct 2009 22:18:53 +0000 (09:18 +1100)]
s4-seftest: skip hold.oplock for SMB2 as well
This test is not designed to be run automatically. It deliberately
blocks forever.
Volker Lendecke [Mon, 5 Oct 2009 20:14:06 +0000 (22:14 +0200)]
Revert "s3: Attempt to fix machine password change"
This reverts commit
20a8ea91e10af167067cc794a251265aaf489e75.
Ooops, this should not have been committed.
Volker Lendecke [Mon, 5 Oct 2009 20:09:01 +0000 (22:09 +0200)]
s3:winbind: Slightly simplify the logic of nss_init(), make it static
Volker Lendecke [Mon, 5 Oct 2009 20:00:16 +0000 (22:00 +0200)]
s3:winbind: Fix typos
Volker Lendecke [Sun, 4 Oct 2009 13:47:33 +0000 (15:47 +0200)]
s3: Attempt to fix machine password change
Jeremy Allison [Mon, 5 Oct 2009 17:27:48 +0000 (10:27 -0700)]
Fix bug 6776 - Running overlapping Byte Lock test will core dump Samba daemon.
Re-write core of POSIX locking logic.
Jeremy.
Günther Deschner [Mon, 5 Oct 2009 13:10:35 +0000 (15:10 +0200)]
libndr: add int3264 ndr prototype.
Guenther
Günther Deschner [Mon, 5 Oct 2009 11:01:53 +0000 (13:01 +0200)]
s3-net: print error when "net rpc changetrustpw" has failed.
Guenther
Volker Lendecke [Sun, 4 Oct 2009 13:19:19 +0000 (15:19 +0200)]
s3: Remove a scary error message -- talloc_move can not fail :-)
Signed-off-by: Günther Deschner <gd@samba.org>
Volker Lendecke [Sun, 4 Oct 2009 13:13:44 +0000 (15:13 +0200)]
s3: Fix nonempty blank lines
Signed-off-by: Günther Deschner <gd@samba.org>
Günther Deschner [Thu, 1 Oct 2009 23:25:13 +0000 (01:25 +0200)]
lib/tdr: get rid of build warning when using TDR_ALLOC macro.
Guenther
Günther Deschner [Thu, 1 Oct 2009 11:42:29 +0000 (13:42 +0200)]
s3: remove unused PRS_POINTER_CAST macro.
Guenther
Günther Deschner [Thu, 1 Oct 2009 10:52:46 +0000 (12:52 +0200)]
s3: remove unused SYSTEMTIME struct.
Guenther
Matthias Dieter Wallnöfer [Tue, 29 Sep 2009 10:01:15 +0000 (12:01 +0200)]
s3/s4 common: fix up header file
Björn Jacke [Sat, 3 Oct 2009 23:40:34 +0000 (01:40 +0200)]
s3:Makefile: another attempt to fix the wbclient dependency
in the dependencies we always used a variable that was not jet defined.
Björn Jacke [Sat, 3 Oct 2009 23:33:12 +0000 (01:33 +0200)]
s3:Makefile: another attempt to fix the netapi dependency
in the dependencies we always used a variable that was not jet defined.
Björn Jacke [Sat, 3 Oct 2009 23:30:43 +0000 (01:30 +0200)]
s3:Makefile: another attempt to fix the tdb dependency
in the dependencies we always used a variable that was not jet defined.
Björn Jacke [Sat, 3 Oct 2009 23:20:38 +0000 (01:20 +0200)]
s3:Makefile: another attempt to fix the talloc dependency
in the dependencies we always used a variable that was not jet defined.
Björn Jacke [Sat, 3 Oct 2009 21:04:12 +0000 (23:04 +0200)]
Revert "s3:Makefile: fix talloc dependencies with static build (2nd try)"
This reverts commit
b60d87c20712bd3d83166bd13fe1d2bab0315609.
Björn Jacke [Sat, 3 Oct 2009 21:00:37 +0000 (23:00 +0200)]
Revert "s3:Makefile: fix libtdb dependencies with static build"
This reverts commit
da15726630b0f796aef52a20d96898e269058456.
Björn Jacke [Sat, 3 Oct 2009 20:53:52 +0000 (22:53 +0200)]
Revert "s3:Makefile: fix libwbclient dependencies with static build"
This reverts commit
d7795f2afa3779399fe9e7b4f050d19a412f8bcd.
Björn Jacke [Sat, 3 Oct 2009 20:53:15 +0000 (22:53 +0200)]
Revert "s3:Makefile: fix libnetapi dependencies with static build"
This reverts commit
110897a057af01f3c01a1783e06080b54631ba2d.
Volker Lendecke [Sat, 3 Oct 2009 15:10:53 +0000 (17:10 +0200)]
s3:winbind: use wb_fill_pwent in wb_getpwsid
Volker Lendecke [Sat, 3 Oct 2009 15:11:43 +0000 (17:11 +0200)]
s3:winbind: No point in using strequal to detect a 0-length string
Matthias Dieter Wallnöfer [Sat, 3 Oct 2009 14:50:34 +0000 (16:50 +0200)]
s4:ldap.py - commented out the UTF8 tests (and fixed some deletion DNs)
Volker Lendecke [Sat, 3 Oct 2009 14:43:01 +0000 (16:43 +0200)]
s3:winbind: use talloc_tos() instead of NULL in fillup_pw_field
Volker Lendecke [Sat, 3 Oct 2009 14:36:11 +0000 (16:36 +0200)]
s3:winbind: Fix a debug message
Matthias Dieter Wallnöfer [Sat, 3 Oct 2009 13:37:25 +0000 (15:37 +0200)]
s4:ldb_tdb - fix memory leaks
Matthias Dieter Wallnöfer [Sat, 3 Oct 2009 13:36:44 +0000 (15:36 +0200)]
heimdal kerberos - fix memory leak (free the plugin list always - not only in error cases)
Matthias Dieter Wallnöfer [Sat, 3 Oct 2009 13:08:19 +0000 (15:08 +0200)]
s4:objectclass - Free unused memory from responses
Matthias Dieter Wallnöfer [Sat, 3 Oct 2009 13:08:00 +0000 (15:08 +0200)]
s4:schema_inferiors - Fix wrong check
Volker Lendecke [Sat, 3 Oct 2009 12:21:13 +0000 (14:21 +0200)]
s3: Make default_[static|shared]_modules a bit more readable
Matthias Dieter Wallnöfer [Thu, 1 Oct 2009 09:37:01 +0000 (11:37 +0200)]
s4:ldb.h - add constant for LDAP EXOP password change
Also enhance some other comments.
Matthias Dieter Wallnöfer [Tue, 29 Sep 2009 09:43:17 +0000 (11:43 +0200)]
heimdal - fix various warnings
- Shadowed variables
- "const" related warnings
- Parameter names which shadow function declarations
- Non-void functions which have no return value
(patch also ported upstream)
Matthias Dieter Wallnöfer [Sat, 3 Oct 2009 09:37:30 +0000 (11:37 +0200)]
s4:ldap.py - add tests for valid parent and RDN
Andrew Bartlett [Thu, 24 Sep 2009 22:14:49 +0000 (15:14 -0700)]
s4:dsdb Use possibleInferiors to restrict creation of child objects
This also uses systemPossibleInferiors when the 'relax' control is
specified, which is done by the provision.
Andrew Bartlett
Andrew Bartlett [Thu, 24 Sep 2009 22:12:49 +0000 (15:12 -0700)]
s4:dsdb add systemPossibleInferiors to schema code
This allows us to figure out what the system can add, which will not
be in possibleInferiors due to the systemOnly flag.
Andrew Bartlett
Andrew Bartlett [Thu, 24 Sep 2009 04:16:42 +0000 (21:16 -0700)]
s4:dsdb Add objectClass and RDN constraints to objectClass module
These additional constraints are applied, found by the Microsoft testsuite.
- When the parent is not present, we now return 'NO_SUCH_OBJECT'.
- Restrict the choice of RDN to the correct one per the schema
- Honour the allowedChildClasses attribute from the parent's objectClass.
Andrew Bartlett
Andrew Tridgell [Sat, 3 Oct 2009 09:02:27 +0000 (19:02 +1000)]
ndr: rebuild lsa IDL after recent change
Matthias Dieter Wallnöfer [Sat, 3 Oct 2009 08:57:14 +0000 (10:57 +0200)]
s4:ldap.py - add a test for the "systemOnly" classes
Matthias Dieter Wallnöfer [Sat, 3 Oct 2009 08:52:53 +0000 (10:52 +0200)]
s4:dsdb Don't allow creation of systemOnly objectclasses
(except as part of the provision, which specifies the 'relax' control)
Andrew Bartlett
Matthias Dieter Wallnöfer [Sat, 3 Oct 2009 08:36:41 +0000 (10:36 +0200)]
s4:rdn_name - fix up the rename operation
A function call was wrong ("ldb_request" rathen than "ldb_next_request").
Andrew Tridgell [Sat, 3 Oct 2009 08:13:50 +0000 (18:13 +1000)]
idl: some lsa vars are uint3264
Andrew Tridgell [Sat, 3 Oct 2009 08:13:25 +0000 (18:13 +1000)]
pidl: added int3264 as a base type
This is the type used for a variable that is 32 bits for NDR32 and 64
bits for NDR64
Björn Jacke [Fri, 2 Oct 2009 22:19:30 +0000 (00:19 +0200)]
s3:Makefile: minor clean up
Björn Jacke [Fri, 2 Oct 2009 22:15:19 +0000 (00:15 +0200)]
s3:Makefile: fix libnetapi dependencies with static build
analogical to previous libtalloc fix
Björn Jacke [Fri, 2 Oct 2009 21:08:11 +0000 (23:08 +0200)]
s3:Makefile: eventlogadm dependency cleanup
no need to link against popt lib
Björn Jacke [Fri, 2 Oct 2009 21:05:27 +0000 (23:05 +0200)]
s3:Makefile: fix libwbclient dependencies with static build
analogical to previous libtalloc fix
Björn Jacke [Fri, 2 Oct 2009 21:01:18 +0000 (23:01 +0200)]
s3:Makefile: fix libtdb dependencies with static build
analogical to previous libtalloc fix
Björn Jacke [Fri, 2 Oct 2009 20:43:14 +0000 (22:43 +0200)]
s3:Makefile: fix talloc dependencies with static build (2nd try)
When configure options --with-libtalloc=no --enable-shared-libs=no are used,
LIBTALLOC_TARGET stays empty. Actually LIBTALLOC_TARGET which is only used for
Makefile dependencies is obsolete as LIBTALLOC contains exactly the targets
that we depend on, libtalloc finally is the target to depend on.