ira/wip.git
11 years agos3-docs: fix eventlogadm manpage typo.
Günther Deschner [Thu, 7 Jan 2010 11:05:18 +0000 (12:05 +0100)]
s3-docs: fix eventlogadm manpage typo.

Guenther

11 years agos3: Lock down some srvsvc calls according to what w2k3 seems to do
Volker Lendecke [Thu, 7 Jan 2010 10:47:09 +0000 (11:47 +0100)]
s3: Lock down some srvsvc calls according to what w2k3 seems to do

11 years agos3:auth:check_sam_security: improve calling and logging of pdb_update_sam_account
Michael Adam [Wed, 6 Jan 2010 12:53:10 +0000 (13:53 +0100)]
s3:auth:check_sam_security: improve calling and logging of pdb_update_sam_account

Log what went wrongl, and also call pdb_update_sam_account inside
become_root/unbecome_root: do the logging outside.

Michael

11 years agos3:auth:check_sam_security: fix a leading tab/ws mixup
Michael Adam [Wed, 6 Jan 2010 12:40:58 +0000 (13:40 +0100)]
s3:auth:check_sam_security: fix a leading tab/ws mixup

Michael

11 years agos3:auth:check_sam_security: create (and use) a common exit point
Michael Adam [Wed, 6 Jan 2010 11:36:56 +0000 (12:36 +0100)]
s3:auth:check_sam_security: create (and use) a common exit point

for use after sam_password_ok() has been called.

Michael

11 years agos3:auth:check_sam_security: null out sampass after it has been stolen.
Michael Adam [Wed, 6 Jan 2010 11:32:51 +0000 (12:32 +0100)]
s3:auth:check_sam_security: null out sampass after it has been stolen.

So that a later talloc_free would not harm. I could have used
talloc_move instead of talloc steal in make_server_info_sam(),
but this would have required a change of the signature.

Michael

11 years agos3:auth:sam_password_ok: take username, acct_ctrl and nt/lm hashes, not sampass
Michael Adam [Mon, 4 Jan 2010 17:15:24 +0000 (18:15 +0100)]
s3:auth:sam_password_ok: take username, acct_ctrl and nt/lm hashes, not sampass

This is in preparation to extending check_sam_security to also check
against the password history before updating the bad password count.
This way, sam_password_ok can more easily be reused for that purpose.

Michael

11 years agos3:auth: use data_blob_null instead of data_blob(NULL, 0) in sam_password_ok()
Michael Adam [Mon, 4 Jan 2010 14:37:24 +0000 (15:37 +0100)]
s3:auth: use data_blob_null instead of data_blob(NULL, 0) in sam_password_ok()

This way it is more explicit that there is no allocated data here
that may leak.

Michael

11 years agos3:auth:sam_password_ok: fix allocation of a data blob.
Michael Adam [Wed, 30 Dec 2009 14:37:23 +0000 (15:37 +0100)]
s3:auth:sam_password_ok: fix allocation of a data blob.

data_blob(mem_ctx, 16) does not use mem_ctx as a talloc ctx but
copies 16 bytes from mem_ctx into the newly allocated data blob.
This can not have been intentional. A blank uint8_t array of
length 16 is allocated by passing NULL instead of mem_ctx.
And using data_blob_talloc(mem_ctx, NULL, 16) adds the allocated
blank 16 byte array to mem_ctx - so this is what must have been
intended.

Michael

11 years agos3:auth:sam_password_ok: enhance readability (imho) by adding some pointers
Michael Adam [Wed, 30 Dec 2009 14:35:50 +0000 (15:35 +0100)]
s3:auth:sam_password_ok: enhance readability (imho) by adding some pointers

and removing bool variables and several checks.

Michael

11 years agos3:check_sam_security: untangle assignment from statement
Michael Adam [Wed, 30 Dec 2009 11:46:22 +0000 (12:46 +0100)]
s3:check_sam_security: untangle assignment from statement

Michael

11 years agos3: Factor password_in_history() out of check_passwd_history()
Volker Lendecke [Mon, 14 Dec 2009 19:54:33 +0000 (20:54 +0100)]
s3: Factor password_in_history() out of check_passwd_history()

11 years agoSimplify E_md5hash a bit
Volker Lendecke [Mon, 14 Dec 2009 18:29:36 +0000 (19:29 +0100)]
Simplify E_md5hash a bit

11 years agos3: Simplify pdb_set_plaintext_passwd: pwhistory==NULL can not happen anymore
Volker Lendecke [Mon, 14 Dec 2009 18:18:09 +0000 (19:18 +0100)]
s3: Simplify pdb_set_plaintext_passwd: pwhistory==NULL can not happen anymore

11 years agos3: Simplify pdb_set_plaintext_passwd: pwHistLen==0 was checked above
Volker Lendecke [Mon, 14 Dec 2009 18:16:58 +0000 (19:16 +0100)]
s3: Simplify pdb_set_plaintext_passwd: pwHistLen==0 was checked above

11 years agos3: Add a paranoia check to pdb_set_plaintext_passwd()
Volker Lendecke [Mon, 14 Dec 2009 18:12:50 +0000 (19:12 +0100)]
s3: Add a paranoia check to pdb_set_plaintext_passwd()

11 years agos3: Simplify pdb_set_plaintext_passwd() by removing a redundant condition
Volker Lendecke [Mon, 14 Dec 2009 17:50:38 +0000 (18:50 +0100)]
s3: Simplify pdb_set_plaintext_passwd() by removing a redundant condition

if (current_history_len != pwHistLen) {
     if (current_history_len < pwHistLen) {
     }
}

The second "if" is a bit pointless here

11 years agos3: Simplify pdb_set_plaintext_passwd: memcpy deals fine with 0 bytes
Volker Lendecke [Mon, 14 Dec 2009 17:44:38 +0000 (18:44 +0100)]
s3: Simplify pdb_set_plaintext_passwd: memcpy deals fine with 0 bytes

11 years agos3: Simplify pdb_set_plaintext_passwd by using talloc_zero_array
Volker Lendecke [Mon, 14 Dec 2009 17:43:03 +0000 (18:43 +0100)]
s3: Simplify pdb_set_plaintext_passwd by using talloc_zero_array

11 years agos3: Make use of talloc_array in pdb_set_plaintext_passwd()
Volker Lendecke [Mon, 14 Dec 2009 17:39:19 +0000 (18:39 +0100)]
s3: Make use of talloc_array in pdb_set_plaintext_passwd()

11 years agos3: Simplify pdb_set_plaintext_passwd() a bit
Volker Lendecke [Mon, 14 Dec 2009 17:24:04 +0000 (18:24 +0100)]
s3: Simplify pdb_set_plaintext_passwd() a bit

Remove an indentation by the early return in

+       if (pwHistLen == 0) {
+               /* Set the history length to zero. */
+               pdb_set_pw_history(sampass, NULL, 0, PDB_CHANGED);
+               return true;
+       }

11 years agos3: Simplify pdb_set_plaintext_passwd() slightly
Volker Lendecke [Mon, 14 Dec 2009 17:13:28 +0000 (18:13 +0100)]
s3: Simplify pdb_set_plaintext_passwd() slightly

No functional change, this just removes an indentation level by the early
"return True;" in

+       if ((pdb_get_acct_ctrl(sampass) & ACB_NORMAL) == 0) {
+               /*
+                * No password history for non-user accounts
+                */
+               return true;
+       }

Volker

11 years agos3: Fix a typo
Volker Lendecke [Mon, 14 Dec 2009 16:51:39 +0000 (17:51 +0100)]
s3: Fix a typo

11 years agos3: Avoid a memset(, 0, ) call
Volker Lendecke [Mon, 14 Dec 2009 16:43:56 +0000 (17:43 +0100)]
s3: Avoid a memset(, 0, ) call

11 years agos3:pdb_set_pw_history: free the old history before setting the new.
Michael Adam [Tue, 5 Jan 2010 16:24:17 +0000 (17:24 +0100)]
s3:pdb_set_pw_history: free the old history before setting the new.

This is not strictly necessary, since this only leaks into the
struct samu, and this is not so long-lived in the code path that
changes the password, but it definitely correct and does not harm.

Michael

11 years agos3:pdb_ldap:init_sam_from_ldap: untangle an assignment from the check
Michael Adam [Tue, 5 Jan 2010 17:22:25 +0000 (18:22 +0100)]
s3:pdb_ldap:init_sam_from_ldap: untangle an assignment from the check

to enhance readability and denbuggability.

Michael

11 years agos4/torture: fix small bug in lock test
Steven Danneman [Fri, 18 Dec 2009 23:35:35 +0000 (15:35 -0800)]
s4/torture: fix small bug in lock test

Cleanup path should unlock, not cancel existing locked range.

11 years agos4/torture: add more lock cancellation tests
Steven Danneman [Wed, 16 Dec 2009 22:38:56 +0000 (14:38 -0800)]
s4/torture: add more lock cancellation tests

* Test the SMB1 behavior when multiple lock ranges are requested, pend,
  and then are cancelled.  The entire LockingAndX request fails.

11 years agos3:lib/time: remove TIME_T_MIN/MAX defines
Björn Jacke [Wed, 6 Jan 2010 23:41:50 +0000 (00:41 +0100)]
s3:lib/time: remove TIME_T_MIN/MAX defines

we already get them from lib/util/time.h

11 years agolib/util: move TIME_T_MIN/MAX defines into header file
Björn Jacke [Wed, 6 Jan 2010 23:40:09 +0000 (00:40 +0100)]
lib/util: move TIME_T_MIN/MAX defines into header file

11 years agoѕ3:lib/time: replace make_dos_ and put_dos_ functions with those from lib/util/
Björn Jacke [Wed, 6 Jan 2010 22:24:48 +0000 (23:24 +0100)]
ѕ3:lib/time: replace make_dos_ and put_dos_ functions with those from lib/util/

11 years agos3:lib/time: remoce null_mtime() - use null_time()
Björn Jacke [Wed, 6 Jan 2010 20:32:35 +0000 (21:32 +0100)]
s3:lib/time: remoce null_mtime() - use null_time()

11 years agos3:lib/time: remove unused nt_time_equals
Björn Jacke [Wed, 6 Jan 2010 18:31:41 +0000 (19:31 +0100)]
s3:lib/time: remove unused nt_time_equals

we have nt_time_equal doing the same in lib/util/

11 years agoSecond part of the fix for bug #7020 - smbd using 2G memory.
Jeremy Allison [Wed, 6 Jan 2010 21:11:00 +0000 (13:11 -0800)]
Second part of the fix for bug #7020 - smbd using 2G memory.

There was a second leak in the processing of the out_data.frag
prs_struct. It needs freeing once the current pdu has been returned
asynchronously.

Jeremy.

11 years agos4-smbtorture: add test_ChangeID to RPC-SPOOLSS.
Günther Deschner [Wed, 6 Jan 2010 18:34:33 +0000 (19:34 +0100)]
s4-smbtorture: add test_ChangeID to RPC-SPOOLSS.

This tests ChangeID consistency between spoolss_GetPrinterData,
spoolss_GetPrinterDataEx and spoolss_GetPrinter (level 0).

Guenther

11 years agos4-smbtorture: add test_SetPrinter to RPC-SPOOLSS.
Günther Deschner [Wed, 6 Jan 2010 18:33:39 +0000 (19:33 +0100)]
s4-smbtorture: add test_SetPrinter to RPC-SPOOLSS.

Guenther

11 years agos4-smbtorture: refactor test_GetPrinter in RPC-SPOOLSS.
Günther Deschner [Wed, 6 Jan 2010 16:51:34 +0000 (17:51 +0100)]
s4-smbtorture: refactor test_GetPrinter in RPC-SPOOLSS.

Guenther

11 years agoѕ3:configure: use gettimeofday check from lib/util/
Björn Jacke [Wed, 6 Jan 2010 14:32:15 +0000 (15:32 +0100)]
ѕ3:configure: use gettimeofday check from lib/util/

11 years agovfs_commit: print warning when no fsync support is there
Björn Jacke [Sun, 13 Dec 2009 20:56:28 +0000 (21:56 +0100)]
vfs_commit: print warning when no fsync support is there

this one was part of an old patch from jpeach.

11 years agotdb: fix standalone 'make installdocs'
Stefan Metzmacher [Wed, 6 Jan 2010 13:39:43 +0000 (14:39 +0100)]
tdb: fix standalone 'make installdocs'

metze

11 years agotdb: create symbol links to shared libraries see https://bugzilla.samba.org/show_bug...
Brian Lu [Thu, 17 Dec 2009 06:39:09 +0000 (14:39 +0800)]
tdb: create symbol links to shared libraries see https://bugzilla.samba.org/show_bug.cgi?id=6991 for details

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agotalloc: create symbol links to shared libraries see https://bugzilla.samba.org/show_b...
Brian Lu [Thu, 17 Dec 2009 06:48:59 +0000 (14:48 +0800)]
talloc: create symbol links to shared libraries see https://bugzilla.samba.org/show_bug.cgi?id=6991 for details

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agotevent: create symbol links to shared libraries see https://bugzilla.samba.org/show_b...
Brian Lu [Thu, 17 Dec 2009 06:55:57 +0000 (14:55 +0800)]
tevent: create symbol links to shared libraries see https://bugzilla.samba.org/show_bug.cgi?id=6991 for details

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos4: Fix result check for getaddrinfo()
Kamen Mazdrashki [Wed, 6 Jan 2010 11:40:33 +0000 (13:40 +0200)]
s4: Fix result check for getaddrinfo()

I think this completes commit 50feca550eed7828198b7c0fc5f0e5ddc863313d.
Now result should be handled correctly both for systems that
support EAI_NODATA but returns EAI_NONAME (as my Ubuntu 9.x)
and systems that doesn't support EAI_NODATA at all.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agoFix bug #7020 - smbd using 2G memory.
Jeremy Allison [Tue, 5 Jan 2010 22:34:00 +0000 (14:34 -0800)]
Fix bug #7020 - smbd using 2G memory.

When deferring an async pipe writeX and readX transfer
the outstanding request struct onto the conn struct. This
needs freeing after the packet is finally processed.

Jeremy.

11 years agos4:SAMLDB LDB module - Fix trailing whitespaces
Matthias Dieter Wallnöfer [Sun, 3 Jan 2010 20:47:36 +0000 (21:47 +0100)]
s4:SAMLDB LDB module - Fix trailing whitespaces

11 years agos4:SAMLDB LDB module - Rework to allow checks for wrong "defaultObjectCategory" attri...
Matthias Dieter Wallnöfer [Sun, 3 Jan 2010 19:36:09 +0000 (20:36 +0100)]
s4:SAMLDB LDB module - Rework to allow checks for wrong "defaultObjectCategory" attributes

This allows a stricter check for "defaultObjectCategory" attributes which is
performed when the "relax" control isn't specified.
Additional note: As the added comment points out this isn't complete.
And I personally think that moving this at some point to the "objectclass"
module is a better idea to make this fully work (since there we have direct
access to the schema). If someone has a good idea how to do this please inform
me.

Anyway, the SAMLDB module does require some restructure since at the moment it's
very overloaded and therefore a bit a mess. In the meantime I started to work
on a new approach to realise it in a better way.

11 years agos4:schema_load.c - Typo
Matthias Dieter Wallnöfer [Sun, 3 Jan 2010 18:54:53 +0000 (19:54 +0100)]
s4:schema_load.c - Typo

11 years agos4:ldap_schema.py - add an additional check for validity of "defaultObjectCategory"
Matthias Dieter Wallnöfer [Sun, 3 Jan 2010 18:53:01 +0000 (19:53 +0100)]
s4:ldap_schema.py - add an additional check for validity of "defaultObjectCategory"

11 years agos4:ldap_schema.py - Move generated attributes check
Matthias Dieter Wallnöfer [Sun, 3 Jan 2010 18:43:52 +0000 (19:43 +0100)]
s4:ldap_schema.py - Move generated attributes check

Make more clear that they're created before the "schemaUpdateNow".

11 years agos3: List trusted domains from wcache when domain is offline.
Bo Yang [Wed, 6 Jan 2010 11:13:59 +0000 (19:13 +0800)]
s3: List trusted domains from wcache when domain is offline.

Signed-off-by: Bo Yang <boyang@samba.org>
11 years agos3: Make winbindd_cache.c aware of domain offline to avoid unnecessary backend query.
Bo Yang [Wed, 6 Jan 2010 07:05:20 +0000 (15:05 +0800)]
s3: Make winbindd_cache.c aware of domain offline to avoid unnecessary backend query.

Signed-off-by: Bo Yang <boyang@samba.org>
11 years agos3: Fix infinite loop in NCACN_IP_TCP asa there is no timeout. Assume lsa_pipe_tcp...
Bo Yang [Wed, 6 Jan 2010 04:13:35 +0000 (12:13 +0800)]
s3: Fix infinite loop in NCACN_IP_TCP asa there is no timeout. Assume lsa_pipe_tcp is ok but network is down, then send request is ok, but select() on writeable fds loops forever since there is no response.

Signed-off-by: Bo Yang <boyang@samba.org>
11 years agos3 net: Fix up a share type translation and translate some more strings
Kai Blin [Tue, 5 Jan 2010 08:54:04 +0000 (09:54 +0100)]
s3 net: Fix up a share type translation and translate some more strings

11 years agos3 net: Add a few missing gettext calls.
Kai Blin [Tue, 5 Jan 2010 08:43:34 +0000 (09:43 +0100)]
s3 net: Add a few missing gettext calls.

Many many thanks to Adi Roiban from #ubuntu-translators for helping me find
and fix my problems with the translations.

11 years agoFix the merged build. Probably not strictly correct but allows us to "make test".
Jeremy Allison [Mon, 4 Jan 2010 21:27:48 +0000 (13:27 -0800)]
Fix the merged build. Probably not strictly correct but allows us to "make test".
Jeremy.

11 years agos4:dsdb/repl: convert dreplsrv_out_drsuapi_send/recv to tevent_req
Stefan Metzmacher [Wed, 23 Dec 2009 16:44:40 +0000 (17:44 +0100)]
s4:dsdb/repl: convert dreplsrv_out_drsuapi_send/recv to tevent_req

metze

11 years agoblackbox/test_export_keytab.sh: correctly remove temporary files
Stefan Metzmacher [Mon, 4 Jan 2010 08:27:23 +0000 (09:27 +0100)]
blackbox/test_export_keytab.sh: correctly remove temporary files

metze

11 years agoblackbox/test_export_keytab.sh: use VALGRIND for samba4kinit
Stefan Metzmacher [Mon, 4 Jan 2010 08:26:25 +0000 (09:26 +0100)]
blackbox/test_export_keytab.sh: use VALGRIND for samba4kinit

metze

11 years agos4: Happy New Year 2010
Stefan Metzmacher [Mon, 4 Jan 2010 07:42:49 +0000 (08:42 +0100)]
s4: Happy New Year 2010

metze

11 years agos3: Happy New Year 2010
Stefan Metzmacher [Mon, 4 Jan 2010 07:42:03 +0000 (08:42 +0100)]
s3: Happy New Year 2010

metze

11 years agos3: Trim down smbcontrol a bit
Volker Lendecke [Sun, 3 Jan 2010 12:55:54 +0000 (13:55 +0100)]
s3: Trim down smbcontrol a bit

11 years agos3: Fix a shadowed variable warning
Volker Lendecke [Sun, 3 Jan 2010 11:58:31 +0000 (12:58 +0100)]
s3: Fix a shadowed variable warning

11 years agos3: Fix an uninitialized variable warning
Volker Lendecke [Sun, 3 Jan 2010 11:58:01 +0000 (12:58 +0100)]
s3: Fix an uninitialized variable warning

11 years agos3: Convert cli_ulogoff to the async API
Volker Lendecke [Sun, 3 Jan 2010 12:03:42 +0000 (13:03 +0100)]
s3: Convert cli_ulogoff to the async API

11 years agos3: Convert cli_tdis to the async API
Volker Lendecke [Sun, 3 Jan 2010 17:46:57 +0000 (18:46 +0100)]
s3: Convert cli_tdis to the async API

11 years agos3: Slightly simplify winbindd_dual_ccache_ntlm_auth
Volker Lendecke [Sat, 19 Dec 2009 23:27:34 +0000 (00:27 +0100)]
s3: Slightly simplify winbindd_dual_ccache_ntlm_auth

data_blob_const can't fail

11 years agos3: Fix some nonempty blank lines
Volker Lendecke [Sat, 2 Jan 2010 17:25:13 +0000 (18:25 +0100)]
s3: Fix some nonempty blank lines

11 years agolibwbclient: Remove a pointless check
Volker Lendecke [Sat, 2 Jan 2010 19:09:31 +0000 (20:09 +0100)]
libwbclient: Remove a pointless check

We have dereferenced "blobs" before

11 years agos3: Remove some unused code
Volker Lendecke [Sat, 2 Jan 2010 17:16:30 +0000 (18:16 +0100)]
s3: Remove some unused code

11 years agos3: Convert cli_sesssetup_ntlmssp to the async API
Volker Lendecke [Tue, 22 Dec 2009 22:31:20 +0000 (23:31 +0100)]
s3: Convert cli_sesssetup_ntlmssp to the async API

11 years agos3: NT_STATUS_MORE_PROCESSING_REQUIRED is a valid sesssetup return value
Volker Lendecke [Sat, 2 Jan 2010 17:14:59 +0000 (18:14 +0100)]
s3: NT_STATUS_MORE_PROCESSING_REQUIRED is a valid sesssetup return value

11 years agos3: Convert cli_session_setup_kerberos to the async API
Volker Lendecke [Sun, 20 Dec 2009 13:47:09 +0000 (14:47 +0100)]
s3: Convert cli_session_setup_kerberos to the async API

This is still cheated, acquiring the ticket is not async yet, but the SMB
part is

11 years agos3: Fix a typo
Volker Lendecke [Wed, 30 Dec 2009 19:15:33 +0000 (20:15 +0100)]
s3: Fix a typo

11 years agos3: simplify find_root_domain, find_our_domain() never fails
Volker Lendecke [Wed, 30 Dec 2009 19:09:52 +0000 (20:09 +0100)]
s3: simplify find_root_domain, find_our_domain() never fails

11 years agos3: Use global_sid_Builtin in find_builtin_domain
Volker Lendecke [Wed, 30 Dec 2009 19:11:36 +0000 (20:11 +0100)]
s3: Use global_sid_Builtin in find_builtin_domain

11 years agos3: Avoid adding a domain twice
Volker Lendecke [Mon, 28 Dec 2009 17:11:34 +0000 (18:11 +0100)]
s3: Avoid adding a domain twice

If we found a match with sid==NULL, we ended up adding the domain twice

11 years agos3: Make free_domain_list() static
Volker Lendecke [Mon, 28 Dec 2009 17:03:14 +0000 (18:03 +0100)]
s3: Make free_domain_list() static

11 years agos3: Adapt sid_dup_talloc to README.Coding
Volker Lendecke [Wed, 30 Dec 2009 10:30:13 +0000 (11:30 +0100)]
s3: Adapt sid_dup_talloc to README.Coding

11 years agos3: Introduce domain_is_forest_root() helper function
Volker Lendecke [Wed, 30 Dec 2009 09:25:41 +0000 (10:25 +0100)]
s3: Introduce domain_is_forest_root() helper function

Hopefully this makes the flag tests a bit more understandable

11 years agos4-dsdb: force REVISION_ADS for new and updated ACLs in dsdb
Andrew Tridgell [Sat, 2 Jan 2010 05:53:20 +0000 (16:53 +1100)]
s4-dsdb: force REVISION_ADS for new and updated ACLs in dsdb

w2k8-r2 gives a "schema mismatch" error if the revision is not set to
REVISION_ADS and you replicate the ntsecuritydescriptor using DRS.

Nadya, please check this!

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agos4-drs: don't give an error on repsTo delete if add is also specified
Andrew Tridgell [Sat, 2 Jan 2010 05:51:30 +0000 (16:51 +1100)]
s4-drs: don't give an error on repsTo delete if add is also specified

w2k8-r2 in dcpromo asks for a delete+add during its initial join.

11 years agos4-sddl: DRS replication needs REVISION_ADS for SDs
Andrew Tridgell [Sat, 2 Jan 2010 01:30:48 +0000 (12:30 +1100)]
s4-sddl: DRS replication needs REVISION_ADS for SDs

DRS replication with w2k8-r2 fails with a schema mismatch error if we
set the revision to NT4

11 years agoldb: Fix the standalone ldb build.
Jelmer Vernooij [Sat, 2 Jan 2010 01:40:30 +0000 (02:40 +0100)]
ldb: Fix the standalone ldb build.

11 years agolibreplace: some systems don't have memmem()
Andrew Tridgell [Fri, 1 Jan 2010 23:01:11 +0000 (10:01 +1100)]
libreplace: some systems don't have memmem()

added rep_memmem() and a testsuite

11 years agos4-dsdb: switched to using RMD_FLAGS instead of DELETED in extended DNs
Andrew Tridgell [Fri, 1 Jan 2010 21:14:52 +0000 (08:14 +1100)]
s4-dsdb: switched to using RMD_FLAGS instead of DELETED in extended DNs

This allows for more flags in the future

11 years agos4-kcc: added a preiodic task to remove deleted objects
Andrew Tridgell [Wed, 30 Dec 2009 10:40:17 +0000 (21:40 +1100)]
s4-kcc: added a preiodic task to remove deleted objects

we check for deleted objects in each partition every 10 minutes, using
onelevel searches

11 years agos4-dsdb: fixed several memory leaks
Andrew Tridgell [Wed, 30 Dec 2009 10:39:24 +0000 (21:39 +1100)]
s4-dsdb: fixed several memory leaks

need to be careful with those temporary contexts

11 years agos4-dsdb: fixed samdb_create_foreign_security_principal() to use the wellknown GUID
Andrew Tridgell [Wed, 30 Dec 2009 10:38:21 +0000 (21:38 +1100)]
s4-dsdb: fixed samdb_create_foreign_security_principal() to use the wellknown GUID

This also fixes a memory leak

11 years agos4-ldb: fixed valgrind error: ares can be freed by callback
Andrew Tridgell [Wed, 30 Dec 2009 10:36:31 +0000 (21:36 +1100)]
s4-ldb: fixed valgrind error: ares can be freed by callback

11 years agos4-dsdb: make sure 'whenChanged' is set on modify
Andrew Tridgell [Wed, 30 Dec 2009 09:05:02 +0000 (20:05 +1100)]
s4-dsdb: make sure 'whenChanged' is set on modify

We also should preserve (and then replace) whenChanged on delete

11 years agos4-dsdb: added dsdb_tombstone_lifetime()
Andrew Tridgell [Wed, 30 Dec 2009 09:04:17 +0000 (20:04 +1100)]
s4-dsdb: added dsdb_tombstone_lifetime()

11 years agos4-dsdb: allow system to remove deleted objects
Andrew Tridgell [Wed, 30 Dec 2009 07:47:51 +0000 (18:47 +1100)]
s4-dsdb: allow system to remove deleted objects

This will be used by a periodic job to remove tombstoned objects

11 years agos4-ldaptest: need to use MessageElement for modify messages
Andrew Tridgell [Tue, 29 Dec 2009 23:54:03 +0000 (10:54 +1100)]
s4-ldaptest: need to use MessageElement for modify messages

Without MessageElement() the flags are not set, which is invalid

11 years agos4-ldb: show an error string, as well as error message
Andrew Tridgell [Tue, 29 Dec 2009 23:53:36 +0000 (10:53 +1100)]
s4-ldb: show an error string, as well as error message

This makes it easier to track down error mismatches from the test
suite

11 years agos4-drs: make sure the DNs we put in the db have a extended GUID
Andrew Tridgell [Tue, 29 Dec 2009 23:52:55 +0000 (10:52 +1100)]
s4-drs: make sure the DNs we put in the db have a extended GUID

11 years agos4-dsdb: added dsdb_set_extended_dn_guid()
Andrew Tridgell [Tue, 29 Dec 2009 23:52:14 +0000 (10:52 +1100)]
s4-dsdb: added dsdb_set_extended_dn_guid()

11 years agos4-ldbtest: fixed message element in modify
Andrew Tridgell [Tue, 29 Dec 2009 00:41:19 +0000 (11:41 +1100)]
s4-ldbtest: fixed message element in modify

a flags value of zero is not valid

11 years agos4-ldb: allow modules to override error return values
Andrew Tridgell [Tue, 29 Dec 2009 00:40:30 +0000 (11:40 +1100)]
s4-ldb: allow modules to override error return values

The samldb module overrides the error code for some returns when
handling primaryGroupID. We need to take the error from the async
callback to allow this to work reliably

11 years agos4-ldbmodify: show the error code as well as error string
Andrew Tridgell [Tue, 29 Dec 2009 00:39:29 +0000 (11:39 +1100)]
s4-ldbmodify: show the error code as well as error string