14 years agor23765: Another error-path restore_case_semantics().
Volker Lendecke [Mon, 9 Jul 2007 13:24:31 +0000 (13:24 +0000)]
r23765: Another error-path restore_case_semantics().
(This used to be commit a3e5fe1693a3e1830561d60254d6a3bfc0c30686)

14 years agor23764: Do restore_case_semantics in an error path. Jeremy, please check!
Volker Lendecke [Mon, 9 Jul 2007 13:04:44 +0000 (13:04 +0000)]
r23764: Do restore_case_semantics in an error path. Jeremy, please check!
(This used to be commit 3b5422c9a401321788d824c68da31a39d85aece1)

14 years agor23763: Fix a typo in DEBUG message.
Michael Adam [Mon, 9 Jul 2007 12:59:17 +0000 (12:59 +0000)]
r23763: Fix a typo in DEBUG message.
Thanks to Karolin Seeger (
(This used to be commit 0ae6ae4ee8098abdfefc9fe7c3880bfbb6da52a8)

14 years agor23761: Rename reduce_name to check_reduced_name
Volker Lendecke [Mon, 9 Jul 2007 09:43:41 +0000 (09:43 +0000)]
r23761: Rename reduce_name to check_reduced_name

The function name reduce_name is misleading, making the user believe it
changes an argument.
(This used to be commit 68234f0bc6fb4d6d99ae94ff067db118c60804aa)

14 years agor23760: Untangle use of strrchr_m and strequal and add some checks
Michael Adam [Mon, 9 Jul 2007 09:35:03 +0000 (09:35 +0000)]
r23760: Untangle use of strrchr_m and strequal and add some checks
for the validity of the given registry key name.

(This used to be commit 4b4ba7724ee77a93e32cd7f3c5884d965fe9bcaa)

14 years agor23759: Fix make test -- sorry
Volker Lendecke [Mon, 9 Jul 2007 08:45:14 +0000 (08:45 +0000)]
r23759: Fix make test -- sorry
(This used to be commit cbbc70604e815f4ffd25d040ca0a4ef58e651523)

14 years agor23758: Fix Coverity id 385
Volker Lendecke [Mon, 9 Jul 2007 08:04:43 +0000 (08:04 +0000)]
r23758: Fix Coverity id 385
(This used to be commit 4d9f627cc8081307da3f84f784602533bd20c1e6)

14 years agor23757: Fix Coverity id 386
Volker Lendecke [Mon, 9 Jul 2007 08:00:50 +0000 (08:00 +0000)]
r23757: Fix Coverity id 386
(This used to be commit 91be38f7ab42991e04a41e91132137a834c10996)

14 years agor23756: Fix Coverity id 388
Volker Lendecke [Mon, 9 Jul 2007 07:55:09 +0000 (07:55 +0000)]
r23756: Fix Coverity id 388
(This used to be commit 91af086823265ed66bbd0bdc1cced070b7dd0629)

14 years agor23755: Fix Coverity id 384
Volker Lendecke [Mon, 9 Jul 2007 07:51:39 +0000 (07:51 +0000)]
r23755: Fix Coverity id 384
(This used to be commit ebb410ca1e08d6f062154c9f8b3970682c6eeebd)

14 years agor23752: Fix bug introduced by checkin 22920, allow large
Jeremy Allison [Mon, 9 Jul 2007 00:48:07 +0000 (00:48 +0000)]
r23752: Fix bug introduced by checkin 22920, allow large
readX. Fix from Dmitry Shatrov <>.

"In send_file_readX(), if startpos > sbuf.st_size, then smb_maxcnt is set
to an invalid large value due to integer overflow.
As for me, this resulted in MS Word hanging while trying to save
a 1.5Mb document."

This isn't in shipping code.

(This used to be commit af715c602a8ef6038e6272c7cc6a08501617ae67)

14 years agor23751: Call tdb_close even when validation was not successful.
Michael Adam [Sun, 8 Jul 2007 22:01:43 +0000 (22:01 +0000)]
r23751: Call tdb_close even when validation was not successful.

(This used to be commit b68856d9902f41079224ba11c7d0ab811b082201)

14 years agor23750: Change the behaviour of net conf import when there is a global section
Michael Adam [Sat, 7 Jul 2007 23:57:25 +0000 (23:57 +0000)]
r23750: Change the behaviour of net conf import when there is a global section
in the current registry and there is no global section in the input
file (or only global options with default values):
In that case the existing global section is now not touched. Before, it
would have been deleted and recreated empty. The new behaviour is how
other shares are treated too.

Note that since the input file is parsed by lp_load, there is currently
no way to distinguish between a section with only default parameters
and a non-existing section in net conf import.


PS: A couple of trailing white-spaces have been eliminated
and a line was broken to be not longer than 80 chars, too.
(This used to be commit ec21a0cf9f01986d333b50b883f2105e32cf7fc9)

14 years agor23749: Simplify prototype of reg_setvalue_internal:
Michael Adam [Sat, 7 Jul 2007 22:33:45 +0000 (22:33 +0000)]
r23749: Simplify prototype of reg_setvalue_internal:
eliminate "type" parameter since we store only REG_SZ.

(This used to be commit 65ce4633171eabd6fc94677cb7d884d6125d0745)

14 years agor23748: Clean use of talloc in import_process_service:
Michael Adam [Sat, 7 Jul 2007 22:29:34 +0000 (22:29 +0000)]
r23748: Clean use of talloc in import_process_service:
create a temporary talloc ctx for the function.

(This used to be commit 39df7faaa9472d565653b36203860eee8a259f2c)

14 years agor23747: Move formatting of a parameter's value into a value string
Michael Adam [Sat, 7 Jul 2007 22:18:54 +0000 (22:18 +0000)]
r23747: Move formatting of a parameter's value into a value string
to a function of its own. (for storing it in registry),
Eliminate the valtype variable : store everything as "sz".
Eliminate some trailing white spaces on the way.

(This used to be commit 76f4f224aa65b1414222818996e215ec80d117a4)

14 years agor23746: Fix missing assignments to target string of asprintf in import function.
Michael Adam [Sat, 7 Jul 2007 21:41:59 +0000 (21:41 +0000)]
r23746: Fix missing assignments to target string of asprintf in import function.

(This used to be commit 6b1bf7c1f49f737ca3cbee96b184e3b21fdc4931)

14 years agor23745: Fix: Check whether top subkeyname instead of whole registry key name
Michael Adam [Sat, 7 Jul 2007 21:33:48 +0000 (21:33 +0000)]
r23745: Fix: Check whether top subkeyname instead of whole registry key name
is equal to GLOBAL_NAME.

(This used to be commit fdcdcacf0a9513829ad474605879ef55ce8b389e)

14 years agor23744: Remove TODO-comment. lp_load returns False if opening
Michael Adam [Sat, 7 Jul 2007 20:40:59 +0000 (20:40 +0000)]
r23744: Remove TODO-comment. lp_load returns False if opening
of the config file fails. That's enough of checking for
existence and readbility to my taste.

(This used to be commit 204f4f1a94a6693ab5d92df0de48e6cb446c7a7f)

14 years agor23743: Simplify stat_cache_lookup() logic. For the history of this, see
Volker Lendecke [Sat, 7 Jul 2007 09:57:27 +0000 (09:57 +0000)]
r23743: Simplify stat_cache_lookup() logic. For the history of this, see
(This used to be commit e5e42fe3d5b26c0ec48d98c001b9cb1623c0b5a7)

14 years agor23738: Re-add commented out code snipped that got lost by accident
Volker Lendecke [Sat, 7 Jul 2007 08:46:26 +0000 (08:46 +0000)]
r23738: Re-add commented out code snipped that got lost by accident
(This used to be commit c38c31afb770350e47713bf1025c23fd774607ab)

14 years agor23736: Use local variable of smb_flag2 instead of using the macro every time.
Jeremy Allison [Fri, 6 Jul 2007 23:07:40 +0000 (23:07 +0000)]
r23736: Use local variable of smb_flag2 instead of using the macro every time.
(This used to be commit 9e1663b1f18d716a7f307bea2b09dadeef392ab8)

14 years agor23735: Second part of the bugfix for #4763
Jeremy Allison [Fri, 6 Jul 2007 21:46:43 +0000 (21:46 +0000)]
r23735: Second part of the bugfix for #4763
This should coalesce identical adjacent notify records - making the "too large"
bug very rare indeed. Please test.
(This used to be commit 1aaa1f5bbe9222acbe3dea1daa1c6c5ce72e1c2c)

14 years agor23733: Limit LDAP lookup in lookup_usergroups_member() to security groups.
Lars Müller [Fri, 6 Jul 2007 18:49:49 +0000 (18:49 +0000)]
r23733: Limit LDAP lookup in lookup_usergroups_member() to security groups.

Credits to Ralf Haferkamp for the discussion and help on this.
(This used to be commit 5be96d09a7c457b1763d7ad482b5a5a92c02d157)

14 years agor23732: removed reference to non-existent structure
Herb Lewis [Fri, 6 Jul 2007 17:48:19 +0000 (17:48 +0000)]
r23732: removed reference to non-existent structure
(This used to be commit 4c04059f7dfa0096c9f3249b55269f7335137f48)

14 years agor23731: Forgot one reference to inbuf
Volker Lendecke [Fri, 6 Jul 2007 16:39:58 +0000 (16:39 +0000)]
r23731: Forgot one reference to inbuf
(This used to be commit b02115f2ca6aca8655a4ebd1bd0adaa1e50578ce)

14 years agor23730: Squashed commit of the following:
Gerald Carter [Thu, 5 Jul 2007 19:55:40 +0000 (19:55 +0000)]
r23730: Squashed commit of the following:

commit 3941269fa01038fca242a197e8d7c1f234d45ea7
Author: Gerald (Jerry) Carter <>
Date:   Thu Jul 5 14:52:03 2007 -0500

    Two fixes for "winbind expand groups".

    (a) Update the counter for the number of new groups to resolve else
        we'll only expand one group member per level and drop the rest.
    (b) Don't reset the num_names counter in winbindd_ads.c:lookup_groupmem()
        or we'll drop the SIDs resolved to names via cache from the resulting
(This used to be commit dfb89dfcaa02f497ff22ac0213b70add6e4d5b8f)

14 years agor23728: First part of bugfix for #4763. Limit notify responses
Jeremy Allison [Thu, 5 Jul 2007 18:28:18 +0000 (18:28 +0000)]
r23728: First part of bugfix for #4763. Limit notify responses
to client max buf size.
(This used to be commit 6113f56919a3cd7fd753808dbbe473603851bc3c)

14 years agor23727: Explicitly pass down FLAGS2 to srvstr_get_path.
Volker Lendecke [Thu, 5 Jul 2007 16:36:15 +0000 (16:36 +0000)]
r23727: Explicitly pass down FLAGS2 to srvstr_get_path.

Next step is to remove the bug that in the trans2 code we use the inbuf
as the base pointer to decide whether we need ucs2 alignment where we
need to use the beginning of the params buffer

Jeremy, last one for today to reviw :-)
(This used to be commit 18078b9faa3820fb34604063c9079c1ebe3ad47f)

14 years agor23726: Explicitly pass down the FLAGS2 field to srvstr_pull_buf. The next
Volker Lendecke [Thu, 5 Jul 2007 16:33:37 +0000 (16:33 +0000)]
r23726: Explicitly pass down the FLAGS2 field to srvstr_pull_buf. The next
checkin will pull this up to srvstr_get_path. At that point we can get more
independent of the inbuf, the base_ptr in pull_string will only be used
to satisfy UCS2 alignment constraints.
(This used to be commit 836782b07bf133e9b2598c4a089f1c810e4c7754)

14 years agor23725: Remove get_current_mid()
Volker Lendecke [Thu, 5 Jul 2007 16:27:47 +0000 (16:27 +0000)]
r23725: Remove get_current_mid()

Jeremy, next one to review :-)
(This used to be commit a50555dda7db5e848e337185ed91c41c2557f7be)

14 years agor23724: Reduce access to the global inbuf a tiny bit. Add a struct smb_request
Volker Lendecke [Thu, 5 Jul 2007 16:26:27 +0000 (16:26 +0000)]
r23724: Reduce access to the global inbuf a tiny bit. Add a struct smb_request
that contains some of the fields from the SMB header, removing the need
to access inbuf directly. This right now is used only in the open file
code & friends, and creating that header is only done when needed. This
needs more work, but it is a start.

Jeremy, I'm only checking this into 3_0, please review before I merge it
to _26.

(This used to be commit ca988f4e79e977160d82e86486972afd15d4acf5)

14 years agor23723: Alexander Larsson pointed me at a missing mapping in clierror.c
Simo Sorce [Thu, 5 Jul 2007 13:46:47 +0000 (13:46 +0000)]
r23723: Alexander Larsson pointed me at a missing mapping in clierror.c
When renaming a file across 2 filesystem a samba server returns
NT_STATUS_NOT_SAME_DEVICE but thius is not translated to EXDEV,
and the generic EINVAL is returned instead.
This should fix it, Jeremy or Derrel please check if this is ok.
(This used to be commit b35038fa4e3e69f1397758497a46dc0d37edee79)

14 years agor23722: Fix the build of the catia module
Volker Lendecke [Thu, 5 Jul 2007 10:32:51 +0000 (10:32 +0000)]
r23722: Fix the build of the catia module
(This used to be commit fa09744cce6c1aa63e46bd61e4c01234574f3b32)

14 years agor23714: but now:
Michael Adam [Thu, 5 Jul 2007 00:12:24 +0000 (00:12 +0000)]
r23714: but now:

This script allows for adding lists of users (or other objects)
to lists of groups (or aliases). Useful for creating large test

(This used to be commit b3e5082e105f6eaeed51e9a42d525d811e7155ee)

14 years agor23713: Oops accidentially checked in the wrong file - sorry!
Michael Adam [Thu, 5 Jul 2007 00:11:07 +0000 (00:11 +0000)]
r23713: Oops accidentially checked in the wrong file - sorry!

(This used to be commit ae23e6d04b8551e66b77995994a0c50cd880ea32)

14 years agor23712: This script allows for adding lists of users (or other objects)
Michael Adam [Thu, 5 Jul 2007 00:07:40 +0000 (00:07 +0000)]
r23712: This script allows for adding lists of users (or other objects)
to lists of groups (or aliases). Useful for creating large test

(This used to be commit 0c03c78af8f62ece2965e0f5a16c001aad61c8fa)

14 years agor23711: Refactor the actual creation of object into its own small function.
Michael Adam [Wed, 4 Jul 2007 23:21:51 +0000 (23:21 +0000)]
r23711: Refactor the actual creation of object into its own small function.

(This used to be commit 26349c0b173e8baf6fa43deb39cb2bfdb31bf18e)

14 years agor23710: Remove some code duplication, we do have a random number generator
Volker Lendecke [Wed, 4 Jul 2007 22:30:25 +0000 (22:30 +0000)]
r23710: Remove some code duplication, we do have a random number generator
(This used to be commit afd7febd980bb000f81d5251d03d500cb43c39f4)

14 years agor23709: C++ warnings
Volker Lendecke [Wed, 4 Jul 2007 22:28:04 +0000 (22:28 +0000)]
r23709: C++ warnings
(This used to be commit 2d5e3322d6ecd00c0e936ee64483e63a3ad87c0b)

14 years agor23708: - Add define for WINBIND_WARN_PWD_EXPIRE.
Lars Müller [Wed, 4 Jul 2007 20:25:29 +0000 (20:25 +0000)]
r23708: - Add define for WINBIND_WARN_PWD_EXPIRE.
- Add parameter config_flag to get_config_item_int() and do the same
  check as in get_conf_item_string.
(This used to be commit d1d1baa264587911e1c97b3b35d5ed2bc56bf12b)

14 years agor23707: - Move the asprintf() call to create the key even in
Lars Müller [Wed, 4 Jul 2007 19:52:51 +0000 (19:52 +0000)]
r23707: - Move the asprintf() call to create the key even in
  get_conf_item_string() to the later if statement.
- Also move the key definition to the later if statement in
  get_conf_item_string() and get_conf_item_int().
(This used to be commit 3a82ec943a3828b843dd47aaa0e360844d4dfb91)

14 years agor23706: Add a script to create domainusers,-groups and -aliases.
Michael Adam [Wed, 4 Jul 2007 16:17:48 +0000 (16:17 +0000)]
r23706: Add a script to create domainusers,-groups and -aliases.
This is done via rpc client. The main purpose is to
be able to fill a domain controller with a large number
of users / groups easily. A the object names are
built as <prefix><num> where number ranges from a given
start number counting up until a given number of objects
has been created.

In a next step, I will submit scripts to add (many) users to
a group and to add a user to (many) groups.

(This used to be commit 8b81fbb7d998eda65978a772f2194b4a3de467f9)

14 years agor23705: Add suggestion for vim from Andreas 'GlaDiaC' Schneider to show tabs,
Lars Müller [Wed, 4 Jul 2007 14:15:26 +0000 (14:15 +0000)]
r23705: Add suggestion for vim from Andreas 'GlaDiaC' Schneider to show tabs,
trailing whitespace, and continued lines visually.
(This used to be commit 6209ae79de3710ab9c2e91e2f6643b1c5fe2a6b2)

14 years agor23704: Add pam_pwd_expire feature as discussed on samba-technical.
Lars Müller [Wed, 4 Jul 2007 14:03:10 +0000 (14:03 +0000)]
r23704: Add pam_pwd_expire feature as discussed on samba-technical.

This is a slightly modified version to set warn_pwd_expire to the
default value if 0, no, or a broken value is set.

This version also has one if statement less in get_config_item_int().

Thanks a lot to Andreas 'GlaDiaC' Schneider for this feature!
(This used to be commit d26914c978457ae0ec097cc40c8e33a7cee9ebcf)

14 years agor23694: Make sure that when builddir != srcdir, we can still find the exports
Gerald Carter [Wed, 4 Jul 2007 00:41:58 +0000 (00:41 +0000)]
r23694: Make sure that when builddir != srcdir, we can still find the exports
files and library-versions file.

Also move the "-o $@" from the individual targets and into the SHLD_DSO
(This used to be commit c85311b3a8a891af4b4c8eb1f09bd91f00a1f5db)

14 years agor23692: Couldn't wait, sorry :-). Did the style change.
Jeremy Allison [Tue, 3 Jul 2007 23:48:02 +0000 (23:48 +0000)]
r23692: Couldn't wait, sorry :-). Did the style change.
(This used to be commit da0d6ba0f972dbe48e2b7297e86e1717e510fadf)

14 years agor23691: fix for bug on touching files as described here:
Simo Sorce [Tue, 3 Jul 2007 23:34:01 +0000 (23:34 +0000)]
r23691: fix for bug on touching files as described here:
(This used to be commit 6b68c006f8ecba8ed3a4d87950691cb1e5c46386)

14 years agor23689: Squashed commit of the following:
Gerald Carter [Tue, 3 Jul 2007 19:55:02 +0000 (19:55 +0000)]
r23689: Squashed commit of the following:

commit 0d4bbd197198a94bf4e29e0ccd175a40a60097f3
Author: Gerald (Jerry) Carter <>
Date:   Mon Jul 2 20:08:19 2007 -0500

    Introduce GNU ld linker export-script for hiding non-public symbols
    in shared libraries.

    Based on initial patch from Julien Cristau <>
    and suggestions from James Peach <>.  Currently
    the libsmbsharemodes libraries still exports *.  Signed off on
    my Derrell as well.
(This used to be commit c42cf731b4b259c5c1a874fd1837ca85144f1a58)

14 years agor23688: Fix bug #4759 reported by Raul <>.
Jeremy Allison [Tue, 3 Jul 2007 18:00:54 +0000 (18:00 +0000)]
r23688: Fix bug #4759 reported by Raul <>.
"N" is not a valid format entry for ber_printf, should be "n"
(This used to be commit f3bb102c24018f0a91f8b51de6fe646c091da6be)

14 years agor23685: merge from SAMBA_4_0:
Stefan Metzmacher [Tue, 3 Jul 2007 14:46:06 +0000 (14:46 +0000)]
r23685: merge from SAMBA_4_0:

Only use the bzr and git information when there's
a .bzr or .git in the top branch directory

I use bzr for my home directory and
bzr version-info in ~/devel/samba/4.0/samba4-git
gives the info about the ~/.bzr branch

(This used to be commit e4df2e1c2d302613b1e7f44f13db9435bdafb30f)

14 years agor23683: Check ports are in the correct range (1-65535)
Simo Sorce [Tue, 3 Jul 2007 13:11:56 +0000 (13:11 +0000)]
r23683: Check ports are in the correct range (1-65535)
(This used to be commit 84b193a7d95aa8c00da2a3720ee87a7231e0fc6e)

14 years agor23682: Old patch I forgot in one of my 3.0.25 trees.
Simo Sorce [Tue, 3 Jul 2007 13:07:56 +0000 (13:07 +0000)]
r23682: Old patch I forgot in one of my 3.0.25 trees.
Make sure we honour the directive not to allow machine password changes.
(This used to be commit 436555f05ceae34d8df2356d1066b6b5e0a07c41)

14 years agor23673: Check for integer wrap on incoming data.
Jeremy Allison [Mon, 2 Jul 2007 20:51:09 +0000 (20:51 +0000)]
r23673: Check for integer wrap on incoming data.
(This used to be commit 77a46c7aee2ad4c402527cf78e5ae70a792d65d4)

14 years agor23672: Allow msrpc_name_to_sid() to be called without a domain_name and just a name.
Günther Deschner [Mon, 2 Jul 2007 09:46:18 +0000 (09:46 +0000)]
r23672: Allow msrpc_name_to_sid() to be called without a domain_name and just a name.

(This used to be commit eeed62b6ca86bcb0875de90a5d8c65948fd80215)

14 years agor23671: Remove unused code -- 16416 bytes of bss space...
Volker Lendecke [Sun, 1 Jul 2007 19:40:04 +0000 (19:40 +0000)]
r23671: Remove unused code -- 16416 bytes of bss space...
(This used to be commit 25f3bfdb1f60ab17af05608481068299da94cec9)

14 years agor23670: Fix for the git case: Only use the first line where
Volker Lendecke [Sun, 1 Jul 2007 19:11:40 +0000 (19:11 +0000)]
r23670: Fix for the git case: Only use the first line where
"commit" occurs
(This used to be commit 0e9aeec37008e5b882ce91c44ee201ef779ecabe)

14 years agor23669: Move a variable into the only block where it is used.
Michael Adam [Sun, 1 Jul 2007 00:09:20 +0000 (00:09 +0000)]
r23669: Move a variable into the only block where it is used.
(This used to be commit 82be4137b7bba6a9a433ec011e7f47587935ae61)

14 years agor23668: When creating a new string value, win2k regedit delivers
Michael Adam [Sat, 30 Jun 2007 23:52:23 +0000 (23:52 +0000)]
r23668: When creating a new string value, win2k regedit delivers
one byte of data despite characters being two-byte.

This modifies registry_pull_value, to change the data
to the correct two-byte version of the empty string,
(as delivered by winxp), when only one byte of data is

(This used to be commit a4c2b20296d6853cd1578601f17330cde75c4038)

14 years agor23667: Prevent storing of forbidden parameter names in registry
Michael Adam [Sat, 30 Jun 2007 22:31:13 +0000 (22:31 +0000)]
r23667: Prevent storing of forbidden parameter names in registry
configuration as values. I would really like to check whether
the valuename is a valid parameter name (with lp_parameter_is_valid)
here, but unfortunately, regedit cereates new values as
"New Value #1" (and so on) first, before dropping into the
rename box. So this is impossible here.

(This used to be commit 10014833da868289ae28db2e7c1edfd353ca7b2b)

14 years agor23666: Rename lp_parameter_valid -> lp_parameter_is_valid.
Michael Adam [Sat, 30 Jun 2007 21:35:39 +0000 (21:35 +0000)]
r23666: Rename lp_parameter_valid -> lp_parameter_is_valid.

(This used to be commit 7f85cff49dfe1ae90e37162d35f1a48baaa9fe79)

14 years agor23665: Remove two unneeded global variables
Volker Lendecke [Sat, 30 Jun 2007 09:15:33 +0000 (09:15 +0000)]
r23665: Remove two unneeded global variables
(This used to be commit 51a3933b3d367e3693daa6842f5a286328f4fd39)

14 years agor23664: Fix incorrect index - should be j not i. How did we ever
Jeremy Allison [Sat, 30 Jun 2007 00:22:59 +0000 (00:22 +0000)]
r23664: Fix incorrect index - should be j not i. How did we ever
live without valgrind :-).
(This used to be commit 9b231149c78c8bbfb70c5675cffb652705ba2cd2)

14 years agor23663: Fix bug #4308 - Excel save operation corrupts file ACLs.
Jeremy Allison [Fri, 29 Jun 2007 17:57:05 +0000 (17:57 +0000)]
r23663: Fix bug #4308 - Excel save operation corrupts file ACLs.
You don't want to know what I discovered about Windows
ACLs to make this work :-(. See :

Search for "Q. How does Inheritance come into this?"
for details.
(This used to be commit e1d3a80d2bff2e3540637fd741fc149eeca5fb9d)

14 years agor23662: According to simo, check_dos_char is needed
Volker Lendecke [Fri, 29 Jun 2007 17:51:31 +0000 (17:51 +0000)]
r23662: According to simo, check_dos_char is needed
(This used to be commit c195eccefea69c17169c350a13bbfe845fc6fc44)

14 years agor23661: Another static pstring
Volker Lendecke [Fri, 29 Jun 2007 17:40:37 +0000 (17:40 +0000)]
r23661: Another static pstring
(This used to be commit d4256ae5588fddc62bf90082d24140e327a54c8c)

14 years agor23660: Anybody know what check_dos_char() was used for? It wasn't called at
Volker Lendecke [Fri, 29 Jun 2007 17:27:59 +0000 (17:27 +0000)]
r23660: Anybody know what check_dos_char() was used for? It wasn't called at
all, so it's gone. With it 8k bss went away.
(This used to be commit 7e9a4c39a5ce620f8eac74d0ae4dd80b96c81aca)

14 years agor23659: file_pload is not used outside of util_file.c
Volker Lendecke [Fri, 29 Jun 2007 17:09:39 +0000 (17:09 +0000)]
r23659: file_pload is not used outside of util_file.c
(This used to be commit 3ec43e18a4ffc46700de484251ea0bb2a18cde78)

14 years agor23658: One pstring a day....
Volker Lendecke [Fri, 29 Jun 2007 16:04:26 +0000 (16:04 +0000)]
r23658: One pstring a day....

This one was particularly tasty, it was a static one. So 1k less
footprint per process.
(This used to be commit 83865e32889e2d29086ae9d9701713fc74b09175)

14 years agor23657: Prevent setting of a global option in a share definition
Michael Adam [Fri, 29 Jun 2007 13:07:54 +0000 (13:07 +0000)]
r23657: Prevent setting of a global option in a share definition
in "net conf setparm".

(This used to be commit bf92d567984f00ebb998fb2485d0aac87d30b924)

14 years agor23656: Add initial checking of the validity of a paramter
Michael Adam [Fri, 29 Jun 2007 12:30:41 +0000 (12:30 +0000)]
r23656: Add initial checking of the validity of a paramter
given to "net conf setparm". Add a utility function
lp_parameter_valid() for this to loadparm.c.

(This used to be commit 639051e58d4da9fb1116c19f0790250640b6ac7a)

14 years agor23655: Fix a comment and adjust some code formatting.
Michael Adam [Fri, 29 Jun 2007 12:15:41 +0000 (12:15 +0000)]
r23655: Fix a comment and adjust some code formatting.

(This used to be commit b294bc707c2a7ef3ff5efcac1d5ea6f3d80f5a70)

14 years agor23654: Remove misleading inline comment.
Günther Deschner [Fri, 29 Jun 2007 11:54:29 +0000 (11:54 +0000)]
r23654: Remove misleading inline comment.

(This used to be commit a3441c22b342e2802bd9766b7046073db3895a29)

14 years agor23652: Use the recursive delete function instead of the original one
Michael Adam [Fri, 29 Jun 2007 10:22:18 +0000 (10:22 +0000)]
r23652: Use the recursive delete function instead of the original one
when deleting a share. Just to be sure...

(This used to be commit 91770e153d7dd87d5e4f0516c297812091ba5b5a)

14 years agor23651: Always, always, always compile before commit...
Günther Deschner [Fri, 29 Jun 2007 09:58:11 +0000 (09:58 +0000)]
r23651: Always, always, always compile before commit...

(This used to be commit accb40446ad3f872c5167fc2306d892553293b7b)

14 years agor23650: Fix remaining callers of krb5_kt_default().
Günther Deschner [Fri, 29 Jun 2007 09:54:39 +0000 (09:54 +0000)]
r23650: Fix remaining callers of krb5_kt_default().

(This used to be commit b9d7a2962a472afb0c6b8e3ac5c2c819d4af2b39)

14 years agor23649: Fix the build (by moving smb_krb5_open_keytab() to clikrb5.c).
Günther Deschner [Fri, 29 Jun 2007 09:42:14 +0000 (09:42 +0000)]
r23649: Fix the build (by moving smb_krb5_open_keytab() to clikrb5.c).

(This used to be commit 19020d19dca7f34be92c8c2ec49ae7dbde60f8c1)

14 years agor23648: Allow to list a custom krb5 keytab file with:
Günther Deschner [Fri, 29 Jun 2007 09:01:29 +0000 (09:01 +0000)]
r23648: Allow to list a custom krb5 keytab file with:

net ads keytab list /path/to/krb5.keytab

(This used to be commit a2befee3f240543ea02ea99cebad886b54ae64eb)

14 years agor23647: Use smb_krb5_open_keytab() in smbd as well.
Günther Deschner [Fri, 29 Jun 2007 08:58:03 +0000 (08:58 +0000)]
r23647: Use smb_krb5_open_keytab() in smbd as well.

(This used to be commit d22c0d291e1b4a1412164d257310bbbb99de6500)

14 years agor23646: Generalize our internal keytab handling to support a broader range of default
Günther Deschner [Fri, 29 Jun 2007 08:56:35 +0000 (08:56 +0000)]
r23646: Generalize our internal keytab handling to support a broader range of default
keytabnames (like "ANY:FILE:/etc/krb5.keytab,krb4:/etc/srvtab"). This also
fixes keytab support with Heimdal (which supports the WRFILE pragma as well

(This used to be commit 7ca002f4cc9ec4139c0c48952ebf05f89b5795ef)

14 years agor23645: add examples and try to answer some common questions in the coding style...
Gerald Carter [Thu, 28 Jun 2007 19:27:30 +0000 (19:27 +0000)]
r23645: add examples and try to answer some common questions in the coding style guide
(This used to be commit c955151bb384c3edba3f2f17f1ebb7029b61d36c)

14 years agor23641: Put check for forbidden values in smbconf into a function.
Michael Adam [Thu, 28 Jun 2007 10:32:52 +0000 (10:32 +0000)]
r23641: Put check for forbidden values in smbconf into a function.
(This will be used in a next step to prevent storing these
values in reg_smbconf.c.)

(This used to be commit 00be68a8416405e12a27186506f9eb15bca055b3)

14 years agor23640: When we support the SeSecurity privilage, this is where
Jeremy Allison [Wed, 27 Jun 2007 22:45:08 +0000 (22:45 +0000)]
r23640: When we support the SeSecurity privilage, this is where
we'll check it.
(This used to be commit 1b73bf79f4f8a2bc408d52a1ce9df47f33fb3a87)

14 years agor23639: Eliminate trailing whitespaces in the new tdb_validate functions...
Michael Adam [Wed, 27 Jun 2007 22:10:25 +0000 (22:10 +0000)]
r23639: Eliminate trailing whitespaces in the new tdb_validate functions...

(This used to be commit d4accdbb5285216d532f57f545a846734a2fe774)

14 years agor23636: Adding coding style guide for Samba 3.0 branches (no differences from Tridge...
Gerald Carter [Wed, 27 Jun 2007 18:28:18 +0000 (18:28 +0000)]
r23636: Adding coding style guide for Samba 3.0 branches (no differences from Tridge's prog_guide.txt so we should have a similar style throughout the project)
(This used to be commit ff1c2fdc08f6198bad1bf9f5bae8dc6bc5fb534a)

14 years agor23633: Fix a couple of crash bugs pointed out by Volker caused by an old
Gerald Carter [Wed, 27 Jun 2007 16:52:36 +0000 (16:52 +0000)]
r23633: Fix a couple of crash bugs pointed out by Volker caused by an old
change from a pstring to a char* and still trying use pstrcpy().
(This used to be commit 21dc46a2bad6fee720f0f591e1051aa7675c77c8)

14 years agor23632: Correctly return the new_group list pointer from expand_groups
Gerald Carter [Wed, 27 Jun 2007 16:52:34 +0000 (16:52 +0000)]
r23632: Correctly return the new_group list pointer from expand_groups
or else getgrnam() always  acts like 'winbind expand groups = 1'
(This used to be commit 04ae193ec44c0ecefa64ca44ad0cdb5968087319)

14 years agor23630: Found out what LSA_LOOKUP_NAMES level 5 means:
Günther Deschner [Wed, 27 Jun 2007 12:35:12 +0000 (12:35 +0000)]
r23630: Found out what LSA_LOOKUP_NAMES level 5 means:
only query transitive forest trusts.

(This used to be commit e744efa1ee33fb150132f0b7f46ee1711681afc6)

14 years agor23628: Add LSA lookupnames_level to rpcclient.
Günther Deschner [Wed, 27 Jun 2007 12:27:00 +0000 (12:27 +0000)]
r23628: Add LSA lookupnames_level to rpcclient.

(This used to be commit dee99e40454b00da70343047c57e0cb0f2c489bd)

14 years agor23627: Allow to pass down the lookup-level to rpccli_lsa_lookup_names().
Günther Deschner [Wed, 27 Jun 2007 11:42:17 +0000 (11:42 +0000)]
r23627: Allow to pass down the lookup-level to rpccli_lsa_lookup_names().

(This used to be commit e9a7512a9f630340004913f1379452eea8a9b6ae)

14 years agor23625: Reformating WBFLAGs, just a cosmetic change.
Günther Deschner [Wed, 27 Jun 2007 09:38:07 +0000 (09:38 +0000)]
r23625: Reformating WBFLAGs, just a cosmetic change.

(This used to be commit 555ae4a19b35b0672033798e00e3d1e153d2a9b3)

14 years agor23624: Merge dos error code from samba4 (returned from dfs_Enum against w2k3 as...
Günther Deschner [Wed, 27 Jun 2007 09:36:00 +0000 (09:36 +0000)]
r23624: Merge dos error code from samba4 (returned from dfs_Enum against w2k3 as soon
as a one DFS_VOLUME_FLAVOR_AD_BLOB dfsroot exists).

(This used to be commit 837b0a14c430faa4e4cada03a1efe2823a7b2e2e)

14 years agor23623: Fix rpcclient and rpc_server with new DFS idl.
Günther Deschner [Wed, 27 Jun 2007 09:23:50 +0000 (09:23 +0000)]
r23623: Fix rpcclient and rpc_server with new DFS idl.

(This used to be commit bffe33dd261fdcf9ef8f9f232c15559661843c7c)

14 years agor23622: regenerate dfs rpc gen_ndr.
Günther Deschner [Wed, 27 Jun 2007 09:17:52 +0000 (09:17 +0000)]
r23622: regenerate dfs rpc gen_ndr.

(This used to be commit 71b3259962004c278ca2e859d5460ad47c2468d6)

14 years agor23621: Merge samba4 dfs rpc idl.
Günther Deschner [Wed, 27 Jun 2007 09:13:28 +0000 (09:13 +0000)]
r23621: Merge samba4 dfs rpc idl.

(This used to be commit bb43d56e92f4ea08fbf2ae4fa90570a101efd4e2)

14 years agor23620: Convert set_nt_acl to return NTSTATUS. Also fix the chown
Jeremy Allison [Tue, 26 Jun 2007 22:49:10 +0000 (22:49 +0000)]
r23620: Convert set_nt_acl to return NTSTATUS. Also fix the chown
return to correctly return NT_STATUS_INVALID_OWNER if it
should be disallowed. Matches better what W2K3R3 does.

NFSv4 ACL module owners, please examine these changes.

(This used to be commit fc6899a5506b272f8cd5f5837ca13300b4e69a5f)

14 years agor23619: Fix compile warning in fill_grent_mem() caused by mismatched counter size.
Gerald Carter [Tue, 26 Jun 2007 21:22:01 +0000 (21:22 +0000)]
r23619: Fix compile warning in fill_grent_mem() caused by mismatched counter size.
(This used to be commit 05520d6b0a86c1cd5abbf6252c4a32629cdf8619)

14 years agor23616: Fix bugzilla #4719: must change password is not set from usrmgr.exe.
Jim McDonough [Tue, 26 Jun 2007 20:09:41 +0000 (20:09 +0000)]
r23616: Fix bugzilla #4719: must change password is not set from usrmgr.exe.

This was only affecting the newer versions of usrmgr.exe, because they
use a user_info_25 struct.  The password is getting set separately
inside that code, so the password last set time was getting set from the
password change logic.

We also were not parsing a number of fields (like logon hours) from the
user_info_25.  That should also be fixed.
(This used to be commit afabd68b6ae874aceba708dc36808ed007ad496c)

14 years agor23612: Revert 'net idmap dump' to the 3.0.24 behaviour.
Volker Lendecke [Tue, 26 Jun 2007 19:15:26 +0000 (19:15 +0000)]
r23612: Revert 'net idmap dump' to the 3.0.24 behaviour.
(This used to be commit 56a32f217a183f956ad1c57a62d61a43646aa391)

14 years agor23611: Fix typo in error message.
James Peach [Tue, 26 Jun 2007 18:18:44 +0000 (18:18 +0000)]
r23611: Fix typo in error message.
(This used to be commit 8ee76e43843c56869b23f58615635f986c162d01)