17 years agoBUG 758 -- patch from (James Peach); fix pdma build
Gerald Carter [Wed, 17 Mar 2004 17:13:26 +0000 (17:13 +0000)]
BUG 758 -- patch from (James Peach); fix pdma build

17 years agoChange check_path_syntax() to use the new next_mb_char_size() function
Jeremy Allison [Wed, 17 Mar 2004 02:08:31 +0000 (02:08 +0000)]
Change check_path_syntax() to use the new next_mb_char_size() function
to make it generic. Remove the mb-codepage "blacklist". Alexander, please
check this fix as it reverts your blacklist changes, but I'm hoping it
fixes the problem in a more generic way for all charsets. I'm not trying
to trample on your (excellent!) work here, just make things more generic
without special cases.

17 years agoAdd function next_mb_char_size() that returns a size_t of the number of
Jeremy Allison [Tue, 16 Mar 2004 21:59:11 +0000 (21:59 +0000)]
Add function next_mb_char_size() that returns a size_t of the number of
bytes in the mb character at a pointer. Will be useful in fixing check_path_syntax()
to not use a "blacklist". Also re-added my (C) to reply.c. I mean, really - I've
been adding code to the file for over 10 years and I recognise many of the
fuctions as mine ! :-).

17 years agofix overlapping memory bug when copying username
Gerald Carter [Tue, 16 Mar 2004 20:28:47 +0000 (20:28 +0000)]
fix overlapping memory bug when copying username

17 years agoBUG 748 - patch from (James Peach); relax arg parsing to sambalp script
Gerald Carter [Tue, 16 Mar 2004 19:44:40 +0000 (19:44 +0000)]
BUG 748 - patch from (James Peach); relax arg parsing to sambalp script

17 years agoBUG 768 - patch from (James Peach); accept profileing arg to init...
Gerald Carter [Tue, 16 Mar 2004 19:43:04 +0000 (19:43 +0000)]
BUG 768 - patch from (James Peach); accept profileing arg to init script

17 years agoBUG 979 -- fix quota display on AIX; patch from (Heinric...
Gerald Carter [Tue, 16 Mar 2004 19:06:03 +0000 (19:06 +0000)]
BUG 979 -- fix quota display on AIX; patch from (Heinrich Mislik)

17 years agoBUG 1182: patch from (John Klinger) to reanable the -n 'no...
Gerald Carter [Tue, 16 Mar 2004 18:54:09 +0000 (18:54 +0000)]
BUG 1182: patch from (John Klinger) to reanable the -n 'no cache' option for winbindd

17 years agoFix check_path_syntax() for multibyte encodings which have no '\' as second byte.
Alexander Bokovoy [Tue, 16 Mar 2004 17:18:57 +0000 (17:18 +0000)]
Fix check_path_syntax() for multibyte encodings which have no '\' as second byte.
This is intermediate fix as discussed with Jeremy until we move check_path_syntax() to UCS2 internally where all
ambiguity is resolved. Please add other encodings into charcnv.c with such property.'

17 years agomerging print change notify fix from HP appliance. Also might address some one the...
Gerald Carter [Tue, 16 Mar 2004 17:06:11 +0000 (17:06 +0000)]
merging print change notify fix from HP appliance.  Also might address some one the issues in BUG 1007

17 years agoBUG 1165, 1126: Fix bug with secondary groups (security = ads) and winbind use defaul...
Gerald Carter [Tue, 16 Mar 2004 16:41:54 +0000 (16:41 +0000)]
BUG 1165, 1126: Fix bug with secondary groups (security = ads) and winbind use default domain = yes

17 years agoAvoid mb conversion overflow when sending an announcement.
Jeremy Allison [Tue, 16 Mar 2004 00:10:30 +0000 (00:10 +0000)]
Avoid mb conversion overflow when sending an announcement.

17 years agoUse "unix netbios name" type unstring - 64 bytes long to manipulate netbios
Jeremy Allison [Mon, 15 Mar 2004 21:45:45 +0000 (21:45 +0000)]
Use "unix netbios name" type unstring - 64 bytes long to manipulate netbios
names in nmbd. Allows conversion from dos codepage mb strings (ie. SJIS) to
expand to utf8 size on read.

17 years agoremoving extra comma in --with-fhs
Gerald Carter [Mon, 15 Mar 2004 16:20:03 +0000 (16:20 +0000)]
removing extra comma in --with-fhs

17 years agoinclude swatdir in 'make showlayout'
Gerald Carter [Mon, 15 Mar 2004 16:14:04 +0000 (16:14 +0000)]
include swatdir in 'make showlayout'

17 years agofix byte ordering problem when storing the updating pid for the lpq cache; was causin...
Gerald Carter [Mon, 15 Mar 2004 15:06:33 +0000 (15:06 +0000)]
fix byte ordering problem when storing the updating pid for the lpq cache; was causing an abort in process_exists() on solaris

17 years agoWhen trying to remove a user from a group, winbind should be informed
Volker Lendecke [Sun, 14 Mar 2004 07:15:39 +0000 (07:15 +0000)]
When trying to remove a user from a group, winbind should be informed
about the user and group...


17 years agoUse possessive in message asking for user's password.
Tim Potter [Sun, 14 Mar 2004 03:47:03 +0000 (03:47 +0000)]
Use possessive in message asking for user's password.

17 years agoEnsure we don't truncate strcmps to nstring anymore...
Jeremy Allison [Sat, 13 Mar 2004 02:47:21 +0000 (02:47 +0000)]
Ensure we don't truncate strcmps to nstring anymore...

17 years agoModified fix for bugid #784. Based on a patch from (MORIYAM...
Jeremy Allison [Sat, 13 Mar 2004 02:16:21 +0000 (02:16 +0000)]
Modified fix for bugid #784. Based on a patch from (MORIYAMA Masayuki).
Don't use nstrings to hold workgroup and netbios names. The problem with them is that MB netbios
and workgroup names in unix charset (particularly utf8) may be up to 3x bigger than the name
when represented in dos charset (ie. cp932). So go back to using fstrings for these but
translate into nstrings (ie. 16 byte length values) for transport on the wire.

17 years agoFirst part of patch from (MORIYAMA Masayuki) to
Jeremy Allison [Sat, 13 Mar 2004 00:28:53 +0000 (00:28 +0000)]
First part of patch from (MORIYAMA Masayuki) to
fix up netbios names with mb strings. Includes reformat of libsmb/nmblib.c
so it's readable.

17 years agoif we are truncating to the . we need to start at the beginning in case
Herb Lewis [Fri, 12 Mar 2004 21:35:15 +0000 (21:35 +0000)]
if we are truncating to the . we need to start at the beginning in case
there are multiple "."'s in the name.

This code is protected with an #ifdef TRUNCATE_NETBIOS_NAME and this
is #define'd to 1 directly above. Should we also get rid of the #ifdef?

17 years agoFix from (Robert Dahlem) for bugid #1048
Jeremy Allison [Fri, 12 Mar 2004 20:24:05 +0000 (20:24 +0000)]
Fix from (Robert Dahlem) for bugid #1048
when mangled names are turned off.

17 years agoFix problems with very long filenames in both smbd and smbclient.
Alexander Bokovoy [Fri, 12 Mar 2004 14:37:37 +0000 (14:37 +0000)]
Fix problems with very long filenames in both smbd and smbclient.
It appears that we pass filename through resolve_wildcards() as pstring and use fstring temporary buffer there.
As result, a long filename in unix charset (UTF-8 by default) can easily expand over 255 bytes while
Windows is able to send to us such names (e.g. Japanese name of ~190 mb chars) which we unable to process through
this small fstring buffer. Tested with W2K and smbclient, Japanese and Cyrillics.

17 years agoFix build after Jeremy -- yet another place where convert_string() wasn't updated
Alexander Bokovoy [Fri, 12 Mar 2004 12:57:39 +0000 (12:57 +0000)]
Fix build after Jeremy -- yet another place where convert_string() wasn't updated

17 years agoFix string overflow due to wrong size calculation
Alexander Bokovoy [Fri, 12 Mar 2004 11:21:50 +0000 (11:21 +0000)]
Fix string overflow due to wrong size calculation

17 years agoAllow msdfs symlink syntax to be more forgiving (it took me ages to remember
Jeremy Allison [Fri, 12 Mar 2004 01:43:25 +0000 (01:43 +0000)]
Allow msdfs symlink syntax to be more forgiving (it took me ages to remember
what it was :-). Allow msdfs links to now look like UNC paths : eg.
sym_link -> msdfs://server/share/path/in/share
or :
sym_link -> msdfs:\\server\share\path\in\share

17 years agoRestore the contract on all convert_stringXX() interfaces. Add a "allow_bad_conv"
Jeremy Allison [Thu, 11 Mar 2004 22:48:24 +0000 (22:48 +0000)]
Restore the contract on all convert_stringXX() interfaces. Add a "allow_bad_conv"
boolean parameter that allows broken iconv conversions to work. Gets rid of the
nasty errno checks in mangle_hash2 and check_path_syntax and allows correct
return code checking.

17 years agoGet MungedDial actually working with full TS strings in it for pdb_ldap.
Jim McDonough [Thu, 11 Mar 2004 16:32:19 +0000 (16:32 +0000)]
Get MungedDial actually working with full TS strings in it for pdb_ldap.
I know this isn't pretty, but neither was our assumption that all strings
from the directory fit inside a pstring.  There was no way this worked
before will all versions of usrmgr (for example, the only version of
mine that has the TS Confic button).

17 years agoadd missing #ifdef HAVE_BICONV stuff
Herb Lewis [Thu, 11 Mar 2004 15:12:59 +0000 (15:12 +0000)]
add missing #ifdef HAVE_BICONV stuff

17 years agoBUG 1088: patch from SATOH Fumiyasu <> -- use strchr_m() for...
Gerald Carter [Thu, 11 Mar 2004 14:39:32 +0000 (14:39 +0000)]
BUG 1088: patch from SATOH Fumiyasu <> -- use strchr_m() for query_host (smbclient -L)

17 years agoEnsure we use check_path_syntax() to pull out DFS paths.
Jeremy Allison [Thu, 11 Mar 2004 00:42:33 +0000 (00:42 +0000)]
Ensure we use check_path_syntax() to pull out DFS paths.

17 years agoFix processing of pathnames with embedded '\\' characters (0x5c) in CP932
Jeremy Allison [Thu, 11 Mar 2004 00:31:47 +0000 (00:31 +0000)]
Fix processing of pathnames with embedded '\\' characters (0x5c) in CP932
character set. Because of the allowing of "broken conversions" for people
who have broken iconv libraries we can't rely on the return from convert_string()
to be valid - we must check errno instead. This is ripe for revisiting at
some stage. I prefer adding a bool parameter to all convert_string_XX varients
to specify if we will allow broken conversions or not. With "allow_broken_conversions"
set to false we could then rely on the return from convert_string rather than
checking errno.

17 years agoanother typo
Herb Lewis [Wed, 10 Mar 2004 03:08:14 +0000 (03:08 +0000)]
another typo

17 years agoMoving towards getting msdfs working again (this looks like it was broken
Jeremy Allison [Wed, 10 Mar 2004 02:38:39 +0000 (02:38 +0000)]
Moving towards getting msdfs working again (this looks like it was broken
in 3.0.2a actually). We now send a correct referral back, but the client
refuses to follow it... Not sure why. Will do more tests.. Maybe unicode
character count is wrong (it looks it).

17 years agoFormatting reformat before I start to change anything here.
Jeremy Allison [Wed, 10 Mar 2004 01:32:26 +0000 (01:32 +0000)]
Formatting reformat before I start to change anything here.

17 years agofix typo for tag in proto file
Herb Lewis [Wed, 10 Mar 2004 00:53:36 +0000 (00:53 +0000)]
fix typo for tag in proto file

17 years agoFix dfs referrals - don't use check_path_syntax. Also use mb char calls in
Jeremy Allison [Tue, 9 Mar 2004 23:26:58 +0000 (23:26 +0000)]
Fix dfs referrals - don't use check_path_syntax. Also use mb char calls in
dfs code.

17 years agoYet another '\n' termination of debug message.
Rafal Szczesniak [Tue, 9 Mar 2004 21:47:49 +0000 (21:47 +0000)]
Yet another '\n' termination of debug message.


17 years agoFix to debug message lacking termination with '\n'.
Rafal Szczesniak [Tue, 9 Mar 2004 18:58:19 +0000 (18:58 +0000)]
Fix to debug message lacking termination with '\n'.


17 years agofix build with gcc 2.96 and --with-developer
Gerald Carter [Tue, 9 Mar 2004 15:29:16 +0000 (15:29 +0000)]
fix build with gcc 2.96 and --with-developer

17 years agoGiven how core this code is, I figure it should have it's own testsuite.
Andrew Bartlett [Tue, 9 Mar 2004 11:15:44 +0000 (11:15 +0000)]
Given how core this code is, I figure it should have it's own testsuite.

Big thanks to tpot and mbp for showing how easy it can be to write a simple
unit test, and for providing the STF.

This also changes the strstr_m() code to use strstr_w() (avoiding
duplication) and fixes it so that it passes the STF.

(We now always restart before doing the unicode run, until sombody can
show me why the testsuite is wrong).

Andrew Bartlett

17 years agoJRA's recent strstr_m work really badly broke our string_sub code.
Andrew Bartlett [Tue, 9 Mar 2004 09:56:33 +0000 (09:56 +0000)]
JRA's recent strstr_m work really badly broke our string_sub code.

For example:

strstr_m("%v foo bar", "%v") would fail...

only strstr_m("foo %v", "%v") could work.

I wonder what else this broke...

Fix is to move to using strncmp() inside the strstr_m function.

Tested on ASCII only.

Andrew Bartlett

17 years agoAdded strstr_m() function. Use in all places where we might run into mb
Jeremy Allison [Tue, 9 Mar 2004 00:17:14 +0000 (00:17 +0000)]
Added strstr_m() function. Use in all places where we might run into mb
(should fix the mb service name problem, can't remember the bugid).

17 years agoFix assumption about following directory sep in check_path_syntax(). We
Jeremy Allison [Mon, 8 Mar 2004 21:54:54 +0000 (21:54 +0000)]
Fix assumption about following directory sep in check_path_syntax(). We
need to try and convert 1 byte, then 2 bytes if that fails. Fixes bug
reported by Simo.

17 years agoGet us a little closer to Windows LSA semantics.
Volker Lendecke [Sun, 7 Mar 2004 08:22:06 +0000 (08:22 +0000)]
Get us a little closer to Windows LSA semantics.

A windows DC does not reply to DCNAME\\Administrator, only to
DOMAIN\\Administrator. Fix that.

Without winbind we are wrong as domain members, we should forward the request
DOMAIN\\Username to the DC on behalf of the asking client. Winbind fixes that


17 years agoMention wb_delgrpmem fix
Volker Lendecke [Sun, 7 Mar 2004 08:18:35 +0000 (08:18 +0000)]
Mention wb_delgrpmem fix

17 years agoThis might not be used a lot and might not survive for long, but at least it
Volker Lendecke [Sun, 7 Mar 2004 08:16:10 +0000 (08:16 +0000)]
This might not be used a lot and might not survive for long, but at least it
should work as expected :-)

Fix wb_delgrpmember.


17 years agoFix typo.
Tim Potter [Sun, 7 Mar 2004 01:14:11 +0000 (01:14 +0000)]
Fix typo.

17 years agoMerge from HEAD.
Tim Potter [Sun, 7 Mar 2004 00:50:37 +0000 (00:50 +0000)]
Merge from HEAD.

17 years agoMerge from HEAD.
Tim Potter [Sun, 7 Mar 2004 00:09:36 +0000 (00:09 +0000)]
Merge from HEAD.

17 years agoSeveral mb tidyups - getting ready to address the XXX_sub function.
Jeremy Allison [Fri, 5 Mar 2004 22:32:45 +0000 (22:32 +0000)]
Several mb tidyups - getting ready to address the XXX_sub function.

17 years agoBUG 488: fix the 'show client in col 1' button and corrctely enumerate active connections
Gerald Carter [Fri, 5 Mar 2004 18:37:01 +0000 (18:37 +0000)]
BUG 488: fix the 'show client in col 1' button and corrctely enumerate active connections

17 years agofix compiler warning
Gerald Carter [Fri, 5 Mar 2004 17:39:38 +0000 (17:39 +0000)]
fix compiler warning

17 years agoAdd -O (for writing downloaded files to standard out) based on patch by
Jelmer Vernooij [Fri, 5 Mar 2004 17:17:31 +0000 (17:17 +0000)]
Add -O (for writing downloaded files to standard out) based on patch by
Bas van Sisseren <>

17 years agobring WHATSNEW back up to date
Gerald Carter [Fri, 5 Mar 2004 15:37:08 +0000 (15:37 +0000)]
bring WHATSNEW back up to date

17 years agoall_string_sub() is broken as it doesn't handle mb chars correctly (and
Jeremy Allison [Fri, 5 Mar 2004 01:37:12 +0000 (01:37 +0000)]
all_string_sub() is broken as it doesn't handle mb chars correctly (and
so breaks when substitution '/' and '\'). It's used by unix_clean_name(),
which is used by reduce_name, which is used by check_name() (phew!).
Now that we know all filenames passed to check_name() are in a "good"
format (no double slashes, all '\\' chars translated to '/' etc.) due
to the new check_path_syntax() we can avoid calling reduce_name unless
widelinks are denied. After this check-in I can fix all_string_sub() to
handle mb chars correctly as it won't be in the direct path in the
main path handling code.

17 years agoFix my breakage of NT pipes from the previous patch (sorry). Use the
Jeremy Allison [Thu, 4 Mar 2004 18:55:37 +0000 (18:55 +0000)]
Fix my breakage of NT pipes from the previous patch (sorry). Use the
original srvstr_pull_buf() function to get the pipename not srvstr_get_path().

17 years agoBUG 1015: patch from jmcd to fix statfs redeclaration of statfs struct on ppc
Gerald Carter [Thu, 4 Mar 2004 18:34:45 +0000 (18:34 +0000)]
BUG 1015: patch from jmcd to fix statfs redeclaration of statfs struct on ppc

17 years agoBUG 1080: fix declaration of SMB_BIG_UINT
Gerald Carter [Thu, 4 Mar 2004 18:17:01 +0000 (18:17 +0000)]
BUG 1080: fix declaration of SMB_BIG_UINT

17 years agoThere's a specific error message NT_STATUS_ALIAS_EXISTS.
Volker Lendecke [Thu, 4 Mar 2004 17:57:21 +0000 (17:57 +0000)]
There's a specific error message NT_STATUS_ALIAS_EXISTS.

17 years agoAnother typo, sorry for samba-cvs spam :-)
Volker Lendecke [Thu, 4 Mar 2004 17:51:29 +0000 (17:51 +0000)]
Another typo, sorry for samba-cvs spam :-)

17 years agoFix typo.
Volker Lendecke [Thu, 4 Mar 2004 17:47:14 +0000 (17:47 +0000)]
Fix typo.


17 years agoFix build farm, older compilers won't let you declare variables
Jim McDonough [Thu, 4 Mar 2004 16:24:13 +0000 (16:24 +0000)]
Fix build farm, older compilers won't let you declare variables
right in the middle of the code.

I just love catching jra on stuff like this, after all the crap
I've done. :-)

17 years agoBUG 848: don't create winbind local users/groups that already exist in the tdb
Gerald Carter [Thu, 4 Mar 2004 15:59:11 +0000 (15:59 +0000)]
BUG 848: don't create winbind local users/groups that already exist in the tdb

17 years agoanother fix for bug 761; don't default to bsd printing on linux
Gerald Carter [Thu, 4 Mar 2004 15:18:36 +0000 (15:18 +0000)]
another fix for bug 761; don't default to bsd printing on linux

17 years agoAdded client "hardlink" commant to test doing NT rename with hard links.
Jeremy Allison [Wed, 3 Mar 2004 23:14:23 +0000 (23:14 +0000)]
Added client "hardlink" commant to test doing NT rename with hard links.
Added hardlink_internals() code - UNIX extensions now use this too.

17 years agoUse a common function to parse all pathnames from the wire. This allows
Jeremy Allison [Wed, 3 Mar 2004 20:55:59 +0000 (20:55 +0000)]
Use a common function to parse all pathnames from the wire. This allows
much closer emulation of Win2k3 error return codes.

17 years agoset log file to smbd.log for interaction with logrotate (BUG 503)
Gerald Carter [Wed, 3 Mar 2004 17:56:29 +0000 (17:56 +0000)]
set log file to smbd.log for interaction with logrotate (BUG 503)

17 years agomore usrmgr fixes: display lockout timers in minutes, not seconds, for samr 2e
Jim McDonough [Wed, 3 Mar 2004 17:44:00 +0000 (17:44 +0000)]
more usrmgr fixes: display lockout timers in minutes, not seconds, for samr 2e

17 years agoquick for for usrmgr. unknown_6 is really max dimension of logon hours array. need...
Jim McDonough [Wed, 3 Mar 2004 04:23:43 +0000 (04:23 +0000)]
quick for for usrmgr.  unknown_6 is really max dimension of logon hours array.  need to update passdb for this.

17 years agoMerge fields_present function from HEAD. Now, a field will not be updated
Jim McDonough [Tue, 2 Mar 2004 21:02:09 +0000 (21:02 +0000)]
Merge fields_present function from HEAD.  Now, a field will not be updated
on setuserinfo levels which include this field, unless the corresponding
bit (defined in passdb.h) is turned on.  Without this, newer versions
of usrmgr break us pretty bad.

17 years agoBUG 1129: patch from (Shiro Yamada) to install image files...
Gerald Carter [Tue, 2 Mar 2004 18:10:12 +0000 (18:10 +0000)]
BUG 1129: patch from (Shiro Yamada) to install image files for SWAT

17 years agoJanitorial duty for tpot - --with-fhs fix.
Jeremy Allison [Tue, 2 Mar 2004 18:07:06 +0000 (18:07 +0000)]
Janitorial duty for tpot - --with-fhs fix.

17 years agofix typo for callback bit
Jim McDonough [Tue, 2 Mar 2004 18:04:16 +0000 (18:04 +0000)]
fix typo for callback bit

17 years agoallow the 'printing' parameter to be set on a per share basis.
Gerald Carter [Tue, 2 Mar 2004 14:26:45 +0000 (14:26 +0000)]
allow the 'printing' parameter to be set on a per share basis.
The problem was that the current_printif struct was set during
print_backend_init() based on the 'printcap name'.  So you could
not use cups and then override the setting for a specific printer
by setting 'printing = bsd' (a common setup for pdf generation
print services.

There is a subtle change in behavior in that the print
interface functions are selecting on the basis of lp_printing()
and not lp_printcap_name(), but the new behavior seems more
intuitive IMHO.

17 years agoBUG 761: read the config file before initialized default values for printing options
Gerald Carter [Tue, 2 Mar 2004 04:09:39 +0000 (04:09 +0000)]
BUG 761: read the config file before initialized default values for printing options

17 years agoBUG 692: patch from SATOH Fumiyasu <> to correct truncation...
Gerald Carter [Mon, 1 Mar 2004 17:40:40 +0000 (17:40 +0000)]
BUG 692: patch from SATOH Fumiyasu <> to correct truncation of share names and workgroup names

17 years agoBUG 1147; bad pointer case in get_stored_queue_info() causing seg fault
Gerald Carter [Mon, 1 Mar 2004 17:03:05 +0000 (17:03 +0000)]
BUG 1147; bad pointer case in get_stored_queue_info() causing seg fault

17 years agonet_rpc.c: Don't complain if [add|del]mem was successful.
Volker Lendecke [Sun, 29 Feb 2004 16:34:33 +0000 (16:34 +0000)]
net_rpc.c: Don't complain if [add|del]mem was successful.

srv_samr_nt.c: Correctly report that a user is not member of an alias.


17 years agoPrint an informative error message if trying to add/remove members from
Volker Lendecke [Sun, 29 Feb 2004 12:47:45 +0000 (12:47 +0000)]
Print an informative error message if trying to add/remove members from
something not a group.


17 years agoAdd 'net rpc group [add|del]mem' for domain groups and aliases.
Volker Lendecke [Sat, 28 Feb 2004 18:41:16 +0000 (18:41 +0000)]
Add 'net rpc group [add|del]mem' for domain groups and aliases.


17 years agoFix my fix to net rpc group list. We can certainly have more than a single
Volker Lendecke [Sat, 28 Feb 2004 08:18:09 +0000 (08:18 +0000)]
Fix my fix to net rpc group list. We can certainly have more than a single
set of groups.


17 years agoCan't set allocation size on directories, return correct error code on
Jeremy Allison [Sat, 28 Feb 2004 01:53:30 +0000 (01:53 +0000)]
Can't set allocation size on directories, return correct error code on
fail if file exists and target is a directory. gentest.

17 years agoMore gentest fixes. Fix up regression in IS_NAME_VALID and renames.
Jeremy Allison [Sat, 28 Feb 2004 00:56:42 +0000 (00:56 +0000)]
More gentest fixes. Fix up regression in IS_NAME_VALID and renames.

17 years agoAdded copyrights I forgot about looong ago...
Rafal Szczesniak [Fri, 27 Feb 2004 22:15:38 +0000 (22:15 +0000)]
Added copyrights I forgot about looong ago...


17 years agoFix for writable printerdata problem - bugzilla #1112.
Tim Potter [Thu, 26 Feb 2004 23:04:11 +0000 (23:04 +0000)]
Fix for writable printerdata problem - bugzilla #1112.

17 years agoThat const was one too many
Volker Lendecke [Thu, 26 Feb 2004 14:34:44 +0000 (14:34 +0000)]
That const was one too many

17 years agoImplement 'net groupmap set' and 'net groupmap cleanup'.
Volker Lendecke [Thu, 26 Feb 2004 11:29:56 +0000 (11:29 +0000)]
Implement 'net groupmap set' and 'net groupmap cleanup'.

I was rather annoyed by the net groupmap syntax, I could never get it

net groupmap set "domain admins" domadm

creates a mapping,

net groupmap set "domain admins" -C "Comment" -N "newntname"

should also do what you expect. I'd like to have some feedback on the usability
of this.

net groupmap cleanup

solves a problem I've had two times now: Our SID changed, and a user's primary
group was mapped to a SID that is not ours. net groupmap cleanup removes all
mappings that are not from our domain sid.


17 years agoAnd another little const
Volker Lendecke [Thu, 26 Feb 2004 11:07:06 +0000 (11:07 +0000)]
And another little const

17 years agoApply some const
Volker Lendecke [Thu, 26 Feb 2004 10:55:43 +0000 (10:55 +0000)]
Apply some const


17 years agoFixes to minor security bug pointed out by AB in the mount helper
Steve French [Thu, 26 Feb 2004 06:42:51 +0000 (06:42 +0000)]
Fixes to minor security bug pointed out by AB in the mount helper

17 years agofixed compilation with --enable-dmalloc
Andrew Tridgell [Thu, 26 Feb 2004 02:11:31 +0000 (02:11 +0000)]
fixed compilation with --enable-dmalloc

the macro redefinition of free() means we cannot have a structure
element called "free"

17 years agoMerging Richard's rename test.
Jeremy Allison [Thu, 26 Feb 2004 01:33:35 +0000 (01:33 +0000)]
Merging Richard's rename test.

17 years agoInteresting fact found by IFSTEST /t LockOverlappedTest...
Jeremy Allison [Thu, 26 Feb 2004 01:31:10 +0000 (01:31 +0000)]
Interesting fact found by IFSTEST /t LockOverlappedTest...
Even if it's our own lock context, we need to wait here as
there may be an unlock on the way.
So I removed a "&& !my_lock_ctx" from the following
if statement.

if ((lock_timeout != 0) && lp_blocking_locks(SNUM(conn)) && ERROR_WAS_LOCK_DENIED(status)) {


17 years agoFix bug in previous global_sam_sid() commit. I broke the 'read from
Andrew Bartlett [Wed, 25 Feb 2004 23:12:29 +0000 (23:12 +0000)]
Fix bug in previous global_sam_sid() commit.  I broke the 'read from
MACHINE.SID' file functionality.

Also, before we print out the results of 'net getlocalsid' and 'net
getdomainsid', ensure we have tried to read that file, or have
generated one.

Andrew Bartlett

17 years agoI *hate* global variables...
Andrew Bartlett [Wed, 25 Feb 2004 22:01:02 +0000 (22:01 +0000)]
I *hate* global variables...

OK, what was happening here was that we would invalidate global_sam_sid
when we set the sid into secrets.tdb, to force a re-read.

The problem was, we would do *two* writes into the TDB, and the second one
(in the PDC/BDC case) would be of a NULL pointer.  This caused smbd startups
to fail, on a blank TDB.

By using a local variable in the pdb_generate_sam_sid() code, we avoid this
particular trap.

I've also added better debugging for the case where this all matters, which
is particularly for LDAP, where it finds out a domain SID from the sambaDomain

Andrew Bartlett

17 years agoFixup strange rename error case (gentest).
Jeremy Allison [Wed, 25 Feb 2004 21:37:22 +0000 (21:37 +0000)]
Fixup strange rename error case (gentest).

17 years agoDo the query part of the previous fix...reset time and duration are set in minutes...
Jim McDonough [Wed, 25 Feb 2004 20:02:47 +0000 (20:02 +0000)]
Do the query part of the previous fix...reset time and duration are set in minutes, not seconds.  Works from usrmgr.

17 years agoreset time and duration are set in minutes, not seconds. Works from usrmgr.
Jim McDonough [Wed, 25 Feb 2004 15:02:55 +0000 (15:02 +0000)]
reset time and duration are set in minutes, not seconds.  Works from usrmgr.