ira/wip.git
12 years agoFix for bug 6651 - smbd SIGSEGV when breaking oplocks.
Jeremy Allison [Fri, 21 Aug 2009 22:07:25 +0000 (15:07 -0700)]
Fix for bug 6651 - smbd SIGSEGV when breaking oplocks.
Based on a patch submitted by Petr Vandrovec <petr@vandrovec.name>.
Multiple pending signals with siginfo_t's weren't being handled correctly
leading to smbd abort with kernel oplock signals.
Jeremy

12 years agos3: fix bug #6650, authentication at member servers when winbindd is not running
Michael Adam [Fri, 21 Aug 2009 11:59:16 +0000 (13:59 +0200)]
s3: fix bug #6650, authentication at member servers when winbindd is not running

Authentication of domain users on the member server fails when winbindd
is not running. This is because the is_trusted_domain() check  behaves
differently when winbindd is running and when it isn't:
Since wb_is_trusted_domain() calls wbcDomainInfo(), and this will also
give a result for our own domain, this succeeds for the member
server's own domain when winbindd is running. When winbindd is not
running, is_trusted_domain() checks (and possibly updates) the trustdom
cache, and this does the lsa_EnumTrustDom() rpc call to the DC which
does not return its own domain.

In case of winbindd not running, before 3.4, the domain part was _silently_
mapped to the workgroup in auth_util.c:make_user_info_map(),
which effectively did nothing in the member case.

But then the parameter "map untrusted to domain" was introduced
and the mapping was made to the workstation name instead of
the workgroup name by default unless "map untrusted to domain = yes".
(Commits
 d8c54fddda2dba3cbc5fc13e93431b152813892e,
 5cd4b7b7c03df6e896186d985b6858a06aa40b3f, and
 fbca26923915a70031f561b198cfe2cc0d9c3aa6)
This was ok as long as winbindd was running, but with winbindd not running,
these changes actually uncovered the above logic bug in the check.

So the correct check is to treat the workgroup as trusted / or known
in the member case. This is most easily achieved by not comparing the
domain name against get_global_sam_name() which is the host name unless
for a DC but against my_sam_name() which is the workgroup for a DC and for
a member, too. (These names are not very intuitive...)

I admit that this is a very long commit message for a one-liner, but this has
needed some tracking down, and I think the change deserves some justification.

Michael

12 years agos4:client
Sam Liddicott [Fri, 21 Aug 2009 14:54:49 +0000 (16:54 +0200)]
s4:client

Put was assuming that the remote name was always absolute, and not relative to
the current remote directory.

Signed-off-by: Sam Liddicott <sam@liddicott.com>
12 years agoAdd missing CreateFile flags to smb.h
Steve French [Fri, 21 Aug 2009 12:56:32 +0000 (14:56 +0200)]
Add missing CreateFile flags to smb.h

12 years agos4:ldb Python requires that a 'compare' handler return -1, 0 or 1
Andrew Bartlett [Fri, 21 Aug 2009 07:50:04 +0000 (17:50 +1000)]
s4:ldb Python requires that a 'compare' handler return -1, 0 or 1

12 years agos4:ldb Use length-limited printf to avoid walking off end of strings
Andrew Bartlett [Wed, 19 Aug 2009 03:26:34 +0000 (13:26 +1000)]
s4:ldb Use length-limited printf to avoid walking off end of strings

This should ensure the debug messages do not have random characters at
their ends.

Andrew Bartlett

12 years agos4:kerberos Use MIT compatible names for these enc types
Andrew Bartlett [Tue, 18 Aug 2009 02:08:37 +0000 (12:08 +1000)]
s4:kerberos Use MIT compatible names for these enc types

This is a small start on (ie, the only trivial part of) the work shown in:
http://k5wiki.kerberos.org/wiki/Projects/Samba4_Port#Samba.27s_use_of_Heimdal_symbols.2C_with_MIT_differences
(a table of all Kerberos symbols used in Samba4, and notes on where
they differ from those provided with MIT Kerberos)

Andrew Bartlett

12 years agoFix bug 6638 - ADS Domain Member: Computer Mgr can not set share ACLs
Jeremy Allison [Thu, 20 Aug 2009 18:08:21 +0000 (11:08 -0700)]
Fix bug 6638 - ADS Domain Member: Computer Mgr can not set share ACLs
Add good error message for share modification denial.
Jeremy.

12 years agos3-idmap: fix two uninitialized variable warnings in idmap_tdb2.
Günther Deschner [Thu, 20 Aug 2009 13:28:19 +0000 (15:28 +0200)]
s3-idmap: fix two uninitialized variable warnings in idmap_tdb2.

Guenther

12 years agos3:dsgetdcname: Fix a crash in dsgetdcname
Volker Lendecke [Wed, 19 Aug 2009 12:22:09 +0000 (14:22 +0200)]
s3:dsgetdcname: Fix a crash in dsgetdcname

When returning NT_STATUS_OK we can't leave *info == NULL, this crashes
in is_closest_site called from dsgetdcname().

Signed-off-by: Günther Deschner <gd@samba.org>
12 years agos3:dsgetdcname: Inline dsgetdcname_cache_refresh
Volker Lendecke [Wed, 19 Aug 2009 12:19:22 +0000 (14:19 +0200)]
s3:dsgetdcname: Inline dsgetdcname_cache_refresh

Signed-off-by: Günther Deschner <gd@samba.org>
12 years agos4-spoolss: add stubs for new idl opcodes in spoolss server.
Günther Deschner [Mon, 10 Aug 2009 15:09:41 +0000 (17:09 +0200)]
s4-spoolss: add stubs for new idl opcodes in spoolss server.

Guenther

12 years agos3-spoolss: add stubs for new idl opcodes in spoolss server.
Günther Deschner [Mon, 10 Aug 2009 14:45:47 +0000 (16:45 +0200)]
s3-spoolss: add stubs for new idl opcodes in spoolss server.

Guenther

12 years agos3: re-run make samba3-idl.
Günther Deschner [Mon, 10 Aug 2009 14:45:13 +0000 (16:45 +0200)]
s3: re-run make samba3-idl.

Guenther

12 years agospoolss: add more spoolss calls to IDL
Günther Deschner [Mon, 10 Aug 2009 14:44:19 +0000 (16:44 +0200)]
spoolss: add more spoolss calls to IDL
(spoolss_GetPrinterDriverPackagePath and spoolss_GetCorePrinterDrivers).

Guenther

12 years agoFix bug #6647 - get_root_nt_token: getpwnam("root") failed!
Jeremy Allison [Wed, 19 Aug 2009 23:55:26 +0000 (16:55 -0700)]
Fix bug #6647 - get_root_nt_token: getpwnam("root") failed!
Not all systems may have a "root" user, but all must have a passwd
entry for a uid of zero.
Jeremy.

12 years agoFix Red Hat bugzilla bug : https://bugzilla.redhat.com/show_bug.cgi?id=516165
Jeremy Allison [Wed, 19 Aug 2009 22:33:08 +0000 (15:33 -0700)]
Fix Red Hat bugzilla bug : https://bugzilla.redhat.com/show_bug.cgi?id=516165
nautilus fails to copy files from an SMB share. This is a show-stopper
for 3.4.1 (I'll open a Samba.org bug). Although gnome-vfs is doing
*incredibly* stupid things by asking for a read size of 65535 - this
translates on the wire to a 65534 byte read followed by a 1 byte
read. Please send this back to the gnome developers that they
will ge horrid on the wire performance for this.
Jeremy.

12 years agos3:smbd: implement SMB2 Find (Query Directory)
Stefan Metzmacher [Thu, 6 Aug 2009 10:16:30 +0000 (12:16 +0200)]
s3:smbd: implement SMB2 Find (Query Directory)

metze

12 years agos3:smbd: store a dirptr on the files_struct for SMB2 Query Directory
Stefan Metzmacher [Thu, 6 Aug 2009 10:53:05 +0000 (12:53 +0200)]
s3:smbd: store a dirptr on the files_struct for SMB2 Query Directory

metze

12 years agos3:smbd: add a generic smbd_dirptr_lanman2_entry() function
Stefan Metzmacher [Fri, 14 Aug 2009 11:23:19 +0000 (13:23 +0200)]
s3:smbd: add a generic smbd_dirptr_lanman2_entry() function

This can we used by SMB2, the key difference between
SMB1 and SMB2 is that with SMB2 entries are aligned
to 8 bytes and there's no padding at the end of the last entry.

metze

12 years agos3:smbd: implement all SMB2 Create contexts except "ExtA"
Stefan Metzmacher [Sat, 15 Aug 2009 09:52:37 +0000 (11:52 +0200)]
s3:smbd: implement all SMB2 Create contexts except "ExtA"

metze

12 years agos3:smbd: make smbd_check_open_rights() function non-static for use in SMB2
Stefan Metzmacher [Wed, 19 Aug 2009 16:03:43 +0000 (18:03 +0200)]
s3:smbd: make smbd_check_open_rights() function non-static for use in SMB2

metze

12 years agos3 merged build: Don't build wbinfo twice.
Kai Blin [Wed, 19 Aug 2009 10:38:58 +0000 (12:38 +0200)]
s3 merged build: Don't build wbinfo twice.

Many, many thanks to Metze for telling me which chicken to sacrifice.

12 years agotevent: fix a comment
Michael Adam [Tue, 18 Aug 2009 09:53:42 +0000 (11:53 +0200)]
tevent: fix a comment

Michael

12 years agoMake refusal of SEC_DESC_DACL_PROTECTED configurable
Volker Lendecke [Thu, 13 Aug 2009 04:33:16 +0000 (06:33 +0200)]
Make refusal of SEC_DESC_DACL_PROTECTED configurable

This adds a parameter "gpfs:refuse_dacl_protected" that defaults to false.

GPFS has no place to store the SEC_DESC_DACL_PROTECTED ACL bit. With this
parameter we give customers an option to either ignore this bit or refuse
setting an ACL with it.

12 years agos3:smbd: parse context blobs in SMB2 Create
Stefan Metzmacher [Wed, 12 Aug 2009 18:39:58 +0000 (20:39 +0200)]
s3:smbd: parse context blobs in SMB2 Create

metze

12 years agoadded basic support for rename in DRS replication
Andrew Tridgell [Wed, 19 Aug 2009 05:53:19 +0000 (15:53 +1000)]
added basic support for rename in DRS replication

Added simple DRS rename support in replication. This should be done
async, and I'm not sure if we should also do any repl data updates to
indicate the rename. I'm still learning how this stuff works, but at
least this allows a rename on a DC to propogate correctly

12 years agowe need the Deleted Objects container for replication
Andrew Tridgell [Wed, 19 Aug 2009 05:51:07 +0000 (15:51 +1000)]
we need the Deleted Objects container for replication

When objects are deleted they get renamed to this container. The
container needs to exist when we provision

12 years agowbinfo: Fix up s3 blackbox test. wbinfo no longer needs a config file.
Kai Blin [Tue, 18 Aug 2009 20:10:04 +0000 (22:10 +0200)]
wbinfo: Fix up s3 blackbox test. wbinfo no longer needs a config file.

12 years agos4 winbind: Quiet down the WINBINDD_DOMAIN_INFO handler stub warning
Kai Blin [Tue, 18 Aug 2009 19:48:41 +0000 (21:48 +0200)]
s4 winbind: Quiet down the WINBINDD_DOMAIN_INFO handler stub warning

12 years agowbinfo: Reduce test noise in the wbinfo blackbox test
Kai Blin [Tue, 18 Aug 2009 19:42:37 +0000 (21:42 +0200)]
wbinfo: Reduce test noise in the wbinfo blackbox test

With the switch to libwbclient the previously stubbed out
--trusted-domains and --all-domains calls now fail. Set them to knownfail.

The previously knownfail -D test is now stubbed out, test it now.

This does not fix the issues with wbinfo -a and wbinfo -K not working on the
build farm. I have no idea whatsoever what is causing this, as those are broken
on my local machine even without my changes.

12 years agos4 winbind: Silence compile warning by adding new commands to the list
Kai Blin [Thu, 13 Aug 2009 07:43:40 +0000 (09:43 +0200)]
s4 winbind: Silence compile warning by adding new commands to the list

12 years agos4 winbind: Implement a stubbed out version of WINBINDD_DOMAIN_INFO
Kai Blin [Thu, 13 Aug 2009 07:42:14 +0000 (09:42 +0200)]
s4 winbind: Implement a stubbed out version of WINBINDD_DOMAIN_INFO

12 years agowbinfo: Use one codebase for Samba3 and Samba4.
Kai Blin [Wed, 12 Aug 2009 15:50:04 +0000 (17:50 +0200)]
wbinfo: Use one codebase for Samba3 and Samba4.

There can be only one....wbinfo that is.

12 years agos3 wbinfo: Only call afs_settoken_str if compiled with WITH_FAKE_KASERVER
Kai Blin [Wed, 12 Aug 2009 15:47:12 +0000 (17:47 +0200)]
s3 wbinfo: Only call afs_settoken_str if compiled with WITH_FAKE_KASERVER

12 years agos3 wbinfo: use wbcSidTypeString instead of sid_type_lookup
Kai Blin [Wed, 12 Aug 2009 15:43:40 +0000 (17:43 +0200)]
s3 wbinfo: use wbcSidTypeString instead of sid_type_lookup

12 years agolibwbclient: Add wbcSidTypeString function.
Kai Blin [Wed, 12 Aug 2009 15:41:23 +0000 (17:41 +0200)]
libwbclient: Add wbcSidTypeString function.

12 years agos3 wbinfo: Remove unused functions, use C99-types
Kai Blin [Wed, 12 Aug 2009 15:27:05 +0000 (17:27 +0200)]
s3 wbinfo: Remove unused functions, use C99-types

12 years agos3 wbinfo: Explicitly include popt header, remove unused common options.
Kai Blin [Wed, 12 Aug 2009 15:25:46 +0000 (17:25 +0200)]
s3 wbinfo: Explicitly include popt header, remove unused common options.

12 years agos3 wbinfo: Use talloc_strdup instead of SMB_STRDUP
Kai Blin [Wed, 12 Aug 2009 15:25:14 +0000 (17:25 +0200)]
s3 wbinfo: Use talloc_strdup instead of SMB_STRDUP

12 years agos3 wbinfo: Don't use global_myname()
Kai Blin [Wed, 12 Aug 2009 15:24:19 +0000 (17:24 +0200)]
s3 wbinfo: Don't use global_myname()

12 years agos3 wbinfo: Avoid ADD_TO_ARRAY macro.
Kai Blin [Wed, 12 Aug 2009 14:18:54 +0000 (16:18 +0200)]
s3 wbinfo: Avoid ADD_TO_ARRAY macro.

12 years agos3 wbinfo: Use uint32_t instead of uint32
Kai Blin [Wed, 12 Aug 2009 13:59:14 +0000 (15:59 +0200)]
s3 wbinfo: Use uint32_t instead of uint32

12 years agos3 wbinfo: remove --get-auth-user and --set-auth-user functionality
Kai Blin [Wed, 12 Aug 2009 21:41:32 +0000 (23:41 +0200)]
s3 wbinfo: remove --get-auth-user and --set-auth-user functionality

Point to the corresponding commands in "net" instead.

12 years agos3 net: Add getauthuser/setauthuser commands.
Kai Blin [Wed, 12 Aug 2009 21:40:05 +0000 (23:40 +0200)]
s3 net: Add getauthuser/setauthuser commands.

These replace the functionality of wbinfo --get-auth-user/--set-auth-user

12 years agos3 wbinfo: Get rid of lp_ functions
Kai Blin [Wed, 12 Aug 2009 13:51:20 +0000 (15:51 +0200)]
s3 wbinfo: Get rid of lp_ functions

This commit also fixes a lot of line lengths to make the file more readable.

12 years agos4 ctags: Stop *_proto.h files from cluttering up the tags
Kai Blin [Thu, 13 Aug 2009 07:40:43 +0000 (09:40 +0200)]
s4 ctags: Stop *_proto.h files from cluttering up the tags

12 years agos4: int32 handling: previous fix was not fully correct
Matthias Dieter Wallnöfer [Mon, 17 Aug 2009 18:42:39 +0000 (20:42 +0200)]
s4: int32 handling: previous fix was not fully correct

12 years agos4: Make the int32 problem more clear - and fix another error
Matthias Dieter Wallnöfer [Mon, 17 Aug 2009 18:29:11 +0000 (20:29 +0200)]
s4: Make the int32 problem more clear - and fix another error

12 years agos4:librpc/rpc: fix DEBUG() message
Stefan Metzmacher [Tue, 11 Aug 2009 17:49:33 +0000 (19:49 +0200)]
s4:librpc/rpc: fix DEBUG() message

metze

12 years agonetlogon: document some more MSVC flags.
Günther Deschner [Mon, 17 Aug 2009 14:49:24 +0000 (16:49 +0200)]
netlogon: document some more MSVC flags.

Some of these were observed during password changing
from win7 using a samba 3.4 PDC.

Guenther

12 years agos3-spoolss: remove another duplicate copy of print_architecture_table.
Günther Deschner [Wed, 12 Aug 2009 12:59:44 +0000 (14:59 +0200)]
s3-spoolss: remove another duplicate copy of print_architecture_table.

Guenther

12 years agofixed make test reporting success when provision fails
Andrew Tridgell [Mon, 17 Aug 2009 12:45:51 +0000 (22:45 +1000)]
fixed make test reporting success when provision fails

We were getting build test 'pass' on the build farm when the provision
is failing. The cause was the use of filter pipelines in the selftest
code in the makefile. A bourne shell will by default report the error
status of the last element of the pipeline, which means when provision
failed, make thought everything had passed.

We could use the bash 'pipefail' option to fix this, but it isn't
portable, so instead I've modified the makefile to touch st/st_done
when the first element in the pipeline completes successfully. That
means we now get errors in make test, at the expense of making the
makefile even more horrible than it was.

12 years agos4: Fixed the int32 datatype support
Matthias Dieter Wallnöfer [Mon, 17 Aug 2009 11:10:16 +0000 (13:10 +0200)]
s4: Fixed the int32 datatype support

Should finally fix bug #6136 ("groupType", "sAMAccountType" ... attributes).

12 years agofixed the build
Andrew Tridgell [Mon, 17 Aug 2009 11:40:19 +0000 (21:40 +1000)]
fixed the build

the changes from Matthias didn't take account of url and lp being None
in some ldb python instances in 'make test'

12 years agos4: Major rework of the LDB/SAMDB/IDMAP python bindings
Matthias Dieter Wallnöfer [Sat, 15 Aug 2009 13:20:09 +0000 (15:20 +0200)]
s4: Major rework of the LDB/SAMDB/IDMAP python bindings

- Centralise the lookups for the default domain (root) in the call "domain_dn"
- Reduce the LDB connections attempts ("connect" calls) from three to one
  - tools should load faster
- Make the LDB connection init more like the "ldb_wrap_connection" call
- Load the right UTF8 casefolder which fixes up problems with special characters
  (discovered by me: e.g. small "Umlaute" (ä, ö, ü, ...) in the DN weren't upcased
  - so records "seemed" lost in TDB)

12 years agos4:python tools - Centralise the lookups for the default domain (root) in the call...
Matthias Dieter Wallnöfer [Mon, 17 Aug 2009 09:47:53 +0000 (11:47 +0200)]
s4:python tools - Centralise the lookups for the default domain (root) in the call "domain_dn" from SamDB

12 years agos4:pyglue Add a wrapper for loading the correct UTF8 casefolder
Matthias Dieter Wallnöfer [Mon, 17 Aug 2009 09:46:23 +0000 (11:46 +0200)]
s4:pyglue Add a wrapper for loading the correct UTF8 casefolder

Needed for special characters (e.g. in German "Umlaute")

12 years agos4:ldb python bindings: Handle the parameters of the connect call in the right way
Matthias Dieter Wallnöfer [Sat, 15 Aug 2009 13:18:46 +0000 (15:18 +0200)]
s4:ldb python bindings: Handle the parameters of the connect call in the right way

12 years agoRevert "s4:samdb python bindings - we don't need the attributes here"
Matthias Dieter Wallnöfer [Mon, 17 Aug 2009 09:06:39 +0000 (11:06 +0200)]
Revert "s4:samdb python bindings - we don't need the attributes here"

This reverts commit 53ef426e6f68728763436bd0cd3dd91180c00579.

As abartlet pointed out this causes to load all attributes and therefore gives
us more here than we need (only the check for the DN)!

12 years agosigh - still not right
Andrew Tridgell [Mon, 17 Aug 2009 07:50:26 +0000 (17:50 +1000)]
sigh - still not right

12 years agofixed up add_foreign again
Andrew Tridgell [Mon, 17 Aug 2009 07:48:27 +0000 (17:48 +1000)]
fixed up add_foreign again

my last patch was not even close ...

I'll leave abartlet to work out how to fix the test case

12 years agomore fixups from provision changes
Andrew Tridgell [Mon, 17 Aug 2009 07:34:22 +0000 (17:34 +1000)]
more fixups from provision changes

Andrew, can you please check this? The idmap.setup_name_mapping tests
look totally out of place here. I'm also not sure I captured your
intention with the other changes

12 years agos3:smbd: add support for canceling SMB2 Notify calls.
Stefan Metzmacher [Sat, 15 Aug 2009 08:11:16 +0000 (10:11 +0200)]
s3:smbd: add support for canceling SMB2 Notify calls.

metze

12 years agos3:smbd: add smbd_notify_cancel_by_smbreq()
Stefan Metzmacher [Sat, 15 Aug 2009 08:07:00 +0000 (10:07 +0200)]
s3:smbd: add smbd_notify_cancel_by_smbreq()

This function will be used by the SMB2 notify code.

metze

12 years agos3:smbd: implement SMB2 Cancel correctly.
Stefan Metzmacher [Sat, 15 Aug 2009 08:01:38 +0000 (10:01 +0200)]
s3:smbd: implement SMB2 Cancel correctly.

metze

12 years agos4:build: require tevent 0.9.7 with tevent_req_cancel()
Stefan Metzmacher [Sat, 15 Aug 2009 08:45:21 +0000 (10:45 +0200)]
s4:build: require tevent 0.9.7 with tevent_req_cancel()

metze

12 years agotevent: change version to 0.9.7 after adding tevent_req_cancel infrastructure
Stefan Metzmacher [Sat, 15 Aug 2009 08:44:50 +0000 (10:44 +0200)]
tevent: change version to 0.9.7 after adding tevent_req_cancel infrastructure

metze

12 years agotevent: add tevent_req_cancel() infrastructure
Stefan Metzmacher [Sat, 15 Aug 2009 07:46:23 +0000 (09:46 +0200)]
tevent: add tevent_req_cancel() infrastructure

This offers a generic way for callers to cancel an
async request.

metze

12 years agoskip the autoidl test
Andrew Tridgell [Mon, 17 Aug 2009 03:29:34 +0000 (13:29 +1000)]
skip the autoidl test

The autoidl test is not needed now that we have IDL source
available. It also generates a lot of errors in the logs.

12 years agofixed up some provision errors from the recent changes
Andrew Tridgell [Mon, 17 Aug 2009 03:28:57 +0000 (13:28 +1000)]
fixed up some provision errors from the recent changes

12 years agos4:provision Add comments to the provision script
Andrew Bartlett [Mon, 17 Aug 2009 01:41:58 +0000 (11:41 +1000)]
s4:provision Add comments to the provision script

Hopefully this will explain a bit more whey things are done the way
that they are done.

Andrew Bartlett

12 years agos4:provision Avoid one more call to ltdb_reindex
Andrew Bartlett [Mon, 17 Aug 2009 01:33:25 +0000 (11:33 +1000)]
s4:provision Avoid one more call to ltdb_reindex

The Samba4 schema code (called via
samdb.set_schema_from_ldb(schema.ldb)) manages the @ATTRIBUTES and
@INDEXLIST records, so don't wipe them early.  The chances are that we
will not change them anyway.

Andrew Bartlett

12 years agos4:ldb Remove obsolete comment about ldb_tdb's sequence num
Andrew Bartlett [Mon, 17 Aug 2009 01:20:29 +0000 (11:20 +1000)]
s4:ldb Remove obsolete comment about ldb_tdb's sequence num

12 years agomake sure we update the current schema->prefixes when we add a new prefix
Andrew Tridgell [Mon, 17 Aug 2009 01:13:23 +0000 (11:13 +1000)]
make sure we update the current schema->prefixes when we add a new prefix

This triggered a failure in the updateNow schema test, as the current
global schema was not being updated when a new schema element was
added

12 years agofixed the updateNow schema test to use a canonical OID
Andrew Tridgell [Mon, 17 Aug 2009 01:12:10 +0000 (11:12 +1000)]
fixed the updateNow schema test to use a canonical OID

The expression time.strftime("%s", time.gmtime())[3:] leads to a
string with a leading 0. When added then read back from the prefix map
this leads to a different string, so it is never found.

Use the simpler str(random.randint(a,b)) expression instead

12 years agos4:selftest Remove the 'subunit filter' from make testenv etc
Andrew Bartlett [Fri, 14 Aug 2009 07:51:14 +0000 (17:51 +1000)]
s4:selftest Remove the 'subunit filter' from make testenv etc

The extra filter is no use for 'testenv', as we are not running tests,
but an xterm.  The filter also breaks running 'GDB_PROVISION=yes make
test', but at least if we can run 'GDB_PROVISION=yes make testenv'
then we can debug provision.

Andrew Bartlett

12 years agos4:libcli/ldap Explain why we set a hostname for ldapi:// connections
Andrew Bartlett [Fri, 14 Aug 2009 07:50:18 +0000 (17:50 +1000)]
s4:libcli/ldap Explain why we set a hostname for ldapi:// connections

It is a pretty odd thing to do, and it's only because of the
restrictions of DIGEST-MD5 in Cyrus SASL that we do it.

Andrew Bartlett

12 years agos4:provision Fix existing ldapi:// backend detection exception
Andrew Bartlett [Sun, 16 Aug 2009 23:52:09 +0000 (09:52 +1000)]
s4:provision Fix existing ldapi:// backend detection exception

Found by Oliver Liebel <oliver@itc.li>

Andrew Bartlett

12 years agos4:install Remove provision-backend script from 'make install'
Andrew Bartlett [Sun, 16 Aug 2009 23:46:47 +0000 (09:46 +1000)]
s4:install Remove provision-backend script from 'make install'

Spotted by MICHAEL BROWN <mbrown@mesainc.com>

Andrew Bartlett

12 years agos4:provision Make sure that we don't use Kerberos to our LDAP backend
Andrew Bartlett [Fri, 14 Aug 2009 04:51:44 +0000 (14:51 +1000)]
s4:provision Make sure that we don't use Kerberos to our LDAP backend

This makes no sense, and just causes trouble - we are aiming for
DIGEST-MD5 or NTLM.

Andrew Bartlett

12 years agos4:provison Print the LDAP backend admin username/password
Andrew Bartlett [Fri, 14 Aug 2009 00:28:56 +0000 (10:28 +1000)]
s4:provison Print the LDAP backend admin username/password

12 years agos4:selftest Confirm that there isn't a listener on the ldapi:// socket
Andrew Bartlett [Fri, 14 Aug 2009 00:21:04 +0000 (10:21 +1000)]
s4:selftest Confirm that there isn't a listener on the ldapi:// socket

This should help debug problems with 'make test' of the LDAP backend,
if a stray listener is still around.

Andrew Bartlett

12 years agos4: Re-add --ldapadminpass as an option to provision
Andrew Bartlett [Thu, 13 Aug 2009 23:37:50 +0000 (09:37 +1000)]
s4: Re-add --ldapadminpass as an option to provision

This should make setting up LDAP servers more predictable.

When not specified, it is random

Andrew Bartlett

12 years agos4:python Allow 'no such object' on the delete of the DN
Andrew Bartlett [Thu, 13 Aug 2009 22:46:13 +0000 (08:46 +1000)]
s4:python Allow 'no such object' on the delete of the DN

This fixes the recursive delete in erase_partitions()

For reasons I cannot understand, it is possible to get 'no such
object' trying to delete a DN I just search for without error.  Oh
well...

Andrew Bartlett

12 years agos4:provision Keep a single transaction for the erase and rebuild
Andrew Bartlett [Thu, 13 Aug 2009 22:29:19 +0000 (08:29 +1000)]
s4:provision Keep a single transaction for the erase and rebuild

Using a single transaction to both erase the bulk of the data and the
rebuild of that data means that the in-memory index list is
maintained, and not written out to disk until it is all compleated.
All the writes then occour at the end.

Andrew Bartlett

12 years agos4:provision A crude update of the OpenLDAP backend HOWTO
Andrew Bartlett [Thu, 13 Aug 2009 09:24:38 +0000 (19:24 +1000)]
s4:provision A crude update of the OpenLDAP backend HOWTO

12 years agos4:provision Fixes for Fedora DS schema mapping with full AD schema
Endi Sukma Dewata [Thu, 13 Aug 2009 09:12:28 +0000 (19:12 +1000)]
s4:provision Fixes for Fedora DS schema mapping with full AD schema

12 years agos4:provision Rework provision-backend into provision
Andrew Bartlett [Thu, 13 Aug 2009 07:01:27 +0000 (17:01 +1000)]
s4:provision Rework provision-backend into provision

This removes a *lot* of duplicated code and the cause of much
administrator frustration.  We now handle starting and stopping the
slapd (at least for the provision), and ensure that there is only one
'right' way to configure the OpenLDAP and Fedora DS backend

We now run OpenLDAP in 'cn=config' mode for online configuration.

To test what was the provision-backend code, a new --ldap-dryrun-mode
option has been added to provision.  It quits the provision just
before it would start the LDAP binaries

Andrew Bartlett

12 years agos4:provision Move helper functions back to provision
Andrew Bartlett [Thu, 13 Aug 2009 06:59:49 +0000 (16:59 +1000)]
s4:provision Move helper functions back to provision

(These will be added back in a future commit)

12 years agos4:setup Don't manually set @ATTRIBUTES any more
Andrew Bartlett [Thu, 13 Aug 2009 06:32:34 +0000 (16:32 +1000)]
s4:setup Don't manually set @ATTRIBUTES any more

We now set these as part of the schema load, and we now load the
schema before the provision loads the DB, so setting them here is
pointless

Andrew Bartlett

12 years agos4:python Push some helper functions from SamDB into samba.Ldb
Andrew Bartlett [Thu, 13 Aug 2009 04:37:06 +0000 (14:37 +1000)]
s4:python Push some helper functions from SamDB into samba.Ldb

This makes it possible to do a bit more of the provision with Samba
helpers, but without some of the otherwise useful things (such as
loading in the global schema) that SamDB does.

Rewrite provision_erase to use a recursive search, rather than a
looping subtree search.  This is much more efficient, particularly now
we have one-level indexes enabled.

Delete the @INDEX and similar records *after* deleting all other
visible records, this hopefully also assists performance.

Andrew Bartlett

12 years agos4:schema Allow a schema load on an unconnected database
Andrew Bartlett [Thu, 13 Aug 2009 04:33:57 +0000 (14:33 +1000)]
s4:schema Allow a schema load on an unconnected database

This helps ensure we don't load the schema too often in the provision
(allowing a reference in of the schema before the modules load).

Andrew Bartlett

12 years agos4:provision Remove the ACI element from the provision templates
Andrew Bartlett [Thu, 13 Aug 2009 00:01:00 +0000 (10:01 +1000)]
s4:provision  Remove the ACI element from the provision templates

We need to find a better way to apply this (used in the Fedora DS LDAP
backend), not by trying to tunnel this down the module stack.

Andrew Bartlett

12 years agos4:schema Provide a way to reference a loaded schema between ldbs
Andrew Bartlett [Wed, 12 Aug 2009 23:58:38 +0000 (09:58 +1000)]
s4:schema Provide a way to reference a loaded schema between ldbs

This allows us to load the schema against one ldb context, but apply
it to another.  This will be useful in the provision script, as we
need the schema before we start the LDAP server backend.

Adnrew Bartlett

12 years agos3:winbind: The get[gr|pw]end functions need access to the client state
Volker Lendecke [Sun, 16 Aug 2009 10:46:55 +0000 (12:46 +0200)]
s3:winbind: The get[gr|pw]end functions need access to the client state

12 years agos3:winbind: Convert WINBINDD_GETGRNAM to the new API
Volker Lendecke [Sun, 16 Aug 2009 10:23:31 +0000 (12:23 +0200)]
s3:winbind: Convert WINBINDD_GETGRNAM to the new API

12 years agos3:winbind: Convert WINBINDD_GETGRGID to the new API
Volker Lendecke [Sun, 16 Aug 2009 10:13:00 +0000 (12:13 +0200)]
s3:winbind: Convert WINBINDD_GETGRGID to the new API

12 years agos3:winbind: Add winbindd_print_groupmem
Volker Lendecke [Sun, 16 Aug 2009 10:09:37 +0000 (12:09 +0200)]
s3:winbind: Add winbindd_print_groupmem

This converts a talloc_dict retrieved from wb_group_members to the string
that the pipe protocol expects

12 years agos3:winbind: Make fill_grent publically available
Volker Lendecke [Sun, 16 Aug 2009 10:08:52 +0000 (12:08 +0200)]
s3:winbind: Make fill_grent publically available