ira/wip.git
10 years agos4:upgrade_from_s3 - Move it back to "setup"
Matthias Dieter Wallnöfer [Sat, 28 Nov 2009 18:23:08 +0000 (19:23 +0100)]
s4:upgrade_from_s3 - Move it back to "setup"

Suggested by Jelmer

10 years agos4:setup/provision - Rework
Matthias Dieter Wallnöfer [Sat, 28 Nov 2009 16:03:57 +0000 (17:03 +0100)]
s4:setup/provision - Rework

- Revert change in "ask" - was previously correct
- Readd accidentally removed checks for non-null realm and domainname
- On interactive mode perform only one "ask" call per question
- Inform the user about the unset administrator password

10 years agos4:upgrade.py - remove my copyright
Matthias Dieter Wallnöfer [Sat, 28 Nov 2009 17:48:47 +0000 (18:48 +0100)]
s4:upgrade.py - remove my copyright

First I wanted to add also other changes but then I didn't introduce them.
Therefore remove my copyright again.

10 years agos4:upgrade.py - readd accidentally removed empty lines
Matthias Dieter Wallnöfer [Sat, 28 Nov 2009 15:59:18 +0000 (16:59 +0100)]
s4:upgrade.py - readd accidentally removed empty lines

Jelmer pointed out that this is against the PEP8 norm

10 years agos4:samba3.py/upgrade.py: Revert
Matthias Dieter Wallnöfer [Sat, 28 Nov 2009 14:28:45 +0000 (15:28 +0100)]
s4:samba3.py/upgrade.py: Revert

This reverts commit 2175c0ed0649d545ea833d50e8d33fbee9051c35.
This reverts commit 6c3e2417a0639cd7c367de93615c422cf5217456.
This reverts commit dbb8989e05ac3189a5eca11fa40d572388ea02fc.
This reverts commit 82adfa39b75aa628c88f828278c6ac09335d1a49.
This reverts commit f299efa8f05c6a5b739222bdf75690a4591d3650.

After a small discussion with Jelmer we agreed that this isn't the right way
to fix the problem. We should wait for a real patch rather to rely on temporal
hacks.

10 years agos4-ldb: make it much easier to use common ldb controls
Andrew Tridgell [Sat, 28 Nov 2009 06:35:36 +0000 (17:35 +1100)]
s4-ldb: make it much easier to use common ldb controls

10 years agos4-drs: cope with bogus empty attributes from w2k8-r2
Andrew Tridgell [Sat, 28 Nov 2009 02:27:06 +0000 (13:27 +1100)]
s4-drs: cope with bogus empty attributes from w2k8-r2

w2k8-r2 sometimes sends empty attributes with completely bogus attrid
values in a DRS replication response. This allows us to continue with
the vampire operation despite these broken elements.

10 years agos4: fix SD update and password change in upgrade script
Matthieu Patou [Fri, 27 Nov 2009 14:37:14 +0000 (17:37 +0300)]
s4: fix SD update and password change in upgrade script

- reserve a new Samba OID for recalculate SD control
- fix the update SD function
- fix handling of kvno in the update_machine_account_password function
- fix handling of handles in RPC winreg server

Signed-off-by: Andrew Tridgell <tridge@samba.org>
10 years agos4:WINREG RPC server - add another "talloc_unlink" in "DeleteKey"
Matthias Dieter Wallnöfer [Wed, 18 Nov 2009 07:48:30 +0000 (08:48 +0100)]
s4:WINREG RPC server - add another "talloc_unlink" in "DeleteKey"

Also here we waste memory - therefore free the pointless handle after the delete.

10 years agos4:WINREG RPC server - Reintroduce the free operation on "CloseKey"
Matthias Dieter Wallnöfer [Wed, 18 Nov 2009 09:24:09 +0000 (10:24 +0100)]
s4:WINREG RPC server - Reintroduce the free operation on "CloseKey"

Better use "talloc_unlink" here Since we could have more than one reference.

10 years agos4-smbtorture: more and stricter tests for printer and data keys in RPC-SPOOLSS.
Günther Deschner [Fri, 27 Nov 2009 22:14:27 +0000 (23:14 +0100)]
s4-smbtorture: more and stricter tests for printer and data keys in RPC-SPOOLSS.

Guenther

10 years agos4:provision.py - remove hardcoded SIDs and RIDs
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 21:39:52 +0000 (22:39 +0100)]
s4:provision.py - remove hardcoded SIDs and RIDs

After rework of the SDDL modules this is possible. In future: Never hardcode
them anymore! Always use the abbreviations.

10 years agos4:security/sddl - rework of the security descriptor abbreviations
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 21:37:52 +0000 (22:37 +0100)]
s4:security/sddl - rework of the security descriptor abbreviations

- Reoder them
- Add some new ones (needed for the security descriptor in the provision script)

10 years agosecurity.idl - Add some more wellknown SIDs/RIDs
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 21:36:59 +0000 (22:36 +0100)]
security.idl - Add some more wellknown SIDs/RIDs

10 years agos4:registry/util - Don't include the trailing '\0' in the internal data format but...
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 20:14:44 +0000 (21:14 +0100)]
s4:registry/util - Don't include the trailing '\0' in the internal data format but add it on the back-conversion to a string

As far as I know the registry library saves all data (including) strings without
the null termination. So do it also here in a similar way.

10 years agos4:net utility - add a notice for the "help" operation and format it's output of...
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 19:26:17 +0000 (20:26 +0100)]
s4:net utility - add a notice for the "help" operation and format it's output of the command list better

10 years agos3-kerberos: fix the build on Mac OS X 10.6.2.
Günther Deschner [Fri, 27 Nov 2009 19:08:44 +0000 (20:08 +0100)]
s3-kerberos: fix the build on Mac OS X 10.6.2.

Guenther

10 years agos4:samba3.py - deactivate also the assertion on line 599
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 19:02:25 +0000 (20:02 +0100)]
s4:samba3.py - deactivate also the assertion on line 599

10 years agos3-kerberos: add a missing reference to authdata headers.
Günther Deschner [Fri, 27 Nov 2009 17:51:56 +0000 (18:51 +0100)]
s3-kerberos: add a missing reference to authdata headers.

Guenther

10 years agos3-kerberos: do not include authdata headers before including krb5 headers.
Günther Deschner [Fri, 27 Nov 2009 17:30:18 +0000 (18:30 +0100)]
s3-kerberos: do not include authdata headers before including krb5 headers.

Guenther

10 years agos3-spoolss: simplify _spoolss_EnumPrinterKey a little more.
Günther Deschner [Thu, 26 Nov 2009 18:01:54 +0000 (19:01 +0100)]
s3-spoolss: simplify _spoolss_EnumPrinterKey a little more.

Guenther

10 years agos4:winbind - Fix it another time up
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 16:45:20 +0000 (17:45 +0100)]
s4:winbind - Fix it another time up

The first fix attempt did break some configurations (incl. "make test").
This now is the right fix with the right comment.

10 years agos4:provision.py - cosmetic
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 16:39:02 +0000 (17:39 +0100)]
s4:provision.py - cosmetic

10 years agos4:samba3.py (and test) - deactivate the tests until those parameters are fixed
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 15:39:27 +0000 (16:39 +0100)]
s4:samba3.py (and test) - deactivate the tests until those parameters are fixed

10 years agos4:upgrade.py - Umlaut problem
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 15:35:28 +0000 (16:35 +0100)]
s4:upgrade.py - Umlaut problem

10 years agos4:tests.sh - Make also here the change from "upgrade" to "upgrade_from_s3"
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 15:34:44 +0000 (16:34 +0100)]
s4:tests.sh - Make also here the change from "upgrade" to "upgrade_from_s3"

10 years agos3-kerberos: only use krb5 headers where required.
Günther Deschner [Fri, 27 Nov 2009 14:52:57 +0000 (15:52 +0100)]
s3-kerberos: only use krb5 headers where required.

This seems to be the only way to deal with mixed heimdal/MIT setups during
merged build.

Guenther

10 years agomisc: mark winreg_Data little-endian except for a REG_DWORD_BIG_ENDIAN.
Günther Deschner [Fri, 27 Nov 2009 10:18:30 +0000 (11:18 +0100)]
misc: mark winreg_Data little-endian except for a REG_DWORD_BIG_ENDIAN.

Guenther

10 years agopidl: fix handling of output arguments in s3 client stubs.
Günther Deschner [Fri, 27 Nov 2009 15:06:40 +0000 (16:06 +0100)]
pidl: fix handling of output arguments in s3 client stubs.

a20e095 used (uint8_t) instead of (uint8_t *).

Guenther

10 years agos4:upgrade.py - rework to make the upgrade s3 -> s4 possible again
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 14:50:26 +0000 (15:50 +0100)]
s4:upgrade.py - rework to make the upgrade s3 -> s4 possible again

Able to read basic settings "workgroup", "realm", "netbios name" and the
function mode from the s3 "smb.conf" and use them for the provision of s4.

10 years agos4:upgrade_from_s3 - Fix message outputs
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 14:49:18 +0000 (15:49 +0100)]
s4:upgrade_from_s3 - Fix message outputs

The quiet parameter was interpreted in the reverse manner.

10 years agos4:upgrade.py - the import of WINS databases don't seem to work always
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 14:02:18 +0000 (15:02 +0100)]
s4:upgrade.py - the import of WINS databases don't seem to work always

Disable it for now until the cause has been found

10 years agos4:samba3.py - ignore comments in "smb.conf" files
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 14:00:41 +0000 (15:00 +0100)]
s4:samba3.py - ignore comments in "smb.conf" files

10 years agos4:samba3.py - don't read those informations out from the TDB
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 13:59:12 +0000 (14:59 +0100)]
s4:samba3.py - don't read those informations out from the TDB

At the moment those three calls are broken

10 years agos4:samba3.py - support the TDB version 3
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 13:58:37 +0000 (14:58 +0100)]
s4:samba3.py - support the TDB version 3

10 years agos4:provision - Fix up the provision of "standalone" and "member" mode
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 13:48:58 +0000 (14:48 +0100)]
s4:provision - Fix up the provision of "standalone" and "member" mode

Both modes weren't possible anymore since 1.) the secrets entry wasn't created,
2.) a lookup in winbindd was done using "lp_workgroup()" rather than
"lp_sam_name()" (since on the mentioned two configurations we use the netbios
name as domainname - and not the workgroup).

10 years agos4:provision.py - cosmetic output correction
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 12:07:52 +0000 (13:07 +0100)]
s4:provision.py - cosmetic output correction

10 years agos4:setup/provision - make the interactive mode work again
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 12:02:31 +0000 (13:02 +0100)]
s4:setup/provision - make the interactive mode work again

10 years agos4:WHATSNEW4.txt - Add also here a comment about the "upgrade_from_s3" script
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 10:07:11 +0000 (11:07 +0100)]
s4:WHATSNEW4.txt - Add also here a comment about the "upgrade_from_s3" script

10 years agos4:howto.txt - add a notice about the upgrade possibilities and fix line spaces
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 10:02:20 +0000 (11:02 +0100)]
s4:howto.txt - add a notice about the upgrade possibilities and fix line spaces

10 years agos4:upgrade script - rename it to "upgrade_from_s3" and do some rework
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 09:50:03 +0000 (10:50 +0100)]
s4:upgrade script - rename it to "upgrade_from_s3" and do some rework

- Give a better name to the script
- Move it to the location where also "upgradeprovision" resides
- Fix up trailing whitespaces and tabs

10 years agos3-nsstest: drastically shrink size and dependencies of nsstest binary.
Günther Deschner [Thu, 25 Jun 2009 16:18:50 +0000 (18:18 +0200)]
s3-nsstest: drastically shrink size and dependencies of nsstest binary.

The size went down from 6.4M to 104K on my box.

Guenther

10 years agos4-install: old systems don't have sed -i
Andrew Tridgell [Fri, 27 Nov 2009 08:58:00 +0000 (19:58 +1100)]
s4-install: old systems don't have sed -i

surprisingly, this failure came from SLES8. I didn't realise that the
-i option was so new!

10 years agos4-selftest: s4 passes all the SMB2-LOCK tests now
Andrew Tridgell [Fri, 27 Nov 2009 08:11:28 +0000 (19:11 +1100)]
s4-selftest: s4 passes all the SMB2-LOCK tests now

10 years agos4-torture: fixed error code for s4 in SMB2-LOCK test
Andrew Tridgell [Fri, 27 Nov 2009 08:10:50 +0000 (19:10 +1100)]
s4-torture: fixed error code for s4 in SMB2-LOCK test

s4 returns NETWORK_NAME_DELETED if you attempt to use an invalid tree connection
for a lock. This test (correctly I think) happens before we validate the file handle.
That implies that when you pass both a closed handle and a invalid tree you
should get NT_STATUS_NETWORK_NAME_DELETED.

10 years agos4-ntvfs: win7 does not check for the NONE smb2 lock flag on unlock
Andrew Tridgell [Fri, 27 Nov 2009 08:09:10 +0000 (19:09 +1100)]
s4-ntvfs: win7 does not check for the NONE smb2 lock flag on unlock

10 years agos4-selftest: s4 passes this test now
Andrew Tridgell [Fri, 27 Nov 2009 07:10:01 +0000 (18:10 +1100)]
s4-selftest: s4 passes this test now

10 years agos4-torture: mark s4 as doing valid lock range tests on SMB
Andrew Tridgell [Fri, 27 Nov 2009 07:09:50 +0000 (18:09 +1100)]
s4-torture: mark s4 as doing valid lock range tests on SMB

10 years agos4-ntvfs: move valid lock range test from smb2 layer to generic code
Andrew Tridgell [Fri, 27 Nov 2009 07:08:51 +0000 (18:08 +1100)]
s4-ntvfs: move valid lock range test from smb2 layer to generic code

win7 also fails invalid lock ranges on SMB

10 years agos4:smb_server/smb2: don't reset highest_smb2_seqnum on SMB2 Cancel
Stefan Metzmacher [Thu, 26 Nov 2009 13:18:50 +0000 (14:18 +0100)]
s4:smb_server/smb2: don't reset highest_smb2_seqnum on SMB2 Cancel

metze

10 years agos4-torture: fixed expected error codes for s4 in SMB2-LOCK
Andrew Tridgell [Fri, 27 Nov 2009 03:54:22 +0000 (14:54 +1100)]
s4-torture: fixed expected error codes for s4 in SMB2-LOCK

I think the error/success codes returned by windows for these tests
are quite bogus. The ones s4 gives are much more reasonable. The
locking ones returning NT_STATUS_SUCCESS could lead to data loss, as
an application thinks it has a file locked correctly when it fact it
doesn't, so it could do an unsafe modify.

10 years agos4-drstest: don't use getenv("LDB_URL") in test suites
Andrew Tridgell [Fri, 27 Nov 2009 03:42:05 +0000 (14:42 +1100)]
s4-drstest: don't use getenv("LDB_URL") in test suites

I was stumped for a while as to why the drs test suite was failing for
me. It turned out that it looked for LDB_URL in the environment, and
used it if set. I had it set in my terminal, and it was happily
munching on my sam.ldb while testing. Quite a cute bug really :-)

10 years agos4-pvfs: fixed access check failure in SFILEINFO test
Andrew Tridgell [Fri, 27 Nov 2009 03:22:29 +0000 (14:22 +1100)]
s4-pvfs: fixed access check failure in SFILEINFO test

matching windows behaviour is not always the right thing to do!

10 years agos4-ldb: improve detection of whether the server has a GC port
Andrew Tridgell [Fri, 27 Nov 2009 03:20:47 +0000 (14:20 +1100)]
s4-ldb: improve detection of whether the server has a GC port

We were trying to open $SERVER:3268 regardless, which could result in
creating a file called "localdc1:3268", which led to subsequent test
failures

10 years agos4-ldb: better to test for valid arguments in ldb library than commandline
Andrew Tridgell [Fri, 27 Nov 2009 03:18:39 +0000 (14:18 +1100)]
s4-ldb: better to test for valid arguments in ldb library than commandline

We were testing for valid DNs in ldbrename in the command line
tool. This hid a bug in the ldb library where we caught a bad DN in
the objectclass module rather than in the main ldb code. It is better
to do validation of the DNs passed on the command line in the library
code, as this gives us more consistent error handling between the
programming APIs for ldb and the command line.

10 years agos4-smb2: SMB2 uses NT_STATUS_CANCELLED for cancelled locks
Andrew Tridgell [Thu, 26 Nov 2009 06:38:50 +0000 (17:38 +1100)]
s4-smb2: SMB2 uses NT_STATUS_CANCELLED for cancelled locks

10 years agos4-smb2: sequence numbers are not checked in SMB2_OP_CANCEL
Andrew Tridgell [Thu, 26 Nov 2009 06:38:11 +0000 (17:38 +1100)]
s4-smb2: sequence numbers are not checked in SMB2_OP_CANCEL

10 years agotorture: fixed SMB2-LOCK valgrind error
Andrew Tridgell [Thu, 26 Nov 2009 06:03:20 +0000 (17:03 +1100)]
torture: fixed SMB2-LOCK valgrind error

10 years agos4-smb2: check for invalid SMB2 lock ranges
Andrew Tridgell [Thu, 26 Nov 2009 05:53:51 +0000 (16:53 +1100)]
s4-smb2: check for invalid SMB2 lock ranges

10 years agos4-smb2: check for an invalid lock flags combination
Andrew Tridgell [Thu, 26 Nov 2009 05:35:03 +0000 (16:35 +1100)]
s4-smb2: check for an invalid lock flags combination

UNLOCK with FAIL_IMMEDIATELY is not allowed

10 years agos4-install: fixed install path for python scripts
Andrew Tridgell [Thu, 26 Nov 2009 02:06:01 +0000 (13:06 +1100)]
s4-install: fixed install path for python scripts

when we install python scripts we need to fix the internal path used
to find modules. We also need to install the scripts in the right
place. Most of them should go in $SBINDIR not share/setup/

10 years agos4:upgradeprovision Rework update_machine_account_password() tranactions
Andrew Bartlett [Thu, 26 Nov 2009 21:10:54 +0000 (08:10 +1100)]
s4:upgradeprovision Rework update_machine_account_password() tranactions

This balances the transaction_begin() and transactin_prepare_commit() calls

Andrew Bartlett

10 years agos4:dsdb Don't segfault with ldb_transaction_prepare_commit() without begin()
Andrew Bartlett [Thu, 26 Nov 2009 21:05:59 +0000 (08:05 +1100)]
s4:dsdb Don't segfault with ldb_transaction_prepare_commit() without begin()

It is up to other modules to complain if
ldb_transaction_prepare_commit() is called before
ldb_transaction_begin_transaction()

Andrew Bartlett

10 years agos4:upgradeprovision add 'exit $failed' to blackbox test
Andrew Bartlett [Thu, 26 Nov 2009 11:01:54 +0000 (22:01 +1100)]
s4:upgradeprovision add 'exit $failed' to blackbox test

10 years agos4:upgradeprovision Use mkdtemp to create unique tempoary directory names
Andrew Bartlett [Thu, 26 Nov 2009 10:52:40 +0000 (21:52 +1100)]
s4:upgradeprovision Use mkdtemp to create unique tempoary directory names

10 years agos4:selftest Add tests for upgradeprovision
Andrew Bartlett [Thu, 26 Nov 2009 04:34:53 +0000 (15:34 +1100)]
s4:selftest Add tests for upgradeprovision

10 years agos4:upgradeprovision Rework script, and reset machine account pw
Andrew Bartlett [Thu, 26 Nov 2009 04:32:49 +0000 (15:32 +1100)]
s4:upgradeprovision Rework script, and reset machine account pw

The rework corrects some duplication and errors in the original
script, found when preparing an automated test of the script.

The code to reset the machine account password avoids issues with AES
keys and salting, which may not otherwise be solved by the upgrade.

Andrew Bartlett

10 years agos4:ldb Provide bindings for ldb_transaction_prepare_commit()
Andrew Bartlett [Thu, 26 Nov 2009 04:32:06 +0000 (15:32 +1100)]
s4:ldb Provide bindings for ldb_transaction_prepare_commit()

10 years agos4:provision Make setting the domain SID in the self join optional
Andrew Bartlett [Thu, 26 Nov 2009 03:57:39 +0000 (14:57 +1100)]
s4:provision Make setting the domain SID in the self join optional

10 years agoFix path to upgradeprovision
Andrew Bartlett [Thu, 26 Nov 2009 01:15:22 +0000 (12:15 +1100)]
Fix path to upgradeprovision

10 years agos4: Improve updateprovision
Matthieu Patou [Wed, 25 Nov 2009 13:26:35 +0000 (16:26 +0300)]
s4: Improve updateprovision

* Define a simple upgrade process mode (module storage change, file name change, copy of new file)
  * Move the schema, configuration and current object upgrade into full upgrade mode
  * Added the --full switch to select the full upgrade mode, and made simple upgrade mode the default
  * Make updateprovision works without any switch (update the provision in the default location)
  * Cleanup the messages
  * Create the reference provision in a subdirectory of the updated provision

10 years agos4: update What's new and explain how to upgrade a samba4 provision
Matthieu Patou [Wed, 25 Nov 2009 14:10:52 +0000 (17:10 +0300)]
s4: update What's new and explain how to upgrade a samba4 provision

10 years agos4: Rename the script
Matthieu Patou [Wed, 25 Nov 2009 08:42:16 +0000 (11:42 +0300)]
s4: Rename the script

10 years agos3-kerberos: Fix Bug #6929: build with recent heimdal.
Günther Deschner [Fri, 27 Nov 2009 00:06:36 +0000 (01:06 +0100)]
s3-kerberos: Fix Bug #6929: build with recent heimdal.

Heimdal changed the KRB5_DEPRECATED define (which now may not take an identifier
for activation) in new releases (like 1.3.1).

Guenther

10 years agos3-spoolss: use macros to fillup driver levels.
Günther Deschner [Thu, 26 Nov 2009 22:46:50 +0000 (23:46 +0100)]
s3-spoolss: use macros to fillup driver levels.

Guenther

10 years agos3-smbd: no drsuapi server stubs yet in s3. Fixes the build, sorry.
Günther Deschner [Thu, 26 Nov 2009 19:26:01 +0000 (20:26 +0100)]
s3-smbd: no drsuapi server stubs yet in s3. Fixes the build, sorry.

Guenther

10 years agos3-rpc: running minimal_includes.pl on rpc_client and rpc_server.
Günther Deschner [Thu, 26 Nov 2009 19:17:07 +0000 (20:17 +0100)]
s3-rpc: running minimal_includes.pl on rpc_client and rpc_server.

Guenther

10 years agos3-rpc: Avoid including every pipe's client and server stubs everywhere in samba.
Günther Deschner [Thu, 26 Nov 2009 17:21:28 +0000 (18:21 +0100)]
s3-rpc: Avoid including every pipe's client and server stubs everywhere in samba.

Guenther

10 years agos3-passdb: move some defines out of rpc headers (they really belong to passdb).
Günther Deschner [Thu, 26 Nov 2009 17:15:39 +0000 (18:15 +0100)]
s3-passdb: move some defines out of rpc headers (they really belong to passdb).

Guenther

10 years agos3-winbind: properly include netlogon.idl in wbint.idl.
Günther Deschner [Thu, 26 Nov 2009 17:58:36 +0000 (18:58 +0100)]
s3-winbind: properly include netlogon.idl in wbint.idl.

Guenther

10 years agos3-spoolss: pre cosmetics: reorder levels in construct_printer_info levels.
Günther Deschner [Thu, 26 Nov 2009 17:57:24 +0000 (18:57 +0100)]
s3-spoolss: pre cosmetics: reorder levels in construct_printer_info levels.

Guenther

10 years agotevent: Fix a comment
Volker Lendecke [Thu, 26 Nov 2009 16:18:00 +0000 (17:18 +0100)]
tevent: Fix a comment

10 years agolibrpc: rerun "make idl"
Stefan Metzmacher [Wed, 25 Nov 2009 13:42:24 +0000 (14:42 +0100)]
librpc: rerun "make idl"

metze

10 years agopidl:Samba3/ClientNDR: $size can be 'foo / 2' so we need to add '(' and ')'
Stefan Metzmacher [Wed, 25 Nov 2009 13:31:34 +0000 (14:31 +0100)]
pidl:Samba3/ClientNDR: $size can be 'foo / 2' so we need to add '(' and ')'

foo / 5 * sizeof(bar)' isn't the same as
'(foo / 2) * sizeof(bar)'.

metze

10 years agopidl:NDR/Parser: $size can be 'foo / 2' so we need to add '(' and ')'
Stefan Metzmacher [Wed, 25 Nov 2009 13:21:32 +0000 (14:21 +0100)]
pidl:NDR/Parser: $size can be 'foo / 2' so we need to add '(' and ')'

foo / 5 * sizeof(bar)' isn't the same as
'(foo / 2) * sizeof(bar)'.

metze

10 years agocreate-tarball: Make it more comfortable to use the --copy-docs option.
Karolin Seeger [Thu, 26 Nov 2009 10:18:39 +0000 (11:18 +0100)]
create-tarball: Make it more comfortable to use the --copy-docs option.

Now you can directly specify the 'make release' output dir without any
modifications.

Karolin

10 years agos4:ldap.py - add a test for the enhanced operational attributes check
Matthias Dieter Wallnöfer [Thu, 26 Nov 2009 08:51:56 +0000 (09:51 +0100)]
s4:ldap.py - add a test for the enhanced operational attributes check

(Deny creation of entries with operational attributes specified)

10 years agos4:objectclass LDB module - Prevent write operations on constructed attributes
Matthias Dieter Wallnöfer [Thu, 26 Nov 2009 09:54:20 +0000 (10:54 +0100)]
s4:objectclass LDB module - Prevent write operations on constructed attributes

10 years agos4:operational LDB module - Don't do the write checks here
Matthias Dieter Wallnöfer [Thu, 26 Nov 2009 09:21:44 +0000 (10:21 +0100)]
s4:operational LDB module - Don't do the write checks here

Let this perform the schema in the "objectclass" module.

10 years agos3-kerberos: next step to resolve Bug #6929: build with recent heimdal.
Günther Deschner [Thu, 26 Nov 2009 09:15:45 +0000 (10:15 +0100)]
s3-kerberos: next step to resolve Bug #6929: build with recent heimdal.

Based on patch from Allan <allan@archlinux.org>.

Also should fix the FreeBSD build on the buildfarm.

Guenther

10 years agos4-smbtorture: refactor RPC-SAMR-LARGE-DC test a little more.
Günther Deschner [Thu, 26 Nov 2009 00:25:56 +0000 (01:25 +0100)]
s4-smbtorture: refactor RPC-SAMR-LARGE-DC test a little more.

Guenther

10 years agos4-smbtorture: add torture_samr_context to carry some RPC-SAMR-X specifics.
Günther Deschner [Wed, 25 Nov 2009 23:32:47 +0000 (00:32 +0100)]
s4-smbtorture: add torture_samr_context to carry some RPC-SAMR-X specifics.

Guenther

10 years agoFix warnings with talloc_asprintf.
Jeremy Allison [Wed, 25 Nov 2009 22:47:36 +0000 (14:47 -0800)]
Fix warnings with talloc_asprintf.
Jeremy.

10 years agoMake us pass RAW-CHKPATH with a case sensitive share.
Jeremy Allison [Wed, 25 Nov 2009 21:17:56 +0000 (13:17 -0800)]
Make us pass RAW-CHKPATH with a case sensitive share.
I know Volker will look at this closely so here's the explaination :-).
Originally on a case-sensitive share we simply did a stat (or lstat)
call and returned success of fail based on the result. However this
failed to take account of incoming paths with a wildcard (which must
always fail, and with different error messages depending on whether
the wildcard is the last component or in the path). Also it failed
to take account of a stat fail with ENOENT due to a missing component
of the path as the last component (which is ok as it could be a new
file)  or if the ENOENT was due to the missing component within
the path (not the last component) - which must return the correct
error. What this means is that with "case sensitive = yes" we do
one more talloc call (to get the parent directory) and one more
stat call (on the parent directory) in the case where the stat
call fails. I think this is an acceptable overhead to enable
case sensitive shares to return the correct error messages for
applications. Volker please examine carefully :-).
Jeremy.

10 years agoAdd RAW-CHKPATH test with case-sensitive share.
Jeremy Allison [Wed, 25 Nov 2009 21:17:38 +0000 (13:17 -0800)]
Add RAW-CHKPATH test with case-sensitive share.
Jeremy.

10 years agos3-build: try to fix QNX build ("delay" is defined in lib headers).
Günther Deschner [Wed, 25 Nov 2009 21:03:19 +0000 (22:03 +0100)]
s3-build: try to fix QNX build ("delay" is defined in lib headers).

Guenther

10 years agos4/torture: port SMBv1 RAW-LOCK tests to SMBv2
Steven Danneman [Thu, 19 Nov 2009 00:35:03 +0000 (16:35 -0800)]
s4/torture: port SMBv1 RAW-LOCK tests to SMBv2

RAW-LOCK ported as:

RAW-LOCK-LOCK, RAW-LOCK-LOCKX -> SMB2-LOCK-LOCK
RAW-PIDHIGH -> removed, no longer relevant
RAW-ASYNC -> SMB2-LOCK-ASYNC, SMB2-LOCK-CANCEL, SMB2-LOCK-CANCEL-TDIS, SMB2-LOCK-CANCEL-LOGOFF
RAW-ERRORCODE -> SMB2-LOCK-ERRORCODE
RAW-CHANGETYPE -> removed, no longer relevant
RAW-ZEROBYTELOCKS -> SMB2-LOCK->ZEROBYTELENGTH
RAW-UNLOCK -> SMB2-LOCK-UNLOCK
RAW-MULTIPLE_UNLOCK -> SMB2-LOCK-MULTIPLE-UNLOCK
RAW-STACKING -> SMB2-LOCK-STACKING

BASE-LOCK ported as:

BASE-LOCK-LOCK1 -> SMB2-LOCK-ERRORCODE, timeout is no longer relevant
BASE-LOCK-LOCK2 -> SMB2-LOCK-CONTEND, SMB2-LOCK-LOCK, SMB2-LOCK-CONTEXT
BASE-LOCK-LOCK3 -> SMB2-LOCK-RANGE
BASE-LOCK-LOCK4 -> SMB2-LOCK-OVERLAP
BASE-LOCK-LOCK5 -> SMB2-LOCK-STACKING
BASE-LOCK-LOCK6 -> SMB2-LOCK-CANCEL, change_locktype no longer relevant
BASE-LOCK-LOCK7 -> SMB2-LOCK-RW-SHARED, SMB2-LOCK-RW-EXCLUSIVE

10 years agos4/libcli: rename previously reserved field in SMB2 LOCK struct
Steven Danneman [Thu, 19 Nov 2009 01:51:35 +0000 (17:51 -0800)]
s4/libcli: rename previously reserved field in SMB2 LOCK struct

The lock.in.reserved field has been renamed lock_sequence in the
SMB 2.1 dialect.  See MS-SMB 2.2.26.

10 years agos4/libcli: Initialize client PID for SMB2 connections
Steven Danneman [Thu, 19 Nov 2009 00:35:16 +0000 (16:35 -0800)]
s4/libcli: Initialize client PID for SMB2 connections

Set the SMB pid to the Unix pid of the client process.

10 years agos3-registry: fix REG_MULTI_SZ handling in registry_push_value.
Günther Deschner [Wed, 25 Nov 2009 20:34:55 +0000 (21:34 +0100)]
s3-registry: fix REG_MULTI_SZ handling in registry_push_value.

Catched by smbconftort test on the buildfarm.

Guenther