Günther Deschner [Fri, 3 Jul 2009 07:56:28 +0000 (09:56 +0200)]
s4-smbtorture: add RPC-SPOOLSS-PRINTER test.
Guenther
Günther Deschner [Thu, 2 Jul 2009 17:38:12 +0000 (19:38 +0200)]
s4-smbtorture: add some tests to check spoolss_SetPrinter behavior.
Guenther
Günther Deschner [Tue, 14 Jul 2009 12:33:08 +0000 (14:33 +0200)]
s4-smbtorture: restructure test_OpenPrinter_server in RPC-SPOOLSS a bit.
Guenther
Björn Jacke [Tue, 14 Jul 2009 20:23:39 +0000 (22:23 +0200)]
s3: allow setting the TCP_QUICKACK socket option
Volker Lendecke [Tue, 14 Jul 2009 19:28:13 +0000 (21:28 +0200)]
Attempt to fix the build
Volker Lendecke [Tue, 14 Jul 2009 16:34:36 +0000 (18:34 +0200)]
Create a talloc_stackframe for each file in wildcard unlink
There might be *many* files to delete
Volker Lendecke [Tue, 14 Jul 2009 16:34:07 +0000 (18:34 +0200)]
Create a correct talloc hierarchy in make_sec_acl()
Volker Lendecke [Tue, 14 Jul 2009 16:33:01 +0000 (18:33 +0200)]
TALLOC_FREE(sd) in check_open_rights upon an error
Jeremy Allison [Tue, 14 Jul 2009 18:25:45 +0000 (11:25 -0700)]
Revert this commit :
s3: Make smbd aware of permission change of usershare. Since usershare are relatively volatile and
non-previledge users must disconnect from smbd and reconnect to it to make share permission in effect.
For now. This is a feature request and I think we need
to design it a little differently so as not to touch
core change_to_user() code.
Jeremy.
Bo Yang [Wed, 15 Jul 2009 09:03:04 +0000 (17:03 +0800)]
s3: fix build of pdbedit and net_sam. Guenther, please check. Signed-off-by: Bo Yang <boyang@samba.org>
Bo Yang [Wed, 15 Jul 2009 07:37:04 +0000 (15:37 +0800)]
s3: Fix double free in net usershare.
Signed-off-by: Bo Yang <boyang@samba.org>
Bo Yang [Wed, 15 Jul 2009 07:36:02 +0000 (15:36 +0800)]
S3: Small fix to get rid of annoying log message.
Signed-off-by: Bo Yang <boyang@samba.org>
Bo Yang [Wed, 15 Jul 2009 07:34:10 +0000 (15:34 +0800)]
s3: Make smbd aware of permission change of usershare. Since usershare are relatively volatile and non-previledge users must disconnect from smbd and reconnect to it to make share permission in effect.
Björn Jacke [Tue, 14 Jul 2009 15:55:50 +0000 (17:55 +0200)]
s3: make
d9c0d58236 better readble and reduce indentation
Björn Jacke [Tue, 14 Jul 2009 15:40:21 +0000 (17:40 +0200)]
s3: don't make same innetgr check twice
Sumit Bose [Fri, 10 Jul 2009 20:44:27 +0000 (22:44 +0200)]
remove all '\n' from ldb_debug
Günther Deschner [Mon, 13 Jul 2009 21:53:49 +0000 (23:53 +0200)]
s3-account_policy: add pdb_policy_type enum.
Guenther
Günther Deschner [Mon, 13 Jul 2009 21:42:57 +0000 (23:42 +0200)]
s3-account_policy: remove trailing whitespace.
Guenther
Günther Deschner [Mon, 13 Jul 2009 21:38:16 +0000 (23:38 +0200)]
s3: re-run make idl.
Guenther
Günther Deschner [Mon, 13 Jul 2009 20:46:51 +0000 (22:46 +0200)]
samr: add missing samr_ValidationStatus codes.
Guenther
Christian Ambach [Thu, 9 Jul 2009 12:45:23 +0000 (14:45 +0200)]
reject ACLs with DESC_DACL_PROTECTED on GPFS
as GPFS does not support the ACE4_FLAG_NO_PROPAGATE NFSv4 flag (which would be the mapping for the DESC_DACL_PROTECTED flag), the status of this flag is currently silently ignored by Samba. That means that if you deselect the "Allow inheritable permissions..." checkbox in Windows' ACL dialog and then apply the ACL, the flag will be back immediately.
To make sure that automatic migration with e.g. robocopy does not lead to ACLs silently (and unintentionally) changed, this patch adds an explicit check for this flag and if set, it will return NT_STATUS_NOT_SUPPORTED so errors are shown up on the Windows side and the Administrator is aware of the ACLs not being settable like intended
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
Jeremy Allison [Tue, 14 Jul 2009 01:43:10 +0000 (18:43 -0700)]
Make cli_posix_lock/unlock asynchronous.
Jeremy.
Jeremy Allison [Tue, 14 Jul 2009 00:17:37 +0000 (17:17 -0700)]
Fix set_posix_lock check which had been reversed in the recent
changes.
Jeremy.
Günther Deschner [Mon, 13 Jul 2009 19:56:31 +0000 (21:56 +0200)]
s3-pdb_ads: set correct pdb field with the value from 'accountExpires' attribute.
Guenther
Stefan Metzmacher [Mon, 13 Jul 2009 11:24:19 +0000 (13:24 +0200)]
s3:net: Fix Bug #6222. Default to DRSUAPI replication for net rpc vampire keytab
metze
Signed-off-by: Günther Deschner <gd@samba.org>
Günther Deschner [Mon, 29 Jun 2009 18:34:03 +0000 (20:34 +0200)]
s3-rpc_server: pass down full unix token to map_max_allowed_access().
Also use unix_token->uid instead of geteuid() when checking for mapping of the
SEC_FLAG_MAXIMUM_ALLOWED flag.
Guenther
Günther Deschner [Fri, 12 Jun 2009 13:20:48 +0000 (15:20 +0200)]
libds: merge the UF<->ACB flag mapping functions.
Guenther
Günther Deschner [Fri, 12 Jun 2009 12:27:19 +0000 (14:27 +0200)]
libds: share UF_ flags between samba3 and 4.
Guenther
Stefan Metzmacher [Mon, 13 Jul 2009 11:14:39 +0000 (13:14 +0200)]
s3:smbd: close_file() handles named pipes just fine, no reason to return NOT_SUPPORTED
metze
Stefan Metzmacher [Mon, 13 Jul 2009 10:05:34 +0000 (12:05 +0200)]
s3:smbd: make smbd_do_qfsinfo() non static for use in SMB2 GetInfo
metze
Stefan Metzmacher [Mon, 13 Jul 2009 09:54:20 +0000 (11:54 +0200)]
s3:smbd: split out smbd_do_qfsinfo() from call_trans2qfsinfo()
metze
Stefan Metzmacher [Mon, 13 Jul 2009 07:01:56 +0000 (09:01 +0200)]
s3:smbd: make smbd_do_setfilepathinfo() non static for use in SMB2 SetInfo
metze
Stefan Metzmacher [Mon, 13 Jul 2009 06:59:32 +0000 (08:59 +0200)]
s3:smbd: split out smbd_do_setfilepathinfo() from call_trans2setfilepathinfo()
metze
Stefan Metzmacher [Fri, 10 Jul 2009 18:39:08 +0000 (20:39 +0200)]
s3:smbd: start SMB2 GetInfo support for File*Information levels
TODO: the EA levels are not fully supported.
metze
Stefan Metzmacher [Sun, 12 Jul 2009 14:40:58 +0000 (16:40 +0200)]
s3:smbd: add support for marshalling SMB2 FileFullEaInformation
metze
Stefan Metzmacher [Sun, 12 Jul 2009 15:08:18 +0000 (17:08 +0200)]
s3:smbd: add support for marshalling SMB2 FileAllInformation
metze
Stefan Metzmacher [Sun, 12 Jul 2009 15:06:05 +0000 (17:06 +0200)]
s3:smbd: filter out SMB2 specific private query info levels for SMB1
metze
Stefan Metzmacher [Fri, 10 Jul 2009 18:02:44 +0000 (20:02 +0200)]
s3:smbd: make smbd_do_qfilepathinfo() non static for use in SMB2
metze
Stefan Metzmacher [Sun, 12 Jul 2009 14:37:49 +0000 (16:37 +0200)]
s3:smbd: split calculation and mashalling of file index and access_mask
metze
Stefan Metzmacher [Fri, 10 Jul 2009 17:04:58 +0000 (19:04 +0200)]
s3:smbd: split out smbd_do_qfilepathinfo() from call_trans2qfilepathinfo()
This prepares SMB2 GetInfo.
metze
Stefan Metzmacher [Fri, 10 Jul 2009 16:51:59 +0000 (18:51 +0200)]
s3:smbd: add missing return after reply_nterror()
metze
Jeremy Allison [Sat, 11 Jul 2009 01:23:00 +0000 (18:23 -0700)]
Remove reply_unixerror() - no longer needed. Should make Metze's refactoring a lot easier.
Jeremy.
Jeremy Allison [Fri, 10 Jul 2009 22:50:40 +0000 (15:50 -0700)]
Add hash values to the xattr ACLS to determine when
an underlying POSIX ACL is changed out from under us.
Passes RAW-ACL test up to "invalid owner" problem when
trying to create a file owned by Everyone. Now needs
porting to modules/vfs_acl_tdb.c
Jeremy.
Volker Lendecke [Thu, 9 Jul 2009 13:58:10 +0000 (15:58 +0200)]
Return 0 domains from enum_trusteddoms
Volker Lendecke [Sun, 5 Jul 2009 12:39:16 +0000 (14:39 +0200)]
Quieten events and tldap debug messages
Tim Prouty [Fri, 10 Jul 2009 19:03:51 +0000 (12:03 -0700)]
s3 smb2: Remove unused variable
Volker Lendecke [Fri, 10 Jul 2009 15:36:18 +0000 (17:36 +0200)]
Fix&Run local-gencache
Volker Lendecke [Fri, 10 Jul 2009 15:29:22 +0000 (17:29 +0200)]
Fix our base64 implementation for blobs of length 4....
The additional length check bit us exactly at 4, removing it. The
torture test survives valgrind up to 2000 bytes :-)
Stefan Metzmacher [Wed, 8 Jul 2009 11:13:32 +0000 (13:13 +0200)]
s3:smbd: add support for SMB2 Lock
metze
Stefan Metzmacher [Tue, 7 Jul 2009 16:09:16 +0000 (18:09 +0200)]
s3:smbd: make smbd_do_locking() non static
metze
Stefan Metzmacher [Tue, 7 Jul 2009 15:24:25 +0000 (17:24 +0200)]
s3:smbd: abstract the main locking logic from the LockingAndX parsing
This prepares SMB2 Lock support.
metze
Stefan Metzmacher [Thu, 9 Jul 2009 09:34:14 +0000 (11:34 +0200)]
s3:smbd: pass down the client pid to smbd_smb2_lock_send()
metze
Stefan Metzmacher [Thu, 9 Jul 2009 09:33:58 +0000 (11:33 +0200)]
s3:smbd: fix parsing of SMB2 Lock requests with lock_count > 1
We should not reuse the variable 'i'.
metze
Stefan Metzmacher [Wed, 8 Jul 2009 15:02:00 +0000 (17:02 +0200)]
s3:smbd: fix parsing of invalid SMB2 requests.
Because of 0 - 2 => 0xFFFFFFFE, we got EMSGSIZE
from the tstream layer. And terminate the transport
connection. Instead we should let the caller deal with
the invalid parameter, when checking the body size.
So the caller always gets at least a 2 byte body.
metze
Volker Lendecke [Fri, 10 Jul 2009 09:59:00 +0000 (11:59 +0200)]
Attempt to fix the build -- jlayton, please check!
Jeff Layton [Fri, 10 Jul 2009 01:04:08 +0000 (21:04 -0400)]
cifs.upcall: use pid value from kernel to determine KRB5CCNAME to use
If the kernel sends the upcall a pid of the requesting process, we can
open that process' /proc/<pid>/environ file and scrape the KRB5CCNAME
value out of it.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Tim Prouty [Thu, 9 Jul 2009 22:56:36 +0000 (15:56 -0700)]
s3: Fix two arguments that broke when plumbing smb_filneame through dos_mode()
Volker Lendecke [Thu, 9 Jul 2009 20:03:52 +0000 (22:03 +0200)]
Make escape_ldap_string take a talloc context
Andrew Bartlett [Thu, 9 Jul 2009 04:53:26 +0000 (14:53 +1000)]
s4:dsdb Allow unicodePwd to be set when adding a user
Windows 7 sets it's join password using the unicodePwd attribute (as a
quoted, utf16 string), and does so during the LDAPAdd of the object.
Previously, this code only handled unicodePwd for modifies.
Andrew Bartlett
Andrew Bartlett [Thu, 9 Jul 2009 00:08:02 +0000 (10:08 +1000)]
Add const
Tim Prouty [Thu, 9 Jul 2009 03:15:02 +0000 (20:15 -0700)]
s3: Repace a char * with an smb_filename struct in reply_rmdir
Tim Prouty [Wed, 8 Jul 2009 23:53:01 +0000 (16:53 -0700)]
s3: Prepare open.c to switch fsp_name to an smb_filename struct
Tim Prouty [Thu, 9 Jul 2009 00:53:05 +0000 (17:53 -0700)]
s3 plumb smb_filename through smb_set_file_allocation_info()
Tim Prouty [Wed, 8 Jul 2009 23:22:44 +0000 (16:22 -0700)]
s3: Change the share_mode_lock struct to store a base_name and stream_name
Tim Prouty [Wed, 8 Jul 2009 21:27:06 +0000 (14:27 -0700)]
s3: Make some arguments to (parse|unparse)_share_modes() const
Tim Prouty [Wed, 8 Jul 2009 21:08:04 +0000 (14:08 -0700)]
s3: Remove is_ntfs_stream_name() and split_ntfs_stream_name()
Actually I moved split_ntfs_stream_name into torture.c which is the one
consumer of it. This could probably be changed at some point.
Tim Prouty [Wed, 8 Jul 2009 19:24:03 +0000 (12:24 -0700)]
s3: Plumb smb_filename through dos_mode() and related funtions
Tim Prouty [Wed, 8 Jul 2009 02:20:22 +0000 (19:20 -0700)]
s3: convert unix_mode to take an smb_filename
Jeremy Allison [Thu, 9 Jul 2009 01:05:30 +0000 (18:05 -0700)]
Rename update_stat_ex_writetime() -> update_stat_ex_mtime()
to better describe what we're doing here.
Jeremy
Jeremy Allison [Thu, 9 Jul 2009 00:51:35 +0000 (17:51 -0700)]
The migration to struct stat_ex broke the calculation of
create time from the existing timestamps (for systems
that need to do this). Once the write time is changed
via a sticky write, the create time might need to be
recalculated. To do this I needed to add a bool into
struct stat_ex to remember if the st_ex_btime field
was calculated, or read from the OS. Also fixed the
returning of modified write timestamps in the return
from NTCreateX, SMBattr and SMBattrE (which weren't
taking into account the modified timestamp stored
in the open file table). Attempting to fix an issue
with Excel 2003 and offline files. Volker and Metze,
please review.
Jeremy
Jeremy Allison [Wed, 8 Jul 2009 19:28:01 +0000 (12:28 -0700)]
When faking a create time, use the full timespec values, not time_t.
Jeremy.
Jim McDonough [Wed, 8 Jul 2009 17:12:26 +0000 (13:12 -0400)]
Fix make test_shlibs for libnss_wins and libnetapi (zlib)
Jim McDonough [Wed, 8 Jul 2009 12:02:04 +0000 (08:02 -0400)]
Fix cifs.upcall builds on some platforms (zlib)
Shirish Pargaonkar [Wed, 8 Jul 2009 11:43:43 +0000 (07:43 -0400)]
docs: flesh out options section of umount.cifs manpage
Signed-off-by: Shirish Pargaonkar <shirishpargaonkar@gmail.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Stefan Metzmacher [Wed, 8 Jul 2009 07:22:39 +0000 (09:22 +0200)]
s4:auth/ntlmssp: let _unwrap fallback to seal if sign only doesn't work
s4:auth/ntlmssp: let _unwrap fallback to seal if sign only doesn't work
Windows always uses SEAL with NTLMSSP on LDAP connection even if not negotiated.
metze
Anatoliy Atanasov [Fri, 3 Jul 2009 12:24:52 +0000 (15:24 +0300)]
Test for schemaUpdateNow command
Anatoliy Atanasov [Fri, 3 Jul 2009 12:24:40 +0000 (15:24 +0300)]
Fix for schemaUpdateNow command
Tim Prouty [Mon, 6 Jul 2009 22:44:09 +0000 (15:44 -0700)]
s3 onefs: Fix a few bugs from the smb_filename migration
Tim Prouty [Wed, 8 Jul 2009 00:56:49 +0000 (17:56 -0700)]
s3: Migrate a few functions in open.c to take smb_filename
Tim Prouty [Wed, 8 Jul 2009 00:27:50 +0000 (17:27 -0700)]
s3: Remove unnecessary const qualifiers
Shirish Pargaonkar [Tue, 7 Jul 2009 20:35:06 +0000 (16:35 -0400)]
mount.cifs: clarify mapchars option
Signed-off-by: Shirish Pargaonkar <shirishpargaonkar@gmail.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Björn Jacke [Tue, 7 Jul 2009 20:11:50 +0000 (22:11 +0200)]
s3: QNX doesn't know uint - replace with uint_t
Volker Lendecke [Tue, 7 Jul 2009 18:40:39 +0000 (20:40 +0200)]
Attempt to fix the build of vfs_catia.c -- Tim, please check!
Stefan Metzmacher [Tue, 7 Jul 2009 13:16:21 +0000 (15:16 +0200)]
s3:smbd: cancel all locks that are made before the first failure
s3:smbd: cancel all locks that are made before the first failure
We never reached the cleanup code and directly returned the error.
metze
Andrew Bartlett [Tue, 7 Jul 2009 03:27:47 +0000 (13:27 +1000)]
s4:auth It is easier to copy the session key than get talloc right.
The session keys as supplied already have a reference on them, so
stealing them creates challenges. For 16 bytes, it is just easier to
be consistant and copy them.
Andrew Bartlett
Tim Prouty [Mon, 6 Jul 2009 22:26:57 +0000 (15:26 -0700)]
s3: Update streaminfo implementations now that only base names are passed through the vfs
Tim Prouty [Mon, 6 Jul 2009 21:18:05 +0000 (14:18 -0700)]
s3 smb2: Fix unused variable warning
Tim Prouty [Sat, 4 Jul 2009 00:15:30 +0000 (17:15 -0700)]
s3 audit: Fix a memory leak
Tim Prouty [Thu, 2 Jul 2009 20:39:20 +0000 (13:39 -0700)]
s3: Plumb smb_filename through SMB_VFS_NTIMES
Tim Prouty [Thu, 2 Jul 2009 20:13:14 +0000 (13:13 -0700)]
s3 catia: Remove pointless VOPs from catia
Tim Prouty [Thu, 2 Jul 2009 17:27:01 +0000 (10:27 -0700)]
s3 sticky write time: Removed unused args and tighten up a function by making an arg const
Tim Prouty [Mon, 6 Jul 2009 21:36:16 +0000 (14:36 -0700)]
s3: Plumb smb_filename around SMB_VFS_CHFLAGS
SMB_VFS_CHFLAGS isn't actually getting the smb_filename struct for now
since it only operates on the basefile. This is the strategy for all
path-based operations that will never actually operate on a stream.
By clarifying the meaning of path based operations that don't take an
smb_filename struct, modules that implement streams such as vfs_onefs
no longer need to implement SMB_VFS_CHFLAGS to ensure it's only called
on the base_name.
Tim Prouty [Wed, 1 Jul 2009 23:15:52 +0000 (16:15 -0700)]
s3: Change some filename_convert to pass in NULL for char **fname argument
Tim Prouty [Wed, 1 Jul 2009 23:14:40 +0000 (16:14 -0700)]
s3: Add ability to pass NULL to filename_convert for the char *fname
The goal is to eventually remove the need for the char **fname argument
once all callers have standardized on smb_filename.
Tim Prouty [Thu, 2 Jul 2009 16:27:44 +0000 (09:27 -0700)]
s3: Plumb smb_filename through SMB_VFS_UNLINK
Tim Prouty [Wed, 1 Jul 2009 06:08:02 +0000 (23:08 -0700)]
s3 audit: Remove some recently introduced memory leaks in the audit modules
Tim Prouty [Wed, 1 Jul 2009 05:44:39 +0000 (22:44 -0700)]
s3 audit: Remove the usesless static function declarations from the audit modules
Tim Prouty [Tue, 30 Jun 2009 23:41:48 +0000 (16:41 -0700)]
s3 onefs: Fix failure in POSIX smbtorture test
The return value of readlink was a bool instead of an int,
which caused the length of the returned value to never be
>1.
Tim Prouty [Wed, 1 Jul 2009 00:04:38 +0000 (17:04 -0700)]
s3: Plumb smb_filename through SMB_VFS_RENAME
Jelmer Vernooij [Mon, 6 Jul 2009 20:41:21 +0000 (22:41 +0200)]
Fix some typos pointed out by Oota Toshiya.