ira/wip.git
14 years agos3-netlogon: Fix _netr_ServerPasswordSet2 cleartext blob handling.
Günther Deschner [Fri, 16 Oct 2009 10:09:55 +0000 (12:09 +0200)]
s3-netlogon: Fix _netr_ServerPasswordSet2 cleartext blob handling.

Following Andrew's advice, let's straight md4 the plaintext blob and avoid
trying to get a paintext string out of the input the client sends.

Guenther

14 years agos4-smbtorture: test wbcLookupUserSids in WINBIND-WBCLIENT as well.
Günther Deschner [Fri, 16 Oct 2009 12:51:49 +0000 (14:51 +0200)]
s4-smbtorture: test wbcLookupUserSids in WINBIND-WBCLIENT as well.

Guenther

14 years agos4-smbtorture: test wbcGuidToString and friends as well in WINBIND-WBCLIENT.
Günther Deschner [Fri, 16 Oct 2009 11:38:57 +0000 (13:38 +0200)]
s4-smbtorture: test wbcGuidToString and friends as well in WINBIND-WBCLIENT.

Guenther

14 years agos4:provision - fixed invalid creationTime format
Endi S. Dewata [Wed, 14 Oct 2009 06:04:00 +0000 (01:04 -0500)]
s4:provision - fixed invalid creationTime format

14 years agos4:ldb - fixed dangling pointer in ldb_request_add_control()
Endi S. Dewata [Wed, 14 Oct 2009 05:54:52 +0000 (00:54 -0500)]
s4:ldb - fixed dangling pointer in ldb_request_add_control()

14 years agos4:auth - fixed problem reading bind DN from secrets database
Endi S. Dewata [Fri, 9 Oct 2009 19:30:51 +0000 (14:30 -0500)]
s4:auth - fixed problem reading bind DN from secrets database

14 years agos4:provision - replaced linked_attributes with FDS plugins
Endi S. Dewata [Fri, 9 Oct 2009 18:36:04 +0000 (13:36 -0500)]
s4:provision - replaced linked_attributes with FDS plugins

When FDS is used as a backend, Samba should not use the
linked_attributes LDB module, but instead use the built-in
DS plugins for attribute linking, indexing, and referential
integrity.

14 years agos4:auth_sam: Restructure tail in "authsam_get_server_info_principal" and fix a memory...
Matthias Dieter Wallnöfer [Fri, 16 Oct 2009 11:48:17 +0000 (13:48 +0200)]
s4:auth_sam: Restructure tail in "authsam_get_server_info_principal" and fix a memory leak

14 years agos4:winsdb - Substitute LDB result numbers with constants
Matthias Dieter Wallnöfer [Fri, 16 Oct 2009 11:42:58 +0000 (13:42 +0200)]
s4:winsdb - Substitute LDB result numbers with constants

14 years agos3: Try to fix the build on Solaris & AIX regarding the password change reject reason
Matthias Dieter Wallnöfer [Fri, 16 Oct 2009 10:25:34 +0000 (12:25 +0200)]
s3: Try to fix the build on Solaris & AIX regarding the password change reject reason

14 years agos4/drs(tort): prefixMap unit test initial implementatoin
Kamen Mazdrashki [Wed, 7 Oct 2009 23:56:22 +0000 (02:56 +0300)]
s4/drs(tort): prefixMap unit test initial implementatoin

14 years agos4/drs: prefixMap module initial definition
Kamen Mazdrashki [Wed, 7 Oct 2009 23:55:28 +0000 (02:55 +0300)]
s4/drs: prefixMap module initial definition

14 years agos4/drs(tort): fix compile time warning
Kamen Mazdrashki [Wed, 7 Oct 2009 15:32:43 +0000 (18:32 +0300)]
s4/drs(tort): fix compile time warning

14 years agos4/drs(tort): _drs_util_verify_attids() to verify ATTIDs in objects received
Kamen Mazdrashki [Tue, 6 Oct 2009 08:42:02 +0000 (11:42 +0300)]
s4/drs(tort): _drs_util_verify_attids() to verify ATTIDs in objects received

14 years agos4/drs(tort): drs_util_DsAttributeId_to_string() function
Kamen Mazdrashki [Tue, 6 Oct 2009 08:38:42 +0000 (11:38 +0300)]
s4/drs(tort): drs_util_DsAttributeId_to_string() function

14 years agos4/drs(tort): _drs_ldap_attr_by_oid() implementation
Kamen Mazdrashki [Sun, 27 Sep 2009 14:04:04 +0000 (17:04 +0300)]
s4/drs(tort): _drs_ldap_attr_by_oid() implementation

Utility function to be used to fetch Attribute name and DN
giving attribute OID

14 years agos4/drs(tort): ignore drs/proto.h file
Kamen Mazdrashki [Tue, 6 Oct 2009 08:35:51 +0000 (11:35 +0300)]
s4/drs(tort): ignore drs/proto.h file

14 years agos4/drs(tort): oid_from_attid() reference implementation
Kamen Mazdrashki [Tue, 6 Oct 2009 05:40:15 +0000 (08:40 +0300)]
s4/drs(tort): oid_from_attid() reference implementation

Decode Attribute OID using prefixMap and
ATTID received during replication

Based on MS documentation. See MS-DRSR.pdf - 5.16.4

14 years agos4/drs(tort): TORTURE_DRS torture module - initial implementation
Kamen Mazdrashki [Mon, 5 Oct 2009 15:39:13 +0000 (18:39 +0300)]
s4/drs(tort): TORTURE_DRS torture module - initial implementation

Drsuapi tests module registers two suites:
 - DRS-RPC - tests to be executed against remote machine
 - DRS-UNIT - unit test for internal testing

14 years agos4/drs: Propagate redefinition of drsuapi_DsReplicaOID into code base
Kamen Mazdrashki [Sun, 11 Oct 2009 18:00:55 +0000 (21:00 +0300)]
s4/drs: Propagate redefinition of drsuapi_DsReplicaOID into code base

The biggest change is that 'oid' field is transmited in binary format.
Also the field name is changed to 'binary_oid' so that
field format to be clear for callers.

After those changes, Samba4 should work the way it works before -
i.e. no added value here but we should not fail when
partial-oid is part of prefixMap transmited from Win server.

Also, thre is a bug in this patch - partial-binary-OIDs are
not handled correctly. Partial-binary-OIDs received during
replication will be encoded, but not handled correctly.

14 years agos4/drs(NDR): Print implementation for drsuapi_DsReplicaOID
Kamen Mazdrashki [Mon, 5 Oct 2009 10:28:12 +0000 (13:28 +0300)]
s4/drs(NDR): Print implementation for drsuapi_DsReplicaOID

Custom ndr_print functions is implemented so that transmited
partia-binary-oid to be printed both in hex and
partial-oid formats

14 years agos4/drs(NDR): Remove push/pull code for drsuapi_DsReplicaOID struct
Kamen Mazdrashki [Mon, 5 Oct 2009 10:23:48 +0000 (13:23 +0300)]
s4/drs(NDR): Remove push/pull code for drsuapi_DsReplicaOID struct

New structure definition is automarshaled so custom marshaling
code is not used anymore

14 years agos4/asn1: Use explicite TALLOC_CTX in ber_write_OID functions
Kamen Mazdrashki [Mon, 5 Oct 2009 01:46:20 +0000 (04:46 +0300)]
s4/asn1: Use explicite TALLOC_CTX in ber_write_OID functions

14 years agos4/drs(idl): Regenerate idl
Kamen Mazdrashki [Fri, 2 Oct 2009 15:30:14 +0000 (18:30 +0300)]
s4/drs(idl): Regenerate idl

14 years agos4/drs(idl): Redefine drsuapi_DsReplicaOID in drsuapi.idl
Kamen Mazdrashki [Fri, 2 Oct 2009 15:29:44 +0000 (18:29 +0300)]
s4/drs(idl): Redefine drsuapi_DsReplicaOID in drsuapi.idl

Structure redefined to be more similar with OID_t structure
defined in [ref. MS-DRSR.pdf - p.496].

14 years agos3-libnetapi: add nltest tool.
Günther Deschner [Wed, 14 Oct 2009 23:04:27 +0000 (01:04 +0200)]
s3-libnetapi: add nltest tool.

Guenther

14 years agos3-libnetapi: add I_NetLogonControl{2} example code.
Günther Deschner [Tue, 13 Oct 2009 14:47:32 +0000 (16:47 +0200)]
s3-libnetapi: add I_NetLogonControl{2} example code.

Guenther

14 years agos3-libnetapi: add I_NetLogonControl{2} to public headers.
Günther Deschner [Tue, 13 Oct 2009 14:46:54 +0000 (16:46 +0200)]
s3-libnetapi: add I_NetLogonControl{2} to public headers.

Guenther

14 years agos3-libnetapi: fill in I_NetLogonControl{2}_r.
Günther Deschner [Tue, 13 Oct 2009 14:03:58 +0000 (16:03 +0200)]
s3-libnetapi: fill in I_NetLogonControl{2}_r.

Guenther

14 years agos3-libnetapi: add I_NetLogonControl{2} skeleton.
Günther Deschner [Tue, 13 Oct 2009 13:47:56 +0000 (15:47 +0200)]
s3-libnetapi: add I_NetLogonControl{2} skeleton.

Guenther

14 years agos3-libnetapi: add I_NetLogonControl{2} to IDL.
Günther Deschner [Tue, 13 Oct 2009 13:39:27 +0000 (15:39 +0200)]
s3-libnetapi: add I_NetLogonControl{2} to IDL.

Guenther

14 years agos4-winsrepl: don't put in attributes with no elements
Andrew Tridgell [Fri, 16 Oct 2009 00:41:52 +0000 (11:41 +1100)]
s4-winsrepl: don't put in attributes with no elements

Empty attributes are no longer allowed by ldb. This also fixes the
error checking in winsdb_message()

This fixes the samba4.nbt.winsreplication test

14 years agos3-selftest: enable WINBIND-WBCLIENT against s3.
Günther Deschner [Thu, 15 Oct 2009 23:58:49 +0000 (01:58 +0200)]
s3-selftest: enable WINBIND-WBCLIENT against s3.

Guenther

14 years agos4-smbtorture: add very basic libwbclient testsuite.
Günther Deschner [Thu, 15 Oct 2009 22:33:38 +0000 (00:33 +0200)]
s4-smbtorture: add very basic libwbclient testsuite.

Guenther

14 years agos3-net: fix build warning (missing default in switch).
Günther Deschner [Thu, 15 Oct 2009 23:59:08 +0000 (01:59 +0200)]
s3-net: fix build warning (missing default in switch).

Guenther

14 years agoFix valgrind memory leak in bug #6814 - Fixes for problems reported by valgrind
Jeremy Allison [Thu, 15 Oct 2009 23:55:40 +0000 (16:55 -0700)]
Fix valgrind memory leak in bug #6814 - Fixes for problems reported by valgrind
Jeremy.

14 years agos3: fixed krb5 build problem on ubuntu karmic
Andrew Tridgell [Thu, 15 Oct 2009 23:40:50 +0000 (10:40 +1100)]
s3: fixed krb5 build problem on ubuntu karmic

Karmic has MIT krb5 1.7-beta3, which has the symbol
krb5_auth_con_set_req_cksumtype but no prototype for it.

See also http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=531635

14 years agos4-pvfs: fixed mask handling for SEC_FLAG_MAXIMUM_ALLOWED
Andrew Tridgell [Thu, 15 Oct 2009 23:05:02 +0000 (10:05 +1100)]
s4-pvfs: fixed mask handling for SEC_FLAG_MAXIMUM_ALLOWED

This matches the sec_access_check() code

14 years agos4-torture: take privileges into account in BASE-MAXIMUM_ALLOWED
Andrew Tridgell [Thu, 15 Oct 2009 23:04:26 +0000 (10:04 +1100)]
s4-torture: take privileges into account in BASE-MAXIMUM_ALLOWED

The correct answer depends on the users privileges.

14 years agoidl: added bit definition for privilege masks
Andrew Tridgell [Thu, 15 Oct 2009 23:01:28 +0000 (10:01 +1100)]
idl: added bit definition for privilege masks

When you have backup or restore privileges, you automatically get
extra access bits in ACL interpretation. This adds definitions for the
bits you get.

14 years agos4:dcerpc_server - Read the generic session key out from "dcerpc_generic_session_key"
Matthias Dieter Wallnöfer [Thu, 15 Oct 2009 11:24:30 +0000 (13:24 +0200)]
s4:dcerpc_server - Read the generic session key out from "dcerpc_generic_session_key"

I don't think that this code needs to exist identically on the server and on the
client side. This patch leaves it on the client side (dcerpc lib) and calls it
from the server.

14 years agos3-spnego: fix memleak in spnego_parse_auth().
Günther Deschner [Thu, 15 Oct 2009 13:45:20 +0000 (15:45 +0200)]
s3-spnego: fix memleak in spnego_parse_auth().

Guenther

14 years agos3-spnego: Fix Bug #6815. Windows 2008 R2 SPNEGO negTokenTarg parsing failure.
Günther Deschner [Thu, 15 Oct 2009 12:13:26 +0000 (14:13 +0200)]
s3-spnego: Fix Bug #6815. Windows 2008 R2 SPNEGO negTokenTarg parsing failure.

When parsing a SPNEGO session setup retry (falling back from KRB5 to NTLMSSP),
we failed to parse the ASN1_ENUMERATED negResult in the negTokenTarg, thus
failing spnego_parse_auth() completely.

By just using the shared spnego/asn1 code, we get the parsing the correct way.

Guenther

14 years agos4:w32err_code.py script - put it under "scripting/bin"
Matthias Dieter Wallnöfer [Thu, 15 Oct 2009 09:06:08 +0000 (11:06 +0200)]
s4:w32err_code.py script - put it under "scripting/bin"

I think this is a better location for this script. Since the subdirectory
"script" of "source4" contains only scripts for "make install" and "make
uninstall".

14 years agos3/docs: Add missing meta data to man ldbrename.
Karolin Seeger [Thu, 15 Oct 2009 10:27:24 +0000 (12:27 +0200)]
s3/docs: Add missing meta data to man ldbrename.

Avoid warnings.

Karolin

14 years agos4-smb: fill in fnum as well for root_fid
Andrew Tridgell [Thu, 15 Oct 2009 09:50:49 +0000 (20:50 +1100)]
s4-smb: fill in fnum as well for root_fid

This helps with the CIFS NTVFS backend, but doesn't solve all problems

14 years agos4-selftest: mark some CIFS backend tests as known fail
Andrew Tridgell [Thu, 15 Oct 2009 09:42:53 +0000 (20:42 +1100)]
s4-selftest: mark some CIFS backend tests as known fail

The CIFS passthru NTVFS doesn't handle some options yet (eg. root_fid)

14 years agos4-smbserver: fixed root_fid in nttrans create
Andrew Tridgell [Thu, 15 Oct 2009 07:53:23 +0000 (18:53 +1100)]
s4-smbserver: fixed root_fid in nttrans create

14 years agos4-libcli: fixed structure element bug in ntcreatexreadx
Andrew Tridgell [Thu, 15 Oct 2009 07:52:56 +0000 (18:52 +1100)]
s4-libcli: fixed structure element bug in ntcreatexreadx

This one didn't matter until the root_fid changed the alignment of the
two structures.

14 years agos4-torture: catch bad command line options
Andrew Tridgell [Thu, 15 Oct 2009 07:27:57 +0000 (18:27 +1100)]
s4-torture: catch bad command line options

It is annoying when you mistype a command line option and aren't told.

14 years agos4-pvfs: implement root_fid support in posix backend
Andrew Tridgell [Thu, 15 Oct 2009 07:27:21 +0000 (18:27 +1100)]
s4-pvfs: implement root_fid support in posix backend

Construct the filename from the old handle and the new name.

14 years agos4-smb: declare root_fid as a file handle
Andrew Tridgell [Thu, 15 Oct 2009 07:26:19 +0000 (18:26 +1100)]
s4-smb: declare root_fid as a file handle

In order to implement root_fid in the s4 SMB server we need to declare
it as a handle type, just as for other fnum values in SMB. This
required some extensive (but simple) changes in many bits of code.

14 years agos4-pvfs: fixed handling of SEC_FLAG_MAXIMUM_ALLOWED
Andrew Tridgell [Thu, 15 Oct 2009 07:23:42 +0000 (18:23 +1100)]
s4-pvfs: fixed handling of SEC_FLAG_MAXIMUM_ALLOWED

The CREATEX_ACCESS test shows that this is used as a bit test, not a
equality test

14 years agos4-ldaptest: "testgroup" is a bit too common
Andrew Tridgell [Thu, 15 Oct 2009 05:11:30 +0000 (16:11 +1100)]
s4-ldaptest: "testgroup" is a bit too common

This failed on one of my test boxes that has a group called
"testgroup". using "testgroupXX" should be a bit better.

14 years agos4:ntlmssp server - use also here the new "lp_dnsdomain()" call
Matthias Dieter Wallnöfer [Thu, 15 Oct 2009 08:30:55 +0000 (10:30 +0200)]
s4:ntlmssp server - use also here the new "lp_dnsdomain()" call

14 years agos4:auth/credentials/credentials - fix uninitalised pointers
Matthias Dieter Wallnöfer [Thu, 15 Oct 2009 08:30:07 +0000 (10:30 +0200)]
s4:auth/credentials/credentials - fix uninitalised pointers

This should fix bug #6755.

14 years agos3: fix outdated proto.h causing build error on AIX
Björn Jacke [Thu, 15 Oct 2009 01:19:47 +0000 (03:19 +0200)]
s3: fix outdated proto.h causing build error on AIX

Matthias, please check!

14 years agos4-ldap: test the rDN size limit
Andrew Tridgell [Thu, 15 Oct 2009 04:54:40 +0000 (15:54 +1100)]
s4-ldap: test the rDN size limit

14 years agos4-dsdb: implement limit on rDN length
Andrew Tridgell [Thu, 15 Oct 2009 04:54:20 +0000 (15:54 +1100)]
s4-dsdb: implement limit on rDN length

w2k8 imposes a limit of 64 characters on the rDN

14 years agos4-ldb: removed incorrect rDN length test
Andrew Tridgell [Thu, 15 Oct 2009 04:53:40 +0000 (15:53 +1100)]
s4-ldb: removed incorrect rDN length test

This is a property of AD, not ldb, so should be in our ldb
modules.

14 years agos4-ldb: removed bugus RDN length check
Andrew Tridgell [Wed, 14 Oct 2009 23:01:10 +0000 (10:01 +1100)]
s4-ldb: removed bugus RDN length check

This isn't the rDN !

14 years agos4-script: flush DNS after adding new addresses
Andrew Tridgell [Wed, 14 Oct 2009 23:00:46 +0000 (10:00 +1100)]
s4-script: flush DNS after adding new addresses

14 years agos4-devel: for devel scripts its better to use bin/ than $PREFIX/bin
Andrew Tridgell [Wed, 14 Oct 2009 21:49:21 +0000 (08:49 +1100)]
s4-devel: for devel scripts its better to use bin/ than $PREFIX/bin

This avoids having to do make install after each change when using the
drs devel scripts

14 years agos4-drs: support DRSUAPI_DRS_ADD_REF flag
Andrew Tridgell [Wed, 14 Oct 2009 09:29:39 +0000 (20:29 +1100)]
s4-drs: support DRSUAPI_DRS_ADD_REF flag

The DRSUAPI_DRS_ADD_REF flag tells the DRS server to run an UpdateRefs
call on behalf of the client after the DsGetNCChanges call. The lack
of support for this option may explain why the repsTo attribute was
not being created for w2k8-r2 replication partners.

14 years agos4-drs: implement more of DsUpdateRefs
Andrew Tridgell [Wed, 14 Oct 2009 09:25:48 +0000 (20:25 +1100)]
s4-drs: implement more of DsUpdateRefs

The DsUpdateRefs calls takes a set of flags that indicates if the
server should ignore specific add/delete error codes.

This patch also exposes the core UpdateRefs call into a public
function, so that it can be called from DsGetNCChanges

14 years agoldb: fixed display of replUpToDateVector
Andrew Tridgell [Wed, 14 Oct 2009 04:57:15 +0000 (15:57 +1100)]
ldb: fixed display of replUpToDateVector

14 years agodrs: improved error checking
Andrew Tridgell [Tue, 13 Oct 2009 08:49:08 +0000 (19:49 +1100)]
drs: improved error checking

Check the validity of the requested options in DsGetNCChanges

14 years agos4-dsdb: added samdb_rodc() and samdb_ntds_options()
Andrew Tridgell [Tue, 13 Oct 2009 08:48:13 +0000 (19:48 +1100)]
s4-dsdb: added samdb_rodc() and samdb_ntds_options()

Later we will need to make samdb_rodc() look in the database, but for
now we should at least have the function in a central place

14 years agolibds: added nTDSDSA options flags
Andrew Tridgell [Tue, 13 Oct 2009 08:46:18 +0000 (19:46 +1100)]
libds: added nTDSDSA options flags

14 years agoidl: added WSPP DrsOptions bit names
Andrew Tridgell [Tue, 13 Oct 2009 07:31:21 +0000 (18:31 +1100)]
idl: added WSPP DrsOptions bit names

This should make it much easier to work through the logic in MS-DRSR

14 years agoFix the build, missing ->.
Jeremy Allison [Wed, 14 Oct 2009 19:36:02 +0000 (12:36 -0700)]
Fix the build, missing ->.
Jeremy.

14 years agoFinal part of fix for bug 6793 - winbindd crash with "INTERNAL ERROR: Signal 6"
Jeremy Allison [Wed, 14 Oct 2009 18:11:26 +0000 (11:11 -0700)]
Final part of fix for bug 6793 - winbindd crash with "INTERNAL ERROR: Signal 6"
Don't use mapped_user uninitialized.
Jeremy.

14 years agos3:winbind: Fix a double-free
Volker Lendecke [Tue, 13 Oct 2009 18:56:28 +0000 (20:56 +0200)]
s3:winbind: Fix a double-free

Part of a fix for bug #6793.

14 years agos3:winbind: Fix bug 6793 -- segfault in winbindd_pam_auth
Volker Lendecke [Wed, 14 Oct 2009 18:14:57 +0000 (11:14 -0700)]
s3:winbind: Fix bug 6793 -- segfault in winbindd_pam_auth

14 years agos3-build: we need to have talloc 2.0.1 when building with external talloc.
Günther Deschner [Wed, 14 Oct 2009 15:42:19 +0000 (17:42 +0200)]
s3-build: we need to have talloc 2.0.1 when building with external talloc.

2.0.0 did not got the exports right.
This and the 2.0.1 talloc fixes resolve bug #6808.

Guenther

14 years agotalloc: Fix exports and increment talloc version talloc-2.0.1
Simo Sorce [Wed, 14 Oct 2009 14:50:19 +0000 (10:50 -0400)]
talloc: Fix exports and increment talloc version

14 years agotalloc: Make abi checks in release script
Simo Sorce [Wed, 14 Oct 2009 14:57:17 +0000 (10:57 -0400)]
talloc: Make abi checks in release script

Make always sure the exports and signature files are up to date before
shipping a release.

14 years agotalloc: Move release script under /script too
Simo Sorce [Wed, 14 Oct 2009 14:55:11 +0000 (10:55 -0400)]
talloc: Move release script under /script too

14 years agotalloc: Change the way mksysms work
Simo Sorce [Wed, 14 Oct 2009 14:20:28 +0000 (10:20 -0400)]
talloc: Change the way mksysms work

Make sure we always have a sorted (per file) export file.
This way we can directly compare the real export and the check file w/o having
to further sort things.

Also return error code from abi_checks.sh if warnings were reported

14 years agos3-passdb: missed two prototypes while moving to enum netr_SchannelType.
Günther Deschner [Wed, 14 Oct 2009 09:48:59 +0000 (11:48 +0200)]
s3-passdb: missed two prototypes while moving to enum netr_SchannelType.

Guenther

14 years agos4:torture cldap test - Add checks for the right forest DNS name
Matthias Dieter Wallnöfer [Wed, 14 Oct 2009 10:27:06 +0000 (12:27 +0200)]
s4:torture cldap test - Add checks for the right forest DNS name

14 years agos4:password_hash - load the domain parameters from the "loadparm context"
Matthias Dieter Wallnöfer [Wed, 14 Oct 2009 09:40:25 +0000 (11:40 +0200)]
s4:password_hash - load the domain parameters from the "loadparm context"

And don't cut them out from the DNS hostname.

14 years agos4:torture - fix up "ldap_basic" test
Matthias Dieter Wallnöfer [Wed, 14 Oct 2009 08:50:57 +0000 (10:50 +0200)]
s4:torture - fix up "ldap_basic" test

14 years agos4: Changes the old occurences of "lp_realm" in "lp_dnsdomain" where needed
Matthias Dieter Wallnöfer [Mon, 12 Oct 2009 17:09:18 +0000 (19:09 +0200)]
s4: Changes the old occurences of "lp_realm" in "lp_dnsdomain" where needed

For KERBEROS applications the realm should be upcase (function "lp_realm") but
for DNS ones it should be used lowcase (function "lp_dnsdomain"). This patch
implements the use of both in the right way.

14 years agos4:loadparm - adapt "realm" handling
Matthias Dieter Wallnöfer [Tue, 13 Oct 2009 16:18:50 +0000 (18:18 +0200)]
s4:loadparm - adapt "realm" handling

Change "lp_realm" behaviour to return the realm always upcased and add a
function "lp_dnsdomain" which returns it always lowcased.

14 years agos3: Fix reference to freed memory in pam_winbind.
Bo Yang [Wed, 14 Oct 2009 20:31:26 +0000 (04:31 +0800)]
s3: Fix reference to freed memory in pam_winbind.

Signed-off-by: Bo Yang <boyang@samba.org>
14 years agoRevert "s4:hdb-samba4 - Don't double-free "db""
Andrew Bartlett [Tue, 13 Oct 2009 22:10:01 +0000 (09:10 +1100)]
Revert "s4:hdb-samba4 - Don't double-free "db""

This reverts commit 11a8a54c825a52d7dd6ab78bc7aeff2d719327d2.

The actual fix for bug 6801 is in hdb_end_seq_get() - this attempt
leaks 'db' instead.

Andrew Bartlett

14 years agos4:heimdal A real fix for bug 6801
Andrew Bartlett [Tue, 13 Oct 2009 22:04:16 +0000 (09:04 +1100)]
s4:heimdal A real fix for bug 6801

The issue was that we would free the entry after the database, not
knowing that the entry was a talloc child of the database.

Andrew Bartlett

14 years agos3:net: simplify padding to single printf call
Björn Jacke [Tue, 13 Oct 2009 22:22:08 +0000 (00:22 +0200)]
s3:net: simplify padding to single printf call

14 years agos3:net simplify padding to single printf call
Björn Jacke [Tue, 13 Oct 2009 22:19:35 +0000 (00:19 +0200)]
s3:net simplify padding to single printf call

14 years agos3:net: Fix a segfault in "net rpc trustdom list" for overlong domain names
Volker Lendecke [Tue, 13 Oct 2009 13:56:00 +0000 (15:56 +0200)]
s3:net: Fix a segfault in "net rpc trustdom list" for overlong domain names

That was a complicated way to say "%-20.s"... But that code was from 2002 ...

14 years agoRemove use of "int ret" when we already have errcode.
Jeremy Allison [Tue, 13 Oct 2009 20:28:57 +0000 (13:28 -0700)]
Remove use of "int ret" when we already have errcode.
Jeremy.

14 years agoCatch one more erroneous use of errno.
Jeremy Allison [Tue, 13 Oct 2009 20:03:39 +0000 (13:03 -0700)]
Catch one more erroneous use of errno.
Jeremy.

14 years agocorrectly handle aio_error() and errno
Olaf Flebbe [Tue, 13 Oct 2009 13:48:19 +0000 (15:48 +0200)]
correctly handle aio_error() and errno

14 years agos3:torture: Add a notify-bench test
Volker Lendecke [Mon, 12 Oct 2009 15:29:45 +0000 (17:29 +0200)]
s3:torture: Add a notify-bench test

This is a test that creates and deletes files in a directory as fast as the
network allows it. At the same time, it opens a filechangenotify. This test is
done to just torture handling a single directory together with the notify
infrastructure.

14 years agos3:libsmb: Add cli_notify
Volker Lendecke [Mon, 12 Oct 2009 14:43:19 +0000 (16:43 +0200)]
s3:libsmb: Add cli_notify

14 years agos3:rpc: Fix is_known_pipename for dynamically loaded pipes
Volker Lendecke [Sat, 3 Oct 2009 13:33:12 +0000 (15:33 +0200)]
s3:rpc: Fix is_known_pipename for dynamically loaded pipes

14 years agos3: Fix some nonempty blank lines
Volker Lendecke [Sun, 4 Oct 2009 14:52:08 +0000 (16:52 +0200)]
s3: Fix some nonempty blank lines

14 years agos3: Fix vfs_shadow_copy2 to allow in-path @GMT-xxx
Andrew Tridgell [Wed, 16 Sep 2009 01:22:56 +0000 (03:22 +0200)]
s3: Fix vfs_shadow_copy2 to allow in-path @GMT-xxx

14 years agos3/loadparm: Fix severe HPUX compiler issue.
Olaf Flebbe [Tue, 13 Oct 2009 12:13:06 +0000 (14:13 +0200)]
s3/loadparm: Fix severe HPUX compiler issue.

Members of struct should be initialized explictly.
Fixes bug #6804.