20 years agoFixed crash bug in display_print_info_1()
Tim Potter [Thu, 3 Jan 2002 02:48:23 +0000 (02:48 +0000)]
Fixed crash bug in display_print_info_1()
(This used to be commit d1564fbf1f4950c12516470d4566efeca3ad79e5)

20 years agoInitialise result on success in cli_spoolss_enum_printers() so we don't get
Tim Potter [Thu, 3 Jan 2002 02:47:50 +0000 (02:47 +0000)]
Initialise result on success in cli_spoolss_enum_printers() so we don't get
stuck in an infinite loop.
(This used to be commit fe1fb6589a0a4b4cff7a0ee0267f6e09e10e2a85)

20 years agoThe werror<->nt status code map has changed and has broken all the spoolss
Tim Potter [Thu, 3 Jan 2002 02:36:08 +0000 (02:36 +0000)]
The werror<->nt status code map has changed and has broken all the spoolss
commands in rpcclient.  Replacing ERROR_INSUFFICIENT_BUFFER with

I always thought the caller (i.e cmd_spoolss.c) should take care of the
whole requested/needed buffer size thingy though...
(This used to be commit 6c950db05a2772f11b20cc13c65a123ea8b878c2)

20 years agoRemoved unused #define
Tim Potter [Thu, 3 Jan 2002 02:28:51 +0000 (02:28 +0000)]
Removed unused #define
(This used to be commit ab1bd916cf59e12366d9005f6ce1cf6521ff02be)

20 years agodebug statement fixups.
Jeremy Allison [Wed, 2 Jan 2002 23:28:55 +0000 (23:28 +0000)]
debug statement fixups.
Merge SAFE_FREE fix in tdb from 2.2, and IRIX fix.
(This used to be commit eb6607466565bcd5b3800492d0bc1ae8a44da4f6)

20 years agoremoved stuff I wasn't using
Gerald Carter [Wed, 2 Jan 2002 23:11:24 +0000 (23:11 +0000)]
removed stuff I wasn't using
(This used to be commit 27ffce157a655e267f225126f586847e5a0b8614)

20 years agosync up ldap defaults with 2.2
Gerald Carter [Wed, 2 Jan 2002 22:44:15 +0000 (22:44 +0000)]
sync up ldap defaults with 2.2
(This used to be commit 59174310d419aa835031c7a318d85fe25ba28227)

20 years agoooops./ forgot one
Gerald Carter [Wed, 2 Jan 2002 22:22:22 +0000 (22:22 +0000)]
ooops./  forgot one
(This used to be commit 501f3f3a8fb5ea27155f8c2fe266f1f659d7d22d)

20 years agofixing compile error
Gerald Carter [Wed, 2 Jan 2002 22:02:11 +0000 (22:02 +0000)]
fixing compile error
(This used to be commit 999a2f5c847c6a4336df60807e2fb546a2a4894f)

20 years agoWe should be SHLD not LINK when creating shared libraries.
Jeremy Allison [Wed, 2 Jan 2002 21:54:38 +0000 (21:54 +0000)]
We should be SHLD not LINK when creating shared libraries.
Tidyup in passdb.c
(This used to be commit 676eea502a1bb2114a6e8055ecaf97ecab2e3a91)

20 years agoWe go to a lot of effort to avoid strcpy() in Samba, but its not much use if
Andrew Bartlett [Wed, 2 Jan 2002 09:02:28 +0000 (09:02 +0000)]
We go to a lot of effort to avoid strcpy() in Samba, but its not much use if
people start doing using strlen(src) in strncpy() :-)

This occured when the talloc based passdb was reverted in favor of a pstring
based one.  In the talloc version this was fine, becouse the buffer was
strlen(src) bytes long.  This no longer applies...

This doesn't seem to have broken anything, but I'm chasing up an oddity with NT
password changing from the last merge.

Test & MERGE for 2.2.3

Andrew Bartlett
(This used to be commit 673ece2841e8b60966a17ece3591f9f202807332)

20 years agoAdd prs_dump_before to dump everything from the start of the prs
Martin Pool [Wed, 2 Jan 2002 07:48:07 +0000 (07:48 +0000)]
Add prs_dump_before to dump everything from the start of the prs
buffer up to the current position, and use this to dump pipe buffers
just before parsing.
(This used to be commit 92a3ab274e6cf09a8ba39b91f8bbacba6de40b37)

20 years agoActually enforce the passdb API.
Andrew Bartlett [Wed, 2 Jan 2002 07:41:54 +0000 (07:41 +0000)]
Actually enforce the passdb API.

Thou shalt not reference SAM_ACCOUNT members directly - always use

This is achived by making the whole of SAM_ACCOUNT have a .private member,
where the real members live.  This caught a pile of examples, and these have
beeen fixed.

The pdb_get..() functions are 'const' (have been for some time) and this
required a few small changes to constify other functions.

I've also added some debugs to the pdb get and set, they can be removed if

I've rewritten the copy_id2x_to_sam_pass() functions to use the new passdb
interface, but I need the flags info to do it properly.

The pdb_free_sam() funciton now blanks out the LM and NT hashes, and as such
I have removed many extra 'samr_clear_sam_passwd(smbpass)' calls as a result.

Finally, any and all testing is always appriciated - but the basics seem to

Andrew Bartlett
(This used to be commit d3dd28f6c443187b8d820d5a39c7c5b3be2fa95c)

20 years agoMake user enumeration work for w2k and win9x.
Jeremy Allison [Wed, 2 Jan 2002 07:27:33 +0000 (07:27 +0000)]
Make user enumeration work for w2k and win9x.
This means different return sizes depending on client bugs. This sucks :-(.
(This used to be commit f6592628eb526c487069bb3fcd809aca930e668e)

20 years agoAnother touch of 'const'
Andrew Bartlett [Wed, 2 Jan 2002 06:55:21 +0000 (06:55 +0000)]
Another touch of 'const'
(This used to be commit 3d812aacff98eec62c748cb89109a2e58806d92d)

20 years agoDoc.
Martin Pool [Wed, 2 Jan 2002 06:29:56 +0000 (06:29 +0000)]
(This used to be commit b354163834e0f2da7d3caacfe8d2ac6e2a6949e8)

20 years agoAlso capture received data
Martin Pool [Wed, 2 Jan 2002 06:08:02 +0000 (06:08 +0000)]
Also capture received data
(This used to be commit 93fadcd1118b390605d2504bee63a1e8b6373ac5)

20 years agostruct cli_state remembers the pipe name that it's talking to, if any,
Martin Pool [Wed, 2 Jan 2002 05:39:49 +0000 (05:39 +0000)]
struct cli_state remembers the pipe name that it's talking to, if any,
so that we can print it in later debug messages.

Call prs_dump to dump out requests sent by the client at sufficiently
high debug levels.
(This used to be commit 9973b22b34dc2a88a20b821d4e69f39d2a6aa6a3)

20 years agostruct cli_state remembers the pipe name that it's talking to, if any,
Martin Pool [Wed, 2 Jan 2002 05:38:09 +0000 (05:38 +0000)]
struct cli_state remembers the pipe name that it's talking to, if any,
so that we can print it in later debug messages.
(This used to be commit 37ae84f782e1de6fcea92acb2189683cdf8e7e92)

20 years agoMinor update to make the output 'real C'. (The output is intended to be a C
Andrew Bartlett [Wed, 2 Jan 2002 03:54:40 +0000 (03:54 +0000)]
Minor update to make the output 'real C'.  (The output is intended to be a C
format table for inclusion back into Samba).

Andrew Bartlett
(This used to be commit 95abb2473bb4f93df163a0e8af79d5292e1389b3)

20 years agoRemoved reference to rpc_client/cli_netlogon.o from dependencies for
Tim Potter [Wed, 2 Jan 2002 00:52:30 +0000 (00:52 +0000)]
Removed reference to rpc_client/cli_netlogon.o from dependencies for
samsync.  The libsmb version should do fine.
(This used to be commit 001fe3481f26e27964b3d60c067524b45f085304)

20 years agothe pdbedit tool manpage
Simo Sorce [Wed, 2 Jan 2002 00:40:47 +0000 (00:40 +0000)]
the pdbedit tool manpage
(This used to be commit 4aecb650e1ece234fb7359270deb74fe1c1a4a16)

20 years agotry to handle broken const in headers on cray unicos
Andrew Tridgell [Tue, 1 Jan 2002 06:55:33 +0000 (06:55 +0000)]
try to handle broken const in headers on cray unicos
(This used to be commit 8143052e6917d4ae774192ed463ea7359cf0a5fb)

20 years agoThis brings the NT->DOS error mapping into better line with what NT does.
Andrew Bartlett [Tue, 1 Jan 2002 06:16:43 +0000 (06:16 +0000)]
This brings the NT->DOS error mapping into better line with what NT does.

I'll post the changes to the actual map to the list for comment, but this fixes
the 'unknown' case.

Andrew Bartlett
(This used to be commit 024843a2cedb0b9f06a3351c5838caea372b6c5c)

20 years agoAdd a function to convert 'NT_STATUS...' strings back into their actual error
Andrew Bartlett [Tue, 1 Jan 2002 05:52:02 +0000 (05:52 +0000)]
Add a function to convert 'NT_STATUS...' strings back into their actual error

Andrew Bartlett
(This used to be commit f0089b089b319009576bb39a076397bb44aff628)

20 years agoAllow usernames in the form of 'NT_STATUS_....' to map to that as the error
Andrew Bartlett [Tue, 1 Jan 2002 05:51:03 +0000 (05:51 +0000)]
Allow usernames in the form of 'NT_STATUS_....' to map to that as the error
when using the 'name_to_ntstatus' auth module.

This could be useful in testing.

Andrew Bartlett
(This used to be commit 5cdc67d0bda8ef41305cae9c5be70d11593ffdd8)

20 years agoNow that winbind doesn't rely on this, we may as well remove it...
Andrew Bartlett [Tue, 1 Jan 2002 05:49:27 +0000 (05:49 +0000)]
Now that winbind doesn't rely on this, we may as well remove it...

Andrew Bartlett
(This used to be commit 6673fdda3cb6b90189d8f82274fdffa89f68101b)

20 years agoFurther rpc_client removal, this time from winbindd.
Andrew Bartlett [Tue, 1 Jan 2002 04:50:45 +0000 (04:50 +0000)]
Further rpc_client removal, this time from winbindd.

Also removed the dependency on auth_util.o, which makes things nicer.

makefile variable - becouse Samba dependencies are starting to be sane again!

Andrew Bartlett
(This used to be commit 4609edcac3b70c11025f0c5aa0ddbeed93369c84)

20 years agorenamed ans1.h to asn_1.h to prevent conflict caused by krb5 headers
Andrew Tridgell [Tue, 1 Jan 2002 04:05:10 +0000 (04:05 +0000)]
renamed ans1.h to asn_1.h to prevent conflict caused by krb5 headers
on some platforms using "" instead of <> in include statements
(This used to be commit d0ba307032340a22d77cb1d8fc78b4234e1a963c)

20 years agoA farily large commit:
Andrew Bartlett [Tue, 1 Jan 2002 03:10:32 +0000 (03:10 +0000)]
A farily large commit:

 - Move rpc_client/cli_trust.c to smbd/change_trust_pw.c
  - It hasn't been used by anything else since smbpasswd lost its -j

 - Add a TALLOC_CTX to the auth subsytem.  These are only valid for the length
   of the calls to the individual modules, if you want a longer context hide it
   in your private data.

   Similarly, all returns (like the server_info) should still be malloced.

 - Move the 'ntdomain' module (security=domain in oldspeak) over to use the new
   libsmb domain logon code.  Also rework much of the code to use some better
   helper functions for the connection - getting us much better error returns
   (the new code is NTSTATUS).

   The only remaining thing to do is to figure out if tpot's 0xdead 0xbeef for
   the LUID feilds is sufficient, or if we should do random LUIDs as per the old

   Similarly, I'll move winbind over to this when I get a chance.

This leaves the SPOOLSS code and some cli_pipe code as the only stuff still in
rpc_client, at least as far as smbd is concerned.

While I've given this a basic rundown, any testing is as always appriciated.

Andrew Bartlett
(This used to be commit d870edce76ecca259230fbdbdacd0c86793b4837)

20 years agoAdd a specialised version of tpot's libsmb samlogon code for use with
Andrew Bartlett [Tue, 1 Jan 2002 02:34:29 +0000 (02:34 +0000)]
Add a specialised version of tpot's libsmb samlogon code for use with
presupplied challange-response pairs, and only using the 'network' version.

This will be used to move the auth subsystem over to a libsmb (rather than
rpc_client) base.

Andrew Bartlett
(This used to be commit fe9d77791583737320f8c7560861168df7388c2f)

20 years agoFix up C99 comment.
Andrew Bartlett [Tue, 1 Jan 2002 02:31:32 +0000 (02:31 +0000)]
Fix up C99 comment.
// -> /* */
(This used to be commit a308abbab717df56b982adf1717da96603d2045f)

20 years agoNamed constants are always much better than magic numbers...
Andrew Bartlett [Tue, 1 Jan 2002 00:18:47 +0000 (00:18 +0000)]
Named constants are always much better than magic numbers...
(I defined the constants when I put in 'net rpc shutdown')

Andrew Bartlett
(This used to be commit 4d90cc1d991f3894b9f39b2a75078148834701bb)

20 years agolast_enum not used.
Jeremy Allison [Mon, 31 Dec 2001 23:24:48 +0000 (23:24 +0000)]
last_enum not used.
(This used to be commit efbec935fe727d5d5bd852c7bae9baf92df18686)

20 years agoFixed enumeration of a large (<1500) users from a Samba PDC to a W2k
Jeremy Allison [Mon, 31 Dec 2001 22:37:51 +0000 (22:37 +0000)]
Fixed enumeration of a large (<1500) users from a Samba PDC to a W2k
member server. Firstly, use the same max enumeration size (0x400) as W2K
uses, otherwise W2K won't ask for any more. Secondly, if a enumeration
request with a non-zero offset comes in on a handle that hasn't started
an enumeration, don't bitch about it (return NT_STATUS_UNSUCCESSFUL),
just load the db on that handle and return at that offset.
(This used to be commit 0b7da4a50ea02e28ab23e71de1e5f8b9194a9af3)

20 years agoadded a simple test to see whether building shared libraries actually
Andrew Tridgell [Mon, 31 Dec 2001 22:10:24 +0000 (22:10 +0000)]
added a simple test to see whether building shared libraries actually
(This used to be commit 3aeefbca4f272f57e83e753177ee6e8157b2dbd5)

20 years agoops, froget to set the values.
Simo Sorce [Mon, 31 Dec 2001 16:01:04 +0000 (16:01 +0000)]
ops, froget to set the values.
jerry, can you look at theis where we use standard_sub_advanced() fns?
I think this structure should be backported to 2.2 because we do not know if the SAM_ACCOUNT strings have enough space to contain the "substituted" string.
(Yes, just now we know they are pstrings, but we may change them into alloced one, I'm a strong suported of alloced strings as 1024 bytes are not always enough and are often too much)
(This used to be commit 29b3b5e9292805aa65e887755567abd50f74e5cb)

20 years agoconst religion
Simo Sorce [Mon, 31 Dec 2001 15:48:32 +0000 (15:48 +0000)]
const religion
(This used to be commit c0904d96170a9166b8cd405b75ce4a9bbc32ad1b)

20 years agoport mods from 2.2
Simo Sorce [Mon, 31 Dec 2001 15:48:03 +0000 (15:48 +0000)]
port mods from 2.2
(This used to be commit f796f18a83cd2fc0988612aa38c794f005efbfaf)

20 years agoreverted to 1.24 and manually merged in changes from 2.2
Gerald Carter [Mon, 31 Dec 2001 14:39:26 +0000 (14:39 +0000)]
reverted to 1.24 and manually merged in changes from 2.2
(This used to be commit 466f515240aaeca7b0fe2b7b3474ab23cab687cc)

20 years agocope with systems that don't have full gssapi libs
Andrew Tridgell [Mon, 31 Dec 2001 14:31:13 +0000 (14:31 +0000)]
cope with systems that don't have full gssapi libs
(This used to be commit c4d928e55fe99a3a1c4e53508a44949f92d74219)

20 years agomore irix -64 portability fixes
Andrew Tridgell [Mon, 31 Dec 2001 14:05:22 +0000 (14:05 +0000)]
more irix -64 portability fixes
(This used to be commit 65e857b36e170e3ecd78bf6695ae73342e9c04cd)

20 years ago- portablitity fixes for cc -64 on irix
Andrew Tridgell [Mon, 31 Dec 2001 13:46:26 +0000 (13:46 +0000)]
- portablitity fixes for cc -64 on irix
- fixed gid* bug in rpc_server
(This used to be commit 48aa90c48c5f0e3054c4acdc49668e222e7c0d36)

20 years agoEnsure the output cli can't have spurious values if the connection fails...
Andrew Bartlett [Mon, 31 Dec 2001 13:06:10 +0000 (13:06 +0000)]
Ensure the output cli can't have spurious values if the connection fails...
(This used to be commit 2d1612dd3560bb5ef35fa1eeee00e3d7976bcd62)

20 years agoAdd 'net rpc shutdown' and 'net rpc abortshutdown'.
Andrew Bartlett [Mon, 31 Dec 2001 13:00:59 +0000 (13:00 +0000)]
Add 'net rpc shutdown' and 'net rpc abortshutdown'.

These two little features are very useful, but the passing of options about
needs some serious work.  The popt stuff in the shutdown code is #ifdef'ed out
until the main popt loop can be convinced not to chew on the options :-(

Andrew Bartlett
(This used to be commit 51c985be7fbfe5627c5b2590e7610653e7be98e3)

20 years agoFix up the comment in the copyright header
Andrew Bartlett [Mon, 31 Dec 2001 12:50:44 +0000 (12:50 +0000)]
Fix up the comment in the copyright header
(This used to be commit 45042bef7cdede6f991572677654903bbf7d9144)

20 years agoGive the main loop talloc context a name (using mbp's new talloc naming
Andrew Bartlett [Mon, 31 Dec 2001 12:41:24 +0000 (12:41 +0000)]
Give the main loop talloc context a name (using mbp's new talloc naming

Andrew Bartlett
(This used to be commit f0c301a12eb142add488a2da55591269dfc15f77)

20 years agoMake --with-tdbsam compile again, given the new 'am I setting a default' flags.
Andrew Bartlett [Mon, 31 Dec 2001 11:25:48 +0000 (11:25 +0000)]
Make --with-tdbsam compile again, given the new 'am I setting a default' flags.

Andrew Bartlett
(This used to be commit 20d7c5d9b9bc0a426897f21b3350933602abdbf1)

20 years agoAllow this to build without LDAP, as per the example below it.
Andrew Bartlett [Mon, 31 Dec 2001 11:14:38 +0000 (11:14 +0000)]
Allow this to build without LDAP, as per the example below it.

Andrew Bartlett
(This used to be commit f60e4450018fc06c9f8ce18e62c29fd968d55daa)

20 years agofix compile error
Gerald Carter [Mon, 31 Dec 2001 02:04:08 +0000 (02:04 +0000)]
fix compile error
(This used to be commit c946c6bbc8192f5f0f3706d1b4a6cca0a994f36b)

20 years agoremoved extern samlogon_user
Gerald Carter [Mon, 31 Dec 2001 01:56:05 +0000 (01:56 +0000)]
removed extern samlogon_user
(This used to be commit a7dc0febe4285b70d3ff5b27505b2681731bfba1)

20 years agoremove samlogon_user
Gerald Carter [Mon, 31 Dec 2001 00:09:15 +0000 (00:09 +0000)]
remove samlogon_user
(This used to be commit a5f4559b2aade54f1c0f717eea21881f482faff2)

20 years agosome merges from 2.2. Still need to merge in changes from pdb_tdb.c
Gerald Carter [Mon, 31 Dec 2001 00:06:51 +0000 (00:06 +0000)]
some merges from 2.2.  Still need to merge in changes from pdb_tdb.c
but it will take more time as I don't want to loose any fixes that
are only in HEAD.
(This used to be commit efcde5d9d8ce44c0613764504d797be54ba21473)

20 years agofreeing the wrong pointer, sorry my mistake.
Simo Sorce [Sun, 30 Dec 2001 22:55:04 +0000 (22:55 +0000)]
freeing the wrong pointer, sorry my mistake.
(This used to be commit ce7e89949ae1755f9faa008784a5b1a9b137945e)

20 years agoUnicode byte ording fix from Benjamin Kuit <>
Tim Potter [Sun, 30 Dec 2001 21:25:46 +0000 (21:25 +0000)]
Unicode byte ording fix from Benjamin Kuit <>
(This used to be commit 6b7e9d03cf6093f1108642deddb0f8cc42e59067)

20 years agoutil_sid.c - respect a const variabile (addedd strdup)
Simo Sorce [Sun, 30 Dec 2001 19:21:25 +0000 (19:21 +0000)]
util_sid.c - respect a const variabile (addedd strdup)
cli_reg.c  - indentation
pdb_ldap.c - some checks on init fns parameters
pdb_tdb.c  - some checks on init fns parameters + make sure we close the db on failure
(This used to be commit 49f5cb7a3df6d673f86e6769319aa657e30d8380)

20 years agoAdd a pile of doxygen style comments to various parts of Samba. Many of these
Andrew Bartlett [Sun, 30 Dec 2001 10:54:58 +0000 (10:54 +0000)]
Add a pile of doxygen style comments to various parts of Samba.  Many of these
probably will never actually be genearted, but I like the style in any case.

Also fix a segfault in 'net rpc' when the login failed and a small memory leak
on failure in the auth_info.c code.

Andrew Bartlett
(This used to be commit 2efae7cc522651c22fb120835bc800645559b63e)

20 years agoFinally remove these files, which moved (by cvs backend magic) to source/auth
Andrew Bartlett [Sun, 30 Dec 2001 10:50:46 +0000 (10:50 +0000)]
Finally remove these files, which moved (by cvs backend magic) to source/auth
at the start of the month.
(This used to be commit 30ef625897cd025e1895c932b55dee027f060413)

20 years agoFinish idra's cleanup of the RPC remote shutdown code.
Andrew Bartlett [Sun, 30 Dec 2001 10:19:56 +0000 (10:19 +0000)]
Finish idra's cleanup of the RPC remote shutdown code.
(This used to be commit 79031b68ce6bdf882d9c9bd4f3310f597e0c1fda)

20 years agoremove unneaded memory leaking code.
Simo Sorce [Sun, 30 Dec 2001 08:37:34 +0000 (08:37 +0000)]
remove unneaded memory leaking code.
(This used to be commit d2c663185e13974f953a60adf1b191b56bfa08f4)

20 years agoFix the compile on systems without a full kerberos kit.
Andrew Bartlett [Sun, 30 Dec 2001 06:20:23 +0000 (06:20 +0000)]
Fix the compile on systems without a full kerberos kit.

Andrew Bartlett
(This used to be commit 33ae29028bffccf5a9cdd8d44b08c27b9d8fd982)

20 years agoMake Samba compile on RH 6.2 again.
Andrew Bartlett [Sun, 30 Dec 2001 05:59:43 +0000 (05:59 +0000)]
Make Samba compile on RH 6.2 again.

We now include the libber.h file if required, but currently we just don't use
ldap.  (I'll chase this up).

In the meantime, I've moved the ads_status code about, its now in its own file,
and has a couple of #ifdefs to allow smbd to link - becouse the lack of LDAP
caused HAVE_ADS to be undefined. (I hope its not too ugly).

Andrew Bartlett
(This used to be commit 14407c87e2dcccae1784290e3eb7a2d611516aff)

20 years agoWhen running interactive we want to set our own process group for
Jeremy Allison [Sun, 30 Dec 2001 01:46:38 +0000 (01:46 +0000)]
When running interactive we want to set our own process group for
signal management.
(This used to be commit fffae94dd5699f44c0b1c8081587deafd89b3fc0)

20 years agopdb_getsampwnuid() merge from 2.2
Gerald Carter [Sun, 30 Dec 2001 00:03:47 +0000 (00:03 +0000)]
pdb_getsampwnuid() merge from 2.2
(This used to be commit 54cbfc7ebcdf1bd2094407b689b0050f0abfa46f)

20 years agoDocumented -i modes for nmbd/smbd.
Jeremy Allison [Sat, 29 Dec 2001 21:15:40 +0000 (21:15 +0000)]
Documented -i modes for nmbd/smbd.
(This used to be commit a076e2e4c512cd2ef2f9c38447c44d93e4b6ac57)

20 years agoFixup -i interactive modes.
Jeremy Allison [Sat, 29 Dec 2001 21:13:53 +0000 (21:13 +0000)]
Fixup -i interactive modes.
(This used to be commit 9343b613d3778b0330bc4d610d3befd363797360)

20 years agoRemoved extra lp_adduser() call.
Jeremy Allison [Sat, 29 Dec 2001 20:29:43 +0000 (20:29 +0000)]
Removed extra lp_adduser() call.
Fixed up error returns in get_correct_cversion().
(This used to be commit 7ce2d1fe37d2be26c407f3dc9427851d00ca216a)

20 years agofile Samba-LDAP-HOWTO.sgml was initially added on branch SAMBA_2_2.
Gerald Carter [Sat, 29 Dec 2001 16:20:49 +0000 (16:20 +0000)]
file Samba-LDAP-HOWTO.sgml was initially added on branch SAMBA_2_2.
(This used to be commit d57c43fd05d8759f09c8c460baeb513a8ed41479)

20 years agopassing NULL to print_queue_status()'s status parameter could end in a segfault
Simo Sorce [Sat, 29 Dec 2001 09:52:24 +0000 (09:52 +0000)]
passing NULL to print_queue_status()'s status parameter could end in a segfault
(This used to be commit 79254d2b0490ba400832ef6d460895d45cc4273f)

20 years agoremoved unused files
Gerald Carter [Fri, 28 Dec 2001 02:28:39 +0000 (02:28 +0000)]
removed unused files
(This used to be commit c6d867b55273167a0adaeb979062752edeb09549)

20 years agomerge from 2.2
Gerald Carter [Fri, 28 Dec 2001 02:03:36 +0000 (02:03 +0000)]
merge from 2.2
(This used to be commit 241b5218ea5ad83ecb02a0f838e84abee0672371)

20 years agomoving SAM_ACCOUNT to include a bit field for initialized
Gerald Carter [Thu, 27 Dec 2001 06:38:04 +0000 (06:38 +0000)]
moving SAM_ACCOUNT to include a bit field for initialized
members (such as uid and gid).  This way we will be able to
keep ourselves from writing out default smb.conf settings when
the admin doesn't want to,  That part is not done yet.

Tested compiles with ldap/tdb/smbpasswd.  Tested connection with smbpasswd

oh...and smbpasswd doesn'y automatically expire accounts after 21 days
from the last password change either now.  Just ifdef'd out that code
in build_sam_account().

Will merge updates into 2.2 as they are necessary.

(This used to be commit f0d43791157d8f04a13a07d029f203ad4384d317)

20 years agosync with 2.2
Gerald Carter [Wed, 26 Dec 2001 05:35:40 +0000 (05:35 +0000)]
sync with 2.2
(This used to be commit aca58b0b72d2eb5024b4d5103fde5b281212d714)

20 years agomerge Jeremy's gcc3 warning fix from 2.2
Herb Lewis [Sat, 22 Dec 2001 01:15:58 +0000 (01:15 +0000)]
merge Jeremy's gcc3 warning fix from 2.2
(This used to be commit 52e9d2c383371e64e498bbdb4a3f0e8583ca77a0)

20 years agosync up packaging scripts
Herb Lewis [Sat, 22 Dec 2001 00:54:10 +0000 (00:54 +0000)]
sync up packaging scripts
(This used to be commit 3999e13ef89acd51df4cf215959eccd6217c86e3)

20 years agomerge IRIX winbind support from Samba 2.2 branch
Herb Lewis [Sat, 22 Dec 2001 00:51:32 +0000 (00:51 +0000)]
merge IRIX winbind support from Samba 2.2 branch
(This used to be commit 20c5f042e3bb79ff96a993c70b843908dcfafb65)

20 years agoRemoved unused variables.
Jeremy Allison [Fri, 21 Dec 2001 23:28:04 +0000 (23:28 +0000)]
Removed unused variables.
(This used to be commit 621fa227bdf6af15daa13f62287978dc2310c04c)

20 years agoThe jf_get_sampasswd_entries() is not used anymore.
Jeremy Allison [Fri, 21 Dec 2001 23:25:32 +0000 (23:25 +0000)]
The jf_get_sampasswd_entries() is not used anymore.
(This used to be commit bf1816099707b816c9b62ad5ab794dc49b833181)

20 years agoadded a copyright notice.
Jean-François Micouleau [Fri, 21 Dec 2001 22:54:53 +0000 (22:54 +0000)]
added a copyright notice.

(This used to be commit 87928c4d91940447191af4fe83a2be7ac3477361)

20 years agodoesn't keep track of the struct's size we enumerate. W2K doesn't
Jean-François Micouleau [Fri, 21 Dec 2001 22:34:49 +0000 (22:34 +0000)]
doesn't keep track of the struct's size we enumerate. W2K doesn't
calculate them and always reply a size of 32 bytes whereas NT4 did the
maths. Anyway, it looks like the clients don't complain.

in query_dom_info() at level 2, return the real number of users and
groups. That's the fix to the W95/98 userlist bug !

as W95/98 does a query_dom_info(2) followed by a query_disp_info(4) on
the SAME context handle (err we call it an lsa policy handle ! plain
wrong name), I was tempted to keep the snapshoot in memory, to prevent
2 full user db enumerations in a row and just have one shared. But if some
client does the 2 calls on two different handles, we would have 2 copies
in memory not free'ed before the samr_close().

We still have too many fixed constant and too many magic values in that
code. And btw, I really hates how the sequence number is generated !

(This used to be commit c0178e1a03f8225e5b350feb8fcbfb02f43327b4)

20 years agoFixup some DEBUG statements (0 -> 10).
Jeremy Allison [Fri, 21 Dec 2001 22:27:20 +0000 (22:27 +0000)]
Fixup some DEBUG statements (0 -> 10).
(This used to be commit bf65331cb49299189d35ad5834167ec24b3a1ecb)

20 years agoclose some handles. not really necessary but doesn't hurt.
Jean-François Micouleau [Fri, 21 Dec 2001 22:18:06 +0000 (22:18 +0000)]
close some handles. not really necessary but doesn't hurt.

(This used to be commit 55b9cd7af611e5f76896e1849529629e5e7caaf8)

20 years agomerge from 2.2
Gerald Carter [Fri, 21 Dec 2001 20:04:22 +0000 (20:04 +0000)]
merge from 2.2
(This used to be commit 6697e46183719c894ec115c0fd8a18ad4191b347)

20 years agoUse pdb_free_sam() to free a SAM_ACCOUNT struct, not safe_free(). There
Jeremy Allison [Fri, 21 Dec 2001 19:34:32 +0000 (19:34 +0000)]
Use pdb_free_sam() to free a SAM_ACCOUNT struct, not safe_free(). There
are pointers withing the SAM_ACCOUNT struct that also need freeing.
(This used to be commit a7d099cc75f813b4010a5f313c3fa6e6e8284b6d)

20 years agoadded all level to samr_query_disp_info rpcclient side.
Jean-François Micouleau [Fri, 21 Dec 2001 13:38:07 +0000 (13:38 +0000)]
added all level to samr_query_disp_info rpcclient side.

(This used to be commit d5f2e645e43224b966c17c593fff33b64d6c0a8b)

20 years agoLarge expansion of my german book project.
Volker Lendecke [Fri, 21 Dec 2001 13:37:39 +0000 (13:37 +0000)]
Large expansion of my german book project.

(This used to be commit 768f90a6ca8538ffda5b46491281eea7673ae730)

20 years agore-done all of samr_query_disp_info()
Jean-François Micouleau [Fri, 21 Dec 2001 13:36:14 +0000 (13:36 +0000)]
re-done all of samr_query_disp_info()
instead of enumerating the whole user db or group db every time, we store
a in memory copy linked to the handle.

that's much faster for large enumeration where the db can't fit in a
single rpc packet. And as it's a copy, it's constant between enumeration.

still some stuff to clean. But now I can fix the W95 userlist bug, as I've
finally found it.

(This used to be commit 3ab45215369e8e93d750f4687e9c1f7d47782590)

20 years agoput back the -l option to rpcclient.
Jean-François Micouleau [Fri, 21 Dec 2001 13:30:55 +0000 (13:30 +0000)]
put back the -l option to rpcclient.
that's the most useful option in this tool !

I love rpcclient ;-)

(This used to be commit 18dc4cd57a53480684ea9e2bc6a6442535f89119)

20 years ago- handle kerberos session setup reply with broken null termination
Andrew Tridgell [Fri, 21 Dec 2001 12:29:51 +0000 (12:29 +0000)]
- handle kerberos session setup reply with broken null termination
- don't display Domain=[] for auth protocols that don't give us a domain
(This used to be commit 20368455ea59e6e9b85632848bbe92069e7b0f38)

20 years agotry to handle end of packet for not null terminated domain strings
Andrew Tridgell [Fri, 21 Dec 2001 11:58:30 +0000 (11:58 +0000)]
try to handle end of packet for not null terminated domain strings
(This used to be commit 1da988456dbd885820093ae43c74e0ac66f72802)

20 years agoupdated ldap test to test for less common function
Andrew Tridgell [Fri, 21 Dec 2001 11:20:59 +0000 (11:20 +0000)]
updated ldap test to test for less common function
(This used to be commit 831f25a9a7ef3f5481c531b3a5ff514fa8b6d81e)

20 years agofixed a typo in vsyslog()
Andrew Tridgell [Fri, 21 Dec 2001 11:04:14 +0000 (11:04 +0000)]
fixed a typo in vsyslog()
(This used to be commit da353bc539db6e2f8d834275abdd9b5fb47b9db8)

20 years agoremove duplicate lines
Herb Lewis [Fri, 21 Dec 2001 05:13:36 +0000 (05:13 +0000)]
remove duplicate lines
(This used to be commit b60d6f11972892a17bf6df5e7ee3dd2e498bc4c0)

20 years agosmbcontrol in non-interactive mode was returning True for success --
Martin Pool [Fri, 21 Dec 2001 04:33:28 +0000 (04:33 +0000)]
smbcontrol in non-interactive mode was returning True for success --
need to invert this to give the shell 0.
(This used to be commit ecc624067c54314834aacbf21d0f2ee54fce37e9)

20 years agoAdd option to pass NULL max_replies to wait_for_replies in case you
Martin Pool [Fri, 21 Dec 2001 04:30:58 +0000 (04:30 +0000)]
Add option to pass NULL max_replies to wait_for_replies in case you
don't know how many to expect.
(This used to be commit 53f1c0298b526dcacae956453a4b95fff226d0b8)

20 years agoAdd code to send MSG_REQ_POOL_USAGE. (smbd doesn't respond yet.)
Martin Pool [Fri, 21 Dec 2001 04:28:03 +0000 (04:28 +0000)]
Add code to send MSG_REQ_POOL_USAGE.  (smbd doesn't respond yet.)

Factor out common code to wait until replies are received or timeout

Show debug message when messages are sent.
(This used to be commit 17bb0f60af13c5d0561c0ba50b0a6331bde52e8f)

20 years agoAppend to log.winbindd instead of overwriting it so we are consistent with
Tim Potter [Fri, 21 Dec 2001 02:23:38 +0000 (02:23 +0000)]
Append to log.winbindd instead of overwriting it so we are consistent with
smbd/nmbd behaviour.
(This used to be commit 54d276561524213302e7bb2d759d7d4082fd6e8a)

20 years agoFix for null command description in rpcclient help. From Benjamin Kuit
Tim Potter [Fri, 21 Dec 2001 01:16:37 +0000 (01:16 +0000)]
Fix for null command description in rpcclient help.  From Benjamin Kuit
(This used to be commit 60d1d0bfa93bfb8264b117147b651b521dbf28ce)

20 years agoAdd an output parameter to message_send_all that says how many
Martin Pool [Fri, 21 Dec 2001 00:37:49 +0000 (00:37 +0000)]
Add an output parameter to message_send_all that says how many
messages were sent, so you know how many replies to expect.

Const and doc religion.
(This used to be commit 22e510ea0d69356be4fd2fa5ad9e9f4e84f62337)

20 years agoFactor out a broadcast_printer_notify() routine.
Martin Pool [Fri, 21 Dec 2001 00:37:09 +0000 (00:37 +0000)]
Factor out a broadcast_printer_notify() routine.
(This used to be commit d32598c953e7a500f707a02608c44203bc5941ec)