17 years agoChange check_path_syntax() to use the new next_mb_char_size() function
Jeremy Allison [Wed, 17 Mar 2004 02:08:31 +0000 (02:08 +0000)]
Change check_path_syntax() to use the new next_mb_char_size() function
to make it generic. Remove the mb-codepage "blacklist". Alexander, please
check this fix as it reverts your blacklist changes, but I'm hoping it
fixes the problem in a more generic way for all charsets. I'm not trying
to trample on your (excellent!) work here, just make things more generic
without special cases.
(This used to be commit 5a9324525acc02e6bf14528679816b35929a564e)

17 years agoAdd function next_mb_char_size() that returns a size_t of the number of
Jeremy Allison [Tue, 16 Mar 2004 21:59:11 +0000 (21:59 +0000)]
Add function next_mb_char_size() that returns a size_t of the number of
bytes in the mb character at a pointer. Will be useful in fixing check_path_syntax()
to not use a "blacklist". Also re-added my (C) to reply.c. I mean, really - I've
been adding code to the file for over 10 years and I recognise many of the
fuctions as mine ! :-).
(This used to be commit d2b2a39fd2f2e06cc4aebf081876985f0b28b477)

17 years agofix overlapping memory bug when copying username
Gerald Carter [Tue, 16 Mar 2004 20:28:47 +0000 (20:28 +0000)]
fix overlapping memory bug when copying username
(This used to be commit a7cac639c2cf0e2606d9cfbdb08e961212ee3bfa)

17 years agoBUG 748 - patch from (James Peach); relax arg parsing to sambalp script
Gerald Carter [Tue, 16 Mar 2004 19:44:40 +0000 (19:44 +0000)]
BUG 748 - patch from (James Peach); relax arg parsing to sambalp script
(This used to be commit e2361da91f58e123c900f989b0afe94e93387a5d)

17 years agoBUG 768 - patch from (James Peach); accept profileing arg to init...
Gerald Carter [Tue, 16 Mar 2004 19:43:04 +0000 (19:43 +0000)]
BUG 768 - patch from (James Peach); accept profileing arg to init script
(This used to be commit a04573aeb0a137feb4be48b74627536e1f0d40b1)

17 years agoBUG 979 -- fix quota display on AIX; patch from (Heinric...
Gerald Carter [Tue, 16 Mar 2004 19:06:03 +0000 (19:06 +0000)]
BUG 979 -- fix quota display on AIX; patch from (Heinrich Mislik)
(This used to be commit 760b63496ccc908c76ea5d3ed474cbbca268ad61)

17 years agoBUG 1182: patch from (John Klinger) to reanable the -n 'no...
Gerald Carter [Tue, 16 Mar 2004 18:54:09 +0000 (18:54 +0000)]
BUG 1182: patch from (John Klinger) to reanable the -n 'no cache' option for winbindd
(This used to be commit d1848988d9ee9fdd870bcdd32c938b907419558b)

17 years agoFix check_path_syntax() for multibyte encodings which have no '\' as second byte.
Alexander Bokovoy [Tue, 16 Mar 2004 17:18:57 +0000 (17:18 +0000)]
Fix check_path_syntax() for multibyte encodings which have no '\' as second byte.
This is intermediate fix as discussed with Jeremy until we move check_path_syntax() to UCS2 internally where all
ambiguity is resolved. Please add other encodings into charcnv.c with such property.'
(This used to be commit 2c404f6ba988d68c6f44df9409c0de319553de10)

17 years agomerging print change notify fix from HP appliance. Also might address some one the...
Gerald Carter [Tue, 16 Mar 2004 17:06:11 +0000 (17:06 +0000)]
merging print change notify fix from HP appliance.  Also might address some one the issues in BUG 1007
(This used to be commit 17ecea4152fb0883acde675b01f19d3e19ff1d64)

17 years agoBUG 1165, 1126: Fix bug with secondary groups (security = ads) and winbind use defaul...
Gerald Carter [Tue, 16 Mar 2004 16:41:54 +0000 (16:41 +0000)]
BUG 1165, 1126: Fix bug with secondary groups (security = ads) and winbind use default domain = yes
(This used to be commit f2eaa14b1eb7e89c945b2b06a48e17998c75d620)

17 years agoAvoid mb conversion overflow when sending an announcement.
Jeremy Allison [Tue, 16 Mar 2004 00:10:30 +0000 (00:10 +0000)]
Avoid mb conversion overflow when sending an announcement.
(This used to be commit 188e1daaffb3b21abc250ebb37d9a671ba51d054)

17 years agoUse "unix netbios name" type unstring - 64 bytes long to manipulate netbios
Jeremy Allison [Mon, 15 Mar 2004 21:45:45 +0000 (21:45 +0000)]
Use "unix netbios name" type unstring - 64 bytes long to manipulate netbios
names in nmbd. Allows conversion from dos codepage mb strings (ie. SJIS) to
expand to utf8 size on read.
(This used to be commit 834d816caf9cd6318da00febde50d9233469dac2)

17 years agoremoving extra comma in --with-fhs
Gerald Carter [Mon, 15 Mar 2004 16:20:03 +0000 (16:20 +0000)]
removing extra comma in --with-fhs
(This used to be commit 12f3f0268c49c9393ff4cd97cfcd802e6b61bbea)

17 years agoinclude swatdir in 'make showlayout'
Gerald Carter [Mon, 15 Mar 2004 16:14:04 +0000 (16:14 +0000)]
include swatdir in 'make showlayout'
(This used to be commit b1115c0fc507e82d828ccbb5853734a964701cd2)

17 years agofix byte ordering problem when storing the updating pid for the lpq cache; was causin...
Gerald Carter [Mon, 15 Mar 2004 15:06:33 +0000 (15:06 +0000)]
fix byte ordering problem when storing the updating pid for the lpq cache; was causing an abort in process_exists() on solaris
(This used to be commit 26681cd2a1567d90cc7d344e8aca6e6a686053f5)

17 years agoWhen trying to remove a user from a group, winbind should be informed
Volker Lendecke [Sun, 14 Mar 2004 07:15:39 +0000 (07:15 +0000)]
When trying to remove a user from a group, winbind should be informed
about the user and group...

(This used to be commit 9fa2c4045252f07cc0518457d8ef8b81d8402327)

17 years agoUse possessive in message asking for user's password.
Tim Potter [Sun, 14 Mar 2004 03:47:03 +0000 (03:47 +0000)]
Use possessive in message asking for user's password.
(This used to be commit cc9765ce97b65bb7a6cd44e847a690d3fbe9d032)

17 years agoEnsure we don't truncate strcmps to nstring anymore...
Jeremy Allison [Sat, 13 Mar 2004 02:47:21 +0000 (02:47 +0000)]
Ensure we don't truncate strcmps to nstring anymore...
(This used to be commit d7cf64b1e4e501bcd01ddc8279babc65d894a4b3)

17 years agoModified fix for bugid #784. Based on a patch from (MORIYAM...
Jeremy Allison [Sat, 13 Mar 2004 02:16:21 +0000 (02:16 +0000)]
Modified fix for bugid #784. Based on a patch from (MORIYAMA Masayuki).
Don't use nstrings to hold workgroup and netbios names. The problem with them is that MB netbios
and workgroup names in unix charset (particularly utf8) may be up to 3x bigger than the name
when represented in dos charset (ie. cp932). So go back to using fstrings for these but
translate into nstrings (ie. 16 byte length values) for transport on the wire.
(This used to be commit b4ea493599ab414f7828b83f40a5a8b43479ff64)

17 years agoFirst part of patch from (MORIYAMA Masayuki) to
Jeremy Allison [Sat, 13 Mar 2004 00:28:53 +0000 (00:28 +0000)]
First part of patch from (MORIYAMA Masayuki) to
fix up netbios names with mb strings. Includes reformat of libsmb/nmblib.c
so it's readable.
(This used to be commit 966e49a48c352563cdd7f75fe2768f2d6612ec7e)

17 years agoif we are truncating to the . we need to start at the beginning in case
Herb Lewis [Fri, 12 Mar 2004 21:35:15 +0000 (21:35 +0000)]
if we are truncating to the . we need to start at the beginning in case
there are multiple "."'s in the name.

This code is protected with an #ifdef TRUNCATE_NETBIOS_NAME and this
is #define'd to 1 directly above. Should we also get rid of the #ifdef?
(This used to be commit 0375dace248eb3dc660fa2bca2808552e502b3f7)

17 years agoFix from (Robert Dahlem) for bugid #1048
Jeremy Allison [Fri, 12 Mar 2004 20:24:05 +0000 (20:24 +0000)]
Fix from (Robert Dahlem) for bugid #1048
when mangled names are turned off.
(This used to be commit 29909ce26ac9a0d8e631b1ed884c525674ee5606)

17 years agoFix problems with very long filenames in both smbd and smbclient.
Alexander Bokovoy [Fri, 12 Mar 2004 14:37:37 +0000 (14:37 +0000)]
Fix problems with very long filenames in both smbd and smbclient.
It appears that we pass filename through resolve_wildcards() as pstring and use fstring temporary buffer there.
As result, a long filename in unix charset (UTF-8 by default) can easily expand over 255 bytes while
Windows is able to send to us such names (e.g. Japanese name of ~190 mb chars) which we unable to process through
this small fstring buffer. Tested with W2K and smbclient, Japanese and Cyrillics.
(This used to be commit 83dac6571f99b854ac607d4313cc3f742c1fae2e)

17 years agoFix build after Jeremy -- yet another place where convert_string() wasn't updated
Alexander Bokovoy [Fri, 12 Mar 2004 12:57:39 +0000 (12:57 +0000)]
Fix build after Jeremy -- yet another place where convert_string() wasn't updated
(This used to be commit 9acd46ab462cb4aee9938658dda594ef8b8ddcbd)

17 years agoFix string overflow due to wrong size calculation
Alexander Bokovoy [Fri, 12 Mar 2004 11:21:50 +0000 (11:21 +0000)]
Fix string overflow due to wrong size calculation
(This used to be commit e1d0b8fc7bbe075dd817e3816f29640cda980732)

17 years agoAllow msdfs symlink syntax to be more forgiving (it took me ages to remember
Jeremy Allison [Fri, 12 Mar 2004 01:43:25 +0000 (01:43 +0000)]
Allow msdfs symlink syntax to be more forgiving (it took me ages to remember
what it was :-). Allow msdfs links to now look like UNC paths : eg.
sym_link -> msdfs://server/share/path/in/share
or :
sym_link -> msdfs:\\server\share\path\in\share
(This used to be commit 2979c3e388400fb030b94da5c711f803f81ae0b9)

17 years agoRestore the contract on all convert_stringXX() interfaces. Add a "allow_bad_conv"
Jeremy Allison [Thu, 11 Mar 2004 22:48:24 +0000 (22:48 +0000)]
Restore the contract on all convert_stringXX() interfaces. Add a "allow_bad_conv"
boolean parameter that allows broken iconv conversions to work. Gets rid of the
nasty errno checks in mangle_hash2 and check_path_syntax and allows correct
return code checking.
(This used to be commit 7b96765c23637613f079d37566d95d5edd511f05)

17 years agoGet MungedDial actually working with full TS strings in it for pdb_ldap.
Jim McDonough [Thu, 11 Mar 2004 16:32:19 +0000 (16:32 +0000)]
Get MungedDial actually working with full TS strings in it for pdb_ldap.
I know this isn't pretty, but neither was our assumption that all strings
from the directory fit inside a pstring.  There was no way this worked
before will all versions of usrmgr (for example, the only version of
mine that has the TS Confic button).
(This used to be commit d275c0e384db08c2a6efc28e52844f676ff71fb6)

17 years agoadd missing #ifdef HAVE_BICONV stuff
Herb Lewis [Thu, 11 Mar 2004 15:12:59 +0000 (15:12 +0000)]
add missing #ifdef HAVE_BICONV stuff
(This used to be commit 9ea0560b0b62dbefaedd640cf9f4f58a0d337abe)

17 years agoBUG 1088: patch from SATOH Fumiyasu <> -- use strchr_m() for...
Gerald Carter [Thu, 11 Mar 2004 14:39:32 +0000 (14:39 +0000)]
BUG 1088: patch from SATOH Fumiyasu <> -- use strchr_m() for query_host (smbclient -L)
(This used to be commit bc6992c4bffed043dd8ad58d721202091cd14cd3)

17 years agoEnsure we use check_path_syntax() to pull out DFS paths.
Jeremy Allison [Thu, 11 Mar 2004 00:42:33 +0000 (00:42 +0000)]
Ensure we use check_path_syntax() to pull out DFS paths.
(This used to be commit 28f1e21c583ea9a7771d6e0134b09a7acd5f054d)

17 years agoFix processing of pathnames with embedded '\\' characters (0x5c) in CP932
Jeremy Allison [Thu, 11 Mar 2004 00:31:47 +0000 (00:31 +0000)]
Fix processing of pathnames with embedded '\\' characters (0x5c) in CP932
character set. Because of the allowing of "broken conversions" for people
who have broken iconv libraries we can't rely on the return from convert_string()
to be valid - we must check errno instead. This is ripe for revisiting at
some stage. I prefer adding a bool parameter to all convert_string_XX varients
to specify if we will allow broken conversions or not. With "allow_broken_conversions"
set to false we could then rely on the return from convert_string rather than
checking errno.
(This used to be commit 74722f28659ac369676e898fda48d3d9ab265045)

17 years agoanother typo
Herb Lewis [Wed, 10 Mar 2004 03:08:14 +0000 (03:08 +0000)]
another typo
(This used to be commit e6c2d9a3f7b5e427c6e7139726160d79e1dfc16d)

17 years agoMoving towards getting msdfs working again (this looks like it was broken
Jeremy Allison [Wed, 10 Mar 2004 02:38:39 +0000 (02:38 +0000)]
Moving towards getting msdfs working again (this looks like it was broken
in 3.0.2a actually). We now send a correct referral back, but the client
refuses to follow it... Not sure why. Will do more tests.. Maybe unicode
character count is wrong (it looks it).
(This used to be commit e2709f99fc4e603897472d3ba3bf1ca2e7ca728f)

17 years agoFormatting reformat before I start to change anything here.
Jeremy Allison [Wed, 10 Mar 2004 01:32:26 +0000 (01:32 +0000)]
Formatting reformat before I start to change anything here.
(This used to be commit 80fde09fc4a5d7e72611fd587777151adc5c890d)

17 years agofix typo for tag in proto file
Herb Lewis [Wed, 10 Mar 2004 00:53:36 +0000 (00:53 +0000)]
fix typo for tag in proto file
(This used to be commit 2367d988ae8d33397cd255d39100ae5791401558)

17 years agoFix dfs referrals - don't use check_path_syntax. Also use mb char calls in
Jeremy Allison [Tue, 9 Mar 2004 23:26:58 +0000 (23:26 +0000)]
Fix dfs referrals - don't use check_path_syntax. Also use mb char calls in
dfs code.
(This used to be commit 42175b4518764e484d33d9fbfba3b78ba4102ead)

17 years agoYet another '\n' termination of debug message.
Rafal Szczesniak [Tue, 9 Mar 2004 21:47:49 +0000 (21:47 +0000)]
Yet another '\n' termination of debug message.

(This used to be commit 3e57c2c6850655da77e25de4cb047cc27741ca9c)

17 years agoFix to debug message lacking termination with '\n'.
Rafal Szczesniak [Tue, 9 Mar 2004 18:58:19 +0000 (18:58 +0000)]
Fix to debug message lacking termination with '\n'.

(This used to be commit 2a7dd469430459d124cb48d516b82766a2a249bc)

17 years agofix build with gcc 2.96 and --with-developer
Gerald Carter [Tue, 9 Mar 2004 15:29:16 +0000 (15:29 +0000)]
fix build with gcc 2.96 and --with-developer
(This used to be commit 11fc4da07f232c38e04c6443e5d0f829e16b0a18)

17 years agoGiven how core this code is, I figure it should have it's own testsuite.
Andrew Bartlett [Tue, 9 Mar 2004 11:15:44 +0000 (11:15 +0000)]
Given how core this code is, I figure it should have it's own testsuite.

Big thanks to tpot and mbp for showing how easy it can be to write a simple
unit test, and for providing the STF.

This also changes the strstr_m() code to use strstr_w() (avoiding
duplication) and fixes it so that it passes the STF.

(We now always restart before doing the unicode run, until sombody can
show me why the testsuite is wrong).

Andrew Bartlett
(This used to be commit a893a324f37e6a171719db8ffffe66df31c2dbaa)

17 years agoJRA's recent strstr_m work really badly broke our string_sub code.
Andrew Bartlett [Tue, 9 Mar 2004 09:56:33 +0000 (09:56 +0000)]
JRA's recent strstr_m work really badly broke our string_sub code.

For example:

strstr_m("%v foo bar", "%v") would fail...

only strstr_m("foo %v", "%v") could work.

I wonder what else this broke...

Fix is to move to using strncmp() inside the strstr_m function.

Tested on ASCII only.

Andrew Bartlett
(This used to be commit 44d304f84c4ba5a832d5e3848ae0d04d5438ac15)

17 years agoAdded strstr_m() function. Use in all places where we might run into mb
Jeremy Allison [Tue, 9 Mar 2004 00:17:14 +0000 (00:17 +0000)]
Added strstr_m() function. Use in all places where we might run into mb
(should fix the mb service name problem, can't remember the bugid).
(This used to be commit 94a272b9a881ec0004c5da2a7242b0a818da5630)

17 years agoFix assumption about following directory sep in check_path_syntax(). We
Jeremy Allison [Mon, 8 Mar 2004 21:54:54 +0000 (21:54 +0000)]
Fix assumption about following directory sep in check_path_syntax(). We
need to try and convert 1 byte, then 2 bytes if that fails. Fixes bug
reported by Simo.
(This used to be commit 8702d0089619c7321b93e59d35f43ef32dce7b78)

17 years agoGet us a little closer to Windows LSA semantics.
Volker Lendecke [Sun, 7 Mar 2004 08:22:06 +0000 (08:22 +0000)]
Get us a little closer to Windows LSA semantics.

A windows DC does not reply to DCNAME\\Administrator, only to
DOMAIN\\Administrator. Fix that.

Without winbind we are wrong as domain members, we should forward the request
DOMAIN\\Username to the DC on behalf of the asking client. Winbind fixes that

(This used to be commit 7ed61edbbedbdee25f750aa30c13479764aa1af2)

17 years agoMention wb_delgrpmem fix
Volker Lendecke [Sun, 7 Mar 2004 08:18:35 +0000 (08:18 +0000)]
Mention wb_delgrpmem fix
(This used to be commit 97a6a67b34201dda7715f5f23b1b9af3bcf3705f)

17 years agoThis might not be used a lot and might not survive for long, but at least it
Volker Lendecke [Sun, 7 Mar 2004 08:16:10 +0000 (08:16 +0000)]
This might not be used a lot and might not survive for long, but at least it
should work as expected :-)

Fix wb_delgrpmember.

(This used to be commit 9fc0025d12d17b0c68956af481a836eebc32e675)

17 years agoFix typo.
Tim Potter [Sun, 7 Mar 2004 01:14:11 +0000 (01:14 +0000)]
Fix typo.
(This used to be commit e6e8b59f53d5ac618dcec13a46c356f0abe5950a)

17 years agoMerge from HEAD.
Tim Potter [Sun, 7 Mar 2004 00:50:37 +0000 (00:50 +0000)]
Merge from HEAD.
(This used to be commit 89f3173f4f4e9a16f24b25f550065b50577f3f4c)

17 years agoMerge from HEAD.
Tim Potter [Sun, 7 Mar 2004 00:09:36 +0000 (00:09 +0000)]
Merge from HEAD.
(This used to be commit 1bba071126b46032c97154fbf77242e15bcc5fa3)

17 years agoSeveral mb tidyups - getting ready to address the XXX_sub function.
Jeremy Allison [Fri, 5 Mar 2004 22:32:45 +0000 (22:32 +0000)]
Several mb tidyups - getting ready to address the XXX_sub function.
(This used to be commit 92c3ae3458177ec7f721598311a8ad04b2db5138)

17 years agoBUG 488: fix the 'show client in col 1' button and corrctely enumerate active connections
Gerald Carter [Fri, 5 Mar 2004 18:37:01 +0000 (18:37 +0000)]
BUG 488: fix the 'show client in col 1' button and corrctely enumerate active connections
(This used to be commit d77d38560d1bdc10a58408f449fbc320275bcacc)

17 years agofix compiler warning
Gerald Carter [Fri, 5 Mar 2004 17:39:38 +0000 (17:39 +0000)]
fix compiler warning
(This used to be commit df19b6066e1f4e200adcd80f9526aa1a68509580)

17 years agoAdd -O (for writing downloaded files to standard out) based on patch by
Jelmer Vernooij [Fri, 5 Mar 2004 17:17:31 +0000 (17:17 +0000)]
Add -O (for writing downloaded files to standard out) based on patch by
Bas van Sisseren <>
(This used to be commit cc164e5afb0f6100bde547674b3de88b7e45f31f)

17 years agobring WHATSNEW back up to date
Gerald Carter [Fri, 5 Mar 2004 15:37:08 +0000 (15:37 +0000)]
bring WHATSNEW back up to date
(This used to be commit 737b3a5a9286777b0ea38bed5f1e20a3c3859304)

17 years agoall_string_sub() is broken as it doesn't handle mb chars correctly (and
Jeremy Allison [Fri, 5 Mar 2004 01:37:12 +0000 (01:37 +0000)]
all_string_sub() is broken as it doesn't handle mb chars correctly (and
so breaks when substitution '/' and '\'). It's used by unix_clean_name(),
which is used by reduce_name, which is used by check_name() (phew!).
Now that we know all filenames passed to check_name() are in a "good"
format (no double slashes, all '\\' chars translated to '/' etc.) due
to the new check_path_syntax() we can avoid calling reduce_name unless
widelinks are denied. After this check-in I can fix all_string_sub() to
handle mb chars correctly as it won't be in the direct path in the
main path handling code.
(This used to be commit 6080186fc4c2e7c59dd12a177539bfb77eb525cb)

17 years agoFix my breakage of NT pipes from the previous patch (sorry). Use the
Jeremy Allison [Thu, 4 Mar 2004 18:55:37 +0000 (18:55 +0000)]
Fix my breakage of NT pipes from the previous patch (sorry). Use the
original srvstr_pull_buf() function to get the pipename not srvstr_get_path().
(This used to be commit 2a263873fd6bbbf03a32136981e433dc43374da9)

17 years agoBUG 1015: patch from jmcd to fix statfs redeclaration of statfs struct on ppc
Gerald Carter [Thu, 4 Mar 2004 18:34:45 +0000 (18:34 +0000)]
BUG 1015: patch from jmcd to fix statfs redeclaration of statfs struct on ppc
(This used to be commit fafb243278cd33d696487e477d4685bb79e2e357)

17 years agoBUG 1080: fix declaration of SMB_BIG_UINT
Gerald Carter [Thu, 4 Mar 2004 18:17:01 +0000 (18:17 +0000)]
BUG 1080: fix declaration of SMB_BIG_UINT
(This used to be commit 810bc1e2a02c6ab11ef00bf67b49929c596bee33)

17 years agoThere's a specific error message NT_STATUS_ALIAS_EXISTS.
Volker Lendecke [Thu, 4 Mar 2004 17:57:21 +0000 (17:57 +0000)]
There's a specific error message NT_STATUS_ALIAS_EXISTS.
(This used to be commit f0d99f318c67852ac5bf9b606faa115ad36a5f80)

17 years agoAnother typo, sorry for samba-cvs spam :-)
Volker Lendecke [Thu, 4 Mar 2004 17:51:29 +0000 (17:51 +0000)]
Another typo, sorry for samba-cvs spam :-)
(This used to be commit 3e39d157cb94928a036f0497a9e255f6dbad1771)

17 years agoFix typo.
Volker Lendecke [Thu, 4 Mar 2004 17:47:14 +0000 (17:47 +0000)]
Fix typo.

(This used to be commit 8ba5bdc330114efbc86c851b71c58ac91ada7f31)

17 years agoFix build farm, older compilers won't let you declare variables
Jim McDonough [Thu, 4 Mar 2004 16:24:13 +0000 (16:24 +0000)]
Fix build farm, older compilers won't let you declare variables
right in the middle of the code.

I just love catching jra on stuff like this, after all the crap
I've done. :-)
(This used to be commit dc7dc5175847243d821dd33c1678af1b785dfaf7)

17 years agoBUG 848: don't create winbind local users/groups that already exist in the tdb
Gerald Carter [Thu, 4 Mar 2004 15:59:11 +0000 (15:59 +0000)]
BUG 848: don't create winbind local users/groups that already exist in the tdb
(This used to be commit 89da3df07b7d90ad19852046d0533673cff8fdc6)

17 years agoanother fix for bug 761; don't default to bsd printing on linux
Gerald Carter [Thu, 4 Mar 2004 15:18:36 +0000 (15:18 +0000)]
another fix for bug 761; don't default to bsd printing on linux
(This used to be commit d58139d64f37fe9fec34492d7857257d9ad4a808)

17 years agoAdded client "hardlink" commant to test doing NT rename with hard links.
Jeremy Allison [Wed, 3 Mar 2004 23:14:23 +0000 (23:14 +0000)]
Added client "hardlink" commant to test doing NT rename with hard links.
Added hardlink_internals() code - UNIX extensions now use this too.
(This used to be commit aad6eb2240393931940c982e25a981ce32264f38)

17 years agoUse a common function to parse all pathnames from the wire. This allows
Jeremy Allison [Wed, 3 Mar 2004 20:55:59 +0000 (20:55 +0000)]
Use a common function to parse all pathnames from the wire. This allows
much closer emulation of Win2k3 error return codes.
(This used to be commit c9f31fafeda6ad79e590276f36e03ecd2e93f818)

17 years agoset log file to smbd.log for interaction with logrotate (BUG 503)
Gerald Carter [Wed, 3 Mar 2004 17:56:29 +0000 (17:56 +0000)]
set log file to smbd.log for interaction with logrotate (BUG 503)
(This used to be commit c800b5c2f99c27dd0a3f526dfdac0980412e1694)

17 years agomore usrmgr fixes: display lockout timers in minutes, not seconds, for samr 2e
Jim McDonough [Wed, 3 Mar 2004 17:44:00 +0000 (17:44 +0000)]
more usrmgr fixes: display lockout timers in minutes, not seconds, for samr 2e
(This used to be commit 832674c099a3ff9bb747dba6235e47d40a930abd)

17 years agoquick for for usrmgr. unknown_6 is really max dimension of logon hours array. need...
Jim McDonough [Wed, 3 Mar 2004 04:23:43 +0000 (04:23 +0000)]
quick for for usrmgr.  unknown_6 is really max dimension of logon hours array.  need to update passdb for this.
(This used to be commit fbf909926b7d7b1e92ebeba44469392296c35c1a)

17 years agoMerge fields_present function from HEAD. Now, a field will not be updated
Jim McDonough [Tue, 2 Mar 2004 21:02:09 +0000 (21:02 +0000)]
Merge fields_present function from HEAD.  Now, a field will not be updated
on setuserinfo levels which include this field, unless the corresponding
bit (defined in passdb.h) is turned on.  Without this, newer versions
of usrmgr break us pretty bad.
(This used to be commit 840340bd96d3c6693b451bc61e155b7b426271e4)

17 years agoBUG 1129: patch from (Shiro Yamada) to install image files...
Gerald Carter [Tue, 2 Mar 2004 18:10:12 +0000 (18:10 +0000)]
BUG 1129: patch from (Shiro Yamada) to install image files for SWAT
(This used to be commit a01a7fdbd93997185322d1faaa76c408f0ed2b1d)

17 years agoJanitorial duty for tpot - --with-fhs fix.
Jeremy Allison [Tue, 2 Mar 2004 18:07:06 +0000 (18:07 +0000)]
Janitorial duty for tpot - --with-fhs fix.
(This used to be commit 64eded518b32a242880b5e85c9032bc212c3f1fb)

17 years agofix typo for callback bit
Jim McDonough [Tue, 2 Mar 2004 18:04:16 +0000 (18:04 +0000)]
fix typo for callback bit
(This used to be commit 31a15164ffb3f551a5f7006e637036dc3b59bd22)

17 years agoallow the 'printing' parameter to be set on a per share basis.
Gerald Carter [Tue, 2 Mar 2004 14:26:45 +0000 (14:26 +0000)]
allow the 'printing' parameter to be set on a per share basis.
The problem was that the current_printif struct was set during
print_backend_init() based on the 'printcap name'.  So you could
not use cups and then override the setting for a specific printer
by setting 'printing = bsd' (a common setup for pdf generation
print services.

There is a subtle change in behavior in that the print
interface functions are selecting on the basis of lp_printing()
and not lp_printcap_name(), but the new behavior seems more
intuitive IMHO.
(This used to be commit 14de9c065787bd1675021a6cd6555f81ea965f17)

17 years agoBUG 761: read the config file before initialized default values for printing options
Gerald Carter [Tue, 2 Mar 2004 04:09:39 +0000 (04:09 +0000)]
BUG 761: read the config file before initialized default values for printing options
(This used to be commit d358f72974ce49bf2007c9b3b7314caa5897b4c1)

17 years agoBUG 692: patch from SATOH Fumiyasu <> to correct truncation...
Gerald Carter [Mon, 1 Mar 2004 17:40:40 +0000 (17:40 +0000)]
BUG 692: patch from SATOH Fumiyasu <> to correct truncation of share names and workgroup names
(This used to be commit 822e31d841e720d48f4feeec673b75575caa8fac)

17 years agoBUG 1147; bad pointer case in get_stored_queue_info() causing seg fault
Gerald Carter [Mon, 1 Mar 2004 17:03:05 +0000 (17:03 +0000)]
BUG 1147; bad pointer case in get_stored_queue_info() causing seg fault
(This used to be commit 91af1fb73a2e86a343c085128aaed2ef0c26de57)

17 years agonet_rpc.c: Don't complain if [add|del]mem was successful.
Volker Lendecke [Sun, 29 Feb 2004 16:34:33 +0000 (16:34 +0000)]
net_rpc.c: Don't complain if [add|del]mem was successful.

srv_samr_nt.c: Correctly report that a user is not member of an alias.

(This used to be commit 540f625036871e7facd094fce49d7317f65f4ffd)

17 years agoPrint an informative error message if trying to add/remove members from
Volker Lendecke [Sun, 29 Feb 2004 12:47:45 +0000 (12:47 +0000)]
Print an informative error message if trying to add/remove members from
something not a group.

(This used to be commit 73f26de5c0b6a6b9b78c22016986f3106bce7bfa)

17 years agoAdd 'net rpc group [add|del]mem' for domain groups and aliases.
Volker Lendecke [Sat, 28 Feb 2004 18:41:16 +0000 (18:41 +0000)]
Add 'net rpc group [add|del]mem' for domain groups and aliases.

(This used to be commit e597420421e085b17dcdc062c5900518d0d4e685)

17 years agoFix my fix to net rpc group list. We can certainly have more than a single
Volker Lendecke [Sat, 28 Feb 2004 08:18:09 +0000 (08:18 +0000)]
Fix my fix to net rpc group list. We can certainly have more than a single
set of groups.

(This used to be commit e77fe4a77a6b0b8d92014edb073b36d01a1a5169)

17 years agoCan't set allocation size on directories, return correct error code on
Jeremy Allison [Sat, 28 Feb 2004 01:53:30 +0000 (01:53 +0000)]
Can't set allocation size on directories, return correct error code on
fail if file exists and target is a directory. gentest.
(This used to be commit f4a7ea6dc2b9f379a9c735670a49ac63818754c7)

17 years agoMore gentest fixes. Fix up regression in IS_NAME_VALID and renames.
Jeremy Allison [Sat, 28 Feb 2004 00:56:42 +0000 (00:56 +0000)]
More gentest fixes. Fix up regression in IS_NAME_VALID and renames.
(This used to be commit 367f5c3bc27aafb04f7589b3d4ac5b58189909fb)

17 years agoAdded copyrights I forgot about looong ago...
Rafal Szczesniak [Fri, 27 Feb 2004 22:15:38 +0000 (22:15 +0000)]
Added copyrights I forgot about looong ago...

(This used to be commit 33d1e2dd63e3dbf592a666ae48bc013a8198d008)

17 years agoFix for writable printerdata problem - bugzilla #1112.
Tim Potter [Thu, 26 Feb 2004 23:04:11 +0000 (23:04 +0000)]
Fix for writable printerdata problem - bugzilla #1112.
(This used to be commit a05b9f0cc55300e2a25c87849a4417afea0cd867)

17 years agoThat const was one too many
Volker Lendecke [Thu, 26 Feb 2004 14:34:44 +0000 (14:34 +0000)]
That const was one too many
(This used to be commit 005d92d57ea912b68dd107152d478fae2162511a)

17 years agoImplement 'net groupmap set' and 'net groupmap cleanup'.
Volker Lendecke [Thu, 26 Feb 2004 11:29:56 +0000 (11:29 +0000)]
Implement 'net groupmap set' and 'net groupmap cleanup'.

I was rather annoyed by the net groupmap syntax, I could never get it

net groupmap set "domain admins" domadm

creates a mapping,

net groupmap set "domain admins" -C "Comment" -N "newntname"

should also do what you expect. I'd like to have some feedback on the usability
of this.

net groupmap cleanup

solves a problem I've had two times now: Our SID changed, and a user's primary
group was mapped to a SID that is not ours. net groupmap cleanup removes all
mappings that are not from our domain sid.

(This used to be commit eb4d4faff8c14e999f414ca5b6e8c25a558859c8)

17 years agoAnd another little const
Volker Lendecke [Thu, 26 Feb 2004 11:07:06 +0000 (11:07 +0000)]
And another little const
(This used to be commit f6bb3304fc5ef298a921b9ee5ad2f6444b0e72bc)

17 years agoApply some const
Volker Lendecke [Thu, 26 Feb 2004 10:55:43 +0000 (10:55 +0000)]
Apply some const

(This used to be commit 0b29d83d33153dc0e49406efa6735b6664d88ce7)

17 years agoFixes to minor security bug pointed out by AB in the mount helper
Steve French [Thu, 26 Feb 2004 06:42:51 +0000 (06:42 +0000)]
Fixes to minor security bug pointed out by AB in the mount helper
(This used to be commit b83802c5a14800554d30c32c12ae3a86e3136bdf)

17 years agofixed compilation with --enable-dmalloc
Andrew Tridgell [Thu, 26 Feb 2004 02:11:31 +0000 (02:11 +0000)]
fixed compilation with --enable-dmalloc

the macro redefinition of free() means we cannot have a structure
element called "free"
(This used to be commit d2d653a1a6db9d0407e99affb317a0045e56168a)

17 years agoMerging Richard's rename test.
Jeremy Allison [Thu, 26 Feb 2004 01:33:35 +0000 (01:33 +0000)]
Merging Richard's rename test.
(This used to be commit 5646b6c989c6f13fe1149cf24bf8af87fa95b759)

17 years agoInteresting fact found by IFSTEST /t LockOverlappedTest...
Jeremy Allison [Thu, 26 Feb 2004 01:31:10 +0000 (01:31 +0000)]
Interesting fact found by IFSTEST /t LockOverlappedTest...
Even if it's our own lock context, we need to wait here as
there may be an unlock on the way.
So I removed a "&& !my_lock_ctx" from the following
if statement.

if ((lock_timeout != 0) && lp_blocking_locks(SNUM(conn)) && ERROR_WAS_LOCK_DENIED(status)) {

(This used to be commit 3f35e3975f1c46daad1456bc82163acd049d7be8)

17 years agoFix bug in previous global_sam_sid() commit. I broke the 'read from
Andrew Bartlett [Wed, 25 Feb 2004 23:12:29 +0000 (23:12 +0000)]
Fix bug in previous global_sam_sid() commit.  I broke the 'read from
MACHINE.SID' file functionality.

Also, before we print out the results of 'net getlocalsid' and 'net
getdomainsid', ensure we have tried to read that file, or have
generated one.

Andrew Bartlett
(This used to be commit 191b43159e7358541be9a3deac8c447885145442)

17 years agoI *hate* global variables...
Andrew Bartlett [Wed, 25 Feb 2004 22:01:02 +0000 (22:01 +0000)]
I *hate* global variables...

OK, what was happening here was that we would invalidate global_sam_sid
when we set the sid into secrets.tdb, to force a re-read.

The problem was, we would do *two* writes into the TDB, and the second one
(in the PDC/BDC case) would be of a NULL pointer.  This caused smbd startups
to fail, on a blank TDB.

By using a local variable in the pdb_generate_sam_sid() code, we avoid this
particular trap.

I've also added better debugging for the case where this all matters, which
is particularly for LDAP, where it finds out a domain SID from the sambaDomain

Andrew Bartlett
(This used to be commit 86ad04d26d3065a99b08afaaf2914968a9e701c5)

17 years agoFixup strange rename error case (gentest).
Jeremy Allison [Wed, 25 Feb 2004 21:37:22 +0000 (21:37 +0000)]
Fixup strange rename error case (gentest).
(This used to be commit d448fb801e175e11cfc0118325043eef836103f0)

17 years agoDo the query part of the previous fix...reset time and duration are set in minutes...
Jim McDonough [Wed, 25 Feb 2004 20:02:47 +0000 (20:02 +0000)]
Do the query part of the previous fix...reset time and duration are set in minutes, not seconds.  Works from usrmgr.
(This used to be commit 98833a82facb0bc25d9ba6f4d4c1200627e98d6d)

17 years agoreset time and duration are set in minutes, not seconds. Works from usrmgr.
Jim McDonough [Wed, 25 Feb 2004 15:02:55 +0000 (15:02 +0000)]
reset time and duration are set in minutes, not seconds.  Works from usrmgr.
(This used to be commit 700049d9efefc7f8952cc60bc46ba8aa790a28ba)

17 years agoFigured out a new flags bit with gentest and ethereal....
Jeremy Allison [Wed, 25 Feb 2004 02:15:34 +0000 (02:15 +0000)]
Figured out a new flags bit with gentest and ethereal....
(This used to be commit b4b684f1155b1abccb69cca7bca9819625dbfead)