ira/wip.git
14 years agos4-smbtorture: fix smbtorture after setprinter IDL fixes.
Günther Deschner [Wed, 16 Dec 2009 09:33:41 +0000 (10:33 +0100)]
s4-smbtorture: fix smbtorture after setprinter IDL fixes.

Guenther

14 years agos3-spoolss: fix rpcclient after setprinter IDL fixes.
Günther Deschner [Wed, 16 Dec 2009 09:33:13 +0000 (10:33 +0100)]
s3-spoolss: fix rpcclient after setprinter IDL fixes.

Guenther

14 years agospoolss: more mork on SetPrinterInfo() levels.
Günther Deschner [Wed, 16 Dec 2009 09:32:35 +0000 (10:32 +0100)]
spoolss: more mork on SetPrinterInfo() levels.

Guenther

14 years agos4-ntvfs: check if pvfs is NULL in pvfs_logoff
brendan powers [Thu, 17 Dec 2009 00:01:32 +0000 (19:01 -0500)]
s4-ntvfs: check if pvfs is NULL in pvfs_logoff

pvfs can be NULL if the directory a share points to does not exist. In
this case, there would be no open files, so it is safe to just return
from the function.

Signed-off-by: Andrew Tridgell <tridge@samba.org>
14 years agos4:gensec: allow clearing local and remote address by passing NULL
Stefan Metzmacher [Wed, 16 Dec 2009 19:34:15 +0000 (20:34 +0100)]
s4:gensec: allow clearing local and remote address by passing NULL

metze

14 years agos4-gensec: Remove obsolete socket_address vars and fns.
Andreas Schneider [Wed, 16 Dec 2009 17:07:07 +0000 (18:07 +0100)]
s4-gensec: Remove obsolete socket_address vars and fns.

14 years agos4-gensec: Replace gensec_get_peer_addr with new tsocket based fn.
Andreas Schneider [Wed, 16 Dec 2009 15:41:21 +0000 (16:41 +0100)]
s4-gensec: Replace gensec_get_peer_addr with new tsocket based fn.

14 years agos4-gensec: Replace gensec_set_peer_addr with new tsocket based fn.
Andreas Schneider [Wed, 16 Dec 2009 15:12:13 +0000 (16:12 +0100)]
s4-gensec: Replace gensec_set_peer_addr with new tsocket based fn.

14 years agos4-gensec: Replace gensec_get_my_addr with new tsocket based fn.
Andreas Schneider [Wed, 16 Dec 2009 15:06:55 +0000 (16:06 +0100)]
s4-gensec: Replace gensec_get_my_addr with new tsocket based fn.

14 years agos4-gensec: Replace gensec_set_my_addr() with new tsocket based fn.
Andreas Schneider [Wed, 16 Dec 2009 14:52:30 +0000 (15:52 +0100)]
s4-gensec: Replace gensec_set_my_addr() with new tsocket based fn.

14 years agos4-gensec: Added remote and local setter/getter using tsocket.
Andreas Schneider [Wed, 16 Dec 2009 12:27:20 +0000 (13:27 +0100)]
s4-gensec: Added remote and local setter/getter using tsocket.

14 years agoFinal part of the fix for 6837 - "Too many open files" when trying to access large...
Jeremy Allison [Wed, 16 Dec 2009 18:19:19 +0000 (10:19 -0800)]
Final part of the fix for 6837 - "Too many open files" when trying to access large number of files

Win7 needs a min of 16k file handles to work against a
server.

Jeremy.

14 years agoAdd helpful debug of DACL for errors on ACL access.
Jeremy Allison [Wed, 16 Dec 2009 18:09:11 +0000 (10:09 -0800)]
Add helpful debug of DACL for errors on ACL access.
Jeremy.

14 years agospoolss: add spoolss_DriverInfo7.
Günther Deschner [Wed, 16 Dec 2009 09:39:00 +0000 (10:39 +0100)]
spoolss: add spoolss_DriverInfo7.

Guenther

14 years agos3-pdbedit: allow to call "pdbedit -N description -u user" without specifiyng "-r".
Günther Deschner [Wed, 16 Dec 2009 14:59:04 +0000 (15:59 +0100)]
s3-pdbedit: allow to call "pdbedit -N description -u user" without specifiyng "-r".

Guenther

14 years agos4-dsdb: also mark the relax control non-critical when done
Andrew Tridgell [Wed, 16 Dec 2009 09:45:40 +0000 (20:45 +1100)]
s4-dsdb: also mark the relax control non-critical when done

14 years agos4-dsdb: it is a better pattern to mark a control as done than remove it
Andrew Tridgell [Wed, 16 Dec 2009 09:45:02 +0000 (20:45 +1100)]
s4-dsdb: it is a better pattern to mark a control as done than remove it

removing a control means it can't be seen by any other modules, which
is usually not what is wanted. Better to just mark it non-critical,
which means anyone else who wants to look at it can, but if nobody
does its not an error.

14 years agos4-dsdb: when the SD_FLAGS control is set, don't remove nTSecurityDescriptor
Andrew Tridgell [Wed, 16 Dec 2009 09:39:55 +0000 (20:39 +1100)]
s4-dsdb: when the SD_FLAGS control is set, don't remove nTSecurityDescriptor

14 years agos4-dsdb: don't actually remove the sd_flags control, just mark it non-critical
Andrew Tridgell [Wed, 16 Dec 2009 09:39:18 +0000 (20:39 +1100)]
s4-dsdb: don't actually remove the sd_flags control, just mark it non-critical

For controls that need to be seen by more than one module, it is best
to just mark them non-critical when handled, instead of removing
them. Otherwise lower modules can't see them.

In this case we want the operational module to see the SD_FLAGS
control

14 years agos4-ldb: show the OID of any unhandled critical controls
Andrew Tridgell [Wed, 16 Dec 2009 06:13:19 +0000 (17:13 +1100)]
s4-ldb: show the OID of any unhandled critical controls

It isn't very useful just saying that a control is not supported,
without saying which one is the problem

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

14 years agos4-ldb: fixed a transaction error on prepare_commit
Andrew Tridgell [Wed, 16 Dec 2009 06:12:28 +0000 (17:12 +1100)]
s4-ldb: fixed a transaction error on prepare_commit

when a prepare commit fails, we need to give a cancel to all modules,
not a commit!

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

14 years agos4-ldb: added --show-deactivated-link command line option
Andrew Tridgell [Wed, 16 Dec 2009 03:58:35 +0000 (14:58 +1100)]
s4-ldb: added --show-deactivated-link command line option

this adds the SHOW_DEACTIVATED_LINK control

14 years agoldap: give a debug error when we don't know a control
Andrew Tridgell [Wed, 16 Dec 2009 03:57:32 +0000 (14:57 +1100)]
ldap: give a debug error when we don't know a control

This interface should really have a proper error interface, but at
least a DEBUG() gives the user a chance of finding the error

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

14 years agos4-dsdb: added dsdb_get_deleted_objects_dn()
Andrew Tridgell [Wed, 16 Dec 2009 02:41:21 +0000 (13:41 +1100)]
s4-dsdb: added dsdb_get_deleted_objects_dn()

This is based on the code from Eduardo Lima <eduardoll@gmail.com>, but
uses the new helper functions added in the last couple of commits

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

14 years agos4-dsdb: added dsdb_find_nc_root()
Andrew Tridgell [Wed, 16 Dec 2009 02:36:17 +0000 (13:36 +1100)]
s4-dsdb: added dsdb_find_nc_root()

This is based on the function of the same name from Eduardo Lima
<eduardoll@gmail.com>, but using ldb_dn_compare, to give us
comparisons consistent with what the rest of the code uses.

We will use this function in combination with dsdb_wellknown_dn() to
find the Deleted Objects container for any object.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

14 years agos4-dsdb: added dsdb_wellknown_dn()
Andrew Tridgell [Wed, 16 Dec 2009 02:18:44 +0000 (13:18 +1100)]
s4-dsdb: added dsdb_wellknown_dn()

This finds a wellknown object given its GUID

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

14 years agolibds: added GUIDs for wellknown AD objects
Andrew Tridgell [Wed, 16 Dec 2009 02:18:10 +0000 (13:18 +1100)]
libds: added GUIDs for wellknown AD objects

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

14 years agos4-dsdb: added a dsdb_module_rename() call
Andrew Tridgell [Wed, 16 Dec 2009 01:01:16 +0000 (12:01 +1100)]
s4-dsdb: added a dsdb_module_rename() call

This will be used by the replmd_delete() code

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

14 years agos4-dsdb: added dsdb_module_modify()
Andrew Tridgell [Wed, 16 Dec 2009 00:32:57 +0000 (11:32 +1100)]
s4-dsdb: added dsdb_module_modify()

This is used to do a sync modify in a module

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

14 years agos4-dsdb: fixed dsdb_module_dn_by_guid()
Andrew Tridgell [Wed, 16 Dec 2009 00:31:30 +0000 (11:31 +1100)]
s4-dsdb: fixed dsdb_module_dn_by_guid()

needs to ask for the DN in storage format, plus fix compilation errors

14 years agos4-dsdb: dsdb_flags should be unsigned
Andrew Tridgell [Wed, 16 Dec 2009 00:30:03 +0000 (11:30 +1100)]
s4-dsdb: dsdb_flags should be unsigned

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

14 years agos4-dsdb: rename dsdb_module_search_handle_flags to dsdb_request_add_controls
Andrew Tridgell [Wed, 16 Dec 2009 00:28:50 +0000 (11:28 +1100)]
s4-dsdb: rename dsdb_module_search_handle_flags to dsdb_request_add_controls

This function will be used for non-search controls, like relax

14 years agos4-dsdb: added dsdb_module_dn_by_guid()
Andrew Tridgell [Tue, 15 Dec 2009 23:27:32 +0000 (10:27 +1100)]
s4-dsdb: added dsdb_module_dn_by_guid()

This finds a DN given a GUID, searching below the current module in
the module stack.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

14 years agos4-dsdb: use dsdb_dn_is_deleted_val()
Andrew Tridgell [Tue, 15 Dec 2009 00:01:18 +0000 (11:01 +1100)]
s4-dsdb: use dsdb_dn_is_deleted_val()

This also moves the check to before we parse the DN, which saves some
unnecessary work

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

14 years agos4-dsdb: added dsdb_dn_is_deleted_val()
Andrew Tridgell [Tue, 15 Dec 2009 00:00:30 +0000 (11:00 +1100)]
s4-dsdb: added dsdb_dn_is_deleted_val()

This is used to determine if a extedned DN has the 'DELETED=1'
component

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

14 years agos4-ntvfs: try to fix bug 6989
Andrew Tridgell [Tue, 15 Dec 2009 22:32:10 +0000 (09:32 +1100)]
s4-ntvfs: try to fix bug 6989

bug 6989 is a rare crash that has occurred in production. My best
guess as to the cause is the talloc_free() not being specific enough
as to which parent needs to be freed.

14 years agos4:drsuapi/getncchanges.c - Update the list of operational attributes
Matthias Dieter Wallnöfer [Wed, 16 Dec 2009 08:45:22 +0000 (09:45 +0100)]
s4:drsuapi/getncchanges.c - Update the list of operational attributes

- Reorder them as specified in "operational.c"
- Add also the lan manager hash password attribute

14 years agoEnsure dos_mode can return FILE_ATTRIBUTE_NORMAL, then filter the returned attributes...
Jeremy Allison [Wed, 16 Dec 2009 02:03:47 +0000 (18:03 -0800)]
Ensure dos_mode can return FILE_ATTRIBUTE_NORMAL, then filter the returned attributes by protocol level.

This makes us consistant in returning DOS attrs across all replies. Tested on OS/2 by Günter Kukkukk.
Jeremy.

14 years agos4-smbtorture: run GetPrinterDriver2 tests against each printer's driver.
Günther Deschner [Tue, 15 Dec 2009 21:26:39 +0000 (22:26 +0100)]
s4-smbtorture: run GetPrinterDriver2 tests against each printer's driver.

Guenther

14 years agos4:prog_guide4.txt: remove obsolete comments
Stefan Metzmacher [Tue, 15 Dec 2009 15:52:00 +0000 (16:52 +0100)]
s4:prog_guide4.txt: remove obsolete comments

metze

14 years agos4: Fixed the programming guide to reflect the current tree.
Andreas Schneider [Tue, 15 Dec 2009 15:46:03 +0000 (16:46 +0100)]
s4: Fixed the programming guide to reflect the current tree.

14 years agos4-kdc: Migrate to tsocket_address.
Andreas Schneider [Tue, 15 Dec 2009 11:58:40 +0000 (12:58 +0100)]
s4-kdc: Migrate to tsocket_address.

14 years agotsocket: Fixed tsocket_guide.txt asciidoc syntax.
Andreas Schneider [Tue, 15 Dec 2009 11:58:18 +0000 (12:58 +0100)]
tsocket: Fixed tsocket_guide.txt asciidoc syntax.

14 years agotsocket: Fixed documentation for tsocket_address_bsd_sockaddr().
Andreas Schneider [Tue, 15 Dec 2009 11:57:35 +0000 (12:57 +0100)]
tsocket: Fixed documentation for tsocket_address_bsd_sockaddr().

14 years agotsocket: Fixed typo in LGPL header.
Andreas Schneider [Tue, 15 Dec 2009 11:56:44 +0000 (12:56 +0100)]
tsocket: Fixed typo in LGPL header.

14 years agotsocket: add tsocket_address_bsd_sockaddr() and tsocket_address_bsd_from_sockaddr()
Stefan Metzmacher [Wed, 4 Nov 2009 18:03:41 +0000 (19:03 +0100)]
tsocket: add tsocket_address_bsd_sockaddr() and tsocket_address_bsd_from_sockaddr()

metze

14 years agosmbtorture4: Add rpc-samba3-getaliasmembership-0
Volker Lendecke [Tue, 15 Dec 2009 16:49:24 +0000 (17:49 +0100)]
smbtorture4: Add rpc-samba3-getaliasmembership-0

14 years agos3: Fix _samr_GetAliasMembership for results with 0 rids
Volker Lendecke [Tue, 15 Dec 2009 13:01:43 +0000 (14:01 +0100)]
s3: Fix _samr_GetAliasMembership for results with 0 rids

14 years agoRemoved ldb_modify_ctrl from ldb, implemented as a static in ldap_backend.
Nadezhda Ivanova [Tue, 15 Dec 2009 18:29:20 +0000 (20:29 +0200)]
Removed ldb_modify_ctrl from ldb, implemented as a static in ldap_backend.

14 years agos4 torture: Add new RAW-SEARCH test to explore strange max count behavior
Aravind Srinivasan [Tue, 15 Dec 2009 17:49:08 +0000 (09:49 -0800)]
s4 torture: Add new RAW-SEARCH test to explore strange max count behavior

Signed-off-by: Tim Prouty <tprouty@samba.org>
14 years agos4 torture: Update RAW-QFILEINFO to only test info levels that are supported by the...
Aravind Srinivasan [Tue, 15 Dec 2009 17:22:07 +0000 (09:22 -0800)]
s4 torture: Update RAW-QFILEINFO to only test info levels that are supported by the server

Signed-off-by: Tim Prouty <tprouty@samba.org>
14 years agos4 torture: Convert RAW-OPEN to suite form
Zach Loafman [Mon, 14 Dec 2009 18:31:02 +0000 (10:31 -0800)]
s4 torture: Convert RAW-OPEN to suite form

14 years agos4 torture: Add SHARE_DELETE to create_directory_handle
Tim Prouty [Tue, 15 Dec 2009 01:00:43 +0000 (17:00 -0800)]
s4 torture: Add SHARE_DELETE to create_directory_handle

Tests explicitly checking share modes should open the dir/file
with the share mode they want to test.

14 years agoFix release script to work with recent git versions
Simo Sorce [Tue, 15 Dec 2009 14:17:25 +0000 (09:17 -0500)]
Fix release script to work with recent git versions

14 years agos4:tls: fix the build on Solaris
Brian Lu [Tue, 15 Dec 2009 11:56:23 +0000 (12:56 +0100)]
s4:tls: fix the build on Solaris

Signed-off-by: Stefan Metzmacher <metze@samba.org>
14 years agoFixed a problem with duplicate values of allowedAttributesEffective.
Nadezhda Ivanova [Tue, 15 Dec 2009 10:02:20 +0000 (12:02 +0200)]
Fixed a problem with duplicate values of allowedAttributesEffective.

14 years agos4: rename res/res2 to something more explicit
Matthieu Patou [Sat, 12 Dec 2009 16:13:15 +0000 (19:13 +0300)]
s4: rename res/res2 to something more explicit

14 years agos4: upgradeprovision handle renaming and knownobjects
Matthieu Patou [Sat, 12 Dec 2009 13:28:31 +0000 (16:28 +0300)]
s4: upgradeprovision handle renaming and knownobjects

14 years agos4: upgradeprovision rename also when there is a mismatch on the case of name attribute
Matthieu Patou [Sat, 12 Dec 2009 15:33:53 +0000 (18:33 +0300)]
s4: upgradeprovision rename also when there is a mismatch on the case of name attribute

  Renaming not only helps when name attribute is not here
  it also helps when the case is not the good one. So
  in order to avoid problem and have as much as possible similar provision
  we should use the rename whenever a name difference appear.

14 years agos4: reorder action to permit old provision to be correctly upgraded
Matthieu Patou [Sun, 29 Nov 2009 23:37:35 +0000 (02:37 +0300)]
s4: reorder action to permit old provision to be correctly upgraded

14 years agos4:provision - Remap conflicting thumbnailPhoto and thumbnailLogo OID's.
Endi Sukma Dewata [Tue, 8 Dec 2009 20:55:16 +0000 (14:55 -0600)]
s4:provision - Remap conflicting thumbnailPhoto and thumbnailLogo OID's.

14 years agos3: Allow up to 20480 entries in LookupSids, as mandated by the official IDL
Volker Lendecke [Mon, 14 Dec 2009 15:48:38 +0000 (16:48 +0100)]
s3: Allow up to 20480 entries in LookupSids, as mandated by the official IDL

Seen in the wild by putting >1000 users into BUILTIN\Users

14 years agos4-dsdb: added REVEAL_INTERNALS flag to dsdb_module_search_handle_flags()
Andrew Tridgell [Mon, 14 Dec 2009 10:53:40 +0000 (21:53 +1100)]
s4-dsdb: added REVEAL_INTERNALS flag to dsdb_module_search_handle_flags()

14 years agos4-devel: support vampire_ad.sh with no initial smb.conf
Andrew Tridgell [Mon, 14 Dec 2009 07:02:15 +0000 (18:02 +1100)]
s4-devel: support vampire_ad.sh with no initial smb.conf

14 years agos4-loadparm: call reload_charcnv() also for a missing smb.conf
Andrew Tridgell [Mon, 14 Dec 2009 06:54:04 +0000 (17:54 +1100)]
s4-loadparm: call reload_charcnv() also for a missing smb.conf

bin/net vampire with a missing smb.conf would segfault as the iconv
convenience pointer had not been setup.

14 years agos4-dsdb: return a zero guid on error in samdb_result_guid()
Andrew Tridgell [Fri, 11 Dec 2009 06:33:32 +0000 (17:33 +1100)]
s4-dsdb: return a zero guid on error in samdb_result_guid()

14 years agoheimdal: work around differences between GNU and XSI strerror_r()
Andrew Tridgell [Fri, 11 Dec 2009 03:39:33 +0000 (14:39 +1100)]
heimdal: work around differences between GNU and XSI strerror_r()

This is a fairly ugly workaround, but then again, strerror_r() is a
very ugly mess.

14 years agos4-dsdb: use the reveal control to hide/show extended DN components
Andrew Tridgell [Thu, 10 Dec 2009 12:46:34 +0000 (23:46 +1100)]
s4-dsdb: use the reveal control to hide/show extended DN components

When reveal is set, then we show deleted linked attributes and all
linkked attribute components. When not set we show a normal extended
DN.

14 years agos4-ldb: added new ldb_dn extended components for linked attributes
Andrew Tridgell [Thu, 10 Dec 2009 12:45:16 +0000 (23:45 +1100)]
s4-ldb: added new ldb_dn extended components for linked attributes

These will store linked attribute replication meta data

14 years agos4-ldb: added a function to filter extended components of a ldb_dn
Andrew Tridgell [Thu, 10 Dec 2009 12:44:44 +0000 (23:44 +1100)]
s4-ldb: added a function to filter extended components of a ldb_dn

We need to be able to filter out components that should not be exposed
to users

14 years agos4-ldb: added a new "reveal" control
Andrew Tridgell [Thu, 10 Dec 2009 12:44:05 +0000 (23:44 +1100)]
s4-ldb: added a new "reveal" control

This control will allow inspection of internal ldb values, which would
normally be stripped before being presented to users. The first use
will be stripping linked attribute meta data extended components.

14 years agos4-ldb: sort the linearized extended DN by component name
Andrew Tridgell [Thu, 10 Dec 2009 11:45:36 +0000 (22:45 +1100)]
s4-ldb: sort the linearized extended DN by component name

This will make life easier when handling deleted linked attributes

14 years agolibrpc/ndr: avoid comparison_fn_t to fix the openchange build on solaris
Brian Lu [Mon, 14 Dec 2009 10:08:07 +0000 (11:08 +0100)]
librpc/ndr: avoid comparison_fn_t to fix the openchange build on solaris

Signed-off-by: Stefan Metzmacher <metze@samba.org>
14 years agoadd ignore for autogenrated files as they are not used by s3
Matthieu Patou [Sun, 13 Dec 2009 15:44:02 +0000 (18:44 +0300)]
add ignore for autogenrated files as they are not used by s3

Signed-off-by: Stefan Metzmacher <metze@samba.org>
14 years agotorture: add new tests for dfsblobs
Matthieu Patou [Sun, 13 Dec 2009 15:41:53 +0000 (18:41 +0300)]
torture: add new tests for dfsblobs

Signed-off-by: Stefan Metzmacher <metze@samba.org>
14 years agoidl: introduce new file: dfsblobs.idl
Matthieu Patou [Sun, 13 Dec 2009 02:03:03 +0000 (05:03 +0300)]
idl: introduce new file: dfsblobs.idl

Signed-off-by: Stefan Metzmacher <metze@samba.org>
14 years agolibrpc/ndr: add missing prototypes for relative_short functions
Stefan Metzmacher [Mon, 14 Dec 2009 09:52:56 +0000 (10:52 +0100)]
librpc/ndr: add missing prototypes for relative_short functions

metze

14 years agospoolss: fix spoolss_PrinterData size calculation.
Günther Deschner [Sat, 12 Dec 2009 01:52:41 +0000 (02:52 +0100)]
spoolss: fix spoolss_PrinterData size calculation.

Currently we were crashing in EnumPrinterDataEx when an e.g. an empty (NULL)
string for a separator file was returned.

Guenther

14 years agospoolss: trivial fix for spoolss_FormInfo2 IDL.
Günther Deschner [Sat, 12 Dec 2009 01:51:44 +0000 (02:51 +0100)]
spoolss: trivial fix for spoolss_FormInfo2 IDL.

Guenther

14 years agos4-smbtorture: check whether a returned buffer size is a multiple of 4 in RPC-SPOOLSS.
Günther Deschner [Sat, 12 Dec 2009 00:51:13 +0000 (01:51 +0100)]
s4-smbtorture: check whether a returned buffer size is a multiple of 4 in RPC-SPOOLSS.

This gives a good indication where our IDL (and the s3 spoolss implementation) is still wrong.

Guenther

14 years agos3:docs: Fix 'make manpages3'.
Karolin Seeger [Mon, 14 Dec 2009 07:58:50 +0000 (08:58 +0100)]
s3:docs: Fix 'make manpages3'.

Karolin

14 years agos4:"samdb_set_password_sid" - clean up created objects correctly
Matthias Dieter Wallnöfer [Sun, 13 Dec 2009 15:13:34 +0000 (16:13 +0100)]
s4:"samdb_set_password_sid" - clean up created objects correctly

- We should clean up such "helper" objects created in this function to don't
  have them around until "mem_ctx" is destroyed
- Remove a from my view pointless comment "This is a password set, not change"
  since an external argument "user_change" decides this ("modify" or "(re)set")

14 years agos4:operational LDB module - cosmetic - reorder an attribute list
Matthias Dieter Wallnöfer [Sat, 12 Dec 2009 16:59:05 +0000 (17:59 +0100)]
s4:operational LDB module - cosmetic - reorder an attribute list

This matches the default handling order in the "password_hash" module (it's nice
to have this consistent).

14 years agos3: Fix a very embarrassing build failure
Volker Lendecke [Sat, 12 Dec 2009 15:58:31 +0000 (16:58 +0100)]
s3: Fix a very embarrassing build failure

14 years agopidl: Introduce new dirrective: relative_short
Matthieu Patou [Thu, 10 Dec 2009 07:04:48 +0000 (10:04 +0300)]
pidl: Introduce new dirrective: relative_short

relative_short is like relative but instead of having the offset coded on 4 bytes
it's coded on 2 bytes. Such things happen in GET_DFS_REFERAL messages.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
14 years agolibrpc/ndr: add support for relative_short pointers
Matthieu Patou [Thu, 10 Dec 2009 07:04:48 +0000 (10:04 +0300)]
librpc/ndr: add support for relative_short pointers

relative_short is like relative but instead of having the offset coded on 4 bytes
it's coded on 2 bytes. Such things happen in GET_DFS_REFERAL messages.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
14 years agos4:utils/oLschema2ldif.c - remove (now) unused variables
Matthias Dieter Wallnöfer [Fri, 11 Dec 2009 19:19:16 +0000 (20:19 +0100)]
s4:utils/oLschema2ldif.c - remove (now) unused variables

14 years agos3:docs: document ldap deref
Björn Jacke [Fri, 11 Dec 2009 12:28:31 +0000 (13:28 +0100)]
s3:docs: document ldap deref

14 years agos3:loadparm: Change the "ldap deref" value "defualt" to "auto".
Karolin Seeger [Fri, 11 Dec 2009 10:56:26 +0000 (11:56 +0100)]
s3:loadparm:  Change the "ldap deref" value "defualt" to "auto".

That's an established value. Default is a bit confusing.

Karolin

14 years agos4:libnet/libnet_become_dc - Fix a small glitch in "becomeDC_drsuapi1_add_entry_send"
Matthias Dieter Wallnöfer [Fri, 11 Dec 2009 10:17:37 +0000 (11:17 +0100)]
s4:libnet/libnet_become_dc - Fix a small glitch in "becomeDC_drsuapi1_add_entry_send"

We shouldn't use the now uninitialised "status" variable anymore.

14 years agos3: add prototype to fix the build
Björn Jacke [Thu, 10 Dec 2009 22:19:26 +0000 (23:19 +0100)]
s3: add prototype to fix the build

14 years agos3-selftest: enable RPC-SAMBA3-WINREG.
Günther Deschner [Thu, 10 Dec 2009 19:38:32 +0000 (20:38 +0100)]
s3-selftest: enable RPC-SAMBA3-WINREG.

Very strange we didn't run it before.

Guenther

14 years agos3-rpcclient: allow to set offered size for enumkey command.
Günther Deschner [Wed, 9 Dec 2009 14:49:46 +0000 (15:49 +0100)]
s3-rpcclient: allow to set offered size for enumkey command.

Guenther

14 years agos4-smbtorture: add more spoolss_EnumPrinterKey tests for local NDR test.
Günther Deschner [Wed, 2 Dec 2009 23:35:03 +0000 (00:35 +0100)]
s4-smbtorture: add more spoolss_EnumPrinterKey tests for local NDR test.

Guenther

14 years agos3: make own defines for ldap deref types
Björn Jacke [Thu, 10 Dec 2009 21:22:54 +0000 (22:22 +0100)]
s3: make own defines for ldap deref types

there are too many naming clashes between different ldap libs and ldb libs.
Let's simply make our own defines. The numbers are well standarized. This also
makes the default for "ldap deref" be "default" which means we won't tell the
ldap library what to do. Ѕo by default it's all up to what the server and our
libs think they should to do.

14 years agos3: add LDAP Alias Dereferencing support
Björn Jacke [Thu, 10 Dec 2009 20:00:26 +0000 (21:00 +0100)]
s3: add LDAP Alias Dereferencing support

Thanks to Dan Cox for initial patch for 3.0. This closes #2350.

14 years agospoolss: remove unused spoolss_StringArray2.
Günther Deschner [Thu, 10 Dec 2009 13:23:49 +0000 (14:23 +0100)]
spoolss: remove unused spoolss_StringArray2.

Guenther

14 years agos4-smbtorture: fix and extend enum printerkey test.
Günther Deschner [Thu, 10 Dec 2009 13:21:12 +0000 (14:21 +0100)]
s4-smbtorture: fix and extend enum printerkey test.

Guenther

14 years agos3-spoolss: fix enumprinter key client and server.
Günther Deschner [Thu, 10 Dec 2009 13:20:22 +0000 (14:20 +0100)]
s3-spoolss: fix enumprinter key client and server.

Guenther

14 years agos3: re-run make samba3-idl.
Günther Deschner [Thu, 10 Dec 2009 13:27:33 +0000 (14:27 +0100)]
s3: re-run make samba3-idl.

Guenther