14 years agor17431: Fix bug #4003, reported by
Jeremy Allison [Sat, 5 Aug 2006 20:05:37 +0000 (20:05 +0000)]
r17431: Fix bug #4003, reported by
NTcancel doesn't send a reply, so in this case the signing
sequence number is only incremented by 1, not 2.
(This used to be commit 85841a01987e653a085af00c7c437145686a332b)

14 years agor17425: Add the multi-key wrapper. If it's necessary to add general blobs as keys,
Volker Lendecke [Sat, 5 Aug 2006 17:49:35 +0000 (17:49 +0000)]
r17425: Add the multi-key wrapper. If it's necessary to add general blobs as keys,
this can trivially be added later.

(This used to be commit 6915adb9780052952e4a1d9e1c3e6cac06f48463)

14 years agor17408: Let us use netgroups even without a NIS domain but just using files
Simo Sorce [Fri, 4 Aug 2006 22:18:02 +0000 (22:18 +0000)]
r17408: Let us use netgroups even without a NIS domain but just using files
(This used to be commit c065341d3ffc9125514f563c63d416cf7c40375f)

14 years agor17407: Don't do strchr_m twice when once will do.
Jeremy Allison [Fri, 4 Aug 2006 21:15:52 +0000 (21:15 +0000)]
r17407: Don't do strchr_m twice when once will do.
(This used to be commit b5f0b1b6447ac3c77558b32d97ce96d357ce15c0)

14 years agor17406: We need to do a translation of winbind separator -> '\\' in
Volker Lendecke [Fri, 4 Aug 2006 21:07:32 +0000 (21:07 +0000)]
r17406: We need to do a translation of winbind separator -> '\\' in
lookup_name_smbconf, otherwise

force user = domain+administrator

can not work. Also attempt to fix the 'valid users = domain+group' bug at the
same time.

(This used to be commit 255475901c13fde29b1b476560d969cc99712767)

14 years agor17404: Is this XP (extreme programming)? :-)
Volker Lendecke [Fri, 4 Aug 2006 20:43:21 +0000 (20:43 +0000)]
r17404: Is this XP (extreme programming)? :-)

With lp_workgroup we end up with remote names again...

(This used to be commit 250b9f353118bee4c080655f57d09011679deaf7)

14 years agor17403: add a helpful debug msg
Gerald Carter [Fri, 4 Aug 2006 20:39:37 +0000 (20:39 +0000)]
r17403: add a helpful debug msg
(This used to be commit 63325b36872c92d9f9fe04a185d7bd3ac525d84c)

14 years agor17402: Added lookup_name_smbconf() to be called when looking
Jeremy Allison [Fri, 4 Aug 2006 20:35:52 +0000 (20:35 +0000)]
r17402: Added lookup_name_smbconf() to be called when looking
up names from smb.conf. If the name is unqualified it
causes the lookup to be done in WORKGROUP\name, then
"Unix [users|groups]"\name rather than searching the
domain. Should fix the problems with "force user"
selecting a domain user by preference.
(This used to be commit 1e1fcb5eb2ac4bd360461b29f85c07dbf460025d)

14 years agor17401: BUG 3855: remove bits of XML and SQL checks from aclocal.m4
Gerald Carter [Fri, 4 Aug 2006 17:36:31 +0000 (17:36 +0000)]
r17401: BUG 3855: remove bits of XML and SQL checks from aclocal.m4
(This used to be commit 92ccdec33f8afb01335f9b775b5af11296ba2aa2)

14 years agor17399: Some C++ warnings
Volker Lendecke [Fri, 4 Aug 2006 12:15:53 +0000 (12:15 +0000)]
r17399: Some C++ warnings
(This used to be commit d12b08fc619f7b566ef5c4cc7294174e887014fe)

14 years agor17393: Remove Volker's ASSERT that num_groupsids > 0.
Jeremy Allison [Fri, 4 Aug 2006 01:09:57 +0000 (01:09 +0000)]
r17393: Remove Volker's ASSERT that num_groupsids > 0.
For guest connection they may well be zero.
This should fix up the buildfarm (fingers
(This used to be commit 16ebccbc5889c3b4c1a20bf3453bd523ddf6f5b0)

14 years agor17392: Commit Volker's fix for the valid users problem.
Jeremy Allison [Fri, 4 Aug 2006 00:00:15 +0000 (00:00 +0000)]
r17392: Commit Volker's fix for the valid users problem.
Let's look at the build farm now... :-).
(This used to be commit 6d822b85676f033a1a2e422e2d5ac92aaf566aef)

14 years agor17391: Revert the second part of the valid users fix - the
Jeremy Allison [Thu, 3 Aug 2006 23:44:07 +0000 (23:44 +0000)]
r17391: Revert the second part of the valid users fix - the
netlogon code uses pdb_get_group_sid() which could
return a S-1-1-22 unix sid. Who knew.... :-(.
I'm going to test Volker's fix instead. Once
3.0.23b is out we *have* to rip out the pdb_set_group_sid()
(This used to be commit 65003e1b251b4762cef2b3cdcc895269f9319eb8)

14 years agor17388: Fix the "valid users"/token issue for now. Volker,
Jeremy Allison [Thu, 3 Aug 2006 19:07:12 +0000 (19:07 +0000)]
r17388: Fix the "valid users"/token issue for now. Volker,
please come in and fix it in a less ugly way once
you have some time. Thanks,
(This used to be commit 79b1e668e2ce263c84ff8fafaafb3e57b06717ab)

14 years agor17386: fix inverted logic pointed out by Volker. When deleting a printer return...
Gerald Carter [Thu, 3 Aug 2006 15:19:01 +0000 (15:19 +0000)]
r17386: fix inverted logic pointed out by Volker.  When deleting a printer return access denied if the printer still exists after the delete_printer_hook() is called
(This used to be commit c05e2bdc0c068eb832035daea7962ab1a9e787b2)

14 years agor17383: Patch from Michael Adams <> to catch
Gerald Carter [Thu, 3 Aug 2006 12:41:20 +0000 (12:41 +0000)]
r17383: Patch from Michael Adams <> to catch
some memory leaks on error paths in net_ads_join()
(This used to be commit 24de2d83ff1d27400a89985126edee588bc415f3)

14 years agor17378: Fix the issues people have been having with mapped
Jeremy Allison [Thu, 3 Aug 2006 01:49:14 +0000 (01:49 +0000)]
r17378: Fix the issues people have been having with mapped
users (username map) and failure to connect to a
share. Essentially, even on a standalone system
we were going into the create_token_from_username()
code (I think by mistake) if the username was mapped.
Fixes bug #3991.

Volker & Jerry - please go over this with a very careful eye
and let me know if this isn't correct (I think it is,
but this isn't my code and it's a dangerous area for
me to be playing in :-).

(This used to be commit 0b5b2b53ec6e4c25b5f6645451dfce4aa7ae8a61)

14 years agor17376: Fix bug #3985 - ensure in msdfs we check for our
Jeremy Allison [Wed, 2 Aug 2006 16:18:45 +0000 (16:18 +0000)]
r17376: Fix bug #3985 - ensure in msdfs we check for our
netbios aliases. Reported by Björn Jacke <>.
Probably needs to be in 3.0.23b (if Björn approves
of the fix).
(This used to be commit e9e711fe37d9aec28b329dbfe2ad3ebfc1771825)

14 years agor17375: If a field containts only whitespace, we need to do base64 as well.
Volker Lendecke [Wed, 2 Aug 2006 09:32:18 +0000 (09:32 +0000)]
r17375: If a field containts only whitespace, we need to do base64 as well.

(This used to be commit 795d06f427061536c6e3a3eb5b5d60a27f5ec70d)

14 years agor17374: Get rid of a silly "System User" default for "description", also fetch the
Volker Lendecke [Wed, 2 Aug 2006 08:53:22 +0000 (08:53 +0000)]
r17374: Get rid of a silly "System User" default for "description", also fetch the

(This used to be commit 61e7ed593b944fa14330729e585d1f790af93a7b)

14 years agor17367: Reverting the ab code. Note I'm not saying this
Jeremy Allison [Tue, 1 Aug 2006 18:40:19 +0000 (18:40 +0000)]
r17367: Reverting the ab code. Note I'm not saying this
code is wrong or bad or anything, just that it
needs to be discussed & reviewed on the samba-technical
list before we add a platform-specific NFSv4 mapping.
That way lies a lot of future pain :-).
(This used to be commit 330899ec30ffceb798e3a8362d20e103e20b2897)

14 years agor17366: Save the logon script path from the info3 in the PAM session allowing
Günther Deschner [Tue, 1 Aug 2006 15:31:16 +0000 (15:31 +0000)]
r17366: Save the logon script path from the info3 in the PAM session allowing
other PAM modules to pick it up from there.

(This used to be commit b3ac5a586ba37b1122b0dc941dfee648fc4fa6d5)

14 years agor17365: Fix memleak.
Günther Deschner [Tue, 1 Aug 2006 15:17:18 +0000 (15:17 +0000)]
r17365: Fix memleak.

(This used to be commit 62a8e0b08919e71c6a575ce6d89d8a4a09acbd87)

14 years agor17364: Another NT4 join bug: The idealx tools set the primary group sid, and if...
Volker Lendecke [Tue, 1 Aug 2006 14:46:08 +0000 (14:46 +0000)]
r17364: Another NT4 join bug: The idealx tools set the primary group sid, and if we do
an update_sam_account later on, we want to also set it using the delete/add
method. As the idealx tools use the replace method, they don't care about what
has been in there before.

Jerry, this is a likely 3.0.23b candidate. Not merging, it's your call :-)

(This used to be commit f002a3633892fc040f0a6d076723c660bb82a41a)

14 years agor17363: Some C++ warnings
Volker Lendecke [Tue, 1 Aug 2006 12:45:12 +0000 (12:45 +0000)]
r17363: Some C++ warnings
(This used to be commit fd82f185a2e0f94bfb75f4eee072556ad94bf27d)

14 years agor17358: Re-add JFS2 NFS4 ACLs support, move readme for it into AIX-specific examples...
Alexander Bokovoy [Tue, 1 Aug 2006 09:25:24 +0000 (09:25 +0000)]
r17358: Re-add JFS2 NFS4 ACLs support, move readme for it into AIX-specific examples directory.
(This used to be commit c085355c323c65ee782516859eed8a76b53e6035)

14 years agor17356: Also transfer the sambaHomePath attribute.
Volker Lendecke [Tue, 1 Aug 2006 09:06:18 +0000 (09:06 +0000)]
r17356: Also transfer the sambaHomePath attribute.

(This used to be commit 49ad0d4d0eea85ef133e1a5c055305e06de109de)

14 years agor17354: Revert -r 17353 per Volker request while gpfs compatibility layer code will...
Alexander Bokovoy [Tue, 1 Aug 2006 08:27:19 +0000 (08:27 +0000)]
r17354: Revert -r 17353 per Volker request while gpfs compatibility layer code will be released.
(This used to be commit 5b1db0151461af18d994359e86c649922fc6de65)

14 years agor17353: Add support for JFS2 NFS4/AIXC and GPFS acls based on NFSv4 ACLs.
Alexander Bokovoy [Tue, 1 Aug 2006 07:38:36 +0000 (07:38 +0000)]
r17353: Add support for JFS2 NFS4/AIXC and GPFS acls based on NFSv4 ACLs.
(This used to be commit 72312cb2e255301f978455a559461ad83b13b6cb)

14 years agor17348: Some C++ warnings
Volker Lendecke [Mon, 31 Jul 2006 21:40:25 +0000 (21:40 +0000)]
r17348: Some C++ warnings
(This used to be commit ae6b9b34e59167e3958bfdb9997fa25340b9a0a3)

14 years agor17347: Some C++ warnings -- 271 left
Volker Lendecke [Mon, 31 Jul 2006 21:11:03 +0000 (21:11 +0000)]
r17347: Some C++ warnings -- 271 left
(This used to be commit 641dac4f85c0e00484d90726bea1a4cb58c8235c)

14 years agor17346: Add optimisation vl needs for the cluster code where
Jeremy Allison [Mon, 31 Jul 2006 20:58:02 +0000 (20:58 +0000)]
r17346: Add optimisation vl needs for the cluster code where
we don't get the chainlock when getting the byte range
lock record read-only.
(This used to be commit fcd798ca0c1b76adb2bcda4a99c40c7aacb0addb)

14 years agor17345: Some C++ warnings
Volker Lendecke [Mon, 31 Jul 2006 20:51:55 +0000 (20:51 +0000)]
r17345: Some C++ warnings
(This used to be commit 21c8fa2fc8bfd35d203b089ff61efc7c292b4dc0)

14 years agor17338: Add support for multiple shares test inspired by Samba 4 torture's --unclist...
Alexander Bokovoy [Mon, 31 Jul 2006 09:41:25 +0000 (09:41 +0000)]
r17338: Add support for multiple shares test inspired by Samba 4 torture's --unclist option. Triggered by -b sharelist_file option.
Based on Peter Samogyi's work. I'm not sure what concept for fstring replacement is currently in place though (talloc-ed strings? or it was for pstring only?)
(This used to be commit c9f8fafad698c5bc75df86ee8b611104d3fb65bc)

14 years agor17335: Some more fixes to net rpc vampire ldif. Still not good though :-(
Volker Lendecke [Mon, 31 Jul 2006 06:01:54 +0000 (06:01 +0000)]
r17335: Some more fixes to net rpc vampire ldif. Still not good though :-(

(This used to be commit e947f4bd91fcfa0dd27d12e8188ada381da541ff)

14 years agor17334: Some C++ warnings
Volker Lendecke [Mon, 31 Jul 2006 04:30:55 +0000 (04:30 +0000)]
r17334: Some C++ warnings
(This used to be commit 8ae7ed1f3cecbb5285313d17b5f9511e2e622f0b)

14 years agor17333: Some C++ warnings
Volker Lendecke [Mon, 31 Jul 2006 03:53:39 +0000 (03:53 +0000)]
r17333: Some C++ warnings
(This used to be commit be9aaffdaccae06c8c035eaf31862e34b7cfbe38)

14 years agor17316: More C++ warnings -- 456 left
Volker Lendecke [Sun, 30 Jul 2006 16:36:56 +0000 (16:36 +0000)]
r17316: More C++ warnings -- 456 left
(This used to be commit 1e4ee728df7eeafc1b4d533240acb032f73b4f5c)

14 years agor17315: Make talloc and tdb C++-warning-free. Would this also be interesting in talloc
Volker Lendecke [Sun, 30 Jul 2006 10:42:11 +0000 (10:42 +0000)]
r17315: Make talloc and tdb C++-warning-free. Would this also be interesting in talloc
and tdb "upstream"?

(This used to be commit 68c43191c8aa4faa9801e0ab084a216ceaf4379d)

14 years agor17314: Optimisation for POSIX locking. If we're downgrading
Jeremy Allison [Sat, 29 Jul 2006 19:14:24 +0000 (19:14 +0000)]
r17314: Optimisation for POSIX locking. If we're downgrading
a POSIX lock (applying a read-lock) and we overlap
pending read locks then send them an unlock message,
we may have allowed them to proceed.
(This used to be commit a7a0b6ba50f4cf7c5a0a29809fdff9e1266a29e7)

14 years agor17313: Non-Ascii attribute values need to be encoded as base64, with an attribute
Volker Lendecke [Sat, 29 Jul 2006 17:33:48 +0000 (17:33 +0000)]
r17313: Non-Ascii attribute values need to be encoded as base64, with an attribute
name attr:: instead of attr:

German domains tend to have umlauts in group names.

More to come tomorrow.

(This used to be commit 94cdd5d64cfaa5228209eebbb76244da0bf4b518)

14 years agor17312: Do some reformatting on net rpc samsync ldif. Not doing this checkin easily,
Volker Lendecke [Sat, 29 Jul 2006 15:45:19 +0000 (15:45 +0000)]
r17312: Do some reformatting on net rpc samsync ldif. Not doing this checkin easily,
as this puts me into svn blame in places I'm not sure I want my name to show

(This used to be commit d00e73c49b5227db61d41a017eb9b71d9e7e2620)

14 years agor17307: Add datarootdir setting (required for newer autoconfs)
Jelmer Vernooij [Sat, 29 Jul 2006 11:33:04 +0000 (11:33 +0000)]
r17307: Add datarootdir setting (required for newer autoconfs)
(This used to be commit 86687b804a60973883965700e755686e7d7d24f3)

14 years agor17296: Replace the understandable parts of the quota
Jeremy Allison [Fri, 28 Jul 2006 23:16:52 +0000 (23:16 +0000)]
r17296: Replace the understandable parts of the quota
code with become_root_uid_only()/unbecome_root_uid_only()
pairs. This code needs working on.....
(This used to be commit 0661d4e26614180636bc57de0c48adf8b9ce7a21)

14 years agor17295: Back out the become_root_uid_only change on the POSIX
Jeremy Allison [Fri, 28 Jul 2006 23:09:12 +0000 (23:09 +0000)]
r17295: Back out the become_root_uid_only change on the POSIX
acls code. I'm pretty sure this was safe, but become_root()
does other things to the token stack that become_root_uid_only()
does not, and as we're going into a vfs redirectred function
I decided it wasn't safe for now.
(This used to be commit b3e0f45488595aa96c852dab8e1349631a85dded)

14 years agor17294: Make the code a little cleaner. Instead of using the two
Jeremy Allison [Fri, 28 Jul 2006 22:56:41 +0000 (22:56 +0000)]
r17294: Make the code a little cleaner. Instead of using the two
calls make it :


saving errno across the second call. Most of our internal
change calls can be replaced with these simple calls.

(This used to be commit 4143aa83c029848d8ec741d9218b3fa6e3fd28dd)

14 years agor17293: After the results from the cluster tests in Germany,
Jeremy Allison [Fri, 28 Jul 2006 22:42:39 +0000 (22:42 +0000)]
r17293: After the results from the cluster tests in Germany,
fix the messaging code to call the efficient calls :




instead of using heavyweight become_root()/unbecome_root()
pairs around all messaging code. Fixup the messaging
code to ensure sec_init() is called (only once) so that non-root
processes still work when sending messages.

This is a lighter weight solution to become_root()/unbecome_root()
(which swaps all the supplemental groups) and should be more
efficient. I will migrate all server code over to using this
(a similar technique should be used in the passdb backend
where needed).

(This used to be commit 4ace291278d9a44f5c577bdd3b282c1231e543df)

14 years agor17292: Try and fix bug #3967 - signing problems on trans
Jeremy Allison [Fri, 28 Jul 2006 21:23:53 +0000 (21:23 +0000)]
r17292: Try and fix bug #3967 - signing problems on trans
calls introduced by signing code simplification.
Please test if you've seen signing problems with
(This used to be commit f462daf02c12cfba634f92e681eb23a09e7d0acf)

14 years agor17291: Fix memory leaks on early exit path.
Jeremy Allison [Fri, 28 Jul 2006 20:35:00 +0000 (20:35 +0000)]
r17291: Fix memory leaks on early exit path.
(This used to be commit deaac5bd463e5b8fd0b9915b553fdac3a4271293)

14 years agor17279: conn->cnum is the tid we've given to the client. This has nothing to do with
Volker Lendecke [Thu, 27 Jul 2006 17:23:57 +0000 (17:23 +0000)]
r17279: conn->cnum is the tid we've given to the client. This has nothing to do with
our internal share number.

Funny that it worked at all :-)

(This used to be commit afa6e9094604afe1ef929cd936fbfa07b5473fd2)

14 years agor17276: Don't change the POSIX lock ref count if posix locking = no.
Jeremy Allison [Thu, 27 Jul 2006 15:23:46 +0000 (15:23 +0000)]
r17276: Don't change the POSIX lock ref count if posix locking = no.
(This used to be commit 42dec2192c1261090f2fac7a123c384f5c133587)

14 years agor17271: Fix a regression in the ldapsam uri syntax.
Gerald Carter [Thu, 27 Jul 2006 12:20:19 +0000 (12:20 +0000)]
r17271: Fix a regression in the ldapsam uri syntax.
Allow multiple LDAP URIs to be grouped by  ""
(This used to be commit 21d69dcb3c5361f94d15b2d186e1aae6e246a24e)

14 years agor17262: After messages from Metze and traces from Karolin Seeger,
Jeremy Allison [Wed, 26 Jul 2006 17:24:54 +0000 (17:24 +0000)]
r17262: After messages from Metze and traces from Karolin Seeger,
turns out that EDQUOTA must map to NT_STATUS_DISK_FULL
for Windows apps to work correctly. My mistake.
(This used to be commit de1e3f7a7ae9e8a41b45130e2cdfc22f43cf53b5)

14 years agor17260: remove extra ;SAMBA_3_0_23/source/utils/netlookup.c
Gerald Carter [Wed, 26 Jul 2006 16:47:58 +0000 (16:47 +0000)]
r17260: remove extra ;SAMBA_3_0_23/source/utils/netlookup.c
(This used to be commit c152d20e9073eb741047cc4b5f8e8086e2bc9ddd)

14 years agor17258: Cleanup the 'net ads help join' output and document createupn
Gerald Carter [Wed, 26 Jul 2006 15:26:51 +0000 (15:26 +0000)]
r17258: Cleanup the 'net ads help join' output and document createupn
and createcomputer options
(This used to be commit 87be77bf35635fc925e1be36073571f8c6ec3e81)

14 years agor17254: Simple flattening of an if-statement, no logic change.
Volker Lendecke [Wed, 26 Jul 2006 08:08:48 +0000 (08:08 +0000)]
r17254: Simple flattening of an if-statement, no logic change.

Jeremy, I'm sure you will look at this nevertheless :-)

(This used to be commit 3ef34468b55771b6f6b54454fa6c9decc183c565)

14 years agor17249: Ensure we only set the FILE_WRITE_DATA on O_TRUNC
Jeremy Allison [Wed, 26 Jul 2006 04:42:18 +0000 (04:42 +0000)]
r17249: Ensure we only set the FILE_WRITE_DATA on O_TRUNC
in one place.
(This used to be commit f326bae3e269046b6f087626240cddbb5dafb0e4)

14 years agor17248: Ensure we definately add the WRITE_DATA on O_TRUNC.
Jeremy Allison [Wed, 26 Jul 2006 02:15:01 +0000 (02:15 +0000)]
r17248: Ensure we definately add the WRITE_DATA on O_TRUNC.
(This used to be commit 8eed82d5d5ba34cc0a6b99b9d0df45eec5f788fa)

14 years agor17247: When we map generic to specific we need to remember
Jeremy Allison [Wed, 26 Jul 2006 01:53:23 +0000 (01:53 +0000)]
r17247: When we map generic to specific we need to remember
to copy over the copy of the access_mask, open_access_mask.
Jerry - this is a definate fix for a 3.0.23b and should also
be on the patches page. CIFSFS breaks without this.
(This used to be commit d11e71ebcccf6907f2404a04aa6bf61b12ab2709)

14 years agor17246: BUG 3964: lower case username prior to getpwnam() call in smbpasswd
Gerald Carter [Tue, 25 Jul 2006 21:48:13 +0000 (21:48 +0000)]
r17246: BUG 3964: lower case username prior to getpwnam() call in smbpasswd
(This used to be commit dc4fec1f7d196cf7e18d4dd58149853011380ef9)

14 years agor17245: Second part of fix for #3962. Don't do a double
Jeremy Allison [Tue, 25 Jul 2006 21:33:13 +0000 (21:33 +0000)]
r17245: Second part of fix for #3962. Don't do a double
free in the infolevel2 case. Free both queue and
NT_PRINTER_INFO_LEVEL in the same place.
(This used to be commit 6ac3a4ce78f42949013ae7bd675ff292fb0383ca)

14 years agor17244: There were several error paths where NT_PRINTER_INFO_LEVEL
Jeremy Allison [Tue, 25 Jul 2006 21:23:34 +0000 (21:23 +0000)]
r17244: There were several error paths where NT_PRINTER_INFO_LEVEL
wasn't being freed - also one enum jobs case where the
NT_PRINTER_INFO_LEVEL and queue weren't being freed.
Strange that Coverity or Klokwork didn't pick these up.
Hopefully will fix #3962.
(This used to be commit bb264123872bfec42ad85ec0c8afa3a8c7d1811e)

14 years agor17242: BUG 3957: make sure to zero memory in the SRV hostlist in case there is not...
Gerald Carter [Tue, 25 Jul 2006 20:11:03 +0000 (20:11 +0000)]
r17242: BUG 3957: make sure to zero memory in the SRV hostlist in case there is not an A record for each SRV name
(This used to be commit 42608b8bb974e1bd88cf2105bf1774622c045458)

14 years agor17239: BUG 3959: patch from William Charles <> to fix a segv...
Gerald Carter [Tue, 25 Jul 2006 19:59:35 +0000 (19:59 +0000)]
r17239: BUG 3959: patch from William Charles <> to fix a segv in the DNS SRV lookups dur to calling rand()
(This used to be commit be12519fd8a7ccd8400fd298e05921eda56b4e16)

14 years agor17234: Fix error mappings for EQUOTA and ENOBUFS.
Jeremy Allison [Tue, 25 Jul 2006 16:48:08 +0000 (16:48 +0000)]
r17234: Fix error mappings for EQUOTA and ENOBUFS.
Based on an idea from Shlomi Yaakobovich <>.
(This used to be commit 9c440925f879d1e4ef99d04e2dfbe41077869204)

14 years agor17231: Some patch cosmetics
Volker Lendecke [Tue, 25 Jul 2006 14:59:32 +0000 (14:59 +0000)]
r17231: Some patch cosmetics
(This used to be commit 736e55101b1e7cc22f043b836be877afbb031edf)

14 years agor17229: Indent-style reformatting -- getting used to the code again :-)
Volker Lendecke [Tue, 25 Jul 2006 08:51:54 +0000 (08:51 +0000)]
r17229: Indent-style reformatting -- getting used to the code again :-)
(This used to be commit 2e400fb0077ccef38fff28ef037f982624b7815b)

14 years agor17228: Modest reformatting
Volker Lendecke [Tue, 25 Jul 2006 08:40:04 +0000 (08:40 +0000)]
r17228: Modest reformatting
(This used to be commit 640b4297a400fe23418e9c1c01d4c14ce3bde5b4)

14 years agor17220: If we're going to fail a write with an errno, make
Jeremy Allison [Tue, 25 Jul 2006 00:16:45 +0000 (00:16 +0000)]
r17220: If we're going to fail a write with an errno, make
sure we return -1.
(This used to be commit 89b83237b03066785ca4bf3b9d120519bddeffad)

14 years agor17217: Fix a couple of "smbldap_open(): Cannot open when not root" bugs
Gerald Carter [Mon, 24 Jul 2006 12:05:20 +0000 (12:05 +0000)]
r17217: Fix a couple of "smbldap_open(): Cannot open when not root" bugs
when viewing or modifying local group membership.
(This used to be commit 41e30a9666e1fb736cd2ba8a5ad9285fcde50d47)

14 years agor17216: From Kai Blin <>:
Andrew Bartlett [Mon, 24 Jul 2006 05:02:38 +0000 (05:02 +0000)]
r17216: From Kai Blin <>:

A patch to make ntlm_auth recognize three new commands in
ntlmssp-client-1 and squid-2.5-ntlmssp:

The commands are the following:

Command: SF <hex number>
Reply: OK
Description: Takes feature request flags similar to samba4's
gensec_want_feature() call. So far, only NTLMSSP_FEATURE_SESSION_KEY,
NTLMSSP_FEATURE_SIGN and NTLMSSP_FEATURE_SEAL are implemented, using the same
values as the corresponding GENSEC_FEATURE_* flags in samba4.

Command: GF
Reply: GF <hex number>
Description: Returns the negotiated flags.

Command: GK
Reply: GK <base64 encoded session key>
Description: Returns the negotiated session key.

(These commands assist a wine project to use ntlm_auth for signing and
sealing of bulk data).

Andrew Bartlett
(This used to be commit bd3e06a0e4435f1c48fa3b7862333efe273119ee)

14 years agor17199: Add comment to the RID/SID miracle
Volker Lendecke [Sun, 23 Jul 2006 08:18:31 +0000 (08:18 +0000)]
r17199: Add comment to the RID/SID miracle
(This used to be commit 4c4ae01c671bd35687af686a34824a96828e6b25)

14 years agor17198: Fix wins_nss dependencies
Alexander Bokovoy [Sun, 23 Jul 2006 03:33:28 +0000 (03:33 +0000)]
r17198: Fix wins_nss dependencies
(This used to be commit c005049043b01e85d42a9c230ed3c41f1a1e185e)

14 years agor17194: To run rpc-samba3-lsa in the build farm, we can't rely on geteuid()==0. Adapt
Volker Lendecke [Sat, 22 Jul 2006 20:46:02 +0000 (20:46 +0000)]
r17194: To run rpc-samba3-lsa in the build farm, we can't rely on geteuid()==0. Adapt
it to other "Am I root?" checks.

Jerry, Jeremy, please check this!


(This used to be commit f777b2d294f7258e676976d7807adbb644c85a2f)

14 years agor17192: Make this actually survive valgrind. We NEED pidl here...
Volker Lendecke [Sat, 22 Jul 2006 19:44:17 +0000 (19:44 +0000)]
r17192: Make this actually survive valgrind. We NEED pidl here...

Maybe bzr is not such a bad idea, then you would probably see less spam on
samba-cvs, sorry for that... :-)

(This used to be commit 41456b498a181c70707ca1ea80288bd7bdcadcdf)

14 years agor17191: Forgotten file, sorry!
Volker Lendecke [Sat, 22 Jul 2006 19:34:10 +0000 (19:34 +0000)]
r17191: Forgotten file, sorry!
(This used to be commit 32fbf66a4be3d1cc0251f00e54020bf2dbd0dfb0)

14 years agor17190: Remove a warning from "opi", a 64-bit machine
Volker Lendecke [Sat, 22 Jul 2006 19:29:02 +0000 (19:29 +0000)]
r17190: Remove a warning from "opi", a 64-bit machine
(This used to be commit 844c98eab475ea047aeaae3ef1250897413cc823)

14 years agor17188: Dump lsa_lookupsids3. I could not make it work at all against W2k3, the
Volker Lendecke [Sat, 22 Jul 2006 19:15:22 +0000 (19:15 +0000)]
r17188: Dump lsa_lookupsids3. I could not make it work at all against W2k3, the
rpc-lsa test even considers NT_STATUS_RPC_PROTSEQ_NOT_SUPPORTED not to be an

Before someone re-activates this, show me a working sniff please :-)

(This used to be commit b185fb9fa61d89b612870c2fdd9e112c9e7ae57c)

14 years agor17184: Attempt to get rid of some warnings on HP/UX. Without _XOPEN_SOURCE_EXTENDED
Volker Lendecke [Sat, 22 Jul 2006 16:40:58 +0000 (16:40 +0000)]
r17184: Attempt to get rid of some warnings on HP/UX. Without _XOPEN_SOURCE_EXTENDED
#defined getsockopt uses an int* as socklen parameter.

(This used to be commit 0b78da62f7481c6b3d46eb2f1b586d20b0b10ca5)

14 years agor17183: LsaLookupSids() shoudl return the string form of a SID when
Gerald Carter [Sat, 22 Jul 2006 00:53:19 +0000 (00:53 +0000)]
r17183: LsaLookupSids() shoudl return the string form of a SID when
it cannot be mapped and not the hex of the RID.  Who wrote that?
(This used to be commit 4e51cf34cf4cbe77957d754952369df3a180f974)

14 years agor17181: Fix the build farm RAW-READ bug. When making a copy
Jeremy Allison [Fri, 21 Jul 2006 22:02:54 +0000 (22:02 +0000)]
r17181: Fix the build farm RAW-READ bug. When making a copy
of the lock array in order to delete them individually
it's also important to make a copy of the *size* of
this array. Otherwise the unlock decrements the termination
index of your for loop :-). Doh ! Big thanks to Volker
for showing me how to set up the build farm to track
this one down. This is not a 3.0.23a issue.
(This used to be commit 2c82a159ae6a4cc83989f2b453508358db516d67)

14 years agor17179: Merge the vl-posixacls tmp branch into mainline. It
Jim McDonough [Fri, 21 Jul 2006 15:51:34 +0000 (15:51 +0000)]
r17179: Merge the vl-posixacls tmp branch into mainline. It
modularizes our interface into the special posix API used on
the system. Without this patch the specific API flavor is
determined at compile time, something which severely limits
usability on systems with more than one file system. Our
first targets are AIX with its JFS and JFS2 APIs, at a later
stage also GPFS. But it's certainly not limited to IBM
stuff, this abstraction is also necessary for anything that
copes with NFSv4 ACLs. For this we will check in handling
very soon.

Major contributions can be found in the copyright notices as
well as the checkin log of the vl-posixacls branch. The
final merge to 3_0 post-3.0.23 was done by Peter Somogyi
(This used to be commit ca0c73f281a2a65a988094a46bb3e46a94011a53)

14 years agor17177: Get rid of a global variable by adding a private data pointer to
Volker Lendecke [Fri, 21 Jul 2006 14:13:30 +0000 (14:13 +0000)]
r17177: Get rid of a global variable by adding a private data pointer to

(This used to be commit f97f6cedffdc4d10afcac90a163b93a801acf514)

14 years agor17172: Fix typo.
John Terpstra [Fri, 21 Jul 2006 01:58:17 +0000 (01:58 +0000)]
r17172: Fix typo.
(This used to be commit 421cb6f728be7821b537d00cdd05d05f1490eb3f)

14 years agor17162: Fix typo small typos noticed by Paul Green.
Gerald Carter [Thu, 20 Jul 2006 20:23:04 +0000 (20:23 +0000)]
r17162: Fix typo small typos noticed by Paul Green.
(This used to be commit 1a5874588686fb4ece9be70059ff75b975ed2bd5)

14 years agor17159: Bug 3920: Restore wnibind use default domain behavior for domain groups.
Gerald Carter [Thu, 20 Jul 2006 18:02:51 +0000 (18:02 +0000)]
r17159: Bug 3920: Restore wnibind use default domain behavior for domain groups.
This break local users and 'winbind nested groups' on domain members.
Cannot be helped.

My plans is to move the default domain crud to the client code (pam and
nss libraries) in 3.0.24.
(This used to be commit 8ee22eeab5d06008b363f8bb250dc767ddfbb86a)

14 years agor17158: Add two new options to 'net ads join'
Gerald Carter [Thu, 20 Jul 2006 14:39:06 +0000 (14:39 +0000)]
r17158: Add two new options to 'net ads join'

  * createupn=[host_upn@realm]
  * createcomputer=<ou path top to bottom> (this was previously
    the only arg)
(This used to be commit 75054e984e5ca7249b1327630db9d09da974a54e)

14 years agor17152: Don't handle the delete pending here, await
Jeremy Allison [Wed, 19 Jul 2006 21:03:03 +0000 (21:03 +0000)]
r17152: Don't handle the delete pending here, await
(This used to be commit 11bab9d57958659c71f053fe8dc0f9156c9f3c1f)

14 years agor17151: revert a few accidental commits to the Makefile
Gerald Carter [Wed, 19 Jul 2006 21:02:03 +0000 (21:02 +0000)]
r17151: revert a few accidental commits to the Makefile
(This used to be commit 3fea233802dd2f6a5528fdb183a2ff30d572020d)

14 years agor17150: MMC User & group plugins fixes:
Gerald Carter [Wed, 19 Jul 2006 20:59:04 +0000 (20:59 +0000)]
r17150: MMC User & group plugins fixes:

* Make sure to lower case all usernames before
  calling the create, delete, or rename hooks.
* Preserve case for usernames in passdb
* Flush the getpwnam cache after renaming a user
* Add become/unbecome root block in _samr_delete_dom_user()
  when trying to verify the account's existence.
(This used to be commit bbe11b7a950e7d85001f042bbd1ea3bf33ecda7b)

14 years agor17149: Fail the join if we cannot set any SPNs for the machine account.
Gerald Carter [Wed, 19 Jul 2006 20:56:11 +0000 (20:56 +0000)]
r17149: Fail the join if we cannot set any SPNs for the machine account.
Disable the one we created and whine.
(This used to be commit 1a7e81a4a8955e643d1c8a54365221a9e2ed8a12)

14 years agor17148: the wins service should not accept any controls so that a GUI can grey it...
Gerald Carter [Wed, 19 Jul 2006 20:54:39 +0000 (20:54 +0000)]
r17148: the wins service should not accept any controls so that a GUI can grey it out as not remotely manageable
(This used to be commit 859c51cf25a2bb80787a5060156f09c2f0142dfb)

14 years agor17147: Install fixes for libraries
Gerald Carter [Wed, 19 Jul 2006 20:54:02 +0000 (20:54 +0000)]
r17147: Install fixes for libraries
(This used to be commit 72bac13f21bf2c71538e3b3bafa0fc447e1e8af8)

14 years agor17146: Starting to cleanout my local tree some
Gerald Carter [Wed, 19 Jul 2006 20:53:10 +0000 (20:53 +0000)]
r17146: Starting to cleanout my local tree some

* add code to lookup NS records (in prep for later coe that
  does DNS updates as part of the net ads join)
(This used to be commit 36d4970646638a2719ebb05a091c951183535987)

14 years agor17142: Ensure we record the correct can_read/can_write
Jeremy Allison [Wed, 19 Jul 2006 18:45:25 +0000 (18:45 +0000)]
r17142: Ensure we record the correct can_read/can_write
from the client requested access mask.
(This used to be commit 12490fafc7f98952bf709c4c504f8f2b5646f197)

14 years agor17140: Get rid of the lock release/reacquire code ! Turns out
Jeremy Allison [Wed, 19 Jul 2006 18:34:19 +0000 (18:34 +0000)]
r17140: Get rid of the lock release/reacquire code ! Turns out
that create dispositions that cause O_TRUNC break
oplocks. This simplifies the code - although we have
to keep separate the client requested access mask and
the access mask we actually use to open the file.
(This used to be commit 3bcd52a4752ec6c2a8f678afa3b7b3646103ad60)

14 years agor17138: In preparation for the cluster merge, add an empty configure option :-)
Volker Lendecke [Wed, 19 Jul 2006 16:28:20 +0000 (16:28 +0000)]
r17138: In preparation for the cluster merge, add an empty configure option :-)

(This used to be commit 906720649b4a6c9de9fb6e248e573d3e8fd00ead)

14 years agor17136: Fix alignment on lsaquery. This broke in particular level 6, where the client
Volker Lendecke [Wed, 19 Jul 2006 15:05:06 +0000 (15:05 +0000)]
r17136: Fix alignment on lsaquery. This broke in particular level 6, where the client
tried to figure out which role we are.

Needs to go into 23a.

Thanks to Karolin for insisting and setting up the test case :-)

(This used to be commit 3482bb1ef57e60397df8dcf1b29999161359c42a)

14 years agor17134: Fix a debug message
Volker Lendecke [Wed, 19 Jul 2006 10:42:50 +0000 (10:42 +0000)]
r17134: Fix a debug message
(This used to be commit 40e267981174840f4f36d1863985ee010ef5074a)

14 years agor17131: Optimisation - when doing a stat open don't open the
Jeremy Allison [Wed, 19 Jul 2006 05:32:12 +0000 (05:32 +0000)]
r17131: Optimisation - when doing a stat open don't open the
file unless we really have to (ie. O_CREAT and file
doesn't exist).
(This used to be commit 788aa15ea24e6dfb61820465b5b881829a64297a)