12 years agos3:Makefile: add LIBREPLACE_LIBS for talloc, tdb and wbclient
Björn Jacke [Sat, 31 Oct 2009 09:37:44 +0000 (10:37 +0100)]
s3:Makefile: add LIBREPLACE_LIBS for talloc, tdb and wbclient

12 years agoѕ3:buildsystem: fix depenencies for libreplace
Björn Jacke [Fri, 30 Oct 2009 18:54:52 +0000 (19:54 +0100)]
ѕ3:buildsystem: fix depenencies for libreplace

This problem became visible after adding the picky -z defs linker option: On
Solaris libreplace had unresolved symbols, which showed up in the libtalloc
build. PAM_WINBIND_EXTRA_LIBS and WINBIND_NSS_EXTRA_LIBS had been workarounds
to make things work at two placeѕ. These variables have been obsoleted now.
This patch introduces LIBREPLACE_LIBS which contans the linker flags needed for
linking anything using libreplace.

12 years agoѕ3:ldap: search for account policies in objectclass sambaDomain, not *
Björn Jacke [Fri, 30 Oct 2009 20:50:41 +0000 (21:50 +0100)]
ѕ3:ldap: search for account policies in objectclass sambaDomain, not *

12 years agos3/docs: Fix typo.
Karolin Seeger [Fri, 30 Oct 2009 15:47:22 +0000 (16:47 +0100)]
s3/docs: Fix typo.

Fix bug #4250. Thanks to TAKAHASHI Motonobu <> for reporting!


12 years agos3/docs: Remove reference to nonexistent file.
Karolin Seeger [Fri, 30 Oct 2009 15:31:55 +0000 (16:31 +0100)]
s3/docs: Remove reference to nonexistent file.

Fix bug #4252. Thanks to TAKAHASHI Motonobu <> for reporting!


12 years agos4:nbt_server/wins/winsdb - Fix "const" warning
Matthias Dieter Wallnöfer [Sat, 17 Oct 2009 20:31:34 +0000 (22:31 +0200)]
s4:nbt_server/wins/winsdb - Fix "const" warning

12 years agos4-smbtorture: skip bigendian tests against s3 in RPC-LSA-SECRETS.
Günther Deschner [Thu, 29 Oct 2009 13:50:56 +0000 (14:50 +0100)]
s4-smbtorture: skip bigendian tests against s3 in RPC-LSA-SECRETS.


12 years agos3-rpcclient: add deletetrustdom command.
Günther Deschner [Wed, 28 Oct 2009 14:37:11 +0000 (15:37 +0100)]
s3-rpcclient: add deletetrustdom command.


12 years agos3-rpcclient: add createtrustdom command.
Günther Deschner [Wed, 28 Oct 2009 13:13:32 +0000 (14:13 +0100)]
s3-rpcclient: add createtrustdom command.


12 years agos3-lsa: expand struct lsa_info to carry name and sd.
Günther Deschner [Thu, 29 Oct 2009 22:50:20 +0000 (23:50 +0100)]
s3-lsa: expand struct lsa_info to carry name and sd.


12 years agos3-lsa: use switch in _lsa_QuerySecurity().
Günther Deschner [Thu, 29 Oct 2009 11:36:30 +0000 (12:36 +0100)]
s3-lsa: use switch in _lsa_QuerySecurity().


12 years agos4-smbtorture: fix warning in RPC-WKSSVC torture test.
Günther Deschner [Fri, 30 Oct 2009 11:13:21 +0000 (12:13 +0100)]
s4-smbtorture: fix warning in RPC-WKSSVC torture test.


12 years agos4:kdc/hdb-samba4 - Remove unused variable
Matthias Dieter Wallnöfer [Fri, 30 Oct 2009 11:13:26 +0000 (12:13 +0100)]
s4:kdc/hdb-samba4 - Remove unused variable

12 years agoChange RAW-STREAMS for s3 to allow rename over an existing stream,
Jeremy Allison [Thu, 29 Oct 2009 23:38:34 +0000 (16:38 -0700)]
Change RAW-STREAMS for s3 to allow rename over an existing stream,
we need to file a CAR to find out why Windows gives INVALID_PARAMETER
for this.

12 years agoStart fixing the RAW-STREAMS test - ensure that the xattr
Jeremy Allison [Thu, 29 Oct 2009 23:14:12 +0000 (16:14 -0700)]
Start fixing the RAW-STREAMS test - ensure that the xattr
used to store the stream info in is not
seen in when enumerating EAs.

12 years agos3: Fix incorrect rc check of nscd_flush_cache.
Jim McDonough [Thu, 29 Oct 2009 15:11:43 +0000 (11:11 -0400)]
s3: Fix incorrect rc check of nscd_flush_cache.

At least this only resulted in an incorrect debug message.

12 years agos3-secrets: use autogenerated code for TRUSTED_DOM_PASS struct parsing from a tdb.
Günther Deschner [Wed, 28 Oct 2009 15:42:44 +0000 (16:42 +0100)]
s3-secrets: use autogenerated code for TRUSTED_DOM_PASS struct parsing from a tdb.


12 years agos3: add secrets.idl.
Günther Deschner [Wed, 28 Oct 2009 15:21:53 +0000 (16:21 +0100)]
s3: add secrets.idl.


12 years agotdb: update README a bit
Kirill Smelkov [Wed, 21 Oct 2009 17:18:58 +0000 (21:18 +0400)]
tdb: update README a bit

While studying tdb, I've noticed a couple of mismatches between readme
and actual code:

- tdb_open_ex changed it's log_fn argument to log_ctx
- there is now no tdb_update(), which it seems was transformed into
  non-exported tdb_update_hash()

There were other mismatches, but I don't remember them now, sorry.

Signed-off-by: Kirill Smelkov <>
Signed-off-by: Rusty Russell <>
12 years agotdb: add tests for double .close() in pytdb
Kirill Smelkov [Wed, 21 Oct 2009 17:18:57 +0000 (21:18 +0400)]
tdb: add tests for double .close() in pytdb

The reason I do it is that when using older python-tdb as shipped in
Debian Lenny, python interpreter crashes on this test:

    (gdb) bt
    #0  0xb7f8c424 in __kernel_vsyscall ()
    #1  0xb7df5640 in raise () from /lib/i686/cmov/
    #2  0xb7df7018 in abort () from /lib/i686/cmov/
    #3  0xb7e3234d in __libc_message () from /lib/i686/cmov/
    #4  0xb7e38624 in malloc_printerr () from /lib/i686/cmov/
    #5  0xb7e3a826 in free () from /lib/i686/cmov/
    #6  0xb7b39c84 in tdb_close () from /usr/lib/
    #7  0xb7b43e14 in ?? () from /var/lib/python-support/python2.5/
    #8  0x0a038d08 in ?? ()
    #9  0x00000000 in ?? ()

master's pytdb does not (we have a check for self->closed in obj_close()),
but still...

Signed-off-by: Kirill Smelkov <>
Signed-off-by: Rusty Russell <>
12 years agotdb: reset tdb->fd to -1 in tdb_close()
Kirill Smelkov [Wed, 21 Oct 2009 17:18:56 +0000 (21:18 +0400)]
tdb: reset tdb->fd to -1 in tdb_close()

So that erroneous double tdb_close() calls do not try to close() same
fd again. This is like SAFE_FREE() but for fd.

Signed-off-by: Kirill Smelkov <>
Signed-off-by: Rusty Russell <>
12 years agotdb: fix typo in python's Tdb.get() docstring
Kirill Smelkov [Wed, 21 Oct 2009 17:18:55 +0000 (21:18 +0400)]
tdb: fix typo in python's Tdb.get() docstring

It's Tdb.get(), not Tdb.fetch().

Signed-off-by: Kirill Smelkov <>
Signed-off-by: Rusty Russell <>
12 years agotdb: kill last bits from swig
Kirill Smelkov [Wed, 21 Oct 2009 17:18:54 +0000 (21:18 +0400)]
tdb: kill last bits from swig

We no longer use swig for pytdb, so there is no need for swig make
rules. Also pytdb.c header should be updated.

Signed-off-by: Kirill Smelkov <>
Signed-off-by: Rusty Russell <>
12 years agoFix map readonly in smb.conf, it is a single word
Simo Sorce [Wed, 28 Oct 2009 23:10:08 +0000 (19:10 -0400)]
Fix map readonly in smb.conf, it is a single word

12 years agoAdd in Metze's new code to ndr encode the user.DOSATTRIB
Stefan (metze) Metzmacher [Wed, 28 Oct 2009 22:42:47 +0000 (15:42 -0700)]
Add in Metze's new code to ndr encode the user.DOSATTRIB
blobs. Next I'll change the create timestamp and dos attribute
code to use this.

12 years agoFix bug 6572 - libsmbclient: unable to access 'msdfs proxy' share.
SATOH Fumiyasu [Wed, 28 Oct 2009 19:48:36 +0000 (12:48 -0700)]
Fix bug 6572 - libsmbclient: unable to access 'msdfs proxy' share.

12 years agos3:net: fix output of net rpc trustdom list
Björn Jacke [Wed, 28 Oct 2009 13:33:40 +0000 (14:33 +0100)]
s3:net: fix output of net rpc trustdom list

Move some messages from stderr to stdout. When some trusting DCs were
unreachable we lacked \n's on stdout which screwed up whole the output.

12 years agos3:configure: only check for gpfs_gpl.h
Stefan Metzmacher [Wed, 28 Oct 2009 10:21:27 +0000 (11:21 +0100)]
s3:configure: only check for gpfs_gpl.h

The header is everything we need in order to build vfs_gpfs.


Signed-off-by: Michael Adam <>
12 years agos3-passdb: move open_schannel_session_store() to passdb/secrets_schannel.c.
Günther Deschner [Wed, 28 Oct 2009 10:36:13 +0000 (11:36 +0100)]
s3-passdb: move open_schannel_session_store() to passdb/secrets_schannel.c.


12 years agos3-net: acct_flags are uint32_t in net_sam_set_userflag().
Günther Deschner [Wed, 28 Oct 2009 09:56:01 +0000 (10:56 +0100)]
s3-net: acct_flags are uint32_t in net_sam_set_userflag().


12 years agoadssearch: dump some more nttime timestamps.
Günther Deschner [Wed, 28 Oct 2009 09:55:14 +0000 (10:55 +0100)]
adssearch: dump some more nttime timestamps.


12 years agos3-lsa: add lsa_trusted_domain_mapping.
Günther Deschner [Tue, 27 Oct 2009 14:29:02 +0000 (15:29 +0100)]
s3-lsa: add lsa_trusted_domain_mapping.


12 years agolsa: add LSA_TRUSTED_DOMAIN access masks.
Günther Deschner [Tue, 27 Oct 2009 14:28:06 +0000 (15:28 +0100)]
lsa: add LSA_TRUSTED_DOMAIN access masks.


12 years agos3-passdb: add secrets_delete_generic().
Günther Deschner [Tue, 27 Oct 2009 13:59:25 +0000 (14:59 +0100)]
s3-passdb: add secrets_delete_generic().


12 years agos3-lsa: add lsa_secret_mapping.
Günther Deschner [Tue, 27 Oct 2009 12:50:43 +0000 (13:50 +0100)]
s3-lsa: add lsa_secret_mapping.


12 years agolsa: add LSA_SECRET access masks.
Günther Deschner [Tue, 27 Oct 2009 12:49:21 +0000 (13:49 +0100)]
lsa: add LSA_SECRET access masks.


12 years agos3-lsa: use correct function name in_lsa_RemoveAccountRights().
Günther Deschner [Mon, 26 Oct 2009 22:47:01 +0000 (23:47 +0100)]
s3-lsa: use correct function name in_lsa_RemoveAccountRights().


12 years agos3-lsa: pure cosmetic indentation fixes.
Günther Deschner [Mon, 26 Oct 2009 22:37:21 +0000 (23:37 +0100)]
s3-lsa: pure cosmetic indentation fixes.


12 years agos3-lsa: use enum lsa_LookupNamesLevel in lsa_lookup_level_to_flags().
Günther Deschner [Mon, 26 Oct 2009 22:28:30 +0000 (23:28 +0100)]
s3-lsa: use enum lsa_LookupNamesLevel in lsa_lookup_level_to_flags().


12 years agoldb:tdb backend - be also here more careful with the result value
Matthias Dieter Wallnöfer [Tue, 27 Oct 2009 18:40:57 +0000 (19:40 +0100)]
ldb:tdb backend - be also here more careful with the result value

"msg_delete_attribute" doesn't return an LDB result constant.

12 years agoldb:python bindings - make the intention by Jelmer ("int" vs. "enum") more clear
Matthias Dieter Wallnöfer [Tue, 27 Oct 2009 18:11:15 +0000 (19:11 +0100)]
ldb:python bindings - make the intention by Jelmer ("int" vs. "enum") more clear

12 years agoRevert "ldb python bindungs - better use the "enum ldb_scope" for the search scope...
Matthias Dieter Wallnöfer [Tue, 27 Oct 2009 18:07:53 +0000 (19:07 +0100)]
Revert "ldb python bindungs - better use the "enum ldb_scope" for the search scope rather than "int""

This reverts commit 4f8826ff7f4789c5b5f363b733a42053f72aa526.

Jelmer pointed out that the "enum"s don't work so well in combination with python.

12 years agos3/docs: Document new pdbedit -K option.
Karolin Seeger [Tue, 27 Oct 2009 15:04:35 +0000 (16:04 +0100)]
s3/docs: Document new pdbedit -K option.


12 years agos3: pdbedit: add option --kickoff-time/-K to set the user's kickoff time
Michael Adam [Mon, 26 Oct 2009 15:07:58 +0000 (16:07 +0100)]
s3: pdbedit: add option --kickoff-time/-K to set the user's kickoff time

Use "never" as argument to set this to unlimited.


12 years agos4-dsdb: call dsdb_make_schema_global() from ldb_wrap
Andrew Tridgell [Tue, 27 Oct 2009 09:30:53 +0000 (20:30 +1100)]
s4-dsdb: call dsdb_make_schema_global() from ldb_wrap

Calling it from samdb_connect() can cause a stale schema to be put
into the global schema.

Thanks to Andrew Bartlett for spotting this.

12 years agoSecond part of the fix for bug 6828 - infinite timeout occurs when byte lock held...
Jeremy Allison [Tue, 27 Oct 2009 04:20:22 +0000 (21:20 -0700)]
Second part of the fix for bug 6828 - infinite timeout occurs when byte lock held outside of samba.
Fixes case where a connection with a pending lock can me marked "idle", and ensures
that the lock queue timeout is always recalculated.

12 years agos4-dsdb: always cancel transactions on all partitions
Andrew Tridgell [Tue, 27 Oct 2009 01:13:46 +0000 (12:13 +1100)]
s4-dsdb: always cancel transactions on all partitions

If we get an error ending a transaction on one partition we need to
continue on the other partitions.

12 years agos4-ldb: '+' can also happen in base64 encoded index DNs
Andrew Tridgell [Tue, 27 Oct 2009 00:44:05 +0000 (11:44 +1100)]
s4-ldb: '+' can also happen in base64 encoded index DNs

12 years agos4:ldb Add detail to failures in the indexing code
Andrew Bartlett [Tue, 27 Oct 2009 00:10:49 +0000 (11:10 +1100)]
s4:ldb Add detail to failures in the indexing code

12 years agos4:dsdb Rework partitions module for better tracing
Andrew Bartlett [Mon, 26 Oct 2009 23:54:16 +0000 (10:54 +1100)]
s4:dsdb Rework partitions module for better tracing

This means we need to create a fake 'module' which only has a 'next'
pointer, so that we can now ldb_next_request() (which incorporates
tracing).  The remainaing stub of partition_request() is retained so
that we can indicate which partition an operation is destined for.

Similar tracing is added to the transaction handlers.

Andrew Bartlett

12 years agos4:ldb Add additional tracing of the ldb API
Andrew Bartlett [Mon, 26 Oct 2009 23:43:51 +0000 (10:43 +1100)]
s4:ldb Add additional tracing of the ldb API

This helps pin down where errors occour, by printing a call stack and
setting error strings and trace messages in the transaction case.

Andrew Bartlett

12 years agos4:dsdb Remove partition_extended_schema_update_now
Andrew Bartlett [Sun, 25 Oct 2009 23:23:10 +0000 (10:23 +1100)]
s4:dsdb Remove partition_extended_schema_update_now

The schema update now request is now handled above the partitions

Andrew Bartlett

12 years agos3: Rename new parameter "ldap ref follow" to "ldap follow referral".
Karolin Seeger [Mon, 26 Oct 2009 11:11:59 +0000 (12:11 +0100)]
s3: Rename new parameter "ldap ref follow" to "ldap follow referral".

This parameter will be introduced with Samba 3.5.0.


12 years agos3:docs: Public is not a synonym for access based shareenum.
Karolin Seeger [Mon, 26 Oct 2009 09:14:51 +0000 (10:14 +0100)]
s3:docs: Public is not a synonym for access based shareenum.

Fix build warning.


12 years agos3:docs: fake dir create times is a global parameter.
Karolin Seeger [Mon, 26 Oct 2009 08:33:37 +0000 (09:33 +0100)]
s3:docs: fake dir create times is a global parameter.


12 years agos4-ldb: fixed request handling for schemaUpdateNow op
Andrew Tridgell [Sun, 25 Oct 2009 21:38:03 +0000 (08:38 +1100)]
s4-ldb: fixed request handling for schemaUpdateNow op

12 years agoMerge branch 'master' of ssh://
Andrew Tridgell [Sun, 25 Oct 2009 12:14:56 +0000 (23:14 +1100)]
Merge branch 'master' of ssh://

12 years agos4-ldb: allow for unescaped '=' in a index DN
Andrew Tridgell [Sun, 25 Oct 2009 11:02:31 +0000 (22:02 +1100)]
s4-ldb: allow for unescaped '=' in a index DN

The ldb_dn_explode code normally enforces all special characters,
including a '=', must be escaped. Unfortunately this conflicts with
the ltdb index DNs, which for binary attributes may be base64
encoded. This allows a unescaped '=' as a special case for index DNs.

12 years agoldb:backend "connect" functions - convert result values to LDB constants
Matthias Dieter Wallnöfer [Fri, 23 Oct 2009 15:23:44 +0000 (17:23 +0200)]
ldb:backend "connect" functions - convert result values to LDB constants

I think this is better since "ldb_backend_connect" and "ldb_connect" which
propagate those values should return only LDB constants. Therefore a conversion
(especially for "-1") would be needed.

12 years agos4-samdb: reduce the number of samdb opens at startup
Andrew Tridgell [Sun, 25 Oct 2009 06:19:03 +0000 (17:19 +1100)]
s4-samdb: reduce the number of samdb opens at startup

Using common parameters means that the ldb_wrap code can return a
reference rather than a new database

12 years agos4-ldb: ensure DNs pass validity tests in indexing
Andrew Tridgell [Sun, 25 Oct 2009 02:13:41 +0000 (13:13 +1100)]
s4-ldb: ensure DNs pass validity tests in indexing

12 years agos4-ldb: fixed string length handling on index records
Andrew Tridgell [Sun, 25 Oct 2009 02:12:32 +0000 (13:12 +1100)]
s4-ldb: fixed string length handling on index records

12 years agos4-dsdb: ensure that new partitions inherit any transaction
Andrew Tridgell [Fri, 23 Oct 2009 11:46:09 +0000 (22:46 +1100)]
s4-dsdb: ensure that new partitions inherit any transaction

12 years agotdb: detect tdb store of identical records and skip
Andrew Tridgell [Fri, 23 Oct 2009 11:45:03 +0000 (22:45 +1100)]
tdb: detect tdb store of identical records and skip

This can help with ldb where we rewrite the index records

12 years agos4-ldb: don't allow modifies outside a transaction.
Andrew Tridgell [Fri, 23 Oct 2009 11:43:24 +0000 (22:43 +1100)]
s4-ldb: don't allow modifies outside a transaction.

12 years agos4-ldb: fixed re-index during a complex transaction
Andrew Tridgell [Fri, 23 Oct 2009 11:42:26 +0000 (22:42 +1100)]
s4-ldb: fixed re-index during a complex transaction

We may have modified index objects in the in-memory index tdb

12 years agos4-python: fixed annoyance where control-C doesn't kill our python scripts
Andrew Tridgell [Fri, 23 Oct 2009 06:12:48 +0000 (17:12 +1100)]
s4-python: fixed annoyance where control-C doesn't kill our python scripts

We want our scripts to die immediately when a user hits
control-C. Otherwise we not only annoy the hell out of the user, we
also risk db corruption as the control-C could get delivered as an
exception which gets mis-interpreted (eg. as a missing db object). We
use transactions for all our databases, so the right thing to do in
all our command line tools is to die immediately.

12 years agos4:dcesrv_samr: always use mem_ctx as initial parent for samr_*_state
Stefan Metzmacher [Fri, 23 Oct 2009 15:30:47 +0000 (17:30 +0200)]
s4:dcesrv_samr: always use mem_ctx as initial parent for samr_*_state

We always steal the state to the policy handle on success,
but untill then keep it on the short term context.


12 years agos4:loadparm: don't leak the names of all shares in each lp_service() call
Stefan Metzmacher [Fri, 23 Oct 2009 13:12:01 +0000 (15:12 +0200)]
s4:loadparm: don't leak the names of all shares in each lp_service() call


12 years agos4:dsdb/partition_init: don't leak a talloc_new() in case we have no data yet
Stefan Metzmacher [Fri, 23 Oct 2009 13:11:08 +0000 (15:11 +0200)]
s4:dsdb/partition_init: don't leak a talloc_new() in case we have no data yet


12 years agolibcli/auth: initialize creds in netlogon_creds_client_init_session_key()
Stefan Metzmacher [Fri, 23 Oct 2009 15:26:58 +0000 (17:26 +0200)]
libcli/auth: initialize creds in netlogon_creds_client_init_session_key()


12 years agos4:gensec/schannel: remove unused talloc_reference() in schannel_update()
Stefan Metzmacher [Fri, 23 Oct 2009 15:25:19 +0000 (17:25 +0200)]
s4:gensec/schannel: remove unused talloc_reference() in schannel_update()

We never expose creds to the caller in schannel_update().


12 years agolibcli/auth: fix memory leak in schannel_creds_server_step_check_ldb()
Stefan Metzmacher [Fri, 23 Oct 2009 15:23:56 +0000 (17:23 +0200)]
libcli/auth: fix memory leak in schannel_creds_server_step_check_ldb()


12 years agolibcli/auth: don't leak the ldb_msg in schannel_store_session_key_ldb()
Stefan Metzmacher [Fri, 23 Oct 2009 13:10:20 +0000 (15:10 +0200)]
libcli/auth: don't leak the ldb_msg in schannel_store_session_key_ldb()


12 years agoFix bug 6802 - A created folder does not properly inherit permissions from parent.
Barry Sabsevitz [Fri, 23 Oct 2009 18:50:29 +0000 (11:50 -0700)]
Fix bug 6802 - A created folder does not properly inherit permissions from parent.

12 years agotdb: rename 'struct list_struct' into 'struct tdb_record'
Stefan Metzmacher [Fri, 23 Oct 2009 11:51:03 +0000 (13:51 +0200)]
tdb: rename 'struct list_struct' into 'struct tdb_record'


12 years agoldb python bindungs - better use the "enum ldb_scope" for the search scope rather...
Matthias Dieter Wallnöfer [Fri, 23 Oct 2009 12:26:41 +0000 (14:26 +0200)]
ldb python bindungs - better use the "enum ldb_scope" for the search scope rather than "int"

12 years agos3: Fix crash in pam_winbind, another reference to freed memory.
Bo Yang [Sat, 24 Oct 2009 01:20:00 +0000 (09:20 +0800)]
s3: Fix crash in pam_winbind, another reference to freed memory.

Signed-off-by: Bo Yang <>
12 years agos4-python: we need to include Python.h first
Andrew Tridgell [Fri, 23 Oct 2009 05:23:01 +0000 (16:23 +1100)]
s4-python: we need to include Python.h first

If we don't include Python.h first then we get a pile of warnings due
to broken redefines of XOPEN_SOURCE in the Python includes.

12 years agos4:dsdb 'attrs' must be static (otherwise segv with async)
Andrew Bartlett [Fri, 23 Oct 2009 03:58:09 +0000 (14:58 +1100)]
s4:dsdb 'attrs' must be static (otherwise segv with async)

The async code makes this really easy to mess up...

Andrew Bartlett

12 years agos4:dsdb Fix samba3sam test again.
Andrew Bartlett [Fri, 23 Oct 2009 02:37:53 +0000 (13:37 +1100)]
s4:dsdb Fix samba3sam test again.

We again need to be careful not to call 'ldb_next_request' based functions in the partitions module.

Or, we need to instead go back to having that work, and ditch the
partition_request stuff...

Andrew Bartlett

12 years agos4:dsdb Add error string in 'no such object' because of 0 replies case
Andrew Bartlett [Fri, 23 Oct 2009 01:34:41 +0000 (12:34 +1100)]
s4:dsdb Add error string in 'no such object' because of 0 replies case

12 years agos4:dsdb Remove unused variables
Andrew Bartlett [Fri, 23 Oct 2009 00:36:23 +0000 (11:36 +1100)]
s4:dsdb Remove unused variables

12 years agos4:dsdb Do less allocation when searching for partitions modules
Andrew Bartlett [Thu, 22 Oct 2009 23:08:27 +0000 (10:08 +1100)]
s4:dsdb Do less allocation when searching for partitions modules

(it didn't help that the previous allocation was on the wrong long-term context)

Andrew Bartlett

12 years agos4:setup Mark 'cn' in secrets as case insensitive
Andrew Bartlett [Thu, 22 Oct 2009 07:22:26 +0000 (18:22 +1100)]
s4:setup Mark 'cn' in secrets as case insensitive

While this does not matter very much, others may later expect 'cn' to be case

Andrew Bartlett

12 years agos4:secrets Look for LDAP secret with a name that is indexed
Andrew Bartlett [Thu, 22 Oct 2009 07:21:50 +0000 (18:21 +1100)]
s4:secrets Look for LDAP secret with a name that is indexed

This avoids a very common unindexed lookup

12 years agos4:gensec Use an index on computerName in schannel.ldb
Andrew Bartlett [Thu, 22 Oct 2009 07:21:02 +0000 (18:21 +1100)]
s4:gensec Use an index on computerName in schannel.ldb

12 years agoutil:ldb Allow multiple entries to be added in one LDIF snippit
Andrew Bartlett [Thu, 22 Oct 2009 07:20:07 +0000 (18:20 +1100)]
util:ldb Allow multiple entries to be added in one LDIF snippit

12 years agos4:dsdb Split schema loading and schema data management
Andrew Bartlett [Thu, 22 Oct 2009 04:54:57 +0000 (15:54 +1100)]
s4:dsdb Split schema loading and schema data management

By splitting the module this way, we can load the schema at startup, after
the partitions module is operational, but we leave the 'mess with details of
entries in the partitions' module to operate only on the partitions module.

Loading the schema later allows us to set the @ATTRIBUTES correctly on all
the databases.

Andrew Bartlett

12 years agos4:dsdb Set partitions metadata as soon as it is set up.
Andrew Bartlett [Thu, 22 Oct 2009 04:54:12 +0000 (15:54 +1100)]
s4:dsdb Set partitions metadata as soon as it is set up.

12 years agos4-selftest: lower some of the timeouts during make test
Andrew Tridgell [Fri, 23 Oct 2009 04:38:54 +0000 (15:38 +1100)]
s4-selftest: lower some of the timeouts during make test

This speeds up some of the delay based tests by a lot. There is no
need to have long delays during testing.

12 years agos4-samdb: make sure the static credentials are never freed
Andrew Tridgell [Fri, 23 Oct 2009 03:54:07 +0000 (14:54 +1100)]
s4-samdb: make sure the static credentials are never freed

12 years agos4-ldb: move the tdb_reopen_all() calls to ldb_wrap.c
Andrew Tridgell [Fri, 23 Oct 2009 03:50:56 +0000 (14:50 +1100)]
s4-ldb: move the tdb_reopen_all() calls to ldb_wrap.c

12 years agos4-ldb: use ldb_wrap_fork_hook() to cancel child transactions
Andrew Tridgell [Fri, 23 Oct 2009 03:46:34 +0000 (14:46 +1100)]
s4-ldb: use ldb_wrap_fork_hook() to cancel child transactions

12 years agos4-ldb: added ldb_transaction_cancel_noerr()
Andrew Tridgell [Fri, 23 Oct 2009 03:46:08 +0000 (14:46 +1100)]
s4-ldb: added ldb_transaction_cancel_noerr()

This will be used to allow cancelling of transactions in a child after
a fork()

12 years agos4-server: call the ldb_wrap_fork_hook() after a fork()
Andrew Tridgell [Fri, 23 Oct 2009 03:31:07 +0000 (14:31 +1100)]
s4-server: call the ldb_wrap_fork_hook() after a fork()

This will be used to allow us to cancel any pending transactions
after a fork.

12 years agos4-server: pre-open the main ldb databases in the server
Andrew Tridgell [Fri, 23 Oct 2009 03:30:00 +0000 (14:30 +1100)]
s4-server: pre-open the main ldb databases in the server

By pre-opening these databases and leaving them open, we allow the new
ldb_wrap_connect() code to share the ldb context between users.

12 years agos4-ldbwrap: added re-use of ldb contexts in ldb_wrap_connect()
Andrew Tridgell [Fri, 23 Oct 2009 03:27:00 +0000 (14:27 +1100)]
s4-ldbwrap: added re-use of ldb contexts in ldb_wrap_connect()

This allows us to reuse a ldb context if it is open twice, instead
of going through the expensive process of a full ldb open. We can
reuse it if all of the parameters are the same.

The change relies on callers using talloc_unlink() or free of a parent
to close a ldb context.

12 years agos4-dsdb: add a static samdb_credentials
Andrew Tridgell [Fri, 23 Oct 2009 03:23:40 +0000 (14:23 +1100)]
s4-dsdb: add a static samdb_credentials

Similarly to system_session(), this creates a static

12 years agos4-dsdb: create a static system_session context
Andrew Tridgell [Fri, 23 Oct 2009 03:19:28 +0000 (14:19 +1100)]
s4-dsdb: create a static system_session context

This patch adds a system_session cache, preventing us from having to
recreate it on every ldb open, and allowing us to detect when the same
session is being used in ldb_wrap