14 years agor22175: sync packaging changes from SAMBA_3_0_25
Gerald Carter [Wed, 11 Apr 2007 12:54:00 +0000 (12:54 +0000)]
r22175: sync packaging changes from SAMBA_3_0_25
(This used to be commit 057db3255860e8462188f405712f89db97f6abac)

14 years agor22173: BUG 4491, 4501: Additional fixes for protecting against
Gerald Carter [Wed, 11 Apr 2007 12:32:58 +0000 (12:32 +0000)]
r22173: BUG 4491, 4501: Additional fixes for protecting against
crashes in allocate_id().

BUG 4501: Fix segv in idmap_ad caused by resetting the
entry iterator when parsing search results.
(This used to be commit bd6ebbfb9fb9d95bdf41eab1fd134170fcf6b6bf)

14 years agor22172: FSCTL_RECALL_FILE is 0x90117 according to my traces. Record it here.
Alexander Bokovoy [Wed, 11 Apr 2007 12:32:07 +0000 (12:32 +0000)]
r22172: FSCTL_RECALL_FILE is 0x90117 according to my traces. Record it here.
(This used to be commit f36bc61d17baf468ec66151dda347fdfc40e0297)

14 years agor22164: Fix missing lock count release in transaction cancel.
Jeremy Allison [Wed, 11 Apr 2007 05:27:00 +0000 (05:27 +0000)]
r22164: Fix missing lock count release in transaction cancel.
Found by Taj Khattra <>.
(This used to be commit a014a6c30d1e0d75a1a49fdd61bad8cf4cc90327)

14 years agor22163: Pure reformatting. I hate 4 space tabstops :-).
Jeremy Allison [Wed, 11 Apr 2007 05:05:33 +0000 (05:05 +0000)]
r22163: Pure reformatting. I hate 4 space tabstops :-).
(This used to be commit 99abe96b2b8e41e4c7536d35cc169f7e6c3eba1c)

14 years agor22159: BUG 4501 (second half of fix): Just disable the
Gerald Carter [Tue, 10 Apr 2007 22:59:42 +0000 (22:59 +0000)]
r22159: BUG 4501 (second half of fix): Just disable the
uid/gid allocation if no idmap alloca backend has been
defined and we are not using a 3.0.24 idmap backend
compatible configuration.
(This used to be commit 0b700456f45d2bdfe8538bcfd0fce8ec2b9c3adb)

14 years agor22158: BUG 4501 (partial): Fix a crash caused by not using the
Gerald Carter [Tue, 10 Apr 2007 21:14:44 +0000 (21:14 +0000)]
r22158: BUG 4501 (partial): Fix a crash caused by not using the
nss_info_{rfc2307,sfu} plugin with idmap_ad.
(This used to be commit f640f056bfbf1013d6b3df89632109011fc42361)

14 years agor22157: Fix bug #3634 - stop nmbd segfaulting with bad interface line.
Jeremy Allison [Tue, 10 Apr 2007 20:35:30 +0000 (20:35 +0000)]
r22157: Fix bug #3634 - stop nmbd segfaulting with bad interface line.
(This used to be commit c3e2207cb40386c565b23fcabc8c7384b10216de)

14 years agor22155: Fixed warning #4498 from
Jeremy Allison [Tue, 10 Apr 2007 18:21:37 +0000 (18:21 +0000)]
r22155: Fixed warning #4498 from
(This used to be commit f1b22c952719f004d7e33813c4d0f10514e1fff9)

14 years agor22154: Make struct smbdb_ctx an opaque pointer so users of the API
Jeremy Allison [Tue, 10 Apr 2007 18:12:25 +0000 (18:12 +0000)]
r22154: Make struct smbdb_ctx an opaque pointer so users of the API
don't need to have tdb.h.
(This used to be commit 512542c90a78006bda3470eed7fb6d3f6e708eed)

14 years agor22153: fix LDAP SASL "GSSAPI" bind against w2k3, this isn't critical
Stefan Metzmacher [Tue, 10 Apr 2007 16:04:22 +0000 (16:04 +0000)]
r22153: fix LDAP SASL "GSSAPI" bind against w2k3, this isn't critical
because we try "GSS-SPNEGO" first and all windows version support

(This used to be commit 34a5badbded0b2537ee854287931e2a7dc3aeb37)

14 years agor22151: remove netgr functions from libreplace they're not used
Stefan Metzmacher [Tue, 10 Apr 2007 15:59:39 +0000 (15:59 +0000)]
r22151: remove netgr functions from libreplace they're not used
in samba4 currently and samba3 has explicit configure checks for them.

should fix bug #4496

(This used to be commit 7f61b3f0095efed81adc9022ba44e5c7df84d2f2)

14 years agor22149: BUG 4500: patch from Jorge Santos <>
Gerald Carter [Tue, 10 Apr 2007 15:41:23 +0000 (15:41 +0000)]
r22149: BUG 4500: patch from Jorge Santos <>
to fix compile bug ni quotas.c (typo calling unbecome_root()).
(This used to be commit 22d550d62b5834e2c5155550756d3462a1bd6561)

14 years agor22148: Fix gpfs module on posix-acl test. Adds gpfsacl_sys_set_fd (calls
Jim McDonough [Tue, 10 Apr 2007 15:41:22 +0000 (15:41 +0000)]
r22148: Fix gpfs module on posix-acl test.  Adds gpfsacl_sys_set_fd (calls
_file).  Thanks to Gomati Mohanan.
(This used to be commit 859269c9492e002f02415d610c83452538147972)

14 years agor22147: Next try
Volker Lendecke [Tue, 10 Apr 2007 07:36:58 +0000 (07:36 +0000)]
r22147: Next try
(This used to be commit 42f42321558ed0647697e5bfd7d5339a29aa30d9)

14 years agor22146: Attempt to fix the build
Volker Lendecke [Tue, 10 Apr 2007 07:33:14 +0000 (07:33 +0000)]
r22146: Attempt to fix the build
(This used to be commit 825255c7600f2372c1702a0cecb309e9f22c087e)

14 years agor22145: Fix bug #4494 - reported by Kevin Jamieson <>.
Jeremy Allison [Mon, 9 Apr 2007 21:01:46 +0000 (21:01 +0000)]
r22145: Fix bug #4494 - reported by Kevin Jamieson <>.
If returning a mapped UNIX error from sendfile, don't call chain_reply.
(This used to be commit 38404c990db1436241c3a774c51196bc058d7576)

14 years agor22135: Check in most of Michael Adam's net conf utility. A good share of this patch
Volker Lendecke [Mon, 9 Apr 2007 10:38:55 +0000 (10:38 +0000)]
r22135: Check in most of Michael Adam's net conf utility. A good share of this patch
is moving functions around to fix some linker dependencies for the registry.

Michael, I've renamed your auth_utils2.c to token_utils.c.


(This used to be commit 9de16f25c1c3e0b203da47391772ef2e2fe291ac)

14 years agor22132: I hate inefficiency. Don't call conv_str_size()
Jeremy Allison [Sun, 8 Apr 2007 19:41:47 +0000 (19:41 +0000)]
r22132: I hate inefficiency. Don't call conv_str_size()
on every pread/sendfile call, initialize these
variables in an allocated struct at connection
time and just refer to them directly.
(This used to be commit 85df3fca681a44c882f596ef042ad9956c3a63c0)

14 years agor22130: - Ensure that the libsmbclient example programs link with the libsmbclient
Derrell Lipman [Sun, 8 Apr 2007 16:41:24 +0000 (16:41 +0000)]
r22130: - Ensure that the libsmbclient example programs link with the libsmbclient
  library that's part of the current tree, not with whatever happens to have
  been previously installed.
(This used to be commit c65621e0b7690b90beb420f829c769c7d28147f5)

14 years agor22129: Fix the nttrans create extended response for pipes
Jeremy Allison [Sun, 8 Apr 2007 04:54:44 +0000 (04:54 +0000)]
r22129: Fix the nttrans create extended response for pipes
and files (tested with Win32 code). Bug #4404 should
now be dead :-).
(This used to be commit 40a86a56662eca2668b8a9515b9f924f54d80cc0)

14 years agor22128: Fix the pipe open response with EXTENDED_RESPONSE_REQUIRED
Jeremy Allison [Sun, 8 Apr 2007 00:47:49 +0000 (00:47 +0000)]
r22128: Fix the pipe open response with EXTENDED_RESPONSE_REQUIRED
set. Only the NTTrans create left to fix for csc.
(This used to be commit 7856db9fce9906c5a7d19fbe69dfcfd4b644c134)

14 years agor22127: Wrap the AC_TRY_RUN detection for Linux getgrouplist in an
James Peach [Sat, 7 Apr 2007 21:13:29 +0000 (21:13 +0000)]
r22127: Wrap the AC_TRY_RUN detection for Linux getgrouplist in an
AC_CACHE_CHECK, so it can be cross-compiled.
(This used to be commit f9fb07d2f9f142b4bcef02b8b3fc40789a6995d7)

14 years agor22126: Fix a bogus uninitialized variable warning
Volker Lendecke [Sat, 7 Apr 2007 19:35:13 +0000 (19:35 +0000)]
r22126: Fix a bogus uninitialized variable warning
(This used to be commit 3be234effacd370dbdae11f6fcfddfe37d0623b3)

14 years agor22125: Fix a warning
Volker Lendecke [Sat, 7 Apr 2007 13:22:49 +0000 (13:22 +0000)]
r22125: Fix a warning
(This used to be commit 1c0ceb5fe217bd7210072869a1313c7ac67ff118)

14 years agor22124: Wow - NTCreateX sets the word count to 42, but returns 50 on
Jeremy Allison [Sat, 7 Apr 2007 06:59:32 +0000 (06:59 +0000)]
r22124: Wow - NTCreateX sets the word count to 42, but returns 50 on
the wire. Strange.... But now we're returning Windows compatible
extended info. Next to fix the pipe returns and NTTrans Creates.
(This used to be commit 57e46f2f80db153fc7ce0eb09f24afa78aa27349)

14 years agor22123: Try and fix the csc (#4404) bug by supporting the extended
Jeremy Allison [Sat, 7 Apr 2007 06:38:45 +0000 (06:38 +0000)]
r22123: Try and fix the csc (#4404) bug by supporting the extended
response to NTCreateX - need to fix this also for
pipe open and NTTransCreate as well so this isn't
(This used to be commit be742f248178ae606dfa3a90c6148a18b42128e3)

14 years agor22122: Start to fix csc issue with Vista. Make smbd support
Jeremy Allison [Sat, 7 Apr 2007 05:49:24 +0000 (05:49 +0000)]
r22122: Start to fix csc issue with Vista. Make smbd support
the extended 7 word response for tconX rather than the
3 word one we supported previously.
(This used to be commit 137953226a2d691259e7e84d6ae0dc24755e5a3a)

14 years agor22113: Fix core dump when configfile in same directory.
Jeremy Allison [Fri, 6 Apr 2007 22:08:44 +0000 (22:08 +0000)]
r22113: Fix core dump when configfile in same directory.
From Steven Danneman <>.
(This used to be commit 572c418b04eb1dbce8da7643fe7e236b06fce57b)

14 years agor22112: Fix memleak pointed out by Steven Danneman <>.
Jeremy Allison [Fri, 6 Apr 2007 21:55:44 +0000 (21:55 +0000)]
r22112: Fix memleak pointed out by Steven Danneman <>.
(This used to be commit 7c45bd3a47fc2b24c5f1351a241ace2201c857d2)

14 years agor22111: Allow readahead params to use size suffixes as K,M, etc.
Jeremy Allison [Fri, 6 Apr 2007 21:12:44 +0000 (21:12 +0000)]
r22111: Allow readahead params to use size suffixes as K,M, etc.
(This used to be commit e296f07e1d3a14fe05a444ccdc752cd945fee5bc)

14 years agor22110: don't cache the S-1-22-{1,2} domain SID/uig/gid lookups in idmap_cache
Gerald Carter [Fri, 6 Apr 2007 21:05:55 +0000 (21:05 +0000)]
r22110: don't cache the S-1-22-{1,2} domain SID/uig/gid lookups in idmap_cache
(This used to be commit adfc2d31656f642c76a3d8eeddf5a67804a4917d)

14 years agor22109: Readonly is automatically set in the generic init code, let's just log the...
Simo Sorce [Fri, 6 Apr 2007 19:55:45 +0000 (19:55 +0000)]
r22109: Readonly is automatically set in the generic init code, let's just log the fact there
and remove the specific, but redundant, code in idmap_ad.c
(This used to be commit f127803734f9ae16e400b8a91e1e1910fd49b7f3)

14 years agor22108: Fix from <> to try and fix the HPUX builds.
Jeremy Allison [Fri, 6 Apr 2007 19:38:35 +0000 (19:38 +0000)]
r22108: Fix from <> to try and fix the HPUX builds.
(This used to be commit 4de297112b9d87e58d870889007001169265e084)

14 years agor22107: Fix typo.
James Peach [Fri, 6 Apr 2007 19:17:15 +0000 (19:17 +0000)]
r22107: Fix typo.
(This used to be commit fd056b2426dea059fec50fe1c90e4fdd48f916d7)

14 years agor22106: Fix the module name - it's vfs_readahead not vfs_linux_readahead.
Jeremy Allison [Fri, 6 Apr 2007 19:09:53 +0000 (19:09 +0000)]
r22106: Fix the module name - it's vfs_readahead not vfs_linux_readahead.
(This used to be commit bc2b6e3f32ab50444bb478efffd7a8b505536c6c)

14 years agor22105: Added vfs_readahead module that appears to do wonderful things
Jeremy Allison [Fri, 6 Apr 2007 18:56:47 +0000 (18:56 +0000)]
r22105: Added vfs_readahead module that appears to do wonderful things
for copying files from Samba when using Windows Vista Windows
explorer.... :-). By default if you add this I can go on my
vmware sessions from 7MB/sec to 12MB/sec (+1 extra MB/sec if
I turn sendfile on).
(This used to be commit 97fdd67e83bb2706106a9bae95b32d8d9f8b4066)

14 years agor22104: BUG 4439: Fix the object picket on x64 WIndopws XP/2003.
Gerald Carter [Fri, 6 Apr 2007 18:52:30 +0000 (18:52 +0000)]
r22104: BUG 4439: Fix the object picket on x64 WIndopws XP/2003.
Enable the DsRoleGetPrimaryDomainInfo() server code.
Tested by Win2000/XP/2003/Vista (x86) and WinXP (x64)
(This used to be commit eab9ca7e7d8d7dc3e705720f8bc5dff5c8ec5f5f)

14 years agor22103: No code change. This is a spring time end of line clesnup checkin.
Lars Müller [Fri, 6 Apr 2007 16:42:37 +0000 (16:42 +0000)]
r22103: No code change.  This is a spring time end of line clesnup checkin.
(This used to be commit 3ae99e5924a8d20f920faddf823f43fb73ee4c6e)

14 years agor22102: Remove obsoleted SHLIBS_PROGS from {Makefile,configure}.in.
Lars Müller [Fri, 6 Apr 2007 16:27:28 +0000 (16:27 +0000)]
r22102: Remove obsoleted SHLIBS_PROGS from {Makefile,configure}.in.

As NSS_MODULES is added to the all rule the resulting set of binaries
are the same.
(This used to be commit 3bebb5f4c1c09493e81a96efdc09742abd9adacf)

14 years agor22101: remove RedHat 9 packaging files after annoncement on the samba ml
Gerald Carter [Fri, 6 Apr 2007 16:23:55 +0000 (16:23 +0000)]
r22101: remove RedHat 9 packaging files after annoncement on the samba ml
(This used to be commit 884952435598430ee74c7ef5a925025321d422c7)

14 years agor22099: Revert parts of revision 22056 as proto_exists is not required by
Lars Müller [Fri, 6 Apr 2007 15:39:34 +0000 (15:39 +0000)]
r22099: Revert parts of revision 22056 as proto_exists is not required by
@WINBIND_NSS@, bin/pam_winbind.@SHLIBEXT@, and bin/pam_smbpass.@SHLIBEXT@.
(This used to be commit 641edac6ece16aa51fef240a5356c1aa5afaa644)

14 years agor22097: Add detection for linux readahead() syscall.
Jeremy Allison [Fri, 6 Apr 2007 01:09:19 +0000 (01:09 +0000)]
r22097: Add detection for linux readahead() syscall.
(This used to be commit 4e3232aad4179e4ca9a1138bc43addec2ea6d9cc)

14 years agor22096: become_root_uid_only() is unneeded - it's only used in
Jeremy Allison [Thu, 5 Apr 2007 23:56:10 +0000 (23:56 +0000)]
r22096: become_root_uid_only() is unneeded - it's only used in
messages.c. Refactor to use become_root() instead and
make it local to messages.c
(This used to be commit f3ffb3f98472b69b476b702dfe5c0575b32da018)

14 years agor22095: BUG 4484: Add more checks to set %a for Vista clients (based on absence of...
Gerald Carter [Thu, 5 Apr 2007 19:56:08 +0000 (19:56 +0000)]
r22095: BUG 4484: Add more checks to set %a for Vista clients (based on absence of native OS and Lanman strings in the session setup request)
(This used to be commit e5c9fc937d40046030c0d3bcfced505410a14caf)

14 years agor22094: Clarify that SMB_VFS_LOCK should not be used to get lock status.
James Peach [Thu, 5 Apr 2007 19:49:29 +0000 (19:49 +0000)]
r22094: Clarify that SMB_VFS_LOCK should not be used to get lock status.
(This used to be commit 395fd99edba8a75eab5d13c9fac5616bcd6ecf2c)

14 years agor22093: send also the correct OID_KERBEROS5 not only the broken
Stefan Metzmacher [Thu, 5 Apr 2007 12:36:10 +0000 (12:36 +0000)]
r22093: send also the correct OID_KERBEROS5 not only the broken

(This used to be commit 294c69334fce1cbb74ae9eb5a06e17b397f994df)

14 years agor22092: - make spnego_parse_auth_response() more generic and
Stefan Metzmacher [Thu, 5 Apr 2007 12:30:23 +0000 (12:30 +0000)]
r22092: - make spnego_parse_auth_response() more generic and
  not specific for NTLMSSP
- it's possible that the server sends a mechOID and authdata
  if negResult != SPNEGO_NEG_RESULT_INCOMPLETE, but we still
  force the mechOID to be present if negResult == SPNEGO_NEG_RESULT_INCOMPLETE

(This used to be commit e9f2aa22f90208a5e530ef3b68664151960a0a22)

14 years agor22091: Fix an uninitialized variable warning
Volker Lendecke [Thu, 5 Apr 2007 11:13:25 +0000 (11:13 +0000)]
r22091: Fix an uninitialized variable warning
(This used to be commit a6e1e39f1dcd9ebcb5db199fd152a861b9be929b)

14 years agor22080: Fix directory recycle module bug #4486.
Jeremy Allison [Wed, 4 Apr 2007 23:33:07 +0000 (23:33 +0000)]
r22080: Fix directory recycle module bug #4486.
(This used to be commit 17b1d11bbb8353e309c8410128a3e9c5964ea766)

14 years agor22079: Tsk, tsk, Metze didn't compile before check-in :-).
Jeremy Allison [Wed, 4 Apr 2007 17:38:12 +0000 (17:38 +0000)]
r22079: Tsk, tsk, Metze didn't compile before check-in :-).
Merge the memory leak fix (with fix :-) to 3.0.25.
(This used to be commit ab3150fe4ed2a629eb371db5f43ae09b9c583a64)

14 years agor22078: fix memory leak in not often used code, we only use it if the server
Stefan Metzmacher [Wed, 4 Apr 2007 14:50:39 +0000 (14:50 +0000)]
r22078: fix memory leak in not often used code, we only use it if the server
doesn't support GSS-SPNEGO in SASL

can someone please review this, maybe it's also for 3.0.25

(This used to be commit 8c6930b7013b185af0530b04a7d5a49bc2ce7831)

14 years agor22071: Make the error message for incorrect use of '-c' show the parameter as used.
Andrew Bartlett [Wed, 4 Apr 2007 06:03:54 +0000 (06:03 +0000)]
r22071: Make the error message for incorrect use of '-c' show the parameter as used.

This means that smbpasswd -c user (which in htpasswd creates a new file)
and smbpasswd -c /not/my/smb.conf should give errors an admin will
think to chase down.

Andrew Bartlett
(This used to be commit 721375e14cfcef88061c9e4d4a1f3ca2f33fa9aa)

14 years agor22069: BUG 4447: Fix compile failure on AIX 5.2 (patch from William Jojo <jojowil...
Gerald Carter [Wed, 4 Apr 2007 04:28:28 +0000 (04:28 +0000)]
r22069: BUG 4447: Fix compile failure on AIX 5.2 (patch from William Jojo <>)
(This used to be commit c1cb6d059b2a8539bc8a05ea4467d136bbb2ff38)

14 years agor22067: - fix --with-fhs, where confdir is set to \${sysconfdir}
Stefan Metzmacher [Wed, 4 Apr 2007 03:54:30 +0000 (03:54 +0000)]
r22067: - fix --with-fhs, where confdir is set to \${sysconfdir}
  but sysconfdir wasn't defined in our Makefile
- add localstatedir for completeness

(This used to be commit a70af6d457fede7f6bec822d4118abe658613d67)

14 years agor22066: Ensure that winbind can resolve SIDs in the S-1-22-{1,2}
Gerald Carter [Wed, 4 Apr 2007 02:57:01 +0000 (02:57 +0000)]
r22066: Ensure that winbind can resolve SIDs in the S-1-22-{1,2}
domain to a uid.gid using the idmap_passdb backend.
(This used to be commit fc1aeee52d8cb6c8d5d306dbbec18127bd2674bc)

14 years agor22065: First logic change I've found :-(. We were being too
Jeremy Allison [Wed, 4 Apr 2007 00:03:12 +0000 (00:03 +0000)]
r22065: First logic change I've found :-(. We were being too
restrictive about strings being NULL. If an info level
doesn't use a subformat the subformat string may be
missing (null). Add debug statements to help track
(This used to be commit 70875f92a22985539dc41e26a084218a45e1a13f)

14 years agor22064: Fix the DFS code to work better with Vista clients. Allow
Jeremy Allison [Tue, 3 Apr 2007 22:59:55 +0000 (22:59 +0000)]
r22064: Fix the DFS code to work better with Vista clients. Allow
"host msdfs = true" to be set in the [global] section
and allow Vista to see shares with "msdfs root = yes"
and "msdfs root = no" off the same server. Down
to an error message really :-).
(This used to be commit 1a0f69bb21fd03a18514dfc93c84568708144e28)

14 years agor22062: Fix the parsing of info level 3. Flags is not a flags
Jeremy Allison [Tue, 3 Apr 2007 19:47:19 +0000 (19:47 +0000)]
r22062: Fix the parsing of info level 3. Flags is not a flags
field, but an offset. Fixed 64-bit display of ACLs on
(This used to be commit 0c8949ff5d742dbe59f2af0f57a289f238e3592c)

14 years agor22061: Fix the krb5 user ticket refresh event timeout in winbindd
Gerald Carter [Tue, 3 Apr 2007 18:32:25 +0000 (18:32 +0000)]
r22061: Fix the krb5 user ticket refresh event timeout in winbindd
(This used to be commit 4a99b89618948f5518b9c685d1cdcfaad69bfc80)

14 years agor22060: Fix for AIX quotas from Heinrich Mislik <>.
Jeremy Allison [Tue, 3 Apr 2007 17:10:52 +0000 (17:10 +0000)]
r22060: Fix for AIX quotas from Heinrich Mislik <>.
(This used to be commit 8d95cdf8c0a46abc6b5cbcec3fd8bf246d49ee4b)

14 years agor22059: Over-allocate and NULL out 100 bytes for lanman.c.
Volker Lendecke [Tue, 3 Apr 2007 14:16:56 +0000 (14:16 +0000)]
r22059: Over-allocate and NULL out 100 bytes for lanman.c.

(This used to be commit 0eea6b84cec7e2a3fc1f784d5a9b162f71cc8a02)

14 years agor22058: Add test_nss_modules to check NSS modules for unresolved symbols.
Günther Deschner [Tue, 3 Apr 2007 13:30:43 +0000 (13:30 +0000)]
r22058: Add test_nss_modules to check NSS modules for unresolved symbols.

(This used to be commit 21d092f4f9aca1371f2cf97a39da6f30ddc62eba)

14 years agor22056: Adding some missing proto_exists calls (for PAM and NSS modules)
Günther Deschner [Tue, 3 Apr 2007 13:25:14 +0000 (13:25 +0000)]
r22056: Adding some missing proto_exists calls (for PAM and NSS modules)

(This used to be commit 04705aa190936510fc672ee92a4dbe540e18cf45)

14 years agor22055: Port the endpoint mapper (and functions it requires) to Samba 3.
Jelmer Vernooij [Tue, 3 Apr 2007 12:28:40 +0000 (12:28 +0000)]
r22055: Port the endpoint mapper (and functions it requires) to Samba 3.
(This used to be commit ad981261877e6a2dce0c4f4e71fd9127aa31538a)

14 years agor22054: merge from samba4:
Stefan Metzmacher [Tue, 3 Apr 2007 10:15:15 +0000 (10:15 +0000)]
r22054: merge from samba4:

remove broken samba3 specific stuff from tdbtool

(This used to be commit 9b34cd8d8917bc640c861783e56a1c121c7c47f9)

14 years agor22051: use libreplace headers
Stefan Metzmacher [Tue, 3 Apr 2007 07:00:53 +0000 (07:00 +0000)]
r22051: use libreplace headers

(This used to be commit 1017ca3eaa5cb8f4537886df5a1ee62439fff2f0)

14 years agor22050: Fix a couple of off-by-one errors in the rap
Jeremy Allison [Tue, 3 Apr 2007 04:52:09 +0000 (04:52 +0000)]
r22050: Fix a couple of off-by-one errors in the rap
call patch. Jerry, this works now for displaying
shares on Win9x (and hopefully everything else
as well :-).
(This used to be commit 728a4cc71376f9cfff2578d21a47602f8b7c6531)

14 years agor22049: HPUX build fixes from <>.
Jeremy Allison [Mon, 2 Apr 2007 23:07:06 +0000 (23:07 +0000)]
r22049: HPUX build fixes from <>.
(This used to be commit b70af25e851b2695e552b10f1befb16e336fb36f)

14 years agor22045: As Volker noticed, skip_string's last argument is
Jeremy Allison [Mon, 2 Apr 2007 20:10:21 +0000 (20:10 +0000)]
r22045: As Volker noticed, skip_string's last argument is
redundent. Remove it.
(This used to be commit 140881cfbb59ce4a699b5900efe02bf315be7bd5)

14 years agor22044: Remove the only skip_string(...,2) caller
Volker Lendecke [Mon, 2 Apr 2007 20:04:05 +0000 (20:04 +0000)]
r22044: Remove the only skip_string(...,2) caller
(This used to be commit 08ea2b83b26968990fce191cdafe26d3183518a6)

14 years agor22043: Comparing lanman.c with -r22013 is now MUCH easier, thanks! This looks much
Volker Lendecke [Mon, 2 Apr 2007 19:46:27 +0000 (19:46 +0000)]
r22043: Comparing lanman.c with -r22013 is now MUCH easier, thanks! This looks much
easier to review! Damn close to what I had in my tree, just the fn names were
slightly different.

This removes one unnecessary dupe.

Next thing is to get rid of the parameter "n" of skip_string, there is only
one (!) caller that does not pass in 1....

(This used to be commit 2878c1e93a8d71288fa3144cff57bce66c592e22)

14 years agor22042: Try and clean up my own mess using the API Volker
Jeremy Allison [Mon, 2 Apr 2007 19:04:57 +0000 (19:04 +0000)]
r22042: Try and clean up my own mess using the API Volker
suggested. I now use :

BOOL is_offset_safe(const char *buf_base, size_t buf_len, char *ptr, size_t off)
char *get_safe_ptr(const char *buf_base, size_t buf_len, char *ptr, size_t off)
char *get_safe_str_ptr(const char *buf_base, size_t buf_len, char *ptr, size_t off)
int get_safe_SVAL(const char *buf_base, size_t buf_len, char *ptr, size_t off, int failval)
int get_safe_IVAL(const char *buf_base, size_t buf_len, char *ptr, size_t off, int failval)

Volker, please criticize and comment. Thanks,

(This used to be commit d47af7c9263f519e7307859b6a696d854c5dfca3)

14 years agor22039: fix compiler warnings
Stefan Metzmacher [Mon, 2 Apr 2007 18:42:56 +0000 (18:42 +0000)]
r22039: fix compiler warnings

(This used to be commit 91402d7a42d9930e8e67bc67423b8b79db27f12d)

14 years agor22033: remove useless line
Stefan Metzmacher [Mon, 2 Apr 2007 17:16:14 +0000 (17:16 +0000)]
r22033: remove useless line

(This used to be commit cb6d90d7963d8fc650b46355d7e6590d1e0654ad)

14 years agor22026: Missed in my last commit, another case where we need to copy, not reference.
Andrew Bartlett [Mon, 2 Apr 2007 12:52:08 +0000 (12:52 +0000)]
r22026: Missed in my last commit, another case where we need to copy, not reference.

Andrew Bartlett
(This used to be commit 635b83a21683068eb3908506d5ee1191e55381d1)

14 years agor22024: Don't leak, actually use the provided memory context...
Andrew Bartlett [Mon, 2 Apr 2007 06:57:37 +0000 (06:57 +0000)]
r22024: Don't leak, actually use the provided memory context...
(This used to be commit 46ff4e599e79f47254e05c7e4db75db9a19934bc)

14 years agor22023: I don't like this cache, but I think Jeremy is right, the consequences
Andrew Bartlett [Mon, 2 Apr 2007 06:26:16 +0000 (06:26 +0000)]
r22023: I don't like this cache, but I think Jeremy is right, the consequences
of the talloc heirarchy created are too subtle, particularly with
callers picking out individual members.

This might fix the faults on the build farm.

Andrew Bartlett
(This used to be commit 82667bc75e63292c61f73c1f7cde809cc3dd55b0)

14 years agor22022: - Clarify the comments
Andrew Bartlett [Mon, 2 Apr 2007 05:53:34 +0000 (05:53 +0000)]
r22022: - Clarify the comments

- make sure never to free an uninitialised variable

- ensure to free result on getpwnam_alloc failure

Andrew Bartlett
(This used to be commit 5fe3328e66661371182cc1c3b6e239797c3b4f93)

14 years agor22020: Make it more clear that both the vuser struct and it's contents are
Andrew Bartlett [Mon, 2 Apr 2007 03:46:13 +0000 (03:46 +0000)]
r22020: Make it more clear that both the vuser struct and it's contents are
talloc_free()'ed at the end of a session.

Rework the passwd cache code to use talloc_unlink and
talloc_reference, to more carefully manage the cache.

Andrew Bartlett
(This used to be commit e3e0ec25e67308de314aa61852905ee42aa2c8fe)

14 years agor22019: Jeremy, this hopefully fixes the build farm currently. But I think we need
Volker Lendecke [Sun, 1 Apr 2007 13:50:02 +0000 (13:50 +0000)]
r22019: Jeremy, this hopefully fixes the build farm currently. But I think we need
another get_safe_offset call that also includes the required buffer size.

(This used to be commit 6138be7e4a5eb57af4a024d749cb68168b8589fb)

14 years agor22018: fix compile error
Herb Lewis [Sat, 31 Mar 2007 03:11:02 +0000 (03:11 +0000)]
r22018: fix compile error
(This used to be commit a4c1c770a227390f745c9db07efe468bdcd31339)

14 years agor22017: After changing 2000 lines of this I think this is needed :-).
Jeremy Allison [Sat, 31 Mar 2007 01:14:00 +0000 (01:14 +0000)]
r22017: After changing 2000 lines of this I think this is needed :-).
(This used to be commit 99092e8841edea468fa1e59a8c725f3467b58966)

14 years agor22016: Try and fix the build - move things out of proto.h
Jeremy Allison [Fri, 30 Mar 2007 23:23:45 +0000 (23:23 +0000)]
r22016: Try and fix the build - move things out of proto.h
(This used to be commit 29933600cff458f6599e4604f9e861cd20fc8e38)

14 years agor22015: Fix for memory leak from Steven Danneman <>
Jeremy Allison [Fri, 30 Mar 2007 22:35:35 +0000 (22:35 +0000)]
r22015: Fix for memory leak from Steven Danneman <>
(This used to be commit 61a1574f50d35435a55de62fa6f1d281eed90a25)

14 years agor22014: Make us pass RANDOMIPC test again :-(. This is an ugly check-in,
Jeremy Allison [Fri, 30 Mar 2007 22:25:08 +0000 (22:25 +0000)]
r22014: Make us pass RANDOMIPC test again :-(. This is an ugly check-in,
but I've no option.
(This used to be commit c3a565081d70b209a4f9e6e8f1859bf7194a5f74)

14 years agor22013: Move to SSPI framing (sig first in NTLM).
Jeremy Allison [Fri, 30 Mar 2007 22:19:51 +0000 (22:19 +0000)]
r22013: Move to SSPI framing (sig first in NTLM).
(This used to be commit 22eaed76f01ea9d0184dcaf57adca23abc6330b9)

14 years agor22012: Ensure we use the same technique to pull the share mode
Jeremy Allison [Thu, 29 Mar 2007 22:12:28 +0000 (22:12 +0000)]
r22012: Ensure we use the same technique to pull the share mode
data out that locking/locking.c does.
(This used to be commit 1fec4da6d6267289bf93f930de4cb5e21c450e15)

14 years agor22011: As Metze suggested, use 0xFF 'E' <enc ctx> instead
Jeremy Allison [Thu, 29 Mar 2007 19:46:34 +0000 (19:46 +0000)]
r22011: As Metze suggested, use 0xFF 'E' <enc ctx> instead
of 0xFF 'S' <enc ctx>.
(This used to be commit d8cd4fc91b324c9ab8d2f66ee264093763018f76)

14 years agor22010: Now I'm looking at mangling again, make sure
Jeremy Allison [Thu, 29 Mar 2007 19:40:59 +0000 (19:40 +0000)]
r22010: Now I'm looking at mangling again, make sure
that we mangle any illegal names before doing
any wildcard matches. That way lies least
suprises. Don't merge this for 3.0.25, too
dangerous. Thanks.
(This used to be commit 8e15ef476cada7a900ff17c7ba70c729d56718bd)

14 years agor22009: change TDB_DATA from char * to unsigned char *
Stefan Metzmacher [Thu, 29 Mar 2007 09:35:51 +0000 (09:35 +0000)]
r22009: change TDB_DATA from char * to unsigned char *

and fix all compiler warnings in the users

(This used to be commit 3a28443079c141a6ce8182c65b56ca210e34f37f)

14 years agor22008: use string_term_tdb_data()
Stefan Metzmacher [Thu, 29 Mar 2007 08:24:15 +0000 (08:24 +0000)]
r22008: use string_term_tdb_data()

(This used to be commit 1f047d7e31252481c4ed905e0dfdb791c704adca)

14 years agor22007: make string_tdb_data(NULL) possible...
Stefan Metzmacher [Thu, 29 Mar 2007 08:08:52 +0000 (08:08 +0000)]
r22007: make string_tdb_data(NULL) possible...

(This used to be commit d03094708378bde088bf6e90efe54deb83d3952e)

14 years agor22006: use string_term_tdb_data()...
Stefan Metzmacher [Thu, 29 Mar 2007 07:30:22 +0000 (07:30 +0000)]
r22006: use string_term_tdb_data()...

(This used to be commit 136914502ff129b90f10794ed6474dca558c75a0)

14 years agor22003: Fix from Jiri.Sasek@Sun.COM to wrap our krb5_locate_kdc
Jeremy Allison [Wed, 28 Mar 2007 19:47:59 +0000 (19:47 +0000)]
r22003: Fix from Jiri.Sasek@Sun.COM to wrap our krb5_locate_kdc
call as smb_krb5_locate_kdc to prevent incorrect linking
and crashes on Solaris.
(This used to be commit 7d30737c8d851505e81a60443baf9a8c7e523472)

14 years agor22002: Fix bug #3974, there are still open issues with -N behavior (doc fix next)
Simo Sorce [Wed, 28 Mar 2007 14:16:34 +0000 (14:16 +0000)]
r22002: Fix bug #3974, there are still open issues with -N behavior (doc fix next)
and -T argument parsing behavior (which is just insane but a separate bug)
(This used to be commit 1a3980f1fcb6431aa6bce83f7c34338436b4e962)

14 years agor22001: change prototype of dump_data(), so that it takes unsigned char * now,
Stefan Metzmacher [Wed, 28 Mar 2007 13:34:59 +0000 (13:34 +0000)]
r22001: change prototype of dump_data(), so that it takes unsigned char * now,
which matches what samba4 has.

also fix all the callers to prevent compiler warnings

(This used to be commit fa322f0cc9c26a9537ba3f0a7d4e4a25941317e7)

14 years agor22000: remove useless casts
Stefan Metzmacher [Wed, 28 Mar 2007 13:31:52 +0000 (13:31 +0000)]
r22000: remove useless casts

(This used to be commit 8f55fe4e4614d73c2534ca87745972f7550875ee)

14 years agor21999: remove useless casts
Stefan Metzmacher [Wed, 28 Mar 2007 13:26:43 +0000 (13:26 +0000)]
r21999: remove useless casts

(This used to be commit f948005ca69c50b07fdbcf7801975676d19d1486)

14 years agor21998: Fix tdb keynames in netsamlogon_clear_cached_user().
Günther Deschner [Wed, 28 Mar 2007 10:00:42 +0000 (10:00 +0000)]
r21998: Fix tdb keynames in netsamlogon_clear_cached_user().

No point in deleting U/DOMAIN/RID and UG/DOMAIN/RID keys if we only store U/SID
and UG/SID keys :-)

Next we need to verify the need of calling netsamlogon_clear_cached_user() at all.

(This used to be commit 78d13f14672b65c2d4798ce94322e945334eea62)