David O'Neill [Fri, 1 Sep 2000 18:49:26 +0000 (18:49 +0000)]
Changes from APPLIANCE_HEAD (per Tim Potter):
- make proto
- addition of function to convert from errno values to NT status codes
(source/lib/error.c)
- purge queue done without full access permission will purge only the
jobs owned by that user, rather than failing.
- unlock job database tdb before sending job to printer
- in print_job_start(), ensure that we don't pick a jobid with an existing
temporary file that may be owned by another user, as it causes silent
failures.
- fixes for printer permission checking for NT5 clients
(source/include/rpc_spoolss.h, source/printing/nt_printing.c,
source/printing/printing.c, source/rpc_server/srv_spoolss_nt.c)
- change from uint8 to 'enum SID_NAME_USE' (source/rpc_server/srv_lsa.c)
- fixed memory leaks for win95 driver download process
(source/smbd/lanman.c)
- properly free prs_structs and dacl in testsuite/printing/psec.c
(This used to be commit
74af3e2caec7197e5d1ca389e2f78054a4197502)
Jeremy Allison [Fri, 1 Sep 2000 17:13:44 +0000 (17:13 +0000)]
Fix from John Reilly @ HP for my typo with the parameters being reversed. Ooops.
Jeremy.
(This used to be commit
8317d70a35086c5539e67d60cbcf937b6ce0932c)
Gerald Carter [Fri, 1 Sep 2000 06:25:15 +0000 (06:25 +0000)]
-U% should be an anonymous connection. Fixed bug where
the password was being set to "" instead of NULL.
..and yes Elrond, I'll merge this into TNG.
P
jerry
(This used to be commit
cc611ecc674832f7e7390b5e7ad6648c9d622e9e)
Tim Potter [Fri, 1 Sep 2000 02:06:20 +0000 (02:06 +0000)]
Fix for swat to return correct MIME type for text files. From "Ron
Alexander" <rcalex@home.com>
(This used to be commit
061e5e50523913a26bc86bd816c4e26a37a832c7)
Jeremy Allison [Thu, 31 Aug 2000 19:04:51 +0000 (19:04 +0000)]
Implemented DELETEFORM tested using Gerald's Win32 test code :-).
Jeremy.
(This used to be commit
596c21a2af0309ce43a5e52a343a671036d05ebf)
Andrew Tridgell [Thu, 31 Aug 2000 07:11:59 +0000 (07:11 +0000)]
make sure a couple of variables are initialised
(This used to be commit
155c7c37398f5f9457ea249ded74f425b90ac9a0)
Andrew Tridgell [Thu, 31 Aug 2000 07:11:45 +0000 (07:11 +0000)]
fixed "admin users" option with new security code
(This used to be commit
b69c5de6bad9fad3aed1280e7d12fbfed276a16f)
Tim Potter [Thu, 31 Aug 2000 04:27:38 +0000 (04:27 +0000)]
Removed compiler warning.
(This used to be commit
2d23607bb0fe3d93809b3a194f9976b01ece8768)
Jeremy Allison [Wed, 30 Aug 2000 22:54:54 +0000 (22:54 +0000)]
Fixed overrun write error when using debuglevel > 50.
Jeremy.
(This used to be commit
3d9b163655f684f2b98aa72f976379cee869db05)
Jeremy Allison [Wed, 30 Aug 2000 21:09:21 +0000 (21:09 +0000)]
Fixed error returns for moving printer driver files around so generic
"Access denied" isn't always returned. More fixes found using Gerald's
wonderful Win32 test progs :-).
Jeremy.
(This used to be commit
67b9d40e3df19523714430cb4457717575f2a61e)
Jeremy Allison [Wed, 30 Aug 2000 18:33:56 +0000 (18:33 +0000)]
Added vfs_unlink call to ensure vfs is used on unlink from client.
Jeremy.
(This used to be commit
38fc56c8434c427335cf264c4b27420c5ad47566)
Jeremy Allison [Wed, 30 Aug 2000 17:34:35 +0000 (17:34 +0000)]
Fix for bind interfaces only sometimes picking the wrong IP address
for a name query. From Steve Langasek <vorlon@netexpress.net>.
Jeremy.
(This used to be commit
9890740121ae7bd7a0196bbf946c6f8c82aa7f6e)
Jeremy Allison [Wed, 30 Aug 2000 00:45:59 +0000 (00:45 +0000)]
Implemented AbortPrinter() from Gerald's Win32 test code. Just purge all
possible printjobs from that printer (I think this is correct).
Added error code returns for print_queue_XXX() functions.
Jeremy.
(This used to be commit
6d081a9017f87f59b7189ba507e211db01c40af5)
Gerald Carter [Tue, 29 Aug 2000 16:47:20 +0000 (16:47 +0000)]
missed removing the static declaration of strwicmp()
jerry
(This used to be commit
d09d8a3f4b32c1b4467dff5f2284e382163b7f09)
Gerald Carter [Tue, 29 Aug 2000 14:57:37 +0000 (14:57 +0000)]
Gerald Carter [Tue, 29 Aug 2000 14:43:42 +0000 (14:43 +0000)]
added -P (for no prompt) and -A <authfile> options
jerry
(This used to be commit
2d95c38f7e65a0379cbaadd57b8eb41d830b5a6b)
Gerald Carter [Tue, 29 Aug 2000 14:42:10 +0000 (14:42 +0000)]
added a #define for SPOOLSSGETPRINTERDATAEX. Although we do not
support the RPC yte (win2k specific), I added it for documentation
purposes.
jerry
(This used to be commit
41bf13341127b1c58105ca9a59fd686c15746164)
Gerald Carter [Tue, 29 Aug 2000 14:38:38 +0000 (14:38 +0000)]
fixed previous bug spotted by Elrond in get_printerdrivernumber().
Thought I had already committed this.
jerry
(This used to be commit
2ceb704c3d06a92b97ba67ac82c007a7ba084b75)
Gerald Carter [Tue, 29 Aug 2000 14:35:31 +0000 (14:35 +0000)]
added -A <authfile> option to smbclient for the reading of username /
password credentials from a file.
--jerry
(This used to be commit
e2915009031d63f43cc11c36dac2dfe6c780b5f0)
Gerald Carter [Tue, 29 Aug 2000 14:33:39 +0000 (14:33 +0000)]
needed to use strwicmp() in smbclient code, so I moved it to util_str.c
and made it non-static
--jerry
(This used to be commit
dfdca21bd90b9c83f195d580ec9d774f1be8f9cb)
Gerald Carter [Tue, 29 Aug 2000 14:32:23 +0000 (14:32 +0000)]
make rpcclent by default.
--jerry
(This used to be commit
e89117f418c9c1a1b4f2e9d708030369d801a01c)
Gerald Carter [Tue, 29 Aug 2000 14:31:27 +0000 (14:31 +0000)]
added the -A <authfile> option for allowing the reading of user
name and password credentials from a file. Designed for use
when needed to passwd credentials between scripts
--jerry
(This used to be commit
d8dde169e729ad5229d2bda8c9f306edb3c1239b)
Gerald Carter [Tue, 29 Aug 2000 14:29:53 +0000 (14:29 +0000)]
first draft at rpcclient man page for HEAD branch. Taken heavily
from the man page in TNG. Updated for newer spoolss commands.
jerry
(This used to be commit
0202f7e249a3988f94ab38706e6f6224148868bb)
Jeremy Allison [Tue, 29 Aug 2000 00:29:15 +0000 (00:29 +0000)]
This doesn't compile but is a placeholder for moving the UNIX
acl code over to POSIX acls.
Jeremy.
(This used to be commit
a2829febe12513d26534c4977c2f41f480f4fa0e)
Jeremy Allison [Mon, 28 Aug 2000 20:45:00 +0000 (20:45 +0000)]
smbd/password.c: Fixed typo in Tim's new code that caused insure overrun error.
smbd/reply.c: Fixed lowercasing UNIX character set problem.
Jeremy.
(This used to be commit
2b6e3ed7a6447d40d9dd7e9b5c286b1aabe4730d)
Herb Lewis [Mon, 28 Aug 2000 18:58:46 +0000 (18:58 +0000)]
added a little description of useage and output format since this gives
more info than just what parameters are not supported by SWAT.
(This used to be commit
7db533cb47a0d9bc88219dbe48e96ceed45a65a1)
Gerald Carter [Mon, 28 Aug 2000 13:41:46 +0000 (13:41 +0000)]
fixed typos spotted by Ron Alexander <rcalex@home.com>
--jerry
(This used to be commit
9fbcede92f558fdcda257338798613cffa4e2cb6)
Gerald Carter [Mon, 28 Aug 2000 13:35:10 +0000 (13:35 +0000)]
script written by herb for reporting which smb.conf parameters
are in loarparm.c but not supported by SWAT. I just thought it looked fun.
:-)
--jerry
(This used to be commit
eb20a2c6f478688b82ce8346fea618aebbfc9295)
Tim Potter [Mon, 28 Aug 2000 07:25:18 +0000 (07:25 +0000)]
Merge bug - still getting used to dirdiff.
(This used to be commit
cb717b4a2bb55eb2ff008e59203ebfeac6c5ab9f)
Tim Potter [Mon, 28 Aug 2000 06:50:45 +0000 (06:50 +0000)]
Oops - missed a file.
(This used to be commit
5aed84b74981a4f4fcc4d466ef03178eff22ba85)
Tim Potter [Mon, 28 Aug 2000 06:46:53 +0000 (06:46 +0000)]
Merge from appliance branch.
(This used to be commit
567b0095b1b8393b3b1e32533aa2860ab3dbfa47)
Andrew Tridgell [Mon, 28 Aug 2000 04:42:31 +0000 (04:42 +0000)]
yipee!
The spoolss AddJob function has an [in,out] buffer not an [in] buffer
(despite the comment in the code to the contrary). Also, we must fail
this function - not just blindly reply "no problem" as AddJob should
always fail on non-local printers.
This fixes a bug where the "print test page" failed about half the
time. I suspect it will also fix a bunch of other intermittent spoolss
bugs where the client (incorrectly) tries to use the AddJob printing
interface.
(This used to be commit
14e534a8907c34b53e00a63756efd71903ff9432)
Andrew Tridgell [Mon, 28 Aug 2000 03:17:22 +0000 (03:17 +0000)]
made reopen_logs() always re-open logs, not try and be smart about not
re-opening in some circumstances. This fixes a problem where a HUP
does not re-open logs and leaves the log open on a unlinked file.
(This used to be commit
f99f028c77482e591741df2a3da7f036f7409a68)
Andrew Tridgell [Mon, 28 Aug 2000 02:06:25 +0000 (02:06 +0000)]
arrgh.
whoever added "auto" parameters in loadparam only supported "True", "False"
and "Auto", and did not support "Yes" and "No" like booleans. This
means anyone using "preferred master = yes" didn't get what they
expected!
(This used to be commit
311a4dfb9a9a39a54dcb47d83e1604ad7461dce4)
Jeremy Allison [Fri, 25 Aug 2000 20:44:33 +0000 (20:44 +0000)]
vfs write data fix. Fix for name matching in addtosmbpass
Jeremy.
(This used to be commit
85738b7ee1ea6d88999d6aedc51a2daf545cb8b8)
Tim Potter [Fri, 25 Aug 2000 04:18:50 +0000 (04:18 +0000)]
Replaced "\\MAILSLOT\\NET\\NETLOGON" with NET_LOGON_MAILSLOT constant.
(This used to be commit
5764e84c0e01fa4d6ecba410542f6f5c63b9eae6)
Andrew Tridgell [Fri, 25 Aug 2000 03:58:02 +0000 (03:58 +0000)]
- fixed the %U macro so that the old (and documented) semantics work
again. This got broken with one of the substitute.c updates a couple
of months ago.
- also fixed %u to return the username from the current_user structure
when called via a method that does not have direct access to the
username. I cache the uidtoname() result to prevent thrashing nss.
(This used to be commit
2520a0eff9c5decbec79aababe9910db3535890a)
Tim Potter [Fri, 25 Aug 2000 00:55:27 +0000 (00:55 +0000)]
Updated file with version in TNG.
(This used to be commit
156e17dea48962bca98a3f7d1e876eb6047ebc8a)
Jeremy Allison [Thu, 24 Aug 2000 19:48:31 +0000 (19:48 +0000)]
Modified to use sid_to_uid and sid_to_gid. Now ready for POSIX ACL
code....
Jeremy.
(This used to be commit
28586c1dee18d99e0e0999ab1a945a33ce33c371)
Jeremy Allison [Wed, 23 Aug 2000 23:05:49 +0000 (23:05 +0000)]
Tidied up some error returns from printing calls. Still need to map UNIX
errors to NT error for print job failure returns. Patch from John Reilly at HP.
Jeremy.
(This used to be commit
3514b5bb8fffd78e3647425d93b74e2e6291bafc)
Jeremy Allison [Wed, 23 Aug 2000 17:38:52 +0000 (17:38 +0000)]
Documentation on NT_USER_TOKEN. Requested by Sander.
Jeremy.
(This used to be commit
e203324d4a3b9aac99ed0b22cbd8c373461919dd)
Jeremy Allison [Wed, 23 Aug 2000 00:45:40 +0000 (00:45 +0000)]
Added code to do SID to uid/gid conversion. Needed for ACL support.
Jeremy.
(This used to be commit
81c5380f91839b6416c8a42739dadf00e7388528)
Tim Potter [Tue, 22 Aug 2000 06:28:33 +0000 (06:28 +0000)]
Patch from John Reilly <jreilly@hp.com> for not processing duplicate files
when moving printer driver to download area.
(This used to be commit
6e0c9079c385a4f0e61d9f1b1e0351bc4dbc3151)
Jeremy Allison [Mon, 21 Aug 2000 19:30:19 +0000 (19:30 +0000)]
Fix for safe_free freeing static strings. From Robert August Vincent, II.
Jeremy.
(This used to be commit
bd844fcd3023ab956eb7ab369475955a88bcca14)
Luke Leighton [Fri, 18 Aug 2000 06:27:24 +0000 (06:27 +0000)]
oops. must return "" string and length zero when strlen(filebuf) == 0
(This used to be commit
d3bc7cca99e47ce89035a03022d7c3ec69e01636)
Gerald Carter [Fri, 18 Aug 2000 06:03:13 +0000 (06:03 +0000)]
fixed an off by one error where I was tromping on memory
when initializing a driver_info_3 struct. See spoolss_addprinterdriver()
jerry
(This used to be commit
4fad1fc28a0396443e4723d2065860feb283a785)
Gerald Carter [Fri, 18 Aug 2000 05:57:09 +0000 (05:57 +0000)]
fixed initialization errors (again!) I must have forgot to
check these in before.
jerry
(This used to be commit
e682d6a599934e5460abe0d30cb2465fa80c7937)
Luke Leighton [Fri, 18 Aug 2000 05:56:19 +0000 (05:56 +0000)]
getfileline() - line with length of zero -> filebuf[strlen(filebuf)-1]
is NOT ok.
(This used to be commit
24e0c8ef70dc59bfaaa113c3d44befbccbcba15f)
Gerald Carter [Fri, 18 Aug 2000 05:55:37 +0000 (05:55 +0000)]
changing some debug message levels
j-
(This used to be commit
facef51be4e3f3be75613f39c8dfedfa7410552c)
Gerald Carter [Thu, 17 Aug 2000 20:05:05 +0000 (20:05 +0000)]
Fix for Win9x driver downloads when information is
stored in the TDB. See the message I posted about
this on samba-technical
* If the admin does not desire the new NT print driver
support, nothing needs to be done. All existing
parameters work the same.
* If the admin wants to take advantage of NT printer
driver support but does not want to migrate the 9x drivers
to the new setup, the leave the existing printers.def
file. When smbd attempts to locate a 9x driver for the
printer in the TDB and fails it will drop down to
using the printers.def (and all associated parameters).
The make_printerdef tool will also remain for backwards
compatibility but will be moved to the "this tool is the
old way of doing it" pile.
* If the admin installs a 9x driver for a printer on
a Samba host (in the printing TDB), this information will
take precedence and the three old printing parameters
will be ignored (including print driver location).
* If an admin wants to migrate the printers.def file into
the new setup, I can write a script to do this using
rpcclient. The main problem is the driver namespace
(we need the NT driver name first in order to
be consistent).
jerry
(This used to be commit
ac049f8bf348810dc068382fdbc6635a2015d36a)
Gerald Carter [Thu, 17 Aug 2000 20:03:53 +0000 (20:03 +0000)]
added comment for my own memory purposes
jerry
(This used to be commit
b64ddbd1aaba8811641e502e96f3bbef01171f52)
Gerald Carter [Wed, 16 Aug 2000 03:44:04 +0000 (03:44 +0000)]
hack for unmarshalling unistr's on machines with BIG_ENDIAN arch
I think we have a lot more of these bugs lurking (i'm fairly
confident of it).
jerry
(This used to be commit
3b14487c7e5218ff3e0ff3118ca1afd706e05247)
Gerald Carter [Wed, 16 Aug 2000 03:41:02 +0000 (03:41 +0000)]
- fixed memcpy bug in copy_unistr2()
- init_unistr2_from_unistr() does not NULL terminate
the buffer
--jerry
(This used to be commit
65ee5f9b6ed3c4ad33fefd3c879f2649496fd3f3)
Gerald Carter [Wed, 16 Aug 2000 03:38:52 +0000 (03:38 +0000)]
fixed unitialized struct bug in enum_users (whatever it is called)
jerry
(This used to be commit
a606131508592d72f3fd8a0dd63073e9c559062f)
Gerald Carter [Wed, 16 Aug 2000 03:34:58 +0000 (03:34 +0000)]
fixed typo.
jerry
(This used to be commit
f00a330b3e7900bc325802b2a252a392a16a8b2a)
Gerald Carter [Tue, 15 Aug 2000 23:36:05 +0000 (23:36 +0000)]
fixed error in [public] spotted by Ron Alexander <rcalex@home.com>
changed to read only = yes
jerry
(This used to be commit
e17753c532ab6d5ae628c6e6f6d5b810638cb314)
Tim Potter [Tue, 15 Aug 2000 21:09:54 +0000 (21:09 +0000)]
Merge ... uninitialised variable fix from APPLIANCE_HEAD.
(This used to be commit
20a7fefee8c85f02f6a0e2a02c0df04a8b22b7cb)
Jeremy Allison [Tue, 15 Aug 2000 02:33:27 +0000 (02:33 +0000)]
Tidied up extra ()'s.
Jeremy
(This used to be commit
f94f37dcab2bc2b68e2b6b4ca440ad53a60e8117)
Jeremy Allison [Mon, 14 Aug 2000 23:48:07 +0000 (23:48 +0000)]
Reverted the change Luke made. Removed IS_BITS_SET_XX macros.
Do not re-add them. These macros are unsafe as they are not understood.
Change all TNG code using them to correct '&' and '|' please.
IS_BITS_SET_ALL was being used in cmd_interp.c when IS_BITS_SET_SOME
should have been used.
Jeremy.
(This used to be commit
be4e5eeb4f808c1d8ac4030e8886a83a37914c57)
Tim Potter [Mon, 14 Aug 2000 21:27:54 +0000 (21:27 +0000)]
Gerald Carter [Mon, 14 Aug 2000 21:18:02 +0000 (21:18 +0000)]
fixed a few bugs in new_smb_io_relarraystr().
Marshalling code path now uses spoolss_smb_io_unistr()
also caught a NULL pointer case.
i'll update TNG later.
(This used to be commit
bd4c83eb40a14baf447ac88886d4eafe7b9a309f)
Tim Potter [Mon, 14 Aug 2000 18:39:51 +0000 (18:39 +0000)]
NT printer permissions test program.
(This used to be commit
9af82423d2e5c6f873a906097a56c8ac6c5f8297)
Luke Leighton [Mon, 14 Aug 2000 11:03:30 +0000 (11:03 +0000)]
restored IS_BITS_SET_xxx macros.
(This used to be commit
bc065f9597654666e2f26ec046e058e44247d6e3)
Luke Leighton [Mon, 14 Aug 2000 07:37:12 +0000 (07:37 +0000)]
hey, jerry: turns out you _have_ converted to get_safe_nt_errmsg!!!
[got confused with which way dirdiff was going :)].
... but you forgot to update TNG's lib/cmd_interp.c...
(This used to be commit
8fe195df0b5826af7048ef6c87e4b55dfd336cf8)
Luke Leighton [Mon, 14 Aug 2000 07:33:34 +0000 (07:33 +0000)]
jeremy,
please do not remove IS_BITS_SET_XXX macros just because you happen
"not to like them". whilst still working on merging, you are not
responsible for this code, therefore do not hinder its development
whilst people are attempting to do merges. after the merge from
TNG to cvs main is completed, you can do what the hell you like.
thank you.
jerry,
please could you consider adding underlying routines (in this case
get_safe_smb_errstr()) instead of reverting to a [less secure]
previous coding method. thanks.
(This used to be commit
b2e044f89de7cb12fd14540d5d7d5070951ce2fb)
Gerald Carter [Mon, 14 Aug 2000 03:18:17 +0000 (03:18 +0000)]
minor formatting fixes.
jerry
(This used to be commit
95355d2cf26f51b1f928b8a020a4a731483be0b8)
Gerald Carter [Mon, 14 Aug 2000 03:17:17 +0000 (03:17 +0000)]
fix for new_smb_io_relarraystr() and new_smb_io_relstr()
to use spool_smb_io_unistr() as this does not call prs_align()
befrore parsing the UNISTR.
Parsing a void* buffer from an RPC should not be aligned
on 4 byte boundaries. Don't think this change affects
any marshalling code, only unmarshalling...
jerry
(This used to be commit
bc154e8522a75540a8504195c1e6f45739167e6b)
Gerald Carter [Sat, 12 Aug 2000 14:51:36 +0000 (14:51 +0000)]
removed the prs_align in spoolss_smb_io_unistr() (JF, please check)
as it was throwing things off when parsing buffers passed in SPOOLSS
RPCs
fixed the unmarshalling of UNISTR arrays to be double NULL terminated
jerry
(This used to be commit
236f19659cea87cc35128990954d30c43114b889)
Gerald Carter [Sat, 12 Aug 2000 14:31:29 +0000 (14:31 +0000)]
fixes to prs_unistr UNMARSHALLING only. Problem was due to talloc's
of 0 bytes.
jerry
(This used to be commit
3fcc59ba928250759bbf3ef46d7c118950a5ba6f)
Gerald Carter [Sat, 12 Aug 2000 14:26:01 +0000 (14:26 +0000)]
FIxed some unmarshalling problems with relstr and unistr arrays
jerry
(This used to be commit
ce2d20395ae3d41d55030427f4b7b44ce87c605e)
Gerald Carter [Sat, 12 Aug 2000 14:20:40 +0000 (14:20 +0000)]
fixed unistr_to_ascii to deal with NULL src strings
jerry
(This used to be commit
8e95aae1709a9be28d6e25ff6f0fdc729dc09274)
Gerald Carter [Sat, 12 Aug 2000 14:14:40 +0000 (14:14 +0000)]
reworked talloc() to in order to help track down invalid
memory access.
Tridge, I don't think using 0xdeadbeef for size allocations
of 0 is going to work. I ended up having to use NULL
as much code that works on UNISTR checks to see if the buffer ptr
is NULL. So valid code ends up with a seg fault.
Rather than rewriting it all, I added a DEBUG_TALLOC
#ifdef in talloc.h that sets a macro BAD_PTR.
This is the value assigned to ptr for an allocation of 0 bytes.
jerry
(This used to be commit
233b9cffa2350552d9f775f791d5d5e0464a1ed4)
Gerald Carter [Sat, 12 Aug 2000 14:10:27 +0000 (14:10 +0000)]
removed (void) typecast from SMB_ASSERT
jerry
(This used to be commit
f806881e6c2c94c03fb7e70d92cd0a5a3fc30fbd)
John Terpstra [Sat, 12 Aug 2000 02:41:42 +0000 (02:41 +0000)]
Updated by Patrick Powell <papowell@lprng.org>
(This used to be commit
3361c144f5ba2a87a469436f670ab35189021d49)
Jeremy Allison [Fri, 11 Aug 2000 23:13:09 +0000 (23:13 +0000)]
Fixed the problem with UNISTR marshalling in a buffer5 struct.
The smb_io_unistr() code called a prs_align, this was not being
counted in the size or taken account of in the offset calculation.
Fixed size_ calculation to always return a size a multiple of 4
and also set the offset correctly. This fixes the problem I saw
and will hopefully fix the problem HP reported. JF please check
this change.
Jeremy.
(This used to be commit
ceba9f3dcdb4bddae17ec0024692c9074086302d)
Christopher R. Hertel [Fri, 11 Aug 2000 22:29:44 +0000 (22:29 +0000)]
First shot at actually *doing* WINS failover.
If libsmb/namequery.c:name_query() times out while doing a non-broadcast
query, I mark that WINS server 'dead'. Note that I don't try the new
WINS server. I think I can get that working too.
This is only for queries, not registrations. The biggest problem is that
I may have to fiddle with the UNICAST SUBNET, but I need to check talk
that over with someone (Jeremy?) before I hack at it.
I can't actually test the above change, I'm 'fraid. I'm getting:
4 errors detected in the compilation of "rpc_server/srv_spoolss_nt.c".
in head branch.
Chris -)-----
(This used to be commit
40ae638866e3d826ccd5d827672634959c31b039)
Jeremy Allison [Fri, 11 Aug 2000 00:53:13 +0000 (00:53 +0000)]
Fix case where volumename could be returned as UNIX charset or DOS codepage
depending on where it came from.
Jeremy.
(This used to be commit
cfbf78085d48671e5be382e7486953a85a893be1)
Jeremy Allison [Thu, 10 Aug 2000 23:41:16 +0000 (23:41 +0000)]
Added "add_printer_hook" call to update printer for Win9x clients.
Patch from John Reilly <jreilly@hp.com>.
Jeremy.
(This used to be commit
76a5713bd3fad18ec60d12fc3f965f3e9717c159)
Jeremy Allison [Thu, 10 Aug 2000 19:51:45 +0000 (19:51 +0000)]
Tidied up security rights definitions.
Jeremy.
(This used to be commit
e466c863f5540e13776f4477b6d58e3fbfe7276d)
Jeremy Allison [Thu, 10 Aug 2000 17:48:15 +0000 (17:48 +0000)]
Removed requirement that sid have an owner before being interpreted.
Thanks to Elrond for pointing this out.
Jeremy.
(This used to be commit
1d9a5494f8214b8d6171073f4090687a8535d78c)
Gerald Carter [Thu, 10 Aug 2000 14:05:19 +0000 (14:05 +0000)]
Working on spoolss_getprinterdriver() as it does not display all the
dependentfiles.
jery
(This used to be commit
206565368b887ba83791efe018f24175e6f31137)
Gerald Carter [Thu, 10 Aug 2000 14:03:13 +0000 (14:03 +0000)]
working on the unmarshalling of dependentfiles to a DRIVER_INFO_3
struct. Not wuite there.
jerry
(This used to be commit
1a145977f09654fc51ebcd40ef7a2aa69aa96cfb)
Gerald Carter [Thu, 10 Aug 2000 14:02:07 +0000 (14:02 +0000)]
code formatting cleanup
jerry
(This used to be commit
4bc5b8aa345b963e1247c6a364ba48a08fbd9764)
Gerald Carter [Thu, 10 Aug 2000 14:00:40 +0000 (14:00 +0000)]
deal with allocation size of 0 in prs_unistr when UNMARSHALLING
jerry
(This used to be commit
26a73a70e282a5e46cc2b6fe7bc09b406724c9dd)
Gerald Carter [Thu, 10 Aug 2000 14:00:05 +0000 (14:00 +0000)]
Deal will NULL UNISTR in unistr_to_ascii
jerry
(This used to be commit
cfa4c878a2ccaf346940f8f4a201737e185f76d6)
Gerald Carter [Thu, 10 Aug 2000 13:58:15 +0000 (13:58 +0000)]
talloc returns 0xdeadbeef when asked to allocate 0 bytes
jerry
(This used to be commit
df51dc32f6ffc4fe2cebfaae5079417aad1ff34d)
Gerald Carter [Thu, 10 Aug 2000 04:10:29 +0000 (04:10 +0000)]
Needed to add the SHARED attribute bit when creating a printer
on a Samba host. Also needed to add an option to pass the share
name (printer name) on the command line.
And fixed the checking of the return code for spoolss_r_addprinterex()
jerry
(This used to be commit
880e81161640cd38540b06d982c592cbada51d40)
Jeremy Allison [Wed, 9 Aug 2000 23:19:50 +0000 (23:19 +0000)]
Fixed bug in new printer access check code. If PRINTER_ALL_ACCESS is changed
in the ACE's the same thing must be done in the desired access or they will
never match. This took me a while to find... :-).
Jeremy.
(This used to be commit
066520979b2b5d967e6e1d77f16185a5fb19dc0c)
Gerald Carter [Wed, 9 Aug 2000 20:19:37 +0000 (20:19 +0000)]
Gerald Carter [Wed, 9 Aug 2000 20:14:29 +0000 (20:14 +0000)]
More work on AddPrinterDriver() and AddPrinterEx() client RPC's
Also fixed init_unistr() to deal with a NULL source character string.
-jerry
(This used to be commit
8ecd5dd52a6bd867f5d117352048ee43ce7254d9)
Jeremy Allison [Wed, 9 Aug 2000 18:40:48 +0000 (18:40 +0000)]
Fixed memory leak with NT tokens.
Added debug messages to se_access_check().
Added FULL_ACCESS acl to default acl on printers.
Jeremy.
(This used to be commit
7507f6f408cf8b0f8d7e2b3da54ce5fb5ef5343b)
Andrew Tridgell [Wed, 9 Aug 2000 07:34:35 +0000 (07:34 +0000)]
got error code right for printer update/add failure
(This used to be commit
0d00d2ec258b36d73e865f06d5d11745d7cdafa9)
Andrew Tridgell [Wed, 9 Aug 2000 04:25:01 +0000 (04:25 +0000)]
add printer admin docs
(This used to be commit
1342f2e5be28d1582ab39ec837392fbf9e721014)
Andrew Tridgell [Wed, 9 Aug 2000 04:19:18 +0000 (04:19 +0000)]
added printer admin option
any user in that list can do anything to a printer
(This used to be commit
7b5912be150dd590d6195be40b0976305b8716ba)
Gerald Carter [Wed, 9 Aug 2000 02:04:25 +0000 (02:04 +0000)]
Fixed AddPrinterDriver()
jerry
(This used to be commit
39d025693eadf4ca1c4fe17dd9110bb8a647f361)
Andrew Tridgell [Wed, 9 Aug 2000 00:11:01 +0000 (00:11 +0000)]
fixed help string
(This used to be commit
16afa46797a4cdaa6e3b668caf6d910c08bec9b4)
Jeremy Allison [Tue, 8 Aug 2000 23:49:26 +0000 (23:49 +0000)]
Found the sec_ctx_stack overflow - a become_root() should have been an
unbecome_root() - typo.
Jeremy.
(This used to be commit
ebb160663ed55e44e44f1c3d17eb077a32c2ffb9)
Jeremy Allison [Tue, 8 Aug 2000 21:51:22 +0000 (21:51 +0000)]
Added SID "Everyone" S-1-1-0 as always matching if present in an ACE.
Jeremy.
(This used to be commit
b3a1038ac1bfb0c32e64f6cb26e5e46fbda794a2)
Jeremy Allison [Tue, 8 Aug 2000 19:34:34 +0000 (19:34 +0000)]
Changed the sec desc access checks to match the spec. Needs testing.
Jeremy.
(This used to be commit
5a4a7cd4727df5d1b5e71d343e776c7df52dc515)
Gerald Carter [Tue, 8 Aug 2000 07:23:20 +0000 (07:23 +0000)]