ira/wip.git
14 years agor23654: Remove misleading inline comment.
Günther Deschner [Fri, 29 Jun 2007 11:54:29 +0000 (11:54 +0000)]
r23654: Remove misleading inline comment.

Guenther

14 years agor23652: Use the recursive delete function instead of the original one
Michael Adam [Fri, 29 Jun 2007 10:22:18 +0000 (10:22 +0000)]
r23652: Use the recursive delete function instead of the original one
when deleting a share. Just to be sure...

Michael

14 years agor23651: Always, always, always compile before commit...
Günther Deschner [Fri, 29 Jun 2007 09:58:11 +0000 (09:58 +0000)]
r23651: Always, always, always compile before commit...

Guenther

14 years agor23650: Fix remaining callers of krb5_kt_default().
Günther Deschner [Fri, 29 Jun 2007 09:54:39 +0000 (09:54 +0000)]
r23650: Fix remaining callers of krb5_kt_default().

Guenther

14 years agor23649: Fix the build (by moving smb_krb5_open_keytab() to clikrb5.c).
Günther Deschner [Fri, 29 Jun 2007 09:42:14 +0000 (09:42 +0000)]
r23649: Fix the build (by moving smb_krb5_open_keytab() to clikrb5.c).

Guenther

14 years agor23648: Allow to list a custom krb5 keytab file with:
Günther Deschner [Fri, 29 Jun 2007 09:01:29 +0000 (09:01 +0000)]
r23648: Allow to list a custom krb5 keytab file with:

net ads keytab list /path/to/krb5.keytab

Guenther

14 years agor23647: Use smb_krb5_open_keytab() in smbd as well.
Günther Deschner [Fri, 29 Jun 2007 08:58:03 +0000 (08:58 +0000)]
r23647: Use smb_krb5_open_keytab() in smbd as well.

Guenther

14 years agor23646: Generalize our internal keytab handling to support a broader range of default
Günther Deschner [Fri, 29 Jun 2007 08:56:35 +0000 (08:56 +0000)]
r23646: Generalize our internal keytab handling to support a broader range of default
keytabnames (like "ANY:FILE:/etc/krb5.keytab,krb4:/etc/srvtab"). This also
fixes keytab support with Heimdal (which supports the WRFILE pragma as well
now).

Guenther

14 years agor23645: add examples and try to answer some common questions in the coding style...
Gerald Carter [Thu, 28 Jun 2007 19:27:30 +0000 (19:27 +0000)]
r23645: add examples and try to answer some common questions in the coding style guide

14 years agor23641: Put check for forbidden values in smbconf into a function.
Michael Adam [Thu, 28 Jun 2007 10:32:52 +0000 (10:32 +0000)]
r23641: Put check for forbidden values in smbconf into a function.
(This will be used in a next step to prevent storing these
values in reg_smbconf.c.)

Michael

14 years agor23640: When we support the SeSecurity privilage, this is where
Jeremy Allison [Wed, 27 Jun 2007 22:45:08 +0000 (22:45 +0000)]
r23640: When we support the SeSecurity privilage, this is where
we'll check it.
Jeremy.

14 years agor23639: Eliminate trailing whitespaces in the new tdb_validate functions...
Michael Adam [Wed, 27 Jun 2007 22:10:25 +0000 (22:10 +0000)]
r23639: Eliminate trailing whitespaces in the new tdb_validate functions...

Michael

14 years agor23636: Adding coding style guide for Samba 3.0 branches (no differences from Tridge...
Gerald Carter [Wed, 27 Jun 2007 18:28:18 +0000 (18:28 +0000)]
r23636: Adding coding style guide for Samba 3.0 branches (no differences from Tridge's prog_guide.txt so we should have a similar style throughout the project)

14 years agor23633: Fix a couple of crash bugs pointed out by Volker caused by an old
Gerald Carter [Wed, 27 Jun 2007 16:52:36 +0000 (16:52 +0000)]
r23633: Fix a couple of crash bugs pointed out by Volker caused by an old
change from a pstring to a char* and still trying use pstrcpy().

14 years agor23632: Correctly return the new_group list pointer from expand_groups
Gerald Carter [Wed, 27 Jun 2007 16:52:34 +0000 (16:52 +0000)]
r23632: Correctly return the new_group list pointer from expand_groups
or else getgrnam() always  acts like 'winbind expand groups = 1'

14 years agor23630: Found out what LSA_LOOKUP_NAMES level 5 means:
Günther Deschner [Wed, 27 Jun 2007 12:35:12 +0000 (12:35 +0000)]
r23630: Found out what LSA_LOOKUP_NAMES level 5 means:
only query transitive forest trusts.

Guenther

14 years agor23628: Add LSA lookupnames_level to rpcclient.
Günther Deschner [Wed, 27 Jun 2007 12:27:00 +0000 (12:27 +0000)]
r23628: Add LSA lookupnames_level to rpcclient.

Guenther

14 years agor23627: Allow to pass down the lookup-level to rpccli_lsa_lookup_names().
Günther Deschner [Wed, 27 Jun 2007 11:42:17 +0000 (11:42 +0000)]
r23627: Allow to pass down the lookup-level to rpccli_lsa_lookup_names().

Guenther

14 years agor23625: Reformating WBFLAGs, just a cosmetic change.
Günther Deschner [Wed, 27 Jun 2007 09:38:07 +0000 (09:38 +0000)]
r23625: Reformating WBFLAGs, just a cosmetic change.

Guenther

14 years agor23624: Merge dos error code from samba4 (returned from dfs_Enum against w2k3 as...
Günther Deschner [Wed, 27 Jun 2007 09:36:00 +0000 (09:36 +0000)]
r23624: Merge dos error code from samba4 (returned from dfs_Enum against w2k3 as soon
as a one DFS_VOLUME_FLAVOR_AD_BLOB dfsroot exists).

Guenther

14 years agor23623: Fix rpcclient and rpc_server with new DFS idl.
Günther Deschner [Wed, 27 Jun 2007 09:23:50 +0000 (09:23 +0000)]
r23623: Fix rpcclient and rpc_server with new DFS idl.

Guenther

14 years agor23622: regenerate dfs rpc gen_ndr.
Günther Deschner [Wed, 27 Jun 2007 09:17:52 +0000 (09:17 +0000)]
r23622: regenerate dfs rpc gen_ndr.

Guenther

14 years agor23621: Merge samba4 dfs rpc idl.
Günther Deschner [Wed, 27 Jun 2007 09:13:28 +0000 (09:13 +0000)]
r23621: Merge samba4 dfs rpc idl.

Guenther

14 years agor23620: Convert set_nt_acl to return NTSTATUS. Also fix the chown
Jeremy Allison [Tue, 26 Jun 2007 22:49:10 +0000 (22:49 +0000)]
r23620: Convert set_nt_acl to return NTSTATUS. Also fix the chown
return to correctly return NT_STATUS_INVALID_OWNER if it
should be disallowed. Matches better what W2K3R3 does.

NFSv4 ACL module owners, please examine these changes.

Jeremy.

14 years agor23619: Fix compile warning in fill_grent_mem() caused by mismatched counter size.
Gerald Carter [Tue, 26 Jun 2007 21:22:01 +0000 (21:22 +0000)]
r23619: Fix compile warning in fill_grent_mem() caused by mismatched counter size.

14 years agor23616: Fix bugzilla #4719: must change password is not set from usrmgr.exe.
Jim McDonough [Tue, 26 Jun 2007 20:09:41 +0000 (20:09 +0000)]
r23616: Fix bugzilla #4719: must change password is not set from usrmgr.exe.

This was only affecting the newer versions of usrmgr.exe, because they
use a user_info_25 struct.  The password is getting set separately
inside that code, so the password last set time was getting set from the
password change logic.

We also were not parsing a number of fields (like logon hours) from the
user_info_25.  That should also be fixed.

14 years agor23612: Revert 'net idmap dump' to the 3.0.24 behaviour.
Volker Lendecke [Tue, 26 Jun 2007 19:15:26 +0000 (19:15 +0000)]
r23612: Revert 'net idmap dump' to the 3.0.24 behaviour.

14 years agor23611: Fix typo in error message.
James Peach [Tue, 26 Jun 2007 18:18:44 +0000 (18:18 +0000)]
r23611: Fix typo in error message.

14 years agor23610: Move some winbindd_cache specific flags and actions
Michael Adam [Tue, 26 Jun 2007 13:45:07 +0000 (13:45 +0000)]
r23610: Move some winbindd_cache specific flags and actions
back to winbindd_cache.c. The generic mechanism
should open the cache tdb readonly and with default
flags.

Michael

14 years agor23609: Removing more redundant codepaths out of smb_krb5_renew_ticket().
Günther Deschner [Tue, 26 Jun 2007 10:19:06 +0000 (10:19 +0000)]
r23609: Removing more redundant codepaths out of smb_krb5_renew_ticket().

Thanks Volker for the pointer hint :)

Guenther

14 years agor23608: Just inline comment cosmetics.
Günther Deschner [Tue, 26 Jun 2007 09:41:14 +0000 (09:41 +0000)]
r23608: Just inline comment cosmetics.

Guenther

14 years agor23607: Add legacy support for Services for Unix (SFU) 2.0.
Günther Deschner [Tue, 26 Jun 2007 09:15:37 +0000 (09:15 +0000)]
r23607: Add legacy support for Services for Unix (SFU) 2.0.

Guenther

14 years agor23606: Merge Samba4 mkversion.sh to Samba3.
Kai Blin [Tue, 26 Jun 2007 09:10:30 +0000 (09:10 +0000)]
r23606: Merge Samba4 mkversion.sh to Samba3.

14 years agor23601: BUG 4579: Don't mark the SAM domain on a Samba DC as an internal domain or...
Gerald Carter [Tue, 26 Jun 2007 00:52:19 +0000 (00:52 +0000)]
r23601: BUG 4579: Don't mark the SAM domain on a Samba DC as an internal domain or else all network connections from the local winbindd will fail

14 years agor23600: First step in abstracting the winbindd cache validation
Michael Adam [Mon, 25 Jun 2007 20:17:04 +0000 (20:17 +0000)]
r23600: First step in abstracting the winbindd cache validation
code into a generic tdb validation code.
In lib/util_tdb.c for a start.

Michael

14 years agor23599: Add new version of indent script copied from the the Linux
Gerald Carter [Mon, 25 Jun 2007 15:23:19 +0000 (15:23 +0000)]
r23599: Add new version of indent script copied from the the Linux
kernel tree.

14 years agor23598: Add script for running indent and remove .indent.pro file
Gerald Carter [Mon, 25 Jun 2007 15:18:41 +0000 (15:18 +0000)]
r23598: Add script for running indent and remove .indent.pro file

14 years agor23597: add a few utility scripts for code formatting
Gerald Carter [Mon, 25 Jun 2007 14:40:59 +0000 (14:40 +0000)]
r23597: add a few utility scripts for code formatting

14 years agor23596: Add notes about smbfs/cifs to usage() in smb[u]mount
Volker Lendecke [Mon, 25 Jun 2007 11:45:54 +0000 (11:45 +0000)]
r23596: Add notes about smbfs/cifs to usage() in smb[u]mount

14 years agor23595: One pstring a day...
Volker Lendecke [Sun, 24 Jun 2007 13:40:58 +0000 (13:40 +0000)]
r23595: One pstring a day...

14 years agor23594: Fix parsing of local pids if cluster support is compiled in but no
Volker Lendecke [Sun, 24 Jun 2007 13:24:20 +0000 (13:24 +0000)]
r23594: Fix parsing of local pids if cluster support is compiled in but no
cluster is used

14 years agor23593: Mention "net conf" in top level net usage.
Michael Adam [Fri, 22 Jun 2007 22:37:07 +0000 (22:37 +0000)]
r23593: Mention "net conf" in top level net usage.

Michael

14 years agor23592: Change a debuglevel to not clutter output when calling
Michael Adam [Fri, 22 Jun 2007 22:30:01 +0000 (22:30 +0000)]
r23592: Change a debuglevel to not clutter output when calling
net as a non-root user, e.g.

Michael

14 years agor23591: Fix bug #4725. Don't crash when no eventlogs specified. Needs
Jeremy Allison [Fri, 22 Jun 2007 19:33:46 +0000 (19:33 +0000)]
r23591: Fix bug #4725. Don't crash when no eventlogs specified. Needs
merging for 3.0.25b.
Jeremy.

14 years agor23590: Fix realloc leak on failure case from Jim Meyering <jim@meyering.net>.
Jeremy Allison [Fri, 22 Jun 2007 17:36:10 +0000 (17:36 +0000)]
r23590: Fix realloc leak on failure case from Jim Meyering  <jim@meyering.net>.
Jeremy.

14 years agor23589: Ensure we will always release any timeout handler
Jeremy Allison [Fri, 22 Jun 2007 17:19:08 +0000 (17:19 +0000)]
r23589: Ensure we will always release any timeout handler
on fsp close or removal of oplock. Mulitple removals
are safe.
Jeremy.

14 years agor23588: Some more cleanups and error checks in the krb5 renew function.
Günther Deschner [Fri, 22 Jun 2007 14:54:39 +0000 (14:54 +0000)]
r23588: Some more cleanups and error checks in the krb5 renew function.

Guenther

14 years agor23587: Cleanup redundant code in the krb5 renew function.
Günther Deschner [Fri, 22 Jun 2007 14:50:15 +0000 (14:50 +0000)]
r23587: Cleanup redundant code in the krb5 renew function.

Guenther

14 years agor23586: Fix heimdal path in the krb5 renew routine when we need to compose the tgt
Günther Deschner [Fri, 22 Jun 2007 14:43:42 +0000 (14:43 +0000)]
r23586: Fix heimdal path in the krb5 renew routine when we need to compose the tgt
string ourselves.

Guenther

14 years agor23585: Add a "drop" function to "net conf" that clears the
Michael Adam [Fri, 22 Jun 2007 11:43:50 +0000 (11:43 +0000)]
r23585: Add a "drop" function to "net conf" that clears the
whole configuration stored in registry.

Michael

14 years agor23584: Use a while loop instead of a for loop without increment... :-)
Michael Adam [Fri, 22 Jun 2007 11:42:17 +0000 (11:42 +0000)]
r23584: Use a while loop instead of a for loop without increment... :-)

Michael

14 years agor23583: Add a utility function to recursively delete a Registry
Michael Adam [Fri, 22 Jun 2007 11:21:59 +0000 (11:21 +0000)]
r23583: Add a utility function to recursively delete a Registry
key with all its subkeys. (reg_deletekey will refuse to
delete a key with subkeys with WERR_ACCESS_DENIED).

Michael

14 years agor23582: Fix event based krb5 ticket refreshing in winbindd.
Günther Deschner [Fri, 22 Jun 2007 11:20:37 +0000 (11:20 +0000)]
r23582: Fix event based krb5 ticket refreshing in winbindd.

We were incorrectly using the renew_till timestamp instead of the renewed
ticket's endtime to calculate the next refreshing date.

Guenther

14 years agor23581: Move regkey_open_onelevel from reg_frontend to reg_api,
Michael Adam [Fri, 22 Jun 2007 11:03:48 +0000 (11:03 +0000)]
r23581: Move regkey_open_onelevel from reg_frontend to reg_api,
where it actually belongs, and make it static.

Michael

14 years agor23579: Up to now, the "allparameters" argument to lp_next_parameter was
Michael Adam [Thu, 21 Jun 2007 23:11:21 +0000 (23:11 +0000)]
r23579: Up to now, the "allparameters" argument to lp_next_parameter was
not effective for the global section (snum < 0). This checkin
makes it effective for the global section, too.

This does not produce changes in the results of the present calls of
lp_next_parameter: Beside the new use in utils/net_conf.c (which is
hereby fixed), the only calls of lp_next_parameter are in web/swat.c,
where it is effectively always called with allparameters == 1.

Michael

14 years agor23578: When calling DeleteKey for a key that has subkey(s), Windows
Michael Adam [Thu, 21 Jun 2007 22:18:42 +0000 (22:18 +0000)]
r23578: When calling DeleteKey for a key that has subkey(s), Windows
returns WERR_ACCESS_DENIED. This adapts reg_deletekey to behave
the same way.

Michael

14 years agor23577: Fix winbindd (sorry). Ensure I set the new child_pid
Jeremy Allison [Thu, 21 Jun 2007 22:10:41 +0000 (22:10 +0000)]
r23577: Fix winbindd (sorry). Ensure I set the new child_pid
variable at the correct point just before the write
call is scheduled.
Jeremy.

14 years agor23576: Fix some confusion between HAVE_BROKEN_GETGROUPS and USE_BSD_SETGROUPS.
James Peach [Thu, 21 Jun 2007 21:17:06 +0000 (21:17 +0000)]
r23576: Fix some confusion between HAVE_BROKEN_GETGROUPS and USE_BSD_SETGROUPS.

14 years agor23575: Fix a segfault when lp_load is called before init_registry.
Michael Adam [Thu, 21 Jun 2007 20:56:56 +0000 (20:56 +0000)]
r23575: Fix a segfault when lp_load is called before init_registry.

Michael

14 years agor23574: Remove double-null check (I hate people bitching at me
Jeremy Allison [Thu, 21 Jun 2007 19:40:51 +0000 (19:40 +0000)]
r23574: Remove double-null check (I hate people bitching at me
on the lists :-).
Jeremy.

14 years agor23573: Cope with terminating winbindd children on read/write/timeout
Jeremy Allison [Thu, 21 Jun 2007 18:44:14 +0000 (18:44 +0000)]
r23573: Cope with terminating winbindd children on read/write/timeout
communication failures. Set timeout to 5 mins. Ensure that
we're terminating the correct child (the one we thought we
were talking to). Still setting up my testing environment
but I have high hopes for this being the fix for the 3.0.25b
showstopper.
Jeremy.

14 years agor23572: Ensure we obey Unicode consortium restrictions. Code
Jeremy Allison [Thu, 21 Jun 2007 17:25:13 +0000 (17:25 +0000)]
r23572: Ensure we obey Unicode consortium restrictions. Code
based on patch from MORIYAMA Masayuki <moriyama@miraclelinux.com>.
Jeremy.

14 years agor23571: Fix, parsing of multi byte share names.
Simo Sorce [Thu, 21 Jun 2007 17:05:59 +0000 (17:05 +0000)]
r23571: Fix, parsing of multi byte share names.
Thanks to SATOH Fumiyasu
Fixes 4720

Jerry,
this is a showstopper for 3.0.25b, please grab it into
SAMBA_3_0_RELEASE before cuting the tarballs.

Simo.

14 years agor23569: Also dump fd_event in dump_event_list().
Günther Deschner [Thu, 21 Jun 2007 15:12:51 +0000 (15:12 +0000)]
r23569: Also dump fd_event in dump_event_list().

Guenther

14 years agor23568: Remove last traces of Heimdal KCM support (and don't misuse wbinfo where a
Günther Deschner [Thu, 21 Jun 2007 14:32:09 +0000 (14:32 +0000)]
r23568: Remove last traces of Heimdal KCM support (and don't misuse wbinfo where a
torture test would be much more appropriate). Fix #4408.

Guenther

14 years agor23567: Fix bug 4721
Volker Lendecke [Thu, 21 Jun 2007 14:30:40 +0000 (14:30 +0000)]
r23567: Fix bug 4721

14 years agor23566: Fix the sys_bsd_setgroups function. The actual workaround was inactive.
Michael Adam [Thu, 21 Jun 2007 14:23:06 +0000 (14:23 +0000)]
r23566: Fix the sys_bsd_setgroups function. The actual workaround was inactive.

Michael

14 years agor23565: Avoid double NULL pointer checks.
Günther Deschner [Thu, 21 Jun 2007 14:04:55 +0000 (14:04 +0000)]
r23565: Avoid double NULL pointer checks.

Guenther

14 years agor23564: Handle MSG_DUMP_EVENT_LIST only in winbindd for now.
Günther Deschner [Thu, 21 Jun 2007 13:05:56 +0000 (13:05 +0000)]
r23564: Handle MSG_DUMP_EVENT_LIST only in winbindd for now.

Guenther

14 years agor23563: Add dump-event-list command to smbcontrol.
Günther Deschner [Thu, 21 Jun 2007 13:04:28 +0000 (13:04 +0000)]
r23563: Add dump-event-list command to smbcontrol.

Guenther

14 years agor23562: Add dump_event_list() for debugging the event list.
Günther Deschner [Thu, 21 Jun 2007 13:03:27 +0000 (13:03 +0000)]
r23562: Add dump_event_list() for debugging the event list.

Guenther

14 years agor23556: Fix for error path from Atsushi Nakabayashi <nakabayashi@miraclelinux.com>.
Jeremy Allison [Wed, 20 Jun 2007 23:24:18 +0000 (23:24 +0000)]
r23556: Fix for error path from Atsushi Nakabayashi <nakabayashi@miraclelinux.com>.
Jeremy.

14 years agor23555: Fix some uninitialiazed variable uses.
Jeremy Allison [Wed, 20 Jun 2007 18:05:48 +0000 (18:05 +0000)]
r23555: Fix some uninitialiazed variable uses.
Jeremy

14 years agor23554: Fix bug #4711 by makeing cli_connect return an NTSTATUS.
Jeremy Allison [Wed, 20 Jun 2007 17:38:42 +0000 (17:38 +0000)]
r23554: Fix bug #4711 by makeing cli_connect return an NTSTATUS.
Long overdue fix....
Jeremy.

14 years agor23553: Also ignore "lock directory" in registry global options.
Michael Adam [Wed, 20 Jun 2007 10:08:31 +0000 (10:08 +0000)]
r23553: Also ignore "lock directory" in registry global options.

Michael

14 years agor23552: Use proper comparison function an fix logic.
Michael Adam [Wed, 20 Jun 2007 08:47:13 +0000 (08:47 +0000)]
r23552: Use proper comparison function an fix logic.

Michael

14 years agor23550: Add more UNIX error -> NT status mappings.
Jeremy Allison [Wed, 20 Jun 2007 01:26:18 +0000 (01:26 +0000)]
r23550: Add more UNIX error -> NT status mappings.
Jeremy.

14 years agor23549: Make "net conf setparm" always use registry data type "sz".
Michael Adam [Tue, 19 Jun 2007 21:40:27 +0000 (21:40 +0000)]
r23549: Make "net conf setparm" always use registry data type "sz".
This simplifies the usage of this command from
"net conf setparm <section> <param> <type> <value>"
to
"net conf setparm <section> <param> <value>".

Micheal

14 years agor23548: Fix comments.
Michael Adam [Tue, 19 Jun 2007 21:08:46 +0000 (21:08 +0000)]
r23548: Fix comments.

Michael

14 years agor23547: Ignore parameter "include" in regsitry globals.
Michael Adam [Tue, 19 Jun 2007 21:06:31 +0000 (21:06 +0000)]
r23547: Ignore parameter "include" in regsitry globals.

Michael

14 years agor23543: Adjust comments.
Michael Adam [Tue, 19 Jun 2007 11:11:01 +0000 (11:11 +0000)]
r23543: Adjust comments.

14 years agor23541: Linking the LSA pipe module only once is probably enough.
James Peach [Mon, 18 Jun 2007 16:10:00 +0000 (16:10 +0000)]
r23541: Linking the LSA pipe module only once is probably enough.

14 years agor23539: Remove code duplication and unify behaviour of winbind_nss_*.h files
Kai Blin [Mon, 18 Jun 2007 13:59:09 +0000 (13:59 +0000)]
r23539: Remove code duplication and unify behaviour of winbind_nss_*.h files

14 years agor23538: Fix for wild-card rename: We can't return directly on error, we need to
Volker Lendecke [Mon, 18 Jun 2007 12:22:42 +0000 (12:22 +0000)]
r23538: Fix for wild-card rename: We can't return directly on error, we need to
CloseDir.

14 years agor23537: Revert the inbuf/outbuf part of r23528: This caused the Solaris CC make test
Volker Lendecke [Mon, 18 Jun 2007 09:25:31 +0000 (09:25 +0000)]
r23537: Revert the inbuf/outbuf part of r23528: This caused the Solaris CC make test
to break. The Solaris CC put the static char InBuffer[TOTAL_BUFFER_SIZE] on an
odd address, the malloc'ed one is always aligned. The problem showed up in
pull_ucs2, ucs2_align uses the address of InBuffer as an indication whether to
bump up the src of the string by one. Unfortunately in the trans calls the
data portion is malloced and thus has different alignment guarantees than a
static variable. This one is bigger....

Volker

14 years agor23536: Fix a typo. James: Please check!
Michael Adam [Sun, 17 Jun 2007 23:13:32 +0000 (23:13 +0000)]
r23536: Fix a typo. James: Please check!

Michael

14 years agor23530: Fix bugs #4678 and #4697 which had the same root cause.
Jeremy Allison [Sun, 17 Jun 2007 19:23:32 +0000 (19:23 +0000)]
r23530: Fix bugs #4678 and #4697 which had the same root cause.
In make_server_info_pw() we assign a user SID in our
authoritative SAM, even though this may be from a
pure "Unix User" that doesn't exist in the SAM.
This causes lookups on "[in]valid users" to fail as they
will lookup this name as a "Unix User" SID to check against
the user token. Fix this by adding the "Unix User"\unix_username
SID to the sid array. The correct fix should probably be
changing the server_info->sam_account user SID to be a
S-1-22 Unix SID, but this might break old configs where
plaintext passwords were used with no SAM backend.
Jeremy

14 years agor23528: Two changes to make the valgrind massif (heap profiler) output readable:
Volker Lendecke [Sun, 17 Jun 2007 05:19:30 +0000 (05:19 +0000)]
r23528: Two changes to make the valgrind massif (heap profiler) output readable:

Remove the allocated inbuf/output. In async I/O we copy the buffers
explicitly now, so NewInBuffer is called exactly once. This does not
reduce memory footprint, but removes one of the larger chunks that
clobber the rest of the massif output

In getgroups_unix_user on Linux 2.6 we allocated 64k groups x 4 bytes
per group x 2 (once in the routine itself and once in libc) = 512k just
to throw it away directly again. This reduces it do a more typical limit
of 32 groups per user. We certainly cope with overflow fine if 32 is not
enough. Not 100% sure about this one, a DEVELOPER only thing?

14 years agor23527: Use existing escaping function pointed by James
Simo Sorce [Sat, 16 Jun 2007 22:52:51 +0000 (22:52 +0000)]
r23527: Use existing escaping function pointed by James

14 years agor23525: I believe this patch is ok, got no reply of it being not ok.
Simo Sorce [Sat, 16 Jun 2007 18:59:02 +0000 (18:59 +0000)]
r23525: I believe this patch is ok, got no reply of it being not ok.
This closes #4624 for me.

14 years agor23524: Fix bug 2319.
Simo Sorce [Sat, 16 Jun 2007 18:54:13 +0000 (18:54 +0000)]
r23524: Fix bug 2319.
Got report this is all ok form a tester. Close a loong
standing bug preventing people to freely use any character
in their password when printing via cups were involved.

14 years agor23523: Gaa -- had renamed "name" to "path" and apparently not compiled after
Volker Lendecke [Sat, 16 Jun 2007 18:19:42 +0000 (18:19 +0000)]
r23523: Gaa -- had renamed "name" to "path" and apparently not compiled after
that....

Volker

14 years agor23522: Save us a kilobyte stack space in a hot code path: I can't see a reason
Volker Lendecke [Sat, 16 Jun 2007 18:07:44 +0000 (18:07 +0000)]
r23522: Save us a kilobyte stack space in a hot code path: I can't see a reason
why check_path_syntax should not be able to run in-line. The destination
pointer either walks side by side with the source pointer or is
decremented. So as far as I can see s>=d is true throughout the whole
routine.

Jeremy, I'm checking this only into 3_0 for now. Please review and ack
or directly merge this to 3_0_26.

Thanks,

Volker

14 years agor23518: Remove the silly assumption that string_replace requires a pstring.
Volker Lendecke [Sat, 16 Jun 2007 11:48:11 +0000 (11:48 +0000)]
r23518: Remove the silly assumption that string_replace requires a pstring.

Jeremy, I am always very confused about the different length arguments
in convert_string and friends. Can you take a look at the change in
string_replace and verify it's ok? Thanks!

While at it, remove the pstring limit for strhasupper and strhaslower.

14 years agor23517: After Jeremy has given is ack on irc:
Volker Lendecke [Sat, 16 Jun 2007 10:02:51 +0000 (10:02 +0000)]
r23517: After Jeremy has given is ack on irc:

Change rename_internals to open the file/directory and then call
rename_internals_fsp. Two reasons: Remove code duplication and remove a
race condition. The race condition was due to the fact that in
can_rename the share mode check closed the file and then after that did
the rename.

14 years agor23516: Fix bug found & fixed by Doug Rudoff (doug_rudoff@isilon.com)
Jeremy Allison [Sat, 16 Jun 2007 01:04:22 +0000 (01:04 +0000)]
r23516: Fix bug found & fixed by Doug Rudoff (doug_rudoff@isilon.com)
- when cleaning up invalid locks make sure we mark the lck
struct as modified so it'll get saved back correctly (that
was the original intent).
Jeremy.

14 years agor23515: Ensure status isn't used uninitialized.
Jeremy Allison [Sat, 16 Jun 2007 00:54:58 +0000 (00:54 +0000)]
r23515: Ensure status isn't used uninitialized.
Jeremy.

14 years agor23514: Remove unused function ads_get_dn_from_extended_dn().
Jeremy Allison [Sat, 16 Jun 2007 00:39:52 +0000 (00:39 +0000)]
r23514: Remove unused function ads_get_dn_from_extended_dn().
Jeremy.

14 years agor23513: Fix one more use of VALUE_PREFIX.
Jeremy Allison [Fri, 15 Jun 2007 23:52:01 +0000 (23:52 +0000)]
r23513: Fix one more use of VALUE_PREFIX.
Jeremy.

14 years agor23512: Fix conflict in #define for SECDESC_PREFIX. Ensure all
Jeremy Allison [Fri, 15 Jun 2007 23:47:40 +0000 (23:47 +0000)]
r23512: Fix conflict in #define for SECDESC_PREFIX. Ensure all
reg #defines use "REG_" prefix. Michael - please check
gcc warnings on compiles.
Jeremy.