ira/wip.git
16 years agor25533: remove a pstring
Volker Lendecke [Fri, 5 Oct 2007 21:28:54 +0000 (21:28 +0000)]
r25533: remove a pstring
(This used to be commit 0f2552e20fb66b0b80006a8a7b999ccf6f54c656)

16 years agor25528: Only do transactions on registry.tdb if anything changes
Volker Lendecke [Fri, 5 Oct 2007 20:42:14 +0000 (20:42 +0000)]
r25528: Only do transactions on registry.tdb if anything changes

I got annoyed by the fsync calls clobbering my harddrive when smbd started up
for debugging.

... things you do on a plane without internet
(This used to be commit e0927a7cbf4b806bcc93ad4af9552bc91292e78b)

16 years agor25526: Fix usage output.
Günther Deschner [Fri, 5 Oct 2007 20:08:48 +0000 (20:08 +0000)]
r25526: Fix usage output.

Guenther
(This used to be commit 31a0bf7b8cae3322a379dc147be6493441c2f13d)

16 years agor25525: Add "net rpc registry getsd <keyname>" to display security descriptors.
Günther Deschner [Fri, 5 Oct 2007 20:07:18 +0000 (20:07 +0000)]
r25525: Add "net rpc registry getsd <keyname>" to display security descriptors.

Guenther
(This used to be commit 550ae11ad1243c4c2af68345349c96d38a5e1ef8)

16 years agor25511: Fix sockaddr_in6 detection.
Jeremy Allison [Fri, 5 Oct 2007 02:03:29 +0000 (02:03 +0000)]
r25511: Fix sockaddr_in6 detection.
Jeremy.
(This used to be commit 9fe14b5a78b0a9a9546fa07d184d0f320fb1a7be)

16 years agor25510: Now we're returning the port instead of using a global,
Jeremy Allison [Fri, 5 Oct 2007 01:11:33 +0000 (01:11 +0000)]
r25510: Now we're returning the port instead of using a global,
remember to use ntohs. Hopefully will fix the build farm.
Jeremy.
(This used to be commit 5174acccb589edbfbe4ba633f4178f7200d7d6c4)

16 years agor25508: Reformatting.
Jeremy Allison [Thu, 4 Oct 2007 18:23:22 +0000 (18:23 +0000)]
r25508: Reformatting.
Jeremy.
(This used to be commit b412ba6fb3e526f5cd83e6cabd952ad7c303c346)

16 years agor25507: Fix definition of struct sockaddr_storage if
Jeremy Allison [Thu, 4 Oct 2007 17:35:12 +0000 (17:35 +0000)]
r25507: Fix definition of struct sockaddr_storage if
struct sockaddr_in6 is defined.
Jeremy.
(This used to be commit 4cf17df5caeb2b0220f6a7dd82d5fed5aca56850)

16 years agor25505: Add a replacement (IPv4 only) implementation of getaddrinfo/freeaddrinfo
Jeremy Allison [Thu, 4 Oct 2007 17:20:49 +0000 (17:20 +0000)]
r25505: Add a replacement (IPv4 only) implementation of getaddrinfo/freeaddrinfo
under the 2 clause *BSD license for future use in IPv6 code. Original
code was from PostgreSQL and I've maintained their license even though
I've rewritten large parts of it (I probably should donate this back
to them).
Jeremy.
(This used to be commit 760d993340a966269d71acfb7a6b5e4d3776ac5d)

16 years agor25503: ignore failing WINBIND tests
Stefan Metzmacher [Thu, 4 Oct 2007 14:45:57 +0000 (14:45 +0000)]
r25503: ignore failing WINBIND tests

we should get the them going without ignoring error...

metze
(This used to be commit 3d3881a3d1fb5fe56cd41c80c0bfbf7747843b19)

16 years agor25502: Fix bug 5006
Volker Lendecke [Thu, 4 Oct 2007 13:13:16 +0000 (13:13 +0000)]
r25502: Fix bug 5006

Thanks to Joerg.Bernau at web.de
(This used to be commit 492977016fa66ce0e98a5bdd1c0f00eacdf13f0c)

16 years agor25499: Fix rpc_file_list_internals
Volker Lendecke [Thu, 4 Oct 2007 00:10:54 +0000 (00:10 +0000)]
r25499: Fix rpc_file_list_internals
(This used to be commit da5736f2103be2229cc3d4421c68f33b3242fa6d)

16 years agor25498: Remove checks that are always true.
Jelmer Vernooij [Wed, 3 Oct 2007 22:23:37 +0000 (22:23 +0000)]
r25498: Remove checks that are always true.
(This used to be commit 2f2bdfa0df758104a9a2fcafe49d6215d8753536)

16 years agor25495: Fixup definitions for missing sockaddr_storage.
Jeremy Allison [Wed, 3 Oct 2007 22:01:25 +0000 (22:01 +0000)]
r25495: Fixup definitions for missing sockaddr_storage.
Jeremy.
(This used to be commit d980ee5040f2ab9e7408218d13962dd64e2b33b1)

16 years agor25494: Sanity check --with-samba4srcdir argument.
Jelmer Vernooij [Wed, 3 Oct 2007 21:14:20 +0000 (21:14 +0000)]
r25494: Sanity check --with-samba4srcdir argument.
(This used to be commit d05bf1fbeeb5504d3b372b03db1ab5fd535f7b2e)

16 years agor25493: Fix typo in Jeremy's thread-safe winbind patch:
Jim McDonough [Wed, 3 Oct 2007 20:56:29 +0000 (20:56 +0000)]
r25493: Fix typo in Jeremy's thread-safe winbind patch:
lock->unlock (would have tried to lock a mutex
at the end of a function).  Cut-n-paste error.
(This used to be commit 281c6191547c352a51d73920c7a31d9236b37351)

16 years agor25492: Start adding IPv6 compatible code to lib/util_sock.c and deal with
Jeremy Allison [Wed, 3 Oct 2007 20:43:55 +0000 (20:43 +0000)]
r25492: Start adding IPv6 compatible code to lib/util_sock.c and deal with
the ripple effects this causes. utmp has to change etc. Remove some
global varables and store address/port in the unexpected db.
Jeremy.
(This used to be commit 18c6a2211d9e25233d01715b3f78977edcd6d869)

16 years agor25487: Try fix the build - fix socklen_t and sa_family_t.
Jeremy Allison [Wed, 3 Oct 2007 19:12:39 +0000 (19:12 +0000)]
r25487: Try fix the build - fix socklen_t and sa_family_t.
Jeremy.
(This used to be commit 2cab82563409eca79ac5f518a3dcb8cdbdcded7e)

16 years agor25484: Fix srvsrc_NetFileEnum listing only for one user
Volker Lendecke [Wed, 3 Oct 2007 18:37:57 +0000 (18:37 +0000)]
r25484: Fix srvsrc_NetFileEnum listing only for one user
(This used to be commit 9e1f513916d8836914580806580c4f8c38e5f2be)

16 years agor25482: Slightly simplify logic
Volker Lendecke [Wed, 3 Oct 2007 13:13:02 +0000 (13:13 +0000)]
r25482: Slightly simplify logic

Instead of one big if-branch for if (process_exists(..)) return if
(!process_exists(..))
(This used to be commit 3acc00132c97b36e026162ae11a23953269dfbed)

16 years agor25481: Fix some typos, don't panic as non-root on net getdomainsid
Volker Lendecke [Wed, 3 Oct 2007 12:55:45 +0000 (12:55 +0000)]
r25481: Fix some typos, don't panic as non-root on net getdomainsid

Thanks to Karolin Seeger <ks@sernet.de>
(This used to be commit 5ae4b2739853e2cd91e839909eb868dbb56be431)

16 years agor25480: Fix a segfault
Volker Lendecke [Wed, 3 Oct 2007 12:51:36 +0000 (12:51 +0000)]
r25480: Fix a segfault
(This used to be commit 7e72a3046d5c318247d1e69b51bcb74e897e3eae)

16 years agor25476: Finally fix up new interface detection code :-).
Jeremy Allison [Tue, 2 Oct 2007 21:12:01 +0000 (21:12 +0000)]
r25476: Finally fix up new interface detection code :-).
Jeremy.
(This used to be commit fffdad52859b5a8bc5dd61912d80b93e8c030c8f)

16 years agor25475: Fix braindead mistakes I made pointed out by Simo and
Jeremy Allison [Tue, 2 Oct 2007 20:39:41 +0000 (20:39 +0000)]
r25475: Fix braindead mistakes I made pointed out by Simo and
James (how did this compile ? :-).
Jeremy.
(This used to be commit ae8efc60aa1ddff795d16b1fb1bfe8cc392f49b3)

16 years agor25474: Try and fix the build on Mac OS X 10.4.9.
Jeremy Allison [Tue, 2 Oct 2007 20:04:14 +0000 (20:04 +0000)]
r25474: Try and fix the build on Mac OS X 10.4.9.
Shuffle sa_family_t around.
Jeremy.
(This used to be commit f1b8c5de0ae96e04e340029f5cd544de9ac57b32)

16 years agor25473: Reformatting only. Prepare for new ip functions.
Jeremy Allison [Tue, 2 Oct 2007 19:50:53 +0000 (19:50 +0000)]
r25473: Reformatting only. Prepare for new ip functions.
Jeremy.
(This used to be commit 2a8f3dd55074eeb3d96a1b478981780651bbe88b)

16 years agor25472: Fix the interfaces code to detect IPv6 interfaces, using the
Jeremy Allison [Tue, 2 Oct 2007 19:27:25 +0000 (19:27 +0000)]
r25472: Fix the interfaces code to detect IPv6 interfaces, using the
new standard getifaddrs() and freeifaddrs() interfaces. Currently
we only return IPv4 af_families. Needs fixing for binds to IPv6
but this has to be careful work.
Jeremy.
(This used to be commit 327875182c9219aeba687e10aaea93546d9a70ea)

16 years agor25470: use --immediate like in samba4 to get more usefull output
Stefan Metzmacher [Tue, 2 Oct 2007 16:13:30 +0000 (16:13 +0000)]
r25470: use --immediate like in samba4 to get more usefull output

metze
(This used to be commit f5b089370a4a8e23d656276d06febb041729743d)

16 years agor25455: Ensure we have inet_ntop and inet_pton available in lib/replace.
Jeremy Allison [Mon, 1 Oct 2007 23:18:26 +0000 (23:18 +0000)]
r25455: Ensure we have inet_ntop and inet_pton available in lib/replace.
Jeremy.
(This used to be commit 1f719905440d4c87c526c56532f47d894cfec5f0)

16 years agor25445: Fix IPV6 detection.
Jeremy Allison [Mon, 1 Oct 2007 18:30:01 +0000 (18:30 +0000)]
r25445: Fix IPV6 detection.
Jeremy.
(This used to be commit ab2e190859f2cc64c989f0d10195bfff3db12651)

16 years agor25441: Make wbinfo --sequence output the sequence number if --domain
Michael Adam [Mon, 1 Oct 2007 15:35:05 +0000 (15:35 +0000)]
r25441: Make wbinfo --sequence output the sequence number if --domain
is specified.

Michael
(This used to be commit b0f59f18bc8e95a98ee44fcc751f3af4e96d5924)

16 years agor25434: Add the option to print the debug class (DBGC_CLASS) in the debug header.
Michael Adam [Sun, 30 Sep 2007 08:07:06 +0000 (08:07 +0000)]
r25434: Add the option to print the debug class (DBGC_CLASS) in the debug header.
Control this by a new boolean smb.conf option "debug class" which is
by default set to "no" to keep the default debug header unchanged.

Michael

Note: You need to make clean for this patch.
(This used to be commit 066a46ba91ca734d9e20cb9d6db36fec209a27d7)

16 years agor25432: Merge module linking changes from SAMBA_3_2 to SAMBA_3_2_0 to reduce
James Peach [Sat, 29 Sep 2007 23:54:32 +0000 (23:54 +0000)]
r25432: Merge module linking changes from SAMBA_3_2 to SAMBA_3_2_0 to reduce
spurious tree differences.
(This used to be commit ee1eba2855c7ee2d60ba7d354e6731da78cbd48e)

16 years agor25431: Add detection for IPv6 support.
Jeremy Allison [Sat, 29 Sep 2007 23:43:24 +0000 (23:43 +0000)]
r25431: Add detection for IPv6 support.
Jeremy.
(This used to be commit 86b47d267d0eda4b972f1087be069ae5afda834e)

16 years agor25429: Samba 3 doesn't need to selftest Samba4 code...
Stefan Metzmacher [Sat, 29 Sep 2007 15:17:49 +0000 (15:17 +0000)]
r25429: Samba 3 doesn't need to selftest Samba4 code...

metze
(This used to be commit fef2ed213035607fa2b9d987c3efc3cc48b04790)

16 years agor25426: Fix another implicit cast warning.
Michael Adam [Sat, 29 Sep 2007 08:25:44 +0000 (08:25 +0000)]
r25426: Fix another implicit cast warning.

Michael
(This used to be commit 4a053d5bf9db82b5ae9ac342f68e90ef89ba292f)

16 years agor25424: Align log level (by two) in debugging output.
Michael Adam [Sat, 29 Sep 2007 07:18:23 +0000 (07:18 +0000)]
r25424: Align log level (by two) in debugging output.

Michael
(This used to be commit 9265b3cde25208884a8d3a9c42461d1c6e6fc353)

16 years agor25422: Get rid of some cast warnings.
Michael Adam [Sat, 29 Sep 2007 06:44:39 +0000 (06:44 +0000)]
r25422: Get rid of some cast warnings.
(This used to be commit 3e155b249e03cc9f7bd0cbf3a3ab8a57536bf0ce)

16 years agor25418: fix generation of git revision calculation
Stefan Metzmacher [Fri, 28 Sep 2007 23:39:32 +0000 (23:39 +0000)]
r25418: fix generation of git revision calculation

metze
(This used to be commit 43df4928ecd61ae071109abb1c72dfd1b78a5a5e)

16 years agor25417: Use DBGC_REGISTRY class.
Günther Deschner [Fri, 28 Sep 2007 23:05:52 +0000 (23:05 +0000)]
r25417: Use DBGC_REGISTRY class.

Guenther
(This used to be commit 43ca04918a5a1b2379083dc624b346ceb8476a38)

16 years agor25416: Add registry debug class.
Günther Deschner [Fri, 28 Sep 2007 23:03:08 +0000 (23:03 +0000)]
r25416: Add registry debug class.

Guenther
(This used to be commit b28dd747cb5a3d0eee865076eb4733dc123a6968)

16 years agor25415: Merge the 3.2-perltest branch that switches Samba 3.2 to use Samba 4's selfte...
Jelmer Vernooij [Fri, 28 Sep 2007 22:16:14 +0000 (22:16 +0000)]
r25415: Merge the 3.2-perltest branch that switches Samba 3.2 to use Samba 4's selftest code. See the mailing list for details.
(This used to be commit bdc831ddb3a860676c36bbd89e6f748946df68a1)

16 years agor25407: Revert Longhorn join patch as it is not correct for the 3.2 tree.
Gerald Carter [Fri, 28 Sep 2007 18:15:34 +0000 (18:15 +0000)]
r25407: Revert Longhorn join patch as it is not correct for the 3.2 tree.

The translate_name() used by cli_session_setup_spnego() cann rely
Winbindd since it is needed by the join process (and hence before
Winbind can be run).
(This used to be commit 00a93ed336c5f36643e6e33bd277608eaf05677c)

16 years agor25406: Make the Linux nss client code thread-safe.
Jeremy Allison [Fri, 28 Sep 2007 18:12:22 +0000 (18:12 +0000)]
r25406: Make the Linux nss client code thread-safe.
Fix originally inspired from code from boyang <yyyeer.bo@gmail.com>.
Jeremy.
(This used to be commit cc19c0ace43a3613f6290fa4bc4f68c964563743)

16 years agor25405: Fix formatting as per metze's comments
Gerald Carter [Fri, 28 Sep 2007 18:09:50 +0000 (18:09 +0000)]
r25405: Fix formatting as per metze's comments
(This used to be commit 45fa393358926117e0209970414678547d8504a6)

16 years agor25402: BUG 4997 (3.2 only): Fix enumration level for smbtree
Gerald Carter [Fri, 28 Sep 2007 04:08:58 +0000 (04:08 +0000)]
r25402: BUG 4997 (3.2 only): Fix enumration level for smbtree
(This used to be commit f387e0f256e3f8a8c4a67f7fcc847a9dabaff8da)

16 years agor25401: BUG 4982: Don't delete lanman hashes on invalid logins when
Gerald Carter [Fri, 28 Sep 2007 03:56:12 +0000 (03:56 +0000)]
r25401: BUG 4982: Don't delete lanman hashes on invalid logins when
using the "lanman auth = no".  Tested by Guenter Kukkukk.
(This used to be commit 611fdd95a583ebd22ffa17e2f39c5a1bb0936c63)

16 years agor25400: Windows 2008 (Longhorn) Interop fixes for AD specific auth2 flags,
Gerald Carter [Fri, 28 Sep 2007 03:54:42 +0000 (03:54 +0000)]
r25400: Windows 2008 (Longhorn) Interop fixes for AD specific auth2 flags,
and client fixes.  Patch from Todd Stetcher <todd.stetcher@isilon.com>.
(This used to be commit 8304ccba7346597425307e260e88647e49081f68)

16 years agor25399: Excise uint - > uint32 (where appropriate) or unsigned int.
Jeremy Allison [Fri, 28 Sep 2007 01:32:08 +0000 (01:32 +0000)]
r25399: Excise uint - > uint32 (where appropriate) or unsigned int.
Jeremy.
(This used to be commit b4ee924000f4a21b16a70e08e58331d209c4d114)

16 years agor25396: Very obvious fix from Martin Zielinski.
Günther Deschner [Fri, 28 Sep 2007 01:02:11 +0000 (01:02 +0000)]
r25396: Very obvious fix from Martin Zielinski.

Guenther
(This used to be commit 1f0d05807b7fe31cc4be59c7a2e850c9ec3e3864)

16 years agor25393: Removed unused variable
Gerald Carter [Thu, 27 Sep 2007 23:33:35 +0000 (23:33 +0000)]
r25393: Removed unused variable
(This used to be commit 11894a62e3a41f3387fac1a578258321333085ac)

16 years agor25391: Fix bug #4978 : Store DOS Attributes fails when copying folders.
Jeremy Allison [Thu, 27 Sep 2007 23:28:35 +0000 (23:28 +0000)]
r25391: Fix bug #4978 : Store DOS Attributes fails when copying folders.
Jeremy.
(This used to be commit 713277391ae7f81f8545723c919865ff8c07ed86)

16 years agor25389: Fix crash bug using DFS info struct uninitialized.
Jeremy Allison [Thu, 27 Sep 2007 22:55:11 +0000 (22:55 +0000)]
r25389: Fix crash bug using DFS info struct uninitialized.
Jeremy.
(This used to be commit 993bd0995eadc134378e691ccd796074dc475741)

16 years agor25380: Remove the groupdb:mapping parameter as discussed in the following thread:
Gerald Carter [Thu, 27 Sep 2007 20:12:40 +0000 (20:12 +0000)]
r25380: Remove the groupdb:mapping parameter as discussed in the following thread:
http://lists.samba.org/archive/samba-technical/2007-June/053747.html
(This used to be commit c5adb92c020e38644baf1afc8fc570a518cd6307)

16 years agor25378: Add a vim configuration example to highlight overly long lines.
Michael Adam [Thu, 27 Sep 2007 19:20:37 +0000 (19:20 +0000)]
r25378: Add a vim configuration example to highlight overly long lines.
(This used to be commit 95b7404836a723334d703825ab6f605ab38efe82)

16 years agor25370: Allow to delete registry keys recursively without deleting the final key.
Günther Deschner [Thu, 27 Sep 2007 01:26:19 +0000 (01:26 +0000)]
r25370: Allow to delete registry keys recursively without deleting the final key.

Guenther
(This used to be commit e9922cd8aeb70aebb162ad598fda76ad69226b94)

16 years agor25362: Add "NT Authority\System" with Full Access to the default registry security
Günther Deschner [Wed, 26 Sep 2007 21:46:43 +0000 (21:46 +0000)]
r25362: Add "NT Authority\System" with Full Access to the default registry security
descriptor.

Guenther
(This used to be commit ddc6d051115577b27529c46ff98267517218fe59)

16 years agor25355: IP address parsing did not allow for fully expanded ipv6 addresses
Steve French [Wed, 26 Sep 2007 18:36:38 +0000 (18:36 +0000)]
r25355: IP address parsing did not allow for fully expanded ipv6 addresses
(which can be 12 bytes longer than we were allowing for).

Thanks to Dr. David Holder
(This used to be commit 0202a84e3f61665953bd5207218063b0d5ff6088)

16 years agor25328: When using ldap sasl wrapping with gssapi it's important to receive warnings
Günther Deschner [Wed, 26 Sep 2007 01:02:52 +0000 (01:02 +0000)]
r25328: When using ldap sasl wrapping with gssapi it's important to receive warnings
for clock-skew errors.

Guenther
(This used to be commit 53c99d415d605ab03e3646f6096aff794457dd33)

16 years agor25327: Normalize the path we return for 'msdfs proxy'
Volker Lendecke [Tue, 25 Sep 2007 23:26:05 +0000 (23:26 +0000)]
r25327: Normalize the path we return for 'msdfs proxy'

We now accept both \\server\tmp and \server\tmp. There are other places
where this might be necessary, but at least the functionality is a bit
easier now.
(This used to be commit 25cc27df97e9eecb470f99ea934de12f2a0f4df9)

16 years agor25326: Free the context from the talloc_stackframe.
Günther Deschner [Tue, 25 Sep 2007 22:43:42 +0000 (22:43 +0000)]
r25326: Free the context from the talloc_stackframe.

Guenther
(This used to be commit 0719835c4d979c91d11b139e5b424b5e0dc2a2c2)

16 years agor25325: Rename some defines.
Günther Deschner [Tue, 25 Sep 2007 21:41:57 +0000 (21:41 +0000)]
r25325: Rename some defines.

Guenther
(This used to be commit cc38e4fc1f2d3f9e2e2ff90a7a004ce8fdfa9238)

16 years agor25324: Fix "msdfs proxy"
Volker Lendecke [Tue, 25 Sep 2007 21:41:39 +0000 (21:41 +0000)]
r25324: Fix "msdfs proxy"

Jeremy, please check!
(This used to be commit d4eddf88d20b09c450d4358d2ef1bc35736501ff)

16 years agor25323: Fix the build
Volker Lendecke [Tue, 25 Sep 2007 21:32:49 +0000 (21:32 +0000)]
r25323: Fix the build
(This used to be commit e55b30ab8417cb36def8e4d8b8f6ba16b4e664c1)

16 years agor25317: Activate raw-samba3rootdirfid
Volker Lendecke [Tue, 25 Sep 2007 16:42:53 +0000 (16:42 +0000)]
r25317: Activate raw-samba3rootdirfid
(This used to be commit 1cbe40b27c8142c53480fc9c4e1b0c9f14446300)

16 years agor25314: Add HKEY_CURRENT_USER to reg_hive_key().
Günther Deschner [Tue, 25 Sep 2007 04:54:20 +0000 (04:54 +0000)]
r25314: Add HKEY_CURRENT_USER to reg_hive_key().

Guenther
(This used to be commit 693b3c26c0643028e861b78068c2bcda0add1105)

16 years agor25313: dd HKEY_CURRENT_USER to rpccli_winreg_Connect().
Günther Deschner [Tue, 25 Sep 2007 04:52:15 +0000 (04:52 +0000)]
r25313: dd HKEY_CURRENT_USER to rpccli_winreg_Connect().

Guenther
(This used to be commit eb311cafbb446abf8e29faf6501cf5b82593a36f)

16 years agor25311: Patch from Heinrich Mislik <Heinrich.Mislik@univie.ac.at> to fix AIX
Volker Lendecke [Mon, 24 Sep 2007 21:43:54 +0000 (21:43 +0000)]
r25311: Patch from Heinrich Mislik <Heinrich.Mislik@univie.ac.at> to fix AIX
quotas.

Heinrich, I trust you on that, I don't even have compiled this :-)

Volker
(This used to be commit a8312a1d7b7e3ad00265279dd0640261beaa287d)

16 years agor25309: Volker's fix for bug #4984 - samba4 torture test
Jeremy Allison [Mon, 24 Sep 2007 19:11:42 +0000 (19:11 +0000)]
r25309: Volker's fix for bug #4984 - samba4 torture test
to follow. Ensure we don't prepend "./" as a root
directory - this is an invalid pathname for unix_convert().
Jeremy.
(This used to be commit f70ac2e25847e41ecf54ae9d66e3247e1996b152)

16 years agor25294: Tidy up callers of unistr2_to_ascii() to pass sizeof(target_area) to
Michael Adam [Fri, 21 Sep 2007 14:37:35 +0000 (14:37 +0000)]
r25294: Tidy up callers of unistr2_to_ascii() to pass sizeof(target_area) to
the maxeln parameter instead of sizeof(target_area) - 1 (or even
sizeof(fstring) - 1 in some places.

I hope these were really all there were.

Michael
(This used to be commit 9a28be220df622322857dfe102fa35e108f932dc)

16 years agor25287: Eliminate a handful of red bars and overly long lines I just
Michael Adam [Fri, 21 Sep 2007 12:24:43 +0000 (12:24 +0000)]
r25287: Eliminate a handful of red bars and overly long lines I just
came across.

Michael
(This used to be commit bf12f0c0f843f088c7fa2d1eca3298a3d76e9761)

16 years agor25286: Fix one more caller of unistr2_to_ascii() that passed
Michael Adam [Fri, 21 Sep 2007 11:58:25 +0000 (11:58 +0000)]
r25286: Fix one more caller of unistr2_to_ascii() that passed
in -1 for maxlen.

Michael
(This used to be commit cd3d652d0d7609fc369ed0743c1fc54c87558438)

16 years agor25285: Fix some more callers of unistr2_to_ascii to use the size of
Michael Adam [Fri, 21 Sep 2007 11:53:14 +0000 (11:53 +0000)]
r25285: Fix some more callers of unistr2_to_ascii to use the size of
destination instead of source as maxlen.

Michael
(This used to be commit 76cb05deec153c1e0003776339da912a0f3d73a9)

16 years agor25281: Fix a caller of unistr2_to_ascii():
Michael Adam [Fri, 21 Sep 2007 10:46:09 +0000 (10:46 +0000)]
r25281: Fix a caller of unistr2_to_ascii():
The maxlen parameter should be set to the size of the
destination, not to the size of the soruce.

Michael
(This used to be commit 841ff0beee7ea44ee92d1f90de3edeb53edcae0a)

16 years agor25277: Belt-and-braces approach to Volker's fix for RPC-SAMBA3-GETUSERNAME.
Jeremy Allison [Fri, 21 Sep 2007 10:32:57 +0000 (10:32 +0000)]
r25277: Belt-and-braces approach to Volker's fix for RPC-SAMBA3-GETUSERNAME.
If we promise dest is null terminated, ensure we do it even on
fast path exits.
Jeremy.
(This used to be commit 32626e2b9770eb6b15c191a8feb881f81ed6c57a)

16 years agor25275: w2k3 (as PDC emulator) returns WERR_NO_SUCH_DOMAIN to netlogon_getanydcname()
Stefan Metzmacher [Fri, 21 Sep 2007 10:25:33 +0000 (10:25 +0000)]
r25275: w2k3 (as PDC emulator) returns WERR_NO_SUCH_DOMAIN to netlogon_getanydcname()
when called for it's own domain. So we should use netlogon_getdcname() which
returns WERR_OK:-)

gd: feel free to usage rpccli_netlogon_dsr_getdcname(), but please make sure
    the new WINBIND-STRUCT-GETDCNAME test is still passing.

metze
(This used to be commit 9a9c164366a252ab8268b687699d54048ced993f)

16 years agor25274: Attempt to fix RPC-SAMBA3-GETUSERNAME
Volker Lendecke [Fri, 21 Sep 2007 10:23:35 +0000 (10:23 +0000)]
r25274: Attempt to fix RPC-SAMBA3-GETUSERNAME
(This used to be commit f6f64cf0b51f2fb841bd1c0f800c66114c213577)

16 years agor25273: unistrX_to_ascii calls pull_ucs2 - ensure it's never
Jeremy Allison [Fri, 21 Sep 2007 09:58:36 +0000 (09:58 +0000)]
r25273: unistrX_to_ascii calls pull_ucs2 - ensure it's never
called with -1 (these calls were wrong anyway, target
was an fstring, not a pstring). Found by  Michael Adam <ma@sernet.de>,
now to check all other uses.
Michael - this version uses sizeof(target) not sizeof(fstring).
This way is more future proof.
Jeremy.
(This used to be commit 9ed3046633b6949c68c9aed61b8e9444601cf101)

16 years agor25272: Fix a bunch of callers of pull_ucs2 that passed -1 for dest_len.
Michael Adam [Fri, 21 Sep 2007 09:52:28 +0000 (09:52 +0000)]
r25272: Fix a bunch of callers of pull_ucs2 that passed -1 for dest_len.

Michael
(This used to be commit a4f53fe22569a63fe7b196971ac6c28a676ee4e8)

16 years agor25270: for internal domains we should not ask a remote DC.
Stefan Metzmacher [Fri, 21 Sep 2007 09:35:53 +0000 (09:35 +0000)]
r25270: for internal domains we should not ask a remote DC.

metze
(This used to be commit 579ed8ae87e449dbd5e4f78609754df0556fbf68)

16 years agor25260: add trusted domains always to the end of the list.
Stefan Metzmacher [Thu, 20 Sep 2007 18:37:34 +0000 (18:37 +0000)]
r25260: add trusted domains always to the end of the list.

Now BUILTIN is always the first domain followed
by the domain of our own SAM DB and the primary
domain (in member server mode).

metze
(This used to be commit b8d67b78aa1c35e4e7e61050c1fccbb6d76d9fd7)

16 years agor25258: Fix a panic message and remove superfluous return after the call to smb_panic().
Michael Adam [Thu, 20 Sep 2007 12:42:15 +0000 (12:42 +0000)]
r25258: Fix a panic message and remove superfluous return after the call to smb_panic().

Michael
(This used to be commit 8b5c34b7d141c44d65622f44f9432723230cea47)

16 years agor25257: When dumping eventlist, display full timestring.
Günther Deschner [Thu, 20 Sep 2007 11:02:27 +0000 (11:02 +0000)]
r25257: When dumping eventlist, display full timestring.

Guenther
(This used to be commit 38eca60913f513accb24b31dcb6d1d7e92b0ba66)

16 years agor25254: Add my C - Michael
Michael Adam [Thu, 20 Sep 2007 09:15:26 +0000 (09:15 +0000)]
r25254: Add my C - Michael
(This used to be commit 3246be8cf05a867b74b4b96697c99cc62f13c2a9)

16 years agor25252: move macro defines to the end of replace.h
Stefan Metzmacher [Thu, 20 Sep 2007 09:12:18 +0000 (09:12 +0000)]
r25252: move macro defines to the end of replace.h
and move the include location sys/param.h
before we redefine missing macros

metze
(This used to be commit 862046028c3c61adf6da2effac91abf3c763635d)

16 years agor25248: According to the build-farm all this defines are not needed
Stefan Metzmacher [Thu, 20 Sep 2007 06:52:30 +0000 (06:52 +0000)]
r25248: According to the build-farm all this defines are not needed
for HPUX large file support.

But it would be nice if someone could verify that.

metze
(This used to be commit b09024928d036933a47e4f1c2e246426fb3792aa)

16 years agor25247: Rename the rpccli_lsa_lookup_sids_all() function to rpccli_lsa_lookup_sids()
Michael Adam [Wed, 19 Sep 2007 22:11:09 +0000 (22:11 +0000)]
r25247: Rename the rpccli_lsa_lookup_sids_all() function to rpccli_lsa_lookup_sids()
and remove the old rpccli_lsa_lookup_sids() function. The old function would
fail due to server limits when requesting to resolve too many sids at once
(20480 for W2k3). The new version passes the list of sids in hunks to the
server. It has up to now been used (and tested) in the winbindd_ads
lookup_groupmem() function, and I think the time has come to replace the actual
function with this correct version.

Michael
(This used to be commit 1194d4f36ef720747e62dde31881c295e44e4a76)

16 years agor25245: rerun 'make idl'
Stefan Metzmacher [Wed, 19 Sep 2007 20:03:43 +0000 (20:03 +0000)]
r25245: rerun 'make idl'

metze
(This used to be commit af91f4fd08aae117d9b48eade4d49762c9634cbc)

16 years agor25244: see what the build-farm says when we only use large file support
Stefan Metzmacher [Wed, 19 Sep 2007 19:45:51 +0000 (19:45 +0000)]
r25244: see what the build-farm says when we only use large file support
detection from libreplace...

It would be good if someone could test that on HPUX...

metze
(This used to be commit 00ea030e67c519ebb69e5932f607b4ac6e834f0e)

16 years agor25241: remove sequence_number out of WINBINDD_DOMAIN_INFO call
Stefan Metzmacher [Wed, 19 Sep 2007 19:05:54 +0000 (19:05 +0000)]
r25241: remove sequence_number out of WINBINDD_DOMAIN_INFO call
as this is always answered by the winbindd parent and will
most times return old sequence number values.

metze
(This used to be commit 9caf54c868e8c0109730860e772c9cc404e2f899)

16 years agor25239: fix cut-n-paste bug in code with LIBUNWIND support
Stefan Metzmacher [Wed, 19 Sep 2007 19:01:20 +0000 (19:01 +0000)]
r25239: fix cut-n-paste bug in code with LIBUNWIND support

metze
(This used to be commit ff94d055760b16786d1a998e251d487fb886a64c)

16 years agor25238: Make the error returns from the string functions
Jeremy Allison [Wed, 19 Sep 2007 17:52:06 +0000 (17:52 +0000)]
r25238: Make the error returns from the string functions
always consistent. Return -1 on error, and ensure
we check for this. In cases where the dest is already
specified and we've been asked to terminate with a
null, ensure we always do so even on error.
Jeremy.
(This used to be commit abedd967869ade9a43c3a8e1b889c60d4aca81cf)

16 years agor25236: make it possible to alter WINBINDD_SOCKET_DIR via
Stefan Metzmacher [Wed, 19 Sep 2007 17:19:57 +0000 (17:19 +0000)]
r25236: make it possible to alter WINBINDD_SOCKET_DIR via
"winbindd:socket dir=/path/to/dir" for usage in make test

metze
(This used to be commit 5566cf01e827edf60c0235a661d95dd376210108)

16 years agor25232: sync lib/replace with SAMBA_4_0
Stefan Metzmacher [Wed, 19 Sep 2007 14:57:20 +0000 (14:57 +0000)]
r25232: sync lib/replace with SAMBA_4_0

metze
(This used to be commit 828d2ca0610ab5ee3b96d187b3432b9b4fea72f8)

16 years agor25230: sync lib/talloc with SAMBA_4_0
Stefan Metzmacher [Wed, 19 Sep 2007 14:44:16 +0000 (14:44 +0000)]
r25230: sync lib/talloc with SAMBA_4_0

metze
(This used to be commit 84ebb6cac224cabf3856a632de80a8a9c687329b)

16 years agor25227: Patch from "Steven Danneman" <steven.danneman@isilon.com>:
Stefan Metzmacher [Wed, 19 Sep 2007 14:33:32 +0000 (14:33 +0000)]
r25227: Patch from "Steven Danneman" <steven.danneman@isilon.com>:

-
We ran across a bug joining our Samba server to a Win2K domain with LDAP
signing turned on.  Upon investigation I discovered that there is a bug
in Win2K server which returns a duplicated responseToken in the LDAP
bindResponse packet.  This blob is placed in the optional mechListMIC
field which is unsupported in both Win2K and Win2K3.  You can see RFC
2478 for the proper packet construction.  I've worked with metze on this
to confirm all these finding.

This patch properly parses then discards the mechListMIC field if it
exists in the packet, so we don't produce a malformed packet error,
causing LDAP signed joins to fail.  Also attached is a sniff of the
domain join, exposing Win2Ks bad behavior (packet 21).
-

(I've just changed the scope of the DATA_BLOB mechList)

metze
(This used to be commit 200b5bfb8180af09446762e915eac63d14c6c7b0)

16 years agor25226: Get rid of more red bars...
Michael Adam [Wed, 19 Sep 2007 12:45:35 +0000 (12:45 +0000)]
r25226: Get rid of more red bars...
(This used to be commit aa603bcc6c848de67ea07d6028ab841a8401d9ad)

16 years agor25225: Add a debug message.
Michael Adam [Wed, 19 Sep 2007 12:05:47 +0000 (12:05 +0000)]
r25225: Add a debug message.

Michael
(This used to be commit 7238884c2cb25dd9279703004ffab6618715a275)

16 years agor25224: Fix a potential segfault in lsa_lookupsids client code due to
Michael Adam [Wed, 19 Sep 2007 12:03:02 +0000 (12:03 +0000)]
r25224: Fix a potential segfault in lsa_lookupsids client code due to
uninitialized data.

Michael
(This used to be commit b4fff6d09d17a18eae61e8ca789f128cd094ba09)

16 years agor25223: Fix behaviour of rpccli_lsa_lookupsids_all() when
Michael Adam [Wed, 19 Sep 2007 11:01:44 +0000 (11:01 +0000)]
r25223: Fix behaviour of rpccli_lsa_lookupsids_all() when
rpccli_lsa_lookupsids_noalloc() returns an error for one hunk
of SIDs: free all allocated arrays and return the error code
returned by the hunk lookup.

Michael
(This used to be commit 2c68ebd6934206186dc6e635401f66c2fd1e1234)