13 years agor4525: fix Fedora specfile to include pam_winbind(8) man page
Gerald Carter [Wed, 5 Jan 2005 01:54:58 +0000 (01:54 +0000)]
r4525: fix Fedora specfile to include pam_winbind(8) man page
(This used to be commit 0d8306c621a0fe96cf0fc3230062e7ee398302eb)

13 years agor4514: Fix for bugzilla 1770. Remove READ_ATTRIBUTES from GENERIC_EXECUTE, otherwise
Jim McDonough [Tue, 4 Jan 2005 20:02:56 +0000 (20:02 +0000)]
r4514: Fix for bugzilla 1770.  Remove READ_ATTRIBUTES from GENERIC_EXECUTE, otherwise
modification of an ACL that contains an ACE with execute only will cause
that to be upgraded to read/execute.  Side effect is that dirs/files with
execute only show up as special permissions, which is still correct.
(This used to be commit 8d9dc7d543fd347e47d04157064a2f92fb5c99db)

13 years agor4370: Don't assume the compiler supports declarations after statements.
Jelmer Vernooij [Sun, 26 Dec 2004 21:06:43 +0000 (21:06 +0000)]
r4370: Don't assume the compiler supports declarations after statements.
(This used to be commit 7fa2caec5ec2de4c5e7359621745a65ca9df255c)

13 years agor4369: Patch for bug #2190 (SWAT displaying parameters in UNIX charset)
Jeremy Allison [Sun, 26 Dec 2004 18:51:49 +0000 (18:51 +0000)]
r4369: Patch for bug #2190 (SWAT displaying parameters in UNIX charset)
not utf8. Fixed by Shiro Yamada <>.
(This used to be commit 8de04888097b3e125845340ba1a9a1bb79892e22)

13 years agor4353: Finally get length of munged_dial correct.
Günther Deschner [Fri, 24 Dec 2004 00:56:30 +0000 (00:56 +0000)]
r4353: Finally get length of munged_dial correct.

(This used to be commit b209f97f246cd65719f1000c7de368babec26d47)

13 years agor4352: Base64-encode munged-dial with correct length in 'net rpc vampire'.
Günther Deschner [Fri, 24 Dec 2004 00:38:22 +0000 (00:38 +0000)]
r4352: Base64-encode munged-dial with correct length in 'net rpc vampire'.

(This used to be commit 98f3e3353df988e819bc41d145b13c76e1b86b55)

13 years agor4351: Vampire Logon-Hours. Update Logon-Hours only when they have changed.
Günther Deschner [Fri, 24 Dec 2004 00:08:15 +0000 (00:08 +0000)]
r4351: Vampire Logon-Hours. Update Logon-Hours only when they have changed.

(This used to be commit 0930ad662770278cbe9fd4e3deaa523957b96697)

13 years agor4350: bumping version to 3.0.11pre2
Gerald Carter [Thu, 23 Dec 2004 22:03:29 +0000 (22:03 +0000)]
r4350: bumping version to 3.0.11pre2
(This used to be commit 8675b41d336df3030deeda45f1379835002f883c)

13 years agor4346: Fix cut-and-paste error - bugid #2189. Fixed by Buck Huppmann <buckh@pobox...
Jeremy Allison [Thu, 23 Dec 2004 18:40:50 +0000 (18:40 +0000)]
r4346: Fix cut-and-paste error - bugid #2189. Fixed by Buck Huppmann <>
(This used to be commit 5c22cb082c86088add0db21541a8079c516c9fd9)

13 years agor4343: forgot to add info-level 8 to SAMR_UNKNOWN_2E as well.
Günther Deschner [Thu, 23 Dec 2004 09:36:49 +0000 (09:36 +0000)]
r4343: forgot to add info-level 8 to SAMR_UNKNOWN_2E as well.

(This used to be commit 5e6ce9a6e3d62190da5427ed7b5e2f2ac22a0c34)

13 years agor4337: Produce a slightly different error message is lanman authentication is
Andrew Bartlett [Thu, 23 Dec 2004 02:16:57 +0000 (02:16 +0000)]
r4337: Produce a slightly different error message is lanman authentication is
disabled, rather than simply unavailable.

Andrew Bartlett
(This used to be commit 1c70583a19c9f741a41d08c0b994fccb66eeb0bf)

13 years agor4336: Apply some other samba4 SAMR idl that is just too obvious. Don't hard
Günther Deschner [Wed, 22 Dec 2004 23:50:31 +0000 (23:50 +0000)]
r4336: Apply some other samba4 SAMR idl that is just too obvious. Don't hard
set the value "forcibly disconnect remote users from server when logon
hours expire" to "no", instead take the value from our account-policy

(This used to be commit e3bd2a22a5cebc4adf6910d3ec31bc6fada8cd35)

13 years agor4334: Fix for bugid #2186 - from Buck Huppmann <>
Jeremy Allison [Wed, 22 Dec 2004 22:07:04 +0000 (22:07 +0000)]
r4334: Fix for bugid #2186 - from Buck Huppmann <>
to prevent uninitialized creds being freed.
(This used to be commit c3f9c81a8fcb26f7110f75b3096d5d1eb30aac13)

13 years agor4331: Implement SAMR query_dom_info-call info-level 8 server- and client-side,
Günther Deschner [Wed, 22 Dec 2004 16:58:43 +0000 (16:58 +0000)]
r4331: Implement SAMR query_dom_info-call info-level 8 server- and client-side,
based on samba4-idl.

This saves us an enormous amount of totally unnecessary ldap-traffic
when several hundreds of winbind-daemons query a Samba3 DC just to get
the fake SAM-sequence-number (time(NULL)) by enumerating all users, all
groups and all aliases when query-dom-info level 2 is used.

Note that we apparently never get the sequence number right (we parse a
uint32, although it's a uint64, at least in samba4 idl). For the time
being, I would propose to stay with that behaviour.

(This used to be commit f9ab15a986626581000d4b93961184c501f36b93)

13 years agor4330: Fix for bug found by Rob Foehl <>. Remember to
Jeremy Allison [Tue, 21 Dec 2004 23:14:20 +0000 (23:14 +0000)]
r4330: Fix for bug found by Rob Foehl <>. Remember to
add in the bcc length for readX on named pipes.
(This used to be commit 1168395e6a543c51f684280b00fb8c9b8bbc6ec0)

13 years agor4312: Marking "min password length" as depreciated (to be removed in one of
Günther Deschner [Tue, 21 Dec 2004 11:10:28 +0000 (11:10 +0000)]
r4312: Marking "min password length" as depreciated (to be removed in one of
the next releases). The corresponding functionality is better handled
with the account policy. See for details.

(This used to be commit 61204a267c3b1b024ba6cb2340317301210b4d90)

13 years agor4311: 'Document' the -L switch when adding groups with "net rpc group".
Günther Deschner [Tue, 21 Dec 2004 10:26:59 +0000 (10:26 +0000)]
r4311: 'Document' the -L switch when adding groups with "net rpc group".

(This used to be commit 4eec06b461c295f90c2ec01a0eef1e173eab22b3)

13 years agor4306: Couple more MALLOC fixes from albert chin (
Jeremy Allison [Tue, 21 Dec 2004 07:08:11 +0000 (07:08 +0000)]
r4306: Couple more MALLOC fixes from albert chin (
(This used to be commit c5a8bf3335606c070e1c74f339ea4c22d0adfa57)

13 years agor4305: Fix from Albert Chin ( to fix the
Jeremy Allison [Tue, 21 Dec 2004 04:34:14 +0000 (04:34 +0000)]
r4305: Fix from Albert Chin ( to fix the
earlier malloc changes.
(This used to be commit da7ef2517162740bc61a81ae814d48348aa513d5)

13 years agor4301: One more *alloc -> SMB_MALLOC (not compiled by default).
Jeremy Allison [Tue, 21 Dec 2004 01:04:11 +0000 (01:04 +0000)]
r4301: One more *alloc -> SMB_MALLOC (not compiled by default).
(This used to be commit 235a0c1698db48583a6860a3a9fca9f261544365)

13 years agor4296: Patch from William Jojo <> to fix HPUX sendfile and add
Jeremy Allison [Mon, 20 Dec 2004 22:33:37 +0000 (22:33 +0000)]
r4296: Patch from William Jojo <> to fix HPUX sendfile and add tests and code for sendfile on AIX.
(This used to be commit f08aceb9882fb1df1e1e28179f87ac5c3d5afa45)

13 years agor4295: Don't include header len in data write debug.
Jeremy Allison [Mon, 20 Dec 2004 22:04:53 +0000 (22:04 +0000)]
r4295: Don't include header len in data write debug.
(This used to be commit 473babfecac87a7e1068246bddc171a464be59e5)

13 years agor4293: Fix inspired by debug trace from Rob Foehl <> - catch sendfile
Jeremy Allison [Mon, 20 Dec 2004 22:01:42 +0000 (22:01 +0000)]
r4293: Fix inspired by debug trace from Rob Foehl <> - catch sendfile
errors correctly and return the correct values we want the caller to return (-1
meaning none in correct cases).
(This used to be commit 139c1c3488237d710ceda394c028b8dc9007bff1)

13 years agor4291: More *alloc fixes inspired by Albert Chin (
Jeremy Allison [Mon, 20 Dec 2004 21:14:28 +0000 (21:14 +0000)]
r4291: More *alloc fixes inspired by Albert Chin (
(This used to be commit efc1b688cf9b1a17f1a6bf46d481280ed8bd0c46)

13 years agor4289: Close LDAP-Connection before retrying to open a new connection in the
Günther Deschner [Mon, 20 Dec 2004 18:42:58 +0000 (18:42 +0000)]
r4289: Close LDAP-Connection before retrying to open a new connection in the

This fixes a deadlock-situation when ldapsam is used with the ldapi
interface: getpeername won't fail while trying to detect dead
connections on unix domain sockets. When the ldapi-connection was closed
server-side (due to OpenLDAP's idletimeout) we *never* got a new LDAP

(This used to be commit ac8032bacff10451fa03f155d43f0d20389512fa)

13 years agor4287: Vampire SAM_DELTA_DOMAIN_INFO.
Günther Deschner [Mon, 20 Dec 2004 12:52:33 +0000 (12:52 +0000)]

Based on samba4-idl. The decoding of account-lockout-string is somewhat
experimental though.

(This used to be commit 721bf50d7446b8ce18bc1d45e17d4214d5a43d26)

13 years agor4286: Give back 8 byte lm_session_key in Netrsamlogon-reply.
Günther Deschner [Mon, 20 Dec 2004 11:36:39 +0000 (11:36 +0000)]
r4286: Give back 8 byte lm_session_key in Netrsamlogon-reply.

The old #ifdef JRATEST-block was copying 16 bytes and thus overwriting
acct_flags with bizarre values, breaking a lot of things.

This patch is successfully running in a production environment for quite
some time now and is required to finally allow Exchange 5.5 to access
another Exchange Server when both are running on NT4 in a
samba-controlled domain. This also allows Exchange Replication to take
place, Exchange Administrator to access other Servers in the network,
etc. Fixes Bugzilla #1136.

Thanks abartlet for helping me with that one.

(This used to be commit bd4c5125d6989cebc90152a23e113b345806c660)

13 years agor4285: Allow -v or -l for displaying verbose groupmap-listing as well as
Günther Deschner [Mon, 20 Dec 2004 11:05:54 +0000 (11:05 +0000)]
r4285: Allow -v or -l for displaying verbose groupmap-listing as well as

(This used to be commit 0760d07b4c6f15489bea2f0fb4f1b0084bd62301)

13 years agor4273: Same fix for r4272 in SAMBA_3_0 branch.
Tim Potter [Sun, 19 Dec 2004 03:23:10 +0000 (03:23 +0000)]
r4273: Same fix for r4272 in SAMBA_3_0 branch.
(This used to be commit 4f1927acfa6569fc90317d76ed34e5ee088df7c1)

13 years agor4270: Add some const as a fix for bugzilla #2135.
Tim Potter [Sun, 19 Dec 2004 00:53:52 +0000 (00:53 +0000)]
r4270: Add some const as a fix for bugzilla #2135.
(This used to be commit ad8fdcc6fdb08d206d324a152300933661c72c4b)

13 years agor4268: Merge fix for bugzilla #2150.
Tim Potter [Sun, 19 Dec 2004 00:31:31 +0000 (00:31 +0000)]
r4268: Merge fix for bugzilla #2150.
(This used to be commit f00ae4ab0c36a623257861fb65373b39cf075921)

13 years agor4260: Change the license for the winbindd external interface more liberal.
Tim Potter [Fri, 17 Dec 2004 22:16:30 +0000 (22:16 +0000)]
r4260: Change the license for the winbindd external interface more liberal.
(This used to be commit 82b9faaaa2e1e2986a15102605739e7d13885ac6)

13 years agor4259: Fix cast in SMB_XMALLOC_ARRAY. Bugzilla #2168.
Tim Potter [Fri, 17 Dec 2004 21:59:47 +0000 (21:59 +0000)]
r4259: Fix cast in SMB_XMALLOC_ARRAY.  Bugzilla #2168.
(This used to be commit 0c3bb181e8f4d10d446f9211904d53f42ddcbaeb)

13 years agor4258: strlower username, not (non-existing) domain_username.
Günther Deschner [Fri, 17 Dec 2004 13:14:22 +0000 (13:14 +0000)]
r4258: strlower username, not (non-existing) domain_username.

(This used to be commit 4f10666295ff7c086ac2a38e0a5f0ac80b57b9a0)

13 years agor4256: Add a patch from New Parameter 'afs token lifetime' tells the
Volker Lendecke [Fri, 17 Dec 2004 11:42:10 +0000 (11:42 +0000)]
r4256: Add a patch from New Parameter 'afs token lifetime' tells the
AFS client when to throw away a token.


(This used to be commit 836a8277b2281bcdb6eab8339b05bec61b49eb74)

13 years agor4254: Add an undocumented hack. I had to delete a wrong mapping (a user that had
Volker Lendecke [Fri, 17 Dec 2004 10:20:53 +0000 (10:20 +0000)]
r4254: Add an undocumented hack. I had to delete a wrong mapping (a user that had
ended up as a gid in winbindd_idmap.tdb) from winbindd_idmap.tdb. Stopping
winbind was not an option on that machine....

net idmap delete <idmap-file> <SID>


(This used to be commit 27c16733c13bb1c91d356f1c9f5c1f069e24cca2)

13 years agor4252: Comment clarification from Love Hörnquist Åstrand <>.
Volker Lendecke [Fri, 17 Dec 2004 09:35:54 +0000 (09:35 +0000)]
r4252: Comment clarification from Love Hörnquist Åstrand <>.


(This used to be commit 207625c7ab8ce41d7b59981e6a767dc299178335)

13 years agor4251: AFS does not cope with spaces in file names. Implement a stupid mapping that
Volker Lendecke [Fri, 17 Dec 2004 09:05:41 +0000 (09:05 +0000)]
r4251: AFS does not cope with spaces in file names. Implement a stupid mapping that
maps the space to another character choosable by afsacl:space.


P.S: Who is "OH"? ;-)
(This used to be commit e717ff70c6ce15bad7a792a592b42ecd057acc01)

13 years agor4248: Implement smbstatus -n, don't lookup users and groups. On heavily loaded
Volker Lendecke [Fri, 17 Dec 2004 08:51:23 +0000 (08:51 +0000)]
r4248: Implement smbstatus -n, don't lookup users and groups. On heavily loaded
winbind systems, looking up hundreds of users can turn out to be a bit too
expensive if you just want to find out which smbd handles a particular IP


P.S: Who is "OH"? ;-)
(This used to be commit d878563ef0c9aa21a12cc5a88dcb17ef8c4bcf5a)

13 years agor4241: More *alloc fixes.
Jeremy Allison [Thu, 16 Dec 2004 21:16:48 +0000 (21:16 +0000)]
r4241: More *alloc fixes.
(This used to be commit ec9606f00b52eb0d3a1a4c5eb98d171660ef19ad)

13 years agor4238: More *alloc fixes.
Jeremy Allison [Thu, 16 Dec 2004 21:14:08 +0000 (21:14 +0000)]
r4238: More *alloc fixes.
(This used to be commit 4d971806f4e4f5523227e378125d5601a5df271d)

13 years agor4236: More *alloc fixes.
Jeremy Allison [Thu, 16 Dec 2004 21:12:29 +0000 (21:12 +0000)]
r4236: More *alloc fixes.
(This used to be commit 6b25a6e088390d33314ca69c8f17c869cec3904b)

13 years agor4234: More malloc fixes to use the macros.
Jeremy Allison [Thu, 16 Dec 2004 21:06:33 +0000 (21:06 +0000)]
r4234: More malloc fixes to use the macros.
(This used to be commit 61479f56be60a3c2ae0f7b931335cb1da77540c2)

13 years agor4226: display infolevel 12 in query_dom_info.
Günther Deschner [Wed, 15 Dec 2004 19:37:35 +0000 (19:37 +0000)]
r4226: display infolevel 12 in query_dom_info.

(This used to be commit d25f303f317ef6ec96799d396ca65ac500cae0ae)

13 years agor4224: Today is not my day ....
Volker Lendecke [Wed, 15 Dec 2004 15:39:23 +0000 (15:39 +0000)]
r4224: Today is not my day ....
(This used to be commit 40b208b25212f84faeb7d54b7dc0dbb9f925b651)

13 years agor4222: Always compile before commit...
Volker Lendecke [Wed, 15 Dec 2004 14:23:15 +0000 (14:23 +0000)]
r4222: Always compile before commit...
(This used to be commit 0f26ba5226fab5b86031a0df6fba16b8e6af6e7d)

13 years agor4221: when in the multi-mapping mode of idmap_rid:
Günther Deschner [Wed, 15 Dec 2004 14:16:12 +0000 (14:16 +0000)]
r4221: when in the multi-mapping mode of idmap_rid:
allow BUILTIN domain-mapping.

(This used to be commit e3b067ee99e304aa9e165dae5fcb0546cec711e2)

13 years agor4219: Fix samba3 samr "idl"... According to samba4 idl samr_DomInfo2 contains a
Volker Lendecke [Wed, 15 Dec 2004 13:13:15 +0000 (13:13 +0000)]
r4219: Fix samba3 samr "idl"... According to samba4 idl samr_DomInfo2 contains a
comment string and not an unknown 12 byte structure...

Found after abartlet's smbtorture extended this string to

"Tortured by Samba4: Fri Nov 26 15:40:18 2004 CET"


(This used to be commit b41d94d8186f66136918432cf32e9dcef5a8bd12)

13 years agor4217: Fix open_any_socket_out.
Volker Lendecke [Wed, 15 Dec 2004 12:05:48 +0000 (12:05 +0000)]
r4217: Fix open_any_socket_out.

This was a missing merge from HEAD or rather a commit to 3_0 from the wrong
source. Fixed slightly over HEAD, HEAD merge will follow.

Deal with connection refused according to the specs.

(This used to be commit 7230cb87eba2c296217bb0255893c55ae5d695d3)

13 years agor4216: fix segfault in idmap_rid
Günther Deschner [Wed, 15 Dec 2004 10:12:10 +0000 (10:12 +0000)]
r4216: fix segfault in idmap_rid

(only ever shows up when the somewhat hidden

Thanks to Stephan Martin <> for reporting this bug.

(This used to be commit e7b81d679b487734e12a948f30f0ad88240f17f1)

13 years agor4212: Ensure we only look at the bottom bit of large_readx.
Jeremy Allison [Wed, 15 Dec 2004 01:25:24 +0000 (01:25 +0000)]
r4212: Ensure we only look at the bottom bit of large_readx.
Set the 14 word version of write if size > 0xffff as
well as 64-bit offset.
(This used to be commit 94779ccb39560bf5eecab77d70f1fa04bfcf1456)

13 years agor4208: Set version to 3.0.11
John Terpstra [Tue, 14 Dec 2004 23:05:27 +0000 (23:05 +0000)]
r4208: Set version to 3.0.11
(This used to be commit 8622fdcc50dfb4fa09c9b3dff2140a68454d3146)

13 years agor4190: When changing length calculations, get them right......
Jeremy Allison [Tue, 14 Dec 2004 01:11:22 +0000 (01:11 +0000)]
r4190: When changing length calculations, get them right......
(This used to be commit 63cfa904ad186bb9d793584d319bd4a7107cc8b9)

13 years agor4188: Ensure we add in the upper length in the right place !
Jeremy Allison [Tue, 14 Dec 2004 00:33:53 +0000 (00:33 +0000)]
r4188: Ensure we add in the upper length in the right place !
(This used to be commit 9d4e57f06c4f75f42036e91401b0d0392647752b)

13 years agor4186: Fix client & server to allow 127k READX calls.
Jeremy Allison [Tue, 14 Dec 2004 00:25:11 +0000 (00:25 +0000)]
r4186: Fix client  & server to allow 127k READX calls.
(This used to be commit 831cb21a874601e4536c2cf76c5351e1d0defcb5)

13 years agor4184: Removed unused extern.
Jeremy Allison [Tue, 14 Dec 2004 00:20:55 +0000 (00:20 +0000)]
r4184: Removed unused extern.
(This used to be commit 72e39041e9fbb7f252292182d56b1927a8133be0)

13 years agor4153: port from trunk of pdbedit changes
Simo Sorce [Sat, 11 Dec 2004 17:09:28 +0000 (17:09 +0000)]
r4153: port from trunk of pdbedit changes
(This used to be commit 9b322f232c450e9525d5aa3b8267881b94ba4052)

13 years agor4143: Make strict locking an enum. Auto means use oplock optimization.
Jeremy Allison [Sat, 11 Dec 2004 00:30:28 +0000 (00:30 +0000)]
r4143: Make strict locking an enum. Auto means use oplock optimization.
(This used to be commit 0dd4adeae2042d0ea64398a78b3f48eb0150c133)

13 years agor4134: check the setprinter(3) based on the access permissions on the handle and...
Gerald Carter [Fri, 10 Dec 2004 21:08:34 +0000 (21:08 +0000)]
r4134: check the setprinter(3) based on the access permissions on the handle and avoid the call to print_access_chaeck()
(This used to be commit 426634df9c221fbe4f48b4ff9d1b4b8426a581f7)

13 years agor4130: add bad_password_count and logon_count to vampire (inspired by a patch
Günther Deschner [Fri, 10 Dec 2004 10:42:47 +0000 (10:42 +0000)]
r4130: add bad_password_count and logon_count to vampire (inspired by a patch
from Lars Mueller <>), just for completeness.

Note that though we have logon_count implemented in all pdb-backends but
never (for good reason!) update the counter.

(This used to be commit a03aa0956813998dbbc3c68f6bc5214fd720cdb2)

13 years agor4128: Cron jobs etc seem to do an initgroups for root quite frequently. So
Volker Lendecke [Fri, 10 Dec 2004 10:30:59 +0000 (10:30 +0000)]
r4128: Cron jobs etc seem to do an initgroups for root quite frequently. So
log.winbindd is spammed with 'user root does not exist'. Increase debug level.

(This used to be commit 7256771dd01029ed103896c0825bb91b88757015)

13 years agor4127: vampire munged_dial.
Günther Deschner [Fri, 10 Dec 2004 09:45:03 +0000 (09:45 +0000)]
r4127: vampire munged_dial.

(This used to be commit eb64eb9d572e12b28a67779746b8ddc191497c09)

13 years agor4126: Fix from Björn Jacke <> for bugid #2040 - ensure the locale
Jeremy Allison [Fri, 10 Dec 2004 05:49:48 +0000 (05:49 +0000)]
r4126: Fix from Björn Jacke <> for bugid #2040 - ensure the locale
is reset to C to get ASCII-compatible toupper/lower functions.
(This used to be commit 8e1b1693abf1e6eb46b23a5fa56776fc2ede7982)

13 years agor4121: Optimisation from Nadav Danieli <>. If we're oplocked,
Jeremy Allison [Thu, 9 Dec 2004 22:10:40 +0000 (22:10 +0000)]
r4121: Optimisation from Nadav Danieli <>. If we're oplocked,
short circuit some is_locked() tests.
(This used to be commit f4feed8f90be98eaea59bebcc142fd398ffe2a59)

13 years agor4120: Never, ever, doubt valgrind :-). Fix order of evaluation bug that's been in the
Jeremy Allison [Thu, 9 Dec 2004 21:42:00 +0000 (21:42 +0000)]
r4120: Never, ever, doubt valgrind :-). Fix order of evaluation bug that's been in the
bitmap code for ever. Remove silly extra space in paranoid malloc.
(This used to be commit 0a7d17bc9b178628da371e627014412e9bef5d42)

13 years agor4108: As check_self is *always* False in every invokation, remove the
Jeremy Allison [Thu, 9 Dec 2004 01:07:06 +0000 (01:07 +0000)]
r4108: As check_self is *always* False in every invokation, remove the
logic for it. We still pass Samba4 RAW-LOCK test.
(This used to be commit 596f23051363f8cc8896119b3eca0663a61a38c3)

13 years agor4103: lock timeout is in milliseconds (as in reply.c)
Herb Lewis [Wed, 8 Dec 2004 17:30:50 +0000 (17:30 +0000)]
r4103: lock timeout is in milliseconds (as in reply.c)
(This used to be commit 1feda3649fa5dd7233ea66057fc431948c87825b)

13 years agor4094: BUG 2107: fix memory bloating caused by large numbers of print_queue_updates...
Gerald Carter [Wed, 8 Dec 2004 03:02:29 +0000 (03:02 +0000)]
r4094: BUG 2107: fix memory bloating caused by large numbers of print_queue_updates() requests sent via messages.tdb
(This used to be commit 56b1110c71b17eeb2ebdb7d506d86deb6b81f0d5)

13 years agor4092: Bring into line with new *alloc rules.
Jeremy Allison [Wed, 8 Dec 2004 01:52:23 +0000 (01:52 +0000)]
r4092: Bring into line with new *alloc rules.
(This used to be commit 2ed86ac5844ce5893beb2bca351fee66cc3b4049)

13 years agor4089: fix logic error in add_a_form() that only compared N characters instead of...
Gerald Carter [Tue, 7 Dec 2004 19:00:45 +0000 (19:00 +0000)]
r4089: fix logic error in add_a_form() that only compared N characters instead of the entire form name
(This used to be commit e3decbc441686486903a4863daa862ed1672e405)

13 years agor4088: Get medieval on our ass about malloc.... :-). Take control of all our allocation
Jeremy Allison [Tue, 7 Dec 2004 18:25:53 +0000 (18:25 +0000)]
r4088: Get medieval on our ass about malloc.... :-). Take control of all our allocation
functions so we can funnel through some well known functions. Should help greatly with
malloc checking.
HEAD patch to follow.
(This used to be commit 620f2e608f70ba92f032720c031283d295c5c06a)

13 years agor4083: consolidate printer searches to use find_service rather than for loops
Gerald Carter [Mon, 6 Dec 2004 19:25:25 +0000 (19:25 +0000)]
r4083: consolidate printer searches to use find_service rather than for loops
(This used to be commit 12440744ba36445186042c8c254785766cce5385)

13 years agor4043: BUG 2091: don't remove statically defined printers in remove_stale_printers()
Gerald Carter [Thu, 2 Dec 2004 17:11:18 +0000 (17:11 +0000)]
r4043: BUG 2091: don't remove statically defined printers in remove_stale_printers()
(This used to be commit c24a3c49ce20797c0f9172e503e34770d00842ec)

13 years agor4032: Fix bug #2110 - ensure we convert to ucs2 correctly.
Jeremy Allison [Thu, 2 Dec 2004 00:55:47 +0000 (00:55 +0000)]
r4032: Fix bug #2110 - ensure we convert to ucs2 correctly.
(This used to be commit a1e5a2a6ab1abc9add7a606e2e3f2d6c88dcf96c)

13 years agor4030: patch from Rob -- don't force the cups printer-make-and-model tag as the comme...
Gerald Carter [Wed, 1 Dec 2004 21:11:54 +0000 (21:11 +0000)]
r4030: patch from Rob -- don't force the cups printer-make-and-model tag as the comment for autoloaded printers
(This used to be commit 26bbad62b9cfef4f2bb5cd3f2b2b7d13017e6439)

13 years agor4029: solaris packaging fixes from Rob
Gerald Carter [Wed, 1 Dec 2004 21:01:27 +0000 (21:01 +0000)]
r4029: solaris packaging fixes from Rob
(This used to be commit 18915f59e4a3ef1cb32c2d119baa8906e1dc5976)

13 years agor4028: * prevent the background LPQ daemon from updating
Gerald Carter [Wed, 1 Dec 2004 20:11:31 +0000 (20:11 +0000)]
r4028: * prevent the background LPQ daemon from updating
  the print queue cache just because multiple smbd
  processes sent a message that it was out of date.

* add some extra debug messages while trying to track down
  down jobs being left in the queue after printing has
(This used to be commit a64505d52fcb23374711e22b3df328c9a7848b84)

13 years agor4023: Code tidyup to fix bug #2098.
Jeremy Allison [Tue, 30 Nov 2004 22:57:41 +0000 (22:57 +0000)]
r4023: Code tidyup to fix bug #2098.
(This used to be commit ebaf21e3e289d3570f20b22e00555eaebe060063)

13 years agor4020: Fix for crash reported by Bård Kalbakk <>.
Jeremy Allison [Tue, 30 Nov 2004 18:58:58 +0000 (18:58 +0000)]
r4020: Fix for crash reported by Bård Kalbakk <>.
Don't go fishing for the authorisation data unless we
know it's there.
(This used to be commit 6f6b4c61e03afb4d35bf6b3ea468fb211d703aa7)

13 years agor4019: better error logging in register_message_flags() from Rob
Gerald Carter [Tue, 30 Nov 2004 15:55:27 +0000 (15:55 +0000)]
r4019: better error logging in register_message_flags() from Rob
(This used to be commit 5fc0f838e7ec8b29d7987caafe9ffbb8724a3176)

13 years agor4018: * move claim_connection from the netbios session request
Gerald Carter [Tue, 30 Nov 2004 15:52:46 +0000 (15:52 +0000)]
r4018: * move claim_connection from the netbios session request
  reply code to the negprot reply code to cope with
  client connections on port 445.  Fixes the spurious
  "register_message_flags: tdb fetch failed" errors.

* don't run the backgroup LPQ daemon when we are running
  in interactive mode.
(This used to be commit 88747a7da351261185222e78e9c8d470ff53a246)

13 years agor4016: Fix for bug found by Steve French client code (cifsfs) on
Jeremy Allison [Tue, 30 Nov 2004 06:41:38 +0000 (06:41 +0000)]
r4016: Fix for bug found by Steve French client code (cifsfs) on
POSIX ACL set. You need to *get* a permset_t pointer from the entry before
any of the permset code will accept it as a valid value
(This used to be commit 7e78059948612fa9f5d179a1e3f5f59e7ad5e456)

13 years agor4009: Fix from Timur Bakeyev <> for bugid #2100,
Jeremy Allison [Tue, 30 Nov 2004 01:01:43 +0000 (01:01 +0000)]
r4009: Fix from Timur Bakeyev <> for bugid #2100,
change the way we check for errors after a dlopen (which
may set internal warnings which get picked up by mistake
in dlsym).
(This used to be commit 6711cb8b02f96d04af82d30b1274f76dc5461dc2)

13 years agor4007: Fix bug #2088 - ensure inherit permissions is only applied on a new file,
Jeremy Allison [Tue, 30 Nov 2004 00:22:04 +0000 (00:22 +0000)]
r4007: Fix bug #2088 - ensure inherit permissions is only applied on a new file,
not an existing one.
(This used to be commit fbbdb72cf1adfe567112556626f26b031747f440)

13 years agor4005: Fix for bug #2071 reported by Jason Mader <>.
Jeremy Allison [Mon, 29 Nov 2004 19:28:12 +0000 (19:28 +0000)]
r4005: Fix for bug #2071 reported by Jason Mader <>.
Use correct enum type for comparisons.
(This used to be commit b926480d053e42205e959b9808a6e3bb90db9ce5)

13 years agor3987: Use sys_readdir() instead of readdir()
Jelmer Vernooij [Sat, 27 Nov 2004 19:02:45 +0000 (19:02 +0000)]
r3987: Use sys_readdir() instead of readdir()
(This used to be commit 7751f46cc77887cd050b44eebb28909a871d4f6b)

13 years agor3985: Fix bug with 64bit fs support
Jelmer Vernooij [Sat, 27 Nov 2004 18:57:44 +0000 (18:57 +0000)]
r3985: Fix bug with 64bit fs support
(This used to be commit 5cee4e94786c6fd63dab1a9805914a9ce6aa7227)

13 years agor3974: - Fix assignment of a couple of fields in pdb_{mysql,pgsql}
Jelmer Vernooij [Thu, 25 Nov 2004 20:55:31 +0000 (20:55 +0000)]
r3974: - Fix assignment of a couple of fields in pdb_{mysql,pgsql}
- Use new DTD URL in pdb_xml
(This used to be commit 99dc2f36d1f637906d47e98dbd4d5eb1f1cc4357)

13 years agor3954: bring Samba3 into line with the Samba4 password change code
Andrew Tridgell [Thu, 25 Nov 2004 04:10:19 +0000 (04:10 +0000)]
r3954: bring Samba3 into line with the Samba4 password change code
(This used to be commit 04a6573f894800b9d939d9b4be48790437352804)

13 years agor3951: Fix for bugid #2081 reported by John Janosik <> - ensure
Jeremy Allison [Thu, 25 Nov 2004 00:59:44 +0000 (00:59 +0000)]
r3951: Fix for bugid #2081 reported by John Janosik <> - ensure
SE_DESC_DACL_PROTECTED is set if "map acl inherit = no".
(This used to be commit 934c41b474c8959310389378bfa7d3332bd5ec79)

13 years agor3948: Fix incorrect declaration. Bug #2083.
Jeremy Allison [Thu, 25 Nov 2004 00:25:53 +0000 (00:25 +0000)]
r3948: Fix incorrect declaration. Bug #2083.
(This used to be commit 05b905a28f349a2741e0963e41ad624a8f0b9fb8)

13 years agor3946: Fix for bugid #2085 reported by Jason Mader <>. Use consistent
Jeremy Allison [Thu, 25 Nov 2004 00:07:01 +0000 (00:07 +0000)]
r3946: Fix for bugid #2085 reported by Jason Mader <>. Use consistent
enum type for Protocol extern.
(This used to be commit 65dfae7ea45d4c9452b2a08efa09b01d870142f3)

13 years agor3944: Fix the problem we get on Linux where sendfile fails, but we've already sent the
Jeremy Allison [Wed, 24 Nov 2004 22:05:59 +0000 (22:05 +0000)]
r3944: Fix the problem we get on Linux where sendfile fails, but we've already sent the
header using send(). As our implementation of sendfile can't return EINTR (it
restarts in that case) use an errno of EINTR to signal the linux sendfile fail
after header case. When that happens send the rest of the data and then turn
off sendfile. Sendfile should be safe to enable on all systems now (even though
it may not help in all performance cases).
(This used to be commit 78236382f7ffe08d7924907be49493779521837f)

13 years agor3940: typo.
Günther Deschner [Wed, 24 Nov 2004 09:44:57 +0000 (09:44 +0000)]
r3940: typo.

(This used to be commit 412ff4a129c5e719aa4d4e4856500ff59c82b939)

13 years agor3936: Ensure LARGE_READX response must fit within reply buffer.
Jeremy Allison [Wed, 24 Nov 2004 05:24:38 +0000 (05:24 +0000)]
r3936: Ensure LARGE_READX response must fit within reply buffer.
(This used to be commit 5541001cf98aa9afb8f98ebeb91561348d3f5d74)

13 years agor3934: Correctly check for the top length bit in LARGE_READX.
Jeremy Allison [Wed, 24 Nov 2004 03:42:01 +0000 (03:42 +0000)]
r3934: Correctly check for the top length bit in LARGE_READX.
(This used to be commit f9effa2af90245c0fe090d730c86a2a60d8570dc)

13 years agor3931: Fix all "may be used uninitialized" and "shadow" warnings.
Jeremy Allison [Wed, 24 Nov 2004 01:03:23 +0000 (01:03 +0000)]
r3931: Fix all "may be used uninitialized" and "shadow" warnings.
(This used to be commit 8e979772a640bb4f00f4d72b6a9c837b8ef14333)

13 years agor3929: Dead code elimination fix for bug #2075 from
Jeremy Allison [Tue, 23 Nov 2004 23:13:48 +0000 (23:13 +0000)]
r3929: Dead code elimination fix for bug #2075 from
(This used to be commit 9d367ac636d7d88cd4756531bd8412f8d6d16d14)

13 years agor3928: Fix duplicate call to pdb_get_acct_desc(). Bugzilla #2080.
Tim Potter [Tue, 23 Nov 2004 20:50:16 +0000 (20:50 +0000)]
r3928: Fix duplicate call to pdb_get_acct_desc().  Bugzilla #2080.
(This used to be commit 3ebfd137b2d8f393874561046ef79f4d9a8cae52)

13 years agor3925: patch from Thomas Bork <> to fix with GNU ld versio...
Gerald Carter [Tue, 23 Nov 2004 16:35:14 +0000 (16:35 +0000)]
r3925: patch from Thomas Bork <> to fix with GNU ld versions that don't output a date string in the --version
(This used to be commit 3bbae21dc9d8147a40cac7962e44fe37630efb40)