13 years agor19853: Update a link
Volker Lendecke [Thu, 23 Nov 2006 10:42:58 +0000 (10:42 +0000)]
r19853: Update a link
(This used to be commit ce44158dde64cb65a3f51dfe1734f3c3d7f1bfd9)

13 years agor19852: Fix the build for the VFS examples. Fixes bugzilla #3931.
James Peach [Thu, 23 Nov 2006 06:44:05 +0000 (06:44 +0000)]
r19852: Fix the build for the VFS examples. Fixes bugzilla #3931.
(This used to be commit fa69031d00f914aa8d642a2731db8c81f74bc8d9)

13 years agor19851: Disable gcc PIE options on Darwin.
James Peach [Thu, 23 Nov 2006 06:07:03 +0000 (06:07 +0000)]
r19851: Disable gcc PIE options on Darwin.
(This used to be commit 23795be8b429d4423263e60ce80f454e2e42cae7)

13 years agor19849: Fix compilation after idl changes.
Jelmer Vernooij [Wed, 22 Nov 2006 21:40:23 +0000 (21:40 +0000)]
r19849: Fix compilation after idl changes.
(This used to be commit b7f22408e9aac88e792929afe15385e5997658ce)

13 years agor19848: Sync with Samba4 - no top-level unique pointers.
Jelmer Vernooij [Wed, 22 Nov 2006 18:57:07 +0000 (18:57 +0000)]
r19848: Sync with Samba4 - no top-level unique pointers.
(This used to be commit 75515c5fda2d405e4b08413a80ee71139673b18a)

13 years agor19841: Wrap regdb_store_keys and regdb_store_values in tdb transactions
Volker Lendecke [Wed, 22 Nov 2006 16:53:28 +0000 (16:53 +0000)]
r19841: Wrap regdb_store_keys and regdb_store_values in tdb transactions
(This used to be commit 5ec737922041b723b9e60c08049ace5fa2fa5dec)

13 years agor19840: Fix an uninitialized variable
Volker Lendecke [Wed, 22 Nov 2006 16:39:07 +0000 (16:39 +0000)]
r19840: Fix an uninitialized variable
(This used to be commit c4b5e8c7a0b936a3d95f221718a048d5374e836a)

13 years agor19839: Fix the build, we are not there yet :-)
Volker Lendecke [Wed, 22 Nov 2006 15:55:48 +0000 (15:55 +0000)]
r19839: Fix the build, we are not there yet :-)
(This used to be commit ff4123c8f2e07e282800c166a4e00b1015ddd45c)

13 years agor19838: We have to delete the value record as well, otherwise the old values pop up
Volker Lendecke [Wed, 22 Nov 2006 15:41:29 +0000 (15:41 +0000)]
r19838: We have to delete the value record as well, otherwise the old values pop up
again if the key is re-created.

(This used to be commit f722f3341f65f8737c10eb59048c1263a58afd44)

13 years agor19837: Some reformatting (Jerry, I hope you do not mind
Volker Lendecke [Wed, 22 Nov 2006 15:10:46 +0000 (15:10 +0000)]
r19837: Some reformatting (Jerry, I hope you do not mind
(This used to be commit 6639f8c1190419e183d92ed0322e1026375717e6)

13 years agor19835: Some net sam policy improvements.
Volker Lendecke [Wed, 22 Nov 2006 14:17:36 +0000 (14:17 +0000)]
r19835: Some net sam policy improvements.

Thanks to Karolin Seeger <>

(This used to be commit 2091018a534006cddaa5cf52f564fd7e023473b6)

13 years agor19828: Add a helper function to pull *and* unparse local registry values
Volker Lendecke [Tue, 21 Nov 2006 21:19:51 +0000 (21:19 +0000)]
r19828: Add a helper function to pull *and* unparse local registry values
(This used to be commit 969eb9cda6eba93068472e952e27138b9384c364)

13 years agor19827: Move registry_push/pull_value to lib/util_reg.c
Volker Lendecke [Tue, 21 Nov 2006 21:18:53 +0000 (21:18 +0000)]
r19827: Move registry_push/pull_value to lib/util_reg.c
(This used to be commit 3047a4b92c7d5391a8f162f26ccc92ce30c35cee)

13 years agor19826: Fix typo
Jim McDonough [Tue, 21 Nov 2006 20:44:09 +0000 (20:44 +0000)]
r19826: Fix typo
(This used to be commit fa656ce34ebea57b6dbe70ad1866a419c846e1f1)

13 years agor19825: To create a key, smbd also needs read privs assigned
Volker Lendecke [Tue, 21 Nov 2006 20:10:39 +0000 (20:10 +0000)]
r19825: To create a key, smbd also needs read privs assigned
(This used to be commit b2866b1318f2fa521ff93ec5ed58413b9145385a)

13 years agor19824: Fix the max value calculation in QueryInfoKey
Volker Lendecke [Tue, 21 Nov 2006 19:47:48 +0000 (19:47 +0000)]
r19824: Fix the max value calculation in QueryInfoKey
(This used to be commit cd14b7f05234f540601cd2c5841a52dd047c965d)

13 years agor19823: "log" is an internal define in older versions of gcc.
Jeremy Allison [Tue, 21 Nov 2006 19:45:53 +0000 (19:45 +0000)]
r19823: "log" is an internal define in older versions of gcc.
Rename to log_ctx.
(This used to be commit dbf0e58a1e7fa77ce0338104cf71c7a81214884b)

13 years agor19822: Implement net rpc registry createkey, deletekey and deletevalue
Volker Lendecke [Tue, 21 Nov 2006 15:33:55 +0000 (15:33 +0000)]
r19822: Implement net rpc registry createkey, deletekey and deletevalue
(This used to be commit 419ebc92f02c9a927295ec7c54844bd5666e3f17)

13 years agor19821: Make net_rpc_registry use net_run_function2.
Volker Lendecke [Tue, 21 Nov 2006 14:01:03 +0000 (14:01 +0000)]
r19821: Make net_rpc_registry use net_run_function2.

Fix an erroneous NT_STATUS_NO_MEMORY found by Chetan S <>.

Thanks :-)

(This used to be commit 30f02e73fd85faa89186511edab4d5396d5efb6a)

13 years agor19820: Limit the stat cache to 1MB by default (Bug 4244). Thanks to Bjoern Jacke
Volker Lendecke [Tue, 21 Nov 2006 13:42:31 +0000 (13:42 +0000)]
r19820: Limit the stat cache to 1MB by default (Bug 4244). Thanks to Bjoern Jacke

(This used to be commit b32c8356f783e0919f29b452be9417d7ff59b5bc)

13 years agor19819: Windows returns an empty string instead of NULL here
Volker Lendecke [Tue, 21 Nov 2006 13:28:27 +0000 (13:28 +0000)]
r19819: Windows returns an empty string instead of NULL here
(This used to be commit c1083216c83f4236edb78484c6333ff1d1646c40)

13 years agor19818: Remove reg_split_hive, make use of registry_openkey
Volker Lendecke [Tue, 21 Nov 2006 10:48:11 +0000 (10:48 +0000)]
r19818: Remove reg_split_hive, make use of registry_openkey
(This used to be commit 7fd1578a905d3c974cb88cc93452d43a03038d30)

13 years agor19817: Implement net rpc registry setvalue (only dword and sz so far)
Volker Lendecke [Tue, 21 Nov 2006 10:32:08 +0000 (10:32 +0000)]
r19817: Implement net rpc registry setvalue (only dword and sz so far)
(This used to be commit 9ecb69c075060d199133520ac6a7627a5faba7f3)

13 years agor19812: dump_regval_buf is not needed anymore
Volker Lendecke [Tue, 21 Nov 2006 02:23:43 +0000 (02:23 +0000)]
r19812: dump_regval_buf is not needed anymore
(This used to be commit f24e64160dc7d7b7434cbed15677c105fa7b60de)

13 years agor19811: Decode REG_MULTI_SZ and REG_BINARY
Volker Lendecke [Tue, 21 Nov 2006 02:21:45 +0000 (02:21 +0000)]
r19811: Decode REG_MULTI_SZ and REG_BINARY
(This used to be commit 679330175185f8504bb5968339dcc7cb20d9140c)

13 years agor19809: remove winbind blacklist parameter
Gerald Carter [Tue, 21 Nov 2006 00:00:43 +0000 (00:00 +0000)]
r19809: remove winbind blacklist parameter
(This used to be commit 40cff1449886449b34b896e31fd43b7dff436a3f)

13 years agor19808: remove old smbwrapper references
Gerald Carter [Tue, 21 Nov 2006 00:00:18 +0000 (00:00 +0000)]
r19808: remove old smbwrapper references
(This used to be commit c142b629c8f08597519a754a8fb78b7708279f75)

13 years agor19807: First attempt at wrapping something sane around the registry API. Will be
Volker Lendecke [Mon, 20 Nov 2006 23:20:07 +0000 (23:20 +0000)]
r19807: First attempt at wrapping something sane around the registry API. Will be

(This used to be commit 40922eb924a8e21f28720f2651f087eefc3e3aed)

13 years agor19804: Fix a valgrind error
Volker Lendecke [Mon, 20 Nov 2006 18:51:00 +0000 (18:51 +0000)]
r19804: Fix a valgrind error
(This used to be commit cb9e16c8389f25f487e627bbeb06ec45f25aef6b)

13 years agor19803: Fix problem reported by Chetan S: QueryInfoKey needs to report the max name
Volker Lendecke [Mon, 20 Nov 2006 13:39:01 +0000 (13:39 +0000)]
r19803: Fix problem reported by Chetan S: QueryInfoKey needs to report the max name
length in *bytes* for UTF-16, not the string length. This got lost during the

This took a while to figure out :-)

Thanks to Chetan!

(This used to be commit 8df6544fa855d2d07b1b69c8d448a1362e41733c)

13 years agor19800: * Remove exmpty aix directory
Gerald Carter [Sun, 19 Nov 2006 19:01:14 +0000 (19:01 +0000)]
r19800: * Remove exmpty aix directory
* remove old, commented out commands from 'make clean'
(This used to be commit 4c96a387a283b52e4dc13cfe15190cbaa300bd1f)

13 years agor19797: Convert the remaining pipes to the "new" unique out ptr handling
Volker Lendecke [Sun, 19 Nov 2006 18:57:52 +0000 (18:57 +0000)]
r19797: Convert the remaining pipes to the "new" unique out ptr handling
(This used to be commit bc4e0a388a2859d2ddcfb8f07920f3b121a37894)

13 years agor19794: Convert DFS
Volker Lendecke [Sun, 19 Nov 2006 18:22:20 +0000 (18:22 +0000)]
r19794: Convert DFS
(This used to be commit 2efd3b35097a780ce99abad8a10eca536f37fc26)

13 years agor19793: Change the lsa calls to the new calling convention. Nobody uses the changed
Volker Lendecke [Sun, 19 Nov 2006 18:06:08 +0000 (18:06 +0000)]
r19793: Change the lsa calls to the new calling convention. Nobody uses the changed
calls yet.

(This used to be commit 144cddaef538cf151ec2c4989e7110c553ca63cb)

13 years agor19790: Check in the PIDL change and the converted unixinfo and winbind pipes without
Volker Lendecke [Sun, 19 Nov 2006 17:56:35 +0000 (17:56 +0000)]
r19790: Check in the PIDL change and the converted unixinfo and winbind pipes without
waiting for comments. This is what version control is for, and it does fix a
segfault I ran into ;-)

Nevertheless, Jelmer & Jerry, please take a look!


(This used to be commit 95c14a822cae2ddc2e6ed87f5f5505fa7b98e4f0)

13 years agor19786: My last checkin to winreg_StringBuf killed rpccli_winreg_EnumKeys against
Volker Lendecke [Sun, 19 Nov 2006 17:07:59 +0000 (17:07 +0000)]
r19786: My last checkin to winreg_StringBuf killed rpccli_winreg_EnumKeys against
W2k3. The server requires that size==0 in the [in] name. Somehow I get the
feeling that something is badly wrong here....

I did not yet recreate the gen_ndr equivalent, see next mail.

(This used to be commit 016ddce12005bb0829bf050e4d4851852751b3e5)

13 years agor19780: Ok, regkey_open_internal needs a regkey_close_internal. Giving a talloc ctx is
Volker Lendecke [Sun, 19 Nov 2006 11:11:01 +0000 (11:11 +0000)]
r19780: Ok, regkey_open_internal needs a regkey_close_internal. Giving a talloc ctx is
misleading here. This needs fixing properly :-)

(This used to be commit f808182346aa16bb2f3a9383e28d318099a5e14e)

13 years agor19779: Fail properly on talloc_strdup failure
Volker Lendecke [Sun, 19 Nov 2006 10:54:57 +0000 (10:54 +0000)]
r19779: Fail properly on talloc_strdup failure
(This used to be commit b57e446789530cb7e18e107478ca8b59a19d990f)

13 years agor19778: Make regkey_open_internal take a talloc ctx
Volker Lendecke [Sun, 19 Nov 2006 10:50:33 +0000 (10:50 +0000)]
r19778: Make regkey_open_internal take a talloc ctx
(This used to be commit cb7f4211b8441642dce9594522dc9588475a7719)

13 years agor19777: Make regsubkey_ctr_addkey return WERROR. Nobody checks this so far, but this
Volker Lendecke [Sat, 18 Nov 2006 17:46:32 +0000 (17:46 +0000)]
r19777: Make regsubkey_ctr_addkey return WERROR. Nobody checks this so far, but this
will change.

(This used to be commit 17c7c337f64b082c1bf1045a4093c279deeec958)

13 years agor19776: Hmmm. I should have done one instead of three commits. Sorry :-)
Volker Lendecke [Sat, 18 Nov 2006 17:07:15 +0000 (17:07 +0000)]
r19776: Hmmm. I should have done one instead of three commits. Sorry :-)
(This used to be commit e2a35ceffe35b25aafde987c50e63b89a3e3ec16)

13 years agor19775: Fix typo
Volker Lendecke [Sat, 18 Nov 2006 17:06:43 +0000 (17:06 +0000)]
r19775: Fix typo
(This used to be commit 370e29ebb9da92c9072bdd4eec84980b5753089a)

13 years agor19774: Fix typo
Volker Lendecke [Sat, 18 Nov 2006 17:06:02 +0000 (17:06 +0000)]
r19774: Fix typo
(This used to be commit 842599a7fd1217b498dc2d241d39ed604cf0da7d)

13 years agor19773: TALLOC_FREE checks for NULL itself
Volker Lendecke [Sat, 18 Nov 2006 17:05:50 +0000 (17:05 +0000)]
r19773: TALLOC_FREE checks for NULL itself
(This used to be commit fb3983ae1fdd1935333ffee80bceb747228ac0f3)

13 years agor19766: Fix a const-warning. Jerry, what did you want to fix with this line?
Volker Lendecke [Sat, 18 Nov 2006 11:29:29 +0000 (11:29 +0000)]
r19766: Fix a const-warning. Jerry, what did you want to fix with this line?

(This used to be commit 55dc4741cfead0f21deb7ea2d28afb240505686b)

13 years agor19764: set version in 3.0 branch to 3.0.25
Gerald Carter [Fri, 17 Nov 2006 23:31:45 +0000 (23:31 +0000)]
r19764: set version in 3.0 branch to 3.0.25
(This used to be commit d7179d945c24f1aa4fff243cc6c29a5545ce692a)

13 years agor19762: libaddns/*[ch] code fixes donated by Centeris Corporation
Gerald Carter [Fri, 17 Nov 2006 21:46:26 +0000 (21:46 +0000)]
r19762: libaddns/*[ch] code fixes donated by Centeris Corporation
( under my copyright.

* Rework error reporting to use DNS_ERROR instead
  of int32
* Convert memory allocation to use talloc()
* Generalize the DNS request/response packet marshalling
* Fix the secure update requests
(This used to be commit c78798333616c3f823514df0f58da2eb3a30a988)

13 years agor19758: remove the LDAP_SCOPE_ONELEVEL define (not needed after svnup)
Gerald Carter [Fri, 17 Nov 2006 01:25:23 +0000 (01:25 +0000)]
r19758: remove the LDAP_SCOPE_ONELEVEL define (not needed after svnup)
(This used to be commit e37132f219bb9ef52c7fc9b396bd272dd5abca70)

13 years agor19754: * When using a krb5 session setup, we don't fill in the server_name
Gerald Carter [Thu, 16 Nov 2006 23:48:46 +0000 (23:48 +0000)]
r19754: * When using a krb5 session setup, we don't fill in the server_name
  string the clis_state struct.  So call saf_store() after we
  have the short domain name in the lsa_query_inof_policy code.

* Remove unused server string in saf_delete()
(This used to be commit 3eddae2f2080f8dafec883cb9ffa2e578c242607)

13 years agor19748: Ensure to link against the required libraries.
Lars Müller [Thu, 16 Nov 2006 18:29:36 +0000 (18:29 +0000)]
r19748: Ensure to link against the required libraries.
(This used to be commit 85d8c73fbbf86f4d22244f8e2bb2fdd51fa6680b)

13 years agor19747: Ensure to link with the required objects.
Lars Müller [Thu, 16 Nov 2006 18:16:57 +0000 (18:16 +0000)]
r19747: Ensure to link with the required objects.
(This used to be commit 8d50fb3f5152b5daa62fde5bbf34f585631be397)

13 years agor19745: For the fun of it, add an CLDAP client written in perl.
Günther Deschner [Thu, 16 Nov 2006 11:55:16 +0000 (11:55 +0000)]
r19745: For the fun of it, add an CLDAP client written in perl.

(This used to be commit 8a2dded7fb6fff7080a77895803f28985bdf728b)

13 years agor19744: merge from samba4
Stefan Metzmacher [Thu, 16 Nov 2006 11:18:05 +0000 (11:18 +0000)]
r19744: merge from samba4

(This used to be commit fe61e6ebf7d771ce6441198bf2e330d53bf7b10e)

13 years agor19741: fix compiler warnings
Stefan Metzmacher [Thu, 16 Nov 2006 11:11:09 +0000 (11:11 +0000)]
r19741: fix compiler warnings

(This used to be commit 18171cf54b22f9f2d73753db580934bd10e95e3d)

13 years agor19739: fix compiler warning
Stefan Metzmacher [Thu, 16 Nov 2006 11:02:34 +0000 (11:02 +0000)]
r19739: fix compiler warning

(This used to be commit b7965ac26cbfdfe60f929e2fa3a295b8c57d220d)

13 years agor19730: as libreplace always provides dlopen(), we need to always define SHLIBEXT
Stefan Metzmacher [Thu, 16 Nov 2006 06:29:18 +0000 (06:29 +0000)]
r19730: as libreplace always provides dlopen(), we need to always define SHLIBEXT

this fix the build on hpisgr8 HPUX 11.23

(This used to be commit b61269d7e39382d395e84bf2b488f6b40a8049a6)

13 years agor19725: sync samba3's ldb with samba4
Stefan Metzmacher [Wed, 15 Nov 2006 17:34:20 +0000 (17:34 +0000)]
r19725: sync samba3's ldb with samba4

(This used to be commit 207643e9c9c75546f38a09f12ea0b574b08086c5)

13 years agor19718: define SHLIBEXT (prepare ldb merge from samba4)
Stefan Metzmacher [Wed, 15 Nov 2006 15:31:11 +0000 (15:31 +0000)]
r19718: define SHLIBEXT (prepare ldb merge from samba4)

(This used to be commit d8f9c200551038dad73be52bb066523312508089)

13 years agor19710: Fix memory leak in get_conf_item_string(). As
Jeremy Allison [Wed, 15 Nov 2006 02:06:58 +0000 (02:06 +0000)]
r19710: Fix memory leak in get_conf_item_string(). As
we're just doing strchr on a const string there's
no need to strdup it before, we're never modifying
it. Just remove the variable "parm".
(This used to be commit 1af18f613b1399220e38e7ab40665c2ca177c5a7)

13 years agor19709: Fix bug #4224 - deadtime timeout was broken
Jeremy Allison [Wed, 15 Nov 2006 01:06:45 +0000 (01:06 +0000)]
r19709: Fix bug #4224 - deadtime timeout was broken
because of this. Probably a show-stopper for 3.0.23d.
Thanks to Alain GORLIER <>
for the fix.
(This used to be commit b167785cbd7911940e16fd2a54ec665857feef5e)

13 years agor19705: Fix blocker bug for 3.0.23d - find_forced_group could
Jeremy Allison [Tue, 14 Nov 2006 20:21:23 +0000 (20:21 +0000)]
r19705: Fix blocker bug for 3.0.23d - find_forced_group could
return an uninitialized sid.
(This used to be commit 57c60103e7dd8f9907bc2954369ea8db8b3b69ff)

13 years agor19703: Don't free a string if you want to return it!
Simo Sorce [Tue, 14 Nov 2006 16:50:29 +0000 (16:50 +0000)]
r19703: Don't free a string if you want to return it!
(This used to be commit 3fed72ac3efd1fa7df8fb7d1e2cb9772d66bb4bd)

13 years agor19692: Another fix.
Simo Sorce [Mon, 13 Nov 2006 14:22:56 +0000 (14:22 +0000)]
r19692: Another fix.
(This used to be commit a86a56fed3eb06b4b4a04329d42a9f57bad16271)

13 years agor19691: Fix the build
Simo Sorce [Mon, 13 Nov 2006 14:01:15 +0000 (14:01 +0000)]
r19691: Fix the build
(This used to be commit fd70972ad943411f58ad9698b33b32e15eae88e4)

13 years agor19690: Remove this ancient module, I never realized it was ported over.
Simo Sorce [Mon, 13 Nov 2006 13:38:04 +0000 (13:38 +0000)]
r19690: Remove this ancient module, I never realized it was ported over.
(This used to be commit 3ef6ef7cc89b6421b9e8ec301cbd55ccd09e4d20)

13 years agor19689: Fix a NULL dereference found by coverity (the call to strlen).
Volker Lendecke [Mon, 13 Nov 2006 10:50:55 +0000 (10:50 +0000)]
r19689: Fix a NULL dereference found by coverity (the call to strlen).

Jerry, please check this. The way I understood alpha_strcpy the last arg needs
to be the size of the target, not of the source.


(This used to be commit 287d68daab89c78748b90849c9782473784b6a84)

13 years agor19688: Fix a deadcode warning by Coverity.
Volker Lendecke [Mon, 13 Nov 2006 10:43:12 +0000 (10:43 +0000)]
r19688: Fix a deadcode warning by Coverity.

Simo, I'm not sure this is the correct fix. So I'd like you to look at it and
merge to 4 if appropriate.

(This used to be commit afd7f12124b02b594063535f93903a8a598a0587)

13 years agor19687: Fix uninitialized variables found by Coverity (and gcc -O1... ;-))
Volker Lendecke [Mon, 13 Nov 2006 10:34:59 +0000 (10:34 +0000)]
r19687: Fix uninitialized variables found by Coverity (and gcc -O1... ;-))

(This used to be commit b7dc9b81696aa5434419c5378a47b41c6dee3dfa)

13 years agor19686: Fix the build
Volker Lendecke [Mon, 13 Nov 2006 09:58:51 +0000 (09:58 +0000)]
r19686: Fix the build
(This used to be commit 28ac0235810c53eccb449201ac933d7eaf8eb38f)

13 years agor19685: Two changes inspired by problems with huge tdbs. tdbtool's list command now
Volker Lendecke [Mon, 13 Nov 2006 09:34:55 +0000 (09:34 +0000)]
r19685: Two changes inspired by problems with huge tdbs. tdbtool's list command now
prints the hash on every record for easier awk'ing, and tdbbackup allows a
different hash chain length on the backed up tdb.

Jeremy, Günther, this might be interesting for you huge domains. Not only
locking.tdb, also the winbind ones might grow huge.

In the installation I fixed with this winbind spent a huge amount of CPU
spinning through a degenerated winbindd_idmap.tdb with entries for more than
15.000 users. With a default number of hash chains of 131 on that tdb you can
imagine that the lists get large.

Not merging to 4, I don't get tdbbackup to compile there right now.

What about changing the global default hash chain number to be dramatically
larger? Disk is cheap these days.

(This used to be commit 577d0ff658596f8246f120e0342cc5c9e4077ece)

13 years agor19669: set_share_security does not need a mem_ctx passed
Volker Lendecke [Sat, 11 Nov 2006 18:07:51 +0000 (18:07 +0000)]
r19669: set_share_security does not need a mem_ctx passed
(This used to be commit 53eaa603eb84047263c27d57b8c0f5ce8e157189)

13 years agor19668: Convert the locking params to use struct share_param instead of snum
Volker Lendecke [Sat, 11 Nov 2006 17:05:11 +0000 (17:05 +0000)]
r19668: Convert the locking params to use struct share_param instead of snum
(This used to be commit 609dbec600048718b86cd1ecdc2ce49bbdeb803c)

13 years agor19667: Fix incorrect null check
Volker Lendecke [Sat, 11 Nov 2006 17:04:08 +0000 (17:04 +0000)]
r19667: Fix incorrect null check
(This used to be commit dc9cdf37e9e2d33d46f0f6da34a3df372eede982)

13 years agor19666: Talloc_guide text on multithreading by Remi Turboult
Volker Lendecke [Sat, 11 Nov 2006 17:02:08 +0000 (17:02 +0000)]
r19666: Talloc_guide text on multithreading by Remi Turboult
(This used to be commit 36a7bf738afd466e378fb2f09d1ce0b47ec924a4)

13 years agor19665: Fix a memleak
Volker Lendecke [Sat, 11 Nov 2006 16:50:38 +0000 (16:50 +0000)]
r19665: Fix a memleak
(This used to be commit bc6d4e52806eb1ace282e983566660928214374c)

13 years agor19659: Fix bug #4187. Possible crash in signing on/off code.
Jeremy Allison [Sat, 11 Nov 2006 00:23:44 +0000 (00:23 +0000)]
r19659: Fix bug #4187. Possible crash in signing on/off code.
(This used to be commit 78c1c43523d787825bdb6d52e128bf0af5eccaae)

13 years agor19657: Correctly check for malloc failure
Volker Lendecke [Fri, 10 Nov 2006 15:56:20 +0000 (15:56 +0000)]
r19657: Correctly check for malloc failure
(This used to be commit e5b5c9b058b7f2a6188684019ffe42e497ac6b6c)

13 years agor19656: Correctly check for malloc failure
Volker Lendecke [Fri, 10 Nov 2006 15:55:06 +0000 (15:55 +0000)]
r19656: Correctly check for malloc failure
(This used to be commit 3d0661b0393804707eb42d9ee9377a622333f252)

13 years agor19655: Jeremy, please review:
Jim McDonough [Fri, 10 Nov 2006 15:43:29 +0000 (15:43 +0000)]
r19655: Jeremy, please review:

I updated the vfs version in 3.0.24 from 16 to 17, beacuse 16 was the
latest released code, but on SAMBA_3_0, I reverted my earlier change
back from 19 to 18, because we've not had any released code with 18.

This is related to the kernel_flock call addition.
(This used to be commit fb8e43fb493b486c31fc141b5240a7dd36c9219f)

13 years agor19652: Trying to track down which caller tries to store a 0 length domain name
Günther Deschner [Fri, 10 Nov 2006 13:46:19 +0000 (13:46 +0000)]
r19652: Trying to track down which caller tries to store a 0 length domain name
in the affinity cache (which happens all the time here).

(This used to be commit 45d6d300767d5b99aff332bdfb0a8f464fd103e0)

13 years agor19651: Fix interesting bug with the automatic site coverage in Active Directory:
Günther Deschner [Fri, 10 Nov 2006 12:42:50 +0000 (12:42 +0000)]
r19651: Fix interesting bug with the automatic site coverage in Active Directory:

When having DC-less sites, AD assigns DCs from other sites to that site
that does not have it's own DC. The most reliable way for us to identify
the nearest DC - in that and all other cases - is the closest_dc flag in
the CLDAP reply.

(This used to be commit ff004f7284cb047e738ba3d3ad6602e8aa84e883)

13 years agor19648: whoops, forgot to increment the vfs version number with the added flock
Jim McDonough [Thu, 9 Nov 2006 21:40:40 +0000 (21:40 +0000)]
r19648: whoops, forgot to increment the vfs version number with the added flock
(This used to be commit 1bc834455de0088941609ed46fcecde5b796fe77)

13 years agor19647: Add some GPFS support in a vfs mod. Also adds the kernel flock op to
Jim McDonough [Thu, 9 Nov 2006 20:29:31 +0000 (20:29 +0000)]
r19647: Add some GPFS support in a vfs mod.  Also adds the kernel flock op to
the vfs layer, since gpfs supports it.  Thanks to Volker, Christian,
Mathias, Chetan, and Peter.
(This used to be commit 0620658890fa9c68a9848538728023192319c81a)

13 years agor19646: Fix memleak in the default_ou_string handling. Thanks to David Hu
Günther Deschner [Thu, 9 Nov 2006 10:16:38 +0000 (10:16 +0000)]
r19646: Fix memleak in the default_ou_string handling. Thanks to David Hu
<>. Fixes #4212.

(This used to be commit 4ec896cdbe441b17d91895a50ac9be61efe2f9c1)

13 years agor19627: Fix for bug #4211 - logic error in acl_group_override()
Jeremy Allison [Tue, 7 Nov 2006 18:35:41 +0000 (18:35 +0000)]
r19627: Fix for bug #4211 - logic error in acl_group_override()
function. Fix from Jim Wang of Wesoft.
(This used to be commit eb78ce1f550377bfb1fd43f550641cf8a606e973)

13 years agor19626: Coalesce usage of DUMP_CORE. Fix formatting on chdir error message
James Peach [Tue, 7 Nov 2006 17:18:00 +0000 (17:18 +0000)]
r19626: Coalesce usage of DUMP_CORE. Fix formatting on chdir error message
in core dump path.
(This used to be commit 9a51fba71c5fa7082c331e1a78a98638d9aa06cf)

13 years agor19601: Fix protection from invalid struct tm values.
Jeremy Allison [Tue, 7 Nov 2006 02:33:10 +0000 (02:33 +0000)]
r19601: Fix protection from invalid struct tm values.
Backport from Samba4.
(This used to be commit 02a0ac0bacafe91e4fa3ca0cae2f05a25215efbc)

13 years agor19591: Use `import' and `include' in the IDL and regenerate.
Jelmer Vernooij [Mon, 6 Nov 2006 23:20:35 +0000 (23:20 +0000)]
r19591: Use `import' and `include' in the IDL and regenerate.
(This used to be commit 68fc15a5e025348dee4bf14aa4498e20905cb377)

13 years agor19579: BUG 4075: patch from Dmitry Butskoy <>.
Gerald Carter [Mon, 6 Nov 2006 19:46:50 +0000 (19:46 +0000)]
r19579: BUG 4075: patch from Dmitry Butskoy <>.
Allow smbd to use winbindd to lookup uids/gids outside the
idmap range if 'winbind trusted domains only = yes'
(This used to be commit 5b3ac400a7d51dfc818563189bdf6649b2dc3a52)

13 years agor19577: Fix from Nils Nordman for bug #4085. Thanks !
Jeremy Allison [Mon, 6 Nov 2006 19:21:44 +0000 (19:21 +0000)]
r19577: Fix from Nils Nordman for bug #4085. Thanks !
(This used to be commit 3b5ab8ab8296339ad0e62d8564d706b5a446dcf3)

13 years agor19576: Correct trivial typo.
James Peach [Mon, 6 Nov 2006 18:39:48 +0000 (18:39 +0000)]
r19576: Correct trivial typo.
(This used to be commit a0ada1aa342722fa7f90715a312b5d81f02f937b)

13 years agor19552: Fix names of known failing tests.
Jelmer Vernooij [Sat, 4 Nov 2006 13:28:19 +0000 (13:28 +0000)]
r19552: Fix names of known failing tests.
(This used to be commit b533620f04758636db6ae5fcea932bb392bc039a)

13 years agor19542: Regenerate IDL.
Jelmer Vernooij [Fri, 3 Nov 2006 20:00:14 +0000 (20:00 +0000)]
r19542: Regenerate IDL.
(This used to be commit 759c1b0fd24aa23802432a0b9447435044d2a11c)

13 years agor19533: Add a suffix to the program name if this is a process with a
Jeremy Allison [Thu, 2 Nov 2006 09:37:52 +0000 (09:37 +0000)]
r19533: Add a suffix to the program name if this is a process with a
non-default configuration file name.
(This used to be commit e8bf421c018ed829b9dba7c0872693080b77d49d)

13 years agor19529: Added showacls togle. Previously was vendor-specific code.
Jeremy Allison [Wed, 1 Nov 2006 17:18:08 +0000 (17:18 +0000)]
r19529: Added showacls togle. Previously was vendor-specific code.
Merging these in - should have been merged back before (will
be tidied up later).
(This used to be commit 1e9284590f42b61bd730104920bc535bf7dfcbf4)

13 years agor19528: Fix container handling for "net ads user" and "net ads group" functions
Günther Deschner [Wed, 1 Nov 2006 11:19:33 +0000 (11:19 +0000)]
r19528: Fix container handling for "net ads user" and "net ads group" functions
along with some memleaks.

(This used to be commit 4bad52c5b3a983418d4216a2c3f5e04926e37e94)

13 years agor19527: Fix double free in "net ads group add".
Günther Deschner [Wed, 1 Nov 2006 11:08:05 +0000 (11:08 +0000)]
r19527: Fix double free in "net ads group add".

(This used to be commit 08db3d3b04d91238b739e88e817bd3f800b768ee)

13 years agor19526: Fix minor memleak.
Günther Deschner [Wed, 1 Nov 2006 11:04:28 +0000 (11:04 +0000)]
r19526: Fix minor memleak.

(This used to be commit 61ebedc82ee7d7a98e2a52b0677d723a801ab30f)

13 years agor19525: Fix the same error in "net ads group delete".
Günther Deschner [Wed, 1 Nov 2006 10:59:28 +0000 (10:59 +0000)]
r19525: Fix the same error in "net ads group delete".

(This used to be commit 94ed3e9de8671d677451d2a16977caeeb7e744d1)

13 years agor19524: Stop "net ads user delete" from doing funny things.
Günther Deschner [Wed, 1 Nov 2006 10:38:54 +0000 (10:38 +0000)]
r19524: Stop "net ads user delete" from doing funny things.

(This used to be commit a20e7c0315f9a06ce2139f99d035b409b066d722)