ira/wip.git
11 years agos3-printing: Fix vlp testprinter application.
Günther Deschner [Tue, 12 May 2009 09:41:14 +0000 (11:41 +0200)]
s3-printing: Fix vlp testprinter application.

Jeremy, we cannot just access cache_path() here without calling lp_load and
friends as well as parsing configfile from the commandline in order to make
"make test/selftest" find the correct conffile with path, etc.

I just changed it to pass the target tdbfilename as an argument, ok ?

Guenther

11 years agos3:build: extend the support fo Debian GNU/kFooBar to kOpenSolaris
Michael Adam [Fri, 8 May 2009 22:10:51 +0000 (00:10 +0200)]
s3:build: extend the support fo Debian GNU/kFooBar to kOpenSolaris

As suggested by Robert Millan.

Michael

11 years agos3:build: support non-linux gnu ports
Michael Adam [Thu, 30 Apr 2009 19:59:07 +0000 (21:59 +0200)]
s3:build: support non-linux gnu ports

This is based on a patch by the debian package maintainers,
adapted for the merged branch.

Michael

11 years agos3:loadparm: free the file_list at the start of loadparm
Michael Adam [Wed, 6 May 2009 00:25:08 +0000 (02:25 +0200)]
s3:loadparm: free the file_list at the start of loadparm

This should reduce the waste of memory when using "config file"
or "config backend". It also reduces the risk of triggering
reloads due to some old unused files being checked.

Michael

11 years agos3:loadparm: refactor freeing of file_list out into free_file_lists()
Michael Adam [Wed, 6 May 2009 00:09:56 +0000 (02:09 +0200)]
s3:loadparm: refactor freeing of file_list out into free_file_lists()

Michael

11 years agos3:proto.h: remove old param/params.c prototype
Michael Adam [Mon, 11 May 2009 05:43:07 +0000 (07:43 +0200)]
s3:proto.h: remove old param/params.c prototype

Michael

11 years agoFix warning about unused label with no sendfile.
Jeremy Allison [Tue, 12 May 2009 06:23:17 +0000 (23:23 -0700)]
Fix warning about unused label with no sendfile.
Jeremy.

11 years agoFix definition of smb_thread_once - must return int not void as
Jeremy Allison [Tue, 12 May 2009 05:33:32 +0000 (22:33 -0700)]
Fix definition of smb_thread_once - must return int not void as
it's used in a ? : comparison macro.
Jeremy.

11 years agoFix a bunch of compiler warnings about wrong format types.
Jeremy Allison [Tue, 12 May 2009 04:56:57 +0000 (21:56 -0700)]
Fix a bunch of compiler warnings about wrong format types.
Should make Solaris 10 builds look cleaner.
Jeremy.

11 years agoHopefully fix the buildfarm. Add some debug level 10 messages
Jeremy Allison [Tue, 12 May 2009 00:29:48 +0000 (17:29 -0700)]
Hopefully fix the buildfarm. Add some debug level 10 messages
I used to track down the vlp problem, change the vlp test printer
not to use a static path of /tmp/vlp.tdb for the virtual print
database (as this will eventually fill up). Cause it to use
a virtual print database inside the cachepath.
Jeremy.

11 years agoEnsure documentation matches the tdb_util function usage.
Jeremy Allison [Tue, 12 May 2009 00:29:16 +0000 (17:29 -0700)]
Ensure documentation matches the tdb_util function usage.
Jeremy.

11 years agos3-samr: implement _samr_RidToSid().
Günther Deschner [Fri, 8 May 2009 09:25:56 +0000 (11:25 +0200)]
s3-samr: implement _samr_RidToSid().

Guenther

11 years agos3-samr: Let _samr_TestPrivateFunctionsDomain() return NT_STATUS_NOT_SUPPORTED to...
Günther Deschner [Mon, 11 May 2009 21:47:37 +0000 (23:47 +0200)]
s3-samr: Let _samr_TestPrivateFunctionsDomain() return NT_STATUS_NOT_SUPPORTED to make RPC-SAMR happy.

Guenther

11 years agos4-smbtorture: skip SetMemberAttributesOfGroup in RPC-SAMR for s3 as well.
Günther Deschner [Mon, 11 May 2009 22:19:56 +0000 (00:19 +0200)]
s4-smbtorture: skip SetMemberAttributesOfGroup in RPC-SAMR for s3 as well.

Guenther

11 years agos4-smbtorture: Skip secdesc set calls for non-user objects in RPC-SAMR for Samba3.
Günther Deschner [Mon, 11 May 2009 21:46:45 +0000 (23:46 +0200)]
s4-smbtorture: Skip secdesc set calls for non-user objects in RPC-SAMR for Samba3.

Note that they are skipped for all objects while testing Samba4.

Guenther

11 years agos4-smbtorture: Fix order of assert args in test_TestPrivateFunctionsDomain() in RPC...
Günther Deschner [Mon, 11 May 2009 21:46:11 +0000 (23:46 +0200)]
s4-smbtorture: Fix order of assert args in test_TestPrivateFunctionsDomain() in RPC-SAMR.

Guenther

11 years agos4-smbtorture: switch to use torture_context in RPC-SAMR.
Günther Deschner [Mon, 11 May 2009 21:13:26 +0000 (23:13 +0200)]
s4-smbtorture: switch to use torture_context in RPC-SAMR.

Guenther

11 years agos4-smbtorture: remove trailing whitespace in RPC-SAMR.
Günther Deschner [Mon, 11 May 2009 20:44:58 +0000 (22:44 +0200)]
s4-smbtorture: remove trailing whitespace in RPC-SAMR.

Guenther

11 years agoFix some nonempty blank lines
Volker Lendecke [Mon, 11 May 2009 21:07:24 +0000 (23:07 +0200)]
Fix some nonempty blank lines

11 years agoCorrect typos; semicolons instead of commas
Derrell Lipman [Mon, 11 May 2009 18:16:52 +0000 (14:16 -0400)]
Correct typos; semicolons instead of commas

11 years agos3-samr: Fix Bug #5859, renaming of samr objects failed due to samr setuserinfo acces...
Günther Deschner [Mon, 11 May 2009 16:45:46 +0000 (18:45 +0200)]
s3-samr: Fix Bug #5859, renaming of samr objects failed due to samr setuserinfo access checks.

Torture test to follow...

Guenther

11 years agoAdd checks for non_root mode to help buildfarm spoolss tests.
Jeremy Allison [Mon, 11 May 2009 16:42:08 +0000 (09:42 -0700)]
Add checks for non_root mode to help buildfarm spoolss tests.
Reviewed by Guenther.
Jeremy.

11 years agos3-lsa: Fix _lsa_LookupNames2() server implementation which always returned a NULL...
Günther Deschner [Mon, 11 May 2009 16:27:40 +0000 (18:27 +0200)]
s3-lsa: Fix _lsa_LookupNames2() server implementation which always returned a NULL sid_array since 3.2.0.

Found by torture test.

This makes it possible to search for users while adding them to groups via
windows usermanager.

Guenther

11 years agos3-selftest: enable RPC-LSA-LOOKUPNAMES against Samba 3.
Günther Deschner [Mon, 11 May 2009 14:29:39 +0000 (16:29 +0200)]
s3-selftest: enable RPC-LSA-LOOKUPNAMES against Samba 3.

Guenther

11 years agos4-smbtorture: add very basic RPC-LSA-LOOKUPNAMES test.
Günther Deschner [Mon, 11 May 2009 14:28:42 +0000 (16:28 +0200)]
s4-smbtorture: add very basic RPC-LSA-LOOKUPNAMES test.

Guenther

11 years agos4-smbtorture: add optional very simple reply checks to lsa lookup name tests.
Günther Deschner [Mon, 11 May 2009 14:40:26 +0000 (16:40 +0200)]
s4-smbtorture: add optional very simple reply checks to lsa lookup name tests.

Guenther

11 years agos4:smb_server: return after we have processed an invalid smb2 request
Stefan Metzmacher [Mon, 11 May 2009 13:54:55 +0000 (15:54 +0200)]
s4:smb_server: return after we have processed an invalid smb2 request

metze

11 years agoMove SMB2 constants to a separate file
Volker Lendecke [Mon, 13 Apr 2009 20:26:46 +0000 (22:26 +0200)]
Move SMB2 constants to a separate file

11 years agoFix SMB2_CAP_DFS
Volker Lendecke [Sun, 12 Apr 2009 17:11:09 +0000 (19:11 +0200)]
Fix SMB2_CAP_DFS

11 years agos4-smbtorture: remove trailing whitespace in RPC-LSA test.
Günther Deschner [Mon, 11 May 2009 12:54:04 +0000 (14:54 +0200)]
s4-smbtorture: remove trailing whitespace in RPC-LSA test.

Guenther

11 years agos4-smbtorture: use struct torture_context in RPC-LSA.
Günther Deschner [Mon, 11 May 2009 12:51:41 +0000 (14:51 +0200)]
s4-smbtorture: use struct torture_context in RPC-LSA.

Guenther

11 years agos3-docs: document "net dom renamecomputer".
Günther Deschner [Mon, 11 May 2009 08:30:05 +0000 (10:30 +0200)]
s3-docs: document "net dom renamecomputer".

Guenther

11 years agos3-net: add "net dom renamecomputer" to rename machines in a domain.
Günther Deschner [Fri, 8 May 2009 19:56:17 +0000 (21:56 +0200)]
s3-net: add "net dom renamecomputer" to rename machines in a domain.

dmarkey, please test :)

Guenther

11 years agoUse bool instead of int for a boolean variable
Derrell Lipman [Mon, 11 May 2009 03:04:00 +0000 (23:04 -0400)]
Use bool instead of int for a boolean variable

11 years agoOptimize smb_thread_once usage by not calling it if known already called
Derrell Lipman [Mon, 11 May 2009 02:58:12 +0000 (22:58 -0400)]
Optimize smb_thread_once usage by not calling it if known already called

- The macro SMB_THREAD_ONCE now tests whether the "once" variable is already
  set, and if so avoids calling smb_thread_once().

Derrell

11 years agoPanic upon mutex lock or unlock failure
Derrell Lipman [Mon, 11 May 2009 02:40:20 +0000 (22:40 -0400)]
Panic upon mutex lock or unlock failure

- It's a serious error if we can't lock or unlock a mutex in
  smb_thread_once(). Panic instead of just displaying a DEBUG message.

Derrell

11 years agoProvide a libsmbclient interface for programs requiring threads
Derrell Lipman [Mon, 11 May 2009 02:31:37 +0000 (22:31 -0400)]
Provide a libsmbclient interface for programs requiring threads

- This adds two functions: smbc_thread_posix() which provides access to the
  internal threading implementation using pthread; and smbc_thread_impl()
  where the user provides each of the functions required by Samba, to give
  access to the thread implementation's native capabilities.

Derrell

11 years agoDon't require external use of internal enum smb_thread_lock_type
Derrell Lipman [Mon, 11 May 2009 02:27:54 +0000 (22:27 -0400)]
Don't require external use of internal enum smb_thread_lock_type

- Internally, when locking or unlocking a mutex, we'll pass one of the
  values of enum smb_thread_lock_type. That enum is not available to users
  providing a thread implementation. Externally, we'll document the integer
  values which will be passed to their lock_mutex function, but not require
  them to access our internal header file.

Derrell

11 years agoReplace external thread "once" with an internal implementation
Derrell Lipman [Mon, 11 May 2009 01:55:23 +0000 (21:55 -0400)]
Replace external thread "once" with an internal implementation

Jeremy, please check...

- I'm in the process of providing an interface in libsmbclient to the
  recently-added threading capabilities. In the process, I discovered that
  different thread implementations have varying types for the variable passed
  to the thread_impl_once() function. pthreads, for example, uses type
  pthread_once_t. Since Samba needs to internally declare these variables, it
  would need to know the exact type required by each thread implementation's
  function. After considering multiple methods of obtaining an appropriately
  sized variable, I decided that for the basic "once" functionality required
  by Samba, it would be much simpler to just implement our own "once"
  functionality. We don't require cancellation points et all. This commit adds
  an smb_thread_once() function that is implemented using an internal
  mutex. The mutex itself uses the implementation's create_mutex
  function. This eliminates the need for the user to provide a smb_thread_once
  function pointer and the entire issue of that function's first parameter.

Derrell

11 years agoFix an unitialized variable warning
Volker Lendecke [Sun, 10 May 2009 05:42:55 +0000 (07:42 +0200)]
Fix an unitialized variable warning

11 years agowb_int_trans -> wb_simple_trans in wbclient.c
Volker Lendecke [Sat, 9 May 2009 19:12:33 +0000 (21:12 +0200)]
wb_int_trans -> wb_simple_trans in wbclient.c

11 years agoAdd wb_simple_trans_send/recv
Volker Lendecke [Sat, 9 May 2009 19:01:09 +0000 (21:01 +0200)]
Add wb_simple_trans_send/recv

11 years agoPass also sername to check password script
Simo Sorce [Sat, 9 May 2009 15:26:14 +0000 (11:26 -0400)]
Pass also sername to check password script

11 years agoFix the mangle1 test
Volker Lendecke [Sat, 9 May 2009 11:46:08 +0000 (13:46 +0200)]
Fix the mangle1 test

11 years agoDo not call SMB_VFS_GET_REAL_FILENAME if the name is mangled
Volker Lendecke [Sat, 9 May 2009 09:12:52 +0000 (11:12 +0200)]
Do not call SMB_VFS_GET_REAL_FILENAME if the name is mangled

The GPFS get_real_file name does not know about mangled names. Tim, if onefs
does not either, you need this bugfix :-)

In case onefs does 8.3 names, we need to pass the mangled flag down to
SMB_VFS_GET_REAL_FILENAME to give GPFS a chance say ENOTSUPP and do the
fallback.

11 years agos3:libsmb: fix layering of cli_ntrename_internal and its callers
Stefan Metzmacher [Fri, 8 May 2009 16:40:35 +0000 (18:40 +0200)]
s3:libsmb: fix layering of cli_ntrename_internal and its callers

It's easier to have cli_ntrename_internal as a semetric async
tevent_req function. cli_ntrename() and cli_nt_hardlink() should
be callers on top of cli_ntrename_internal().

metze

11 years agos3: Fix chained sesssetupAndX/tconn messages
Tim Prouty [Wed, 25 Mar 2009 00:24:55 +0000 (00:24 +0000)]
s3: Fix chained sesssetupAndX/tconn messages

A sesssetupAndX chained with a tconn will not correctly set the TID in
the response header.  I'm seeing an XP client send this chained
sesssetup/tconn when samba has security = share.  Samba's current
behavior is to return a TID of 0 in the smb header rather than the
actual TID.  This patch also updates the UID in the header as well.

11 years agos4-smbtorture: avoid secdesc test on connect handle in RPC-SAMR-USERS for Samba3.
Günther Deschner [Fri, 8 May 2009 22:46:17 +0000 (00:46 +0200)]
s4-smbtorture: avoid secdesc test on connect handle in RPC-SAMR-USERS for Samba3.

With this, I think, we pass RPC-SAMR-USERS.

Guenther

11 years agos3-samr: Fix SetUserInfo level 16 and 21 w.r.t. ACB_AUTOLOCK acct_flag.
Günther Deschner [Fri, 8 May 2009 22:03:50 +0000 (00:03 +0200)]
s3-samr: Fix SetUserInfo level 16 and 21 w.r.t. ACB_AUTOLOCK acct_flag.

It is not allowed to *set* this flag remotely if it has been not set already.

Found by torture test.

Guenther

11 years agos3-samr: Fix SetUserInfo level 7 when there has been no name change.
Günther Deschner [Fri, 8 May 2009 22:02:00 +0000 (00:02 +0200)]
s3-samr: Fix SetUserInfo level 7 when there has been no name change.

Found by torture test.

Guenther

11 years agos3-selftest: enable running RPC-SAMR-USERS against Samba3.
Günther Deschner [Fri, 8 May 2009 20:23:51 +0000 (22:23 +0200)]
s3-selftest: enable running RPC-SAMR-USERS against Samba3.

Guenther

11 years agos4-smbtorture: skip unsupported ACB bits for Samba3 in RPC-SAMR-USER.
Günther Deschner [Fri, 8 May 2009 20:20:38 +0000 (22:20 +0200)]
s4-smbtorture: skip unsupported ACB bits for Samba3 in RPC-SAMR-USER.

Guenther

11 years agos3-samr: more accurateness in _samr_SetDomainInfo().
Günther Deschner [Fri, 8 May 2009 09:24:35 +0000 (11:24 +0200)]
s3-samr: more accurateness in _samr_SetDomainInfo().

Guenther

11 years agos4-smbtorture: Support timestamp handling for Samba3 in RPC-SAMR-USERS.
Günther Deschner [Fri, 8 May 2009 20:01:55 +0000 (22:01 +0200)]
s4-smbtorture: Support timestamp handling for Samba3 in RPC-SAMR-USERS.

Timestamps in passdb (currently) only have second granularity.

Guenther

11 years agoFix bug #6330 - DFS doesn't work on AIX. Jeremy.
Jeremy Allison [Fri, 8 May 2009 18:31:34 +0000 (11:31 -0700)]
Fix bug #6330 - DFS doesn't work on AIX. Jeremy.

11 years agoExpand the comment explaining why user_in_group_sid is
Jeremy Allison [Fri, 8 May 2009 17:11:38 +0000 (10:11 -0700)]
Expand the comment explaining why user_in_group_sid is
not reliable for winbindd users from foreign domains.
Jeremy.

11 years agos3:smbd: fix posix acls when setting an ACL without explicit ACE for the owner (bug...
Stefan Metzmacher [Fri, 8 May 2009 12:33:49 +0000 (14:33 +0200)]
s3:smbd: fix posix acls when setting an ACL without explicit ACE for the owner (bug#2346)

The problem of bug #2346 remains for users exported by
winbindd, because create_token_from_username() just fakes
the token when the user is not in the local sam domain. This causes
user_in_group_sid() to give totally wrong results.
In uid_entry_in_group() we need to check if we already
have the full unix token in the current_user struct.
If so we should use the current_user unix token,
instead of doing a very complex user_in_group_sid()
which doesn't give reliable results anyway.

metze

11 years agos3:smbd: fix the fix for mapped IPv4 address handling in release_ip().
Michael Adam [Fri, 8 May 2009 13:13:21 +0000 (15:13 +0200)]
s3:smbd: fix the fix for mapped IPv4 address handling in release_ip().

It was too late... Thanks Metze for noticing.

Michael

11 years agos3-selftest: run RPC-LSA-GETUSER against Samba 3.
Günther Deschner [Fri, 8 May 2009 09:26:57 +0000 (11:26 +0200)]
s3-selftest: run RPC-LSA-GETUSER against Samba 3.

Guenther

11 years agos4-smbtorture: Fix printf info-level mismatch in RPC-SAMR.
Günther Deschner [Fri, 8 May 2009 07:56:40 +0000 (09:56 +0200)]
s4-smbtorture: Fix printf info-level mismatch in RPC-SAMR.

Guenther

11 years agos3-samr: implement more info levels in _samr_QueryDomainInfo().
Günther Deschner [Fri, 8 May 2009 07:55:10 +0000 (09:55 +0200)]
s3-samr: implement more info levels in _samr_QueryDomainInfo().

Gets us closer to pass RPC-SAMR.

Guenther

11 years agos3-samr: Fix potential memory leak in _samr_ChangePasswordUser().
Günther Deschner [Thu, 7 May 2009 23:23:54 +0000 (01:23 +0200)]
s3-samr: Fix potential memory leak in _samr_ChangePasswordUser().

Guenther

11 years agos4:loadparm: fix a comment typo. and line wrapping.
Michael Adam [Thu, 7 May 2009 14:49:58 +0000 (16:49 +0200)]
s4:loadparm: fix a comment typo. and line wrapping.

Michael

11 years agos4:loadparm: fix brace indentation and add brace for clarity
Michael Adam [Thu, 7 May 2009 14:37:11 +0000 (16:37 +0200)]
s4:loadparm: fix brace indentation and add brace for clarity

Michael

11 years agos3: make release_ip() call (ctdb) cope with IPv4 mapped addresses
Michael Adam [Thu, 7 May 2009 23:11:43 +0000 (01:11 +0200)]
s3: make release_ip() call (ctdb) cope with IPv4 mapped addresses

Michael

11 years agos3-selftest: finally enable RPC-SAMR-PASSWORDS which samba3 now passes.
Günther Deschner [Thu, 7 May 2009 22:31:11 +0000 (00:31 +0200)]
s3-selftest: finally enable RPC-SAMR-PASSWORDS which samba3 now passes.

Guenther

11 years agos4-smbtorture: avoid acct_flags check at the end of RPC-SAMR-PASSWORDS for Samba3.
Günther Deschner [Thu, 7 May 2009 22:30:11 +0000 (00:30 +0200)]
s4-smbtorture: avoid acct_flags check at the end of RPC-SAMR-PASSWORDS for Samba3.

I don't get this, why would the account suddenly get ACB_PWNOTREQ ?

Guenther

11 years agos3-selftest: need to enable lanman auth in order make RPC-SAMR-PASSWORDS pass.
Günther Deschner [Thu, 7 May 2009 22:18:28 +0000 (00:18 +0200)]
s3-selftest: need to enable lanman auth in order make RPC-SAMR-PASSWORDS pass.

Guenther

11 years agos3-samr: Do not leak information whether a user exist or not in pwd change calls.
Günther Deschner [Thu, 7 May 2009 21:56:22 +0000 (23:56 +0200)]
s3-samr: Do not leak information whether a user exist or not in pwd change calls.

Found by torture test.

Guenther

11 years agos3-samr: implement _samr_ChangePasswordUser().
Günther Deschner [Thu, 7 May 2009 22:16:43 +0000 (00:16 +0200)]
s3-samr: implement _samr_ChangePasswordUser().

This is vastly copied from samba4 samr server.

Guenther

11 years agos3-samr: implement _samr_OemChangePasswordUser2().
Günther Deschner [Thu, 7 May 2009 21:26:54 +0000 (23:26 +0200)]
s3-samr: implement _samr_OemChangePasswordUser2().

Guenther

11 years agos3-samr: disable check for ACB_DISABLED in check_oem_password().
Günther Deschner [Thu, 7 May 2009 21:54:58 +0000 (23:54 +0200)]
s3-samr: disable check for ACB_DISABLED in check_oem_password().

It is a bad idea to just tell everyone that an account is disabled without
really having checked the password first.

Found by torture test.

Guenther

11 years agos3-samr: rework check_oem_password() to take a struct samu, not to return one.
Günther Deschner [Thu, 7 May 2009 21:22:26 +0000 (23:22 +0200)]
s3-samr: rework check_oem_password() to take a struct samu, not to return one.

Guenther

11 years agos4-smbtorture: prepare for running RPC-SAMR-USERS against samba3.
Günther Deschner [Thu, 7 May 2009 19:47:47 +0000 (21:47 +0200)]
s4-smbtorture: prepare for running RPC-SAMR-USERS against samba3.

In Samba 3 there are no pdb calls to store comments, codepages and countrycodes
(yet).

Guenther

11 years agos3-samr: Let _samr_TestPrivateFunctionsUser() return not supported.
Günther Deschner [Thu, 7 May 2009 16:42:28 +0000 (18:42 +0200)]
s3-samr: Let _samr_TestPrivateFunctionsUser() return not supported.

This is to get us closer to pass RPC-SAMR-USERS.

Guenther

11 years agos3-samr: Do not return users in _samr_QueryDisplayInfo() for builtin domain.
Günther Deschner [Thu, 7 May 2009 16:40:39 +0000 (18:40 +0200)]
s3-samr: Do not return users in _samr_QueryDisplayInfo() for builtin domain.

Found by torture test.

Guenther

11 years agos3-samr: let set_user_info_16 and 20 follow the same pattern as all other levels.
Günther Deschner [Thu, 7 May 2009 19:45:51 +0000 (21:45 +0200)]
s3-samr: let set_user_info_16 and 20 follow the same pattern as all other levels.

Guenther

11 years agos3-samr: support some more info levels in samr_SetUserInfo calls.
Günther Deschner [Thu, 7 May 2009 15:06:26 +0000 (17:06 +0200)]
s3-samr: support some more info levels in samr_SetUserInfo calls.

Guenther

11 years agos3-samr: support some more info levels in samr_QueryUser calls.
Günther Deschner [Thu, 7 May 2009 15:05:49 +0000 (17:05 +0200)]
s3-samr: support some more info levels in samr_QueryUser calls.

Guenther

11 years agos3/ldap: also handle DirX return codes
Björn Jacke [Thu, 7 May 2009 15:50:34 +0000 (17:50 +0200)]
s3/ldap: also handle DirX return codes

11 years agos3:configure: "test" only takes one "="
Björn Jacke [Sat, 4 Apr 2009 09:21:01 +0000 (11:21 +0200)]
s3:configure: "test" only takes one "="

11 years agoFix some type-punned warnings
Volker Lendecke [Thu, 7 May 2009 21:07:55 +0000 (23:07 +0200)]
Fix some type-punned warnings

11 years agoRemove a misleading comment
Volker Lendecke [Wed, 6 May 2009 13:12:27 +0000 (15:12 +0200)]
Remove a misleading comment

11 years agoFix some nonempty blank lines
Volker Lendecke [Thu, 7 May 2009 21:25:49 +0000 (23:25 +0200)]
Fix some nonempty blank lines

11 years agoConvert lib/wb_reqtrans.c to unix calling conventions
Volker Lendecke [Wed, 6 May 2009 13:10:00 +0000 (15:10 +0200)]
Convert lib/wb_reqtrans.c to unix calling conventions

11 years agoAdapt wb_reqtrans to "recent" coding conventions
Volker Lendecke [Wed, 6 May 2009 12:52:17 +0000 (14:52 +0200)]
Adapt wb_reqtrans to "recent" coding conventions

11 years agos3-auth: use full 16byte session key in make_user_info_netlogon_interactive().
Günther Deschner [Thu, 7 May 2009 11:36:52 +0000 (13:36 +0200)]
s3-auth: use full 16byte session key in make_user_info_netlogon_interactive().

Patch from Jeremy.

With this patch, I was able to join Windows 7 RC to a Samba3 DC, and login into a
Samba 3 Domain.

There are still two registry settings required:

        HKLM\System\CCS\Services\LanmanWorkstation\Parameters
            DWORD  DomainCompatibilityMode = 1
    DWORD  DNSNameResolutionRequired = 0

Do *not* modify the other netlogon registry parameters that were passed around,
they weaken security.

Guenther
(cherry picked from commit b5097d54cb74ca0ea328f9e029562f65f4a01134)

11 years agoAsync API needs all parameters to be kept around until sent,
Jeremy Allison [Thu, 7 May 2009 17:01:28 +0000 (10:01 -0700)]
Async API needs all parameters to be kept around until sent,
ensure they're attached to the state structure. Thanks to Metze
for pointing this out.
Jeremy.

11 years agoFix a typo
Volker Lendecke [Thu, 7 May 2009 14:24:54 +0000 (16:24 +0200)]
Fix a typo

11 years agoAdd simple test chaining up sesssetup and tcon
Volker Lendecke [Thu, 7 May 2009 14:24:46 +0000 (16:24 +0200)]
Add simple test chaining up sesssetup and tcon

11 years agoMake cli_tcon_andx chainable
Volker Lendecke [Thu, 7 May 2009 14:24:04 +0000 (16:24 +0200)]
Make cli_tcon_andx chainable

11 years agoMake cli_session_setup_guest chainable
Volker Lendecke [Thu, 7 May 2009 14:23:27 +0000 (16:23 +0200)]
Make cli_session_setup_guest chainable

11 years agos3-samr: Fix _samr_Connect5(). In error case it still needs to return empty info1.
Günther Deschner [Thu, 7 May 2009 12:19:43 +0000 (14:19 +0200)]
s3-samr: Fix _samr_Connect5(). In error case it still needs to return empty info1.

Guenther

11 years agoFix missing backtick.
Praveen Arimbrathodiyil [Thu, 7 May 2009 12:16:19 +0000 (14:16 +0200)]
Fix missing backtick.

11 years agos3-rpcclient: rework enumdrivers call a bit to allow queries like win7 does.
Günther Deschner [Thu, 7 May 2009 11:35:00 +0000 (13:35 +0200)]
s3-rpcclient: rework enumdrivers call a bit to allow queries like win7 does.

Guenther

11 years agos3-credentials: protect netlogon_creds_server_step() against NULL creds.
Günther Deschner [Thu, 7 May 2009 11:32:41 +0000 (13:32 +0200)]
s3-credentials: protect netlogon_creds_server_step() against NULL creds.

Found by SCHANNEL torture tests.

Guenther

11 years agos3-selftest: run RPC-SCHANNEL, RPC-SCHANNEL2 and RPC-BENCH-SCHANNEL1 against Samba3.
Günther Deschner [Thu, 7 May 2009 11:06:03 +0000 (13:06 +0200)]
s3-selftest: run RPC-SCHANNEL, RPC-SCHANNEL2 and RPC-BENCH-SCHANNEL1 against Samba3.

Guenther

11 years agos4-smbtorture: Avoid failing RPC-SCHANNEL when testing lsa_GetUserName behaviour...
Günther Deschner [Thu, 7 May 2009 11:05:13 +0000 (13:05 +0200)]
s4-smbtorture: Avoid failing RPC-SCHANNEL when testing lsa_GetUserName behaviour against Samba 3.

Guenther

11 years agoFix bug 6336: "net groupmap set" segfaults
Volker Lendecke [Thu, 7 May 2009 08:09:32 +0000 (10:09 +0200)]
Fix bug 6336: "net groupmap set" segfaults

11 years agotevent: fix typo async_req_done() => tevent_req_done()
Stefan Metzmacher [Fri, 1 May 2009 15:45:39 +0000 (17:45 +0200)]
tevent: fix typo async_req_done() => tevent_req_done()

metze