18 years agoUpdating SuSE build files for Samba3
John Terpstra [Tue, 12 Aug 2003 01:30:40 +0000 (01:30 +0000)]
Updating SuSE build files for Samba3

18 years agoDeleting obsoleted files in preparation for addition of new files.
John Terpstra [Tue, 12 Aug 2003 01:27:23 +0000 (01:27 +0000)]
Deleting obsoleted files in preparation for addition of new files.

18 years agoStylesheet for processing samba docs
Jelmer Vernooij [Tue, 12 Aug 2003 01:19:48 +0000 (01:19 +0000)]
Stylesheet for processing samba docs

18 years agoAdd DTD for the samba-specific docbook tags
Jelmer Vernooij [Tue, 12 Aug 2003 01:18:20 +0000 (01:18 +0000)]
Add DTD for the samba-specific docbook tags

18 years agoFix client autonegotiate signing.
Volker Lendecke [Tue, 12 Aug 2003 01:15:23 +0000 (01:15 +0000)]
Fix client autonegotiate signing.

18 years agoFix for bug 269. Change wbinfo and ntlm_auth to convert domain, username
Tim Potter [Tue, 12 Aug 2003 00:46:15 +0000 (00:46 +0000)]
Fix for bug 269.  Change wbinfo and ntlm_auth to convert domain, username
and workstation to utf8 before sending the winbindd request.  Also, don't
continue when the call to pull_utf8() fails but rather return a winbind
error.  (This is what was causing the crash)

18 years agoFallback to not using NTLMv2 is extended security not supported.
Jeremy Allison [Mon, 11 Aug 2003 21:44:19 +0000 (21:44 +0000)]
Fallback to not using NTLMv2 is extended security not supported.

18 years agoI think this is the one to check...
Volker Lendecke [Mon, 11 Aug 2003 21:00:13 +0000 (21:00 +0000)]
I think this is the one to check...


18 years agoRevert the latest fix. Need to investigate further.
Volker Lendecke [Mon, 11 Aug 2003 20:51:47 +0000 (20:51 +0000)]
Revert the latest fix. Need to investigate further.


18 years agoMake client signing auto.
Jeremy Allison [Mon, 11 Aug 2003 20:50:42 +0000 (20:50 +0000)]
Make client signing auto.

18 years agoFix a segfault in ntlm_auth when we can't find a domain or hostname.
Volker Lendecke [Mon, 11 Aug 2003 20:40:39 +0000 (20:40 +0000)]
Fix a segfault in ntlm_auth when we can't find a domain or hostname.


18 years agoApply some const
Volker Lendecke [Mon, 11 Aug 2003 19:11:43 +0000 (19:11 +0000)]
Apply some const

18 years agoFix typos.
Volker Lendecke [Mon, 11 Aug 2003 17:42:17 +0000 (17:42 +0000)]
Fix typos.


18 years agoMention security=ads in introductory paragraph too
Alexander Bokovoy [Mon, 11 Aug 2003 08:05:59 +0000 (08:05 +0000)]
Mention security=ads in introductory paragraph too

18 years agofix bug #281 by surrounding pdb_getgrgid() with become/unbecome_root()
Gerald Carter [Mon, 11 Aug 2003 07:05:23 +0000 (07:05 +0000)]
fix bug #281 by surrounding pdb_getgrgid() with become/unbecome_root()

18 years agoadding '.' special name to --domain to mean our domain
Gerald Carter [Mon, 11 Aug 2003 06:36:30 +0000 (06:36 +0000)]
adding '.' special name to --domain to mean our domain

18 years agoadding missing options (mine) to wbinfo
Gerald Carter [Mon, 11 Aug 2003 06:30:22 +0000 (06:30 +0000)]
adding missing options (mine) to wbinfo

18 years agoUpdate upgrading docs
Jelmer Vernooij [Mon, 11 Aug 2003 01:41:56 +0000 (01:41 +0000)]
Update upgrading docs

18 years agoImprove MySQL library detection, add support for MySQL 4
Jelmer Vernooij [Mon, 11 Aug 2003 00:31:28 +0000 (00:31 +0000)]
Improve MySQL library detection, add support for MySQL 4

18 years agonot used
Gerald Carter [Sun, 10 Aug 2003 22:11:26 +0000 (22:11 +0000)]
not used

18 years agoadd --domain=DOMAINNAME to wbinfo
Gerald Carter [Sun, 10 Aug 2003 22:01:11 +0000 (22:01 +0000)]
add --domain=DOMAINNAME to wbinfo

Add support for geting the sequence number, list of users, and list
of groups for a specific domain (assuming on reported back by
wbinfo -m)

wbinfo -u --domain=DOA

18 years agoWe get the server and workgroup list only over port 139. Fall back to that
Volker Lendecke [Sun, 10 Aug 2003 21:43:28 +0000 (21:43 +0000)]
We get the server and workgroup list only over port 139. Fall back to that
and if NetBIOS over TCP/IP is disabled, give an error message.

Fixes Bug #284


18 years agoFix style
Jelmer Vernooij [Sun, 10 Aug 2003 20:41:27 +0000 (20:41 +0000)]
Fix style

18 years agoStore the server domain from the ntlmssp challenge in the client struct
Volker Lendecke [Sun, 10 Aug 2003 20:18:05 +0000 (20:18 +0000)]
Store the server domain from the ntlmssp challenge in the client struct
to be able to ask a LMB for the servers in its workgroup. Against
W2k this only works on port 139....


18 years agofix MS-DFS (my bug) stupid return code error that cose me more time
Gerald Carter [Sun, 10 Aug 2003 06:45:04 +0000 (06:45 +0000)]
fix MS-DFS (my bug)  stupid return code error that cose me more time
that I would like to admit.

18 years agofix for BUG #267 (problem with supplementary groups).
Gerald Carter [Sat, 9 Aug 2003 23:12:35 +0000 (23:12 +0000)]
fix for BUG #267 (problem with supplementary groups).
Use winbindd to get the group list if possible since we already
know it from netsamlogon_cache.tdb. More effecient than letting
libc call getgrent() to get seconary groups.

Tested by Ken Cross.

18 years agoupdating smb.conf manpage to reflect changes in ./configure options
Gerald Carter [Sat, 9 Aug 2003 23:01:35 +0000 (23:01 +0000)]
updating smb.conf manpage to reflect changes in ./configure options

18 years agofix 2 bugs:
Gerald Carter [Fri, 8 Aug 2003 23:53:13 +0000 (23:53 +0000)]
fix 2 bugs:

  1)  don't ask trusted DC's for a list of trusted domains.  This causes
      us to treat non-transitive ones as if they were transitive.  Not
      needed anyways

  2)  Fix dc lookup bug where we would always try to use DNS to resolve
      the DC's for a domain (even if it was a trusted NT4 domain).

18 years agoFormat tidyup.
Jeremy Allison [Fri, 8 Aug 2003 23:09:09 +0000 (23:09 +0000)]
Format tidyup.

18 years agoTurn on client ntlmv2 by default.
Jeremy Allison [Fri, 8 Aug 2003 22:19:09 +0000 (22:19 +0000)]
Turn on client ntlmv2 by default.

18 years agoRPC fix from Ronan Waide <>. Tested with rpcecho.
Jeremy Allison [Fri, 8 Aug 2003 17:08:35 +0000 (17:08 +0000)]
RPC fix from Ronan Waide <>. Tested with rpcecho.

18 years agoneed to be able to connect to a domain member as a local account; don't always map...
Gerald Carter [Fri, 8 Aug 2003 05:11:11 +0000 (05:11 +0000)]
need to be able to connect to a domain member as a local account; don't always map to the domain name

18 years agoneed to make sure that the connection struct mem_ctx is initialized and destroyed
Gerald Carter [Fri, 8 Aug 2003 05:10:12 +0000 (05:10 +0000)]
need to make sure that the connection struct mem_ctx is initialized and destroyed

18 years agoAdded by request of "Stefan (metze) Metzmacher" <>.
Jeremy Allison [Fri, 8 Aug 2003 00:53:46 +0000 (00:53 +0000)]
Added by request of "Stefan (metze) Metzmacher" <>.

18 years agoTest modules for shadow copy by "Stefan (metze) Metzmacher" <>.
Jeremy Allison [Thu, 7 Aug 2003 21:49:01 +0000 (21:49 +0000)]
Test modules for shadow copy by "Stefan (metze) Metzmacher" <>.

18 years agoShadow copy API - Original work by "Ken Cross" <>, adapted
Jeremy Allison [Thu, 7 Aug 2003 21:47:46 +0000 (21:47 +0000)]
Shadow copy API - Original work by "Ken Cross" <>, adapted
into a patch by "Stefan (metze) Metzmacher" <>.

18 years agoAn oplock break reply from the client causes the sequence number to be
Jeremy Allison [Thu, 7 Aug 2003 05:36:08 +0000 (05:36 +0000)]
An oplock break reply from the client causes the sequence number to be
updated by 2 if there is no open reply outstanding, else by one....
Yes - this makes no sense....

18 years agoadding generic docs for defining VFS module options
Gerald Carter [Thu, 7 Aug 2003 05:00:51 +0000 (05:00 +0000)]
adding generic docs for defining VFS module options

18 years agoTurns out I had my packet sequences wrong for oplock break code.
Jeremy Allison [Thu, 7 Aug 2003 02:59:52 +0000 (02:59 +0000)]
Turns out I had my packet sequences wrong for oplock break code.
I was storing the mid of the oplock break - I should have been
storing the mid from the open. There are thus 2 types of deferred
packet sequence returns - ones that increment the sequence number
(returns from oplock causing opens) and ones that don't (change notify
returns etc). Running with signing forced on does lead to some
interesting tests :-).

18 years agoCosmetic fix from
Jeremy Allison [Thu, 7 Aug 2003 01:04:57 +0000 (01:04 +0000)]
Cosmetic fix from

18 years agoPatch from to print out Port Type.
Jeremy Allison [Thu, 7 Aug 2003 00:55:35 +0000 (00:55 +0000)]
Patch from to print out Port Type.

18 years agoEnsure smbclient obeys -s smb.conf option.
Jeremy Allison [Wed, 6 Aug 2003 22:45:46 +0000 (22:45 +0000)]
Ensure smbclient obeys -s smb.conf option.

18 years agoReversed replacement. Oops.
Jeremy Allison [Wed, 6 Aug 2003 21:31:11 +0000 (21:31 +0000)]
Reversed replacement. Oops.

18 years agoAnal formatting tidyup :-).
Jeremy Allison [Wed, 6 Aug 2003 20:01:31 +0000 (20:01 +0000)]
Anal formatting tidyup :-).

18 years agoGet rid of MAXPATHLEN, move to standard PATH_MAX.
Jeremy Allison [Wed, 6 Aug 2003 19:30:42 +0000 (19:30 +0000)]
Get rid of MAXPATHLEN, move to standard PATH_MAX.

18 years agofix bug #208; have to get the gid of the user's primary group for %G
Gerald Carter [Wed, 6 Aug 2003 19:16:17 +0000 (19:16 +0000)]
fix bug #208; have to get the gid of the user's primary group for %G

18 years agorework winbindd_accountdb_init() to reduce error messages in the log
Gerald Carter [Wed, 6 Aug 2003 18:01:39 +0000 (18:01 +0000)]
rework winbindd_accountdb_init() to reduce error messages in the log

18 years agoWhen doing 'net groupmap add', default to algorithmic mapping for the rid.
Volker Lendecke [Wed, 6 Aug 2003 09:24:11 +0000 (09:24 +0000)]
When doing 'net groupmap add', default to algorithmic mapping for the rid.


18 years agoSpelling.
Tim Potter [Wed, 6 Aug 2003 01:14:51 +0000 (01:14 +0000)]

18 years agooops; fix typo. Noticed by gcc warning
Gerald Carter [Wed, 6 Aug 2003 00:06:37 +0000 (00:06 +0000)]
oops; fix typo.  Noticed by gcc warning

18 years agofix bug #245; local_lookupsid() needed to make a getpwuid() call to get the username...
Gerald Carter [Tue, 5 Aug 2003 23:24:14 +0000 (23:24 +0000)]
fix bug #245; local_lookupsid() needed to make a getpwuid() call to get the username instead of making up unix_user.##

18 years agoChanges to make gss-spnego ntlmssp client work against W2k AD.
Volker Lendecke [Mon, 4 Aug 2003 13:10:43 +0000 (13:10 +0000)]
Changes to make gss-spnego ntlmssp client work against W2k AD.

Now I know where the mechListMIC changes came from: Ethereal ;-)


18 years agoFix unused variable warning.
Tim Potter [Mon, 4 Aug 2003 06:16:03 +0000 (06:16 +0000)]
Fix unused variable warning.

18 years agoMemory leak fix for create_rpc_bind_req()
Tim Potter [Mon, 4 Aug 2003 02:51:30 +0000 (02:51 +0000)]
Memory leak fix for create_rpc_bind_req()

18 years agoMore patches from Brett:
Tim Potter [Mon, 4 Aug 2003 00:50:00 +0000 (00:50 +0000)]
More patches from Brett:

  - remove 'if(mem_ctx)' tests prior to 'talloc_destroy' call to make
consistent with other modules; 'talloc_destroy' already test for NULL

  - initialize PyObject* result pointers to NULL in function
declarations; enables removal of redundant NULL assignments.

  - use local scope TALLOC_CTX in lsa_lookup_names to prevent unbounded
memory growth during python policy object lifetime.

  - change context name string used in lsa_lookup_sids from
'lsa_open_policy' to 'lsa_lookup_sids' (cut'npaste oversight from
previous patch)

  - change docstring to match module name (apparently another cut'npaste

18 years agoFix memory leak in py_smb_set_setdesc()
Tim Potter [Mon, 4 Aug 2003 00:48:49 +0000 (00:48 +0000)]
Fix memory leak in py_smb_set_setdesc()

Consistency fixups in py_smb_query_secdesc()

Thanks to Brett A. Funderburg for these patches.

18 years agoFix up #defines around utmp_host and utmp_name. Noticed by
Jeremy Allison [Sun, 3 Aug 2003 18:50:00 +0000 (18:50 +0000)]
Fix up #defines around utmp_host and utmp_name. Noticed by

18 years agoOutput message saying "signed connect" instead of just connect when signing
Jeremy Allison [Sun, 3 Aug 2003 07:20:05 +0000 (07:20 +0000)]
Output message saying "signed connect" instead of just connect when signing
is active.

18 years agoFix oplock break detection code on incoming oplock break responses. This
Jeremy Allison [Sun, 3 Aug 2003 07:12:46 +0000 (07:12 +0000)]
Fix oplock break detection code on incoming oplock break responses. This
fixes signing for oplocks.

18 years agoRemoved duplicated file, no longer in use. Note: profiles.1.xml is still
John Terpstra [Sun, 3 Aug 2003 05:10:57 +0000 (05:10 +0000)]
Removed duplicated file, no longer in use. Note: profiles.1.xml is still
present and relevant.

18 years agoChanged "winbind uid/gid" to "idmap uid/gid"
John Terpstra [Sun, 3 Aug 2003 05:09:19 +0000 (05:09 +0000)]
Changed "winbind uid/gid" to "idmap uid/gid"

18 years agomake sure to initialize the backend methods when enumerating sequence numbers; report...
Gerald Carter [Sat, 2 Aug 2003 18:15:33 +0000 (18:15 +0000)]
make sure to initialize the backend methods when enumerating sequence numbers; reported by Ken Cross

18 years agoEnsure we don't leak any sign records on cancel of pending requests.
Jeremy Allison [Sat, 2 Aug 2003 08:48:01 +0000 (08:48 +0000)]
Ensure we don't leak any sign records on cancel of pending requests.

18 years agoOnly look for mid sign records on incoming packets for oplock break replies.
Jeremy Allison [Sat, 2 Aug 2003 08:38:34 +0000 (08:38 +0000)]
Only look for mid sign records on incoming packets for oplock break replies.
Otherwise we find spurious mid sign records on reply_ntcancel calls (they cancel
by mid). That took a *lot* of tracking down. I still need to remove the mid
records from the sign state on reply_ntcancel to avoid leaking memory....

18 years agoMore fixes for client and server side signing. Ensure sequence numbers
Jeremy Allison [Sat, 2 Aug 2003 07:07:38 +0000 (07:07 +0000)]
More fixes for client and server side signing. Ensure sequence numbers
are updated correctly on returning an error for server trans streams.
Ensure we turn off client trans streams on error.

18 years agoLeave the packet sequence checkers enabled whilst I track down a smbclient -> smbd
Jeremy Allison [Sat, 2 Aug 2003 03:12:39 +0000 (03:12 +0000)]
Leave the packet sequence checkers enabled whilst I track down a smbclient -> smbd
sequence number problem.

18 years agoAdd the same signing code to the server. Ensure we use identical session
Jeremy Allison [Sat, 2 Aug 2003 03:06:07 +0000 (03:06 +0000)]
Add the same signing code to the server. Ensure we use identical session
numbers and MIDs when in trans/trans2/nttrans code.

18 years agoCorrect fix (removed the earlier band-aid) for what I thought was a signing
Jeremy Allison [Sat, 2 Aug 2003 00:29:45 +0000 (00:29 +0000)]
Correct fix (removed the earlier band-aid) for what I thought was a signing
bug with w2k. Turns out that when we're doing a trans/trans2/nttrans call
the MID and send_sequence_number and reply_sequence_number must remain constant.
This was something we got very wrong in earlier versions of Samba. I can now
get a directory listing from WINNT\SYSTEM32 with the older earlier parameters
for clilist.c
This still needs to be fixed for the server side of Samba, client appears to
be working happily now (I'm doing a signed smbtar download of an entire W2K3
image to test this :-).

18 years agoFix the option processing for smbtar. Does no one check this !
Jeremy Allison [Fri, 1 Aug 2003 21:09:10 +0000 (21:09 +0000)]
Fix the option processing for smbtar. Does no one check this !

18 years agoadd tests for IRIX attr functions
Herb Lewis [Fri, 1 Aug 2003 19:45:12 +0000 (19:45 +0000)]
add tests for IRIX attr functions

18 years agoUpdate my copyrights according to my agreement with IBM
Jim McDonough [Fri, 1 Aug 2003 15:30:44 +0000 (15:30 +0000)]
Update my copyrights according to my agreement with IBM

18 years agoUpdate my copyrights according to my agreement with IBM
Jim McDonough [Fri, 1 Aug 2003 15:21:20 +0000 (15:21 +0000)]
Update my copyrights according to my agreement with IBM

18 years agoFix copyright statements for various pieces of Anthony Liguori's work.
Jim McDonough [Fri, 1 Aug 2003 14:47:39 +0000 (14:47 +0000)]
Fix copyright statements for various pieces of Anthony Liguori's work.

18 years agofix cut-n-paste error found by abartlet
Gerald Carter [Fri, 1 Aug 2003 13:28:13 +0000 (13:28 +0000)]
fix cut-n-paste error found by abartlet

18 years agoAdd ntlmssp client support to ntlm_auth. Find the corresponding cyrus sasl
Volker Lendecke [Fri, 1 Aug 2003 07:59:23 +0000 (07:59 +0000)]
Add ntlmssp client support to ntlm_auth. Find the corresponding cyrus sasl
module under


18 years agoFix a memory leak. I did not check all the calls to winbindd_request, but
Volker Lendecke [Fri, 1 Aug 2003 07:46:42 +0000 (07:46 +0000)]
Fix a memory leak. I did not check all the calls to winbindd_request, but
we might leak the extra_data somewhere else as well.


18 years agolocking.c now refers to map_nt_error_from_unix, so link it in with
Volker Lendecke [Fri, 1 Aug 2003 07:45:02 +0000 (07:45 +0000)]
locking.c now refers to map_nt_error_from_unix, so link it in with
smbstatus and smbcontrol


18 years agoFinish reformatting.
Jeremy Allison [Fri, 1 Aug 2003 06:29:16 +0000 (06:29 +0000)]
Finish reformatting.

18 years agoFinal fix for the bug tridge found. Only push locks onto a blocking lock
Jeremy Allison [Fri, 1 Aug 2003 06:10:30 +0000 (06:10 +0000)]
Final fix for the bug tridge found. Only push locks onto a blocking lock
queue if the posix lock failed with EACCES or EAGAIN (this means another
lock conflicts). Else return an error and don't queue the request.

18 years agoReformat lots of clitar code as I hate the style so much :-).
Jeremy Allison [Fri, 1 Aug 2003 01:03:05 +0000 (01:03 +0000)]
Reformat lots of clitar code as I hate the style so much :-).

18 years agoReformat clitar option processing - getting ready to fix it for popt...
Jeremy Allison [Fri, 1 Aug 2003 00:41:57 +0000 (00:41 +0000)]
Reformat clitar option processing - getting ready to fix it for popt...

18 years agoCVAL_NC() doesn't need the (unsigned) fix and breaks the IRIX build
Andrew Tridgell [Thu, 31 Jul 2003 23:22:21 +0000 (23:22 +0000)]
CVAL_NC() doesn't need the (unsigned) fix and breaks the IRIX build

Thanks to Herb for pointing this out!

18 years agoAdded a note inspired by to explain when this
Jeremy Allison [Thu, 31 Jul 2003 21:47:22 +0000 (21:47 +0000)]
Added a note inspired by to explain when this
parameter gets run.

18 years agoonly honor the first OID in the sessetup snego negotiate. Deviates
Gerald Carter [Thu, 31 Jul 2003 19:01:22 +0000 (19:01 +0000)]
only honor the first OID in the sessetup snego negotiate.  Deviates
from RFC but I'm smelling a client bug here.

/* only look at the first OID for determining the mechToken --
   accoirding to RFC2478, we should choose the one we want
   and renegotiate, but i smell a client bug here..

   Problem observed when connecting to a member (samba box)
   of an AD domain as a user in a Samba domain.  Samba member
   server sent back krb5/mskrb5/ntlmssp as mechtypes, but the
   client (2ksp3) replied with ntlmssp/mskrb5/krb5 and an
   NTLMSSP mechtoken.                 --jerry              */

18 years agoReturn proper error when it is impossible to change quota flags
Alexander Bokovoy [Thu, 31 Jul 2003 17:08:38 +0000 (17:08 +0000)]
Return proper error when it is impossible to change quota flags

18 years agoFix off-by-one found by valgrind.
Volker Lendecke [Thu, 31 Jul 2003 15:53:59 +0000 (15:53 +0000)]
Fix off-by-one found by valgrind.


18 years agospnego.c has function definitions. Prototype them.
Volker Lendecke [Thu, 31 Jul 2003 15:53:26 +0000 (15:53 +0000)]
spnego.c has function definitions. Prototype them.

Anybody familiar with could you please look at this?
This is probably the wrong way to fix this.


18 years agoFixes for memory leaks in gss spnego handling by aliguori.
Volker Lendecke [Thu, 31 Jul 2003 10:24:10 +0000 (10:24 +0000)]
Fixes for memory leaks in gss spnego handling by aliguori.


18 years agoThis fixes an error I must have made when playing with spnego.c found
Volker Lendecke [Thu, 31 Jul 2003 10:23:13 +0000 (10:23 +0000)]
This fixes an error I must have made when playing with spnego.c found
by aliguori: NegTokenInit.mechListMIC is an Octet String.

Second: add a free_spnego_data function.

Both thanks to aliguori.


18 years agoApply some const
Volker Lendecke [Thu, 31 Jul 2003 10:21:13 +0000 (10:21 +0000)]
Apply some const

18 years agomake sure the domain sid is set when enumerating trusted domains
Gerald Carter [Thu, 31 Jul 2003 06:37:37 +0000 (06:37 +0000)]
make sure the domain sid is set when enumerating trusted domains
(we don't always get it back)

18 years agoworking on transtive trusts issue:
Gerald Carter [Thu, 31 Jul 2003 05:43:47 +0000 (05:43 +0000)]
working on transtive trusts issue:

  * use DsEnumerateDomainTrusts() instead of LDAP search.
    wbinfo -m now lists all trusted downlevel domains and
    all domains in the forest.

Thnigs to do:

  o Look at Krb5 connection trusted domains
  o make sure to initial the trusted domain cache as soon
    as possible

18 years agoWhoops - this is probably better shell syntax.
Tim Potter [Thu, 31 Jul 2003 04:28:43 +0000 (04:28 +0000)]
Whoops - this is probably better shell syntax.

18 years agoTurn on automatic winbindd support for FreeBSD and see what the compile farm
Tim Potter [Thu, 31 Jul 2003 04:27:41 +0000 (04:27 +0000)]
Turn on automatic winbindd support for FreeBSD and see what the compile farm
thinks of it.

18 years agoThis is a critical bug fix for a data corruption bug. If you
Andrew Tridgell [Thu, 31 Jul 2003 04:01:32 +0000 (04:01 +0000)]
This is a critical bug fix for a data corruption bug. If you
maintain another tree then please apply!

On non-X86 machines out byte-order macros fails for one particular
value. If you asked for IVAL() of 0xFFFFFFFF and assigned it to a 64
bit quantity then you got a 63 bit number 0x7FFFFFFFFFFFFFFF rather
than the expected 0xFFFFFFFF. This is due to some rather bizarre and
obscure sign extension rules to do with unsigned chars and arithmetic
operators (basically if you | together two unsigned chars you get a
signed result!)

This affected a byte range lock using the large lockingX format and a
lock of offset 0 and length 0xFFFFFFFF. Microsoft Excel does one of
these locks when opening a .csv file. If the platform you run on does
not then handle locks of length 0x7FFFFFFFFFFFFFFF then the posix lock
fails and the client is given a lockingX failure. This causes the .csv
file to be trunated!!

18 years agoWrap calls to change_oem_password() in become_root()/unbecome_root() pairs
Jeremy Allison [Thu, 31 Jul 2003 01:33:44 +0000 (01:33 +0000)]
Wrap calls to change_oem_password() in become_root()/unbecome_root() pairs
to allow UNIX password change scripts to work correctly. This is safe as
the old password has been checked as correct before invoking this.

18 years agoTurn the 'doing_signing' variable on - fix bug where it was only being set
Jeremy Allison [Thu, 31 Jul 2003 00:30:01 +0000 (00:30 +0000)]
Turn the 'doing_signing' variable on - fix bug where it was only being set
on when signing was mandatory.

18 years agoAdd a command line option (-S on|off|required) to enable signing on client
Jeremy Allison [Wed, 30 Jul 2003 23:49:29 +0000 (23:49 +0000)]
Add a command line option (-S on|off|required) to enable signing on client
connections. Overrides smb.conf parameter if set.

18 years agoSave us from possibly uninitialised variable (caught by gcc).
Jeremy Allison [Wed, 30 Jul 2003 23:33:56 +0000 (23:33 +0000)]
Save us from possibly uninitialised variable (caught by gcc).

18 years agoFix bug we discovered in W2K client signing on secondary trans2 packets.
Jeremy Allison [Wed, 30 Jul 2003 19:00:52 +0000 (19:00 +0000)]
Fix bug we discovered in W2K client signing on secondary trans2 packets.
Use W2K parameters. tpot please re-test smbclient with your problem