ira/wip.git
7 years agolibcli/smb/smbXcli: remove unused if statement from smb2cli_conn_dispatch_incoming()
Stefan Metzmacher [Mon, 27 Feb 2012 08:24:38 +0000 (09:24 +0100)]
libcli/smb/smbXcli: remove unused if statement from smb2cli_conn_dispatch_incoming()

metze

7 years agos4:libcli/smb2: remove unused 'session_key' from struct smb2_session
Stefan Metzmacher [Mon, 27 Feb 2012 08:20:20 +0000 (09:20 +0100)]
s4:libcli/smb2: remove unused 'session_key' from struct smb2_session

metze

7 years agos4:librpc/dcerpc_smb2: make use of smb2cli_session_application_key()
Stefan Metzmacher [Mon, 27 Feb 2012 08:16:28 +0000 (09:16 +0100)]
s4:librpc/dcerpc_smb2: make use of smb2cli_session_application_key()

metze

7 years agolibcli/smb/smbXcli: add smb2cli_session_application_key()
Stefan Metzmacher [Mon, 27 Feb 2012 08:03:54 +0000 (09:03 +0100)]
libcli/smb/smbXcli: add smb2cli_session_application_key()

metze

7 years agolibcli/smb/smbXcli: maintain smb2 channel_signing_key separate from the signing_key
Stefan Metzmacher [Mon, 27 Feb 2012 07:48:55 +0000 (08:48 +0100)]
libcli/smb/smbXcli: maintain smb2 channel_signing_key separate from the signing_key

The signing_key is fix across all channels and is used for session setups
on a channel binding.

Note:
 - the last session setup response is signed with the new channel signing key.
 - the reauth session setups are signed with the channel signing key.

It's also not needed to remember the main session key.

metze

7 years agolibcli/smb/smbXcli: remove unused checks from smb2cli_session_create_channel()
Stefan Metzmacher [Mon, 27 Feb 2012 08:58:53 +0000 (09:58 +0100)]
libcli/smb/smbXcli: remove unused checks from smb2cli_session_create_channel()

metze

7 years agos3:torture/test_smb2: remove explicit smb2_signing_check_pdu()
Stefan Metzmacher [Mon, 27 Feb 2012 08:18:33 +0000 (09:18 +0100)]
s3:torture/test_smb2: remove explicit smb2_signing_check_pdu()

smb2cli_session_set_session_key() already checks the signature
and that function really knows the signing key.

metze

7 years agos3:torture/test_smb2: a reauth doesn't update the session/signing key
Stefan Metzmacher [Mon, 27 Feb 2012 10:52:50 +0000 (11:52 +0100)]
s3:torture/test_smb2: a reauth doesn't update the session/signing key

metze

7 years agolib/crypto: fix hmac_sha256_final() prototype
Stefan Metzmacher [Wed, 22 Feb 2012 08:01:10 +0000 (09:01 +0100)]
lib/crypto: fix hmac_sha256_final() prototype

metze

7 years agodbwrap: changed log level for information about lock order
Andrew Tridgell [Thu, 9 Feb 2012 03:10:41 +0000 (14:10 +1100)]
dbwrap: changed log level for information about lock order

we were filling our logs with lock ordering debug lines

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Feb 27 12:50:29 CET 2012 on sn-devel-104

7 years agoselftest: up the default log level in s3
Andrew Bartlett [Mon, 13 Feb 2012 06:47:11 +0000 (17:47 +1100)]
selftest: up the default log level in s3

This may help show more detail when our tests fail.

Andrew Bartlett

7 years agos3-selftest: avoid running LOCAL- tests twice
Andrew Bartlett [Mon, 27 Feb 2012 05:29:14 +0000 (16:29 +1100)]
s3-selftest: avoid running LOCAL- tests twice

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Feb 27 09:07:59 CET 2012 on sn-devel-104

7 years agos3-param: Align lp_{max,min}protocol with lib/param names
Andrew Bartlett [Mon, 27 Feb 2012 03:24:30 +0000 (14:24 +1100)]
s3-param: Align lp_{max,min}protocol with lib/param names

This adds an alisas to ensure that both our loadparm systems know all
the names.

I would like to move to the 'server ..' name as canonical, and this
will be raised on the list.

Andrew Bartlett

7 years agotorture: don't check the NOINDEXED bit in attribute comparison
Andrew Tridgell [Thu, 9 Feb 2012 04:14:10 +0000 (15:14 +1100)]
torture: don't check the NOINDEXED bit in attribute comparison

this bit is dependent on user settings on the filesystem

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

7 years agoselftest: plugin_s4_dc can now handle kerberos properly
Andrew Bartlett [Mon, 27 Feb 2012 04:36:45 +0000 (15:36 +1100)]
selftest: plugin_s4_dc can now handle kerberos properly

7 years agos4-netlogond: Fix use of uninitialised value dns_name
Andrew Bartlett [Mon, 27 Feb 2012 05:46:22 +0000 (16:46 +1100)]
s4-netlogond: Fix use of uninitialised value dns_name

The GET_CHECK_STR macro (now unrolled) did not initialise the trusts->array[n].dns_name
when the value was not set.  New tests for our trusted domains code create
domain trusts without a DNS domain name.  Found by the autobuild flakey build detector.

Andrew Bartlett

7 years agolib/tdb2: rename tdb2.pc to tdb.pc
Rusty Russell [Mon, 27 Feb 2012 03:45:47 +0000 (14:15 +1030)]
lib/tdb2: rename tdb2.pc to tdb.pc

The library is called tdb, so the pc file must have the same name.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-User: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date: Mon Feb 27 06:59:58 CET 2012 on sn-devel-104

7 years agoupgradehelpers: Simplify transaction handling.
Jelmer Vernooij [Mon, 27 Feb 2012 02:50:37 +0000 (03:50 +0100)]
upgradehelpers: Simplify transaction handling.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Mon Feb 27 05:25:04 CET 2012 on sn-devel-104

7 years agosamba.xattr: Massively simplify copytree_with_xattrs.
Jelmer Vernooij [Mon, 27 Feb 2012 01:46:31 +0000 (02:46 +0100)]
samba.xattr: Massively simplify copytree_with_xattrs.

7 years agoupgradeprovision: Only backup sysvol directory if it exists.
Jelmer Vernooij [Sun, 26 Feb 2012 23:53:19 +0000 (00:53 +0100)]
upgradeprovision: Only backup sysvol directory if it exists.

This is not the case for standalone installations.

Bug: https://bugs.launchpad.net/samba/+bug/930370
Bug: https://bugzilla.samba.org/show_bug.cgi?id=8781

7 years agosamba.xattr: Split copying of tree with extended attributes out into separate module.
Jelmer Vernooij [Sun, 26 Feb 2012 23:50:00 +0000 (00:50 +0100)]
samba.xattr: Split copying of tree with extended attributes out into separate module.

7 years agos4:torture:smb2:durable-open: prevent using a disconnected handle in reopen4
Michael Adam [Thu, 23 Feb 2012 14:49:51 +0000 (15:49 +0100)]
s4:torture:smb2:durable-open: prevent using a disconnected handle in reopen4

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Mon Feb 27 03:44:16 CET 2012 on sn-devel-104

7 years agos4:torture:smb2:durable-open: introduce new variable for the new session
Michael Adam [Thu, 23 Feb 2012 22:43:18 +0000 (23:43 +0100)]
s4:torture:smb2:durable-open: introduce new variable for the new session

This is to clarify the code.

7 years agos4:torture:smb2:durable-open: make a comment more precise in the reopen4 test
Michael Adam [Thu, 23 Feb 2012 22:25:18 +0000 (23:25 +0100)]
s4:torture:smb2:durable-open: make a comment more precise in the reopen4 test

7 years agos4:torture:smb2:durable_open: use the correct tree in the final close call
Michael Adam [Thu, 23 Feb 2012 14:35:15 +0000 (15:35 +0100)]
s4:torture:smb2:durable_open: use the correct tree in the final close call

7 years agoprovision: Write configuration without help of templates.
Jelmer Vernooij [Sun, 26 Feb 2012 22:15:48 +0000 (23:15 +0100)]
provision: Write configuration without help of templates.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Mon Feb 27 00:52:46 CET 2012 on sn-devel-104

7 years agopyparam: fix formatting.
Jelmer Vernooij [Sun, 26 Feb 2012 21:43:15 +0000 (22:43 +0100)]
pyparam: fix formatting.

7 years agoprovision: Simplify make_smbconf a bit.
Jelmer Vernooij [Sun, 26 Feb 2012 21:23:27 +0000 (22:23 +0100)]
provision: Simplify make_smbconf a bit.

7 years agoprovision: Fix order for error formatting.
Jelmer Vernooij [Sun, 26 Feb 2012 21:09:44 +0000 (22:09 +0100)]
provision: Fix order for error formatting.

7 years agoprovision: Raise proper error when shares are missing rather than AssertionError.
Jelmer Vernooij [Sun, 26 Feb 2012 20:47:50 +0000 (21:47 +0100)]
provision: Raise proper error when shares are missing rather than AssertionError.

7 years agoprovision: Share more code for determine_netbios_name() with samba.valid_netbios_name().
Jelmer Vernooij [Sun, 26 Feb 2012 19:51:04 +0000 (20:51 +0100)]
provision: Share more code for determine_netbios_name() with samba.valid_netbios_name().

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Feb 26 22:24:42 CET 2012 on sn-devel-104

7 years agoprovision/backend: Properly close all opened files.
Jelmer Vernooij [Sun, 26 Feb 2012 19:45:43 +0000 (20:45 +0100)]
provision/backend: Properly close all opened files.

7 years agoprovision: Properly close opened files.
Jelmer Vernooij [Sun, 26 Feb 2012 19:42:41 +0000 (20:42 +0100)]
provision: Properly close opened files.

7 years agoprovision: Reuse determine_netbios_name.
Jelmer Vernooij [Sun, 26 Feb 2012 19:40:26 +0000 (20:40 +0100)]
provision: Reuse determine_netbios_name.

7 years agoprovision: Add tests for determine_netbios_name.
Jelmer Vernooij [Sun, 26 Feb 2012 19:39:13 +0000 (20:39 +0100)]
provision: Add tests for determine_netbios_name.

7 years agoprovision: Factor out determination of new netbios name.
Jelmer Vernooij [Sun, 26 Feb 2012 19:38:50 +0000 (20:38 +0100)]
provision: Factor out determination of new netbios name.

7 years agojoin: Don't print provision results when they're just noise.
Jelmer Vernooij [Sun, 26 Feb 2012 15:25:56 +0000 (16:25 +0100)]
join: Don't print provision results when they're just noise.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Feb 26 17:56:57 CET 2012 on sn-devel-104

7 years agoprovision: Split out result reporting for backends.
Jelmer Vernooij [Sun, 26 Feb 2012 15:23:18 +0000 (16:23 +0100)]
provision: Split out result reporting for backends.

7 years agoprovision: Put adminpass details in ProvisionResult.
Jelmer Vernooij [Sun, 26 Feb 2012 15:07:21 +0000 (16:07 +0100)]
provision: Put adminpass details in ProvisionResult.

7 years agoprovision/tests: Test for phpldapadminconfig path.
Jelmer Vernooij [Sun, 26 Feb 2012 14:56:52 +0000 (15:56 +0100)]
provision/tests: Test for phpldapadminconfig path.

7 years agoprovision: Leave result reporting up to caller.
Jelmer Vernooij [Sun, 26 Feb 2012 14:44:40 +0000 (15:44 +0100)]
provision: Leave result reporting up to caller.

7 years agos3: Remove pointless parentheses
Volker Lendecke [Sun, 26 Feb 2012 08:20:38 +0000 (09:20 +0100)]
s3: Remove pointless parentheses

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Sun Feb 26 11:10:15 CET 2012 on sn-devel-104

7 years agos3-configure: Add CFLAGS_APPEND variable
Volker Lendecke [Sat, 25 Feb 2012 22:42:52 +0000 (23:42 +0100)]
s3-configure: Add CFLAGS_APPEND variable

This makes it possible to add some CFLAGS to the end of the CFLAGS list. I use
it for adding -Wno-unused-value when compiling with clang.

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Sun Feb 26 01:21:49 CET 2012 on sn-devel-104

7 years agos3: Use the correct enum values
Volker Lendecke [Sat, 25 Feb 2012 20:27:28 +0000 (21:27 +0100)]
s3: Use the correct enum values

wbcIdType and id_type have the same values, but different names

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Sat Feb 25 23:46:36 CET 2012 on sn-devel-104

7 years agonsswitch: Remove a pointless if-clause
Volker Lendecke [Sat, 25 Feb 2012 20:20:21 +0000 (21:20 +0100)]
nsswitch: Remove a pointless if-clause

gr->num_gr_mem is a uint32, so it can never be < 0

7 years agolibcli: Remove a pointless check
Volker Lendecke [Sat, 25 Feb 2012 20:17:40 +0000 (21:17 +0100)]
libcli: Remove a pointless check

"n" is size_t, so it is always >=0.

7 years agoprovision: Start splitting out provision result reporting from actual provisioning.
Jelmer Vernooij [Sat, 25 Feb 2012 19:04:57 +0000 (20:04 +0100)]
provision: Start splitting out provision result reporting from actual provisioning.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sat Feb 25 22:13:10 CET 2012 on sn-devel-104

7 years agoprovision: Properly close ldb transactions.
Jelmer Vernooij [Sat, 25 Feb 2012 16:55:52 +0000 (17:55 +0100)]
provision: Properly close ldb transactions.

7 years ago'samba-tool gpo': Properly close transaction.
Jelmer Vernooij [Sat, 25 Feb 2012 16:50:14 +0000 (17:50 +0100)]
'samba-tool gpo': Properly close transaction.

7 years agontacl: There is no 'secrets database' configuration option.
Jelmer Vernooij [Sat, 25 Feb 2012 16:36:54 +0000 (17:36 +0100)]
ntacl: There is no 'secrets database' configuration option.

7 years agoFactor out sanitize_server_role.
Jelmer Vernooij [Sat, 25 Feb 2012 16:35:41 +0000 (17:35 +0100)]
Factor out sanitize_server_role.

7 years agoPartially revert 1f0298dd1b1a939cb215e7b474178b217f8347f4
Jelmer Vernooij [Sat, 25 Feb 2012 14:56:25 +0000 (15:56 +0100)]
Partially revert 1f0298dd1b1a939cb215e7b474178b217f8347f4

It's fine to catch keyboard interrupts and other kinds of errors when it's done just for resource management, where the error is reraised later.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sat Feb 25 17:29:34 CET 2012 on sn-devel-104

7 years agoprovision: Remove unused imports.
Jelmer Vernooij [Sat, 25 Feb 2012 14:15:51 +0000 (15:15 +0100)]
provision: Remove unused imports.

7 years agos3: Fix a typo
Volker Lendecke [Sat, 25 Feb 2012 08:40:16 +0000 (09:40 +0100)]
s3: Fix a typo

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Sat Feb 25 11:16:41 CET 2012 on sn-devel-104

7 years agos3: Fix bug 8777, sys_statvfs() wrapper support for OpenBSD/FreeBSD/DragonFly
Brad Smith [Sat, 25 Feb 2012 08:28:43 +0000 (09:28 +0100)]
s3: Fix bug 8777, sys_statvfs() wrapper support for OpenBSD/FreeBSD/DragonFly

7 years agos3-auth rename vuid_serverinfo to session_info
Andrew Bartlett [Sat, 14 Jan 2012 23:49:07 +0000 (10:49 +1100)]
s3-auth rename vuid_serverinfo to session_info

This matches the name used elsewhere in the code.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sat Feb 25 05:24:19 CET 2012 on sn-devel-104

7 years agos4-lib: Remove unused samdb_msg_set_value()
Ricky Nance [Fri, 10 Feb 2012 06:43:40 +0000 (00:43 -0600)]
s4-lib: Remove unused samdb_msg_set_value()

Found by callcatcher.

Ricky Nance

7 years agos4-lib: Remove unused samdb_msg_set_string()
Ricky Nance [Fri, 10 Feb 2012 06:41:44 +0000 (00:41 -0600)]
s4-lib: Remove unused samdb_msg_set_string()

Found by callcatcher.

Ricky Nance

7 years agos4-lib: Remove unused samdb_msg_set_int()
Ricky Nance [Fri, 10 Feb 2012 06:36:55 +0000 (00:36 -0600)]
s4-lib: Remove unused samdb_msg_set_int()

Found by callcatcher

Ricky Nance

7 years agoMove dptr code over to TALLOC.
Jeremy Allison [Sat, 25 Feb 2012 01:16:08 +0000 (17:16 -0800)]
Move dptr code over to TALLOC.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Feb 25 03:50:24 CET 2012 on sn-devel-104

7 years agoMake dptr_path() and dptr_wcard() const.
Jeremy Allison [Sat, 25 Feb 2012 01:12:52 +0000 (17:12 -0800)]
Make dptr_path() and dptr_wcard() const.

7 years agoFix const warnings.
Jeremy Allison [Thu, 23 Feb 2012 22:49:02 +0000 (14:49 -0800)]
Fix const warnings.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Feb 24 23:10:56 CET 2012 on sn-devel-104

7 years agoRemove unused function.
Jeremy Allison [Thu, 23 Feb 2012 22:46:45 +0000 (14:46 -0800)]
Remove unused function.

7 years agos3: Simplify smb_splice_chain
Volker Lendecke [Fri, 24 Feb 2012 15:16:23 +0000 (16:16 +0100)]
s3: Simplify smb_splice_chain

No code change, just remove a {} block left over as the else branch
from the previous commit

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Fri Feb 24 18:07:48 CET 2012 on sn-devel-104

7 years agos3: Simplify smb_splice_chain
Volker Lendecke [Fri, 24 Feb 2012 15:16:23 +0000 (16:16 +0100)]
s3: Simplify smb_splice_chain

first_request won't be true anymore, we always splice fully existing
records in smbd

7 years agos3: Simplify smb_splice_chain
Volker Lendecke [Fri, 24 Feb 2012 15:16:23 +0000 (16:16 +0100)]
s3: Simplify smb_splice_chain

With the last commit, bytes_padding is not set anymore

7 years agos3: Simplify smb_splice_chain
Volker Lendecke [Fri, 24 Feb 2012 15:16:23 +0000 (16:16 +0100)]
s3: Simplify smb_splice_chain

bytes_alignment used to be used in libsmb, which uses different code
now

7 years agos3: Simplify smb_splice_chain
Volker Lendecke [Fri, 24 Feb 2012 15:16:23 +0000 (16:16 +0100)]
s3: Simplify smb_splice_chain

We use it in smbd/process.c only now. This only splices in finished
buffers, both callers used the same arguments. Pull that into the
routine itself.

7 years agos3: Turn some SMB_ASSERTS into proper return
Volker Lendecke [Fri, 24 Feb 2012 15:02:02 +0000 (16:02 +0100)]
s3: Turn some SMB_ASSERTS into proper return

We deal with the error properly further up

7 years agos3: Fix a DEBUG msg
Volker Lendecke [Fri, 24 Feb 2012 14:45:37 +0000 (15:45 +0100)]
s3: Fix a DEBUG msg

7 years agoupgradedns: Rename to less generic name samba_upgradedns.
Jelmer Vernooij [Fri, 24 Feb 2012 12:31:47 +0000 (13:31 +0100)]
upgradedns: Rename to less generic name samba_upgradedns.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Fri Feb 24 15:07:27 CET 2012 on sn-devel-104

7 years agoon our way with Samba 4.0alpha19
Andrew Bartlett [Fri, 24 Feb 2012 04:24:00 +0000 (15:24 +1100)]
on our way with Samba 4.0alpha19

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Feb 24 07:20:10 CET 2012 on sn-devel-104

7 years agoprepare WHATSNEW for Samba 4.0alpha18 release and mark as release. samba-4.0.0alpha18
Andrew Bartlett [Thu, 16 Feb 2012 05:45:10 +0000 (16:45 +1100)]
prepare WHATSNEW for Samba 4.0alpha18 release and mark as release.

7 years agos3-libsmb: Remove unused spnego_parse_auth_and_mic
Andrew Bartlett [Fri, 24 Feb 2012 01:36:23 +0000 (12:36 +1100)]
s3-libsmb: Remove unused spnego_parse_auth_and_mic

7 years agos3-selftest: Verify GK and GF flag behaviour
Andrew Bartlett [Fri, 24 Feb 2012 01:19:27 +0000 (12:19 +1100)]
s3-selftest: Verify GK and GF flag behaviour

At least this ensures that the helper has not crashed, it will require
a little more to ensure that the values are correct.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Feb 24 03:53:38 CET 2012 on sn-devel-104

7 years agos3-selftest: run ntlm_auth against winbindd in make test
Andrew Bartlett [Fri, 24 Feb 2012 01:12:48 +0000 (12:12 +1100)]
s3-selftest: run ntlm_auth against winbindd in make test

7 years agoauth: Remove plugable password-check functions from gensec_ntlmssp
Andrew Bartlett [Tue, 7 Feb 2012 06:47:42 +0000 (17:47 +1100)]
auth: Remove plugable password-check functions from gensec_ntlmssp

The auth4_context layer now provides the plugability here.

Andrew Bartlett

7 years agoauth: consolidate gensec_ntlmssp_server wrapper functions
Andrew Bartlett [Tue, 7 Feb 2012 06:12:19 +0000 (17:12 +1100)]
auth: consolidate gensec_ntlmssp_server wrapper functions

7 years agos3-libsmb: Remove unused ntlmssp_server_start()
Andrew Bartlett [Tue, 7 Feb 2012 06:07:52 +0000 (17:07 +1100)]
s3-libsmb: Remove unused ntlmssp_server_start()

7 years agos3-ntlm_auth: Convert ntlm_auth to use gensec_ntlmssp server-side
Andrew Bartlett [Tue, 7 Feb 2012 06:02:14 +0000 (17:02 +1100)]
s3-ntlm_auth: Convert ntlm_auth to use gensec_ntlmssp server-side

This uses the common gensec_ntlmssp server code for ntlm_auth, removing
the last non-gensec use of the NTLMSSP server.

Andrew Bartlett

7 years agos3-auth: Provide helper routine to check password and return session_info
Andrew Bartlett [Fri, 3 Feb 2012 12:32:26 +0000 (23:32 +1100)]
s3-auth: Provide helper routine to check password and return session_info

7 years agoauth: Rename some elements of auth4_context
Andrew Bartlett [Fri, 3 Feb 2012 05:33:44 +0000 (16:33 +1100)]
auth: Rename some elements of auth4_context

These operate on NTLM authentication, so make that clear.

Andrew Bartlett

7 years agos3-auth: Add a way to get an auth4_context from the auth stack
Andrew Bartlett [Fri, 3 Feb 2012 05:14:42 +0000 (16:14 +1100)]
s3-auth: Add a way to get an auth4_context from the auth stack

This will allow us to use the same layer that auth_ntlmssp does
in the non-SPNEGO session setup, which will in turn make the
authentication code more consistent in the AD server case.

Andrew Bartlett

7 years agowaf: Make sure libraries are installed with the execute flag set.
Andreas Schneider [Thu, 23 Feb 2012 10:05:09 +0000 (11:05 +0100)]
waf: Make sure libraries are installed with the execute flag set.

There are two reasons for that. The first is that libraries are
executables and can have main functions (see libc). The second reason is
that rpm script to extract debuginfo are looking for executables and
then check if it is the right file to extract the info.

Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Thu Feb 23 20:57:11 CET 2012 on sn-devel-104

7 years agos4-heimdal: Remove the execute flag of cfx.c.
Andreas Schneider [Thu, 23 Feb 2012 08:24:02 +0000 (09:24 +0100)]
s4-heimdal: Remove the execute flag of cfx.c.

The scripts which are extracting debuginfo are looking for files with
the executable bit and find cfx.c which isn't a executable.

7 years agos3:smbd/utmp.c - fix the build on FreeBSD 9 without utmp.h
Matthias Dieter Wallnöfer [Thu, 23 Feb 2012 10:41:11 +0000 (11:41 +0100)]
s3:smbd/utmp.c - fix the build on FreeBSD 9 without utmp.h

https://bugzilla.samba.org/show_bug.cgi?id=8709

Reviewed-by: Jelmer
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Thu Feb 23 19:17:25 CET 2012 on sn-devel-104

7 years agodcerpc_server: Add 'modulesdir' variable to pkg-config file.
Jelmer Vernooij [Thu, 23 Feb 2012 13:51:00 +0000 (14:51 +0100)]
dcerpc_server: Add 'modulesdir' variable to pkg-config file.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Thu Feb 23 16:26:25 CET 2012 on sn-devel-104

7 years agos3: smb_request->vwv can be const
Volker Lendecke [Thu, 23 Feb 2012 09:50:46 +0000 (10:50 +0100)]
s3: smb_request->vwv can be const

Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Thu Feb 23 12:37:23 CET 2012 on sn-devel-104

7 years agoselftest: Do not skip environments that fail to start up
Andrew Bartlett [Thu, 23 Feb 2012 05:34:47 +0000 (16:34 +1100)]
selftest: Do not skip environments that fail to start up

This is a regression in 70f4a96c68e91e407651e2487cc3c66a80262fa2.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Feb 23 10:55:20 CET 2012 on sn-devel-104

7 years agos4-provision: Fix typo in 9b9fdeefb47f2657c9bb4c2f48318550da510209
Andrew Bartlett [Thu, 23 Feb 2012 05:36:33 +0000 (16:36 +1100)]
s4-provision: Fix typo in 9b9fdeefb47f2657c9bb4c2f48318550da510209

This was not found to to a bug in the selftest system.

Andrew Bartlett

7 years agos3-libads: Remove unused ads_set_machine_password()
Andrew Bartlett [Thu, 9 Feb 2012 04:59:38 +0000 (15:59 +1100)]
s3-libads: Remove unused ads_set_machine_password()

Found by callcatcher.

Andrew Bartlett

7 years agos3-libads: Remove unused ads_pull_sids_from_extendeddn()
Andrew Bartlett [Thu, 9 Feb 2012 05:04:30 +0000 (16:04 +1100)]
s3-libads: Remove unused ads_pull_sids_from_extendeddn()

Found by callcatcher.

Andrew Bartlett

7 years agos3-utils: Remove unused connect_to_ipc_krb5()
Andrew Bartlett [Thu, 9 Feb 2012 05:07:06 +0000 (16:07 +1100)]
s3-utils: Remove unused connect_to_ipc_krb5()

Found by callcatcher.

Andrew Bartlett

7 years agowintest: Change to a new Win2008R2 VM
Andrew Bartlett [Tue, 21 Feb 2012 00:55:50 +0000 (11:55 +1100)]
wintest: Change to a new Win2008R2 VM

7 years agos3-libsmb: Remove unused spnego functions
Andrew Bartlett [Mon, 20 Feb 2012 06:03:25 +0000 (17:03 +1100)]
s3-libsmb: Remove unused spnego functions

7 years agos3-rpc_server Remove unused function auth_generic_server_start()
Andrew Bartlett [Mon, 20 Feb 2012 05:42:20 +0000 (16:42 +1100)]
s3-rpc_server Remove unused function auth_generic_server_start()

7 years agos4:smbcli:smb2: add a random GUID to the transport connection in smb2_transport_init()
Michael Adam [Wed, 22 Feb 2012 14:29:26 +0000 (15:29 +0100)]
s4:smbcli:smb2: add a random GUID to the transport connection in smb2_transport_init()

This GUID is used in the smb2 negprot when max protocol is bigger than 0x0202.
According to section 2.2.3 of the MS-SMB2 document, the Client GUID filed in the
SMB2 negotiate request must be filled with a (non-zero) GUID if there are other
dialects than 0x0202 in the dialects field.

http://msdn.microsoft.com/en-us/library/cc246543%28v=prot.13%29.aspx

Apart from corresponding to the docs, this change makes some of our durable-open
tests (e.g reopen2 and open-oplock) _not_ hang when running against windows 8
preview (which might be still buggy).

Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Thu Feb 23 03:23:57 CET 2012 on sn-devel-104

7 years agos3:wscript_build - fix TDB dependency for source3/lib/util.c
Matthias Dieter Wallnöfer [Mon, 20 Feb 2012 09:27:45 +0000 (10:27 +0100)]
s3:wscript_build - fix TDB dependency for source3/lib/util.c

https://bugzilla.samba.org/show_bug.cgi?id=8708

Signed-off-by: Andrew Tridgell <tridge@samba.org>
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Feb 23 01:43:04 CET 2012 on sn-devel-104

7 years agoexamples/testsmbc.c - substitute deprecated function "bzero" with "memset"
Matthias Dieter Wallnöfer [Mon, 20 Feb 2012 08:27:13 +0000 (09:27 +0100)]
examples/testsmbc.c - substitute deprecated function "bzero" with "memset"

Here we do not make any use of libreplace and hence it would be overkill
to include the right headers for Solaris.

This fixes bug: https://bugzilla.samba.org/show_bug.cgi?id=8767

Signed-off-by: Andrew Tridgell <tridge@samba.org>
7 years agoexamples/testsmbc.c - quiet implicit cast warnings on OpenSolaris
Matthias Dieter Wallnöfer [Mon, 20 Feb 2012 08:23:30 +0000 (09:23 +0100)]
examples/testsmbc.c - quiet implicit cast warnings on OpenSolaris

https://bugzilla.samba.org/show_bug.cgi?id=8767

Signed-off-by: Andrew Tridgell <tridge@samba.org>