Matthias Dieter Wallnöfer [Sun, 7 Mar 2010 18:12:30 +0000 (19:12 +0100)]
s4:schema_data LDB module - change counter variables to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Sun, 7 Mar 2010 18:11:48 +0000 (19:11 +0100)]
s4:resolve_oids LDB module - change counter variables to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Sun, 7 Mar 2010 18:11:03 +0000 (19:11 +0100)]
s4:rootdse LDB module - change counter variables to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Sun, 7 Mar 2010 18:10:00 +0000 (19:10 +0100)]
s4:partition LDB module - change counter variables to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Fri, 6 Nov 2009 19:14:41 +0000 (20:14 +0100)]
s4:schema - Change also here counters to "unsigned" where needed
Counters which are used in the way "for (i = 0; array[i] != NULL; i++)" I
modified to "unsigned" since for sure we don't want to have negative array
indexes there.
Matthias Dieter Wallnöfer [Fri, 6 Nov 2009 19:14:41 +0000 (20:14 +0100)]
s4:schema_syntax.c - Change also here counters to "unsigned" where needed
Counters which are used in the way "for (i = 0; array[i] != NULL; i++)" I
modified to "unsigned" since for sure we don't want to have negative array
indexes there.
There were many counter variables typed "uint32_t". This isn't fully correct
since those count LDB objects. The amount is saved in a "num_*" variable which
is "unsigned" without a bitlength specification. Therefore change also these
counters to be plain "unsigned".
Stefan Metzmacher [Fri, 5 Mar 2010 17:30:10 +0000 (18:30 +0100)]
s4:libcli/wrepl: rewrite the low level request handling to use tevent_queue and tstream_context
metze
Stefan Metzmacher [Sun, 7 Mar 2010 15:59:12 +0000 (16:59 +0100)]
s4:wrepl_out_helpers: add a WREPLSRV_PUSH_NOTIFY_STAGE_WAIT_UPDATE stage
This makes the logic more consistent.
metze
Stefan Metzmacher [Fri, 5 Mar 2010 15:03:23 +0000 (16:03 +0100)]
s4:libcli/wrepl: add wrepl_socket_is_connected()
metze
Stefan Metzmacher [Fri, 5 Mar 2010 14:49:27 +0000 (15:49 +0100)]
s4:libcli/wrepl: make struct wrepl_request private to winsrepl.c
metze
Stefan Metzmacher [Fri, 5 Mar 2010 14:22:10 +0000 (15:22 +0100)]
s4:libcli/wrepl: implement wrepl_request_send as a tevent_req based wrapper
metze
Stefan Metzmacher [Fri, 5 Mar 2010 14:03:29 +0000 (15:03 +0100)]
s4:libcli/wrepl: rename enum wrepl_request_state => enum wrepl_request_internal_state
metze
Stefan Metzmacher [Fri, 5 Mar 2010 13:44:23 +0000 (14:44 +0100)]
s4:libcli/wrepl: move wrepl_request_send/recv => wrepl_request_internal_send/recv
metze
Stefan Metzmacher [Fri, 5 Mar 2010 13:34:36 +0000 (14:34 +0100)]
s4:torture/nbt: use wrepl_associate_stop() instead of build the request by hand
metze
Stefan Metzmacher [Fri, 5 Mar 2010 13:29:36 +0000 (14:29 +0100)]
s4:torture/nbt: use wrepl_request() instead of wrepl_request_send() followed by wrepl_request_recv()
metze
Stefan Metzmacher [Fri, 5 Mar 2010 13:17:08 +0000 (14:17 +0100)]
s4:libcli/wrepl: add my copyright
metze
Matthias Dieter Wallnöfer [Sat, 6 Mar 2010 18:39:45 +0000 (19:39 +0100)]
s4:lib/registry/ldb.c - fix trailing whitespaces
Matthias Dieter Wallnöfer [Sat, 6 Mar 2010 18:36:01 +0000 (19:36 +0100)]
s4:registry library - fix up "reg_ldb_set_value"
The previous logic was wrong since it tried to add empty data in some cases
which always ended in an error. This problem should be fixed with the new logic.
Matthias Dieter Wallnöfer [Sat, 6 Mar 2010 18:20:48 +0000 (19:20 +0100)]
s4:registry library - make "reg_ldb_pack/unpack_value" more robust
This to prevent segmentation faults, wrong server inputs ecc.
Matthias Dieter Wallnöfer [Sat, 6 Mar 2010 17:51:41 +0000 (18:51 +0100)]
s4:provision.reg - call us Windows 2008 from the current version point of view
Matthias Dieter Wallnöfer [Sat, 7 Nov 2009 20:07:20 +0000 (21:07 +0100)]
s4:libregistry - change counters to be "unsigned"
Also the s4 registry library has to have "unsigned" counters like the Windows
one.
Volker Lendecke [Sat, 6 Mar 2010 11:57:35 +0000 (12:57 +0100)]
s3: Fix the build of net_afs.c with --fake-kaserver=yes, bug 7216
Thanks to Geza Gemes <geza@kzsdabas.hu> for filing this bug
Matthias Dieter Wallnöfer [Fri, 6 Nov 2009 17:35:17 +0000 (18:35 +0100)]
LDB:tools - change counters to be unsigned
In most cases we do count LDB objects which are enumerated within the "unsigned"
type. Therefore no need to use "signed" counters.
Matthias Dieter Wallnöfer [Sat, 6 Mar 2010 10:19:04 +0000 (11:19 +0100)]
s4:lsa RPC - fix up "gendb_*" result codes
Make the resultcodes consistent: that means:
result < 0 -> NT_STATUS_INTERNAL_DB_CORRUPTION since our DB had a critical
error
result >= 0 -> depends on the function usage. I tried to let the logic always as
it was before.
Matthias Dieter Wallnöfer [Sat, 21 Nov 2009 18:26:02 +0000 (19:26 +0100)]
s4:lsa RPC - Change some counters to be "unsigned" where needed
The "count" size specifiers I typed "uint32_t" since they're often returned as
an "uint32_t" (consider the IDL file). LDB counters need to be "signed" if they
count till a limit of a "gendb*" call or "unsigned" if they count directly the
number of objects.
Matthias Dieter Wallnöfer [Sat, 21 Nov 2009 18:26:02 +0000 (19:26 +0100)]
s4:samr RPC - Change some counters to be "unsigned" where needed
The "count" size specifiers I typed "uint32_t" since they're often returned as
an "uint32_t" (consider the IDL file). LDB counters need to be "signed" if they
count till a limit of a "gendb*" call or "unsigned" if they count directly the
number of objects.
Jeremy Allison [Fri, 5 Mar 2010 23:10:30 +0000 (15:10 -0800)]
Fix for bug #7189 - Open txt files with notepad on samba shares creates problem.
Ensure we don't use any of the create_options for Samba private
use. Add a new parameter to the VFS_CREATE call (private_flags)
which is only used internally. Renumber NTCREATEX_OPTIONS_PRIVATE_DENY_DOS
and NTCREATEX_OPTIONS_PRIVATE_DENY_FCB to match the S4 code).
Rev. the VFS interface to version 28.
Jeremy.
Kamen Mazdrashki [Thu, 4 Mar 2010 16:00:15 +0000 (18:00 +0200)]
s4/tort: fix annoying "union spoolss_PrinterInfo" undefined warnings
Signed-off-by: Günther Deschner <gd@samba.org>
Günther Deschner [Fri, 5 Mar 2010 21:03:26 +0000 (22:03 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Fri, 5 Mar 2010 20:56:50 +0000 (21:56 +0100)]
winreg: fix winreg_QueryValue IDL.
Note that before this change pidl generated code that just dereferenced size_is
and length_is values from unique pointers without checking whether these
pointers were actually NULL.
With this change, pidl now throws a warning like:
warning: Got pointer for `data_size', expected fully derefenced variable
which is not correct, probably because pidl does not evaluate the C expression.
Guenther
Andreas Schneider [Fri, 5 Mar 2010 10:15:35 +0000 (11:15 +0100)]
s3-rpcclient: Leave setprinterdata directly if not enough args were passed.
If we don't pass enough arguments we don't have to close the connection.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Fri, 5 Mar 2010 14:54:31 +0000 (15:54 +0100)]
s3-rpc_server: Document rpc_pipe_open_internal.
Signed-off-by: Günther Deschner <gd@samba.org>
Günther Deschner [Fri, 5 Mar 2010 19:32:16 +0000 (20:32 +0100)]
s4-smbtorture: fix RPC-SPOOLSS-WIN after PrinterData IDL changes.
Guenther
Matthias Dieter Wallnöfer [Sat, 21 Nov 2009 17:57:24 +0000 (18:57 +0100)]
s4:drsuapi RPC - Change also here counters to "unsigned"
No need to have "signed" counters at those places.
Matthias Dieter Wallnöfer [Fri, 6 Nov 2009 19:14:41 +0000 (20:14 +0100)]
s4:dsdb/util - Change also here counters to "unsigned"
No need to have "signed" counters at those places.
Matthias Dieter Wallnöfer [Fri, 6 Nov 2009 19:14:41 +0000 (20:14 +0100)]
s4:repl - change also here the counter variables to "unsigned"
I changed also some "uint32_t" to "unsigned" since the LDB interface doesn't
specify the bitlength of the unsigned type.
Matthias Dieter Wallnöfer [Sat, 7 Nov 2009 20:15:17 +0000 (21:15 +0100)]
s4:wrepl_server - change also here the counter variables to "unsigned"
I changed also some "uint32_t" to "unsigned" since the LDB interface doesn't
specify the bitlength of the unsigned type.
Volker Lendecke [Fri, 5 Mar 2010 16:06:08 +0000 (17:06 +0100)]
s3: Make "smbcontrol xx debuglevel" print the correct cluster pid
Günther Deschner [Fri, 5 Mar 2010 15:34:17 +0000 (16:34 +0100)]
s4-spoolss: fix dcesrv_spoolss_GetPrinterData build.
really not my day today...
Guenther
Günther Deschner [Fri, 5 Mar 2010 15:00:14 +0000 (16:00 +0100)]
s4-smbtorture: fix test_SetPrinterDataEx_matrix() call. sorry...
Guenther
Volker Lendecke [Fri, 5 Mar 2010 14:30:22 +0000 (15:30 +0100)]
s3: Remove the unused parameter "persistent" from fetch_locked_internal
Volker Lendecke [Fri, 5 Mar 2010 14:28:39 +0000 (15:28 +0100)]
s3: db->persistent==true was handled earlier, make this more obvious
Günther Deschner [Fri, 5 Mar 2010 13:42:10 +0000 (14:42 +0100)]
s4-smbtorture: when checking PrinterData matrix, include winreg cross reference checks.
Guenther
Günther Deschner [Fri, 5 Mar 2010 13:03:03 +0000 (14:03 +0100)]
s4-smbtorture: hand down printername to test_SetPrinterDataEx_matrix.
Guenther
Günther Deschner [Thu, 4 Mar 2010 23:56:52 +0000 (00:56 +0100)]
s4-smbtorture: add more paranoid checks for REG_DWORD SetPrinterDataEx tests.
Guenther
Günther Deschner [Thu, 4 Mar 2010 22:13:10 +0000 (23:13 +0100)]
s4-smbtorture: remove check for selfmade parsing artefact.
We were checking against a phenomenon that we created ourselves at the pidl
layer...
Guenther
Günther Deschner [Thu, 4 Mar 2010 16:58:49 +0000 (17:58 +0100)]
s3-libads: fix get_remote_printer_publishing_data after spoolss_EnumPrinterDataEx IDL change.
Guenther
Günther Deschner [Thu, 4 Mar 2010 15:47:33 +0000 (16:47 +0100)]
s3-spoolss: fix _spoolss_EnumPrinterDataEx after idl
Guenther
Günther Deschner [Thu, 4 Mar 2010 15:47:10 +0000 (16:47 +0100)]
s3-rpcclient: fix rpcclient after spoolss_EnumPrinterDataEx IDL change.
Guenther
Günther Deschner [Thu, 4 Mar 2010 15:46:53 +0000 (16:46 +0100)]
s3-net: fix net after spoolss_EnumPrinterDataEx IDL change.
Guenther
Günther Deschner [Thu, 4 Mar 2010 16:04:19 +0000 (17:04 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Thu, 4 Mar 2010 15:40:31 +0000 (16:40 +0100)]
spoolss: fix spoolss_EnumPrinterDataEx IDL.
Guenther
Günther Deschner [Thu, 4 Mar 2010 21:40:31 +0000 (22:40 +0100)]
s4-smbtorture: fix smbtorture after GetPrinterData{Ex} after IDL changes.
Guenther
Günther Deschner [Thu, 4 Mar 2010 17:21:50 +0000 (18:21 +0100)]
s4-spoolss: fix spoolss_GetPrinterData implementation after IDL change.
Guenther
Günther Deschner [Thu, 4 Mar 2010 14:46:28 +0000 (15:46 +0100)]
s3-rpcclient: fix rpcclient after spoolss_GetPrinterData{Ex} IDL change.
Guenther
Günther Deschner [Thu, 4 Mar 2010 14:39:59 +0000 (15:39 +0100)]
s3-spoolss: fix _spoolss_GetPrinterDataEx after IDL change.
Guenther
Günther Deschner [Thu, 4 Mar 2010 16:02:42 +0000 (17:02 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Thu, 4 Mar 2010 14:38:18 +0000 (15:38 +0100)]
spoolss: rollback GetPrinterData[Ex] IDL.
Guenther
Günther Deschner [Thu, 4 Mar 2010 21:22:45 +0000 (22:22 +0100)]
s4-smbtorture: fix smbtorture after SetPrinterData{Ex} IDL changes.
Guenther
Günther Deschner [Thu, 4 Mar 2010 14:34:49 +0000 (15:34 +0100)]
s3-rpcclient: fix rpcclient after spoolss_SetPrinterData{Ex} IDL change.
Guenther
Günther Deschner [Thu, 4 Mar 2010 14:34:22 +0000 (15:34 +0100)]
s3-net: fix net after spoolss_SetPrinterData{Ex} IDL change.
Guenther
Günther Deschner [Thu, 4 Mar 2010 16:00:34 +0000 (17:00 +0100)]
s3-spoolss: fix _spoolss_SetPrinterData{Ex} after IDL change.
Guenther
Günther Deschner [Thu, 4 Mar 2010 16:00:09 +0000 (17:00 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Wed, 3 Mar 2010 17:22:57 +0000 (18:22 +0100)]
spoolss: rollback SetPrinterData{Ex} IDL.
Guenther
Matthias Dieter Wallnöfer [Fri, 5 Mar 2010 14:01:07 +0000 (15:01 +0100)]
s4:dcesrv_samr_AddAliasMember - wrap a long "DEBUG" statement
Stefan Metzmacher [Wed, 3 Mar 2010 17:35:55 +0000 (18:35 +0100)]
s4:libcli/wrepl: convert wrepl_associate_stop_send to tevent_req
metze
Stefan Metzmacher [Wed, 3 Mar 2010 16:18:23 +0000 (17:18 +0100)]
s4:libcli/wrepl: convert wrepl_connect_send to tevent_req
metze
Stefan Metzmacher [Wed, 3 Mar 2010 17:38:16 +0000 (18:38 +0100)]
s4:libcli/wrepl: convert wrepl_associate_send to tevent_req
metze
Stefan Metzmacher [Wed, 3 Mar 2010 14:14:28 +0000 (15:14 +0100)]
s4:libcli/wrepl: convert wrepl_pull_table_send to tevent_req
metze
Stefan Metzmacher [Wed, 3 Mar 2010 14:12:05 +0000 (15:12 +0100)]
s4:libcli/wrepl: convert wrepl_pull_names_send to tevent_req
metze
Stefan Metzmacher [Wed, 3 Mar 2010 12:38:08 +0000 (13:38 +0100)]
s4:libcli/wrepl: use UTIL_TEVENT
metze
Stefan Metzmacher [Wed, 3 Mar 2010 08:45:01 +0000 (09:45 +0100)]
s4:libcli/wrepl: avoid neested named structures
metze
Stefan Metzmacher [Wed, 3 Mar 2010 10:31:03 +0000 (11:31 +0100)]
s4:torture/nbt: avoid the usage of wrepl_pull_table_send()
metze
Stefan Metzmacher [Fri, 5 Mar 2010 07:22:36 +0000 (08:22 +0100)]
libcli/auth: add a const to des_crypt112_16()
metze
Stefan Metzmacher [Fri, 5 Mar 2010 10:16:12 +0000 (11:16 +0100)]
s3:winbindd: add DEBUG(10,...) for the end of each top level
That will hopefully make debugging a bit easier (at least for me).
metze
Matthias Dieter Wallnöfer [Fri, 6 Nov 2009 19:14:41 +0000 (20:14 +0100)]
s4:kcc - Change some counter variables to be unsigned
The upper limits are unsigned variables therefore also the counter variables
need to be like that.
Matthias Dieter Wallnöfer [Fri, 6 Nov 2009 19:14:41 +0000 (20:14 +0100)]
s4:samdb_privilege.c - Change two counter variables to unsigned
Also here in both cases the unsigned counter fits better than the signed one.
Matthias Dieter Wallnöfer [Fri, 6 Nov 2009 19:14:41 +0000 (20:14 +0100)]
s4:cracknames - Change two counter variables to unsigned
In both cases the unsigned counter fits better:
- in the first one since we are counting LDB objects starting from 0
- in the second since we are counting an array starting from 0
Andrew Tridgell [Fri, 5 Mar 2010 12:07:26 +0000 (23:07 +1100)]
s4-pvfs_sys: build on systems without O_NOFOLLOW or O_DIRECTORY
Andrew Tridgell [Fri, 5 Mar 2010 11:58:18 +0000 (22:58 +1100)]
s4-pvfs_sys: talloc_free should be before errno restore
talloc can potentially change the errno
Andrew Tridgell [Fri, 5 Mar 2010 11:48:09 +0000 (22:48 +1100)]
s4-pvfs: use pvfs_sys_fchmod()
Andrew Tridgell [Fri, 5 Mar 2010 11:47:50 +0000 (22:47 +1100)]
s4-pvfs: set default for perm override based on system features
If the system has O_NOFOLLOW and O_DIRECTORY then we allow for
overrides by default. If not, then we disable by default, as we will
be more vulnerable to symlink attacks
Andrew Tridgell [Fri, 5 Mar 2010 11:46:44 +0000 (22:46 +1100)]
s4-pvfs: use O_FOLLOW one level at a time for security overrides
To prevent symlink attacks we need to use O_NOFOLLOW one level at a
time when processing a root security override
Andrew Tridgell [Fri, 5 Mar 2010 11:45:27 +0000 (22:45 +1100)]
replace: added get_current_dir_name()
Andrew Tridgell [Fri, 5 Mar 2010 06:52:35 +0000 (17:52 +1100)]
s4-pvfs: use pvfs_sys_*() functions to wrap posix calls
This allows for root override, which fixes many problems with
mismatches between NT ACL permissions and unix permissions.
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Fri, 5 Mar 2010 06:51:12 +0000 (17:51 +1100)]
s4-pvfs: new pvfs_sys module
The pvfs_sys_*() calls provide wrapper functions for posix file
functions which use root privileges to override EACCES failures if
PVFS_FLAG_PERM_OVERRIDE is set
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Fri, 5 Mar 2010 06:50:18 +0000 (17:50 +1100)]
s4-pvfs: added new pvfs flag PVFS_FLAG_PERM_OVERRIDE
This flag indicates that we should use root privileges to override
unix permissions when the NT ACLs indicate that access should be
granted
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Fri, 5 Mar 2010 06:49:11 +0000 (17:49 +1100)]
s4-privs: add root_privileges_original_uid()
This can be used to get the uid we changed away from when we gained
root privileges
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Günther Deschner [Fri, 5 Mar 2010 10:06:46 +0000 (11:06 +0100)]
s3-selftest: enable RPC-WINREG against Samba 3.
Guenther
Günther Deschner [Fri, 5 Mar 2010 10:06:18 +0000 (11:06 +0100)]
s4-smbtorture: skip NotifyChangeKeyValue test against s3 for now.
Guenther
Matthias Dieter Wallnöfer [Fri, 5 Mar 2010 07:50:08 +0000 (08:50 +0100)]
s4:torture/rpc/samr.c - add some decision possibility constants to some switch
At the moment nothing is done when the enumeration variable is set to one of
those constants as before. This is only to quite nasty warnings.
Matthias Dieter Wallnöfer [Fri, 5 Mar 2010 07:49:25 +0000 (08:49 +0100)]
s4:torture/rpc/samr.c - make some argument of function "test_SamLogon_with_creds" constant
This to quiet warnings.
Matthias Dieter Wallnöfer [Fri, 5 Mar 2010 07:47:48 +0000 (08:47 +0100)]
s4:torture/winbind/struct_based.c - fix up (un)signedness of a function argument
Otherwise always a warning is generated.
Andrew Tridgell [Fri, 5 Mar 2010 03:59:08 +0000 (14:59 +1100)]
s4-pvfs: log more error conditions in NTVFS backend
This should make is easier to track down some bug reports
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Fri, 5 Mar 2010 03:57:50 +0000 (14:57 +1100)]
s4-pvfs: move the private ntcreatex flags to private_flags
Re-using two of the create_options bits was bound to eventually
cause problems, and indeed, Windows7 now uses one of those bits
when opening text files.
Fixes bug 7189
Andrew Tridgell [Fri, 5 Mar 2010 02:49:49 +0000 (13:49 +1100)]
s4-rpc: don't use s->credentials after it is freed
Andrew Tridgell [Fri, 5 Mar 2010 02:02:16 +0000 (13:02 +1100)]
s4-torture: fixed commas separating C statements
Bo Yang [Sat, 6 Mar 2010 12:58:23 +0000 (20:58 +0800)]
s3: Fix unnecessary traversing winbindd_cache.tdb in SIGHUP handler.
Signed-off-by: Bo Yang <boyang@samba.org>
Andrew Tridgell [Fri, 5 Mar 2010 00:53:19 +0000 (11:53 +1100)]
s4-python: only install external python libs that are missing
Andrew Tridgell [Fri, 5 Mar 2010 00:45:40 +0000 (11:45 +1100)]
s4-python: import a copy of the python dns library
This library is not installed on enough systems for us to rely
on it being available. We use the system copy if possible, and
fallback to this local copy
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>