ira/wip.git
16 years agoMove check for broken system capabilites.h headers to lib/replace.
Michael Adam [Mon, 3 Dec 2007 15:43:51 +0000 (16:43 +0100)]
Move check for broken system capabilites.h headers to lib/replace.

Michael

16 years agoAdd check for ppc statfs.h header to workaround for broken capabilities.h.
Michael Adam [Mon, 3 Dec 2007 15:42:08 +0000 (16:42 +0100)]
Add check for ppc statfs.h header to workaround for broken capabilities.h.

Taken from s3:lib/system.c

Michael

16 years agoAdd decode_wkssvc_join_password_buffer().
Günther Deschner [Mon, 3 Dec 2007 13:06:22 +0000 (14:06 +0100)]
Add decode_wkssvc_join_password_buffer().

Guenther

16 years agoReanimate rpcclient wkssvc command.
Günther Deschner [Mon, 3 Dec 2007 11:42:17 +0000 (12:42 +0100)]
Reanimate rpcclient wkssvc command.

Guenther

16 years agoActually implement reboot feature for net dom join/unjoin.
Günther Deschner [Mon, 3 Dec 2007 10:07:27 +0000 (11:07 +0100)]
Actually implement reboot feature for net dom join/unjoin.

Guenther

16 years agoReformatting
Volker Lendecke [Mon, 3 Dec 2007 09:45:47 +0000 (10:45 +0100)]
Reformatting

16 years agoFix some bogus uninitialized variable warnings
Volker Lendecke [Sat, 1 Dec 2007 10:41:44 +0000 (11:41 +0100)]
Fix some bogus uninitialized variable warnings

16 years agoBump up debug level
Volker Lendecke [Sun, 2 Dec 2007 11:54:11 +0000 (12:54 +0100)]
Bump up debug level

Fix bug 5115

16 years agoIn nttransact_create, we also need to check for delete readonly
Volker Lendecke [Sat, 1 Dec 2007 14:01:01 +0000 (15:01 +0100)]
In nttransact_create, we also need to check for delete readonly

16 years agoFix some C++ warnings
Volker Lendecke [Sat, 1 Dec 2007 10:43:12 +0000 (11:43 +0100)]
Fix some C++ warnings

16 years agoFix an uninitialized variable
Volker Lendecke [Sat, 1 Dec 2007 10:43:00 +0000 (11:43 +0100)]
Fix an uninitialized variable

16 years agoFix some C++ warnings
Volker Lendecke [Sat, 1 Dec 2007 10:42:32 +0000 (11:42 +0100)]
Fix some C++ warnings

I think were are actually bugs.

16 years agoFix missing error cleanup noticed by Derrell.
Jeremy Allison [Sat, 1 Dec 2007 05:57:43 +0000 (21:57 -0800)]
Fix missing error cleanup noticed by Derrell.
Jeremy.

16 years agoEnsure we have 2 bytes of zeros as a pad-buffer at the
Jeremy Allison [Sat, 1 Dec 2007 02:02:19 +0000 (18:02 -0800)]
Ensure we have 2 bytes of zeros as a pad-buffer at the
end of all returned trans/trans2/nttrans client replies.
Not included in a count - for safety purposes.
Jeremy.

16 years agoWhitespace cleanup.
Jeremy Allison [Sat, 1 Dec 2007 00:45:44 +0000 (16:45 -0800)]
Whitespace cleanup.
Jeremy.

16 years agoRemove pstring from clirap.c.
Jeremy Allison [Sat, 1 Dec 2007 00:13:35 +0000 (16:13 -0800)]
Remove pstring from clirap.c.
Jeremy.

16 years agoRemoved all pstrings from libsmbclient. Derryl please
Jeremy Allison [Fri, 30 Nov 2007 22:19:55 +0000 (14:19 -0800)]
Removed all pstrings from libsmbclient. Derryl please
check. Passes valgrind tests I've run in examples/libsmbclient.
Jeremy.

16 years agoFix restart after length count.
Jeremy Allison [Fri, 30 Nov 2007 22:15:34 +0000 (14:15 -0800)]
Fix restart after length count.
Jeremy.

16 years agoAvoid to include net prototypes, just reference user creds.
Günther Deschner [Fri, 30 Nov 2007 19:33:51 +0000 (20:33 +0100)]
Avoid to include net prototypes, just reference user creds.

Guenther

16 years agoAdd "net dom" command suite to "net".
Günther Deschner [Fri, 30 Nov 2007 19:21:37 +0000 (20:21 +0100)]
Add "net dom" command suite to "net".

Guenther

16 years agoAdd "net dom unjoin" code.
Günther Deschner [Fri, 30 Nov 2007 19:20:54 +0000 (20:20 +0100)]
Add "net dom unjoin" code.

Guenther

16 years agoAdd "net dom join" code.
Günther Deschner [Fri, 30 Nov 2007 19:20:18 +0000 (20:20 +0100)]
Add "net dom join" code.

Guenther

16 years agoAdd header file for NetJoinDomain() and friends.
Günther Deschner [Fri, 30 Nov 2007 19:18:46 +0000 (20:18 +0100)]
Add header file for NetJoinDomain() and friends.

Guenther

16 years agoAdd NetUnjoinDomain().
Günther Deschner [Fri, 30 Nov 2007 18:57:08 +0000 (19:57 +0100)]
Add NetUnjoinDomain().

Guenther

16 years agoRobustness-fixes for NetJoinDomain().
Günther Deschner [Fri, 30 Nov 2007 18:56:41 +0000 (19:56 +0100)]
Robustness-fixes for NetJoinDomain().

Guenther

16 years agoGive NetJoinDomain() enough time to finish.
Günther Deschner [Fri, 30 Nov 2007 18:55:40 +0000 (19:55 +0100)]
Give NetJoinDomain() enough time to finish.

Guenther

16 years agodomain_name is a ref pointer.
Günther Deschner [Fri, 30 Nov 2007 18:52:27 +0000 (19:52 +0100)]
domain_name is a ref pointer.

Guenther

16 years agoMerge join error codes from Samba 4.
Günther Deschner [Fri, 30 Nov 2007 18:46:25 +0000 (19:46 +0100)]
Merge join error codes from Samba 4.

Guenther

16 years agoAdd NetJoinDomain call.
Günther Deschner [Fri, 30 Nov 2007 17:49:21 +0000 (18:49 +0100)]
Add NetJoinDomain call.

Guenther

16 years agoMove param helper routines to one place.
Günther Deschner [Fri, 30 Nov 2007 17:47:25 +0000 (18:47 +0100)]
Move param helper routines to one place.

Guenther

16 years agoMake encode_wkssvc_join_password_buffer() non-static.
Günther Deschner [Fri, 30 Nov 2007 13:34:33 +0000 (14:34 +0100)]
Make encode_wkssvc_join_password_buffer() non-static.

Guenther

16 years agoMerge encode_wkssvc_join_password_buffer() from samba4.
Günther Deschner [Fri, 30 Nov 2007 13:05:53 +0000 (14:05 +0100)]
Merge encode_wkssvc_join_password_buffer() from samba4.

Guenther

16 years agoAdd talloc versions of all the next_token() functions.
Jeremy Allison [Fri, 30 Nov 2007 21:09:04 +0000 (13:09 -0800)]
Add talloc versions of all the next_token() functions.
Now I can really start removing fixed length strings...
Jeremy.

16 years agoRemove pstrings from clifile.c.
Jeremy Allison [Fri, 30 Nov 2007 01:47:31 +0000 (17:47 -0800)]
Remove pstrings from clifile.c.
Jeremy.

16 years agoRemove PSTRING_LEN from smbd/ nmbd/.
Jeremy Allison [Fri, 30 Nov 2007 01:25:41 +0000 (17:25 -0800)]
Remove PSTRING_LEN from smbd/ nmbd/.
Remove pstring from libsmb/clidfs.c except for a nasty
hack (that will be removed when pstrings are gone from
client/).
Jeremy.

16 years agoFix _reg_perfcount_get_instance_info()
Günther Deschner [Fri, 30 Nov 2007 01:16:46 +0000 (02:16 +0100)]
Fix _reg_perfcount_get_instance_info()

Guenther

16 years agoMerge recent wkssvc changes from samba4.
Günther Deschner [Fri, 30 Nov 2007 00:44:44 +0000 (01:44 +0100)]
Merge recent wkssvc changes from samba4.

Guenther

16 years agoFix build warning.
Günther Deschner [Tue, 27 Nov 2007 17:09:50 +0000 (18:09 +0100)]
Fix build warning.

Guenther

16 years agoFix memleak.
Jeremy Allison [Fri, 30 Nov 2007 00:30:18 +0000 (16:30 -0800)]
Fix memleak.
Jeremy.

16 years agoRemove the explicit TALLOC_CTX * from cli_struct.
Jeremy Allison [Thu, 29 Nov 2007 21:24:54 +0000 (13:24 -0800)]
Remove the explicit TALLOC_CTX * from cli_struct.
Make us very explicit about how long a talloc ctx
should last.
Jeremy.

16 years agoRemove pstrings. Ensure we validate offsets.
Jeremy Allison [Thu, 29 Nov 2007 21:24:14 +0000 (13:24 -0800)]
Remove pstrings. Ensure we validate offsets.
Jeremy.

16 years agoMerge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Thu, 29 Nov 2007 17:48:33 +0000 (09:48 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test

16 years agoAllow calling "net rpc join" and "net rpc trustdom" without specifying server IP.
Michael Adam [Thu, 29 Nov 2007 14:16:06 +0000 (15:16 +0100)]
Allow calling "net rpc join" and "net rpc trustdom" without specifying server IP.

This was a logic bug (typo) in a call to get_pdc_ip() in net_find_server().

Michael

16 years agoRemove unused code (and pstring).
Jeremy Allison [Wed, 28 Nov 2007 22:08:49 +0000 (14:08 -0800)]
Remove unused code (and pstring).
Jeremy.

16 years agoAdd a warning for a potential bug I've run into
Volker Lendecke [Wed, 28 Nov 2007 12:43:31 +0000 (13:43 +0100)]
Add a warning for a potential bug I've run into

16 years agoGive rpcclient a talloc stackframe.
Michael Adam [Wed, 28 Nov 2007 14:24:18 +0000 (15:24 +0100)]
Give rpcclient a talloc stackframe.

Michael

16 years agoRemove pstrings from asn1.c.
Jeremy Allison [Wed, 28 Nov 2007 07:40:54 +0000 (23:40 -0800)]
Remove pstrings from asn1.c.
Jeremy.

16 years agoRemove pstrings from namequery.c.
Jeremy Allison [Wed, 28 Nov 2007 07:10:20 +0000 (23:10 -0800)]
Remove pstrings from namequery.c.
Jeremy.

16 years agoFixed obvious typo.
Jeremy Allison [Wed, 28 Nov 2007 07:00:11 +0000 (23:00 -0800)]
Fixed obvious typo.
Jeremy.

16 years agoRemove unused prototype for smbldap_get_single_pstring().
Jeremy Allison [Wed, 28 Nov 2007 06:22:35 +0000 (22:22 -0800)]
Remove unused prototype for smbldap_get_single_pstring().
Don't use pstr_sprintf() on an fstring - change to talloc.
Jeremy.

16 years agoSave one extra strdup per lp_string. Use talloc_sub_basic()
Jeremy Allison [Wed, 28 Nov 2007 03:12:42 +0000 (19:12 -0800)]
Save one extra strdup per lp_string. Use talloc_sub_basic()
directly.
Jeremy.

16 years agoRemove pstring from srv_spoolss_nt.c. All gone from rpc_server/*.c
Jeremy Allison [Wed, 28 Nov 2007 03:05:08 +0000 (19:05 -0800)]
Remove pstring from srv_spoolss_nt.c. All gone from rpc_server/*.c
Jeremy.

16 years agoFix old cut-and-paste bug where the wrong field was being written to.
Jeremy Allison [Wed, 28 Nov 2007 01:50:39 +0000 (17:50 -0800)]
Fix old cut-and-paste bug where the wrong field was being written to.
Jerry please check.
Jeremy.

16 years agoWhitespace cleanup.
Jeremy Allison [Wed, 28 Nov 2007 01:48:59 +0000 (17:48 -0800)]
Whitespace cleanup.
Jeremy.

16 years agoMake init_unistr2_from_unistr take an explicit talloc context.
Jeremy Allison [Wed, 28 Nov 2007 01:48:44 +0000 (17:48 -0800)]
Make init_unistr2_from_unistr take an explicit talloc context.
Make init_unistr() re-use rpcstr_push_talloc().
Jeremy.

16 years agoRemove pstrings from everything except srv_spoolss_nt.c.
Jeremy Allison [Tue, 27 Nov 2007 22:35:30 +0000 (14:35 -0800)]
Remove pstrings from everything except srv_spoolss_nt.c.
Jeremy.

16 years agofix a obscure compiler warning
Guenther Deschner [Tue, 27 Nov 2007 20:53:41 +0000 (21:53 +0100)]
fix a obscure compiler warning

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Jeremy,

I have never seen this warning before:
"warning: comparison is always false due to limited range of data type".

Guenther
- --
Günther Deschner                    GPG-ID: 8EE11688
Red Hat                         gdeschner@redhat.com
Samba Team                              gd@samba.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFHTIOOSOk3aI7hFogRArxMAJwP0ktE96tHcwn9nXG6AOqonpeDgQCgm/zi
54B6HJZvx6zdUTMFFNWqUb0=
=kUJa
-----END PGP SIGNATURE-----

>From 6a4935ee455adc1251fce2759f97d35f303bd40e Mon Sep 17 00:00:00 2001
From: =?utf-8?q?G=C3=BCnther=20Deschner?= <gd@samba.org>
Date: Tue, 27 Nov 2007 21:48:39 +0100
Subject: [PATCH] Getting rid of "comparison is always false due to limited range of data type"
 warning.

Guenther

16 years agoRemove pstring from everything in rpc_server except
Jeremy Allison [Tue, 27 Nov 2007 19:22:58 +0000 (11:22 -0800)]
Remove pstring from everything in rpc_server except
srv_spoolss_nt.c and srv_srvsvc_nt.c.
They're next :-).
Jeremy.

16 years agoUnless talloc has some new magic there is a ctx missing here.
Günther Deschner [Tue, 27 Nov 2007 17:01:56 +0000 (18:01 +0100)]
Unless talloc has some new magic there is a ctx missing here.

Guenther

16 years agoUse the proper boolean constants - the type has been
Michael Adam [Tue, 27 Nov 2007 15:36:06 +0000 (16:36 +0100)]
Use the proper boolean constants - the type has been
changed from BOOL to bool.

Michael

16 years agoRemove some statics
Volker Lendecke [Sun, 25 Nov 2007 09:10:52 +0000 (10:10 +0100)]
Remove some statics

16 years agoRemove pstrings from nsswitch/ and registry/
Jeremy Allison [Tue, 27 Nov 2007 01:24:56 +0000 (17:24 -0800)]
Remove pstrings from nsswitch/ and registry/
Jeremy.

16 years agoRemove a global
Volker Lendecke [Sat, 24 Nov 2007 16:27:19 +0000 (17:27 +0100)]
Remove a global

16 years agoFix bug 5055
Volker Lendecke [Mon, 26 Nov 2007 14:28:13 +0000 (15:28 +0100)]
Fix bug 5055

16 years agoImprove debug message
Volker Lendecke [Mon, 26 Nov 2007 13:30:50 +0000 (14:30 +0100)]
Improve debug message

Fix bug 5056, thanks to debian package maintainer

16 years agoFix a C++ warning
Volker Lendecke [Mon, 26 Nov 2007 10:55:55 +0000 (11:55 +0100)]
Fix a C++ warning

16 years ago1. lib/system.c (xattr code for Solaris) could not be
Tomoki AONO [Sat, 24 Nov 2007 16:59:40 +0000 (01:59 +0900)]
1. lib/system.c (xattr code for Solaris) could not be
built against c90 compilers. (declaration after
statement.) Sample patch attached.

16 years agoIn libsmbclient, map NT_STATUS_OBJECT_PATH_NOT_FOUND to ENOENT
Volker Lendecke [Sun, 25 Nov 2007 11:54:52 +0000 (12:54 +0100)]
In libsmbclient, map NT_STATUS_OBJECT_PATH_NOT_FOUND to ENOENT

Thanks to SATOH Fumiyasu!

This fixes bug 4974

16 years agoRemove a static
Volker Lendecke [Sat, 24 Nov 2007 15:32:38 +0000 (16:32 +0100)]
Remove a static

16 years agoMake remote_password_change return malloced error strings
Volker Lendecke [Fri, 23 Nov 2007 11:04:35 +0000 (12:04 +0100)]
Make remote_password_change return malloced error strings

This fixes a segfault in smbpasswd -r

16 years agoadd talloc_stackframe() to eventlogadm
Volker Lendecke [Fri, 23 Nov 2007 13:34:13 +0000 (14:34 +0100)]
add talloc_stackframe() to eventlogadm

Thanks to Günther Kukkukk for noticing

16 years agoprinting: fix default printing subsystem detection
Stefan Metzmacher [Fri, 23 Nov 2007 10:51:33 +0000 (11:51 +0100)]
printing: fix default printing subsystem detection

"system/printing.h" includes an outdated copy of
the stuff in samba3's includes.h, so we should not use it.

metze

16 years agosmbd: close_stat() should be static
Stefan Metzmacher [Wed, 21 Nov 2007 15:41:12 +0000 (16:41 +0100)]
smbd: close_stat() should be static

metze

16 years agoDo not link in SOCKET_WRAPPER_OBJ twice
Volker Lendecke [Thu, 22 Nov 2007 14:48:47 +0000 (15:48 +0100)]
Do not link in SOCKET_WRAPPER_OBJ twice

16 years agoCosmetic fix
Volker Lendecke [Wed, 7 Nov 2007 19:18:38 +0000 (20:18 +0100)]
Cosmetic fix

16 years agoAdd a missing prototype
Volker Lendecke [Tue, 13 Nov 2007 10:43:48 +0000 (11:43 +0100)]
Add a missing prototype

16 years agoFix an uninitialized variable
Volker Lendecke [Mon, 12 Nov 2007 16:36:34 +0000 (17:36 +0100)]
Fix an uninitialized variable

16 years agoFix a type-punned warning
Volker Lendecke [Fri, 16 Nov 2007 13:48:26 +0000 (14:48 +0100)]
Fix a type-punned warning

16 years agoMerge ssh://git.samba.org/data/git/samba into v3-2-test
James Peach [Thu, 22 Nov 2007 02:31:35 +0000 (18:31 -0800)]
Merge ssh://git.samba.org/data/git/samba into v3-2-test

16 years agoRemove pstrings from pam_smbpass - make local_password_change
Jeremy Allison [Thu, 22 Nov 2007 01:42:52 +0000 (17:42 -0800)]
Remove pstrings from pam_smbpass - make local_password_change
return malloced strings.
Jeremy.

16 years agoRemove pstring from printing/*.c except for the
Jeremy Allison [Wed, 21 Nov 2007 21:56:36 +0000 (13:56 -0800)]
Remove pstring from printing/*.c except for the
tdb_unpack requirement (I'll be making that an
allocating interface later).
Jeremy.

16 years agoDoh ! Don't use #else when #endif is needed.
Jeremy Allison [Wed, 21 Nov 2007 18:31:18 +0000 (10:31 -0800)]
Doh ! Don't use #else when #endif is needed.
Jeremy.

16 years agoAdd set_sockaddr_port function for winbindd.
Jeremy Allison [Wed, 21 Nov 2007 18:10:52 +0000 (10:10 -0800)]
Add set_sockaddr_port function for winbindd.
Jeremy.

16 years agoAllocate a talloc_stackframe() in main() for wbinfo.
Gerald (Jerry) Carter [Wed, 21 Nov 2007 16:27:22 +0000 (10:27 -0600)]
Allocate a talloc_stackframe() in main() for wbinfo.

16 years agoFix unresolved symbols in smbumount from addition of talloc_stackframe().
Gerald (Jerry) Carter [Wed, 21 Nov 2007 16:27:01 +0000 (10:27 -0600)]
Fix unresolved symbols in smbumount from addition of talloc_stackframe().

16 years agoAdd talloc stackframe for ntlm_auth.c
Jeremy Allison [Wed, 21 Nov 2007 03:17:47 +0000 (19:17 -0800)]
Add talloc stackframe for ntlm_auth.c
Jeremy.

16 years agoRemove pstrcpy I missed.
Jeremy Allison [Wed, 21 Nov 2007 03:05:30 +0000 (19:05 -0800)]
Remove pstrcpy I missed.
Jeremy.

16 years agoMore pstring removal....
Jeremy Allison [Wed, 21 Nov 2007 02:55:36 +0000 (18:55 -0800)]
More pstring removal....
Jeremy.

16 years agoRemove pstring from services/*.c
Jeremy Allison [Wed, 21 Nov 2007 01:57:47 +0000 (17:57 -0800)]
Remove pstring from services/*.c
Jeremy.

16 years agoEnsure we have a talloc stackframe (found by Kukks).
Jeremy Allison [Wed, 21 Nov 2007 01:54:01 +0000 (17:54 -0800)]
Ensure we have a talloc stackframe (found by Kukks).
Jeremy.

16 years agoMore pstring elimination.
Jeremy Allison [Wed, 21 Nov 2007 01:18:16 +0000 (17:18 -0800)]
More pstring elimination.
Jeremy.

16 years agoExtend commit module to help with NFS quotas.
David Losada Carballo [Wed, 21 Nov 2007 00:45:33 +0000 (16:45 -0800)]
Extend commit module to help with NFS quotas.

Add "commit on eof" and "commit past eof" modes. Patch from David
Losada Carballo with some modifications during the merge.

16 years agoMore trivial pstring removal.
Jeremy Allison [Tue, 20 Nov 2007 23:31:37 +0000 (15:31 -0800)]
More trivial pstring removal.
Jeremy.

16 years agoParanoia check that space_remaining never goes -ve.
Jeremy Allison [Tue, 20 Nov 2007 23:31:18 +0000 (15:31 -0800)]
Paranoia check that space_remaining never goes -ve.
Jeremy.

16 years agoPrevent segv in winbindd running on a DC using the "idmap backend" syntax.
Gerald (Jerry) Carter [Tue, 20 Nov 2007 19:24:03 +0000 (13:24 -0600)]
Prevent segv in winbindd running on a DC using the "idmap backend" syntax.

The number of domains should be counted as they are added and not assumed
to match the loop counter.

manually cherry-picked 8ad2826c48a0d4d26abc3bb209860c776f55822f

16 years agoRemove more pstring. Unify talloc_sub functions to make
Jeremy Allison [Tue, 20 Nov 2007 02:56:22 +0000 (18:56 -0800)]
Remove more pstring. Unify talloc_sub functions to make
them a better match for replacing string_sub. Remove
more unused code.
Jeremy.

16 years agoStart to remove some of the pstring functions we're
Jeremy Allison [Tue, 20 Nov 2007 01:51:21 +0000 (17:51 -0800)]
Start to remove some of the pstring functions we're
no longer using.
Jeremy.

16 years agoAlways check return from push_ascii.
Jeremy Allison [Tue, 20 Nov 2007 01:43:28 +0000 (17:43 -0800)]
Always check return from push_ascii.
Jeremy.

16 years agoAdd stackframes to public libsmbclient functions
Volker Lendecke [Mon, 19 Nov 2007 11:36:16 +0000 (12:36 +0100)]
Add stackframes to public libsmbclient functions

As we use talloc_tos() in inner libsmbclient/ functions more and more, we need
to make sure not to create memleaks by not free'ing talloc stackframes. This
patch wraps all calls in libsmbclient.c that are publically exported into a
talloc_stackframe()/talloc_free() pair.

Jeremy, Derrell, can you check this?

Thanks,

Volker

16 years agoRemove pstring from nmbd.
Jeremy Allison [Mon, 19 Nov 2007 23:15:09 +0000 (15:15 -0800)]
Remove pstring from nmbd.
Jeremy.