Andrew Tridgell [Wed, 16 Dec 2009 01:01:16 +0000 (12:01 +1100)]
s4-dsdb: added a dsdb_module_rename() call
This will be used by the replmd_delete() code
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Wed, 16 Dec 2009 00:32:57 +0000 (11:32 +1100)]
s4-dsdb: added dsdb_module_modify()
This is used to do a sync modify in a module
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Wed, 16 Dec 2009 00:31:30 +0000 (11:31 +1100)]
s4-dsdb: fixed dsdb_module_dn_by_guid()
needs to ask for the DN in storage format, plus fix compilation errors
Andrew Tridgell [Wed, 16 Dec 2009 00:30:03 +0000 (11:30 +1100)]
s4-dsdb: dsdb_flags should be unsigned
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Wed, 16 Dec 2009 00:28:50 +0000 (11:28 +1100)]
s4-dsdb: rename dsdb_module_search_handle_flags to dsdb_request_add_controls
This function will be used for non-search controls, like relax
Andrew Tridgell [Tue, 15 Dec 2009 23:27:32 +0000 (10:27 +1100)]
s4-dsdb: added dsdb_module_dn_by_guid()
This finds a DN given a GUID, searching below the current module in
the module stack.
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Tue, 15 Dec 2009 00:01:18 +0000 (11:01 +1100)]
s4-dsdb: use dsdb_dn_is_deleted_val()
This also moves the check to before we parse the DN, which saves some
unnecessary work
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Tue, 15 Dec 2009 00:00:30 +0000 (11:00 +1100)]
s4-dsdb: added dsdb_dn_is_deleted_val()
This is used to determine if a extedned DN has the 'DELETED=1'
component
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Tue, 15 Dec 2009 22:32:10 +0000 (09:32 +1100)]
s4-ntvfs: try to fix bug 6989
bug 6989 is a rare crash that has occurred in production. My best
guess as to the cause is the talloc_free() not being specific enough
as to which parent needs to be freed.
Matthias Dieter Wallnöfer [Wed, 16 Dec 2009 08:45:22 +0000 (09:45 +0100)]
s4:drsuapi/getncchanges.c - Update the list of operational attributes
- Reorder them as specified in "operational.c"
- Add also the lan manager hash password attribute
Jeremy Allison [Wed, 16 Dec 2009 02:03:47 +0000 (18:03 -0800)]
Ensure dos_mode can return FILE_ATTRIBUTE_NORMAL, then filter the returned attributes by protocol level.
This makes us consistant in returning DOS attrs across all replies. Tested on OS/2 by Günter Kukkukk.
Jeremy.
Günther Deschner [Tue, 15 Dec 2009 21:26:39 +0000 (22:26 +0100)]
s4-smbtorture: run GetPrinterDriver2 tests against each printer's driver.
Guenther
Stefan Metzmacher [Tue, 15 Dec 2009 15:52:00 +0000 (16:52 +0100)]
s4:prog_guide4.txt: remove obsolete comments
metze
Andreas Schneider [Tue, 15 Dec 2009 15:46:03 +0000 (16:46 +0100)]
s4: Fixed the programming guide to reflect the current tree.
Andreas Schneider [Tue, 15 Dec 2009 11:58:40 +0000 (12:58 +0100)]
s4-kdc: Migrate to tsocket_address.
Andreas Schneider [Tue, 15 Dec 2009 11:58:18 +0000 (12:58 +0100)]
tsocket: Fixed tsocket_guide.txt asciidoc syntax.
Andreas Schneider [Tue, 15 Dec 2009 11:57:35 +0000 (12:57 +0100)]
tsocket: Fixed documentation for tsocket_address_bsd_sockaddr().
Andreas Schneider [Tue, 15 Dec 2009 11:56:44 +0000 (12:56 +0100)]
tsocket: Fixed typo in LGPL header.
Stefan Metzmacher [Wed, 4 Nov 2009 18:03:41 +0000 (19:03 +0100)]
tsocket: add tsocket_address_bsd_sockaddr() and tsocket_address_bsd_from_sockaddr()
metze
Volker Lendecke [Tue, 15 Dec 2009 16:49:24 +0000 (17:49 +0100)]
smbtorture4: Add rpc-samba3-getaliasmembership-0
Volker Lendecke [Tue, 15 Dec 2009 13:01:43 +0000 (14:01 +0100)]
s3: Fix _samr_GetAliasMembership for results with 0 rids
Nadezhda Ivanova [Tue, 15 Dec 2009 18:29:20 +0000 (20:29 +0200)]
Removed ldb_modify_ctrl from ldb, implemented as a static in ldap_backend.
Aravind Srinivasan [Tue, 15 Dec 2009 17:49:08 +0000 (09:49 -0800)]
s4 torture: Add new RAW-SEARCH test to explore strange max count behavior
Signed-off-by: Tim Prouty <tprouty@samba.org>
Aravind Srinivasan [Tue, 15 Dec 2009 17:22:07 +0000 (09:22 -0800)]
s4 torture: Update RAW-QFILEINFO to only test info levels that are supported by the server
Signed-off-by: Tim Prouty <tprouty@samba.org>
Zach Loafman [Mon, 14 Dec 2009 18:31:02 +0000 (10:31 -0800)]
s4 torture: Convert RAW-OPEN to suite form
Tim Prouty [Tue, 15 Dec 2009 01:00:43 +0000 (17:00 -0800)]
s4 torture: Add SHARE_DELETE to create_directory_handle
Tests explicitly checking share modes should open the dir/file
with the share mode they want to test.
Simo Sorce [Tue, 15 Dec 2009 14:17:25 +0000 (09:17 -0500)]
Fix release script to work with recent git versions
Brian Lu [Tue, 15 Dec 2009 11:56:23 +0000 (12:56 +0100)]
s4:tls: fix the build on Solaris
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Nadezhda Ivanova [Tue, 15 Dec 2009 10:02:20 +0000 (12:02 +0200)]
Fixed a problem with duplicate values of allowedAttributesEffective.
Matthieu Patou [Sat, 12 Dec 2009 16:13:15 +0000 (19:13 +0300)]
s4: rename res/res2 to something more explicit
Matthieu Patou [Sat, 12 Dec 2009 13:28:31 +0000 (16:28 +0300)]
s4: upgradeprovision handle renaming and knownobjects
Matthieu Patou [Sat, 12 Dec 2009 15:33:53 +0000 (18:33 +0300)]
s4: upgradeprovision rename also when there is a mismatch on the case of name attribute
Renaming not only helps when name attribute is not here
it also helps when the case is not the good one. So
in order to avoid problem and have as much as possible similar provision
we should use the rename whenever a name difference appear.
Matthieu Patou [Sun, 29 Nov 2009 23:37:35 +0000 (02:37 +0300)]
s4: reorder action to permit old provision to be correctly upgraded
Endi Sukma Dewata [Tue, 8 Dec 2009 20:55:16 +0000 (14:55 -0600)]
s4:provision - Remap conflicting thumbnailPhoto and thumbnailLogo OID's.
Volker Lendecke [Mon, 14 Dec 2009 15:48:38 +0000 (16:48 +0100)]
s3: Allow up to 20480 entries in LookupSids, as mandated by the official IDL
Seen in the wild by putting >1000 users into BUILTIN\Users
Andrew Tridgell [Mon, 14 Dec 2009 10:53:40 +0000 (21:53 +1100)]
s4-dsdb: added REVEAL_INTERNALS flag to dsdb_module_search_handle_flags()
Andrew Tridgell [Mon, 14 Dec 2009 07:02:15 +0000 (18:02 +1100)]
s4-devel: support vampire_ad.sh with no initial smb.conf
Andrew Tridgell [Mon, 14 Dec 2009 06:54:04 +0000 (17:54 +1100)]
s4-loadparm: call reload_charcnv() also for a missing smb.conf
bin/net vampire with a missing smb.conf would segfault as the iconv
convenience pointer had not been setup.
Andrew Tridgell [Fri, 11 Dec 2009 06:33:32 +0000 (17:33 +1100)]
s4-dsdb: return a zero guid on error in samdb_result_guid()
Andrew Tridgell [Fri, 11 Dec 2009 03:39:33 +0000 (14:39 +1100)]
heimdal: work around differences between GNU and XSI strerror_r()
This is a fairly ugly workaround, but then again, strerror_r() is a
very ugly mess.
Andrew Tridgell [Thu, 10 Dec 2009 12:46:34 +0000 (23:46 +1100)]
s4-dsdb: use the reveal control to hide/show extended DN components
When reveal is set, then we show deleted linked attributes and all
linkked attribute components. When not set we show a normal extended
DN.
Andrew Tridgell [Thu, 10 Dec 2009 12:45:16 +0000 (23:45 +1100)]
s4-ldb: added new ldb_dn extended components for linked attributes
These will store linked attribute replication meta data
Andrew Tridgell [Thu, 10 Dec 2009 12:44:44 +0000 (23:44 +1100)]
s4-ldb: added a function to filter extended components of a ldb_dn
We need to be able to filter out components that should not be exposed
to users
Andrew Tridgell [Thu, 10 Dec 2009 12:44:05 +0000 (23:44 +1100)]
s4-ldb: added a new "reveal" control
This control will allow inspection of internal ldb values, which would
normally be stripped before being presented to users. The first use
will be stripping linked attribute meta data extended components.
Andrew Tridgell [Thu, 10 Dec 2009 11:45:36 +0000 (22:45 +1100)]
s4-ldb: sort the linearized extended DN by component name
This will make life easier when handling deleted linked attributes
Brian Lu [Mon, 14 Dec 2009 10:08:07 +0000 (11:08 +0100)]
librpc/ndr: avoid comparison_fn_t to fix the openchange build on solaris
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Matthieu Patou [Sun, 13 Dec 2009 15:44:02 +0000 (18:44 +0300)]
add ignore for autogenrated files as they are not used by s3
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Matthieu Patou [Sun, 13 Dec 2009 15:41:53 +0000 (18:41 +0300)]
torture: add new tests for dfsblobs
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Matthieu Patou [Sun, 13 Dec 2009 02:03:03 +0000 (05:03 +0300)]
idl: introduce new file: dfsblobs.idl
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Mon, 14 Dec 2009 09:52:56 +0000 (10:52 +0100)]
librpc/ndr: add missing prototypes for relative_short functions
metze
Günther Deschner [Sat, 12 Dec 2009 01:52:41 +0000 (02:52 +0100)]
spoolss: fix spoolss_PrinterData size calculation.
Currently we were crashing in EnumPrinterDataEx when an e.g. an empty (NULL)
string for a separator file was returned.
Guenther
Günther Deschner [Sat, 12 Dec 2009 01:51:44 +0000 (02:51 +0100)]
spoolss: trivial fix for spoolss_FormInfo2 IDL.
Guenther
Günther Deschner [Sat, 12 Dec 2009 00:51:13 +0000 (01:51 +0100)]
s4-smbtorture: check whether a returned buffer size is a multiple of 4 in RPC-SPOOLSS.
This gives a good indication where our IDL (and the s3 spoolss implementation) is still wrong.
Guenther
Karolin Seeger [Mon, 14 Dec 2009 07:58:50 +0000 (08:58 +0100)]
s3:docs: Fix 'make manpages3'.
Karolin
Matthias Dieter Wallnöfer [Sun, 13 Dec 2009 15:13:34 +0000 (16:13 +0100)]
s4:"samdb_set_password_sid" - clean up created objects correctly
- We should clean up such "helper" objects created in this function to don't
have them around until "mem_ctx" is destroyed
- Remove a from my view pointless comment "This is a password set, not change"
since an external argument "user_change" decides this ("modify" or "(re)set")
Matthias Dieter Wallnöfer [Sat, 12 Dec 2009 16:59:05 +0000 (17:59 +0100)]
s4:operational LDB module - cosmetic - reorder an attribute list
This matches the default handling order in the "password_hash" module (it's nice
to have this consistent).
Volker Lendecke [Sat, 12 Dec 2009 15:58:31 +0000 (16:58 +0100)]
s3: Fix a very embarrassing build failure
Matthieu Patou [Thu, 10 Dec 2009 07:04:48 +0000 (10:04 +0300)]
pidl: Introduce new dirrective: relative_short
relative_short is like relative but instead of having the offset coded on 4 bytes
it's coded on 2 bytes. Such things happen in GET_DFS_REFERAL messages.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Matthieu Patou [Thu, 10 Dec 2009 07:04:48 +0000 (10:04 +0300)]
librpc/ndr: add support for relative_short pointers
relative_short is like relative but instead of having the offset coded on 4 bytes
it's coded on 2 bytes. Such things happen in GET_DFS_REFERAL messages.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Matthias Dieter Wallnöfer [Fri, 11 Dec 2009 19:19:16 +0000 (20:19 +0100)]
s4:utils/oLschema2ldif.c - remove (now) unused variables
Björn Jacke [Fri, 11 Dec 2009 12:28:31 +0000 (13:28 +0100)]
s3:docs: document ldap deref
Karolin Seeger [Fri, 11 Dec 2009 10:56:26 +0000 (11:56 +0100)]
s3:loadparm: Change the "ldap deref" value "defualt" to "auto".
That's an established value. Default is a bit confusing.
Karolin
Matthias Dieter Wallnöfer [Fri, 11 Dec 2009 10:17:37 +0000 (11:17 +0100)]
s4:libnet/libnet_become_dc - Fix a small glitch in "becomeDC_drsuapi1_add_entry_send"
We shouldn't use the now uninitialised "status" variable anymore.
Björn Jacke [Thu, 10 Dec 2009 22:19:26 +0000 (23:19 +0100)]
s3: add prototype to fix the build
Günther Deschner [Thu, 10 Dec 2009 19:38:32 +0000 (20:38 +0100)]
s3-selftest: enable RPC-SAMBA3-WINREG.
Very strange we didn't run it before.
Guenther
Günther Deschner [Wed, 9 Dec 2009 14:49:46 +0000 (15:49 +0100)]
s3-rpcclient: allow to set offered size for enumkey command.
Guenther
Günther Deschner [Wed, 2 Dec 2009 23:35:03 +0000 (00:35 +0100)]
s4-smbtorture: add more spoolss_EnumPrinterKey tests for local NDR test.
Guenther
Björn Jacke [Thu, 10 Dec 2009 21:22:54 +0000 (22:22 +0100)]
s3: make own defines for ldap deref types
there are too many naming clashes between different ldap libs and ldb libs.
Let's simply make our own defines. The numbers are well standarized. This also
makes the default for "ldap deref" be "default" which means we won't tell the
ldap library what to do. Ѕo by default it's all up to what the server and our
libs think they should to do.
Björn Jacke [Thu, 10 Dec 2009 20:00:26 +0000 (21:00 +0100)]
s3: add LDAP Alias Dereferencing support
Thanks to Dan Cox for initial patch for 3.0. This closes #2350.
Günther Deschner [Thu, 10 Dec 2009 13:23:49 +0000 (14:23 +0100)]
spoolss: remove unused spoolss_StringArray2.
Guenther
Günther Deschner [Thu, 10 Dec 2009 13:21:12 +0000 (14:21 +0100)]
s4-smbtorture: fix and extend enum printerkey test.
Guenther
Günther Deschner [Thu, 10 Dec 2009 13:20:22 +0000 (14:20 +0100)]
s3-spoolss: fix enumprinter key client and server.
Guenther
Günther Deschner [Thu, 10 Dec 2009 13:27:33 +0000 (14:27 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Thu, 10 Dec 2009 13:19:28 +0000 (14:19 +0100)]
spoolss: use spoolss_KeyNames in spoolss_EnumPrinterKey.
Guenther
Günther Deschner [Thu, 10 Dec 2009 13:18:46 +0000 (14:18 +0100)]
spoolss: add spoolss_KeyNames union.
Guenther
Karolin Seeger [Thu, 10 Dec 2009 13:57:08 +0000 (14:57 +0100)]
s3:packaging: Fix version detection.
Adapted from
728b01fc03.
Thanks god I was not root! It would have delted /*!
Karolin
Nadezhda Ivanova [Thu, 10 Dec 2009 13:49:53 +0000 (15:49 +0200)]
Implementation of sDRightsEffective, allowedAttributesEffective and allowedChildClassesEffective.
Behavior as documented in WSPP and tested. Needs optimisation though.
Karolin Seeger [Thu, 10 Dec 2009 13:26:58 +0000 (14:26 +0100)]
s3:packaging: Fix source dir.
Karolin
Karolin Seeger [Thu, 10 Dec 2009 13:08:43 +0000 (14:08 +0100)]
s3:packaging: Fix typo in comment.
Karolin
Andrew Tridgell [Thu, 10 Dec 2009 06:23:00 +0000 (17:23 +1100)]
s4-ldb: fixed 2 bugs in ldb_dn_set_extended_component()
The first bug was that setting a component twice could cause it to
appear twice in the DN.
The second bug was that using an existing ldb_val from a previous call
of ldb_dn_get_extended_component() as an argument to
ldb_dn_set_extended_component() would cause a valgrind error (as the
array the val pointed into will change).
Andrew Tridgell [Thu, 10 Dec 2009 03:48:56 +0000 (14:48 +1100)]
s4-libcli: GUID_from_ndr_blob() is strict about the blob size
We need to create a blob of the right length
Andrew Tridgell [Thu, 10 Dec 2009 03:36:12 +0000 (14:36 +1100)]
s4-schema: use GUID_to_ndr_blob()
Andrew Tridgell [Thu, 10 Dec 2009 03:35:42 +0000 (14:35 +1100)]
s4-schema: use binsearch.h
Andrew Tridgell [Thu, 10 Dec 2009 03:35:24 +0000 (14:35 +1100)]
util: added binsearch.h for binary array searches
This was moved from the schema_query code. It will now be used in more
than one place, so best to make it a library macro. I think there are
quite a few places that could benefit from this.
Andrew Tridgell [Thu, 10 Dec 2009 03:33:13 +0000 (14:33 +1100)]
s4-dsdb: use GUID_to_ndr_blob()
Andrew Tridgell [Thu, 10 Dec 2009 03:32:47 +0000 (14:32 +1100)]
s4-ldb: use GUID_to_ndr_blob()
Andrew Tridgell [Thu, 10 Dec 2009 03:32:29 +0000 (14:32 +1100)]
s4-libnet: use GUID_to_ndr_blob()
Andrew Tridgell [Thu, 10 Dec 2009 03:32:15 +0000 (14:32 +1100)]
s4-libcli: use GUID_to_ndr_blob()
Andrew Tridgell [Thu, 10 Dec 2009 03:31:52 +0000 (14:31 +1100)]
s4-server: use GUID_to_ndr_blob() in cldap and smb servers
Andrew Tridgell [Thu, 10 Dec 2009 03:31:13 +0000 (14:31 +1100)]
libcli: use GUID_to_ndr_blob()
Andrew Tridgell [Thu, 10 Dec 2009 03:30:46 +0000 (14:30 +1100)]
s3-ldb: use GUID_to_ndr_blob()
this also fixes an error in NTSTATUS handling
Andrew Tridgell [Thu, 10 Dec 2009 03:29:19 +0000 (14:29 +1100)]
libndr: added a GUID_to_ndr_blob() helper function
This can be used in many places that deal with GUIDs
Andrew Tridgell [Thu, 10 Dec 2009 00:27:09 +0000 (11:27 +1100)]
s4-ldb: simplify ldif handlers using new GUID functions
Andrew Tridgell [Thu, 10 Dec 2009 00:26:36 +0000 (11:26 +1100)]
s4-dsdb: simplify samdb_result_guid()
Andrew Tridgell [Thu, 10 Dec 2009 00:26:18 +0000 (11:26 +1100)]
s4-dsdb: simplify linked attributes code using GUID functions
Andrew Tridgell [Thu, 10 Dec 2009 00:25:44 +0000 (11:25 +1100)]
s4-dsdb: simplify schema code using new GUID functions
Andrew Tridgell [Thu, 10 Dec 2009 00:25:13 +0000 (11:25 +1100)]
s4-smb2: use new GUID function in smb2 negprot
Andrew Tridgell [Thu, 10 Dec 2009 00:24:54 +0000 (11:24 +1100)]
s4-libcli: use new GUID functions in libcli
Andrew Tridgell [Thu, 10 Dec 2009 00:23:20 +0000 (11:23 +1100)]
s4-dsdb: use GUID_from_ndr_blob() to create dsdb_get_extended_dn_guid()
Andrew Tridgell [Thu, 10 Dec 2009 00:22:20 +0000 (11:22 +1100)]
librpc: split out a separate GUID_from_ndr_blob() function
This will simplify many of the places that deal with NDR formatted
GUIDs