Andrew Tridgell [Mon, 19 Oct 2009 08:16:39 +0000 (19:16 +1100)]
s4-libnet: fixed privilege handling in samsync to use the right db
I only noticed this one because of Karolins spelling fix :-)
Andrew Tridgell [Mon, 19 Oct 2009 07:46:02 +0000 (18:46 +1100)]
s4-pvfs: fill in alignment_requirement (valgrind error)
Karolin Seeger [Mon, 19 Oct 2009 08:40:15 +0000 (10:40 +0200)]
s4:test: Fix typo.
Karolin
Karolin Seeger [Mon, 19 Oct 2009 07:47:33 +0000 (09:47 +0200)]
Fix typo.
privilage -> privilege
Karolin
Andrew Tridgell [Mon, 19 Oct 2009 03:17:02 +0000 (14:17 +1100)]
Revert "selftest: fixed filter to know about a "error" result"
This reverts commit
1de7e43fb4a4863e3663af8b2a2d9f19cf82d7f3.
This is much more delicate than it seems
Andrew Tridgell [Mon, 19 Oct 2009 02:50:32 +0000 (13:50 +1100)]
s4-selftest: move secdesc.python test to skip list
This test produces a python backtrace due to
LDAP_INSUFFICIENT_ACCESS_RIGHTS errors, which are expected until the
new acl code is finished. The python backtrace overrides the
'knownfail' listing, so we need to skip this test for now.
Andrew Tridgell [Mon, 19 Oct 2009 02:25:55 +0000 (13:25 +1100)]
selftest: fixed filter to know about a "error" result
This is what caused some of the python tests to not match knownfail
entries
Andrew Tridgell [Mon, 19 Oct 2009 02:25:07 +0000 (13:25 +1100)]
s4-test: removed duplicate knownfail entry
Andrew Tridgell [Mon, 19 Oct 2009 01:59:49 +0000 (12:59 +1100)]
s4-pvfs: another uninitialised variable
thanks to valgrind for this one
Bo Yang [Wed, 14 Oct 2009 22:23:48 +0000 (06:23 +0800)]
s3: Don't fail authentication when one or some group of require-membership-of is invalid.
Signed-off-by: Bo Yang <boyang@samba.org>
Andrew Tridgell [Mon, 19 Oct 2009 00:56:53 +0000 (11:56 +1100)]
s4-pvfs: fixed uninitialised variable
This caused havoc on the build farm. Interestingly, it only affected
gcc 4.3.3, not gcc 4.4.1
Matthias Dieter Wallnöfer [Sun, 18 Oct 2009 16:13:17 +0000 (18:13 +0200)]
s4:ldb_msg_check_string_attribute - add a comment about the result values
Matthias Dieter Wallnöfer [Sun, 18 Oct 2009 16:00:59 +0000 (18:00 +0200)]
Revert "s4:ldb_msg - Use LDB constants on results"
This reverts commit
56a8baff3df6a5120b6c7bbca771dfb7c6934fd5.
Simo pointed out that I was wrong here.
Björn Jacke [Sun, 18 Oct 2009 15:01:57 +0000 (17:01 +0200)]
s3:configure: fix avahi activation
Avahi was correctly found but not activated since
e4a26c942.
Matthias Dieter Wallnöfer [Sun, 18 Oct 2009 12:30:50 +0000 (14:30 +0200)]
s4:torture "cldap" test - rework and test more results
Matthias Dieter Wallnöfer [Sun, 18 Oct 2009 09:59:11 +0000 (11:59 +0200)]
s4:sites - get the server site (name) from DSDB
Matthias Dieter Wallnöfer [Sun, 18 Oct 2009 09:11:57 +0000 (11:11 +0200)]
s4:dcerpc_netlogon - unify the two workstation object lookups (DNS hostname and supported encryption types)
This is simply for better performance (no functional change).
Matthias Dieter Wallnöfer [Sat, 17 Oct 2009 20:26:41 +0000 (22:26 +0200)]
s4:ldb_msg - Use LDB constants on results
Matthias Dieter Wallnöfer [Sat, 17 Oct 2009 20:27:42 +0000 (22:27 +0200)]
s4:ldb_ldap - Fix intendation
Andrew Tridgell [Sun, 18 Oct 2009 05:32:01 +0000 (16:32 +1100)]
s4-test: the ldap secdesc test is expected to fail for now
Nadya, if this is not correct and you think this should be passing
already the please let me know. When I looked over it, it doesn't look
like it has a chance of passing until your acl module is in place and
enabled by default.
Andrew Tridgell [Sun, 18 Oct 2009 04:57:21 +0000 (15:57 +1100)]
s4-test: SMB2 oplocks in s4 are a mess
I don't have time to fix these right now, and as we don't advertise
SMB2 by default I'll mark it as a known failure till we start enabling
SMB2 by default.
Andrew Tridgell [Sun, 18 Oct 2009 04:56:16 +0000 (15:56 +1100)]
s4: spelling error
Andrew Tridgell [Sun, 18 Oct 2009 03:22:42 +0000 (14:22 +1100)]
s4-torture: fixed the streams tests for Samba4
In some cases we were not doing streams tests on s4 that we should. In
others, we were calling tests that are known to fail on s4. Some of
those are a bit puzzling.
Andrew Tridgell [Sun, 18 Oct 2009 03:19:27 +0000 (14:19 +1100)]
s4-streams: fixed handling of stream rename and overwrite
Andrew Tridgell [Sun, 18 Oct 2009 03:15:48 +0000 (14:15 +1100)]
s4-pvfs: rename with full name gives SHARING_VIOLATION
Andrew Tridgell [Sun, 18 Oct 2009 03:14:16 +0000 (14:14 +1100)]
s4-pvfs: when reporting the file name, don't include the :$DATA suffix
Andrew Tridgell [Sun, 18 Oct 2009 03:13:45 +0000 (14:13 +1100)]
s4-pvfs: the STREAM_INFORMATION calls don't need any access flags
Andrew Tridgell [Sun, 18 Oct 2009 01:24:09 +0000 (12:24 +1100)]
s4-pvfs: fixed update of stream sizes
The data_blob_free() was changing the size we set the stream to
Jeremy Allison [Sun, 18 Oct 2009 03:46:22 +0000 (20:46 -0700)]
Fix posix_unlink test. Was doing grep without quotes around the
target string.
Jeremy.
Andrew Tridgell [Sat, 17 Oct 2009 23:32:06 +0000 (10:32 +1100)]
s4-pvfs: more fixes for ACLs on file creation
The passed in SD is not used to limit the access mask allowed on file
create.
Andrew Tridgell [Sat, 17 Oct 2009 23:30:10 +0000 (10:30 +1100)]
s4-smb2: fixed SMB2 find commands
The change to check for invalid \ prefix on SMB2 paths broke the
internal SMB2 code.
Andrew Tridgell [Sat, 17 Oct 2009 10:17:29 +0000 (21:17 +1100)]
s4-pvfs: change the handling of access checking on create
Previously when a file was created, we produces the resulting access
mask based on an ACL check against the parent. This change means we
now calculate the inherited ACL much earlier, and produce the
resulting access mask from that ACL, or the user supplied ACL.
Andrew Tridgell [Sat, 17 Oct 2009 10:14:59 +0000 (21:14 +1100)]
smb2-torture: samba4 allows SEC_FLAG_SECURITY to be used with privileges
Andrew Tridgell [Sat, 17 Oct 2009 09:10:03 +0000 (20:10 +1100)]
s4: fixed howto for new binary name
Jeremy Allison [Sat, 17 Oct 2009 19:56:15 +0000 (12:56 -0700)]
Fix the smbtorture4 build. root_fid is a "union smb_handle". tridge
please check.
Jeremy.
Jeremy Allison [Sat, 17 Oct 2009 17:38:44 +0000 (10:38 -0700)]
Trying to find out why the posix_unlink test build farm is still failing even
though we're now successfully deleting the symlink.
Jeremy.
Jeremy Allison [Sat, 17 Oct 2009 17:36:33 +0000 (10:36 -0700)]
Merge branch 'master' of ssh://jra@git.samba.org/data/git/samba
Volker Lendecke [Sat, 17 Oct 2009 15:00:13 +0000 (17:00 +0200)]
s3:winbind: Move fillup_pw_field() as static to wb_fill_pwent.c
Andrew Tridgell [Sat, 17 Oct 2009 02:12:24 +0000 (13:12 +1100)]
s4-smbserver: removed bogus initialisation of two union arms
Thanks to Metze for spotting this.
Andrew Tridgell [Sat, 17 Oct 2009 01:58:17 +0000 (12:58 +1100)]
s4-pvfs: when uwrap is enabled, ignore chown errors
chown is expected to fail under uwrap
Andrew Tridgell [Sat, 17 Oct 2009 01:50:51 +0000 (12:50 +1100)]
s4-torture: fixed the default ACL for s4
s4 returns group and world ACEs in the default acl, based on unix
permissions
Andrew Tridgell [Fri, 16 Oct 2009 23:54:46 +0000 (10:54 +1100)]
s4-torture: minor debugging enhancements
Andrew Tridgell [Fri, 16 Oct 2009 23:50:08 +0000 (10:50 +1100)]
s4-schema: We should not need Samba4TopExtra now
The last attribute this contained was 'privilege' which is now gone
Andrew Tridgell [Fri, 16 Oct 2009 22:09:42 +0000 (09:09 +1100)]
s4-pvfs: don't auto-apply privilege bits in unix acl handling either
Andrew Tridgell [Fri, 16 Oct 2009 22:09:19 +0000 (09:09 +1100)]
s4-acl: SEC_FLAG_MAXIMUM_ALLOWED doesn't auto-apply privilege access masks
Andrew Tridgell [Fri, 16 Oct 2009 12:06:02 +0000 (23:06 +1100)]
s4-torture: the BASE-CREATEX_ACCESS test is broken for non-administrators
See my msg to samba-technical about this test and privilege testing.
Andrew Tridgell [Fri, 16 Oct 2009 12:04:01 +0000 (23:04 +1100)]
s4-torture: cleanup after the MAXIMUM_ALLOWED test
Andrew Tridgell [Fri, 16 Oct 2009 12:03:42 +0000 (23:03 +1100)]
s4-pvfs: use privileges rather than "uid == 0" in unix access check
This makes the unix access check much closer to the full ACL check
Andrew Tridgell [Fri, 16 Oct 2009 12:02:58 +0000 (23:02 +1100)]
s4-security: honor more of the privilege access bits
Andrew Tridgell [Fri, 16 Oct 2009 07:23:42 +0000 (18:23 +1100)]
s4-torture: add a special check for administrators and privileges
lsa privileges calls don't expand groups. darn.
Andrew Tridgell [Fri, 16 Oct 2009 07:22:48 +0000 (18:22 +1100)]
s4-lsasrv: make sure only admins can alter privileges
Andrew Tridgell [Fri, 16 Oct 2009 07:01:35 +0000 (18:01 +1100)]
s4-provision: added the default privileges db
privileges are now stored in a separate database
Andrew Tridgell [Fri, 16 Oct 2009 07:01:02 +0000 (18:01 +1100)]
s4-provision: removed the old privilege attributes
Our schema is getting a bit cleaner :-)
Andrew Tridgell [Fri, 16 Oct 2009 06:05:48 +0000 (17:05 +1100)]
s4-torture: show the sid we are basing privilege tests on
Andrew Tridgell [Fri, 16 Oct 2009 06:05:27 +0000 (17:05 +1100)]
s4-privileges: moved privileges to private/privilege.ldb
We were storing privileges in the sam, which was OK when we were a
standalone DC, but is no good when we replicate with a windows DC.
This moves the privileges to a separate (local) database
Andrew Tridgell [Fri, 16 Oct 2009 06:04:19 +0000 (17:04 +1100)]
added NT_STATUS_NOT_OK_RETURN_AND_FREE()
Try to make it a bit easier to avoid leaks in common code
Jeremy Allison [Sat, 17 Oct 2009 01:13:06 +0000 (18:13 -0700)]
Add comment explaining about symlink following & posix.
Jeremy.
Jeremy Allison [Sat, 17 Oct 2009 00:20:40 +0000 (17:20 -0700)]
Last 2 VFS_STAT -> LSTAT fixes I can see in the modules code.
Jeremy.
Jeremy Allison [Fri, 16 Oct 2009 23:37:20 +0000 (16:37 -0700)]
Fix one missing STAT -> LSTAT with POSIX pathnames in vfs_xattr_tdb.c. Caught by the torture tester. I love unit tests :-). Jeremy.
Björn Jacke [Fri, 16 Oct 2009 21:40:34 +0000 (23:40 +0200)]
s3: build pam_smbpass when possible
Günther Deschner [Fri, 16 Oct 2009 16:01:19 +0000 (18:01 +0200)]
s3-netlogon: fix updating trust accout passwords with downlevel domains.
When choosing the netlogon password set function, make sure to look at the
*negotiated* flags in the cli->dc state, not the ones we start the negotiation
with.
Guenther
Günther Deschner [Fri, 16 Oct 2009 14:07:31 +0000 (16:07 +0200)]
nsswitch: increase libwbclient version after adding wbcChangeTrustCredentials().
Guenther
Karolin Seeger [Fri, 16 Oct 2009 14:00:26 +0000 (16:00 +0200)]
s3:packaging: Fix building RHEL packages.
Fix bug #6721.
Thanks to Eero Volotinen <eero.volotinen@medicel.com> for providing the patch!
Karolin
Matthias Dieter Wallnöfer [Fri, 16 Oct 2009 13:24:20 +0000 (15:24 +0200)]
s3:srv_samr_nt - another fix for the reject reason
Günther Deschner [Wed, 14 Oct 2009 09:58:21 +0000 (11:58 +0200)]
s4-smbtorture: extend netr_LogonControl test in RPC-NETLOGON.
Guenther
Günther Deschner [Fri, 16 Oct 2009 10:09:55 +0000 (12:09 +0200)]
s3-netlogon: Fix _netr_ServerPasswordSet2 cleartext blob handling.
Following Andrew's advice, let's straight md4 the plaintext blob and avoid
trying to get a paintext string out of the input the client sends.
Guenther
Günther Deschner [Fri, 16 Oct 2009 12:51:49 +0000 (14:51 +0200)]
s4-smbtorture: test wbcLookupUserSids in WINBIND-WBCLIENT as well.
Guenther
Günther Deschner [Fri, 16 Oct 2009 11:38:57 +0000 (13:38 +0200)]
s4-smbtorture: test wbcGuidToString and friends as well in WINBIND-WBCLIENT.
Guenther
Endi S. Dewata [Wed, 14 Oct 2009 06:04:00 +0000 (01:04 -0500)]
s4:provision - fixed invalid creationTime format
Endi S. Dewata [Wed, 14 Oct 2009 05:54:52 +0000 (00:54 -0500)]
s4:ldb - fixed dangling pointer in ldb_request_add_control()
Endi S. Dewata [Fri, 9 Oct 2009 19:30:51 +0000 (14:30 -0500)]
s4:auth - fixed problem reading bind DN from secrets database
Endi S. Dewata [Fri, 9 Oct 2009 18:36:04 +0000 (13:36 -0500)]
s4:provision - replaced linked_attributes with FDS plugins
When FDS is used as a backend, Samba should not use the
linked_attributes LDB module, but instead use the built-in
DS plugins for attribute linking, indexing, and referential
integrity.
Matthias Dieter Wallnöfer [Fri, 16 Oct 2009 11:48:17 +0000 (13:48 +0200)]
s4:auth_sam: Restructure tail in "authsam_get_server_info_principal" and fix a memory leak
Matthias Dieter Wallnöfer [Fri, 16 Oct 2009 11:42:58 +0000 (13:42 +0200)]
s4:winsdb - Substitute LDB result numbers with constants
Matthias Dieter Wallnöfer [Fri, 16 Oct 2009 10:25:34 +0000 (12:25 +0200)]
s3: Try to fix the build on Solaris & AIX regarding the password change reject reason
Kamen Mazdrashki [Wed, 7 Oct 2009 23:56:22 +0000 (02:56 +0300)]
s4/drs(tort): prefixMap unit test initial implementatoin
Kamen Mazdrashki [Wed, 7 Oct 2009 23:55:28 +0000 (02:55 +0300)]
s4/drs: prefixMap module initial definition
Kamen Mazdrashki [Wed, 7 Oct 2009 15:32:43 +0000 (18:32 +0300)]
s4/drs(tort): fix compile time warning
Kamen Mazdrashki [Tue, 6 Oct 2009 08:42:02 +0000 (11:42 +0300)]
s4/drs(tort): _drs_util_verify_attids() to verify ATTIDs in objects received
Kamen Mazdrashki [Tue, 6 Oct 2009 08:38:42 +0000 (11:38 +0300)]
s4/drs(tort): drs_util_DsAttributeId_to_string() function
Kamen Mazdrashki [Sun, 27 Sep 2009 14:04:04 +0000 (17:04 +0300)]
s4/drs(tort): _drs_ldap_attr_by_oid() implementation
Utility function to be used to fetch Attribute name and DN
giving attribute OID
Kamen Mazdrashki [Tue, 6 Oct 2009 08:35:51 +0000 (11:35 +0300)]
s4/drs(tort): ignore drs/proto.h file
Kamen Mazdrashki [Tue, 6 Oct 2009 05:40:15 +0000 (08:40 +0300)]
s4/drs(tort): oid_from_attid() reference implementation
Decode Attribute OID using prefixMap and
ATTID received during replication
Based on MS documentation. See MS-DRSR.pdf - 5.16.4
Kamen Mazdrashki [Mon, 5 Oct 2009 15:39:13 +0000 (18:39 +0300)]
s4/drs(tort): TORTURE_DRS torture module - initial implementation
Drsuapi tests module registers two suites:
- DRS-RPC - tests to be executed against remote machine
- DRS-UNIT - unit test for internal testing
Kamen Mazdrashki [Sun, 11 Oct 2009 18:00:55 +0000 (21:00 +0300)]
s4/drs: Propagate redefinition of drsuapi_DsReplicaOID into code base
The biggest change is that 'oid' field is transmited in binary format.
Also the field name is changed to 'binary_oid' so that
field format to be clear for callers.
After those changes, Samba4 should work the way it works before -
i.e. no added value here but we should not fail when
partial-oid is part of prefixMap transmited from Win server.
Also, thre is a bug in this patch - partial-binary-OIDs are
not handled correctly. Partial-binary-OIDs received during
replication will be encoded, but not handled correctly.
Kamen Mazdrashki [Mon, 5 Oct 2009 10:28:12 +0000 (13:28 +0300)]
s4/drs(NDR): Print implementation for drsuapi_DsReplicaOID
Custom ndr_print functions is implemented so that transmited
partia-binary-oid to be printed both in hex and
partial-oid formats
Kamen Mazdrashki [Mon, 5 Oct 2009 10:23:48 +0000 (13:23 +0300)]
s4/drs(NDR): Remove push/pull code for drsuapi_DsReplicaOID struct
New structure definition is automarshaled so custom marshaling
code is not used anymore
Kamen Mazdrashki [Mon, 5 Oct 2009 01:46:20 +0000 (04:46 +0300)]
s4/asn1: Use explicite TALLOC_CTX in ber_write_OID functions
Kamen Mazdrashki [Fri, 2 Oct 2009 15:30:14 +0000 (18:30 +0300)]
s4/drs(idl): Regenerate idl
Kamen Mazdrashki [Fri, 2 Oct 2009 15:29:44 +0000 (18:29 +0300)]
s4/drs(idl): Redefine drsuapi_DsReplicaOID in drsuapi.idl
Structure redefined to be more similar with OID_t structure
defined in [ref. MS-DRSR.pdf - p.496].
Günther Deschner [Wed, 14 Oct 2009 23:04:27 +0000 (01:04 +0200)]
s3-libnetapi: add nltest tool.
Guenther
Günther Deschner [Tue, 13 Oct 2009 14:47:32 +0000 (16:47 +0200)]
s3-libnetapi: add I_NetLogonControl{2} example code.
Guenther
Günther Deschner [Tue, 13 Oct 2009 14:46:54 +0000 (16:46 +0200)]
s3-libnetapi: add I_NetLogonControl{2} to public headers.
Guenther
Günther Deschner [Tue, 13 Oct 2009 14:03:58 +0000 (16:03 +0200)]
s3-libnetapi: fill in I_NetLogonControl{2}_r.
Guenther
Günther Deschner [Tue, 13 Oct 2009 13:47:56 +0000 (15:47 +0200)]
s3-libnetapi: add I_NetLogonControl{2} skeleton.
Guenther
Günther Deschner [Tue, 13 Oct 2009 13:39:27 +0000 (15:39 +0200)]
s3-libnetapi: add I_NetLogonControl{2} to IDL.
Guenther
Andrew Tridgell [Fri, 16 Oct 2009 00:41:52 +0000 (11:41 +1100)]
s4-winsrepl: don't put in attributes with no elements
Empty attributes are no longer allowed by ldb. This also fixes the
error checking in winsdb_message()
This fixes the samba4.nbt.winsreplication test
Günther Deschner [Thu, 15 Oct 2009 23:58:49 +0000 (01:58 +0200)]
s3-selftest: enable WINBIND-WBCLIENT against s3.
Guenther
Günther Deschner [Thu, 15 Oct 2009 22:33:38 +0000 (00:33 +0200)]
s4-smbtorture: add very basic libwbclient testsuite.
Guenther
Günther Deschner [Thu, 15 Oct 2009 23:59:08 +0000 (01:59 +0200)]
s3-net: fix build warning (missing default in switch).
Guenther