14 years agor3628: A typo and a compile-warning.
Günther Deschner [Mon, 8 Nov 2004 23:34:28 +0000 (23:34 +0000)]
r3628: A typo and a compile-warning.

(This used to be commit 906d5f88aabf091ee273e0ed9c3d2947b22c5390)

14 years agor3627: Allow to add dummy-form in rpcclient.
Günther Deschner [Mon, 8 Nov 2004 23:29:40 +0000 (23:29 +0000)]
r3627: Allow to add dummy-form in rpcclient.

(This used to be commit 11622805fb946b7b022d06ec4a85db2bfbf71f12)

14 years agor3616: Merge for 3.0.8.
Andrew Bartlett [Mon, 8 Nov 2004 04:32:23 +0000 (04:32 +0000)]
r3616: Merge for 3.0.8.

In auth_winbind, remove the push_utf8 calls, as this is no longer a
UTF8 interface.  (Removed from everywhere else earlier).

Tested with ASCII - I tried to load the weird charset for testing, but
it doesn't seem to work any more.

Andrew Bartlett
(This used to be commit cb27c197ee44d2be09014598e3928642b59ef956)

14 years agor3604: fix bug in Fedora packaging scripts
Gerald Carter [Sun, 7 Nov 2004 20:21:14 +0000 (20:21 +0000)]
r3604: fix bug in Fedora packaging scripts
(This used to be commit fdc84a04fe8989e36442d09136ededa0c73dae5f)

14 years agor3569: Fix for bug #1651, added extra servicePrincipalNames for kerberos interop.
Jeremy Allison [Fri, 5 Nov 2004 23:50:26 +0000 (23:50 +0000)]
r3569: Fix for bug #1651, added extra servicePrincipalNames for kerberos interop.
Modified the redhat patch some...
(This used to be commit 2ae717cd2c876649464f91093e55bed64ac5588d)

14 years agor3566: Completely replace the queryuseraliases call. The previous implementation...
Volker Lendecke [Fri, 5 Nov 2004 23:34:00 +0000 (23:34 +0000)]
r3566: Completely replace the queryuseraliases call. The previous implementation does
not exactly match what you would expect.

XP workstations during login actually do this, so we should better become a
bit more correct. The LDAP query issued is not really fully optimal, but it is
a lot faster and more correct than what was there before. The change in
passdb.h makes it possible that queryuseraliases is done with a single ldap

(This used to be commit 2508d4ed1e16c268fc9f3676b0c6a122e070f93d)

14 years agor3563: During a typical logon a modern workstation makes a lot of anonymous session
Volker Lendecke [Fri, 5 Nov 2004 22:53:35 +0000 (22:53 +0000)]
r3563: During a typical logon a modern workstation makes a lot of anonymous session
setups on its way to open a pipe. This gets rid of many round-trips to the
LDAP server during logon by setting up the server_info_guest once and not
asking the LDAP server and nss every time. Make sure that the ldap connection
is reopened in the child. (I did not look at the sql backends.)

(This used to be commit 3298f6105e6a88c9390cac02245c8f2eee1e5046)

14 years agor3561: Since we have tdb_reopen_all() after all forks, the local_pid logic is not
Volker Lendecke [Fri, 5 Nov 2004 21:55:21 +0000 (21:55 +0000)]
r3561: Since we have tdb_reopen_all() after all forks, the local_pid logic is not
correct anymore. If we actually open the tdb before the fork, we end up
opening the tdb twice. Jerry, jra, this also happens in the locking and
printing subsystems. You might want to check it there (not that it actually
happens right now, but this gave me some confusion lately...).

(This used to be commit 40cad9dcc14ddec0ce74bb9010d13bd82e4d10af)

14 years agor3559: If called interactively, on shutdown dump the talloc contexts left. Idea
Volker Lendecke [Fri, 5 Nov 2004 21:45:02 +0000 (21:45 +0000)]
r3559: If called interactively, on shutdown dump the talloc contexts left. Idea
stolen from samba4 ... ;-)

(This used to be commit b111bb46afc247e034a11e953b9d243cde69cc07)

14 years agor3538: Fix the build with the latest Heimdal code.
Jeremy Allison [Fri, 5 Nov 2004 00:57:29 +0000 (00:57 +0000)]
r3538: Fix the build with the latest Heimdal code.
(This used to be commit 34275bae787762646f02ea1dec19d7b3a9a733a3)

14 years agor3535: Tidy up error reporting. Memory leak with MIT krb5 1.3.5 turns
Jeremy Allison [Thu, 4 Nov 2004 23:56:23 +0000 (23:56 +0000)]
r3535: Tidy up error reporting. Memory leak with MIT krb5 1.3.5 turns
out to be in the kerberos libraries, not in Samba. Now to test
with Heimdal.
(This used to be commit b08e3bf6fb1052285e4efd669d9717d3a617499d)

14 years agor3525: Fix a memleak
Volker Lendecke [Thu, 4 Nov 2004 09:30:13 +0000 (09:30 +0000)]
r3525: Fix a memleak

(This used to be commit 4c4da26aa19bedcbb52ed3e6d43ca380a7c1603c)

14 years agor3504: Fix incorrectly applied patch. My fault - sorry!
Tim Potter [Wed, 3 Nov 2004 06:12:07 +0000 (06:12 +0000)]
r3504: Fix incorrectly applied patch.  My fault - sorry!
(This used to be commit 43a7f7db3d1995089ac8fb279f36e9e8edb1d8bb)

14 years agor3502: Tidy up debugging in kerberos_keytab code.
Jeremy Allison [Wed, 3 Nov 2004 02:18:51 +0000 (02:18 +0000)]
r3502: Tidy up debugging in kerberos_keytab code.
(This used to be commit 82651c1b1704d90ca52be1463ee871801c607d3b)

14 years agor3498: Optimisation of idmap_rid init: Avoid calling a DC for the domain-sid
Günther Deschner [Wed, 3 Nov 2004 00:39:34 +0000 (00:39 +0000)]
r3498: Optimisation of idmap_rid init: Avoid calling a DC for the domain-sid
when trusted domains are disabled anyway.

(This used to be commit cd30a0b14adf1e58c19bcbfec385a5794d4ca112)

14 years agor3496: Fix calling of get_acl_group_bits().
Günther Deschner [Wed, 3 Nov 2004 00:32:08 +0000 (00:32 +0000)]
r3496: Fix calling of get_acl_group_bits().

(This used to be commit 3acc74eef5dae16d7e2792206640904265c42494)

14 years agor3495: Fix the build (recent kerberos-changes).
Günther Deschner [Wed, 3 Nov 2004 00:29:09 +0000 (00:29 +0000)]
r3495: Fix the build (recent kerberos-changes).

(This used to be commit c7eab285d967345510a15e83bce508edb8e06e99)

14 years agor3492: Fixes from testing kerberos salted principal fix.
Jeremy Allison [Tue, 2 Nov 2004 21:28:14 +0000 (21:28 +0000)]
r3492: Fixes from testing kerberos salted principal fix.
(This used to be commit b356a8fdc5a1ac45f2f7f56a0836e794bdecddc6)

14 years agor3469: Fix build of smbmount.
Günther Deschner [Tue, 2 Nov 2004 08:49:18 +0000 (08:49 +0000)]
r3469: Fix build of smbmount.

(This used to be commit d22b29ee9c37b9d35e0d785632a10856045df0dc)

14 years agor3451: Finish off kerberos salting patch. Needs testing !
Jeremy Allison [Tue, 2 Nov 2004 02:21:26 +0000 (02:21 +0000)]
r3451: Finish off kerberos salting patch. Needs testing !
(This used to be commit ff4cb6b5e80731856d6f3f7eebd8fc23902e3580)

14 years agor3439: Finally fix build for platforms without kerberos.
Günther Deschner [Mon, 1 Nov 2004 19:35:55 +0000 (19:35 +0000)]
r3439: Finally fix build for platforms without kerberos.

(This used to be commit 05619cfdbf814e5c79e65934b82424eca00c76c4)

14 years agor3438: fix some kerberos-related prototype warnings
Günther Deschner [Mon, 1 Nov 2004 18:44:15 +0000 (18:44 +0000)]
r3438: fix some kerberos-related prototype warnings

(This used to be commit 43c8a9e25961f65677a55e701f54c0227329a756)

14 years agor3437: fix the build.
Günther Deschner [Mon, 1 Nov 2004 16:55:40 +0000 (16:55 +0000)]
r3437: fix the build.

(This used to be commit c4cb2ffa611f79ab3ba17f2afd8e4cd99b0afad3)

14 years agor3436: Fix build with recent heimdal-versions (0.6.3) as pointed out by Luke
Günther Deschner [Mon, 1 Nov 2004 16:18:14 +0000 (16:18 +0000)]
r3436: Fix build with recent heimdal-versions (0.6.3) as pointed out by Luke
Mewburn <> and close Bugzilla #1661.

Leaving the old define for KRB5_KPASSWD_VERS_SETPW (added by Antti
Andreimann) as fallback when the library does not provide one.

(This used to be commit 00598877dfb7aab48d1b5d58b3a69ed2dd8a36a8)

14 years agor3420: install smbwrapper and add the include directory in the package
Gerald Carter [Mon, 1 Nov 2004 02:00:09 +0000 (02:00 +0000)]
r3420: install smbwrapper and add the include directory in the package
(This used to be commit fbde364882151f8fac000b9a547eb9d57bb78786)

14 years agor3417: BUG 350: patch from Matt Selsky <> to use autoconf feature...
Gerald Carter [Sun, 31 Oct 2004 22:06:37 +0000 (22:06 +0000)]
r3417: BUG 350: patch from Matt Selsky <> to use autoconf feature preopcessing header file only (3 problematic headers on solaris)
(This used to be commit b4da6bd0f12d599eff4a90a91ca469145bee6275)

14 years agor3408: Another build fix
Volker Lendecke [Sun, 31 Oct 2004 11:26:31 +0000 (11:26 +0000)]
r3408: Another build fix
(This used to be commit 0bc5105f71c79e8c709d3bdfcc57cf8621e6fad5)

14 years agor3407: Fix the build
Volker Lendecke [Sun, 31 Oct 2004 11:20:07 +0000 (11:20 +0000)]
r3407: Fix the build
(This used to be commit b144ce557f516f62ab802fbb277799b10153c8fb)

14 years agor3399: a few more packaging fixes
Gerald Carter [Sun, 31 Oct 2004 03:11:41 +0000 (03:11 +0000)]
r3399: a few more packaging fixes
(This used to be commit 662415454b1fa91e2bd5f6cab30ec902f5f1fa9f)

14 years agor3398: fixing up solaris packaging for 3.0.x
Gerald Carter [Sun, 31 Oct 2004 02:32:35 +0000 (02:32 +0000)]
r3398: fixing up solaris packaging for 3.0.x
(This used to be commit 7b66980f4fbeac66ea8c3e9c32f1543df923a4a5)

14 years agor3381: More merging of the #1717 patch. Fixup some erroneous assumptions about
Jeremy Allison [Sat, 30 Oct 2004 01:32:05 +0000 (01:32 +0000)]
r3381: More merging of the #1717 patch. Fixup some erroneous assumptions about
memcpy's into fqdn names. I think the original intent was to create
Will need testing to see I haven't broken keytab support.
(This used to be commit 82acf83040654eb8b7e261518a3e5eb9caea7750)

14 years agor3379: More merging of kerberos keytab and salting fixes from Nalin Dahyabhai <nalin...
Jeremy Allison [Sat, 30 Oct 2004 00:34:58 +0000 (00:34 +0000)]
r3379: More merging of kerberos keytab and salting fixes from Nalin Dahyabhai <>
(bugid #1717).
(This used to be commit 30b8807cf6d5c3c5b9947a7e841d69f0b22eb019)

14 years agor3377: Merge in first part of modified patch from Nalin Dahyabhai <>
Jeremy Allison [Fri, 29 Oct 2004 22:38:10 +0000 (22:38 +0000)]
r3377: Merge in first part of modified patch from Nalin Dahyabhai <>
for bug #1717.The rest of the code needed to call this patch has not yet been
checked in (that's my next task). This has not yet been tested - I'll do this
once the rest of the patch is integrated.
(This used to be commit 7565019286cf44f43c8066c005b1cd5c1556435f)

14 years agor3345: More MIT/Heimdal tests for comparing enctypes now.
Jeremy Allison [Fri, 29 Oct 2004 00:02:32 +0000 (00:02 +0000)]
r3345: More MIT/Heimdal tests for comparing enctypes now.
(This used to be commit eefb911d0c66bdee586a86446e16723013f84101)

14 years agor3342: More MIT/Heimdal fixes to allow an enctype to be explicitly set in a krb5_creds
Jeremy Allison [Thu, 28 Oct 2004 23:50:14 +0000 (23:50 +0000)]
r3342: More MIT/Heimdal fixes to allow an enctype to be explicitly set in a krb5_creds
(This used to be commit c9b80490128e09442a01dd8ec6f4b453769e82c1)

14 years agor3339: allow tdbtool to be built
Herb Lewis [Thu, 28 Oct 2004 22:58:21 +0000 (22:58 +0000)]
r3339: allow tdbtool to be built
(This used to be commit 682b746ab6ff10bf9970e808f0032066e5f3b783)

14 years agor3326: BUG 1782: reorder loadparm.c to prevent testparm from displaying synonyms...
Gerald Carter [Thu, 28 Oct 2004 13:50:13 +0000 (13:50 +0000)]
r3326: BUG 1782: reorder loadparm.c to prevent testparm from displaying synonyms; patch from Luke Mewburn <>
(This used to be commit c8101dbb6561267298728714e5b82591138c56e6)

14 years agor3298: turning sendfile back off by default
Gerald Carter [Wed, 27 Oct 2004 19:44:12 +0000 (19:44 +0000)]
r3298: turning sendfile back off by default
(This used to be commit 7dc28014860a5c5bbe78dc22628301ea8dc245ee)

14 years agor3296: Fix to ensure entries are stored in correct order. Bug #1498. Patch from
Jeremy Allison [Wed, 27 Oct 2004 18:11:41 +0000 (18:11 +0000)]
r3296: Fix to ensure entries are stored in correct order. Bug #1498. Patch from
SATOH Fumiyasu <>.
(This used to be commit 7e35900bc6894d69f83c99ac6eb260d7cc35683a)

14 years agor3294: Fix for SMB signing with 56-bit DES session keys. From Nalin Dahyabhai <nalin...
Jeremy Allison [Wed, 27 Oct 2004 17:40:28 +0000 (17:40 +0000)]
r3294: Fix for SMB signing with 56-bit DES session keys. From Nalin Dahyabhai <>.
(This used to be commit 55d23cb253d869e58bd51cf179c6dc0f3cfab9d2)

14 years agor3292: A fix from Narayana Pattipati <narayana[dot]pattipati[at]wipro\dotty/com...
Richard Sharpe [Wed, 27 Oct 2004 17:03:09 +0000 (17:03 +0000)]
r3292: A fix from  Narayana Pattipati <narayana[dot]pattipati[at]wipro\dotty/com> for
Solaris to ensure we distinguish properly between 5.1 and 5.10.
(This used to be commit 96baa5bb6c908fa5e870d86d3f380fd368ada658)

14 years agor3275: Fix from Michael Sweet <> for bug #1892.
Jeremy Allison [Wed, 27 Oct 2004 00:52:12 +0000 (00:52 +0000)]
r3275: Fix from Michael Sweet <> for bug #1892.
(This used to be commit 13278744cce43060379b7bbebcdf90b41546d43d)

14 years agor3273: Ensure we're consistent in the use of strchr_m for '@'.
Jeremy Allison [Wed, 27 Oct 2004 00:41:41 +0000 (00:41 +0000)]
r3273: Ensure we're consistent in the use of strchr_m for '@'.
(This used to be commit 0f3f7b035b37bfc51d3a59d0472003c3d4ac1511)

14 years agor3264: fix lmhosts lookup so that we don't say we found something when we really...
Gerald Carter [Tue, 26 Oct 2004 14:22:37 +0000 (14:22 +0000)]
r3264: fix lmhosts lookup so that we don't say we found something when we really didn't
(This used to be commit c7036f824627dc555185a52ed95d3e0132babcd8)

14 years agor3230: swat/lang/*/include/*html are no installed anymore
Gerald Carter [Tue, 26 Oct 2004 02:35:41 +0000 (02:35 +0000)]
r3230: swat/lang/*/include/*html are no installed anymore
(This used to be commit 28c449ac50bf7659672c1feb86a05068f75c79df)

14 years agor3228: Fix for bugzilla #1884 from Brett Funderburg. Use the value of
Tim Potter [Tue, 26 Oct 2004 01:37:19 +0000 (01:37 +0000)]
r3228: Fix for bugzilla #1884 from Brett Funderburg.  Use the value of
desired_access passed in to the lsa open policy routine.  Use a default
value that netapps and windows likes as well.
(This used to be commit 9c3cffaf22c69b8c7fae12adf02aa1679de546b3)

14 years agor3225: Fix correct use of resume name. Cope with the resume
Jeremy Allison [Mon, 25 Oct 2004 23:39:01 +0000 (23:39 +0000)]
r3225: Fix correct use of resume name. Cope with the resume
name not existing. Found using Samba4 RAW-SEARCH.
(This used to be commit 74dd2b33ff1ecba752682937c792628e081f17f5)

14 years agor3221: Remove check for allow-trusted-domains so that this thing does not throw-up.
John Terpstra [Mon, 25 Oct 2004 19:41:16 +0000 (19:41 +0000)]
r3221: Remove check for allow-trusted-domains so that this thing does not throw-up.
(This used to be commit 3d8e19468b8dda3bc84f0bc9174944c8275ed024)

14 years agor3151: Add the "no warranty"-section in the licence header.
Günther Deschner [Sun, 24 Oct 2004 11:50:24 +0000 (11:50 +0000)]
r3151: Add the "no warranty"-section in the licence header.

(This used to be commit c9a7bc10b7aa5e1cb7d37ba9b1a8ddb9b0b2dd5e)

14 years agor3146: Some cleanup for idmap_rid:
Günther Deschner [Sat, 23 Oct 2004 15:16:10 +0000 (15:16 +0000)]
r3146: Some cleanup for idmap_rid:
- fix several memleaks found by valgrind
- turn off support for trusted domains (can be reenabled with
- improve readability

(This used to be commit 351a1227e80db5d87b71e17cd1443c11ea6ace4e)

14 years agor3145: Add experimental idmap_rid-Plugin.
Günther Deschner [Sat, 23 Oct 2004 13:23:54 +0000 (13:23 +0000)]
r3145: Add experimental idmap_rid-Plugin.

Written by Sumit Bose <> and myself a while ago.

idmap_rid does a direct, static mapping between RIDs and UIDs/GIDs using
the idmap-range as offset. It does thus allow to have a unified mapping
over several winbindd-systems without having the need of a central
LDAP-Server (and all related dependencies and problems this solution can

./configure --with-shared-modules=idmap_rid

        idmap backend = idmap_rid

idmp_rid does even allow you to have multiple mappings (for trusted
domains). This is a rather problemtic feature and will be turned off by
default rather soon. The problem is that ranges can quickly overlap when
not measured with caution.

        idmap backend = idmap_rid:"MYDOMAIN=1000-9999 OTHER=10000-19999"

Will valgrind idmap_rid later today and fix a couple of things.

(This used to be commit 49a238bd37105bf1a33d4a230ca594c4cf304dd3)

14 years agor3143: Allow for multiple DC's to be named as #1c names in lmhosts.
Volker Lendecke [Sat, 23 Oct 2004 09:20:02 +0000 (09:20 +0000)]
r3143: Allow for multiple DC's to be named as #1c names in lmhosts.

(This used to be commit 2af98ec054508055a63552cfdb48cfaf43f76b62)

14 years agor3140: * try to ensure consistent usage of the username map.
Gerald Carter [Fri, 22 Oct 2004 20:15:24 +0000 (20:15 +0000)]
r3140: * try to ensure consistent usage of the username map.
  Use the fully qualified DOMAIN\user format for 'security = domain|ads'
  and apply after authentication has succeeded.

* also change fill_domain_username() to only lowercase the username
  and not the domain+username.  This was a cosmetic fix only.
  makes the output more consistent with %D and %U.
(This used to be commit 30ee2d5b0906d5cd73a8faf5170e5aebcc6d69c8)

14 years agor3138: Fix from Sorin Manolache <> for memory leak.
Jeremy Allison [Fri, 22 Oct 2004 18:38:57 +0000 (18:38 +0000)]
r3138: Fix from Sorin Manolache <> for memory leak.
(This used to be commit b35f48ad8ee63e44c70d0b198ccff39306ebdf74)

14 years agor3137: Do not simply ignore failing idmap-module init for remotemaps.
Günther Deschner [Fri, 22 Oct 2004 16:19:31 +0000 (16:19 +0000)]
r3137: Do not simply ignore failing idmap-module init for remotemaps.
(in preparation of adding idmap_rid)

(This used to be commit e7691f4862da141f530a8e8b1364b9c02e8dc732)

14 years agor3121: Bug #1956. Ensure errno is saved and restored consistently on a normal_close.
Jeremy Allison [Thu, 21 Oct 2004 19:51:33 +0000 (19:51 +0000)]
r3121: Bug #1956. Ensure errno is saved and restored consistently on a normal_close.
(This used to be commit f08f437c736e44913b3eeb16d6e32da8975442a7)

14 years agor3120: Fix bug #1955 reported by Love <>. Inconsistent error return.
Jeremy Allison [Thu, 21 Oct 2004 18:39:16 +0000 (18:39 +0000)]
r3120: Fix bug #1955 reported by Love <>. Inconsistent error return.
(This used to be commit c6b144654ae544c86f7caa35483e25f0cfe5e904)

14 years agor3117: Fix from Tom Lackemann <> for bug #1954.
Jeremy Allison [Thu, 21 Oct 2004 17:22:35 +0000 (17:22 +0000)]
r3117: Fix from Tom Lackemann <> for bug #1954.
Memory leak in posix acl code.
(This used to be commit c97aab7ee6bf1f385b445b4b0eb0e1df7e9a56f5)

14 years agor3088: update nds schema file from Uli Iske <>
Gerald Carter [Wed, 20 Oct 2004 15:37:47 +0000 (15:37 +0000)]
r3088: update nds schema file from Uli Iske <>
(This used to be commit 3e28c576951051439e6b5e1022ab76a44e30ff9d)

14 years agor3072: Fix for bug #1947 - incorrect use of getpwnam() etc. interface.
Jeremy Allison [Tue, 19 Oct 2004 23:41:26 +0000 (23:41 +0000)]
r3072: Fix for bug #1947 - incorrect use of getpwnam() etc. interface.
(This used to be commit aaab1120849efca11c68bdce9285bad25e05eecf)

14 years agor3069: add 'force printername' service parameter for people that want to enforce...
Gerald Carter [Tue, 19 Oct 2004 22:13:08 +0000 (22:13 +0000)]
r3069: add 'force printername' service parameter for people that want to enforce printername == sharename for spoolss printing
(This used to be commit d47b8a0b4f348171df35b3b0028ce7d99fab8af3)

14 years agor3068: strip guest mount option off before sending to kernel mount routine to avoid...
Steve French [Tue, 19 Oct 2004 22:05:38 +0000 (22:05 +0000)]
r3068: strip guest mount option off before sending to kernel mount routine to avoid logging spurious message
(This used to be commit a23c607ef0594ab098d1e5d85fb7635e530e3818)

14 years agor3067: patch based on volker's initial work in trunk that fixes the queu update probl...
Gerald Carter [Tue, 19 Oct 2004 17:05:01 +0000 (17:05 +0000)]
r3067: patch based on volker's initial work in trunk that fixes the queu update problem when using the background daemon
(This used to be commit de7af09e727e744aa27af85ef7c0f73ed5c1550a)

14 years agor3066: BUG 1519: fix segfault caused by double free of a printer
Gerald Carter [Tue, 19 Oct 2004 16:17:23 +0000 (16:17 +0000)]
r3066: BUG 1519: fix segfault caused by double free of a printer
(This used to be commit 3760464193c540e82f0ba4e61d1d3b96a9803aca)

14 years agor3065: BUG 1519 (more): apparently the server_name notify request is used to fill...
Gerald Carter [Tue, 19 Oct 2004 14:45:48 +0000 (14:45 +0000)]
r3065: BUG 1519 (more): apparently the server_name notify request is used to fill in the title bar of the port monitor window and unless we get it right, you cannot open the printer properties from the port monitor window
(This used to be commit fc691572c9ba5ae85c63db5202b7777efdbf7260)

14 years agor3050: Steal from Samba4 :-). Make us pass most of the new lock tests (except for
Jeremy Allison [Mon, 18 Oct 2004 22:01:10 +0000 (22:01 +0000)]
r3050: Steal from Samba4 :-). Make us pass most of the new lock tests (except for
the cancel lock which I have to add).
(This used to be commit cf7f89999e0c6becd4617c812400d1e71b9c0a30)

14 years agor3049: fixing some calls in the printing code to stanard_sub_basic(); fix standard_su...
Gerald Carter [Mon, 18 Oct 2004 19:57:03 +0000 (19:57 +0000)]
r3049: fixing some calls in the printing code to stanard_sub_basic(); fix standard_sub_snum() to use the current user's gid;  add some (snum == -1) checks to standard_sub_advanced()
(This used to be commit 8c3fd1908d201e9891878ff4c3259ed9690dff97)

14 years agor3008: when checking for the existance of a lock we are only doing a single
Andrew Tridgell [Sun, 17 Oct 2004 00:22:11 +0000 (00:22 +0000)]
r3008: when checking for the existance of a lock we are only doing a single
tdb call, so there is no need to get the chainlock. This reduces the
number of tdb locking calls made on file IO
(This used to be commit 78e904c27b31d7123b521c446247d6ff558c84cc)

14 years agor3002: Fix for bug #1886 - prevent delete on close being set
Jeremy Allison [Sat, 16 Oct 2004 03:04:40 +0000 (03:04 +0000)]
r3002: Fix for bug #1886 - prevent delete on close being set
for readonly files (and return the correct error code).
We now pass the Samba4 test suite on this.
(This used to be commit 6ae417f12cc6f8d2ad00bea27ce0a20242f76325)

14 years agor2999: Remove lockedkeys code. Not used.
Jeremy Allison [Fri, 15 Oct 2004 19:45:13 +0000 (19:45 +0000)]
r2999: Remove lockedkeys code. Not used.
(This used to be commit c3e87f9fa53b0be1dea5dad5cddd71d2617c3cf6)

14 years agor2996: readability fix for length check; no semantic changes
Gerald Carter [Fri, 15 Oct 2004 15:04:01 +0000 (15:04 +0000)]
r2996: readability fix for length check; no semantic changes
(This used to be commit 668ab6984afa7d9e0c15e87c5d45df7560e467e6)

14 years agor2979: Fix incorrect locks/unlocks in tdb_lockkeys()/tdb_unlockkeys().
Jeremy Allison [Fri, 15 Oct 2004 00:02:55 +0000 (00:02 +0000)]
r2979: Fix incorrect locks/unlocks in tdb_lockkeys()/tdb_unlockkeys().
Spotted by Taj Khattra <>.
(This used to be commit 365b203164bc813579013afb5dbb74f3604906c9)

14 years agor2978: Fix #1926 typo in debug. Found by Bill McGonigle <bill+samba@bfccomputing...
Jeremy Allison [Thu, 14 Oct 2004 22:30:33 +0000 (22:30 +0000)]
r2978: Fix #1926 typo in debug. Found by Bill McGonigle <>.
(This used to be commit 4fd314243e82d9c55bc9849a722424d45553013e)

14 years agor2959: If we want to support writes >= 65536 with cli_write, then it had better
Richard Sharpe [Thu, 14 Oct 2004 03:19:57 +0000 (03:19 +0000)]
r2959: If we want to support writes >= 65536 with cli_write, then it had better
return a size_t, not an ssize_t, and we had better left shift the upper
part of the write count, not right shift it.
(This used to be commit 3eb33fbc64415600d62ff7b1f2edd67d2dac05b4)

14 years agor2955: fixing a segfault uncovered by the changes for BUG 1519
Gerald Carter [Wed, 13 Oct 2004 19:40:22 +0000 (19:40 +0000)]
r2955: fixing a segfault uncovered by the changes for BUG 1519
(This used to be commit 1664395257eb2425246e200ebde4384aa54484a4)

14 years agor2943: solaris packagaing updates from Darren Chew <>
Gerald Carter [Wed, 13 Oct 2004 12:20:07 +0000 (12:20 +0000)]
r2943: solaris packagaing updates from Darren Chew <>
(This used to be commit 3798357e443f2795bf62a6e6ec73ca6a572957db)

14 years agor2942: Add client-side support of triggering ads printer publishing over msrpc
Günther Deschner [Wed, 13 Oct 2004 01:40:35 +0000 (01:40 +0000)]
r2942: Add client-side support of triggering ads printer publishing over msrpc
setprinter calls inside the net-tool.

This is usefull to mimic the same queries a windows-client does. At
least win2k returns WERR_IO_PENDING when printer is published via
setprinter, samba returns WERR_OK but this does not hurt.

(This used to be commit 69b745fb98b8054d1f52e8a3fe3b933fb04336db)

14 years agor2935: This is a long-standing one in my patch-queue: A pair of net commands
Volker Lendecke [Tue, 12 Oct 2004 11:58:01 +0000 (11:58 +0000)]
r2935: This is a long-standing one in my patch-queue: A pair of net commands
(usersidlist/allowedusers) to scan a file server's share and list all users
who have permission to connect there.

(This used to be commit f7f84aa1ded70af3882e4122f34d5c7eed746993)

14 years agor2924: Another #if that should be an #ifdef.
Tim Potter [Tue, 12 Oct 2004 03:34:01 +0000 (03:34 +0000)]
r2924: Another #if that should be an #ifdef.
(This used to be commit b6193f6d52a148c05b6b7cc33553f3b8ff94b64e)

14 years agor2923: Fix some obvious copy/paste leftover debug-messages.
Günther Deschner [Mon, 11 Oct 2004 21:09:36 +0000 (21:09 +0000)]
r2923: Fix some obvious copy/paste leftover debug-messages.

(This used to be commit 94f48d06c774eb137fef70063e6f29e5d5a6ba9d)

14 years agor2918: BUG 1907: fix getprinterdriverdir_1(). have to make sure we don't add unneces...
Gerald Carter [Mon, 11 Oct 2004 20:01:01 +0000 (20:01 +0000)]
r2918: BUG 1907: fix getprinterdriverdir_1().  have to make sure we don't add unnecessary double slashes to the servername
(This used to be commit 859599dbcaa9e39a7902cc959955fcea2dad334b)

14 years agor2917: Fix ip address override in mount.cifs mount helper and clean up warning messag...
Steve French [Mon, 11 Oct 2004 16:30:14 +0000 (16:30 +0000)]
r2917: Fix ip address override in mount.cifs mount helper and clean up warning messages from the sparse tool and expand syntax help
(This used to be commit 1052eabf29f6c197b126f44d32fd5c5bc8f4a9c3)

14 years agor2905: Apply the patch for bug #1822. Add -D_REENTRANT to CPPFLAGS and -lthread
Richard Sharpe [Mon, 11 Oct 2004 05:07:31 +0000 (05:07 +0000)]
r2905: Apply the patch for bug #1822. Add -D_REENTRANT to CPPFLAGS and -lthread

Patch supplied by Sean McGrath ...
(This used to be commit d704272b0a27c51dbe9c5c5f04134ce559bea2c4)

14 years agor2899: Change some #if DEBUG_PASSWORD's to #ifdef DEBUG_PASSWORD.
Tim Potter [Mon, 11 Oct 2004 00:32:31 +0000 (00:32 +0000)]
r2899: Change some #if DEBUG_PASSWORD's to #ifdef DEBUG_PASSWORD.

Bugzilla #1903.
(This used to be commit 1327d83d902b6a39096d387d734e73d85ed53f85)

14 years agor2894: Certain versions of GNU ld the default is not to have the
Tim Potter [Sun, 10 Oct 2004 12:01:14 +0000 (12:01 +0000)]
r2894: Certain versions of GNU ld the default is not to have the
--allow-shlib-undefined flag defined.  This causes a stackload of
warnings when building modules.

Fix by Michel Gravey which closes bugzilla #1776.
(This used to be commit ad53c555131634ba29deea448e4fd184e78e8d4a)

14 years agor2868: Well, I'm not quite sure what I'm doing back in Samba 3.0, but anyway...
Andrew Bartlett [Sat, 9 Oct 2004 01:44:05 +0000 (01:44 +0000)]
r2868: Well, I'm not quite sure what I'm doing back in Samba 3.0, but anyway...

I've been grumbling about under-efficient calls in SAMR, and finally
got around to fixing some of them.

We now call sys_getgroups() (which in turn calls initgroups(), until
glibc 3.4 is released) to figure out a user's group membership.  This
is far, far more efficient than scanning all the groups looking for a
match, and is still the 'posix way', just using an effiecient call.

The seperate issue of 'who is in this group' remains, but this one has
been biting some people.

I need to talk to VL about how best to exersise nasty corner cases,
but my initial tests hold strong.  (The code is also much simpiler
than before, which has to count for something :-)

Andrew Bartlett
(This used to be commit dc19f161698dab5b71d61fa2bacc7e7b8da5fbba)

14 years agor2865: Add static and remove unused functions that only cload the blame-game
Andrew Bartlett [Fri, 8 Oct 2004 13:00:47 +0000 (13:00 +0000)]
r2865: Add static and remove unused functions that only cload the blame-game
in finding out who is causing the massive performance problems with
large LDAP directories.

Andrew Bartlett
(This used to be commit f16ed2616a67c412bc9b78354a5faf673e64cf42)

14 years agor2852: Oh. Allow to migrate win2k3/xp-drivers as well.
Günther Deschner [Thu, 7 Oct 2004 14:47:53 +0000 (14:47 +0000)]
r2852: Oh. Allow to migrate win2k3/xp-drivers as well.
Thanks to Bjoern Jacke for his moral support :)

(This used to be commit ab875d3ecf3a80f5648432f7f4573f57442e6698)

14 years agor2837: Fix printer-migration w.r.t. to new naming-convention for
Günther Deschner [Thu, 7 Oct 2004 11:01:13 +0000 (11:01 +0000)]
r2837: Fix printer-migration w.r.t. to new naming-convention for
policy-handles. Also remove some unused vars.

(This used to be commit 5181c1b2192d1802616e8c30cd9458c00a306a46)

14 years agor2835: Since we always have -I. and -I$(srcdir) in CFLAGS, we can get rid of
Tim Potter [Thu, 7 Oct 2004 04:01:18 +0000 (04:01 +0000)]
r2835: Since we always have -I. and -I$(srcdir) in CFLAGS, we can get rid of
'..' from all #include preprocessor commands.   This fixes bugzilla #1880
where OpenVMS gets confused about the '.' characters.
(This used to be commit 7f161702fa4916979602cc0295919b541912acd6)

14 years agor2834: Netapps can return NT_STATUS_ACCESS_DENIED when trying to return the
Tim Potter [Thu, 7 Oct 2004 03:55:39 +0000 (03:55 +0000)]
r2834: Netapps can return NT_STATUS_ACCESS_DENIED when trying to return the
security descriptor for a file.  Return an error in this case instead
of panicing trying to unpack a zero length buffer.  Found by Brett
(This used to be commit 588de0d4a84a5228d0f99f743ad327ad3b70ead1)

14 years agor2832: Readd WKGUID-binding to match the correct default-locations of new
Günther Deschner [Wed, 6 Oct 2004 16:21:35 +0000 (16:21 +0000)]
r2832: Readd WKGUID-binding to match the correct default-locations of new
User-, Group- and Machine-Accounts in Active Directory (this got lost
during the last trunk-merge).

This way we match e.g. default containers moved by redircmp.exe and
redirusr.exe in Windows 2003 and don't blindly default to cn=Users or

Further wkguids can be examied via "net ads search wellknownobjects=*".
This should still keep a samba3-client joining a samba4 dc. Fixes
Bugzilla #1343.

(This used to be commit 8836621694c95779475fa9a1acf158e5e0577288)

14 years agor2828: Fix for bugzilla #1864 from Brett again.
Tim Potter [Wed, 6 Oct 2004 02:05:39 +0000 (02:05 +0000)]
r2828: Fix for bugzilla #1864 from Brett again.

Add sd->type field to security descriptor Python representation.
(This used to be commit b157a1b7c3e15a960fbc943d37abbb1bf5053a63)

14 years agor2826: Complain if 'password chat' doesn't contain the %u variable. based on a patch...
Jelmer Vernooij [Tue, 5 Oct 2004 22:18:32 +0000 (22:18 +0000)]
r2826: Complain if 'password chat' doesn't contain the %u variable. based on a patch by Ronan Waide
(This used to be commit a48b3b291cfe5883da1a36b368ddf725b5ff9375)

14 years agor2824: restored the is_case_sensitive option to ms_fnmatch() in Samba3. It is
Andrew Tridgell [Tue, 5 Oct 2004 03:26:02 +0000 (03:26 +0000)]
r2824: restored the is_case_sensitive option to ms_fnmatch() in Samba3. It is
very rarely used, but we sohuldn't be removing a feature in a minor
release of this kind.
(This used to be commit 4ce0505bc369243aa77013519ce4e4f6e50f5a48)

14 years agor2823: Patch from Brett Funderburg to pass create options parameter to
Tim Potter [Tue, 5 Oct 2004 01:36:37 +0000 (01:36 +0000)]
r2823: Patch from Brett Funderburg to pass create options parameter to
nt_create_andx() function.
(This used to be commit fa3e8365641e84ca361dc95bac33a9d56e9d799b)

14 years agor2822: Fix parameter confusion in priming of name-to-sid cache. Found by
Tim Potter [Tue, 5 Oct 2004 00:48:56 +0000 (00:48 +0000)]
r2822: Fix parameter confusion in priming of name-to-sid cache.  Found by
Qiao Yang.
(This used to be commit 30ae13cb9fbe5f04e46bcbd5e0c19da9b33341d5)

14 years agor2821: Adding "Windows x64" as architecture string and driverdir "x64" for the
Günther Deschner [Mon, 4 Oct 2004 22:13:57 +0000 (22:13 +0000)]
r2821: Adding "Windows x64" as architecture string and driverdir "x64" for the
64bit AMD platform.

(This used to be "Windows AMD64" and "AMD64" in one of the release
candidates of SP2 for Windows XP. AMD64 is obviously still supported but
not documented.)

(This used to be commit cc5892f0411b8eb5daebe746164a2cf21d3d4c68)

14 years agor2819: Make 'password history'-behaviour in ldapsam more consistent.
Günther Deschner [Mon, 4 Oct 2004 15:53:33 +0000 (15:53 +0000)]
r2819: Make 'password history'-behaviour in ldapsam more consistent.

Currently we cannot store more then 15 password history entries (windows
NT4 allows to store 24) in ldapsam. When choosing more then "15" with
pdbedit -P "password history", we fail to initialize the password
history upon password change and overwrite the history, effectively
using a password history of "1". We do already decrease any
history-policy larger then 15 to 15 while storing the password history
list attribute in ldap.

(This used to be commit a4b47e71475a06c2e2287613b00648c5f53ae52c)

14 years agor2814: Exactly the same as "main" build fix.
Rafal Szczesniak [Sun, 3 Oct 2004 20:25:34 +0000 (20:25 +0000)]
r2814: Exactly the same as "main" build fix.

(This used to be commit 7fa94c38951fcd803a8e769a867a008e47f4129a)