11 years agoDon't require "Modify property" perms to unjoin bug #6481)
Jim McDonough [Fri, 19 Jun 2009 17:46:07 +0000 (13:46 -0400)]
Don't require "Modify property" perms to unjoin bug #6481)
"net ads leave" stopped working when "modify properties"
permissions were not granted (meaning you had to be allowed
to disable the account that you were about to delete).

Libnetapi should not delete machine accounts, as this does not
happen on win32.  The WKSSVC_JOIN_FLAGS_ACCOUNT_DELETE flag
really means "disable" (both in practice and docs).

However, to keep the functionality in "net ads leave", we
will still try to do the delete.  If this fails, we try
to do the disable.

Additionally, it is possible in windows to not disable or
delete the account, but just tell the local machine that it
is no longer in the account.  libnet can now do this as well.

11 years agoAdd a missing talloc_move() in tldap_search_recv
Volker Lendecke [Fri, 19 Jun 2009 15:36:38 +0000 (17:36 +0200)]
Add a missing talloc_move() in tldap_search_recv

11 years agoFix Coverity IDs 922 and 933
Volker Lendecke [Fri, 19 Jun 2009 14:00:23 +0000 (16:00 +0200)]
Fix Coverity IDs 922 and 933

In copy_internals(), if the !CAN_WRITE(conn) kicks in, we end up
dereferencing a NULL smb_filename.

This adds a simple protection around it.

Tim, please check!


11 years agos3/docs: Fix typo.
Karolin Seeger [Fri, 19 Jun 2009 13:23:22 +0000 (15:23 +0200)]
s3/docs: Fix typo.

This fixes bug #6412.
Thanks to Carsten Dumke <carsten [at]> for reporting!


11 years agoAdd tiny tldap test
Volker Lendecke [Fri, 19 Jun 2009 11:06:02 +0000 (13:06 +0200)]
Add tiny tldap test

11 years agoAdd tldap_fetch_rootdse
Volker Lendecke [Sat, 13 Jun 2009 09:59:39 +0000 (11:59 +0200)]
Add tldap_fetch_rootdse

11 years agoMake tevent_req_is_ldap_error public
Volker Lendecke [Fri, 19 Jun 2009 10:41:16 +0000 (12:41 +0200)]
Make tevent_req_is_ldap_error public

11 years agoAdd tldap_context_[gs]etattr
Volker Lendecke [Fri, 19 Jun 2009 09:45:01 +0000 (11:45 +0200)]
Add tldap_context_[gs]etattr

This adds the ability to attach extended information to a tldap_context. This
will become useful once we start to do automatic reconnects for example, a
callback function might want attach a pointer to credentials so that it can

The initial user of this will be a cached rootdse, so that things like the
ability to do paged searches can be cached.

11 years agos3:dmapi: prefer dmapi libs from gpfs over system libs
Björn Jacke [Fri, 19 Jun 2009 09:51:22 +0000 (11:51 +0200)]
s3:dmapi: prefer dmapi libs from gpfs over system libs

Patch from William Jojo sent to samba-technical:

This is based on some pain felt when building 32-bit and 64-bit Clustered Samba
on AIX with GPFS support.

Part of the problem lies in AIX only providing 32-bit shared object in
libxdsm.a(shr.o). So without libdmapi.a from gpfs.base, you get no DMAPI
support under 64-bit.

11 years agos4-smbtorture: fix test_GetInfoLevel crash bug in RPC-DFS.
Günther Deschner [Fri, 19 Jun 2009 00:52:53 +0000 (02:52 +0200)]
s4-smbtorture: fix test_GetInfoLevel crash bug in RPC-DFS.


11 years agoMerge branch 'master' of ssh:// into master-devel
Andrew Bartlett [Fri, 19 Jun 2009 05:38:33 +0000 (15:38 +1000)]
Merge branch 'master' of ssh:// into master-devel

11 years agoAllow developers access the the privilaged ldapi socket for the moment
Andrew Bartlett [Fri, 19 Jun 2009 05:29:42 +0000 (15:29 +1000)]
Allow developers access the the privilaged ldapi socket for the moment

This allows us some time to get the EXTERNAL bind working

11 years agoOn our way to alpha9!
Andrew Bartlett [Fri, 19 Jun 2009 04:43:51 +0000 (14:43 +1000)]
On our way to alpha9!

11 years agoMark as release version samba-4.0.0alpha8
Andrew Bartlett [Fri, 19 Jun 2009 04:36:48 +0000 (14:36 +1000)]
Mark as release version

11 years agoPartially revert restriction of socket_wrapper to 1500 byte writes
Andrew Bartlett [Fri, 19 Jun 2009 03:25:28 +0000 (13:25 +1000)]
Partially revert restriction of socket_wrapper to 1500 byte writes

This keeps the restriction for stream sockets (where the caller will
retry), without creating problems on datagram sockets (CLDAP is not
defined, as far as I know, across multiple UDP packets).

The commit adding this restriction was

Andrew Bartlett

11 years agos4:ldapsrv Place the 'privilaged' ldapi socket under an #ifdef
Andrew Bartlett [Thu, 18 Jun 2009 04:55:31 +0000 (14:55 +1000)]
s4:ldapsrv Place the 'privilaged' ldapi socket under an #ifdef

This makes it clear to our users that this particular implementation
isn't final (all parties are agreed that an EXTERNAL bind is the right
way to do this, but it has not been implemented yet).

Andrew Bartlett

11 years agoadded some basic documentation for the idmap script option
Andrew Tridgell [Fri, 19 Jun 2009 03:57:30 +0000 (13:57 +1000)]
added some basic documentation for the idmap script option

11 years agoadded a sample script for the "idmap script" option
Andrew Tridgell [Fri, 19 Jun 2009 03:57:13 +0000 (13:57 +1000)]
added a sample script for the "idmap script" option

11 years agoPartially revert restriction of socket_wrapper to 1500 byte writes
Andrew Bartlett [Fri, 19 Jun 2009 03:25:28 +0000 (13:25 +1000)]
Partially revert restriction of socket_wrapper to 1500 byte writes

This keeps the restriction for stream sockets (where the caller will
retry), without creating problems on datagram sockets (CLDAP is not
defined, as far as I know, across multiple UDP packets).

The commit adding this restriction was

Andrew Bartlett

11 years agos4:ldb Add test for integer normalisation behaviour
Andrew Bartlett [Fri, 19 Jun 2009 01:29:31 +0000 (11:29 +1000)]
s4:ldb Add test for integer normalisation behaviour

This uses groupType as the example, but this actually applies to all
integer types in AD.

Andrew Bartlett

11 years agoA fix in the ACL code used by both SAMBA 3 and 4
Matthias Dieter Wallnöfer [Thu, 18 Jun 2009 09:18:05 +0000 (11:18 +0200)]
A fix in the ACL code used by both SAMBA 3 and 4

This fixes an uninitialised structure. It has been found through valgrind
in the RAW-ACLs test suite (Bug #6397).

11 years agoFixed some uninitialised variables
Matthias Dieter Wallnöfer [Thu, 18 Jun 2009 09:16:16 +0000 (11:16 +0200)]
Fixed some uninitialised variables

I tried hard to not change the program logic. Should fix bug #6439.

11 years agoCorrect handling of 32-bit integer attributes in SAMBA 4
Matthias Dieter Wallnöfer [Thu, 18 Jun 2009 09:05:45 +0000 (11:05 +0200)]
Correct handling of 32-bit integer attributes in SAMBA 4
- LDB handles now all 32-bit integer attributes correctly (also with overflows)
  according to the schema
- LDAP backends handle the attributes "groupType", "userAccountControl" and
  "sAMAccountType" correctly. This handling doesn't yet use the schema but
  the conversion file "" which contains them hardcoded.
  Did also a refactoring of the conversion function there.
- Bug #6136 should be gone

11 years agos3-pam_winbind: Fix Bug 6253: Use correct value for password expiry calculation.
Günther Deschner [Thu, 18 Jun 2009 23:57:16 +0000 (01:57 +0200)]
s3-pam_winbind: Fix Bug 6253: Use correct value for password expiry calculation.

Based on patch from Blindauer Emmanuel <>.


11 years agoFix bug 4699: Remove pidfile on clean shutdown
Volker Lendecke [Thu, 18 Jun 2009 09:45:57 +0000 (11:45 +0200)]
Fix bug 4699: Remove pidfile on clean shutdown

11 years agoacl_group_override() doesn't need to call stat. Pass this
Jeremy Allison [Thu, 18 Jun 2009 22:40:14 +0000 (15:40 -0700)]
acl_group_override() doesn't need to call stat. Pass this
down from above (as const).

11 years agoAdd some const to the stat struct in the dosmode calls.
Jeremy Allison [Thu, 18 Jun 2009 22:07:14 +0000 (15:07 -0700)]
Add some const to the stat struct in the dosmode calls.
Fix a couple more unix_convert uses to filename_convert.
Fix bug in acl_group_override() where an uninitialized
struct could be used. Move unix_convert with wildcard
use in SMBsearch reply to boilerplate code.

11 years agoReplace the boilerplate calls to :
Jeremy Allison [Thu, 18 Jun 2009 20:13:38 +0000 (13:13 -0700)]
Replace the boilerplate calls to :
resolve_dfspath() -> unix_convert() -> get_full_smb_filename() -> check_name()
with a new function filename_convert().
This restores the check_name() calls that had gone missing
since the default create_file was changed. All "standard"
pathname processing now goes through filename_convert().
I'll take a look at the non-standard pathname processing
next. As a benefit, fixed a missing resolve_dfspath()
in the trans2 mkdir call.

11 years agolibwbclient: fix returned LogonInfo in wbc_LogonUser().
Günther Deschner [Thu, 18 Jun 2009 14:17:26 +0000 (16:17 +0200)]
libwbclient: fix returned LogonInfo in wbc_LogonUser().

That function could return emtpy blobs for username and ccache for e.g. cached


11 years agowbinfo: use wbcLogonUser for wbinfo -K.
Günther Deschner [Thu, 18 Jun 2009 14:33:46 +0000 (16:33 +0200)]
wbinfo: use wbcLogonUser for wbinfo -K.


11 years agoRevert "For tevent to install tevent_util.h"
Simo Sorce [Thu, 18 Jun 2009 11:56:51 +0000 (07:56 -0400)]
Revert "For tevent to install tevent_util.h"

This reverts commit b112cc5503350b248949bdbcce8072f5523ce877.

tevent_util.h is a private header. Must not be installed.

11 years agos3/docs: Add documentation for 'net sam rights'.
Karolin Seeger [Thu, 18 Jun 2009 07:32:10 +0000 (09:32 +0200)]
s3/docs: Add documentation for 'net sam rights'.

This is part of a fix for bug #6328.


11 years agos3:netlogon Cope with recent rename in netlogon.idl
Andrew Bartlett [Thu, 18 Jun 2009 05:00:28 +0000 (15:00 +1000)]
s3:netlogon Cope with recent rename in netlogon.idl

11 years agoRemove unused variable
Andrew Bartlett [Thu, 18 Jun 2009 04:02:13 +0000 (14:02 +1000)]
Remove unused variable

11 years agoBump the ldb version and the version Samba4 requires.
Andrew Bartlett [Thu, 18 Jun 2009 03:50:36 +0000 (13:50 +1000)]
Bump the ldb version and the version Samba4 requires.

We have made a lot of useful changes to LDB since the last realese,
that Samba4 now relies on.  This ensures that a build against a system
LDB will only succeed against the right version.

Andrew Bartlett

11 years agos4: Add tests and 'must change password' flags in setpassword and newuser
Andrew Bartlett [Thu, 18 Jun 2009 02:38:04 +0000 (12:38 +1000)]
s4: Add tests and 'must change password' flags in setpassword and newuser

In particular, ensure that we can acutally change the password under
these circumstances.

Andrew Bartlett

11 years agos4:testprogs Don't specify a username/password when checking the ccache
Andrew Bartlett [Thu, 18 Jun 2009 02:36:00 +0000 (12:36 +1000)]
s4:testprogs Don't specify a username/password when checking the ccache

The purpose of this test is to ensure that the Kerberos credentials
cache is valid.  If the username and password is specified, this
overrides the very thing we are trying to test.

Andrew Bartlett

11 years agos4:libnet Allow 'net password change' to work on expired passwords
Andrew Bartlett [Thu, 18 Jun 2009 02:33:46 +0000 (12:33 +1000)]
s4:libnet Allow 'net password change' to work on expired passwords

We need to pass down flags to the DCE/RPC layer to allow fallback to
anonymous connections, as we can't log in with an expired password.

The anonymous connection can then change the password with SAMR.

Andrew Bartlett

11 years agos4:kdc Allow a password change when the password is expired
Andrew Bartlett [Thu, 18 Jun 2009 01:08:46 +0000 (11:08 +1000)]
s4:kdc Allow a password change when the password is expired

This requires a rework on Heimdal's windc plugin layer, as we want
full control over what tickets Heimdal will issue.  (In particular, in
case our requirements become more complex in future).

The original problem was that Heimdal's check would permit the ticket,
but Samba would then deny it, not knowing it was for kadmin/changepw

Also (in hdb-samba4) be a bit more careful on what entries we will
make the 'change_pw' service mark that this depends on.

Andrew Bartlett

11 years agos4:setup Add an option to 'setpassword' to force password change at next login
Andrew Bartlett [Tue, 16 Jun 2009 23:14:17 +0000 (09:14 +1000)]
s4:setup Add an option to 'setpassword' to force password change at next login

11 years agos4:gensec Print GSSAPI error message when unable to find PAC
Andrew Bartlett [Tue, 16 Jun 2009 23:13:12 +0000 (09:13 +1000)]
s4:gensec Print GSSAPI error message when unable to find PAC

11 years agoRequire the new tdb 1.1.5 (for performance reasons)
Andrew Bartlett [Tue, 16 Jun 2009 23:08:23 +0000 (09:08 +1000)]
Require the new tdb 1.1.5 (for performance reasons)

While tdb has not changed ABI in a way that requires this, we don't
want Samba4 somehow built against the old version with
performance problems on large, growing databases.

Andrew Bartlett

11 years agoFixes for the "cldap" tests
Matthias Dieter Wallnöfer [Mon, 15 Jun 2009 15:55:43 +0000 (17:55 +0200)]
Fixes for the "cldap" tests

- Insert a check after the "tsocket" library call to make sure that the call
  terminated correctly
- Add a comment to explain why on further calls of "cldap_socket_init" the
  destination address hasn't to be specified

11 years agosource4/client/client.c: Possible memory leaks
Slava Semushin [Fri, 12 Jun 2009 11:32:48 +0000 (13:32 +0200)]
source4/client/client.c: Possible memory leaks

Patch for bug #6446

cppcheck found 2 possible memory leaks:

    [./source4/client/client.c:3305]: (error) Memory leak: base_directory
    [./source4/client/client.c:3305]: (error) Memory leak: desthost

Patch in attach.

11 years agoFix resource leak in lib/ldb/tools/ldbmodify.c
Slava Semushin [Fri, 12 Jun 2009 11:31:13 +0000 (13:31 +0200)]
Fix resource leak in lib/ldb/tools/ldbmodify.c

Patch for bug #6389

11 years agoFix syntax error in lib/ldb/ldb_sqlite3/base160.c
Slava Semushin [Fri, 12 Jun 2009 11:28:49 +0000 (13:28 +0200)]
Fix syntax error in lib/ldb/ldb_sqlite3/base160.c

Patch for bug #6388

11 years agoFor tevent to install tevent_util.h
Eric Sandall [Fri, 12 Jun 2009 11:24:30 +0000 (13:24 +0200)]
For tevent to install tevent_util.h

Patch for bug #6270

This patch is for the future when samba4 builds using external libraries. With
this patch, tevent now installs tevent_util.h which is required by samba4.

11 years agoLDB: Link against both tevent and talloc
Eric Sandall [Fri, 12 Jun 2009 11:03:34 +0000 (13:03 +0200)]
LDB: Link against both tevent and talloc

Patch for bug #6269

When linking against tevent you also need to link against talloc. This patch
fixes external/libevent.m4 to do so.

11 years agos4: Call va_end() after all va_start()/va_copy() calls.
Andrew Kroeger [Fri, 12 Jun 2009 11:01:41 +0000 (13:01 +0200)]
s4: Call va_end() after all va_start()/va_copy() calls.

This corrects the issues reaised in bug #6129, and some others that were not
originally identified.  It also accounts for some code that was in the original
bug report but appears to have since been made common between S3 and S4.

Thanks to Erik Hovland <> for the original bug report.

11 years agoNETLOGON pipe improvements
Matthias Dieter Wallnöfer [Fri, 12 Jun 2009 10:38:22 +0000 (12:38 +0200)]
NETLOGON pipe improvements

Patch for bug #4939

This refactors the NETLOGON code related to this bug:

- Introduces a new "SYNCSTATE" enum required by the "DatabaseSync2" call (acc.
to WSPP)
- Make "DatabaseSync" dependant from "DatabaseSync2" (acc. to WSPP)
- Let "DatabaseSync2" return NT_STATUS_NOT_IMPLEMENTED (I'm not sure if this is
also true when a domain is running in mixed mode)
- Make "LogonControl" and "LogonControl2" dependant form "LogonControl2Ex"
(acc. to WSPP)
- Let "LogonControl2Ex" return WERR_NOT_SUPPORTED for now

11 years agoAdd const to cast, to fix warning
Andrew Bartlett [Mon, 15 Jun 2009 13:46:58 +0000 (23:46 +1000)]
Add const to cast, to fix warning

11 years agos3 onefs: Remove dfs resolution from create_file() now that it's being done at a...
Tim Prouty [Thu, 18 Jun 2009 02:54:12 +0000 (19:54 -0700)]
s3 onefs: Remove dfs resolution from create_file() now that it's being done at a higher level

11 years agos3: Change SMB_VFS_OPEN to take an smb_filename struct
Tim Prouty [Tue, 16 Jun 2009 19:01:13 +0000 (12:01 -0700)]
s3: Change SMB_VFS_OPEN to take an smb_filename struct

This was a little messy because of all of the vfs modules I had to
touch.  Most of them were pretty straight forward, but the streams
modules required a little attention to handle smb_filename.  Since the
use of smb_filename enables the vfs modules to access the raw,
over-the-wire stream, a little bit of the handling that was being done
by split_ntfs_stream_name has now been shifted into the individual
stream modules.  It may be a little more code, but overall it gives
more flexibility to the streams modules, while also allowing correct
stream handling.

11 years agos3: Plumb smb_filename from create_file all of the way down to fd_open
Tim Prouty [Mon, 15 Jun 2009 21:14:31 +0000 (14:14 -0700)]
s3: Plumb smb_filename from create_file all of the way down to fd_open

I used the smb_filename struct everywhere that was feasible for the
first pass.  There are still some places in this path that need to be
changed to use smb_filename, but this is a good start.

I also:
- Removed fname/path arguments from a few functions that weren't
  really using them.
- Added a utility function for detecting whether an smb_filename is a

11 years agoUse system Python LDB bindings, if present.
Jelmer Vernooij [Thu, 18 Jun 2009 02:20:46 +0000 (04:20 +0200)]
Use system Python LDB bindings, if present.

11 years agoUse system LDB by default if the right version was found.
Jelmer Vernooij [Thu, 18 Jun 2009 01:09:36 +0000 (03:09 +0200)]
Use system LDB by default if the right version was found.

11 years agodsdb: Fix build against system ldb.
Jelmer Vernooij [Thu, 18 Jun 2009 01:09:14 +0000 (03:09 +0200)]
dsdb: Fix build against system ldb.

11 years agoselftest: Use common function when skipping testsuites based on run-time
Jelmer Vernooij [Thu, 18 Jun 2009 01:08:21 +0000 (03:08 +0200)]
selftest: Use common function when skipping testsuites based on run-time

11 years agosmb_build: Always build modules for system-libraries as shared libraries,
Jelmer Vernooij [Thu, 18 Jun 2009 00:32:26 +0000 (02:32 +0200)]
smb_build: Always build modules for system-libraries as shared libraries,
since they can't be included in the static library.

11 years agoFix build with system LDB.
Jelmer Vernooij [Wed, 17 Jun 2009 23:21:35 +0000 (01:21 +0200)]
Fix build with system LDB.

11 years agoconfigure: Use Python tdb bindings from the system, if found.
Jelmer Vernooij [Wed, 17 Jun 2009 22:53:05 +0000 (00:53 +0200)]
configure: Use Python tdb bindings from the system, if found.

11 years agoRemove outdated Python status file.
Jelmer Vernooij [Wed, 17 Jun 2009 19:48:02 +0000 (21:48 +0200)]
Remove outdated Python status file.

11 years agoFix bug #6476 - more then 3000 smbd-zombies in memory
Jeremy Allison [Wed, 17 Jun 2009 20:56:21 +0000 (13:56 -0700)]
Fix bug #6476 - more then 3000 smbd-zombies in memory
We weren't reaping children in the [x]inetd case.

11 years agoselftest: report time after testsuite, gives nicer output on the
Jelmer Vernooij [Wed, 17 Jun 2009 19:37:49 +0000 (21:37 +0200)]
selftest: report time after testsuite, gives nicer output on the

11 years agotdb: Fix help string in configure flag to enable Python bindings.
Jelmer Vernooij [Wed, 17 Jun 2009 19:12:50 +0000 (21:12 +0200)]
tdb: Fix help string in configure flag to enable Python bindings.

11 years agoOnly install an explicit set of scripts during "make install", rather than
Jelmer Vernooij [Wed, 17 Jun 2009 19:00:22 +0000 (21:00 +0200)]
Only install an explicit set of scripts during "make install", rather than
whatever happens to be in the source tree.

11 years agoMake fullschema script executable.
Jelmer Vernooij [Wed, 17 Jun 2009 18:52:43 +0000 (20:52 +0200)]
Make fullschema script executable.

11 years agopyldb: Fix three more (minor) memory leaks.
Jelmer Vernooij [Wed, 17 Jun 2009 18:43:25 +0000 (20:43 +0200)]
pyldb: Fix three more (minor) memory leaks.

11 years agopyldb: Fix memory leak in Dn.get_parent().
Jelmer Vernooij [Wed, 17 Jun 2009 18:32:35 +0000 (20:32 +0200)]
pyldb: Fix memory leak in Dn.get_parent().

11 years agopyldb: Fix memory leak in Dn.concat.
Jelmer Vernooij [Wed, 17 Jun 2009 18:23:54 +0000 (20:23 +0200)]
pyldb: Fix memory leak in Dn.concat.

11 years agopyldb/tests: Use different dn's everywhere, to easily spot which test is
Jelmer Vernooij [Wed, 17 Jun 2009 18:17:56 +0000 (20:17 +0200)]
pyldb/tests: Use different dn's everywhere, to easily spot which test is
breaking in gdb.

11 years agopyldb: Fix another memory leak and reference counting error.
Jelmer Vernooij [Wed, 17 Jun 2009 18:17:35 +0000 (20:17 +0200)]
pyldb: Fix another memory leak and reference counting error.

11 years agoparam/python: Fix memory leak of LoadParm objects.
Jelmer Vernooij [Wed, 17 Jun 2009 17:07:44 +0000 (19:07 +0200)]
param/python: Fix memory leak of LoadParm objects.

11 years agopycredentials: Raise MemoryError when unable to create objects.
Jelmer Vernooij [Wed, 17 Jun 2009 17:07:22 +0000 (19:07 +0200)]
pycredentials: Raise MemoryError when unable to create objects.

11 years agopyldb: Fix memory leak of LdbMessage's created from Python.
Jelmer Vernooij [Wed, 17 Jun 2009 17:01:06 +0000 (19:01 +0200)]
pyldb: Fix memory leak of LdbMessage's created from Python.

11 years agopycredentials: Fix memory leak.
Jelmer Vernooij [Wed, 17 Jun 2009 17:00:31 +0000 (19:00 +0200)]
pycredentials: Fix memory leak.

11 years agopyldb: Fix two memory leaks of attribute lists.
Jelmer Vernooij [Wed, 17 Jun 2009 16:36:16 +0000 (18:36 +0200)]
pyldb: Fix two memory leaks of attribute lists.

11 years agopyldb: Fix segfault, freeing memory too early in search.
Jelmer Vernooij [Wed, 17 Jun 2009 16:26:40 +0000 (18:26 +0200)]
pyldb: Fix segfault, freeing memory too early in search.

11 years agopyldb: Support getting the parent of special DNs without segfaulting.
Jelmer Vernooij [Wed, 17 Jun 2009 16:25:21 +0000 (18:25 +0200)]
pyldb: Support getting the parent of special DNs without segfaulting.

Found by: Андрей Григорьев <>

11 years agofix release scripts to always git clean
Simo Sorce [Wed, 17 Jun 2009 18:14:31 +0000 (14:14 -0400)]
fix release scripts to always git clean

This makes sure we do not include foreign object files or other
build byproducts by mistake.

11 years agos3-net: Fix Bug #6328: support "net sam rights grant/revoke" with multiple rights.
David Markey [Wed, 17 Jun 2009 16:29:20 +0000 (18:29 +0200)]
s3-net: Fix Bug #6328: support "net sam rights grant/revoke" with multiple rights.


Signed-off-by: Günther Deschner <>
11 years agos3/packaging: pam_winbind has been moved to section 8.
Karolin Seeger [Wed, 17 Jun 2009 13:19:20 +0000 (15:19 +0200)]
s3/packaging: pam_winbind has been moved to section 8.


11 years agos3/packaging: source -> source3
Karolin Seeger [Wed, 17 Jun 2009 13:18:16 +0000 (15:18 +0200)]
s3/packaging: source -> source3


11 years agos3/i18n: Add Russian to the list.
Karolin Seeger [Wed, 17 Jun 2009 12:37:28 +0000 (14:37 +0200)]
s3/i18n: Add Russian to the list.


11 years agos3/i18n: Add Russian translation for SWAT messages.
Karolin Seeger [Wed, 17 Jun 2009 12:31:29 +0000 (14:31 +0200)]
s3/i18n: Add Russian translation for SWAT messages.

Thanks to Yuri Kozlov <kozlov.y [at]>!

This is part of a fix for bug #4755.

11 years agos3-net: Fix Bug #6328: allow multiple rights in "net sam rights grant".
Günther Deschner [Wed, 17 Jun 2009 10:31:49 +0000 (12:31 +0200)]
s3-net: Fix Bug #6328: allow multiple rights in "net sam rights grant".


11 years agos3/i18n: Update German SWAT translations.
Karolin Seeger [Wed, 17 Jun 2009 10:15:59 +0000 (12:15 +0200)]
s3/i18n: Update German SWAT translations.

This is part of a fix for bug #4755.
Patch was provided (mainly) by Helge Kreutzmann <debian [at]>.


11 years agos3/libsmb: Fix typo in error message.
Karolin Seeger [Wed, 17 Jun 2009 08:23:21 +0000 (10:23 +0200)]
s3/libsmb: Fix typo in error message.

Thanks to Herb Lewis <hlewis [at]> for noticing!


11 years agoRemove msdfs pathname processing from default create file.
Jeremy Allison [Wed, 17 Jun 2009 00:42:41 +0000 (17:42 -0700)]
Remove msdfs pathname processing from default create file.
No longer needed.

11 years agoFix msdfs after the change to smb_filename struct. We must *always*
Jeremy Allison [Wed, 17 Jun 2009 00:23:54 +0000 (17:23 -0700)]
Fix msdfs after the change to smb_filename struct. We must *always*
pull the pathname, then call resolve_dfspath(), before unix_convert().

11 years agos4-smbtorture: add test for NetUserSetInfo level 0 (user rename).
Günther Deschner [Tue, 16 Jun 2009 23:30:22 +0000 (01:30 +0200)]
s4-smbtorture: add test for NetUserSetInfo level 0 (user rename).


11 years agos4-smbtorture: use torture_comment in RPC-SAMR-USERS-PRIVILEGES test.
Günther Deschner [Tue, 16 Jun 2009 23:20:03 +0000 (01:20 +0200)]
s4-smbtorture: use torture_comment in RPC-SAMR-USERS-PRIVILEGES test.


11 years agos4-smbtorture: use TORTURE_TEST_USER define in libnetapi user test.
Günther Deschner [Tue, 16 Jun 2009 23:06:14 +0000 (01:06 +0200)]
s4-smbtorture: use TORTURE_TEST_USER define in libnetapi user test.


11 years ago_lsa_EnumAccountRights and _lsa_EnumPrivsAccount can return an
Jeremy Allison [Tue, 16 Jun 2009 20:17:24 +0000 (13:17 -0700)]
_lsa_EnumAccountRights and _lsa_EnumPrivsAccount can return an
empty set of privilages if the SID doesn't have any.
(From [MS-LSAD.pdf])

11 years agos3-netapi: Fix Bug #6451: net/libnetapi user rename using wrong access bits.
Günther Deschner [Tue, 16 Jun 2009 13:00:20 +0000 (15:00 +0200)]
s3-netapi: Fix Bug #6451: net/libnetapi user rename using wrong access bits.


11 years agos3-netapi: Fix Bug #6305. Correctly prompt for a password when a username was given.
Günther Deschner [Wed, 13 May 2009 21:57:26 +0000 (23:57 +0200)]
s3-netapi: Fix Bug #6305. Correctly prompt for a password when a username was given.

When no callback or wrapping has managed to get a password, prompt in the
netapi connection manager for a password.


11 years agos3-docs: fix typo in pam_winbind.8.
Günther Deschner [Tue, 16 Jun 2009 09:49:36 +0000 (11:49 +0200)]
s3-docs: fix typo in pam_winbind.8.


11 years agos3-netapi: add NetGetJoinInformation example code.
Günther Deschner [Mon, 15 Jun 2009 15:25:08 +0000 (17:25 +0200)]
s3-netapi: add NetGetJoinInformation example code.


11 years agopython: Provide way to iterate over available shares.
Jelmer Vernooij [Tue, 16 Jun 2009 00:24:43 +0000 (02:24 +0200)]
python: Provide way to iterate over available shares.

11 years agopython: Add API for accessing available shares.
Jelmer Vernooij [Tue, 16 Jun 2009 00:05:18 +0000 (02:05 +0200)]
python: Add API for accessing available shares.