13 years agor2482: Fix from Arthur van Dongen <> to fix acces -> access typos.
Jeremy Allison [Wed, 22 Sep 2004 00:50:12 +0000 (00:50 +0000)]
r2482: Fix from Arthur van Dongen <> to fix acces -> access typos.
(This used to be commit a278dca1b2c103f368d154aee2d3a1edd5604687)

13 years agor2481: Patch from Igor Belyi <>. Ensure pdb
Jeremy Allison [Wed, 22 Sep 2004 00:33:09 +0000 (00:33 +0000)]
r2481: Patch from Igor Belyi <>. Ensure pdb
user is deleted first before deleting UNIX user (LDAP backend
needs this ordering).
(This used to be commit 2815b31e013e517a58027ba74f118209caf4d85f)

13 years agor2479: Stop attribute "modifyTimestamp" from being deleted.
Jeremy Allison [Tue, 21 Sep 2004 22:16:36 +0000 (22:16 +0000)]
r2479: Stop attribute "modifyTimestamp" from being deleted.
(This used to be commit 0351bf8b03306246efc17e532ebe78ecdafb645d)

13 years agor2477: Document "--destination" for "net rpc [printer|share] migrate".
Günther Deschner [Tue, 21 Sep 2004 13:46:12 +0000 (13:46 +0000)]
r2477: Document "--destination" for "net rpc [printer|share] migrate".

(This used to be commit 4aa670385f81ab3d90a2c5dd8ba6e0190f947452)

13 years agor2476: now that PRINTER_ATTRIBUTE_PUBLISHED does not get reset anymore, migrate
Günther Deschner [Tue, 21 Sep 2004 13:31:57 +0000 (13:31 +0000)]
r2476: now that PRINTER_ATTRIBUTE_PUBLISHED does not get reset anymore, migrate
the publishing-state for migrated printers as well.

Therefor added client-side-support for setprinter level 7.

Next will be a "net rpc printer publish"-command (just for completeness).

(This used to be commit 224920738fdc65ef170152062177421cfed85bbf)

13 years agor2475: A more helpful debug-message when a connection to a dfs-proxy-share is
Günther Deschner [Tue, 21 Sep 2004 13:04:35 +0000 (13:04 +0000)]
r2475: A more helpful debug-message when a connection to a dfs-proxy-share is

(This used to be commit 486bcff17faf8c7ecd9bf4bb9af244bc4bcdf843)

13 years agor2474: (re-)fix memleak (initially found by jra).
Günther Deschner [Tue, 21 Sep 2004 12:50:04 +0000 (12:50 +0000)]
r2474: (re-)fix memleak (initially found by jra).

heimdal 0.6.1rc3 had a bug causing winbindd to die, heimdal version
0.6.1 and higher have that fixed (thanks to Love from Heimdal).

SuSE has been informed about this possible pitfall, any other vendors
that ship with heimdal-0.6.1rc3 to be notified ?

(This used to be commit 6239a5bec99c62032e0cde20679a71622dd7a059)

13 years agor2473: Convert internal data to UTF-8 before calling libxml2
Jelmer Vernooij [Tue, 21 Sep 2004 11:50:42 +0000 (11:50 +0000)]
r2473: Convert internal data to UTF-8 before calling libxml2
(This used to be commit 8be3fa5bfa80b51f30f1c93a7fc9e95e2b1996a7)

13 years agor2472: Fixed krb5_krbhost_get_addrinfo()-parameters and make failure
Günther Deschner [Tue, 21 Sep 2004 10:40:45 +0000 (10:40 +0000)]
r2472: Fixed krb5_krbhost_get_addrinfo()-parameters and make failure
of this call non-critical.

Thanks to Love for the patch and explaining the inner workings of

(This used to be commit 4bd9d8240b571fdd8546af4eea3f4f148987d57c)

13 years agor2470: Fix bug 1797: winbind and nmbd ignored "-l" option.
Volker Lendecke [Tue, 21 Sep 2004 09:07:42 +0000 (09:07 +0000)]
r2470: Fix bug 1797: winbind and nmbd ignored "-l" option.

Thanks to Igor Zhbanov

(This used to be commit 8a28475a0b7659cb0cdefe57edf801d9958c3755)

13 years agor2466: Fix memleak found by
Volker Lendecke [Tue, 21 Sep 2004 07:55:49 +0000 (07:55 +0000)]
r2466: Fix memleak found by


(This used to be commit 587d863ae87042e0193b8d27b52ab3f75c58974b)

13 years agor2453: I think this is the last lot of fixes to get shared libraries working on
Tim Potter [Tue, 21 Sep 2004 01:37:34 +0000 (01:37 +0000)]
r2453: I think this is the last lot of fixes to get shared libraries working on
HPUX.  This is Richard Allen's suggestion to get HPUX to use cc instead of

Also he added some missing $(DYNEXP) on link lines and removed the definition
of $(LINK) as it is no longer used in the Makefile.
(This used to be commit 9481f2a79e83b0dae9141f65ccc59e59bcf682e7)

13 years agor2451: Fix from Henrik Nordstrom <> to allow
Jeremy Allison [Mon, 20 Sep 2004 20:18:19 +0000 (20:18 +0000)]
r2451: Fix from Henrik Nordstrom <> to allow
winbindd to return the correct number of groups when the
groups array must be enlarged.
(This used to be commit bcc769de4d60205209633887f2fb2f0ab6088cae)

13 years agor2450: don't limit the number of groups returned by winbindd_getgroups()
Gerald Carter [Mon, 20 Sep 2004 19:19:59 +0000 (19:19 +0000)]
r2450: don't limit the number of groups returned by winbindd_getgroups()
(This used to be commit 4ba98cb469ad938bbc2e46cffaa48cc1c46b8e4e)

13 years agor2444: Based on jmcd's patch, implement special lists for the ldap user attributes to
Volker Lendecke [Mon, 20 Sep 2004 11:02:14 +0000 (11:02 +0000)]
r2444: Based on jmcd's patch, implement special lists for the ldap user attributes to

Richard, IMHO this is the better solution to the problem you currently
have. Please review.


(This used to be commit 6957d6a8921fbd97747258249d99b505a79cfcb4)

13 years agor2440: Use sys_fork instead of fork for the dual daemon so that we get the
Volker Lendecke [Mon, 20 Sep 2004 09:48:46 +0000 (09:48 +0000)]
r2440: Use sys_fork instead of fork for the dual daemon so that we get the
correct debug pid in the logfiles.

(This used to be commit 410d2c3ebba71434ad92d4572fec64eea7b952cd)

13 years agor2420: Way back at the 1st SambaXP, Simo pointed out a subtle bug related to the
Christopher R. Hertel [Sun, 19 Sep 2004 21:25:24 +0000 (21:25 +0000)]
r2420: Way back at the 1st SambaXP, Simo pointed out a subtle bug related to the
interaction between the splay tree code and the code used to find a leaf
node.  The problem is rare, and with most sites using the newer hashing
algorithm it's probably not important to fix it.  I have fixed it,
(This used to be commit b3997aeaf47d5cf0d5ed63038f3b22c9dfcdff4c)

13 years agor2413: Arggg. Stupid, stupid, stupid me ! I added a paranoia test
Jeremy Allison [Sun, 19 Sep 2004 01:16:45 +0000 (01:16 +0000)]
r2413: Arggg. Stupid, stupid, stupid me ! I added a paranoia test
case when I was developing the deferred open case and made it
too tight. It will fire (incorrectly) and panic when a client
does a second open for a file with a different mid (multiplex-id)
request. Doh ! This is a perfectly valid thing for a client to
do (have two pending opens with different mids outstanding on
the same file) and currently when the first pending open expires
with a share violation the paranoia code will panic smbd.

It's a rare condition, but obvious now I've looked at the

Fix for bug #1743.

(This used to be commit e1bf108ae965ae730c67524164fa36497ea905b5)

13 years agor2396: Fix bug found by Cornelio Bondad Jr <>.
Jeremy Allison [Fri, 17 Sep 2004 21:20:32 +0000 (21:20 +0000)]
r2396: Fix bug found by Cornelio Bondad Jr <>.
To correct “net rpc vampire” core dump.
(This used to be commit cd910ffc510f2007c2619d7a4d31e5e41de7d1d1)

13 years agor2395: Patch from "Stefan (metze) Metzmacher" <> to fix
Jeremy Allison [Fri, 17 Sep 2004 19:58:27 +0000 (19:58 +0000)]
r2395: Patch from "Stefan (metze) Metzmacher" <> to fix
opening of quota file.
(This used to be commit 9a6e331639d7aace294dd663de7d27912fcae146)

13 years agor2392: Steal the nicer error message from Samba4 :-).
Jeremy Allison [Fri, 17 Sep 2004 19:53:12 +0000 (19:53 +0000)]
r2392: Steal the nicer error message from Samba4 :-).
(This used to be commit afa88868b76a6e825bc45f8d405d4b3f557fdfdb)

13 years agor2390: Update some URLs and locations in README
Jelmer Vernooij [Fri, 17 Sep 2004 17:31:31 +0000 (17:31 +0000)]
r2390: Update some URLs and locations in README
(This used to be commit 4e29698467d124663226929b485d27d3f67e0f8e)

13 years agor2388: fix client quota support
Stefan Metzmacher [Fri, 17 Sep 2004 15:09:20 +0000 (15:09 +0000)]
r2388: fix client quota support

for the client we need the windows path and for server we need unix path

(This used to be commit 54fd28f5e7b70ce2b192c2037ce28da3fea9ef92)

13 years agor2378: Remove two confusing #defines
Volker Lendecke [Fri, 17 Sep 2004 09:18:02 +0000 (09:18 +0000)]
r2378: Remove two confusing #defines
(This used to be commit 639cb4ced6b6c08b0665890c815f2e1361e7879f)

13 years agor2374: Fix from Vince Brimhall for
Jeremy Allison [Fri, 17 Sep 2004 01:13:47 +0000 (01:13 +0000)]
r2374: Fix from Vince Brimhall for
ldapsam_compat. Be robust against NULL attributes.
(This used to be commit 727fc341b578577c112e97b0ef6f4c7f8bd15f66)

13 years agor2373: Fix typo.
Jeremy Allison [Fri, 17 Sep 2004 00:53:17 +0000 (00:53 +0000)]
r2373: Fix typo.
(This used to be commit b1033fc77c97f0d9b5613a0b9f7d45dcf58e6b56)

13 years agor2371: Fix for talking to OS/2 clients (max_mux ignored) by Guenter Kukkukk <guenter...
Jeremy Allison [Fri, 17 Sep 2004 00:49:41 +0000 (00:49 +0000)]
r2371: Fix for talking to OS/2 clients (max_mux ignored) by Guenter Kukkukk <>.
Bugid #1590.
(This used to be commit 330025d1a669de927a3879a9c3a9fc20e1be464f)

13 years agor2369: Fix from Richard Renard <> to fix usermgr and trust relation...
Jeremy Allison [Thu, 16 Sep 2004 22:08:26 +0000 (22:08 +0000)]
r2369: Fix from Richard Renard <> to fix usermgr and trust relationships.
(This used to be commit b910e530027c19c4e505314a91ffcb72f20d8f09)

13 years agor2364: Include yp_prot.h before ypclnt.h as AIX 5.2 spits the dummy otherwise.
Tim Potter [Thu, 16 Sep 2004 02:49:01 +0000 (02:49 +0000)]
r2364: Include yp_prot.h before ypclnt.h as AIX 5.2 spits the dummy otherwise.
Bugzilla #1778.
(This used to be commit 0f1ffe0f304d367fa5db1cfd92a8f5e365233c1f)

13 years agor2363: Fix to make find_workgroup use the same truncation as
Jeremy Allison [Thu, 16 Sep 2004 00:25:04 +0000 (00:25 +0000)]
r2363: Fix to make find_workgroup use the same truncation as
create_workgroup (refactor to a common function).
Patch from Paul Szabo -
(This used to be commit b2b6d6e890813b0d222ac75efb95434ba8c70e46)

13 years agor2361: Fix the appalling toktocliplist() fn. Bug found by Luis Benvenutto.
Jeremy Allison [Wed, 15 Sep 2004 22:49:23 +0000 (22:49 +0000)]
r2361: Fix the appalling toktocliplist() fn. Bug found by Luis Benvenutto.
(This used to be commit d434d8e2b47bc8553ee04bd7211f622e3fcbb7fb)

13 years agor2355: Now we've shipped 3.0.7, add in the DOS fix.
Jeremy Allison [Wed, 15 Sep 2004 20:33:03 +0000 (20:33 +0000)]
r2355: Now we've shipped 3.0.7, add in the DOS fix.
(This used to be commit d6b26f9db76e81d65b7630e46af99fe03a982ec6)

13 years agor2351: Fix use of an uninitialized variable. valgrind is sooo useful.
Volker Lendecke [Wed, 15 Sep 2004 15:12:36 +0000 (15:12 +0000)]
r2351: Fix use of an uninitialized variable. valgrind is sooo useful.

(This used to be commit 11f617eafd5512dab89bc363662f8e6953c359d4)

13 years agor2348: fix segmention faults
Stefan Metzmacher [Wed, 15 Sep 2004 13:57:33 +0000 (13:57 +0000)]
r2348: fix segmention faults

in smbcquotas and smbcacls caused by setup_logging() (-r 1425)

(This used to be commit 39f3f76ea2097c10799f0bef8717d3ac71cacaa8)

13 years agor2340: Solve the problem of user sids ending up with gid's and vice versa: This
Volker Lendecke [Wed, 15 Sep 2004 08:55:01 +0000 (08:55 +0000)]
r2340: Solve the problem of user sids ending up with gid's and vice versa: This
belongs into winbind itself, not into wbinfo.

(This used to be commit 75e5c13d5d4c1da9bbb60f4e93183995c05a89ac)

13 years agor2338: Remove lonely looking definition of DYNEXP for HPUX in the configure
Tim Potter [Wed, 15 Sep 2004 00:59:31 +0000 (00:59 +0000)]
r2338: Remove lonely looking definition of DYNEXP for HPUX in the configure
"CPPFLAG settings for strange OS's section".  DYNEXP should only be
set in the shared library configure section.
(This used to be commit 8d00f7310c934dcecac4b0af01e74836f62fa539)

13 years agor2334: Update LDSHFLAGS for HPUX as -Wl is not necessary as we are invoking LD
Tim Potter [Tue, 14 Sep 2004 01:49:50 +0000 (01:49 +0000)]
r2334: Update LDSHFLAGS for HPUX as -Wl is not necessary as we are invoking LD
directly.  Should fix #1731.
(This used to be commit 9f241a8f2a590acd31f59f689b7eb17b6ae4f3dd)

13 years agor2333: check the script is not a 0 lenght string
Simo Sorce [Tue, 14 Sep 2004 01:11:01 +0000 (01:11 +0000)]
r2333: check the script is not a 0 lenght string
(This used to be commit 05a80c37375b3186b02b8430033796ab7a7d68bb)

13 years agor2331: check password script code and example from trunk
Simo Sorce [Tue, 14 Sep 2004 00:21:11 +0000 (00:21 +0000)]
r2331: check password script code and example from trunk
(This used to be commit f836be323a233f3a28cbaa04c532e83ea98ead89)

13 years agor2317: Fixup error messages and reformat.
Jeremy Allison [Mon, 13 Sep 2004 08:52:24 +0000 (08:52 +0000)]
r2317: Fixup error messages and reformat.
(This used to be commit 8ae10c74ec45f1493aa15ee812ff37b86c8fc439)

13 years agor2312: Fix for bugid #1667, smbpasswd file could be left locked on
Jeremy Allison [Mon, 13 Sep 2004 08:04:04 +0000 (08:04 +0000)]
r2312: Fix for bugid #1667, smbpasswd file could be left locked on
some error exits.
(This used to be commit e2b0b9fb72559a9629b116a7e063de08a12e9eb1)

13 years agor2292: changing version to 3.0.8pre1
Gerald Carter [Sun, 12 Sep 2004 04:08:20 +0000 (04:08 +0000)]
r2292: changing version to 3.0.8pre1
(This used to be commit 98799dc78236a76506d2848b7434bd521c9aca8f)

13 years agor2279: Clarification changes only.
John Terpstra [Fri, 10 Sep 2004 16:15:29 +0000 (16:15 +0000)]
r2279: Clarification changes only.
(This used to be commit 6ed4d26b08f0fde400c37042f6012a25d095594d)

13 years agor2269: Copied from SAMBA_3_RELEASE 3.0.7 branch.
John Terpstra [Thu, 9 Sep 2004 16:06:21 +0000 (16:06 +0000)]
r2269: Copied from SAMBA_3_RELEASE 3.0.7 branch.
(This used to be commit c48151d013b81cbcd172d0259b1b653cba800716)

13 years agor2265: Volkers change to HEAD looks very good. Commit message
Jeremy Allison [Thu, 9 Sep 2004 10:02:44 +0000 (10:02 +0000)]
r2265: Volkers change to HEAD looks very good. Commit message
from HEAD follows :
While torturing winbind a bit I found the following unfortunate behaviour:

Sending multiple requests at a high rate for a slow operation exposed that no
response comes back until the last request in the queue has been
processed. This is an unfortunate result of serially going through all sockets> that have shown to be readable or writable. All client sockets become readable> at the same time, none of them is writable. We go through them, read the
request, process the complete request. Before we enter the select system call
the next time all requests have to have completed.

This patch optimizes this by first looking at the sockets for writability. A
write on a socket that came back from select does not block, so this
additional loop might have a non-zero cost, but it can't prevent other
operations from proceeding.

After a possibly long-running winbindd_process() we directly start select()
again. To avoid starvation the currently processed client is demoted to be the> last one in the list of clients.

(This used to be commit bfdeb22c69d09eb73305b6034fa6d0ec67275789)

13 years agor2264: Fix for #1741. Define a struct nss_groupsbymem (thanks lukeh!) for
Tim Potter [Thu, 9 Sep 2004 03:40:27 +0000 (03:40 +0000)]
r2264: Fix for #1741.  Define a struct nss_groupsbymem (thanks lukeh!) for
HPUX 11 which doesn't have one of its own.
(This used to be commit 3d275d1eee9644651dcbb61a342648e878fe3506)

13 years agor2263: When testing whether building shared libraries actually works, use
Tim Potter [Thu, 9 Sep 2004 03:36:05 +0000 (03:36 +0000)]
r2263: When testing whether building shared libraries actually works, use
$SHLD and $LDSHFLAGS instead of $CC, $CPPFLAGS and $CFLAGS as this is
more likely to actually work.  Bugzilla #1731.

I'm checking this in to 3.0 so it can hit the build farm and flush out
any problems with other architectures.  With a bit of luck this should
go in to Samba 3.0.8.
(This used to be commit a754f29ef819e1cf7ea31c117e5ef1487cb5cb5e)

13 years agor2261: fix getdc mailslot checks; testing with Windows 98se, WinME, WinNT 4.0/200x/XP
Gerald Carter [Thu, 9 Sep 2004 01:46:20 +0000 (01:46 +0000)]
r2261: fix getdc mailslot checks; testing with Windows 98se, WinME, WinNT 4.0/200x/XP
(This used to be commit 8ad147508ac653698ebacf9fd19fc5eb5863db28)

13 years agor2258: Attempt to fix Bug 1715. Not sure if all of ldapsam_compat works now, but...
Volker Lendecke [Wed, 8 Sep 2004 18:30:00 +0000 (18:30 +0000)]
r2258: Attempt to fix Bug 1715. Not sure if all of ldapsam_compat works now, but this
definitely fixes two segfaults.

(This used to be commit 270740189995c56c4d0341aeded364efffec86f2)

13 years agor2248: Merge of tridge's PRINTF_ATTRIBUTE fixes from samba4.
Tim Potter [Wed, 8 Sep 2004 02:48:27 +0000 (02:48 +0000)]
r2248: Merge of tridge's PRINTF_ATTRIBUTE fixes from samba4.
(This used to be commit 53bfb76608efa347d5fe154c5583a5e8e3d53740)

13 years agor2246: Some good fixes for HPUX from JBravo on #samba-technical:
Tim Potter [Tue, 7 Sep 2004 23:30:27 +0000 (23:30 +0000)]
r2246: Some good fixes for HPUX from JBravo on #samba-technical:

  - Fix linker options so that stuff actually builds (oops - part of this
    commit was accidentally made in -r2245)

  - Add some preprocessor magic to avoid warnings being printed for every
    single C file being compiled.  This was due to a bug in the HPUX system
    header files.

This should make the HPUX build farm machine build again.
(This used to be commit 46b9d6dcb5bdd47ea82f904d8fac4efe8dc94c9f)

13 years agor2245: Typo fix from trunk.
Tim Potter [Tue, 7 Sep 2004 23:22:09 +0000 (23:22 +0000)]
r2245: Typo fix from trunk.
(This used to be commit 93ddf001e3e079fd1d17096afd91eb93ae17474f)

13 years agor2239: Fixup formatting errors in TDB_LOG calls. Add printf attribute support to
Jim McDonough [Tue, 7 Sep 2004 13:51:03 +0000 (13:51 +0000)]
r2239: Fixup formatting errors in TDB_LOG calls.  Add printf attribute support to
tdb log functions.
(This used to be commit 67c737118faaeae9bd723516ea60657046e135a8)

13 years agor2233: fixed 3 places where == is mistakenly used instead of = in bourne
Andrew Tridgell [Mon, 6 Sep 2004 10:22:03 +0000 (10:22 +0000)]
r2233: fixed 3 places where == is mistakenly used instead of = in bourne
shell script statements in configure.
(This used to be commit 8470968cc6884605cdf2587a2c7f9ecf7b46ded6)

13 years agor2231: Fix iconv.c to use the Samba-supplied uint8 type not the uint8_t type, which...
Paul Green [Mon, 6 Sep 2004 00:24:28 +0000 (00:24 +0000)]
r2231: Fix iconv.c to use the Samba-supplied uint8 type not the uint8_t type, which does not exist on all platforms.
(This used to be commit acc793ead7e61f1eb87864b676d26f5791367228)

13 years agor2224: Make nmbd more robust against bad netbios packets.
Jeremy Allison [Sat, 4 Sep 2004 01:57:16 +0000 (01:57 +0000)]
r2224: Make nmbd more robust against bad netbios packets.
(This used to be commit dd9b17abd6b32c090840c1a0b797fd774711cb3a)

13 years agor2219: Remember to count bad_components only on pathname boundaries.
Jeremy Allison [Fri, 3 Sep 2004 20:30:31 +0000 (20:30 +0000)]
r2219: Remember to count bad_components only on pathname boundaries.
(This used to be commit ee8ac9e51a0aefd41df56de4d6deac522bdee4a3)

13 years agor2215: I think I'm really close now. The key is to count the number of
Jeremy Allison [Fri, 3 Sep 2004 20:05:29 +0000 (20:05 +0000)]
r2215: I think I'm really close now. The key is to count the number of
bad components once you've hit one, and keep track of how many
there are (going up a level removes one - maybe it needs to be ./
in order to be removed, need to check). And remember to change the error
code return depending on whether you're called from ff or chkpath.
(This used to be commit beda1aee795971fa600af65caa749694bb0dfea5)

13 years agor2213: Optimisation. Passes masktest against W2K3.
Jeremy Allison [Fri, 3 Sep 2004 17:44:27 +0000 (17:44 +0000)]
r2213: Optimisation. Passes masktest against W2K3.
(This used to be commit 5dc3324c4f1ae10c96b6d385531369e0eeee4c40)

13 years agor2210: Fix misleading comment found by Heinrich Mislik <>
Simo Sorce [Fri, 3 Sep 2004 13:42:02 +0000 (13:42 +0000)]
r2210: Fix misleading comment found by Heinrich Mislik <>
(This used to be commit 3a88ee4c444c7b953c9f88b19998a5d84fc5e17c)

13 years agor2198: Correct fix for #1360. Need to use -Wl when passing flags to the linker.
Tim Potter [Thu, 2 Sep 2004 22:51:12 +0000 (22:51 +0000)]
r2198: Correct fix for #1360.  Need to use -Wl when passing flags to the linker.
(This used to be commit 274a1eda7863368a0d46aed6600c29ec5e30f406)

13 years agor2196: This error code change is incorrect. Still working on it...
Jeremy Allison [Thu, 2 Sep 2004 22:48:35 +0000 (22:48 +0000)]
r2196: This error code change is incorrect. Still working on it...
(This used to be commit 3dbd822f5e4a241ac12fa6c75de93013f80f00f4)

13 years agor2194: Here is the efforts of much pain reproducing W2K3 pathname
Jeremy Allison [Thu, 2 Sep 2004 22:35:36 +0000 (22:35 +0000)]
r2194: Here is the efforts of much pain reproducing W2K3 pathname
parsing. :-(. One more check for CreateFile() needed.
(This used to be commit 294e2021b34c806900ec65ecbf17d9038ac6229a)

13 years agor2191: ensure that we assign our pid to print jobs (and not our parent's pid); ensure...
Gerald Carter [Thu, 2 Sep 2004 21:52:35 +0000 (21:52 +0000)]
r2191: ensure that we assign our pid to print jobs (and not our parent's pid); ensures that spooling jobs from dead smbds are removed from the tdb
(This used to be commit 9e42d016e1fee9ac999dadc383eb5db45ed79b00)

13 years agor2190: disable 'winbind enable local accounts' by default (had to be done doctor)
Gerald Carter [Thu, 2 Sep 2004 20:51:12 +0000 (20:51 +0000)]
r2190: disable 'winbind enable local accounts' by default (had to be done doctor)
(This used to be commit 1f71295801c7af554fba293069e52666083d7bc5)

13 years agor2189: adding some comments to the schema file
Gerald Carter [Thu, 2 Sep 2004 15:26:36 +0000 (15:26 +0000)]
r2189: adding some comments to the schema file
(This used to be commit 1438c2960f1213ddf98e7e874e1d060f2d57089c)

13 years agor2188: adding some initial checks for DragonFly (same as FreeBSD 4.1)
Gerald Carter [Thu, 2 Sep 2004 14:18:17 +0000 (14:18 +0000)]
r2188: adding some initial checks for DragonFly (same as FreeBSD 4.1)
(This used to be commit dd84bedaca9c8e802fc4cae5b73128c94f38c086)

13 years agor2177: use the correct counter when copying group rids from the user_info3 struct...
Gerald Carter [Wed, 1 Sep 2004 21:28:42 +0000 (21:28 +0000)]
r2177: use the correct counter when copying group rids from the user_info3 struct; patch from Dimitri van der Spek <>
(This used to be commit aa89806deb9d4c9cbd23ccdd41bb98346e395078)

13 years agor2175: Fix for #1546 from Preserve errno in MB strupper_m/strlower_m.
Jeremy Allison [Wed, 1 Sep 2004 17:39:27 +0000 (17:39 +0000)]
r2175: Fix for #1546 from Preserve errno in MB strupper_m/strlower_m.
(This used to be commit 615aa6e914e6bc3691156a3b80244fc98d8ecc56)

13 years agor2163: converted samba3 to use the new utf-16 aware iconv code. Also changed
Andrew Tridgell [Wed, 1 Sep 2004 05:17:40 +0000 (05:17 +0000)]
r2163: converted samba3 to use the new utf-16 aware iconv code. Also changed
iconv to recognise UCS-2LE and UTF-16LE as synonyms, which means this
change should be more robust when applied in trees that treat UCS-2LE
or UTF-16LE as correct.
(This used to be commit 92c9fcaec4299ddc16f9d6568a695b1fe161be33)

13 years agor2160: fixed the uuid pack/unpack routines (they could go past the end of the UUID...
Andrew Tridgell [Wed, 1 Sep 2004 04:46:15 +0000 (04:46 +0000)]
r2160: fixed the uuid pack/unpack routines (they could go past the end of the UUID structure)
(This used to be commit 43cf57e86bfae3ab68e97c2238338581411eb2ff)

13 years agor2157: This parameter in loadparm appears compleatly unused.
Andrew Bartlett [Wed, 1 Sep 2004 02:13:48 +0000 (02:13 +0000)]
r2157: This parameter in loadparm appears compleatly unused.

Andrew Bartlett
(This used to be commit 3dabe879f74d2ea3b379a00a3778ee76051a359a)

13 years agor2155: Reformat, plus steal from Samba4 :-).
Jeremy Allison [Wed, 1 Sep 2004 01:33:55 +0000 (01:33 +0000)]
r2155: Reformat, plus steal from Samba4 :-).
the lp_use_mmap() in map_file() is inappropriate for 2 reasons, so I have removed it.

 - lp_use_mmap() is really meant to cope with systems that have broken
   mmap coherence, but map_file() doesn't need coherence, as its maps
   read only

 - map_file() is used to map the charset files before loadparm has
   loaded, so lp_use_mmap() is always returning false for the major
   use of map_file()

(This used to be commit 3716dbc0cb9a8ca4027217b24dbf62a62f44e9f6)

13 years agor2152: Fix for bug #1674, move the symlinks checks into reduce_name().
Jeremy Allison [Tue, 31 Aug 2004 22:52:05 +0000 (22:52 +0000)]
r2152: Fix for bug #1674, move the symlinks checks into reduce_name().
(This used to be commit 341771857fecf9ef72a436c42e0571d486fa0dde)

13 years agor2150: Fix parsing of names ending in dot and a few other error returns
Jeremy Allison [Tue, 31 Aug 2004 21:29:50 +0000 (21:29 +0000)]
r2150: Fix parsing of names ending in dot and a few other error returns
(commit to Samba4 smbtorture will exercise these fixes).
(This used to be commit ff20dacc68c78b8d30993712366af30a64e960aa)

13 years agor2147: Fix utility name in error message (pre-emptivly merged to trunk ;-)
Andrew Bartlett [Tue, 31 Aug 2004 20:36:55 +0000 (20:36 +0000)]
r2147: Fix utility name in error message (pre-emptivly merged to trunk ;-)

Andrew Bartlett
(This used to be commit 657bb14789bcec65668d072fec0f954d1e5322ef)

13 years agor2137: This is a patch I've been running at Hawker for a while.
Andrew Bartlett [Tue, 31 Aug 2004 19:56:16 +0000 (19:56 +0000)]
r2137: This is a patch I've been running at Hawker for a while.

The purpose of this patch is to avoid changing the machine account
password, when it has 'already been changed'.  This occours in
situations where the secure channel between the workstation and the DC
breaks down, such as occoured in the MS04-11 security patch.  This
avoids LDAP replication load issues, due to the client changing the
password repeatedly.

We also now set the LM password to NULL explicitly, rather than the NT
password value, as this is what we get out of a vampire, or when a
long password is set (as XP seems to do these days).

Andrew Bartlett
(This used to be commit 1ad1317a815898b52b1803211ab7b502e331e782)

13 years agor2135: BUG 1464: make sure that printing commands are initialized even if the 'printi...
Gerald Carter [Tue, 31 Aug 2004 18:34:52 +0000 (18:34 +0000)]
r2135: BUG 1464: make sure that printing commands are initialized even if the 'printing' parameter is not explicitly set
(This used to be commit 8ae57a8e8d7334bc0feb2c8afb673bd5c53bffca)

13 years agor2133: Several fixes:
Gerald Carter [Tue, 31 Aug 2004 15:11:41 +0000 (15:11 +0000)]
r2133: Several fixes:

* BUG 1627: fix for NIS compiles on HPUX 11.00, AIX 4.3 and 5.1
  patch from Olaf Flebbe <>.
  Will need to watch this one in the build farm.

* Fix bug found by where the PRINT_ATTRIBUTE_PUBLISHED
  was getting reset by attempts to sanitize the defined attributes

* Resolve name conflict on DEC OSF-5.1 (inspired by patch from
  Adharsh Praveen <>)

* Work around parsing error in the print change notify code
  (not that the alignment bug is still there but reording the
   entries in the array works around it).

* remove duplicate declaration of getprintprocdir from rpcclient.
(This used to be commit 7474c6a446037f3ca2546cb6984d800bfc524029)

13 years agor2131: Fixup format string. The magic value format specifier was missing, so
Jim McDonough [Tue, 31 Aug 2004 12:06:37 +0000 (12:06 +0000)]
r2131: Fixup format string.  The magic value format specifier was missing, so
the logged offset was really the magic value, and the true offset was
never displayed.
(This used to be commit 30da4e777191c557226d5615cee5a9e28b198a8b)

13 years agor2116: Ensure statcache has large enough tdb memory hash size (1031).
Jeremy Allison [Mon, 30 Aug 2004 22:25:36 +0000 (22:25 +0000)]
r2116: Ensure statcache has large enough tdb memory hash size (1031).
(This used to be commit dad4d65787df7bd28351cb8f8724d3ae5387ca12)

13 years agor2114: Shameless theft of iconv commit from Samba4 to keep the two libs more in sync...
Jeremy Allison [Mon, 30 Aug 2004 21:35:43 +0000 (21:35 +0000)]
r2114: Shameless theft of iconv commit from Samba4 to keep the two libs more in sync :-).
try to cope with a wider range of UTF-16 characters when we are using
an external libiconv library.
(This used to be commit 5d04cd6804f6fc3b556e7c3b53fa0d7af39797c1)

13 years agor2112: Simplify the mangle hash code to use an in-memory tdb.
Jeremy Allison [Mon, 30 Aug 2004 20:19:40 +0000 (20:19 +0000)]
r2112: Simplify the mangle hash code to use an in-memory tdb.
Should be ready for the new directory code now...
(This used to be commit c2eff8ef1b65570d2e590f62f026cc18f9142652)

13 years agor2111: Fix memleak with valid names.
Jeremy Allison [Mon, 30 Aug 2004 18:27:07 +0000 (18:27 +0000)]
r2111: Fix memleak with valid names.
(This used to be commit 3f0707132afc66109701766528cb0bd1e1c7cd8c)

13 years agor2093: Fix for Bug 1416. This must have been a cut&paste error from add_gid....
Volker Lendecke [Sat, 28 Aug 2004 10:12:23 +0000 (10:12 +0000)]
r2093: Fix for Bug 1416. This must have been a cut&paste error from add_gid....

Thanks to Jonas Olsson for the bug report & fix.

(This used to be commit de0eaf7be7d0c3aaf4e17b63653ca68b4332c982)

13 years agor2091: only use sAMAccountName and not userPrincipalName since the breaks winbindd...
Gerald Carter [Fri, 27 Aug 2004 16:15:23 +0000 (16:15 +0000)]
r2091: only use sAMAccountName and not userPrincipalName since the breaks winbindd (lookup_name() only works with the sAMAccountName) -- *please* test this change.  My tests all pass but there is probably something I missed
(This used to be commit 2bf08aaa37f41681b3154514792bf29a3abfdbfd)

13 years agor2090: fix formatting that was bugging me
Gerald Carter [Fri, 27 Aug 2004 16:13:50 +0000 (16:13 +0000)]
r2090: fix formatting that was bugging me
(This used to be commit 5d3ba1fac0ccb7024b72fd3a672e14fab062ef0b)

13 years agor2086: fix bug with winbindd_getpwnam() caused by Microsoft DC's not filling in the...
Gerald Carter [Fri, 27 Aug 2004 13:39:09 +0000 (13:39 +0000)]
r2086: fix bug with winbindd_getpwnam() caused by Microsoft DC's not filling in the username in the user_info3
(This used to be commit 4703a71fa88dff8bdc932f6c9af3a9d25a88938f)

13 years agor2083: Fix memleak on return code path.
Jeremy Allison [Fri, 27 Aug 2004 01:16:25 +0000 (01:16 +0000)]
r2083: Fix memleak on return code path.
(This used to be commit b0af241fd1fc58c1cbaadcbf6832b608923382ff)

13 years agor2082: lp_path should be lp_pathname.
Jeremy Allison [Thu, 26 Aug 2004 21:39:10 +0000 (21:39 +0000)]
r2082: lp_path should be lp_pathname.
Paranoia fix on mangle prefix.
(This used to be commit cc91bbe20d9cb26e52ad417f279e2d60c85af2dc)

13 years agor2080: Remove last traces of static migration to localhost. Needed to allow a
Günther Deschner [Thu, 26 Aug 2004 21:37:20 +0000 (21:37 +0000)]
r2080: Remove last traces of static migration to localhost. Needed to allow a
local netbios-alias bound to non-loopback interface as a migration target.

It's now possible to migrate printers|shares|files from Server A to
Server B while running the net-command on client C.

(This used to be commit 0cfd2866dfe5e959ede169a77c39480790300de3)

13 years agor2079: Clear the publish-bit from the attributes-mask when migrating
Günther Deschner [Thu, 26 Aug 2004 21:32:49 +0000 (21:32 +0000)]
r2079: Clear the publish-bit from the attributes-mask when migrating
printer-settings. publishing-info is not handled yet.

(This used to be commit 1d76adb93c98857ed3460db241847e423c021a99)

13 years agor2077: fix logic bug in the check for creating a user's home directory in register_vu...
Gerald Carter [Thu, 26 Aug 2004 20:47:58 +0000 (20:47 +0000)]
r2077: fix logic bug in the check for creating a user's home directory in register_vuid(); add a few extra debug lines
(This used to be commit 02571e7f5040a577840c969ff9c46a1e533edc21)

13 years agor2076: Removed old dir caching code - not being used now we have the
Jeremy Allison [Wed, 25 Aug 2004 23:20:47 +0000 (23:20 +0000)]
r2076: Removed old dir caching code - not being used now we have the
statcache anyway. New dir caching will be done on nanosecond
(This used to be commit ba473a580245430009245a4c8b8dcaf9fc4b6406)

13 years agor2073: Adding getprinter level 7 to rpcclient.
Günther Deschner [Wed, 25 Aug 2004 21:26:37 +0000 (21:26 +0000)]
r2073: Adding getprinter level 7 to rpcclient.

Is there any other rpc-call to get the guid of a published printer?

(This used to be commit 944ad569c7a88e1d2f14311eed10f80ea9861963)

13 years agor2070: Let's try to overload srnlen and strndup for AIX where they are natly broken.
Simo Sorce [Wed, 25 Aug 2004 14:24:16 +0000 (14:24 +0000)]
r2070: Let's try to overload srnlen and strndup for AIX where they are natly broken.
(This used to be commit 98feb3318f54bb48ce56fc8f4721fec4967b9dd9)

13 years agor2068: Use SMB_ASSERT to track down empty printername (thanks jerry).
Günther Deschner [Wed, 25 Aug 2004 13:03:04 +0000 (13:03 +0000)]
r2068: Use SMB_ASSERT to track down empty printername (thanks jerry).

(This used to be commit 9d8fdd5f323951d3d9b581e9edbf89b05c897af7)

13 years agor2067: Prevent nameless $LIBDIR/printing/.tdb from beeing created.
Günther Deschner [Wed, 25 Aug 2004 12:31:00 +0000 (12:31 +0000)]
r2067: Prevent nameless $LIBDIR/printing/.tdb from beeing created.

I've seen these on several sites now without knowing how they could get

(This used to be commit 531a23d1d22a9951cce5f657df46bd27840eac3d)

13 years agor2057: Although rarely used, prevent "net lookup kdc" from segfaulting when
Günther Deschner [Wed, 25 Aug 2004 07:52:23 +0000 (07:52 +0000)]
r2057: Although rarely used, prevent "net lookup kdc" from segfaulting when
using our own implementation of krb5_lookup_kdc with heimdal. Also,
heimdals krb5_krbhst_next() obviously does not retrieve the struct
addrinfo in the krb5_krbhst_info-struct, using
krb5_krbhst_get_addrinfo() instead.

(This used to be commit cca660e109cc94b49ac6bf1f2802235d1d4d4383)

13 years agor2032: If you're selecting a hash algorithm for tdb, you need to do it at open time,
Jeremy Allison [Wed, 25 Aug 2004 01:04:02 +0000 (01:04 +0000)]
r2032: If you're selecting a hash algorithm for tdb, you need to do it at open time,
it doesn't make sense anywhere else.
(This used to be commit d7ea1ea8fb3420ca1ad8d95acdc43313898200ff)