ira/wip.git
11 years agos4-smbtorture: add test_SetPrinter to RPC-SPOOLSS.
Günther Deschner [Wed, 6 Jan 2010 18:33:39 +0000 (19:33 +0100)]
s4-smbtorture: add test_SetPrinter to RPC-SPOOLSS.

Guenther

11 years agos4-smbtorture: refactor test_GetPrinter in RPC-SPOOLSS.
Günther Deschner [Wed, 6 Jan 2010 16:51:34 +0000 (17:51 +0100)]
s4-smbtorture: refactor test_GetPrinter in RPC-SPOOLSS.

Guenther

11 years agoѕ3:configure: use gettimeofday check from lib/util/
Björn Jacke [Wed, 6 Jan 2010 14:32:15 +0000 (15:32 +0100)]
ѕ3:configure: use gettimeofday check from lib/util/

11 years agovfs_commit: print warning when no fsync support is there
Björn Jacke [Sun, 13 Dec 2009 20:56:28 +0000 (21:56 +0100)]
vfs_commit: print warning when no fsync support is there

this one was part of an old patch from jpeach.

11 years agotdb: fix standalone 'make installdocs'
Stefan Metzmacher [Wed, 6 Jan 2010 13:39:43 +0000 (14:39 +0100)]
tdb: fix standalone 'make installdocs'

metze

11 years agotdb: create symbol links to shared libraries see https://bugzilla.samba.org/show_bug...
Brian Lu [Thu, 17 Dec 2009 06:39:09 +0000 (14:39 +0800)]
tdb: create symbol links to shared libraries see https://bugzilla.samba.org/show_bug.cgi?id=6991 for details

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agotalloc: create symbol links to shared libraries see https://bugzilla.samba.org/show_b...
Brian Lu [Thu, 17 Dec 2009 06:48:59 +0000 (14:48 +0800)]
talloc: create symbol links to shared libraries see https://bugzilla.samba.org/show_bug.cgi?id=6991 for details

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agotevent: create symbol links to shared libraries see https://bugzilla.samba.org/show_b...
Brian Lu [Thu, 17 Dec 2009 06:55:57 +0000 (14:55 +0800)]
tevent: create symbol links to shared libraries see https://bugzilla.samba.org/show_bug.cgi?id=6991 for details

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos4: Fix result check for getaddrinfo()
Kamen Mazdrashki [Wed, 6 Jan 2010 11:40:33 +0000 (13:40 +0200)]
s4: Fix result check for getaddrinfo()

I think this completes commit 50feca550eed7828198b7c0fc5f0e5ddc863313d.
Now result should be handled correctly both for systems that
support EAI_NODATA but returns EAI_NONAME (as my Ubuntu 9.x)
and systems that doesn't support EAI_NODATA at all.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agoFix bug #7020 - smbd using 2G memory.
Jeremy Allison [Tue, 5 Jan 2010 22:34:00 +0000 (14:34 -0800)]
Fix bug #7020 - smbd using 2G memory.

When deferring an async pipe writeX and readX transfer
the outstanding request struct onto the conn struct. This
needs freeing after the packet is finally processed.

Jeremy.

11 years agos4:SAMLDB LDB module - Fix trailing whitespaces
Matthias Dieter Wallnöfer [Sun, 3 Jan 2010 20:47:36 +0000 (21:47 +0100)]
s4:SAMLDB LDB module - Fix trailing whitespaces

11 years agos4:SAMLDB LDB module - Rework to allow checks for wrong "defaultObjectCategory" attri...
Matthias Dieter Wallnöfer [Sun, 3 Jan 2010 19:36:09 +0000 (20:36 +0100)]
s4:SAMLDB LDB module - Rework to allow checks for wrong "defaultObjectCategory" attributes

This allows a stricter check for "defaultObjectCategory" attributes which is
performed when the "relax" control isn't specified.
Additional note: As the added comment points out this isn't complete.
And I personally think that moving this at some point to the "objectclass"
module is a better idea to make this fully work (since there we have direct
access to the schema). If someone has a good idea how to do this please inform
me.

Anyway, the SAMLDB module does require some restructure since at the moment it's
very overloaded and therefore a bit a mess. In the meantime I started to work
on a new approach to realise it in a better way.

11 years agos4:schema_load.c - Typo
Matthias Dieter Wallnöfer [Sun, 3 Jan 2010 18:54:53 +0000 (19:54 +0100)]
s4:schema_load.c - Typo

11 years agos4:ldap_schema.py - add an additional check for validity of "defaultObjectCategory"
Matthias Dieter Wallnöfer [Sun, 3 Jan 2010 18:53:01 +0000 (19:53 +0100)]
s4:ldap_schema.py - add an additional check for validity of "defaultObjectCategory"

11 years agos4:ldap_schema.py - Move generated attributes check
Matthias Dieter Wallnöfer [Sun, 3 Jan 2010 18:43:52 +0000 (19:43 +0100)]
s4:ldap_schema.py - Move generated attributes check

Make more clear that they're created before the "schemaUpdateNow".

11 years agos3: List trusted domains from wcache when domain is offline.
Bo Yang [Wed, 6 Jan 2010 11:13:59 +0000 (19:13 +0800)]
s3: List trusted domains from wcache when domain is offline.

Signed-off-by: Bo Yang <boyang@samba.org>
11 years agos3: Make winbindd_cache.c aware of domain offline to avoid unnecessary backend query.
Bo Yang [Wed, 6 Jan 2010 07:05:20 +0000 (15:05 +0800)]
s3: Make winbindd_cache.c aware of domain offline to avoid unnecessary backend query.

Signed-off-by: Bo Yang <boyang@samba.org>
11 years agos3: Fix infinite loop in NCACN_IP_TCP asa there is no timeout. Assume lsa_pipe_tcp...
Bo Yang [Wed, 6 Jan 2010 04:13:35 +0000 (12:13 +0800)]
s3: Fix infinite loop in NCACN_IP_TCP asa there is no timeout. Assume lsa_pipe_tcp is ok but network is down, then send request is ok, but select() on writeable fds loops forever since there is no response.

Signed-off-by: Bo Yang <boyang@samba.org>
11 years agos3 net: Fix up a share type translation and translate some more strings
Kai Blin [Tue, 5 Jan 2010 08:54:04 +0000 (09:54 +0100)]
s3 net: Fix up a share type translation and translate some more strings

11 years agos3 net: Add a few missing gettext calls.
Kai Blin [Tue, 5 Jan 2010 08:43:34 +0000 (09:43 +0100)]
s3 net: Add a few missing gettext calls.

Many many thanks to Adi Roiban from #ubuntu-translators for helping me find
and fix my problems with the translations.

11 years agoFix the merged build. Probably not strictly correct but allows us to "make test".
Jeremy Allison [Mon, 4 Jan 2010 21:27:48 +0000 (13:27 -0800)]
Fix the merged build. Probably not strictly correct but allows us to "make test".
Jeremy.

11 years agos4:dsdb/repl: convert dreplsrv_out_drsuapi_send/recv to tevent_req
Stefan Metzmacher [Wed, 23 Dec 2009 16:44:40 +0000 (17:44 +0100)]
s4:dsdb/repl: convert dreplsrv_out_drsuapi_send/recv to tevent_req

metze

11 years agoblackbox/test_export_keytab.sh: correctly remove temporary files
Stefan Metzmacher [Mon, 4 Jan 2010 08:27:23 +0000 (09:27 +0100)]
blackbox/test_export_keytab.sh: correctly remove temporary files

metze

11 years agoblackbox/test_export_keytab.sh: use VALGRIND for samba4kinit
Stefan Metzmacher [Mon, 4 Jan 2010 08:26:25 +0000 (09:26 +0100)]
blackbox/test_export_keytab.sh: use VALGRIND for samba4kinit

metze

11 years agos4: Happy New Year 2010
Stefan Metzmacher [Mon, 4 Jan 2010 07:42:49 +0000 (08:42 +0100)]
s4: Happy New Year 2010

metze

11 years agos3: Happy New Year 2010
Stefan Metzmacher [Mon, 4 Jan 2010 07:42:03 +0000 (08:42 +0100)]
s3: Happy New Year 2010

metze

11 years agos3: Trim down smbcontrol a bit
Volker Lendecke [Sun, 3 Jan 2010 12:55:54 +0000 (13:55 +0100)]
s3: Trim down smbcontrol a bit

11 years agos3: Fix a shadowed variable warning
Volker Lendecke [Sun, 3 Jan 2010 11:58:31 +0000 (12:58 +0100)]
s3: Fix a shadowed variable warning

11 years agos3: Fix an uninitialized variable warning
Volker Lendecke [Sun, 3 Jan 2010 11:58:01 +0000 (12:58 +0100)]
s3: Fix an uninitialized variable warning

11 years agos3: Convert cli_ulogoff to the async API
Volker Lendecke [Sun, 3 Jan 2010 12:03:42 +0000 (13:03 +0100)]
s3: Convert cli_ulogoff to the async API

11 years agos3: Convert cli_tdis to the async API
Volker Lendecke [Sun, 3 Jan 2010 17:46:57 +0000 (18:46 +0100)]
s3: Convert cli_tdis to the async API

11 years agos3: Slightly simplify winbindd_dual_ccache_ntlm_auth
Volker Lendecke [Sat, 19 Dec 2009 23:27:34 +0000 (00:27 +0100)]
s3: Slightly simplify winbindd_dual_ccache_ntlm_auth

data_blob_const can't fail

11 years agos3: Fix some nonempty blank lines
Volker Lendecke [Sat, 2 Jan 2010 17:25:13 +0000 (18:25 +0100)]
s3: Fix some nonempty blank lines

11 years agolibwbclient: Remove a pointless check
Volker Lendecke [Sat, 2 Jan 2010 19:09:31 +0000 (20:09 +0100)]
libwbclient: Remove a pointless check

We have dereferenced "blobs" before

11 years agos3: Remove some unused code
Volker Lendecke [Sat, 2 Jan 2010 17:16:30 +0000 (18:16 +0100)]
s3: Remove some unused code

11 years agos3: Convert cli_sesssetup_ntlmssp to the async API
Volker Lendecke [Tue, 22 Dec 2009 22:31:20 +0000 (23:31 +0100)]
s3: Convert cli_sesssetup_ntlmssp to the async API

11 years agos3: NT_STATUS_MORE_PROCESSING_REQUIRED is a valid sesssetup return value
Volker Lendecke [Sat, 2 Jan 2010 17:14:59 +0000 (18:14 +0100)]
s3: NT_STATUS_MORE_PROCESSING_REQUIRED is a valid sesssetup return value

11 years agos3: Convert cli_session_setup_kerberos to the async API
Volker Lendecke [Sun, 20 Dec 2009 13:47:09 +0000 (14:47 +0100)]
s3: Convert cli_session_setup_kerberos to the async API

This is still cheated, acquiring the ticket is not async yet, but the SMB
part is

11 years agos3: Fix a typo
Volker Lendecke [Wed, 30 Dec 2009 19:15:33 +0000 (20:15 +0100)]
s3: Fix a typo

11 years agos3: simplify find_root_domain, find_our_domain() never fails
Volker Lendecke [Wed, 30 Dec 2009 19:09:52 +0000 (20:09 +0100)]
s3: simplify find_root_domain, find_our_domain() never fails

11 years agos3: Use global_sid_Builtin in find_builtin_domain
Volker Lendecke [Wed, 30 Dec 2009 19:11:36 +0000 (20:11 +0100)]
s3: Use global_sid_Builtin in find_builtin_domain

11 years agos3: Avoid adding a domain twice
Volker Lendecke [Mon, 28 Dec 2009 17:11:34 +0000 (18:11 +0100)]
s3: Avoid adding a domain twice

If we found a match with sid==NULL, we ended up adding the domain twice

11 years agos3: Make free_domain_list() static
Volker Lendecke [Mon, 28 Dec 2009 17:03:14 +0000 (18:03 +0100)]
s3: Make free_domain_list() static

11 years agos3: Adapt sid_dup_talloc to README.Coding
Volker Lendecke [Wed, 30 Dec 2009 10:30:13 +0000 (11:30 +0100)]
s3: Adapt sid_dup_talloc to README.Coding

11 years agos3: Introduce domain_is_forest_root() helper function
Volker Lendecke [Wed, 30 Dec 2009 09:25:41 +0000 (10:25 +0100)]
s3: Introduce domain_is_forest_root() helper function

Hopefully this makes the flag tests a bit more understandable

11 years agos4-dsdb: force REVISION_ADS for new and updated ACLs in dsdb
Andrew Tridgell [Sat, 2 Jan 2010 05:53:20 +0000 (16:53 +1100)]
s4-dsdb: force REVISION_ADS for new and updated ACLs in dsdb

w2k8-r2 gives a "schema mismatch" error if the revision is not set to
REVISION_ADS and you replicate the ntsecuritydescriptor using DRS.

Nadya, please check this!

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agos4-drs: don't give an error on repsTo delete if add is also specified
Andrew Tridgell [Sat, 2 Jan 2010 05:51:30 +0000 (16:51 +1100)]
s4-drs: don't give an error on repsTo delete if add is also specified

w2k8-r2 in dcpromo asks for a delete+add during its initial join.

11 years agos4-sddl: DRS replication needs REVISION_ADS for SDs
Andrew Tridgell [Sat, 2 Jan 2010 01:30:48 +0000 (12:30 +1100)]
s4-sddl: DRS replication needs REVISION_ADS for SDs

DRS replication with w2k8-r2 fails with a schema mismatch error if we
set the revision to NT4

11 years agoldb: Fix the standalone ldb build.
Jelmer Vernooij [Sat, 2 Jan 2010 01:40:30 +0000 (02:40 +0100)]
ldb: Fix the standalone ldb build.

11 years agolibreplace: some systems don't have memmem()
Andrew Tridgell [Fri, 1 Jan 2010 23:01:11 +0000 (10:01 +1100)]
libreplace: some systems don't have memmem()

added rep_memmem() and a testsuite

11 years agos4-dsdb: switched to using RMD_FLAGS instead of DELETED in extended DNs
Andrew Tridgell [Fri, 1 Jan 2010 21:14:52 +0000 (08:14 +1100)]
s4-dsdb: switched to using RMD_FLAGS instead of DELETED in extended DNs

This allows for more flags in the future

11 years agos4-kcc: added a preiodic task to remove deleted objects
Andrew Tridgell [Wed, 30 Dec 2009 10:40:17 +0000 (21:40 +1100)]
s4-kcc: added a preiodic task to remove deleted objects

we check for deleted objects in each partition every 10 minutes, using
onelevel searches

11 years agos4-dsdb: fixed several memory leaks
Andrew Tridgell [Wed, 30 Dec 2009 10:39:24 +0000 (21:39 +1100)]
s4-dsdb: fixed several memory leaks

need to be careful with those temporary contexts

11 years agos4-dsdb: fixed samdb_create_foreign_security_principal() to use the wellknown GUID
Andrew Tridgell [Wed, 30 Dec 2009 10:38:21 +0000 (21:38 +1100)]
s4-dsdb: fixed samdb_create_foreign_security_principal() to use the wellknown GUID

This also fixes a memory leak

11 years agos4-ldb: fixed valgrind error: ares can be freed by callback
Andrew Tridgell [Wed, 30 Dec 2009 10:36:31 +0000 (21:36 +1100)]
s4-ldb: fixed valgrind error: ares can be freed by callback

11 years agos4-dsdb: make sure 'whenChanged' is set on modify
Andrew Tridgell [Wed, 30 Dec 2009 09:05:02 +0000 (20:05 +1100)]
s4-dsdb: make sure 'whenChanged' is set on modify

We also should preserve (and then replace) whenChanged on delete

11 years agos4-dsdb: added dsdb_tombstone_lifetime()
Andrew Tridgell [Wed, 30 Dec 2009 09:04:17 +0000 (20:04 +1100)]
s4-dsdb: added dsdb_tombstone_lifetime()

11 years agos4-dsdb: allow system to remove deleted objects
Andrew Tridgell [Wed, 30 Dec 2009 07:47:51 +0000 (18:47 +1100)]
s4-dsdb: allow system to remove deleted objects

This will be used by a periodic job to remove tombstoned objects

11 years agos4-ldaptest: need to use MessageElement for modify messages
Andrew Tridgell [Tue, 29 Dec 2009 23:54:03 +0000 (10:54 +1100)]
s4-ldaptest: need to use MessageElement for modify messages

Without MessageElement() the flags are not set, which is invalid

11 years agos4-ldb: show an error string, as well as error message
Andrew Tridgell [Tue, 29 Dec 2009 23:53:36 +0000 (10:53 +1100)]
s4-ldb: show an error string, as well as error message

This makes it easier to track down error mismatches from the test
suite

11 years agos4-drs: make sure the DNs we put in the db have a extended GUID
Andrew Tridgell [Tue, 29 Dec 2009 23:52:55 +0000 (10:52 +1100)]
s4-drs: make sure the DNs we put in the db have a extended GUID

11 years agos4-dsdb: added dsdb_set_extended_dn_guid()
Andrew Tridgell [Tue, 29 Dec 2009 23:52:14 +0000 (10:52 +1100)]
s4-dsdb: added dsdb_set_extended_dn_guid()

11 years agos4-ldbtest: fixed message element in modify
Andrew Tridgell [Tue, 29 Dec 2009 00:41:19 +0000 (11:41 +1100)]
s4-ldbtest: fixed message element in modify

a flags value of zero is not valid

11 years agos4-ldb: allow modules to override error return values
Andrew Tridgell [Tue, 29 Dec 2009 00:40:30 +0000 (11:40 +1100)]
s4-ldb: allow modules to override error return values

The samldb module overrides the error code for some returns when
handling primaryGroupID. We need to take the error from the async
callback to allow this to work reliably

11 years agos4-ldbmodify: show the error code as well as error string
Andrew Tridgell [Tue, 29 Dec 2009 00:39:29 +0000 (11:39 +1100)]
s4-ldbmodify: show the error code as well as error string

11 years agos4-ldb: declate ldb_val_to_time()
Andrew Tridgell [Tue, 29 Dec 2009 00:39:05 +0000 (11:39 +1100)]
s4-ldb: declate ldb_val_to_time()

11 years agos4-ldb: use safe length limited conversions for int64 and time
Andrew Tridgell [Tue, 29 Dec 2009 00:38:49 +0000 (11:38 +1100)]
s4-ldb: use safe length limited conversions for int64 and time

11 years agos4-dsdb: use safe length limiting in string->integer conversion
Andrew Tridgell [Tue, 29 Dec 2009 00:38:17 +0000 (11:38 +1100)]
s4-dsdb: use safe length limiting in string->integer conversion

The ldap.py test suite could trigger a read past the end of the struct
ldb_val buffer

11 years agos4-dsdb: use ldb_val_to_time() instead of ldb_string_to_time()
Andrew Tridgell [Tue, 29 Dec 2009 00:37:17 +0000 (11:37 +1100)]
s4-dsdb: use ldb_val_to_time() instead of ldb_string_to_time()

11 years agos4-ldb: added ldb_val_to_time()
Andrew Tridgell [Tue, 29 Dec 2009 00:36:37 +0000 (11:36 +1100)]
s4-ldb: added ldb_val_to_time()

This is intended as a replacement for ldb_string_to_time() for ldb_val
inputs. This ensures it is length limited and includes additional
validity checks

11 years agos4-drs: sort linked attributes
Andrew Tridgell [Mon, 28 Dec 2009 06:22:40 +0000 (17:22 +1100)]
s4-drs: sort linked attributes

See MS-DRSR section 4.1.10.5.17 for a description of the sorting
comparison function

11 years agos4-drs: re-resolve the DN in linked attribute processing
Andrew Tridgell [Mon, 28 Dec 2009 06:22:12 +0000 (17:22 +1100)]
s4-drs: re-resolve the DN in linked attribute processing

w2k8-r2 sometimes sends the DN with an old target

11 years agos4-drs: use dsdb_module_rename()
Andrew Tridgell [Mon, 28 Dec 2009 06:20:13 +0000 (17:20 +1100)]
s4-drs: use dsdb_module_rename()

Use the new dsdb_module_rename() for DRS rename handling, instead of
ldb_rename(). This stops us going to the top of the module stack on a
rename.

11 years agos4-drs: use dsdb linked attribute parse functions
Andrew Tridgell [Mon, 28 Dec 2009 06:19:29 +0000 (17:19 +1100)]
s4-drs: use dsdb linked attribute parse functions

This makes the code considerably more readable

11 years agos4-dsdb: added parse functions for DRS linked attribute blobs
Andrew Tridgell [Mon, 28 Dec 2009 06:18:14 +0000 (17:18 +1100)]
s4-dsdb: added parse functions for DRS linked attribute blobs

11 years agos4-drs: set flag to indicate that we do support linked attributes
Andrew Tridgell [Mon, 28 Dec 2009 03:11:37 +0000 (14:11 +1100)]
s4-drs: set flag to indicate that we do support linked attributes

11 years agos4-ldb: show the error code as well as errstr
Andrew Tridgell [Tue, 22 Dec 2009 01:31:42 +0000 (12:31 +1100)]
s4-ldb: show the error code as well as errstr

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agos4-dsdb: fixed valgrind error in replmd modify
Andrew Tridgell [Tue, 22 Dec 2009 01:21:02 +0000 (12:21 +1100)]
s4-dsdb: fixed valgrind error in replmd modify

We are using the values from a search result, so we need to steal them
onto the msg before we free the search results

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agos4-drs: don't try to remove backlinks directly
Andrew Tridgell [Mon, 21 Dec 2009 10:28:04 +0000 (21:28 +1100)]
s4-drs: don't try to remove backlinks directly

backlinks need to be removed as a side effect of removing the forward
link

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agos4-drs: isRecycled only exists in FL W2K8-R2
Andrew Tridgell [Mon, 21 Dec 2009 10:27:16 +0000 (21:27 +1100)]
s4-drs: isRecycled only exists in FL W2K8-R2

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agos4-drs: use DSDB_FLAG_OWN_MODULE
Andrew Tridgell [Mon, 21 Dec 2009 10:26:15 +0000 (21:26 +1100)]
s4-drs: use DSDB_FLAG_OWN_MODULE

We need DRS driven replication changes to update replPropertyMetaData,
so it needs to call into the repl_meta_data module logic

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agos4-drs: update comment to refect only forward link in this fn
Andrew Tridgell [Mon, 21 Dec 2009 10:25:27 +0000 (21:25 +1100)]
s4-drs: update comment to refect only forward link in this fn

This function only update forward links

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agos4-drs: fixed typo for uSNCreated
Andrew Tridgell [Mon, 21 Dec 2009 10:24:18 +0000 (21:24 +1100)]
s4-drs: fixed typo for uSNCreated

This broke DRS replication from samba to windows

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agos4-drs: use dsdb_module_guid_by_dn()
Andrew Tridgell [Mon, 21 Dec 2009 10:23:18 +0000 (21:23 +1100)]
s4-drs: use dsdb_module_guid_by_dn()

We should not be going to the top of the module stack

11 years agos4-drs: cope better with NULL GUIDS from DRS
Andrew Tridgell [Mon, 21 Dec 2009 10:21:55 +0000 (21:21 +1100)]
s4-drs: cope better with NULL GUIDS from DRS

It is valid to get a NULL GUID over DRS for a deleted forward link. We
need to match by DN if possible when seeing if we should update an
existing link.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agos4-drs: give an error message in repl_meta_data if we don't get a partition control
Andrew Tridgell [Mon, 21 Dec 2009 10:19:55 +0000 (21:19 +1100)]
s4-drs: give an error message in repl_meta_data if we don't get a partition control

11 years agos4-drs: treat a zero GUID as not present in replmd_add_fix_la
Andrew Tridgell [Mon, 21 Dec 2009 10:18:31 +0000 (21:18 +1100)]
s4-drs: treat a zero GUID as not present in replmd_add_fix_la

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agos4-drs: update highwatermark after successfully encoding the object
Andrew Tridgell [Mon, 21 Dec 2009 10:16:35 +0000 (21:16 +1100)]
s4-drs: update highwatermark after successfully encoding the object

11 years agos4-drs: send all linked attributes at the end of a replication cycle
Andrew Tridgell [Mon, 21 Dec 2009 10:13:59 +0000 (21:13 +1100)]
s4-drs: send all linked attributes at the end of a replication cycle

This ensures that a link is not seen before the object it points to

11 years agos4-drs: use the extended linearized form for DRS replication
Andrew Tridgell [Mon, 21 Dec 2009 10:12:19 +0000 (21:12 +1100)]
s4-drs: use the extended linearized form for DRS replication

We were sending zero GUIDs. Not good!

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agos4-drs: implemented sorting functions based on replication flags
Andrew Tridgell [Mon, 21 Dec 2009 10:10:41 +0000 (21:10 +1100)]
s4-drs: implemented sorting functions based on replication flags

I think we probably have more work to do on the sort order, but this
brings us a bit closer.

11 years agos4-drs: we are doing the sorting for getncchanges in the app code now
Andrew Tridgell [Mon, 21 Dec 2009 10:06:56 +0000 (21:06 +1100)]
s4-drs: we are doing the sorting for getncchanges in the app code now

the sorting is quite delicate, and easier to get right in the
getncchanges code

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agos4-drs: give a reason when an AddEntry commit fails
Andrew Tridgell [Mon, 21 Dec 2009 10:05:50 +0000 (21:05 +1100)]
s4-drs: give a reason when an AddEntry commit fails

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agos4-schema: don't fill in the extended DN with a zero GUID
Andrew Tridgell [Mon, 21 Dec 2009 10:01:33 +0000 (21:01 +1100)]
s4-schema: don't fill in the extended DN with a zero GUID

sometimes windows sends us a zero GUID in a DRS DN.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agosd-schema: order DRS classes on the wire in reverse order
Andrew Tridgell [Mon, 21 Dec 2009 09:59:57 +0000 (20:59 +1100)]
sd-schema: order DRS classes on the wire in reverse order

windows sends objectclasses in DRS in the opposite order to what LDAP
uses

11 years agos4-dsdb: added DSDB_FLAG_OWN_MODULE
Andrew Tridgell [Mon, 21 Dec 2009 09:59:08 +0000 (20:59 +1100)]
s4-dsdb: added DSDB_FLAG_OWN_MODULE

This allows you to call dsdb_module_*() functions while including the
current module in the module stack to be used

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agos4-ldb: added ldb_module_get_ops()
Andrew Tridgell [Mon, 21 Dec 2009 10:03:11 +0000 (21:03 +1100)]
s4-ldb: added ldb_module_get_ops()

This is needed to support DSDB_FLAG_OWN_MODULE

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agos4-dsdb: use a common method for finding a link pair
Andrew Tridgell [Sun, 20 Dec 2009 00:53:09 +0000 (11:53 +1100)]
s4-dsdb: use a common method for finding a link pair

Use ^1 everywhere, to ensure it works for both forward and backward
links

11 years agos4-drs: fixed the UDV return in getncchanges
Andrew Tridgell [Sat, 19 Dec 2009 23:27:03 +0000 (10:27 +1100)]
s4-drs: fixed the UDV return in getncchanges

We should overwrite an existing entry if found

11 years agos4-drs: some useful debugging options for getncchanges
Andrew Tridgell [Sat, 19 Dec 2009 13:12:35 +0000 (00:12 +1100)]
s4-drs: some useful debugging options for getncchanges

Added two debugging parametric options

  drs:max object sync =
  drs:extra filter =