Gerald (Jerry) Carter [Mon, 14 Jan 2008 15:49:47 +0000 (09:49 -0600)]
Merge commit 'samba/v3-2-test' into v3-2-stable
Günther Deschner [Mon, 14 Jan 2008 14:47:42 +0000 (15:47 +0100)]
Remove more redundant lsa parsing functions.
Guenther
Michael Adam [Mon, 14 Jan 2008 14:44:41 +0000 (15:44 +0100)]
Fix bug #5171 (perl syntax error) found by Jason Filley <jason@snakelegs.org>
Michael
Günther Deschner [Mon, 14 Jan 2008 14:39:51 +0000 (15:39 +0100)]
Fix rpcclient display_trust_dom_info().
Guenther
Günther Deschner [Mon, 14 Jan 2008 14:33:26 +0000 (15:33 +0100)]
Use pidl generated rpccli_lsa_QueryTrustedDomainInfoBySid when vampiring trusted
domain secrets.
Guenther
Günther Deschner [Mon, 14 Jan 2008 14:27:57 +0000 (15:27 +0100)]
Remove some more hand written LSA rpc.
(rpccli_lsa_open_trusted_domain,
rpccli_lsa_query_trusted_domain_info,
cli_lsa_query_domain_info_policy).
Guenther
Günther Deschner [Mon, 14 Jan 2008 14:19:30 +0000 (15:19 +0100)]
Start removing hand-written lsa marshalling code (namely
rpccli_lsa_open_trusted_domain_by_name,
rpccli_lsa_query_trusted_domain_info_by_sid and
rpccli_lsa_query_trusted_domain_info_by_name).
Guenther
Günther Deschner [Mon, 14 Jan 2008 14:15:47 +0000 (15:15 +0100)]
Use some more pidl generated LSA rpc in rpcclient.
Guenther
Michael Adam [Mon, 14 Jan 2008 13:57:30 +0000 (14:57 +0100)]
Fix "make test_shlibs": it showed unresolved symbols for -lwbclient.
Michael
Günther Deschner [Mon, 14 Jan 2008 11:01:06 +0000 (12:01 +0100)]
Revert ""make test_shlibs" shows unresolved symbols for -lwbclient."
This reverts commit
0093f618e91f7dcc69d57dbd09d23acc614999aa.
Günther Deschner [Mon, 14 Jan 2008 09:43:49 +0000 (10:43 +0100)]
"make test_shlibs" shows unresolved symbols for -lwbclient.
Guenther
Andrew Tridgell [Mon, 14 Jan 2008 05:26:52 +0000 (16:26 +1100)]
samba3 already has tdb_validate()
Andrew Tridgell [Mon, 14 Jan 2008 04:38:43 +0000 (15:38 +1100)]
merged tdb fix from ctdb tree
Michael Adam [Sun, 13 Jan 2008 23:23:11 +0000 (00:23 +0100)]
Reset the failed counter in test_wbinfo_s3.sh.
Michael
Michael Adam [Sun, 13 Jan 2008 22:54:48 +0000 (23:54 +0100)]
Fix a syntax error in script/tests/test_local_s3.sh .
This will reveal the currently breaking tdbtorture to the build farm...
Michael
Michael Adam [Sun, 13 Jan 2008 22:45:57 +0000 (23:45 +0100)]
Add and modify comments in net_conf.c
Michael
Michael Adam [Sun, 13 Jan 2008 22:30:08 +0000 (23:30 +0100)]
Add explicit creation of shares to net conf import function.
It has been removed from libnet_conf_set_parameter().
Michael
Michael Adam [Sun, 13 Jan 2008 22:20:51 +0000 (23:20 +0100)]
Make use of the new libnet_conf_delete_global_parameter() function.
Michael
Michael Adam [Sun, 13 Jan 2008 22:16:01 +0000 (23:16 +0100)]
Add a function libnet_conf_delete_global_parameter() to libnet_conf.c
Create the [global] section if it does not yet exist.
Michael
Michael Adam [Sun, 13 Jan 2008 22:12:27 +0000 (23:12 +0100)]
Add a function libnet_conf_get_global_parameter() to libnet_conf.c
It creates the [global] section if it does not yet exist.
Michael
Michael Adam [Sun, 13 Jan 2008 22:00:16 +0000 (23:00 +0100)]
Move libnet_conf_set_global_parameter() inside libnet_conf.c
Also remove the "convenience function" section comment.
The set_global_parameter function now has a right to exist
in the api.
Michael
Michael Adam [Sun, 13 Jan 2008 21:56:56 +0000 (22:56 +0100)]
Add a comment header to libnet_conf_set_global_parameter().
Michael
Michael Adam [Sun, 13 Jan 2008 21:56:11 +0000 (22:56 +0100)]
Add auto-adding of [global] to libnet_conf_set_global_parameter().
Michael
Michael Adam [Sun, 13 Jan 2008 21:49:42 +0000 (22:49 +0100)]
Remove auto-generation of missing share from libnet_conf_set_parameter().
Günther, I wanted to have this as atomic as possible.
I will add this behaviour to libnet_conf_set_global_parameter() next
with the justification that [global] should exist transparently.
Michael
Volker Lendecke [Wed, 9 Jan 2008 22:00:48 +0000 (23:00 +0100)]
Fix the max_dead_record calculations
Michael Adam [Sun, 13 Jan 2008 11:52:25 +0000 (12:52 +0100)]
Fix Compiler warnings by including the proper header.
Michael
Michael Adam [Sun, 13 Jan 2008 00:40:05 +0000 (01:40 +0100)]
Introduce a libnet_conf context created by libnet_conf_open().
The libnet_conf_ctx stores the information necessary to interoperate
with the configuration. It is created by calling libnet_conf_open()
and destroyed by calling libnet_conf_close(). The context is passed
to all the libnet_conf functions. It currently stores the token to
access the registry. Later, it could store more data, e.g. the server
to connect to, credentials, and so on. For support of other backends
than registry or support of remote configuration, only the open
function will have to be changed.
In net_conf, the calls to the actual net_conf functions is wrapped
into a function that calls libnet_conf_open()/_close(). Thus an
individual variant of net_conf_runfunction2() and functable2 is
used to cope with functions being called by the wrapper with the
additional libnet_conf_ctx argument.
Michael
Jelmer Vernooij [Sun, 13 Jan 2008 00:22:23 +0000 (01:22 +0100)]
idl: Replace non-standard "declare" keyword with typedef and regenerate.
Volker Lendecke [Sat, 12 Jan 2008 22:06:33 +0000 (23:06 +0100)]
Don't early delete the share mode tdb data
We now refer directly to the file name in the tdb data, so don't delete it.
Volker Lendecke [Sat, 12 Jan 2008 22:05:23 +0000 (23:05 +0100)]
Trivial simplification
Volker Lendecke [Sat, 12 Jan 2008 18:12:30 +0000 (19:12 +0100)]
Remove an unused variable
Volker Lendecke [Sat, 12 Jan 2008 20:09:43 +0000 (21:09 +0100)]
Get the inbuf on talloc_tos()
Volker Lendecke [Sat, 12 Jan 2008 16:08:04 +0000 (17:08 +0100)]
Convert OpenDir to talloc, use talloc_tos()
This cuts some mallocs on NtCreate&X
Volker Lendecke [Sat, 12 Jan 2008 09:38:17 +0000 (10:38 +0100)]
Restructure dbwrap_rbt
In this low-level code, play tricks to reduce the number of allocations to the
possible minimum. I would not recommend this for higher-level code, but here it
pays off.
Volker Lendecke [Fri, 11 Jan 2008 11:02:56 +0000 (12:02 +0100)]
One more empty line
Volker Lendecke [Fri, 11 Jan 2008 11:35:04 +0000 (12:35 +0100)]
delete on close even prevents stat opens
Volker Lendecke [Fri, 11 Jan 2008 20:53:29 +0000 (21:53 +0100)]
There's no point in calling FLOCK on a non-existing fd
Jeremy Allison [Sat, 12 Jan 2008 08:15:46 +0000 (00:15 -0800)]
CID 458. Don't leak dlopen handles on failing to load
module.
Jeremy.
Jeremy Allison [Sat, 12 Jan 2008 08:09:35 +0000 (00:09 -0800)]
Fix CID 469. new_acct can't be NULL here.
Jeremy.
Jeremy Allison [Sat, 12 Jan 2008 08:05:07 +0000 (00:05 -0800)]
Fix CID 470. resolve_order can't be NULL here so simplify code.
Jeremy.
Jeremy Allison [Sat, 12 Jan 2008 07:56:48 +0000 (23:56 -0800)]
Fix CID 475. work should not be checked against NULL
here as it can never be null.
Jeremy.
Jeremy Allison [Sat, 12 Jan 2008 07:53:27 +0000 (23:53 -0800)]
Fix CID 476. Ensure a valid pac_data pointer is always passed to
ads_verify_ticket as it's always derefed.
Jeremy.
Jeremy Allison [Sat, 12 Jan 2008 07:43:33 +0000 (23:43 -0800)]
Coverity 512, uninitialized var.
Jeremy.
Jeremy Allison [Sat, 12 Jan 2008 07:41:17 +0000 (23:41 -0800)]
Stop Coverity complaining about uninitialized variables.
Jeremy.
Jeremy Allison [Sat, 12 Jan 2008 07:24:13 +0000 (23:24 -0800)]
Fix CID 498. Ensure we don't prs_mem_free an uninitialized
prs_struct.
Jeremy.
Jeremy Allison [Sat, 12 Jan 2008 07:17:23 +0000 (23:17 -0800)]
Fix CID 505 - don't copy uninitialized memory.
Jeremy.
Jeremy Allison [Sat, 12 Jan 2008 06:50:13 +0000 (22:50 -0800)]
Fix CID 523 - wrong null deref check.
Jeremy.
Jeremy Allison [Sat, 12 Jan 2008 06:47:25 +0000 (22:47 -0800)]
Fix CID 524 - reference before allocation fail null check.
Jeremy.
Jeremy Allison [Sat, 12 Jan 2008 06:44:33 +0000 (22:44 -0800)]
Ensure we don't access an uninitialized variable
(CID 535 - actually false but easy to shut up :-).
Jeremy.
Jeremy Allison [Sat, 12 Jan 2008 06:38:42 +0000 (22:38 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Günther Deschner [Sat, 12 Jan 2008 01:24:55 +0000 (02:24 +0100)]
Fix some indents.
Guenther
Günther Deschner [Sat, 12 Jan 2008 01:22:44 +0000 (02:22 +0100)]
Call dsgetdcname when we have no specific dc defined for joining.
Guenther
Günther Deschner [Sat, 12 Jan 2008 01:20:33 +0000 (02:20 +0100)]
Fix some error strings in libnet_join.
Guenther
Günther Deschner [Sat, 12 Jan 2008 01:19:21 +0000 (02:19 +0100)]
Add appropriate error code when pre-creating accounts in ous isnt supported by DC.
Guenther
Günther Deschner [Sat, 12 Jan 2008 01:17:10 +0000 (02:17 +0100)]
For libnet_join error string functions, make sure not to overwrite last status string.
Guenther
Günther Deschner [Sat, 12 Jan 2008 01:15:42 +0000 (02:15 +0100)]
Merge all ads related calls in libnet_join_post_processing_ads().
Guenther
Günther Deschner [Sat, 12 Jan 2008 01:10:17 +0000 (02:10 +0100)]
Use WITH_ADS define in libnet_join, hopefully not breaking the build.
Guenther
Günther Deschner [Sat, 12 Jan 2008 00:28:20 +0000 (01:28 +0100)]
Auto-add missing shares in libnet_conf_set_parameter().
Michael, please have a look.
Guenther
Günther Deschner [Fri, 11 Jan 2008 17:51:15 +0000 (18:51 +0100)]
Add debug bool flag for libnetjoin ctx.
Guenther
Günther Deschner [Fri, 11 Jan 2008 17:49:20 +0000 (18:49 +0100)]
Use domain_is_ad one more time in libnetjoin.
Guenther
Jeremy Allison [Fri, 11 Jan 2008 23:08:37 +0000 (15:08 -0800)]
Sync tdb with the tdb changes in ctdb. Spoke to tridge about
this. Fixes insidious problem with order n^2 freelist merging.
Jeremy.
Michael Adam [Fri, 11 Jan 2008 18:02:26 +0000 (19:02 +0100)]
Remove code accidentially submittet with last commit
83aed537c16f63.
This is ist still in preparation and will follow soon. Soory!
Michael
Michael Adam [Fri, 11 Jan 2008 17:55:20 +0000 (18:55 +0100)]
Fix panic in "net conf": Fix logic in error condition.
Michael
Günther Deschner [Fri, 11 Jan 2008 17:46:41 +0000 (18:46 +0100)]
Fix a build warning.
Guenther
Günther Deschner [Fri, 11 Jan 2008 14:32:20 +0000 (15:32 +0100)]
As long as DsGetDcName is not part of libnetapi, lowercase the fn name.
Guenther
Günther Deschner [Fri, 11 Jan 2008 14:28:24 +0000 (15:28 +0100)]
Fix libnetapi error string callers.
Guenther
Günther Deschner [Fri, 11 Jan 2008 14:03:31 +0000 (15:03 +0100)]
Remove '\n' from error strings in libnet_join context.
Guenther
Günther Deschner [Fri, 11 Jan 2008 13:50:10 +0000 (14:50 +0100)]
Set error string when ads_leave_realm() has failed in libnetjoin.
Guenther
Günther Deschner [Fri, 11 Jan 2008 13:47:52 +0000 (14:47 +0100)]
Include some basic headers in netapi.h.
Guenther
Günther Deschner [Fri, 11 Jan 2008 13:47:23 +0000 (14:47 +0100)]
Refactor libnetapi error string functions a bit.
Guenther
Günther Deschner [Fri, 11 Jan 2008 13:43:56 +0000 (14:43 +0100)]
Ignore result of libnet_conf_delete_parameter here, as realm may be not there.
Guenther
Günther Deschner [Fri, 11 Jan 2008 13:42:48 +0000 (14:42 +0100)]
Remove some more references to global_myname() in libnet_join.
Guenther
Günther Deschner [Fri, 11 Jan 2008 13:41:34 +0000 (14:41 +0100)]
Use domain_is_ad bool.
Guenther
Günther Deschner [Fri, 11 Jan 2008 13:40:06 +0000 (14:40 +0100)]
Add domain_is_ad bool to libnetjoin ctx.
Guenther
Jeremy Allison [Fri, 11 Jan 2008 00:36:05 +0000 (16:36 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Fri, 11 Jan 2008 00:35:54 +0000 (16:35 -0800)]
Don't switch user contexts unless you have to. Saves
a bunch of syscalls on close. Noticed by Volker.
Jeremy.
Michael Adam [Fri, 11 Jan 2008 00:26:54 +0000 (01:26 +0100)]
Combine fsp and tofd to tofsp in SMB_VFS_RECVFILE().
Michael
Michael Adam [Thu, 10 Jan 2008 23:56:06 +0000 (00:56 +0100)]
Remove now redundant parameter fd from prime_cache().
Michael
Michael Adam [Thu, 10 Jan 2008 23:51:19 +0000 (00:51 +0100)]
Combine fsp and fromfd to fromfsp in SMB_VFS_SENDFILE().
Michael
Jeremy Allison [Thu, 10 Jan 2008 23:15:01 +0000 (15:15 -0800)]
Don't print out debug messages at level 0 if we can't
bind to a socket if we've already bound to one (this
prevents :
bind failed on port 445 socket_addr = 0.0.0.0.
Error = Address already in use
bind failed on port 139 socket_addr = 0.0.0.0.
Error = Address already in use
messages when trying to bind to an IPv4 address
when we've already bound to the IPv6 equivalent.
Jeremy.
Michael Adam [Thu, 10 Jan 2008 22:40:13 +0000 (23:40 +0100)]
Fix the build of the cacheprime VFS module after API changes.
Sorry, that had escaped my attention.
Michael
Volker Lendecke [Mon, 7 Jan 2008 17:27:10 +0000 (18:27 +0100)]
--enable-libwbclient-shared
This patch adds the configure option --enable-libwbclient-shared that defaults
to yes. If you set --enable-developer=yes, then you can say
--enable-libwbclient-shared=no to avoid problems you might have with the wrong
shared libaries.
Jerry, is this acceptable to you? If yes, please push.
Thanks!
Volker
Volker Lendecke [Thu, 10 Jan 2008 12:22:51 +0000 (13:22 +0100)]
Tiny cosmetic fix
Michael Adam [Thu, 10 Jan 2008 14:49:35 +0000 (15:49 +0100)]
Remove redundant parameter fd from SMB_VFS_WRITE().
Michael
Michael Adam [Thu, 10 Jan 2008 14:33:51 +0000 (15:33 +0100)]
Remove redundant parameter fd from SMB_VFS_READ().
Michael
Gerald (Jerry) Carter [Thu, 10 Jan 2008 14:25:54 +0000 (08:25 -0600)]
Set the "stable" vendor string in VERSION.
Michael Adam [Thu, 10 Jan 2008 13:27:52 +0000 (14:27 +0100)]
Move transfer_file and transfer_file_internal to a module of their own.
Also, don't auto-generate prototypes of the (two) exported functions
but make a start in having handwritten prototypes in dedicated header
files (not in includes.h ... :-)
Michael
Michael Adam [Thu, 10 Jan 2008 12:55:46 +0000 (13:55 +0100)]
Reformat some code I just touched.
Michael
Michael Adam [Thu, 10 Jan 2008 12:55:16 +0000 (13:55 +0100)]
Make casts to (void *) explicit to remove compiler warnings.
Michael
Michael Adam [Thu, 10 Jan 2008 13:18:46 +0000 (14:18 +0100)]
Fix a really silly typo.
Michael
Michael Adam [Thu, 10 Jan 2008 12:30:43 +0000 (13:30 +0100)]
Correctly abstract the transfer_file mechanism with callbacks and void ptrs.
This removes the in_fsp and out_fsp global variables hack from smbd/vfs.c.
Michael
Volker Lendecke [Sun, 6 Jan 2008 13:17:15 +0000 (14:17 +0100)]
use talloc_tos() in share_access_check()
Volker Lendecke [Sun, 6 Jan 2008 15:15:45 +0000 (16:15 +0100)]
Some more talloc_tos()
Volker Lendecke [Sun, 6 Jan 2008 13:21:25 +0000 (14:21 +0100)]
use talloc_tos in a few more places
Günther Deschner [Thu, 10 Jan 2008 10:13:23 +0000 (11:13 +0100)]
Remove unused string.
Guenther
Volker Lendecke [Thu, 10 Jan 2008 10:35:40 +0000 (11:35 +0100)]
Fix a c++ warning
Volker Lendecke [Thu, 10 Jan 2008 10:35:17 +0000 (11:35 +0100)]
talloc_free_children can only reset pool if it's empty
Volker Lendecke [Thu, 10 Jan 2008 10:34:07 +0000 (11:34 +0100)]
Mark talloc_pool memory for valgrind
Volker Lendecke [Thu, 10 Jan 2008 09:55:20 +0000 (10:55 +0100)]
Fix suspicious Makefile line
If @WINBIND_KRB5_LOCATOR@ is not defined, this leads to a line with just one
tab in.
Volker Lendecke [Thu, 10 Jan 2008 08:53:51 +0000 (09:53 +0100)]
Form a proper hierarchy in talloc_stack
This way talloc_stackframe() can benefit from a pool put on the stack further
up. No need to remove talloc_stackframe().