ira/wip.git
13 years agoon buffer overflow windows gives SMBSRV:ERRerror here
Andrew Tridgell [Wed, 5 Aug 2009 10:19:36 +0000 (20:19 +1000)]
on buffer overflow windows gives SMBSRV:ERRerror here

13 years agos4:torture The test logic for the target was wrong. This should correct it.
Matthias Dieter Wallnöfer [Wed, 5 Aug 2009 08:48:25 +0000 (10:48 +0200)]
s4:torture The test logic for the target was wrong. This should correct it.

13 years agos4:heimdal_build: define HEIMDAL_LOCALEDIR
Stefan Metzmacher [Tue, 4 Aug 2009 11:43:29 +0000 (13:43 +0200)]
s4:heimdal_build: define HEIMDAL_LOCALEDIR

metze

13 years agos4:ldap_server: make sure we shutdown the tls socket before stream_terminate_connecti...
Stefan Metzmacher [Wed, 5 Aug 2009 08:05:56 +0000 (10:05 +0200)]
s4:ldap_server: make sure we shutdown the tls socket before stream_terminate_connection() removes the fd event

This fixes a crash bug where tls_destructor() relies on the fd event still being there.

metze

13 years agos4:torture Remove some unwanted code in the LDAP test - hope this fixes up the test...
Matthias Dieter Wallnöfer [Wed, 5 Aug 2009 07:48:45 +0000 (09:48 +0200)]
s4:torture Remove some unwanted code in the LDAP test - hope this fixes up the test failures

13 years agofixed a problem with group policy writes causing policy corruption
Andrew Tridgell [Wed, 5 Aug 2009 07:51:21 +0000 (17:51 +1000)]
fixed a problem with group policy writes causing policy corruption

This bug was caused by two things:

  1) in the unix ACL mapping, we were not taking into account group
  write permssions for the SEC_STD_DELETE flag

  2) when a file is created using OVERWRITE mode, a fchmod() would
  fail if the user is not the file owner. We resolve that by only
  doing the fchmod() if the mapped file attribute does not match the
  desired file attribute

13 years agos3:winbind: Convert WINBINDD_GETGROUPS to the new API
Volker Lendecke [Tue, 4 Aug 2009 20:26:07 +0000 (16:26 -0400)]
s3:winbind: Convert WINBINDD_GETGROUPS to the new API

13 years agos3:winbind: Add async wb_gettoken
Volker Lendecke [Tue, 4 Aug 2009 20:22:42 +0000 (16:22 -0400)]
s3:winbind: Add async wb_gettoken

13 years agos3:winbind: Convert WINBINDD_GETUSERDOMGROUPS to the new API
Volker Lendecke [Tue, 4 Aug 2009 20:20:18 +0000 (16:20 -0400)]
s3:winbind: Convert WINBINDD_GETUSERDOMGROUPS to the new API

13 years agos3:winbind: Add async wb_lookupusergroups
Volker Lendecke [Tue, 4 Aug 2009 20:07:01 +0000 (16:07 -0400)]
s3:winbind: Add async wb_lookupusergroups

13 years agos3:winbind: Make wcache_lookup_usergroups externally visible
Volker Lendecke [Sun, 2 Aug 2009 16:01:54 +0000 (18:01 +0200)]
s3:winbind: Make wcache_lookup_usergroups externally visible

13 years agos3:winbind: Convert WINBINDD_GETSIDALIASES to the new API
Volker Lendecke [Tue, 4 Aug 2009 19:58:45 +0000 (15:58 -0400)]
s3:winbind: Convert WINBINDD_GETSIDALIASES to the new API

13 years agos3:winbind: Add async wb_lookupuseraliases
Volker Lendecke [Tue, 4 Aug 2009 19:54:05 +0000 (15:54 -0400)]
s3:winbind: Add async wb_lookupuseraliases

13 years agos3:winbind: Make parse_sidlist take a const char *
Volker Lendecke [Sun, 2 Aug 2009 15:17:27 +0000 (17:17 +0200)]
s3:winbind: Make parse_sidlist take a const char *

13 years agos3:winbind: Make wcache_lookup_useraliases available publically
Volker Lendecke [Sun, 2 Aug 2009 14:52:19 +0000 (16:52 +0200)]
s3:winbind: Make wcache_lookup_useraliases available publically

13 years agos3:winbind: Convert WINBINDD_GETPWUID to the new API
Volker Lendecke [Tue, 4 Aug 2009 19:41:40 +0000 (15:41 -0400)]
s3:winbind: Convert WINBINDD_GETPWUID to the new API

13 years agos3:winbind: Convert WINBINDD_GETPWNAM to the new API
Volker Lendecke [Tue, 4 Aug 2009 19:37:54 +0000 (15:37 -0400)]
s3:winbind: Convert WINBINDD_GETPWNAM to the new API

13 years agos3:winbind: Convert WINBINDD_GETPWSID to the new API
Volker Lendecke [Tue, 4 Aug 2009 19:35:24 +0000 (15:35 -0400)]
s3:winbind: Convert WINBINDD_GETPWSID to the new API

13 years agos3:winbind: Add async wb_getpwsid
Volker Lendecke [Tue, 4 Aug 2009 19:32:11 +0000 (15:32 -0400)]
s3:winbind: Add async wb_getpwsid

13 years agos3:winbind: Make fillup_pw_field publically available
Volker Lendecke [Tue, 4 Aug 2009 19:31:49 +0000 (15:31 -0400)]
s3:winbind: Make fillup_pw_field publically available

13 years agos3:winbind: Add async wb_queryuser
Volker Lendecke [Tue, 4 Aug 2009 19:23:13 +0000 (15:23 -0400)]
s3:winbind: Add async wb_queryuser

13 years agos3:winbind: Make wcache_query_user externally visible
Volker Lendecke [Sat, 1 Aug 2009 14:20:13 +0000 (10:20 -0400)]
s3:winbind: Make wcache_query_user externally visible

13 years agos3:winbind: Convert WINBINDD_GID_TO_SID the new API
Volker Lendecke [Tue, 4 Aug 2009 18:22:17 +0000 (14:22 -0400)]
s3:winbind: Convert WINBINDD_GID_TO_SID the new API

13 years agos3:winbind: Add async wb_gid2sid
Volker Lendecke [Tue, 4 Aug 2009 18:19:03 +0000 (14:19 -0400)]
s3:winbind: Add async wb_gid2sid

13 years agos3:winbind: Convert WINBINDD_UID_TO_SID the new API
Volker Lendecke [Tue, 4 Aug 2009 18:07:44 +0000 (14:07 -0400)]
s3:winbind: Convert WINBINDD_UID_TO_SID the new API

13 years agos3:winbind: Add async wb_uid2sid
Volker Lendecke [Tue, 4 Aug 2009 17:52:39 +0000 (13:52 -0400)]
s3:winbind: Add async wb_uid2sid

13 years agos3:winbind: Convert WINBINDD_SID_TO_GID the new API
Volker Lendecke [Tue, 4 Aug 2009 17:42:22 +0000 (13:42 -0400)]
s3:winbind: Convert WINBINDD_SID_TO_GID the new API

13 years agos3:winbind: Add async wb_sid2gid
Volker Lendecke [Tue, 4 Aug 2009 17:38:52 +0000 (13:38 -0400)]
s3:winbind: Add async wb_sid2gid

13 years agos3:winbind: Convert WINBINDD_SID_TO_UID to the new API
Volker Lendecke [Tue, 4 Aug 2009 17:33:56 +0000 (13:33 -0400)]
s3:winbind: Convert WINBINDD_SID_TO_UID to the new API

13 years agos3:winbind: Add async wb_sid2uid
Volker Lendecke [Tue, 4 Aug 2009 17:28:59 +0000 (13:28 -0400)]
s3:winbind: Add async wb_sid2uid

13 years agos3:winbind: Convert WINBINDD_LOOKUPNAME to the new API
Volker Lendecke [Tue, 4 Aug 2009 11:29:03 +0000 (07:29 -0400)]
s3:winbind: Convert WINBINDD_LOOKUPNAME to the new API

13 years agos3:winbind: Add async wb_lookupname
Volker Lendecke [Tue, 4 Aug 2009 11:22:34 +0000 (07:22 -0400)]
s3:winbind: Add async wb_lookupname

13 years agos3:winbind: Make wcache_name_to_sid visible externally
Volker Lendecke [Fri, 31 Jul 2009 22:10:46 +0000 (00:10 +0200)]
s3:winbind: Make wcache_name_to_sid visible externally

13 years agos3:winbind: Remove old version of WINBINDD_PING
Volker Lendecke [Tue, 4 Aug 2009 10:58:28 +0000 (06:58 -0400)]
s3:winbind: Remove old version of WINBINDD_PING

13 years agos3:winbind: Convert WINBINDD_LOOKUPSID to the new API
Volker Lendecke [Tue, 4 Aug 2009 10:57:13 +0000 (06:57 -0400)]
s3:winbind: Convert WINBINDD_LOOKUPSID to the new API

13 years agos3:winbind: Add async wb_lookupsid
Volker Lendecke [Mon, 3 Aug 2009 21:44:46 +0000 (23:44 +0200)]
s3:winbind: Add async wb_lookupsid

13 years agos3:winbind: Make wcache_sid_to_name externally visible
Volker Lendecke [Sat, 1 Aug 2009 10:16:11 +0000 (12:16 +0200)]
s3:winbind: Make wcache_sid_to_name externally visible

13 years agos3:winbind: Add NDR-based parent-child communication to winbind
Volker Lendecke [Tue, 28 Jul 2009 19:06:11 +0000 (15:06 -0400)]
s3:winbind: Add NDR-based parent-child communication to winbind

13 years agohandle large directories in smb2_deltree()
Andrew Tridgell [Wed, 5 Aug 2009 05:05:13 +0000 (15:05 +1000)]
handle large directories in smb2_deltree()

13 years agofixed a uid_wrapper bug that caused a segv in the RAW-ACLS test
Andrew Tridgell [Wed, 5 Aug 2009 03:31:06 +0000 (13:31 +1000)]
fixed a uid_wrapper bug that caused a segv in the RAW-ACLS test

13 years agos4:heimdal: import lorikeet-heimdal-200908050050 (commit 8714779fa7376fd9f7761587639e...
Andrew Bartlett [Wed, 5 Aug 2009 01:25:50 +0000 (11:25 +1000)]
s4:heimdal: import lorikeet-heimdal-200908050050 (commit 8714779fa7376fd9f7761587639e68b48afc8c9c)

This also adds a new hdb-glue.c file, to cope with Heimdal's
uncondtional enabling of SQLITE.

(Very reasonable, but not required for Samba4's use).

Andrew Bartlett

13 years agos4 now supports the large readx extension
Andrew Tridgell [Wed, 5 Aug 2009 02:07:21 +0000 (12:07 +1000)]
s4 now supports the large readx extension

13 years agofixed the sense of the pvfs_acl uwrap check
Andrew Tridgell [Wed, 5 Aug 2009 02:07:08 +0000 (12:07 +1000)]
fixed the sense of the pvfs_acl uwrap check

13 years agopyldb: Fix reference counting on ldb_message_elements, add extra type
Jelmer Vernooij [Wed, 5 Aug 2009 01:34:08 +0000 (03:34 +0200)]
pyldb: Fix reference counting on ldb_message_elements, add extra type
check.

13 years agoskip the readbraw tests if the server does not support it
Andrew Tridgell [Wed, 5 Aug 2009 01:32:01 +0000 (11:32 +1000)]
skip the readbraw tests if the server does not support it

This allows the RAW-READ test to pass against w2k8

13 years agomake the UID_WRAPPER skip checks at runtime
Andrew Tridgell [Wed, 5 Aug 2009 01:21:06 +0000 (11:21 +1000)]
make the UID_WRAPPER skip checks at runtime

This fixes two issues pointed out by Andrew. It adds a runtime
uwrap_enabled() call that wraps the skips needed for uid emulation. It
also makes the skip in the directory_create_or_exist() function only
change the uid checking code, not the permissions code

13 years agoadded a uid_wrapper library
Andrew Tridgell [Wed, 5 Aug 2009 00:50:03 +0000 (10:50 +1000)]
added a uid_wrapper library

This library intercepts seteuid and related calls, and simulates them
in a manner similar to the nss_wrapper and socket_wrapper
libraries. This allows us to enable the vfs_unixuid NTVFS module in
the build farm, which means we are more likely to catch errors in the
token manipulation.

The simulation is not complete, but it is enough for Samba4 for
now. The major areas of incompleteness are:

 - no emulation of setreuid, setresuid or saved uids. These would be
   needed for use in Samba3

 - no emulation of ruid changing. That would also be needed for Samba3

 - no attempt to emulate file ownership changing, so code that (for
   example) tests whether st.st_uid matches geteuid() needs special
   handling

13 years agos4:ldb initialise e->values[i].length before use in python bindings
Andrew Bartlett [Wed, 5 Aug 2009 00:35:45 +0000 (10:35 +1000)]
s4:ldb initialise e->values[i].length before use in python bindings

13 years agos4:dsdb Don't cast an ldb_val into a const char * for schema lookups
Andrew Bartlett [Tue, 4 Aug 2009 22:53:11 +0000 (08:53 +1000)]
s4:dsdb Don't cast an ldb_val into a const char * for schema lookups

This removes a number of cases where we did a cast into a const char *
of an ldb_val.  While convention is to alway have an extra \0 at
data[length] in the ldb_val, this is not required, and does not occour
at least on build farm host 'svart'.

Andrew Bartlett

13 years agoidmap_adex: Fix usage of talloc_stackframe().
Gerald Carter [Mon, 3 Aug 2009 21:18:10 +0000 (16:18 -0500)]
idmap_adex: Fix usage of talloc_stackframe().

Pass an explicit TALLOC_CTX* to build_id_filter() and build_alias_filter()
rather than relying upon the talloc_stackframe() behavior that
allows a caller access to stackframe ctx for called functions.

13 years agos4: make install: prevent overwriting failure
Rusty Russell [Tue, 4 Aug 2009 17:02:42 +0000 (19:02 +0200)]
s4: make install: prevent overwriting failure

We don't have to remove the eventual write privileges to enable the execute ones.

13 years agos3-spoolss: Fix Bug #6568: _spoolss_GetPrintProcessorDirectory() implementation.
Günther Deschner [Tue, 4 Aug 2009 10:21:49 +0000 (12:21 +0200)]
s3-spoolss: Fix Bug #6568: _spoolss_GetPrintProcessorDirectory() implementation.

We should always return a local path so that users are not forced to setup a
[prnproc$] share on the server. This restores pre-3.4.0 spoolss behaviour.

Guenther

13 years agos4: Change my nested groups patch to don't include user's SID itself in the "groupSID...
Matthias Dieter Wallnöfer [Tue, 4 Aug 2009 15:09:29 +0000 (17:09 +0200)]
s4: Change my nested groups patch to don't include user's SID itself in the "groupSID"s structure

13 years agos4:torture Make RPC-NETLOGON pass against ncaclrpc servers
Andrew Bartlett [Tue, 4 Aug 2009 08:24:37 +0000 (18:24 +1000)]
s4:torture Make RPC-NETLOGON pass against ncaclrpc servers

The original patch didn't cope with a NULL target server name - we now key off that to decide it isn't worth checking against LDAP for this host.

I still can't get this to pass against Windows 2008, but mdw was
testing against Windows 2008R2.  at least 'make test' is happy, and
the rest should not be too hard...

Andrew Bartlett

13 years agoAdd const
Andrew Bartlett [Tue, 4 Aug 2009 06:11:55 +0000 (16:11 +1000)]
Add const

13 years agos4:ldif_handlers Allow a binary nTsecurityDescriptor when parsing LDIF
Andrew Bartlett [Tue, 4 Aug 2009 06:07:18 +0000 (16:07 +1000)]
s4:ldif_handlers Allow a binary nTsecurityDescriptor when parsing LDIF

Also allow a SDDL security descriptor, using the domain SID attached
to the session (it will search for it during the LDIF parse if need
be).

Andrew Bartlett

13 years agos4:netlogon Fix warnings and segfault in GetDomainInfo call
Andrew Bartlett [Tue, 4 Aug 2009 04:36:14 +0000 (14:36 +1000)]
s4:netlogon Fix warnings and segfault in GetDomainInfo call

 - Correctly use samdb_search_string to do a 'base' search
   (this needs a NULL, not a "" argument for the format string)

 - There is no need (and it caused a security hole) to use
   talloc_asprintf() with the only argument being the string to
   duplicate.

Andrew Bartlett

13 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba
Andrew Tridgell [Tue, 4 Aug 2009 06:02:23 +0000 (16:02 +1000)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba

13 years agofixed support for readx greater than 64k
Andrew Tridgell [Tue, 4 Aug 2009 06:01:11 +0000 (16:01 +1000)]
fixed support for readx greater than 64k

This fixes bug 6547, where smbclient in S3 reads more than 64k at a
time with readx.

13 years agos4:torture rework LDAP sort test
Andrew Bartlett [Tue, 4 Aug 2009 02:52:11 +0000 (12:52 +1000)]
s4:torture rework LDAP sort test

This reworks the test to be part of the LDAP tests, to make better use
of the torture API and the ldb API (in particular around adding
controls), and a general cleanup.

This also adds the test to the 'make test' run.

Andrew Bartlett

13 years agos4:torture Add test for correct server-side sorting over LDAP
Matthieu Patou [Tue, 4 Aug 2009 01:51:46 +0000 (11:51 +1000)]
s4:torture Add test for correct server-side sorting over LDAP

13 years agoUse smbclient binary for the test file in smbclient test
Andrew Bartlett [Tue, 4 Aug 2009 01:12:33 +0000 (11:12 +1000)]
Use smbclient binary for the test file in smbclient test

In the vein hope that a larger file might show problems better than a
small file.

Andrew Bartlett

13 years agoparam/pyparam: Cope with string list parameters being empty.
Ricardo Jorge [Mon, 3 Aug 2009 22:03:04 +0000 (00:03 +0200)]
param/pyparam: Cope with string list parameters being empty.

Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
13 years agopython/loadparm: Get shares listing working.
Ricardo Jorge [Mon, 3 Aug 2009 22:00:25 +0000 (00:00 +0200)]
python/loadparm: Get shares listing working.

Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
13 years agopyldb: Properly keep copies of Python string contents, rather than
Jelmer Vernooij [Mon, 3 Aug 2009 21:58:16 +0000 (23:58 +0200)]
pyldb: Properly keep copies of Python string contents, rather than
relying on reference leaks :-)

13 years agos4-ldap_server: fix generated error string in map_ldb_error().
Günther Deschner [Mon, 3 Aug 2009 22:06:26 +0000 (00:06 +0200)]
s4-ldap_server: fix generated error string in map_ldb_error().

Guenther

13 years agos3-spoolss: fix crash bug in spoolss_addprinterex_level_2.
Günther Deschner [Mon, 3 Aug 2009 21:41:08 +0000 (23:41 +0200)]
s3-spoolss: fix crash bug in spoolss_addprinterex_level_2.

Guenther

13 years agoAdd some const to winbind_userinfo
Volker Lendecke [Sat, 1 Aug 2009 14:38:13 +0000 (10:38 -0400)]
Add some const to winbind_userinfo

13 years agoFix a typo
Volker Lendecke [Sat, 1 Aug 2009 08:46:45 +0000 (10:46 +0200)]
Fix a typo

13 years agoFix some nonempty blank lines
Volker Lendecke [Mon, 3 Aug 2009 09:30:29 +0000 (11:30 +0200)]
Fix some nonempty blank lines

13 years agopyldb: Raise proper exception when attempting to assign a string to a dn
Jelmer Vernooij [Mon, 3 Aug 2009 16:15:16 +0000 (18:15 +0200)]
pyldb: Raise proper exception when attempting to assign a string to a dn
attribute.

13 years agos3-pdb_ldap: Make ldapsam_alias_memberships behave like the tdbsam equivalent.
Günther Deschner [Mon, 3 Aug 2009 14:28:59 +0000 (16:28 +0200)]
s3-pdb_ldap: Make ldapsam_alias_memberships behave like the tdbsam equivalent.

This lets samr_GetAliasMembership return with NT_STATUS_OK when called with 0
sids (just what w2k3 does).

Guenther

13 years agos4: Change constant to comply with the merged build
Matthias Dieter Wallnöfer [Mon, 3 Aug 2009 12:19:12 +0000 (14:19 +0200)]
s4: Change constant to comply with the merged build

13 years agos3/docs: Fix typos.
Karolin Seeger [Mon, 3 Aug 2009 08:19:45 +0000 (10:19 +0200)]
s3/docs: Fix typos.

Thanks to OPC oota <t-oota@dh.jp.nec.com> for reporting!

Karolin

13 years agos3/s4: Add new autogenerated files from "make idl_full"
Matthias Dieter Wallnöfer [Mon, 3 Aug 2009 07:51:44 +0000 (09:51 +0200)]
s3/s4: Add new autogenerated files from "make idl_full"

13 years agos4: Torture test for enhancements in "netr_LogonGetDomainInformations" call
Matthias Dieter Wallnöfer [Thu, 23 Jul 2009 11:05:34 +0000 (13:05 +0200)]
s4: Torture test for enhancements in "netr_LogonGetDomainInformations" call

This corrects and enhances the torture test of the mentioned call.

13 years agos4: Enhancements in the "netr_LogonGetDomainInformations" call
Matthias Dieter Wallnöfer [Wed, 22 Jul 2009 20:11:12 +0000 (22:11 +0200)]
s4: Enhancements in the "netr_LogonGetDomainInformations" call

This addresses bug #4888 and #6596 in SAMBA 4 Bugzilla
- It implements the call in the complete form as specified in the MSPP/WSPP docs
  and on the discussion on the "cifs-protocol" list
- Therefore client informations (OS name, OS version, "servicePrincipalName"...)
  are now saved in the AD each time the client invokes the call

13 years agonetlogon.idl: Prework to enhance the "netr_LogonGetDomainInformation" call correctly
Matthias Dieter Wallnöfer [Wed, 22 Jul 2009 19:01:52 +0000 (21:01 +0200)]
netlogon.idl: Prework to enhance the "netr_LogonGetDomainInformation" call correctly

This enhances the "netlogon.idl" file to allow enhancements on the mentioned call.
Therefore this is also the base for fixing up bug #4888.

13 years agonetlogon.idl: Removes the form "str[]" for string declarations
Matthias Dieter Wallnöfer [Wed, 22 Jul 2009 18:03:21 +0000 (20:03 +0200)]
netlogon.idl: Removes the form "str[]" for string declarations

In this file two different forms are used to explain the same datatype ("str[]" and "*str").
I didn't find this very nice and unified the occurrences to always use "*str".

This patch is of cosmetic nature.

13 years agoReturn infinite time for last last logoff when last logoff = 0
Matthieu Patou [Sat, 1 Aug 2009 10:02:58 +0000 (14:02 +0400)]
Return infinite time for last last logoff when last logoff = 0

13 years agos3: check in .po files for pam_winbind.
Bo Yang [Mon, 3 Aug 2009 00:16:21 +0000 (08:16 +0800)]
s3: check in .po files for pam_winbind.

Signed-off-by: Bo Yang <boyang@samba.org>
13 years agoFix some nonempty blank lines
Volker Lendecke [Sun, 2 Aug 2009 20:28:49 +0000 (22:28 +0200)]
Fix some nonempty blank lines

13 years agoFix breakage for connect function after API change (connect -> connect_fn)
Alexander Bokovoy [Sun, 2 Aug 2009 14:42:49 +0000 (17:42 +0300)]
Fix breakage for connect function after API change (connect -> connect_fn)

13 years agoRefactor 9b78af1f: Fix lookupname recursion
Volker Lendecke [Sun, 2 Aug 2009 08:43:05 +0000 (10:43 +0200)]
Refactor 9b78af1f: Fix lookupname recursion

Pass a "flags" argument instead of the original winbind command down the
name_to_sid chain. This way we are independent of the winbind commands and
can take the decision at a much higher level

13 years agoSome mods for recent coding conventions
Volker Lendecke [Fri, 31 Jul 2009 20:42:50 +0000 (22:42 +0200)]
Some mods for recent coding conventions

13 years agoPlace a comment correctly
Volker Lendecke [Fri, 31 Jul 2009 20:47:48 +0000 (22:47 +0200)]
Place a comment correctly

13 years agoFix indentation
Volker Lendecke [Fri, 31 Jul 2009 22:24:35 +0000 (00:24 +0200)]
Fix indentation

13 years agoRefactoring: mem_ctx is not needed as an argument to centry_sid
Volker Lendecke [Fri, 31 Jul 2009 21:48:39 +0000 (23:48 +0200)]
Refactoring: mem_ctx is not needed as an argument to centry_sid

13 years agoRename LOOKUP_NAME_EXPLICIT to LOOKUP_NAME_NO_NSS
Volker Lendecke [Fri, 31 Jul 2009 21:17:54 +0000 (23:17 +0200)]
Rename LOOKUP_NAME_EXPLICIT to LOOKUP_NAME_NO_NSS

It took me a bit to understand what this flag does. I hope this is
a bit clearer, at least it is to me.

13 years agoFix some nonempty lines
Volker Lendecke [Fri, 31 Jul 2009 20:59:30 +0000 (22:59 +0200)]
Fix some nonempty lines

13 years agoRemove a pointless variable
Volker Lendecke [Fri, 31 Jul 2009 20:38:54 +0000 (22:38 +0200)]
Remove a pointless variable

13 years agoWe're not changing last write, but setting this to be FILE_NOTIFY_CHANGE_CREATION
Jeremy Allison [Fri, 31 Jul 2009 18:19:19 +0000 (11:19 -0700)]
We're not changing last write, but setting this to be FILE_NOTIFY_CHANGE_CREATION
doesn't work. So use FILE_NOTIFY_CHANGE_LAST_WRITE (now seems to reliably fix
bug #6529 - Offline files conflict with Vista and Office 2003.
Jeremy.

13 years agos3: Remove invalid constant
Matthias Dieter Wallnöfer [Fri, 31 Jul 2009 17:24:53 +0000 (19:24 +0200)]
s3: Remove invalid constant

13 years agoMerge branch 'master' of git://git.samba.org/samba
Matthias Dieter Wallnöfer [Fri, 31 Jul 2009 16:17:00 +0000 (18:17 +0200)]
Merge branch 'master' of git://git.samba.org/samba

13 years agos4: Correct renamed constants
Matthias Dieter Wallnöfer [Fri, 31 Jul 2009 16:15:39 +0000 (18:15 +0200)]
s4: Correct renamed constants

13 years agoProvide a mem_ctx for child requests
Volker Lendecke [Fri, 31 Jul 2009 15:32:03 +0000 (17:32 +0200)]
Provide a mem_ctx for child requests

13 years agos4: Adds a small test for the new enhanced error messages from the AD LDAP server
Matthias Dieter Wallnöfer [Thu, 30 Jul 2009 10:43:49 +0000 (12:43 +0200)]
s4: Adds a small test for the new enhanced error messages from the AD LDAP server

13 years agos4: Enhances the LDAP server to display error messages like Windows Server
Matthias Dieter Wallnöfer [Thu, 30 Jul 2009 10:41:06 +0000 (12:41 +0200)]
s4: Enhances the LDAP server to display error messages like Windows Server

Those error messages also include the WERROR code of the failed operation(s) in this
manner: <error code eight chars in HEX>: <further error message>

This also addresses bug #4949

13 years agoAdds new error codes (needed for enhancing error messages for SAMBA 4 AD LDAP server)
Matthias Dieter Wallnöfer [Thu, 30 Jul 2009 10:40:14 +0000 (12:40 +0200)]
Adds new error codes (needed for enhancing error messages for SAMBA 4 AD LDAP server)

13 years agoSlightly restructure the async winbind request calling convention
Volker Lendecke [Fri, 31 Jul 2009 14:16:24 +0000 (16:16 +0200)]
Slightly restructure the async winbind request calling convention

The main loop now allocates the response, this has to be done everywhere