ira/wip.git
8 years agomidltests: add examples of toplevel vs. embedded unions with global 'ms_union'
Stefan Metzmacher [Mon, 31 Jan 2011 13:36:24 +0000 (14:36 +0100)]
midltests: add examples of toplevel vs. embedded unions with global 'ms_union'

metze

8 years agomidltests: add examples of toplevel vs. embedded unions without 'ms_union'
Stefan Metzmacher [Mon, 31 Jan 2011 13:36:24 +0000 (14:36 +0100)]
midltests: add examples of toplevel vs. embedded unions without 'ms_union'

metze

8 years agomidltests: more union alignment example with ms_union
Stefan Metzmacher [Mon, 31 Jan 2011 11:14:45 +0000 (12:14 +0100)]
midltests: more union alignment example with ms_union

metze

8 years agomidltests: more union alignment example without ms_union
Stefan Metzmacher [Mon, 31 Jan 2011 11:13:28 +0000 (12:13 +0100)]
midltests: more union alignment example without ms_union

metze

8 years agomidltests: union alignment with enum as switch_type and 'ms_union'
Stefan Metzmacher [Mon, 31 Jan 2011 11:05:43 +0000 (12:05 +0100)]
midltests: union alignment with enum as switch_type and 'ms_union'

metze

8 years agomidltests: union alignment with enum as switch_type
Stefan Metzmacher [Mon, 31 Jan 2011 11:04:39 +0000 (12:04 +0100)]
midltests: union alignment with enum as switch_type

metze

8 years agomidltests: unions with enum vs. long
Stefan Metzmacher [Mon, 31 Jan 2011 10:50:01 +0000 (11:50 +0100)]
midltests: unions with enum vs. long

metze

8 years agomidltests: 'ms_unions' with enum vs. long
Stefan Metzmacher [Mon, 31 Jan 2011 10:47:07 +0000 (11:47 +0100)]
midltests: 'ms_unions' with enum vs. long

metze

8 years agomidltests: explore 'ms_union' option.
Stefan Metzmacher [Mon, 31 Jan 2011 10:35:43 +0000 (11:35 +0100)]
midltests: explore 'ms_union' option.

metze

8 years agos3:lib/events: use DLIST_DEMOTE() for fd events
Stefan Metzmacher [Mon, 24 Jan 2011 07:47:12 +0000 (08:47 +0100)]
s3:lib/events: use DLIST_DEMOTE() for fd events

This makes sure that fd events doesn't dry out,
because a fd with a lower number is busy.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Jan 31 16:59:44 CET 2011 on sn-devel-104

8 years agos3:smbd: let smbd_server_connection_loop_once() check for select errors
Stefan Metzmacher [Mon, 24 Jan 2011 08:00:53 +0000 (09:00 +0100)]
s3:smbd: let smbd_server_connection_loop_once() check for select errors

metze

8 years agos3:lib/events: don't loop over fd events is select gave -1
Stefan Metzmacher [Mon, 24 Jan 2011 07:57:47 +0000 (08:57 +0100)]
s3:lib/events: don't loop over fd events is select gave -1

metze

8 years agoRevert "s3: Fix starving the echo responder"
Stefan Metzmacher [Mon, 24 Jan 2011 07:56:56 +0000 (08:56 +0100)]
Revert "s3: Fix starving the echo responder"

This reverts commit d5cf6482ed0cd9a11448ca04944b2e01200a7c89.

I'll add a more generic fix for this problem.

metze

8 years agoRevert "s3:events: Call all ready fd event handlers on each iteration of the main...
Stefan Metzmacher [Mon, 24 Jan 2011 07:47:38 +0000 (08:47 +0100)]
Revert "s3:events: Call all ready fd event handlers on each iteration of the main loop"

This reverts commit 455fccf86b6544cd17a2571c63a88f8aebff3f74.

I'll add a more generic fix for this problem.

metze

8 years agos4-smbtorture: add samr_changepassworduser3 ndr torture tests.
Günther Deschner [Mon, 31 Jan 2011 13:19:25 +0000 (14:19 +0100)]
s4-smbtorture: add samr_changepassworduser3 ndr torture tests.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Jan 31 16:07:14 CET 2011 on sn-devel-104

8 years agos4-smbtorture: make it more obvious this are w2k dumps in netlogon ndr test.
Günther Deschner [Mon, 31 Jan 2011 14:13:09 +0000 (15:13 +0100)]
s4-smbtorture: make it more obvious this are w2k dumps in netlogon ndr test.

Guenther

8 years agos3-waf: On FreeBSD, compile zfsacl if sunacl.h is around.
Günther Deschner [Mon, 31 Jan 2011 08:38:21 +0000 (09:38 +0100)]
s3-waf: On FreeBSD, compile zfsacl if sunacl.h is around.

Volker, please check.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Jan 31 10:51:10 CET 2011 on sn-devel-104

8 years agonsswitch: libwbclient has vnum 1 now.
Günther Deschner [Fri, 28 Jan 2011 17:33:41 +0000 (18:33 +0100)]
nsswitch: libwbclient has vnum 1 now.

Michael, please check.

Guenther

8 years agos3-waf: these libs are not private libs.
Günther Deschner [Fri, 28 Jan 2011 17:31:41 +0000 (18:31 +0100)]
s3-waf: these libs are not private libs.

Guenther

8 years agos4:auth/pyauth.c - temporarily add compatibility code for Python 2.4
Matthias Dieter Wallnöfer [Sun, 30 Jan 2011 16:55:41 +0000 (17:55 +0100)]
s4:auth/pyauth.c - temporarily add compatibility code for Python 2.4

This patch has been commited by request of Jelmer.

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sun Jan 30 19:07:57 CET 2011 on sn-devel-104

8 years agolibrpc/rpc: add dcerpc_fault_to_nt_status() mapping from DCERPC_FAULT_SEC_PKG_ERROR
Stefan Metzmacher [Sun, 30 Jan 2011 16:34:35 +0000 (17:34 +0100)]
librpc/rpc: add dcerpc_fault_to_nt_status() mapping from DCERPC_FAULT_SEC_PKG_ERROR

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sun Jan 30 18:24:04 CET 2011 on sn-devel-104

8 years agodcerpc.idl: add DCERPC_FAULT_SEC_PKG_ERROR
Stefan Metzmacher [Sun, 30 Jan 2011 16:34:11 +0000 (17:34 +0100)]
dcerpc.idl: add DCERPC_FAULT_SEC_PKG_ERROR

metze

8 years agos4:libcli/util: display NT_STATUS_RPC_SEC_PKG_ERROR in error strings
Stefan Metzmacher [Sun, 30 Jan 2011 16:33:48 +0000 (17:33 +0100)]
s4:libcli/util: display NT_STATUS_RPC_SEC_PKG_ERROR in error strings

metze

8 years agos3:libsmb: display NT_STATUS_RPC_SEC_PKG_ERROR in error strings
Stefan Metzmacher [Sun, 30 Jan 2011 16:33:13 +0000 (17:33 +0100)]
s3:libsmb: display NT_STATUS_RPC_SEC_PKG_ERROR in error strings

metze

8 years agolibcli/util: add NT_STATUS_RPC_SEC_PKG_ERROR define
Stefan Metzmacher [Sun, 30 Jan 2011 16:32:19 +0000 (17:32 +0100)]
libcli/util: add NT_STATUS_RPC_SEC_PKG_ERROR define

metze

8 years agos3:net registry: ignore WERR_BADFILE when --force is given in deletekey[_recursive]
Michael Adam [Sun, 30 Jan 2011 12:49:14 +0000 (13:49 +0100)]
s3:net registry: ignore WERR_BADFILE when --force is given in deletekey[_recursive]

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Sun Jan 30 14:53:13 CET 2011 on sn-devel-104

8 years agos3:registry: in deletekey_recursive, fix return code upon error.
Michael Adam [Sun, 30 Jan 2011 12:44:31 +0000 (13:44 +0100)]
s3:registry: in deletekey_recursive, fix return code upon error.

correctly keep the werr from inside the transaction when the opearation
inside the transaction fails.

What is the correct behaviour if the cancel operation fails?

8 years agos3:net registry: fix a debug message.
Michael Adam [Sun, 30 Jan 2011 11:33:13 +0000 (12:33 +0100)]
s3:net registry: fix a debug message.

8 years agos3:net registry: fix a debug message.
Michael Adam [Sun, 30 Jan 2011 11:21:31 +0000 (12:21 +0100)]
s3:net registry: fix a debug message.

8 years agos3: On FreeBSD, compile zfsacl if sunacl.h is around
Volker Lendecke [Sat, 29 Jan 2011 08:19:54 +0000 (09:19 +0100)]
s3: On FreeBSD, compile zfsacl if sunacl.h is around

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Jan 30 12:17:49 CET 2011 on sn-devel-104

8 years agos3: Make _lp_maxprotocol static
Volker Lendecke [Sat, 29 Jan 2011 14:20:41 +0000 (15:20 +0100)]
s3: Make _lp_maxprotocol static

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Jan 29 16:07:28 CET 2011 on sn-devel-104

8 years agos3: Remove an unneeded check
Volker Lendecke [Sat, 29 Jan 2011 13:07:59 +0000 (14:07 +0100)]
s3: Remove an unneeded check

In many other places we already assume that if asprintf returns !=-1 then the
result is allocated.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Jan 29 15:00:09 CET 2011 on sn-devel-104

8 years agos3: inline get_uid_from_state
Volker Lendecke [Fri, 28 Jan 2011 18:07:40 +0000 (19:07 +0100)]
s3: inline get_uid_from_state

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Jan 28 23:38:16 CET 2011 on sn-devel-104

8 years agos3: Lift winbindd_cli_state from fillup_password_policy
Volker Lendecke [Fri, 28 Jan 2011 18:05:37 +0000 (19:05 +0100)]
s3: Lift winbindd_cli_state from fillup_password_policy

8 years agos3: Do not use state->mem_ctx in fillup_password_policy
Volker Lendecke [Fri, 28 Jan 2011 18:04:04 +0000 (19:04 +0100)]
s3: Do not use state->mem_ctx in fillup_password_policy

8 years agos3: Lift winbindd_cli_state from winbindd_dual_pam_auth_samlogon
Volker Lendecke [Sat, 11 Dec 2010 10:54:18 +0000 (11:54 +0100)]
s3: Lift winbindd_cli_state from winbindd_dual_pam_auth_samlogon

8 years agos3: Lift winbindd_cli_state from winbindd_raw_kerberos_login
Volker Lendecke [Sat, 11 Dec 2010 09:41:38 +0000 (10:41 +0100)]
s3: Lift winbindd_cli_state from winbindd_raw_kerberos_login

8 years agoWe need to reply to SMB2_GETINFO_FILE with a class of SMB2_FILE_STANDARD_INFO on...
Jeremy Allison [Fri, 28 Jan 2011 21:07:08 +0000 (13:07 -0800)]
We need to reply to SMB2_GETINFO_FILE with a class of SMB2_FILE_STANDARD_INFO on an IPC$ share.

Otherwise a Win7 client issues this request twice (2xroundtrips)
if we return NOT_SUPPORTED. We do the same for SMB1 in call_trans2qpipeinfo()

Jeremy.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Jan 28 22:53:18 CET 2011 on sn-devel-104

8 years agos3-net: use struct based dcerpc_spoolss_EnumPrinterData_r() call.
Günther Deschner [Fri, 28 Jan 2011 17:17:00 +0000 (18:17 +0100)]
s3-net: use struct based dcerpc_spoolss_EnumPrinterData_r() call.

This is a workaround for a string issue we currently have with argument based
generated dcerpc client code (see bug #7804 for details).

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jan 28 22:05:20 CET 2011 on sn-devel-104

8 years agos3-rpcclient: use struct based dcerpc_spoolss_EnumPrinterData_r() call.
Günther Deschner [Fri, 28 Jan 2011 17:07:07 +0000 (18:07 +0100)]
s3-rpcclient: use struct based dcerpc_spoolss_EnumPrinterData_r() call.

This is a workaround for a string issue we currently have with argument based
generated dcerpc client code (see bug #7804 for details).

Guenther

8 years agos4-smbtorture: add (disabled) ndr torture test to check for a w2k samlogon reply...
Günther Deschner [Fri, 28 Jan 2011 14:33:51 +0000 (15:33 +0100)]
s4-smbtorture: add (disabled) ndr torture test to check for a w2k samlogon reply we can't currently parse.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jan 28 16:23:30 CET 2011 on sn-devel-104

8 years agos4-smbtorture: add NDR tests for netr_LogonSamLogon.
Günther Deschner [Fri, 28 Jan 2011 13:18:31 +0000 (14:18 +0100)]
s4-smbtorture: add NDR tests for netr_LogonSamLogon.

Guenther

8 years agos4-acl: Fixed returning uninitialized ldap error in case of some critical errors.
Nadezhda Ivanova [Fri, 28 Jan 2011 09:58:14 +0000 (11:58 +0200)]
s4-acl: Fixed returning uninitialized ldap error in case of some critical errors.

Autobuild-User: Nadezhda Ivanova <nivanova@samba.org>
Autobuild-Date: Fri Jan 28 12:04:01 CET 2011 on sn-devel-104

8 years agos3-rpc_client: remove some more obsolete cli_X.h header files.
Günther Deschner [Fri, 28 Jan 2011 09:31:39 +0000 (10:31 +0100)]
s3-rpc_client: remove some more obsolete cli_X.h header files.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jan 28 11:18:44 CET 2011 on sn-devel-104

8 years agodocs: update wbinfo manpage: remove documentation of removed parameters
Michael Adam [Thu, 27 Jan 2011 22:47:44 +0000 (23:47 +0100)]
docs: update wbinfo manpage: remove documentation of removed parameters

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Fri Jan 28 02:09:09 CET 2011 on sn-devel-104

8 years agoAdd delete-ln test now we can correctly delete hardlinks.
Jeremy Allison [Thu, 27 Jan 2011 23:37:25 +0000 (15:37 -0800)]
Add delete-ln test now we can correctly delete hardlinks.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Jan 28 01:24:19 CET 2011 on sn-devel-104

8 years agoChange "security=share" to downgrade to SMB1 from SMB2, rather than trying to fake it.
Jeremy Allison [Thu, 27 Jan 2011 23:00:14 +0000 (15:00 -0800)]
Change "security=share" to downgrade to SMB1 from SMB2, rather than trying to fake it.

8 years agolibwbclient: bump the libwbclient SOVER 0 -> 1 due to ABI changes
Michael Adam [Thu, 27 Jan 2011 22:11:42 +0000 (23:11 +0100)]
libwbclient: bump the libwbclient SOVER 0 -> 1 due to ABI changes

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Fri Jan 28 00:25:11 CET 2011 on sn-devel-104

8 years agolibwbclient: bump version to 0.6 -> 1.0 due to ABI change (removed symbols)
Michael Adam [Thu, 27 Jan 2011 21:00:33 +0000 (22:00 +0100)]
libwbclient: bump version to 0.6 -> 1.0 due to ABI change (removed symbols)

8 years agolibwbclient: remove wbcSetGidHwm() - not implemented any more
Michael Adam [Thu, 27 Jan 2011 20:54:25 +0000 (21:54 +0100)]
libwbclient: remove wbcSetGidHwm() - not implemented any more

8 years agolibwbclient: remove wbcSetUidHwm() - not implemented any more
Michael Adam [Thu, 27 Jan 2011 20:54:25 +0000 (21:54 +0100)]
libwbclient: remove wbcSetUidHwm() - not implemented any more

8 years agolibwbclient: remove wbcRemoveGidMapping() - not implemented any more
Michael Adam [Thu, 27 Jan 2011 20:54:25 +0000 (21:54 +0100)]
libwbclient: remove wbcRemoveGidMapping() - not implemented any more

8 years agolibwbclient: remove wbcRemoveUidMapping() - not implemented any more
Michael Adam [Thu, 27 Jan 2011 20:54:25 +0000 (21:54 +0100)]
libwbclient: remove wbcRemoveUidMapping() - not implemented any more

8 years agolibwbclient: remove wbcSetGidMapping() - not implemented any more
Michael Adam [Thu, 27 Jan 2011 20:54:25 +0000 (21:54 +0100)]
libwbclient: remove wbcSetGidMapping() - not implemented any more

8 years agolibwbclient: remove wbcSetUidMapping() - not implemented any more
Michael Adam [Thu, 27 Jan 2011 20:54:25 +0000 (21:54 +0100)]
libwbclient: remove wbcSetUidMapping() - not implemented any more

8 years agolibwbclient: remove two unused defines
Michael Adam [Thu, 27 Jan 2011 20:46:12 +0000 (21:46 +0100)]
libwbclient: remove two unused defines

8 years agowbinfo: remove --remove-gid-mapping - winbindd does not implement that any more.
Michael Adam [Wed, 26 Jan 2011 21:00:22 +0000 (22:00 +0100)]
wbinfo: remove --remove-gid-mapping - winbindd does not implement that any more.

8 years agowbinfo: remove --remove-uid-mapping - winbindd does not implement that any more.
Michael Adam [Wed, 26 Jan 2011 21:00:22 +0000 (22:00 +0100)]
wbinfo: remove --remove-uid-mapping - winbindd does not implement that any more.

8 years agowbinfo: remove --set-gid-mapping - winbindd does not implement that any more.
Michael Adam [Wed, 26 Jan 2011 21:00:22 +0000 (22:00 +0100)]
wbinfo: remove --set-gid-mapping - winbindd does not implement that any more.

8 years agowbinfo: remove --set-uid-mapping - winbindd does not implement that any more.
Michael Adam [Wed, 26 Jan 2011 21:00:22 +0000 (22:00 +0100)]
wbinfo: remove --set-uid-mapping - winbindd does not implement that any more.

8 years agos3:registry: fix comments in regdb_store_regdb_version()
Michael Adam [Mon, 24 Jan 2011 16:37:33 +0000 (17:37 +0100)]
s3:registry: fix comments in regdb_store_regdb_version()

8 years agos4-torture: Reorder the epmapper tests.
Andreas Schneider [Wed, 26 Jan 2011 13:18:15 +0000 (14:18 +0100)]
s4-torture: Reorder the epmapper tests.

It works like a stack!

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Jan 27 15:28:05 CET 2011 on sn-devel-104

8 years agos4-torture: Added a full epm_Map test.
Andreas Schneider [Tue, 25 Jan 2011 17:49:32 +0000 (18:49 +0100)]
s4-torture: Added a full epm_Map test.

8 years agos4-torture: Added a test_Insert for epmapper.
Andreas Schneider [Tue, 25 Jan 2011 21:51:26 +0000 (22:51 +0100)]
s4-torture: Added a test_Insert for epmapper.

8 years agos4-torture: Use binding handle in epm_Delete test.
Andreas Schneider [Tue, 25 Jan 2011 21:50:42 +0000 (22:50 +0100)]
s4-torture: Use binding handle in epm_Delete test.

8 years agos4-torture: Comment out the test_InqObject.
Andreas Schneider [Tue, 18 Jan 2011 15:42:34 +0000 (16:42 +0100)]
s4-torture: Comment out the test_InqObject.

8 years agos4-torture: Added a clean test_Map_simple.
Andreas Schneider [Wed, 12 Jan 2011 16:41:05 +0000 (17:41 +0100)]
s4-torture: Added a clean test_Map_simple.

8 years agos4-torture: Added a clean test_Lookup_terminate_search.
Andreas Schneider [Fri, 24 Dec 2010 09:35:47 +0000 (10:35 +0100)]
s4-torture: Added a clean test_Lookup_terminate_search.

8 years agos4-torture: Added a clean test_Lookup_simple.
Andreas Schneider [Thu, 23 Dec 2010 19:57:28 +0000 (20:57 +0100)]
s4-torture: Added a clean test_Lookup_simple.

8 years agos4-torture: Added test_LookupHandleFree.
Andreas Schneider [Thu, 23 Dec 2010 12:07:39 +0000 (13:07 +0100)]
s4-torture: Added test_LookupHandleFree.

8 years agos4-torture: Start with a clean epm_Insert_noreplace test.
Andreas Schneider [Tue, 5 Oct 2010 09:17:31 +0000 (11:17 +0200)]
s4-torture: Start with a clean epm_Insert_noreplace test.

8 years agos4-selftest: Mark epmapper as knownfail.
Andreas Schneider [Wed, 26 Jan 2011 09:01:26 +0000 (10:01 +0100)]
s4-selftest: Mark epmapper as knownfail.

8 years agoidl: Added missing endpoint mapper defines.
Andreas Schneider [Tue, 5 Oct 2010 13:32:54 +0000 (15:32 +0200)]
idl: Added missing endpoint mapper defines.

[MS-RPCE] 2.2.1.2.4 ept_lookup Method

8 years agolibrpc: Added support to accept netbios names.
Andreas Schneider [Tue, 4 Jan 2011 09:11:09 +0000 (10:11 +0100)]
librpc: Added support to accept netbios names.

If we have a NCACN_NP pipe, the binding host is the netbios name an not
an IP address.

8 years agos3-build: remove another leftover of -I../source4.
Günther Deschner [Tue, 25 Jan 2011 11:10:25 +0000 (12:10 +0100)]
s3-build: remove another leftover of -I../source4.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Jan 27 13:30:30 CET 2011 on sn-devel-104

8 years agoLooking into printer driver issues, I ran across some peculiarities in
David Disseldorp [Wed, 26 Jan 2011 22:32:01 +0000 (14:32 -0800)]
Looking into printer driver issues, I ran across some peculiarities in
copy_file():
- Firstly, if the source file is zero bytes, NT_STATUS_DISK_FULL is
  returned.
- Secondly, the conditional lseek is confusing. It fires when
  OPENX_FILE_EXISTS_OPEN is set and I can't see why the lseek is
  necessary in this case.
- Finally, the lseek error path also results in NT_STATUS_DISK_FULL.

Proposed fix for first and third point below.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Jan 27 00:59:56 CET 2011 on sn-devel-104

8 years agos3-utils: Fixed a resource leak in net_afs.
Andreas Schneider [Wed, 19 Jan 2011 22:15:21 +0000 (23:15 +0100)]
s3-utils: Fixed a resource leak in net_afs.

s3-utils: Fixed a resource leak in net_afs.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Jan 27 00:12:47 CET 2011 on sn-devel-104

8 years agos3-utils: Fixed a resource leak in smbta-util.
Andreas Schneider [Wed, 19 Jan 2011 22:13:47 +0000 (23:13 +0100)]
s3-utils: Fixed a resource leak in smbta-util.

s3-utils: Fixed a resource leak in smbta-util.

8 years agos3-utils: Fixed possible resource leak in net_usershare.
Andreas Schneider [Wed, 19 Jan 2011 22:07:33 +0000 (23:07 +0100)]
s3-utils: Fixed possible resource leak in net_usershare.

s3-utils: Fixed possible resource leak in net_usershare.

8 years agos3-utils: Fixed possible resource leak in smbget.
Andreas Schneider [Wed, 19 Jan 2011 14:18:10 +0000 (15:18 +0100)]
s3-utils: Fixed possible resource leak in smbget.

s3-utils: Fixed possible resource leak in smbget.

8 years agos3-utils: Fixed possible resource leak in smbfilter.
Andreas Schneider [Wed, 19 Jan 2011 14:20:34 +0000 (15:20 +0100)]
s3-utils: Fixed possible resource leak in smbfilter.

s3-utils: Fixed possible resource leak in smbfilter.

8 years agos3-modules: Fixed the for-loop code block.
Andreas Schneider [Wed, 19 Jan 2011 22:11:32 +0000 (23:11 +0100)]
s3-modules: Fixed the for-loop code block.

s3-modules: Fixed the for-loop code block.

8 years agos3-lib: Fixed a missing return value in tldap.
Andreas Schneider [Wed, 19 Jan 2011 22:04:13 +0000 (23:04 +0100)]
s3-lib: Fixed a missing return value in tldap.

s3-lib: Fixed a missing return value in tldap.

8 years agoerrormap: Add unix_to_werror() function
Kai Blin [Wed, 26 Jan 2011 21:17:43 +0000 (22:17 +0100)]
errormap: Add unix_to_werror() function

While this function technically is closest to the
map_nt_status_from_unix() function, I think it is better to keep the new
function in line with our usual fooerror_to_barerror() naming scheme.

Signed-off-by: Kai Blin <kai@samba.org>
Autobuild-User: Kai Blin <kai@samba.org>
Autobuild-Date: Wed Jan 26 23:07:24 CET 2011 on sn-devel-104

8 years agoAllow "security = share" with SMB2. We already handle this in smb2/smb2_server.c
Jeremy Allison [Wed, 26 Jan 2011 18:50:44 +0000 (10:50 -0800)]
Allow "security = share" with SMB2. We already handle this in smb2/smb2_server.c

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Jan 26 20:37:29 CET 2011 on sn-devel-104

8 years agoFrom Metze - make sure we're using the same string length for the hash.
Jeremy Allison [Wed, 26 Jan 2011 16:43:43 +0000 (08:43 -0800)]
From Metze - make sure we're using the same string length for the hash.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Jan 26 18:32:15 CET 2011 on sn-devel-104

8 years agos3-winbind: share a common winbind_samlogon_retry_loop().
Günther Deschner [Mon, 24 Jan 2011 19:52:24 +0000 (20:52 +0100)]
s3-winbind: share a common winbind_samlogon_retry_loop().

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Jan 26 12:41:14 CET 2011 on sn-devel-104

8 years agoRevert "s3: These assignments are overwritten immediately"
Günther Deschner [Mon, 24 Jan 2011 19:45:35 +0000 (20:45 +0100)]
Revert "s3: These assignments are overwritten immediately"

This reverts commit 18962ea3852d0d0fc7371e99813bebd54fae0a19.

8 years agoRevert "s3-winbind: fix winbindd_dual_pam_auth_samlogon() for NT4 domains."
Günther Deschner [Mon, 24 Jan 2011 19:43:56 +0000 (20:43 +0100)]
Revert "s3-winbind: fix winbindd_dual_pam_auth_samlogon() for NT4 domains."

This reverts commit cea36aeacf8778493463f31e6afc3f58384639e2.

8 years agopidl:Typelist: fix perl warnings about recursiv function calls
Stefan Metzmacher [Wed, 26 Jan 2011 07:48:34 +0000 (08:48 +0100)]
pidl:Typelist: fix perl warnings about recursiv function calls

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Jan 26 10:59:04 CET 2011 on sn-devel-104

8 years agopidl:Samba3/ServerNDR: correctly initialise ndr_push struct
Stefan Metzmacher [Tue, 25 Jan 2011 18:46:18 +0000 (19:46 +0100)]
pidl:Samba3/ServerNDR: correctly initialise ndr_push struct

We need to copy the ptr_count from the ndr_pull struct to the ndr_push struct,
otherwise we'll reuse full pointer ids, which will cause the client to
fail in the ndr unmarshalling.

metze

8 years agoMissed one debug printf of name_hash. Ensure always use %x.
Jeremy Allison [Tue, 25 Jan 2011 22:59:44 +0000 (14:59 -0800)]
Missed one debug printf of name_hash. Ensure always use %x.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Jan 26 00:46:28 CET 2011 on sn-devel-104

8 years agoFix bug #7863 - Unlink may unlink wrong file when hardlinks are involved.
Jeremy Allison [Tue, 25 Jan 2011 22:23:19 +0000 (14:23 -0800)]
Fix bug #7863 - Unlink may unlink wrong file when hardlinks are involved.

Do this by keeping a linked list of delete on close tokens, one for
each filename that identifies a path to the dev/inode. Use the
jenkins hash of the pathname to identify the correct token.

8 years agoAdd uint32_t name_hash argument (currently unused) to get_file_infos().
Jeremy Allison [Tue, 25 Jan 2011 21:57:38 +0000 (13:57 -0800)]
Add uint32_t name_hash argument (currently unused) to get_file_infos().

Will be used when we store more than one delete on close token.

8 years agoAdd name_hash into the share mode entry struct (as yet only use for renames to identi...
Jeremy Allison [Tue, 25 Jan 2011 22:01:52 +0000 (14:01 -0800)]
Add name_hash into the share mode entry struct (as yet only use for renames to identify a specific path).

8 years agoAdd name_hash to files_struct. Set within fsp_set_smb_fname().
Jeremy Allison [Tue, 25 Jan 2011 21:49:01 +0000 (13:49 -0800)]
Add name_hash to files_struct. Set within fsp_set_smb_fname().

8 years agos4-test/delete_object: Remove global ldb connections
Kamen Mazdrashki [Sat, 22 Jan 2011 01:22:48 +0000 (03:22 +0200)]
s4-test/delete_object: Remove global ldb connections

Make it more xUnit compliant

Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Tue Jan 25 21:30:19 CET 2011 on sn-devel-104

8 years agos4:ldap.py - check the write protection on LSA objects
Matthias Dieter Wallnöfer [Mon, 17 Jan 2011 12:52:00 +0000 (13:52 +0100)]
s4:ldap.py - check the write protection on LSA objects

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Jan 25 13:09:41 CET 2011 on sn-devel-104

8 years agos4:dsdb/samdb/ldb_modules/objectclass.c - move LSA specific object checks into "objec...
Matthias Dieter Wallnöfer [Tue, 21 Dec 2010 11:24:30 +0000 (12:24 +0100)]
s4:dsdb/samdb/ldb_modules/objectclass.c - move LSA specific object checks into "objectclass_attrs" LDB module

LSA object classes are protected on both LDAP add and LDAP modify
operations, so I've refactored the previous check in the objectclass LDB
module only for LDAP adds in a new one in the objectclass_attrs LDB
module for both adds and modifies.
This is the result of the investigations done by Hongwei Sun and I in
the last months.
Interestingly these protection mechansim doesn't apply on LDAP deletes!

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
8 years agoidl: add file_id idl.
Günther Deschner [Tue, 25 Jan 2011 01:42:59 +0000 (02:42 +0100)]
idl: add file_id idl.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Jan 25 12:27:00 CET 2011 on sn-devel-104