ira/wip.git
12 years agos3:registry: prevent unnecessary transactions in regdb_init
Michael Adam [Wed, 9 Nov 2011 10:14:38 +0000 (11:14 +0100)]
s3:registry: prevent unnecessary transactions in regdb_init

Skip the transaction for the upgrade code, if the database
is already at code-level.

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed Nov  9 15:06:59 CET 2011 on sn-devel-104

12 years agos3: Use autotools to set the winbind socket directory.
Andreas Schneider [Wed, 9 Nov 2011 10:33:47 +0000 (11:33 +0100)]
s3: Use autotools to set the winbind socket directory.

Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Wed Nov  9 13:31:27 CET 2011 on sn-devel-104

12 years agos3:smb2_server: grant credits in async interim responses (bug #8357)
Stefan Metzmacher [Tue, 8 Nov 2011 16:50:43 +0000 (17:50 +0100)]
s3:smb2_server: grant credits in async interim responses (bug #8357)

The first fix for bug #8357 intruduced a regression, so that we no
longer grant credits for real async interim responses with
STATUS_PENDING.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Nov  9 11:56:29 CET 2011 on sn-devel-104

12 years agos3:libsmb: consistently use state->size in cli_write_andx_create() (bug #5326)
Stefan Metzmacher [Wed, 9 Nov 2011 07:09:17 +0000 (08:09 +0100)]
s3:libsmb: consistently use state->size in cli_write_andx_create() (bug #5326)

Otherwise we may get unexpected results.

This is a fix that was missing in commit 95595dd93fd04999fcf56ecaab7c29b064d021f8
(s3:libsmb: fix cli_write_and_x() against OS/2 print shares (bug #5326))

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Nov  9 10:13:32 CET 2011 on sn-devel-104

12 years agos4-provision: Create ldap records for DNS partitions similar to windows
Amitay Isaacs [Tue, 20 Sep 2011 07:33:20 +0000 (17:33 +1000)]
s4-provision: Create ldap records for DNS partitions similar to windows

this allows easy comparison between windows and samba ldap trees

Autobuild-User: Amitay Isaacs <amitay@samba.org>
Autobuild-Date: Wed Nov  9 08:27:46 CET 2011 on sn-devel-104

12 years agos4-provision: Set security descriptor for DNS records
Amitay Isaacs [Tue, 20 Sep 2011 07:30:10 +0000 (17:30 +1000)]
s4-provision: Set security descriptor for DNS records

12 years agos4:torture:smb2: rewrite durable-open.open test to use smb2_*_create functions
Michael Adam [Tue, 8 Nov 2011 23:22:55 +0000 (00:22 +0100)]
s4:torture:smb2: rewrite durable-open.open test to use smb2_*_create functions

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed Nov  9 02:36:36 CET 2011 on sn-devel-104

12 years agos4:torture:smb2: rewrite the durable-open.lock test to use smb2_lease_create()
Michael Adam [Tue, 8 Nov 2011 21:03:04 +0000 (22:03 +0100)]
s4:torture:smb2: rewrite the durable-open.lock test to use smb2_lease_create()

12 years agos4:torture:smb2: rewrite the durable-open.lease test to use smb2_lease_create()
Michael Adam [Tue, 8 Nov 2011 20:59:18 +0000 (21:59 +0100)]
s4:torture:smb2: rewrite the durable-open.lease test to use smb2_lease_create()

12 years agos4:torture:smb2: rewrite the durable-open.oplock test to use smb2_oplock_create()
Michael Adam [Tue, 8 Nov 2011 17:48:25 +0000 (18:48 +0100)]
s4:torture:smb2: rewrite the durable-open.oplock test to use smb2_oplock_create()

12 years agos4:torture:smb2: rewrite the durable-open.file-position test to use smb2_oplock_create()
Michael Adam [Tue, 8 Nov 2011 17:44:54 +0000 (18:44 +0100)]
s4:torture:smb2: rewrite the durable-open.file-position test to use smb2_oplock_create()

12 years agos4:torture:smb2: rewrite the durable-open.open2 test to use smb2_lease_create_share()
Michael Adam [Tue, 8 Nov 2011 17:39:45 +0000 (18:39 +0100)]
s4:torture:smb2: rewrite the durable-open.open2 test to use smb2_lease_create_share()

12 years agos4:torture:smb2: rewrite the durable-open.open1 test to use smb2_oplock_create_share()
Michael Adam [Tue, 8 Nov 2011 17:31:17 +0000 (18:31 +0100)]
s4:torture:smb2: rewrite the durable-open.open1 test to use smb2_oplock_create_share()

12 years agos4:torture:smb2: add smb2_oplock_create_share() that takes sharemode as parameter
Michael Adam [Tue, 8 Nov 2011 17:22:47 +0000 (18:22 +0100)]
s4:torture:smb2: add smb2_oplock_create_share() that takes sharemode as parameter

12 years agos4:torture:smb2: add smb2_lease_create_share() that takes a sharemode as parameter
Michael Adam [Tue, 8 Nov 2011 17:19:54 +0000 (18:19 +0100)]
s4:torture:smb2: add smb2_lease_create_share() that takes a sharemode as parameter

12 years agos4:torture:smb2: add smb2_generic_create_share() that also takes the sharemode as...
Michael Adam [Tue, 8 Nov 2011 17:15:12 +0000 (18:15 +0100)]
s4:torture:smb2: add smb2_generic_create_share() that also takes the sharemode as parameter

12 years agos4:torture:smb2: move the smb2_create_*() utility functions from lease.c to util...
Michael Adam [Tue, 8 Nov 2011 17:13:41 +0000 (18:13 +0100)]
s4:torture:smb2: move the smb2_create_*() utility functions from lease.c to util.c for re-use

12 years agos4:torture:smb2: use smb2_util_oplock_level() in the durable-open test for convenience
Michael Adam [Tue, 8 Nov 2011 15:34:51 +0000 (16:34 +0100)]
s4:torture:smb2: use smb2_util_oplock_level() in the durable-open test for convenience

12 years agos4:torture:smb2: lease: oplock_level is uint8_t, not uint32_t or int
Michael Adam [Tue, 8 Nov 2011 15:33:56 +0000 (16:33 +0100)]
s4:torture:smb2: lease: oplock_level is uint8_t, not uint32_t or int

12 years agos4:torture:smb2: move oplock() from lease.c to smb2_util_oplock_level() in util.c...
Michael Adam [Tue, 8 Nov 2011 15:26:02 +0000 (16:26 +0100)]
s4:torture:smb2: move oplock() from lease.c to smb2_util_oplock_level() in util.c for re-use

12 years agos4:torture:smb2: extract map_sharemode() to smb2_util_share_access() in util.c
Michael Adam [Tue, 8 Nov 2011 07:34:38 +0000 (08:34 +0100)]
s4:torture:smb2: extract map_sharemode() to smb2_util_share_access() in util.c

12 years agos4:torture:smb2: use common smb2_util_lease_state() in the lease tests
Michael Adam [Tue, 8 Nov 2011 07:12:55 +0000 (08:12 +0100)]
s4:torture:smb2: use common smb2_util_lease_state() in the lease tests

12 years agos4:torture:smb2: extract map_lease() to util.c as smb2_util_lease_state().
Michael Adam [Tue, 8 Nov 2011 07:04:28 +0000 (08:04 +0100)]
s4:torture:smb2: extract map_lease() to util.c as smb2_util_lease_state().

12 years agos4:torture:smb2: fix illegal write/uninitialized data bug in the lease.multibreak...
Michael Adam [Wed, 2 Nov 2011 14:46:49 +0000 (15:46 +0100)]
s4:torture:smb2: fix illegal write/uninitialized data bug in the lease.multibreak test

12 years agos4:torture:smb2: lease.update2: some more reasonable struct names and a comment
Michael Adam [Tue, 1 Nov 2011 22:50:01 +0000 (23:50 +0100)]
s4:torture:smb2: lease.update2: some more reasonable struct names and a comment

12 years agos4:torture:smb2: change the test file name in the durable-open.oplock test
Michael Adam [Tue, 1 Nov 2011 13:55:37 +0000 (14:55 +0100)]
s4:torture:smb2: change the test file name in the durable-open.oplock test

to a more reasonable name. This one must have been copied
from the durable-open.lease test.

12 years agosamr: filterModuleName is a lsa_String in userPwdChangeFailureInformation.
Günther Deschner [Tue, 8 Nov 2011 15:00:10 +0000 (16:00 +0100)]
samr: filterModuleName is a lsa_String in userPwdChangeFailureInformation.

The entire marshalling of samr_ChangePasswordUser3 broke with c2685cdedb430ae75a94e86f34484292b4269363.

Matthias, the bad effect of this change was that actually all failed password
change attempts will always return NT_STATUS_OK because the last 4 bytes (the
resulting status code) were not marshalled anymore.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Nov  9 00:41:13 CET 2011 on sn-devel-104

12 years agos4-smbtorture: demonstrate how broken our samr_ChangePasswordUser3 marshalling is...
Günther Deschner [Tue, 8 Nov 2011 14:58:34 +0000 (15:58 +0100)]
s4-smbtorture: demonstrate how broken our samr_ChangePasswordUser3 marshalling is...

Guenther

12 years agos4:samba-tool user command - always initialise the boolean arguments properly
Matthias Dieter Wallnöfer [Tue, 8 Nov 2011 19:46:25 +0000 (20:46 +0100)]
s4:samba-tool user command - always initialise the boolean arguments properly

It they haven't been specified.

Reviewed-by: Jelmer
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Tue Nov  8 22:28:38 CET 2011 on sn-devel-104

12 years agos4:samba-tool - other fix for Gémes Géza patch regarding parameter handling
Matthias Dieter Wallnöfer [Mon, 7 Nov 2011 16:57:52 +0000 (17:57 +0100)]
s4:samba-tool - other fix for Gémes Géza patch regarding parameter handling

The condition has not been specified correctly since we are expecting a boolean.
Pointed out by Jelmer.

Reviewed-by: Jelmer
12 years agos3:libsmb: fix cli_write_and_x() against OS/2 print shares (bug #5326)
Stefan Metzmacher [Tue, 8 Nov 2011 07:25:16 +0000 (08:25 +0100)]
s3:libsmb: fix cli_write_and_x() against OS/2 print shares (bug #5326)

Print shares doesn't support CAP_LARGE_WRITEX, while it's negotiated
by the file server part.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Nov  8 17:01:36 CET 2011 on sn-devel-104

12 years agos3:libsmb: correctly parse the LANMAN2.1 negprot response from OS/2 (bug #8584)
Stefan Metzmacher [Tue, 8 Nov 2011 07:14:31 +0000 (08:14 +0100)]
s3:libsmb: correctly parse the LANMAN2.1 negprot response from OS/2 (bug #8584)

metze

12 years agos3:libsmb: key_len is 8bit only in the NT1 case
Stefan Metzmacher [Tue, 8 Nov 2011 07:13:27 +0000 (08:13 +0100)]
s3:libsmb: key_len is 8bit only in the NT1 case

metze

12 years agos3: Remove two unused variables
Volker Lendecke [Tue, 8 Nov 2011 07:38:20 +0000 (08:38 +0100)]
s3: Remove two unused variables

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Nov  8 10:14:36 CET 2011 on sn-devel-104

12 years agos4-provision: site is passed as an argument to setup_ad_dns()
Amitay Isaacs [Tue, 8 Nov 2011 02:58:45 +0000 (13:58 +1100)]
s4-provision: site is passed as an argument to setup_ad_dns()

Autobuild-User: Amitay Isaacs <amitay@samba.org>
Autobuild-Date: Tue Nov  8 06:07:46 CET 2011 on sn-devel-104

12 years agos4-provision Remove options for LDAP backend to reduce user confusion
Andrew Bartlett [Thu, 3 Nov 2011 22:07:17 +0000 (09:07 +1100)]
s4-provision Remove options for LDAP backend to reduce user confusion

We do not support the LDAP backend any more, but keep the code in case someone
comes up with an interesting use case that could leverage this in a very
particular situation.  In order to keep the code, we must test it, so
we keep just this much of the support around.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Nov  8 04:33:49 CET 2011 on sn-devel-104

12 years agos4-s3-upgrade Add my copyright
Andrew Bartlett [Tue, 1 Nov 2011 01:59:02 +0000 (12:59 +1100)]
s4-s3-upgrade Add my copyright

12 years agoparam: Remove duplicate initialization of 'share backend' parameter
Amitay Isaacs [Tue, 1 Nov 2011 05:29:41 +0000 (16:29 +1100)]
param: Remove duplicate initialization of 'share backend' parameter

12 years agos4-smb_server No longer follow the security=share smb.conf directive
Andrew Bartlett [Tue, 1 Nov 2011 20:43:43 +0000 (07:43 +1100)]
s4-smb_server No longer follow the security=share smb.conf directive

By ignoring the value of security= from the smb.conf, we can allow this
to instead set the value of 'server role' in a manner compatible
with the Samba 3.x release stream.

Andrew Bartlett

12 years agoselftest: Remove the 'all' environment as it is just too slow to start up
Andrew Bartlett [Sat, 24 Sep 2011 18:26:48 +0000 (11:26 -0700)]
selftest: Remove the 'all' environment as it is just too slow to start up

Instead we start the 'dc' environment, and other environments are available as:
make testenv SELFTEST_TESTENV=fl2003dc

Andrew Bartlett

12 years agos4-dnsserver: Test forward zones are not listed in reverse zone search
Amitay Isaacs [Mon, 7 Nov 2011 03:40:06 +0000 (14:40 +1100)]
s4-dnsserver: Test forward zones are not listed in reverse zone search

Autobuild-User: Amitay Isaacs <amitay@samba.org>
Autobuild-Date: Tue Nov  8 01:26:43 CET 2011 on sn-devel-104

12 years agos4-dnsserver: Fix enumeration of zones in ComplexOperation RPC call
Amitay Isaacs [Thu, 3 Nov 2011 05:59:23 +0000 (16:59 +1100)]
s4-dnsserver: Fix enumeration of zones in ComplexOperation RPC call

zone_request_flags are interpreted in different groups rather than
a single group. This correctly returns 0 zones when there are no
reverse zones and DNS_ZONE_REQUEST_REVERSE is set in zone_request_flags.

12 years agoAdd the SEC_DIR_LIST check to dptr_create().
Jeremy Allison [Fri, 4 Nov 2011 23:46:47 +0000 (16:46 -0700)]
Add the SEC_DIR_LIST check to dptr_create().

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Mon Nov  7 21:11:03 CET 2011 on sn-devel-104

12 years agos4:samba-tool - fix Gémes Géza patch regarding parameter handling
Matthias Dieter Wallnöfer [Mon, 7 Nov 2011 16:57:52 +0000 (17:57 +0100)]
s4:samba-tool - fix Gémes Géza patch regarding parameter handling

The new "random-password" parameter has not been evaluated correctly.

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Mon Nov  7 19:35:05 CET 2011 on sn-devel-104

12 years agoAdd a --random-password option to user create command.
Gémes Géza [Wed, 2 Nov 2011 14:33:35 +0000 (15:33 +0100)]
Add a --random-password option to user create command.

Signed-Off-By: Jelmer Vernooij <jelmer@samba.org>
Signed-off-by: Matthias Dieter Wallnöfer <mdw@samba.org>
12 years agos3-wafbuild: Fix inotify detection (bug 8580)
Björn Baumbach [Mon, 7 Nov 2011 13:24:40 +0000 (14:24 +0100)]
s3-wafbuild: Fix inotify detection (bug 8580)

Enable inotify if sys or kernel inotify is available.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Nov  7 16:28:38 CET 2011 on sn-devel-104

12 years agos3-build: Fix inotify detection (bug 8580)
Björn Baumbach [Mon, 7 Nov 2011 11:42:28 +0000 (12:42 +0100)]
s3-build: Fix inotify detection (bug 8580)

Enable inotify if sys or kernel inotify is available.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
12 years agos3:libsmb: return NT_STATUS_OK for if a request is not the last one in the chain
Stefan Metzmacher [Mon, 7 Nov 2011 07:55:20 +0000 (08:55 +0100)]
s3:libsmb: return NT_STATUS_OK for if a request is not the last one in the chain

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Nov  7 11:38:05 CET 2011 on sn-devel-104

12 years agos3:libsmb: make sure have_andx_command() returns false for non AndX commands
Stefan Metzmacher [Mon, 7 Nov 2011 07:54:40 +0000 (08:54 +0100)]
s3:libsmb: make sure have_andx_command() returns false for non AndX commands

metze

12 years agos3:libsmb: remember the seqnum on all chained requests
Stefan Metzmacher [Mon, 7 Nov 2011 07:44:39 +0000 (08:44 +0100)]
s3:libsmb: remember the seqnum on all chained requests

This is needed in order to verify the incoming signature
correctly.

metze

12 years agos3:libsmb: get cmd of the chained request before changing wct_ofs
Stefan Metzmacher [Sat, 5 Nov 2011 11:29:23 +0000 (12:29 +0100)]
s3:libsmb: get cmd of the chained request before changing wct_ofs

metze

12 years agos4: samba-tool user --help documenation improvements
Theresa Halloran [Wed, 2 Nov 2011 14:33:12 +0000 (10:33 -0400)]
s4: samba-tool user --help documenation improvements
Signed-off-by: Theresa Halloran <thallora@linux.vnet.ibm.com>
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Mon Nov  7 01:39:25 CET 2011 on sn-devel-104

12 years agokcc: fixed program name
Andrew Tridgell [Sun, 6 Nov 2011 22:55:01 +0000 (09:55 +1100)]
kcc: fixed program name

kcccompute -> samba_kcc

12 years agokcc: fixed tabs/spaces in kcc python implementation
Andrew Tridgell [Sun, 6 Nov 2011 22:53:06 +0000 (09:53 +1100)]
kcc: fixed tabs/spaces in kcc python implementation

as spotted by autobuild

12 years agosamba_kcc addtion
Dave Craft [Thu, 3 Nov 2011 17:39:53 +0000 (12:39 -0500)]
samba_kcc addtion

Scaffolding and initial implementations of
portions of the KCC in python.  This code currently
properly computes the graph nodes for the intrasite
topology as well as enumerating all steps for a full
run of the KCC.

Signed-off-by: Andrew Tridgell <tridge@samba.org>
12 years agoadd python KCC utility classes and methods
Dave Craft [Thu, 3 Nov 2011 17:37:24 +0000 (12:37 -0500)]
add python KCC utility classes and methods

New file source4/scripting/python/samba/kcc_utils.py
contains classes and methods for:
   DirectoryServiceAgent
   NTDSConnection
   GraphNode
   NamingContext
   NCReplica
These are consumed by a new samba_kcc python script
for KCC topology computation

Signed-off-by: Andrew Tridgell <tridge@samba.org>
12 years agopython dsdb flag addtions (NTDSSETTINGS, NTDSCONN)
Dave Craft [Thu, 3 Nov 2011 17:33:38 +0000 (12:33 -0500)]
python dsdb flag addtions (NTDSSETTINGS, NTDSCONN)

Add missing flags present in C code base to python
code base dsdb/pydsdb.c
   INSTANCE_TYPE...
   DS_NTDSSETTINGS_OPT...
   NTDSCONN_OPT...
These are consumed by the python KCC scripts

Signed-off-by: Andrew Tridgell <tridge@samba.org>
12 years agos3:smb2cli: ignore the NBT/Length header in smb2cli_inbuf_parse_compound()
Stefan Metzmacher [Sat, 5 Nov 2011 10:40:02 +0000 (11:40 +0100)]
s3:smb2cli: ignore the NBT/Length header in smb2cli_inbuf_parse_compound()

This is not needed and in future we want to support SMBDirect,
which add a different header.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sun Nov  6 17:17:04 CET 2011 on sn-devel-104

12 years agoSome formatting fixes, remove unused imports.
Jelmer Vernooij [Fri, 4 Nov 2011 16:34:47 +0000 (17:34 +0100)]
Some formatting fixes, remove unused imports.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Nov  6 06:22:33 CET 2011 on sn-devel-104

12 years agos4-resolver: fix bug with DNS servers returning AAAA records when asked for A records
Matthieu Patou [Sat, 5 Nov 2011 23:23:41 +0000 (00:23 +0100)]
s4-resolver: fix bug with DNS servers returning AAAA records when asked for A records

Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Sun Nov  6 03:18:00 CET 2011 on sn-devel-104

12 years agoMove the SEC_DIR_LIST check into dptr_create for SMB2 and now for SMB1.
Jeremy Allison [Fri, 4 Nov 2011 17:51:29 +0000 (10:51 -0700)]
Move the SEC_DIR_LIST check into dptr_create for SMB2 and now for SMB1.

The pathname check still needs fixing.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Nov  5 01:38:00 CET 2011 on sn-devel-104

12 years agocan_write_to_file() does now take share permissions into account. Fix comment.
Jeremy Allison [Fri, 4 Nov 2011 23:01:16 +0000 (16:01 -0700)]
can_write_to_file() does now take share permissions into account. Fix comment.

12 years agoNo longer do the pre-check on DELETE_ACCESS - we're correctly checking the ACL every...
Jeremy Allison [Fri, 4 Nov 2011 22:56:15 +0000 (15:56 -0700)]
No longer do the pre-check on DELETE_ACCESS - we're correctly checking the ACL every time now.

12 years agoRemove can_access_file_acl(). We no longer need this duplicate code (hurrah!).
Jeremy Allison [Fri, 4 Nov 2011 22:55:11 +0000 (15:55 -0700)]
Remove can_access_file_acl(). We no longer need this duplicate code (hurrah!).

12 years agoRemove can_access_file_data() - make it use the standard smbd_check_access_rights...
Jeremy Allison [Fri, 4 Nov 2011 22:45:13 +0000 (15:45 -0700)]
Remove can_access_file_data() - make it use the standard smbd_check_access_rights() instead.

12 years agoAdd const to the smb_filename argument of smbd_check_access_rights().
Jeremy Allison [Fri, 4 Nov 2011 22:39:55 +0000 (15:39 -0700)]
Add const to the smb_filename argument of smbd_check_access_rights().

12 years agoExpose smbd_check_access_rights() to other modules.
Jeremy Allison [Fri, 4 Nov 2011 21:37:26 +0000 (14:37 -0700)]
Expose smbd_check_access_rights() to other modules.

12 years agoRename smbd_check_open_rights() to smbd_check_access_rights() as we're going to remov...
Jeremy Allison [Fri, 4 Nov 2011 21:28:08 +0000 (14:28 -0700)]
Rename smbd_check_open_rights() to smbd_check_access_rights() as we're going to remove the static from this.

12 years agoReplace smb1_file_se_access_check() with just se_access_check().
Jeremy Allison [Fri, 4 Nov 2011 21:21:35 +0000 (14:21 -0700)]
Replace smb1_file_se_access_check() with just se_access_check().

12 years agoMove root check out of smb1_file_se_access_check() in preparation for deleting this...
Jeremy Allison [Fri, 4 Nov 2011 21:07:23 +0000 (14:07 -0700)]
Move root check out of smb1_file_se_access_check() in preparation for deleting this function.

12 years agosmb1_file_se_access_check() is now static to smbd/open.c
Jeremy Allison [Fri, 4 Nov 2011 20:11:01 +0000 (13:11 -0700)]
smb1_file_se_access_check() is now static to smbd/open.c

12 years agoRevert "Change function signature of check_parent_access() to take char * instead...
Jeremy Allison [Thu, 3 Nov 2011 18:49:22 +0000 (11:49 -0700)]
Revert "Change function signature of check_parent_access() to take char * instead of struct smb_filename."

This reverts commit a11c0a41a35aa2b1c14333552045a65e3e50df1e.

Not needed.

12 years agoRevert "Call check_parent_access() on readdir."
Jeremy Allison [Thu, 3 Nov 2011 18:49:05 +0000 (11:49 -0700)]
Revert "Call check_parent_access() on readdir."

This reverts commit a763edaf9c76afe2546c035fc090370301dd347b.

Checking the wrong thing..

12 years agoProperly fix bug #8384 - Windows XP clients seem to crash smbd process every once...
Henry Wong [Fri, 4 Nov 2011 18:20:10 +0000 (11:20 -0700)]
Properly fix bug #8384 - Windows XP clients seem to crash smbd process every once in a while.

Ensure we correctly null out the referenced pointer when we decrease the ref. count.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Nov  4 21:12:13 CET 2011 on sn-devel-104

12 years agos3:docs fix a series of typos in wbinfo manpage
Christian Ambach [Fri, 4 Nov 2011 17:02:30 +0000 (18:02 +0100)]
s3:docs fix a series of typos in wbinfo manpage

s/choide/choice/

Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Fri Nov  4 19:38:53 CET 2011 on sn-devel-104

12 years agos3:docs: some corrections for wbinfo
Christian Ambach [Fri, 4 Nov 2011 16:56:02 +0000 (17:56 +0100)]
s3:docs: some corrections for wbinfo

Parameters for --sid-aliases and --sid-to-fullname were not listed
properly in the SYNOPSIS section

12 years agos3:smbd increase a debug level
Christian Ambach [Fri, 4 Nov 2011 16:34:48 +0000 (17:34 +0100)]
s3:smbd increase a debug level

logging disconnected clients with level 1 swamps the logs

12 years agodns: Fix offset check in ndr_pull_component
Kai Blin [Fri, 30 Sep 2011 02:31:07 +0000 (19:31 -0700)]
dns: Fix offset check in ndr_pull_component

Autobuild-User: Kai Blin <kai@samba.org>
Autobuild-Date: Fri Nov  4 17:25:16 CET 2011 on sn-devel-104

12 years agonbt: Fix offset check in ndr_pull_component
Kai Blin [Fri, 30 Sep 2011 02:30:39 +0000 (19:30 -0700)]
nbt: Fix offset check in ndr_pull_component

12 years agos4 dns: the opcode is called OPCODE_UPDATE in the RFC, not OPCODE_REGISTER
Kai Blin [Wed, 28 Sep 2011 02:51:55 +0000 (19:51 -0700)]
s4 dns: the opcode is called OPCODE_UPDATE in the RFC, not OPCODE_REGISTER

12 years agos4 dns: Handle QCLASS_NONE queries
Kai Blin [Wed, 28 Sep 2011 01:05:38 +0000 (18:05 -0700)]
s4 dns: Handle QCLASS_NONE queries

12 years agos4 dns: Support DNS_QTYPE_ALL queries
Kai Blin [Wed, 28 Sep 2011 00:36:42 +0000 (17:36 -0700)]
s4 dns: Support DNS_QTYPE_ALL queries

12 years agodns: Build the python bindings
Kai Blin [Tue, 27 Sep 2011 05:25:51 +0000 (22:25 -0700)]
dns: Build the python bindings

12 years agos3:smbd: also send the server name in the negprot response
Stefan Metzmacher [Fri, 4 Nov 2011 12:49:05 +0000 (13:49 +0100)]
s3:smbd: also send the server name in the negprot response

This matches W2K (at least sp4) and higher.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Nov  4 15:50:06 CET 2011 on sn-devel-104

12 years agos3:libsmb: also remember the optional server name from the negprot response
Stefan Metzmacher [Fri, 4 Nov 2011 11:59:54 +0000 (12:59 +0100)]
s3:libsmb: also remember the optional server name from the negprot response

W2K (at least sp4) and higher also send the server name.

metze

12 years agos3:libsmb: the workgroup in the non-extended-security negprot is not aligned (#8573)
Stefan Metzmacher [Fri, 4 Nov 2011 11:52:44 +0000 (12:52 +0100)]
s3:libsmb: the workgroup in the non-extended-security negprot is not aligned (#8573)

I've tested the fix against NT4 sp6a, W2K sp4, W2K8R2 and Win8pre0.

metze

12 years agosystemd: Fix dependencies.
Andreas Schneider [Wed, 2 Nov 2011 15:53:27 +0000 (16:53 +0100)]
systemd: Fix dependencies.

Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Fri Nov  4 12:36:04 CET 2011 on sn-devel-104

12 years agos4 provision/dns: Move DNS-related setup to sambadns module
Kai Blin [Fri, 21 Oct 2011 09:56:10 +0000 (11:56 +0200)]
s4 provision/dns: Move DNS-related setup to sambadns module

Autobuild-User: Kai Blin <kai@samba.org>
Autobuild-Date: Fri Nov  4 09:15:54 CET 2011 on sn-devel-104

12 years agos4 provision/dns: Move secretsdb_setup_dns to the AD DNS specific setup
Kai Blin [Fri, 21 Oct 2011 09:04:07 +0000 (11:04 +0200)]
s4 provision/dns: Move secretsdb_setup_dns to the AD DNS specific setup

12 years agos3:selftest: improve logging in the registry upgrade test
Michael Adam [Thu, 3 Nov 2011 22:59:55 +0000 (23:59 +0100)]
s3:selftest: improve logging in the registry upgrade test

Don't only log to the log file. Give "make test" a cance to grab
some output. And add some more messages.

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Fri Nov  4 01:58:20 CET 2011 on sn-devel-104

12 years agos3-selftest: add new registry upgrade test to test list
Björn Baumbach [Wed, 2 Nov 2011 19:02:35 +0000 (20:02 +0100)]
s3-selftest: add new registry upgrade test to test list

Signed-off-by: Michael Adam <obnox@samba.org>
12 years agos3-selftest: introduce registry upgrade test
Björn Baumbach [Wed, 2 Nov 2011 19:05:24 +0000 (20:05 +0100)]
s3-selftest: introduce registry upgrade test

Signed-off-by: Michael Adam <obnox@samba.org>
12 years agoFix bug #8562 - talloc: double free error.
Jeremy Allison [Thu, 3 Nov 2011 21:30:11 +0000 (14:30 -0700)]
Fix bug #8562 - talloc: double free error.

Ensure we don't access an undefined pointer.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Nov  4 00:09:46 CET 2011 on sn-devel-104

12 years agos4:lib/registry - enhance registry tests in respect to default values
Matthias Dieter Wallnöfer [Thu, 27 Oct 2011 07:54:06 +0000 (09:54 +0200)]
s4:lib/registry - enhance registry tests in respect to default values

Reviewed-by: Jelmer
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Thu Nov  3 21:41:17 CET 2011 on sn-devel-104

12 years agos4:lib/registry/ldb.c - quit the deletion of a not-existing default value with WERR_B...
Matthias Dieter Wallnöfer [Fri, 28 Oct 2011 17:52:49 +0000 (19:52 +0200)]
s4:lib/registry/ldb.c - quit the deletion of a not-existing default value with WERR_BADFILE

Reviewed-by: Jelmer
12 years agos4:lib/registry/ldb.c - don't use search filters for base searches
Matthias Dieter Wallnöfer [Tue, 25 Oct 2011 18:08:31 +0000 (20:08 +0200)]
s4:lib/registry/ldb.c - don't use search filters for base searches

They are not necessary in this case.

Reviewed-by: Jelmer
12 years agos4:lib/registry/regf.c - always generate debug messages on error cases
Matthias Dieter Wallnöfer [Fri, 28 Oct 2011 16:20:47 +0000 (18:20 +0200)]
s4:lib/registry/regf.c - always generate debug messages on error cases

We need to know what is going on.

Reviewed-by: Jelmer
12 years agos4-smbtorture: add some ndr validation tests for netlogon_samlogon_response structs.
Günther Deschner [Thu, 3 Nov 2011 08:34:04 +0000 (09:34 +0100)]
s4-smbtorture: add some ndr validation tests for netlogon_samlogon_response structs.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Nov  3 20:08:20 CET 2011 on sn-devel-104

12 years agotorture: add torture_assert_guid_equal() macro.
Günther Deschner [Thu, 3 Nov 2011 10:33:16 +0000 (11:33 +0100)]
torture: add torture_assert_guid_equal() macro.

Guenther

12 years agowaf: convert NDR_NBT into shared library.
Günther Deschner [Wed, 2 Nov 2011 17:05:59 +0000 (18:05 +0100)]
waf: convert NDR_NBT into shared library.

Guenther