ira/wip.git
16 years agor2834: Netapps can return NT_STATUS_ACCESS_DENIED when trying to return the
Tim Potter [Thu, 7 Oct 2004 03:55:39 +0000 (03:55 +0000)]
r2834: Netapps can return NT_STATUS_ACCESS_DENIED when trying to return the
security descriptor for a file.  Return an error in this case instead
of panicing trying to unpack a zero length buffer.  Found by Brett
Funderburg.
(This used to be commit 588de0d4a84a5228d0f99f743ad327ad3b70ead1)

16 years agor2832: Readd WKGUID-binding to match the correct default-locations of new
Günther Deschner [Wed, 6 Oct 2004 16:21:35 +0000 (16:21 +0000)]
r2832: Readd WKGUID-binding to match the correct default-locations of new
User-, Group- and Machine-Accounts in Active Directory (this got lost
during the last trunk-merge).

This way we match e.g. default containers moved by redircmp.exe and
redirusr.exe in Windows 2003 and don't blindly default to cn=Users or
cn=Computers.

Further wkguids can be examied via "net ads search wellknownobjects=*".
This should still keep a samba3-client joining a samba4 dc. Fixes
Bugzilla #1343.

Guenther
(This used to be commit 8836621694c95779475fa9a1acf158e5e0577288)

16 years agor2828: Fix for bugzilla #1864 from Brett again.
Tim Potter [Wed, 6 Oct 2004 02:05:39 +0000 (02:05 +0000)]
r2828: Fix for bugzilla #1864 from Brett again.

Add sd->type field to security descriptor Python representation.
(This used to be commit b157a1b7c3e15a960fbc943d37abbb1bf5053a63)

16 years agor2826: Complain if 'password chat' doesn't contain the %u variable. based on a patch...
Jelmer Vernooij [Tue, 5 Oct 2004 22:18:32 +0000 (22:18 +0000)]
r2826: Complain if 'password chat' doesn't contain the %u variable. based on a patch by Ronan Waide
(This used to be commit a48b3b291cfe5883da1a36b368ddf725b5ff9375)

16 years agor2824: restored the is_case_sensitive option to ms_fnmatch() in Samba3. It is
Andrew Tridgell [Tue, 5 Oct 2004 03:26:02 +0000 (03:26 +0000)]
r2824: restored the is_case_sensitive option to ms_fnmatch() in Samba3. It is
very rarely used, but we sohuldn't be removing a feature in a minor
release of this kind.
(This used to be commit 4ce0505bc369243aa77013519ce4e4f6e50f5a48)

16 years agor2823: Patch from Brett Funderburg to pass create options parameter to
Tim Potter [Tue, 5 Oct 2004 01:36:37 +0000 (01:36 +0000)]
r2823: Patch from Brett Funderburg to pass create options parameter to
nt_create_andx() function.
(This used to be commit fa3e8365641e84ca361dc95bac33a9d56e9d799b)

16 years agor2822: Fix parameter confusion in priming of name-to-sid cache. Found by
Tim Potter [Tue, 5 Oct 2004 00:48:56 +0000 (00:48 +0000)]
r2822: Fix parameter confusion in priming of name-to-sid cache.  Found by
Qiao Yang.
(This used to be commit 30ae13cb9fbe5f04e46bcbd5e0c19da9b33341d5)

16 years agor2821: Adding "Windows x64" as architecture string and driverdir "x64" for the
Günther Deschner [Mon, 4 Oct 2004 22:13:57 +0000 (22:13 +0000)]
r2821: Adding "Windows x64" as architecture string and driverdir "x64" for the
64bit AMD platform.

(This used to be "Windows AMD64" and "AMD64" in one of the release
candidates of SP2 for Windows XP. AMD64 is obviously still supported but
not documented.)

Guenther
(This used to be commit cc5892f0411b8eb5daebe746164a2cf21d3d4c68)

16 years agor2819: Make 'password history'-behaviour in ldapsam more consistent.
Günther Deschner [Mon, 4 Oct 2004 15:53:33 +0000 (15:53 +0000)]
r2819: Make 'password history'-behaviour in ldapsam more consistent.

Currently we cannot store more then 15 password history entries (windows
NT4 allows to store 24) in ldapsam. When choosing more then "15" with
pdbedit -P "password history", we fail to initialize the password
history upon password change and overwrite the history, effectively
using a password history of "1". We do already decrease any
history-policy larger then 15 to 15 while storing the password history
list attribute in ldap.

Guenther
(This used to be commit a4b47e71475a06c2e2287613b00648c5f53ae52c)

16 years agor2814: Exactly the same as "main" build fix.
Rafal Szczesniak [Sun, 3 Oct 2004 20:25:34 +0000 (20:25 +0000)]
r2814: Exactly the same as "main" build fix.

rafal
(This used to be commit 7fa94c38951fcd803a8e769a867a008e47f4129a)

16 years agor2813: Fix the build.
Rafal Szczesniak [Sun, 3 Oct 2004 19:53:20 +0000 (19:53 +0000)]
r2813: Fix the build.
At least temporarily, since I've got the impression that _real_ fix
is more complex...

rafal
(This used to be commit 982912f0c8547b0f0edc8d0b26e36e9701cdee82)

16 years agor2779: Some fixes to pam_winbind.c.:
Andrew Bartlett [Sat, 2 Oct 2004 11:11:49 +0000 (11:11 +0000)]
r2779: Some fixes to pam_winbind.c.:

Allow 'require_membership_of' and 'require-membership-of'.

Really use a different struct for the SID->Name lookup.

Andrew Bartlett
(This used to be commit 83dadcd089905aa8ff3392010177ffa1dc8237ba)

16 years agor2778: merged the new samba4 ms_fnmatch code to Samba3. Thanks to Rusty
Andrew Tridgell [Sat, 2 Oct 2004 09:14:43 +0000 (09:14 +0000)]
r2778: merged the new samba4 ms_fnmatch code to Samba3. Thanks to Rusty
Russel for some help in designing the new algorithm.
(This used to be commit 38144f8d2cda32edacf90725f28e763689128d0d)

16 years agor2772: Check correct string length when verifying password-policies. Do not
Günther Deschner [Sat, 2 Oct 2004 00:13:21 +0000 (00:13 +0000)]
r2772: Check correct string length when verifying password-policies. Do not
allow e.g. two umlauts and one ascii char to comply with account-policy
"min password length" of 5.

Thanks to Uwe Morgenroth from CC Compunet and Volker.

TODO: we do check the length against AP_MIN_PASSWORD_LEN *and*
lp_min_passwd_length() - both can have differing values.
(This used to be commit d03683772942e8c32507be210b8fd35bfba2c048)

16 years agor2771: Second (and last) part of Swat-i18n-Patch from Björn Jacke
Günther Deschner [Fri, 1 Oct 2004 22:24:44 +0000 (22:24 +0000)]
r2771: Second (and last) part of Swat-i18n-Patch from Björn Jacke
<bjacke@sernet.de>

"Do not use display charset for swat output. In HTML we do not care
about the "locale charmap" because HTML code is UTF-8 only now.
Additionally take care that we convert files from statuspage from unix
charset to UTF-8. Thus we have correct HTML output under all
circumstances. We now also convert the share names correctly from unix
encoding to web encoding and vice vera.  "

Guenther
(This used to be commit 6d9f77c2bb95db4939b8ef375e22b188168b70ab)

16 years agor2770: oops; internal_resolve_name() should stay static in 3.0
Gerald Carter [Fri, 1 Oct 2004 20:52:50 +0000 (20:52 +0000)]
r2770: oops; internal_resolve_name() should stay static in 3.0
(This used to be commit 316302ca4a79cfc201311e12df71fdbb974c09c4)

16 years agor2768: BUG 1519: save the hostname used in the open_printer_ex() for later reuse...
Gerald Carter [Fri, 1 Oct 2004 20:34:12 +0000 (20:34 +0000)]
r2768: BUG 1519: save the hostname used in the open_printer_ex() for later reuse when filling in the spolss replies (also gets rid of get_called_name()
(This used to be commit 57db8ca91f52329c7f8985c04463b6b69015b0c4)

16 years agor2762: Remove silly conversion to and from UTF8 on the winbind pipe. Fix the
Andrew Bartlett [Fri, 1 Oct 2004 03:28:39 +0000 (03:28 +0000)]
r2762: Remove silly conversion to and from UTF8 on the winbind pipe.  Fix the
naming of the require_membership_of parameter in pam_winbind and fix
the error code for 'you didn't specify a domain' in ntlm_auth.

Andrew Bartlett
(This used to be commit 4bf0b94011fe6bfbec5635e58cafbfe3dc898569)

16 years agor2761: Print the decrypted, not encrypted key.
Andrew Bartlett [Fri, 1 Oct 2004 03:14:57 +0000 (03:14 +0000)]
r2761: Print the decrypted, not encrypted key.

Andrew Bartlett
(This used to be commit 1833d0ab724d88411ebd79ac26f5642e7c8cfee3)

16 years agor2760: Another patch from The Written Word. Don't declare function prototypes
Tim Potter [Fri, 1 Oct 2004 02:59:43 +0000 (02:59 +0000)]
r2760: Another patch from The Written Word.  Don't declare function prototypes
inside a function.  Bugzilla #1762.
(This used to be commit 002cdd4a5b34611983a32018248f9fe122c4111a)

16 years agor2759: Fix for winbindd on AIX 5.1. Apparently it doesn't have as many methods
Tim Potter [Fri, 1 Oct 2004 02:57:10 +0000 (02:57 +0000)]
r2759: Fix for winbindd on AIX 5.1.  Apparently it doesn't have as many methods
in struct secmethod_table as AIX 5.2.  Patch from The Written Word.
(This used to be commit 4f8496ad626478c31e9372e07652d50f581256d0)

16 years agor2755: Fix NTLMv2 for use with pam_winbind, the plaintext ntlm_auth modes,
Andrew Bartlett [Thu, 30 Sep 2004 00:49:41 +0000 (00:49 +0000)]
r2755: Fix NTLMv2 for use with pam_winbind, the plaintext ntlm_auth modes,
and the wbinfo -a test tool.

If 'client ntlmv2 auth' is set, then we will send an NTLMv2, rather
than an NT/LM response to the server.

Andrew Bartlett
(This used to be commit ce2456e436c5d57cd95cd10c6edf759592d0e843)

16 years agor2753: Workaround for the (rather broken) _samr_query_useraliases rpc-call.
Günther Deschner [Wed, 29 Sep 2004 15:26:38 +0000 (15:26 +0000)]
r2753: Workaround for the (rather broken) _samr_query_useraliases rpc-call.

_samr_query_useraliases shows up with all kind of very weird memberships
(global-groups, machine-accounts, etc.). Sometimes even if there is no
alias-membership at all.

One of the biggest mistakes is to convert any unix-group the user is a
member of, into an alias by default in get_group_from_gid.

get_alias_user_groups should be rewritten to use
pdb_enum_alias_memberships.

Guenther
(This used to be commit 73ab2d2a74d3992167d9304dd41f60ad0805dd67)

16 years agor2752: Fix the paranoia-check to ensure the ldap-attribute and the
Günther Deschner [Wed, 29 Sep 2004 13:34:41 +0000 (13:34 +0000)]
r2752: Fix the paranoia-check to ensure the ldap-attribute and the
smb.conf-parameter for samba's "algorithmic rid base" in ldapsam are
identical.

It tried to get the value of LDAP_ATTR_ALGORITHMIC_RID_BASE via
get_userattr_key2string() for a very long time now. This just can not
work because LDAP_ATTR_ALGORITHMIC_RID_BASE is neither in attrib_map_v22
nor in attrib_map_v30. Instead, get it directly from dominfo_attr_list.

Ldapsam will now correctly refuse to initialize when admins tried
manually to have differing values for "algorithmic rid base" in ldap and
smb.conf. idmap_ldap is another story...

Guenther
(This used to be commit c5b8bc6c2e9a3f789f41742438b31152721c0bf4)

16 years agor2746: Fix typos in net's usage-output.
Günther Deschner [Wed, 29 Sep 2004 09:56:35 +0000 (09:56 +0000)]
r2746: Fix typos in net's usage-output.

Guenther
(This used to be commit 4886d6663d7479978e2c395602392accb5939fa0)

16 years agor2736: Fix bug in Python printerdata wraper found by Daniel Jarboe.
Tim Potter [Tue, 28 Sep 2004 21:30:54 +0000 (21:30 +0000)]
r2736: Fix bug in Python printerdata wraper found by Daniel Jarboe.
(This used to be commit 8ec28d613d6dcade135b314c6764fbafcc8ed79c)

16 years agor2732: Fixed typo.
Günther Deschner [Tue, 28 Sep 2004 14:13:46 +0000 (14:13 +0000)]
r2732: Fixed typo.

Guenther
(This used to be commit 8521891ee87551e62fedecef2f5efa49f6c90a99)

16 years agor2729: Fix ldapsam_compat homeDrive. Thanks to jason@env.leeds.ac.uk
Volker Lendecke [Tue, 28 Sep 2004 13:24:38 +0000 (13:24 +0000)]
r2729: Fix ldapsam_compat homeDrive. Thanks to jason@env.leeds.ac.uk

Volker
(This used to be commit ef057e9534cc3713d3bcd7427cf34c74f7e3ea13)

16 years agor2715: Swat-i18n-Patch from Björn Jacke <bjacke@sernet.de>:
Günther Deschner [Tue, 28 Sep 2004 10:46:40 +0000 (10:46 +0000)]
r2715: Swat-i18n-Patch from Björn Jacke <bjacke@sernet.de>:

"Unify charset-handling in Content-Type:-headers to UTF-8 (fixes #1766),
making UTF-8 the only supported (but fully functional) charset.  Also
remove html-header-files for ja and tr that have become obsolete now.
Reformat msgstr in msg-files to UTF-8."

Guenther
(This used to be commit 0f8e1a0d0083ffb25b1888f5cae2613f7a7dbc46)

16 years agor2708: Don't look for bzero, we don't use it.
Jeremy Allison [Tue, 28 Sep 2004 05:33:30 +0000 (05:33 +0000)]
r2708: Don't look for bzero, we don't use it.
Samba4 torture tester treates maxentries = 0 as maxentries ==1.
Jeremy.
(This used to be commit 38f3d3e263f59f94f243907447b5a82f67d3e3f7)

16 years agor2706: The code that prints the remote MAC address (from the statistics section
Christopher R. Hertel [Tue, 28 Sep 2004 02:13:53 +0000 (02:13 +0000)]
r2706: The code that prints the remote MAC address (from the statistics section
of the response packet) was outside of the if() that determined whether
the query was successful or not.  As a result, the MAC address would print
out even if there was no MAC address.  At least the garbage it printed was
relatively consistent.  :)

I moved the MAC printing into the if() block and added an 'else' to print
"No reply..." if the query fails.

Chris -)-----
(This used to be commit 2a5d66791fa5e1b19e0ec9072af254142245d0c2)

16 years agor2703: Fix typo noticed by Igor Belyi <sambauser@katehok.ac93.org>
Jeremy Allison [Tue, 28 Sep 2004 00:10:09 +0000 (00:10 +0000)]
r2703: Fix typo noticed by Igor Belyi <sambauser@katehok.ac93.org>
Jeremy.
(This used to be commit ba69c7229c27e917a24e6d608d59e7c0bdd47551)

16 years agor2700: Fix bug where we could incorrectly set sparse attribute. Don't use
Jeremy Allison [Mon, 27 Sep 2004 23:57:59 +0000 (23:57 +0000)]
r2700: Fix bug where we could incorrectly set sparse attribute. Don't use
st_blksize, it isn't what you think....
Jeremy.
--his line, and those below, will be ignored--

M    source/smbd/dosmode.c
(This used to be commit 0a40c1a50f0e4b1b7efc9a53d22ceac14841bccf)

16 years agor2697: Fix for bugzilla #1732, patch by Satoh Fumiyasu, fumiya@samba.gr.jp
Jim McDonough [Mon, 27 Sep 2004 17:07:28 +0000 (17:07 +0000)]
r2697: Fix for bugzilla #1732, patch by Satoh Fumiyasu, fumiya@samba.gr.jp

Limit share names returned by RAP based on windows character width, not unix
character width.
(This used to be commit 5d57058d912a42d55879352e904f0bcaa6531075)

16 years agor2691: Increase a debug level for a quite frequent operation.
Volker Lendecke [Mon, 27 Sep 2004 14:44:07 +0000 (14:44 +0000)]
r2691: Increase a debug level for a quite frequent operation.

Optimization for 'idmap backend = ldap': When asking sid2id for the wrong
type, don't ask ldap when we have the opposite mapping in the local tdb.

Volker
(This used to be commit c91cff3bd38c1a8e23628b032f09829f9abf792d)

16 years agor2665: Ensure the UNIX info level returned enough data.
Jeremy Allison [Sun, 26 Sep 2004 22:16:00 +0000 (22:16 +0000)]
r2665: Ensure the UNIX info level returned enough data.
Jeremy.
(This used to be commit 8a7741dddf17dca136144fb26e2d7a42d313467a)

16 years agor2651: Added 'stat' command to smbclient to exercise the UNIX_FILE_BASIC
Jeremy Allison [Sun, 26 Sep 2004 06:27:54 +0000 (06:27 +0000)]
r2651: Added 'stat' command to smbclient to exercise the UNIX_FILE_BASIC
info level. Outputs data on the file in the same format the the
stat command in Linux. Should be useful to people wanting to learn
how to parse the UNIX extension output.
Yes I will add the docs later :-).
Jeremy.
(This used to be commit b25cc596417d29815814c3968ac2627bf59ffc0b)

16 years agor2637: Fix the roundup problem (returning 1mb roundup) for non-Windows
Jeremy Allison [Sat, 25 Sep 2004 22:18:46 +0000 (22:18 +0000)]
r2637: Fix the roundup problem (returning 1mb roundup) for non-Windows
clients. This upsets the smb client in the Linux kernel (and Linus :-).
Jeremy.
(This used to be commit dad699ce0b36d23b80fe70b74d5e98df568a0495)

16 years agor2619: Only issue the ldap extended password change operation if the ldap server
Volker Lendecke [Sat, 25 Sep 2004 10:12:34 +0000 (10:12 +0000)]
r2619: Only issue the ldap extended password change operation if the ldap server
supports it. This might be a fix for bugs 1823 and 1545, notifying both.

Also ignore object class violation errors from the extended operation. We
don't have the userPassword field in sambaSamAccount, and if we have such
broken setup with user in /etc/passwd and only samba attribs in ldap, we fail
this :-)

Volker
(This used to be commit a32ea3bc881f516fb733cb4767ae5cf22d658b12)

16 years agor2610: Even if we only use the fast-path (ascii only) then
Jeremy Allison [Fri, 24 Sep 2004 23:56:22 +0000 (23:56 +0000)]
r2610: Even if we only use the fast-path (ascii only) then
we still need to set errno = E2BIG when we overflow.
Jeremy.
(This used to be commit 7b0560dcccbd44f1f7b67ba1d46f6a5680b6b47c)

16 years agor2605: Fix stupid typo in back-port of Samba4 fix.
Jeremy Allison [Fri, 24 Sep 2004 20:06:13 +0000 (20:06 +0000)]
r2605: Fix stupid typo in back-port of Samba4 fix.
Jeremy.
(This used to be commit ca9516520ffe007a7dccd4d6cbf1c5d77fc4ce29)

16 years agor2599: avoid free()ing our static unalloceted memory that ends up in memory corruption.
Simo Sorce [Fri, 24 Sep 2004 17:38:23 +0000 (17:38 +0000)]
r2599: avoid free()ing our static unalloceted memory that ends up in memory corruption.
(This used to be commit 557e12d1b593b582ea1157d278bcdde6aba5a879)

16 years agor2584: After talking to jerry, commit the strlower patch to getent username and
Volker Lendecke [Fri, 24 Sep 2004 06:42:04 +0000 (06:42 +0000)]
r2584: After talking to jerry, commit the strlower patch to getent username and
groupnames. In template homedir, leave %D alone uppercased.

Volker
(This used to be commit dcb577f1cd8cf60557c0d061afeec206f58a6b31)

16 years agor2578: Pick up optimisation from Samba4 - thanks tridge !
Jeremy Allison [Fri, 24 Sep 2004 01:32:19 +0000 (01:32 +0000)]
r2578: Pick up optimisation from Samba4 - thanks tridge !
- I recently found out that charaters below 0x3F are guaranteed not to
  occur as secondary bytes in any multi-byte character set. This
  allows for a very simple optimisation in strchr_m() and
  strrchr_m(). It might be a good idea to pick this up for Samba3.
Jeremy.
(This used to be commit 0465e2d23d27e535bad4652037b37041049bfa96)

16 years agor2575: Return correct error codes on old SEARCH call (from Samba4 torture tester).
Jeremy Allison [Fri, 24 Sep 2004 00:55:46 +0000 (00:55 +0000)]
r2575: Return correct error codes on old SEARCH call (from Samba4 torture tester).
Jeremy.
(This used to be commit fc51c97ea86bd1a86830d4ab2c6c7c4ec9fccc88)

16 years agor2570: minor fix with Rob's patch. use dos_errstr() instead of W_ERROR_V() when...
Gerald Carter [Thu, 23 Sep 2004 19:44:04 +0000 (19:44 +0000)]
r2570: minor fix with Rob's patch.  use dos_errstr() instead of W_ERROR_V() when using %s in the format string
(This used to be commit b26e4dbd7fd616e672331fd36441b8bf74157904)

16 years agor2569: Patch from Rob Foehl <rwf@loonybin.net>:
Gerald Carter [Thu, 23 Sep 2004 19:24:02 +0000 (19:24 +0000)]
r2569: Patch from Rob Foehl <rwf@loonybin.net>:

- fix typo in libads/ldap_printer.c:39, ads_find_printer_on_server()
  (originally libads-typo.patch)
- fix leak in printing/nt_printing.c, is_printer_published()
  (originally is_printer_published-leak.patch)
- fix double print_backend_init() calls, now only called from main()
- restructuring in printing/nt_printing.c
  - replaced (un)publish_it() with ads-specific functions
  - moved common code to nt_printer_publish()
  - improved error handling in several places
- added check_published_printers() in printing/nt_printing.c, to verify
  that each published printer is actually in the directory at startup
- changed calling semantics of mod_a_printer, dump_a_printer, and
  update_driver_init to be more consistent with the rest of the api and
  reduce some copying
(This used to be commit 50a5a3dbd02acb0d09133b6e42cc37d091ea901d)

16 years agor2567: Patches from Lars Mueller <lmuelle at suse dot de>:
Gerald Carter [Thu, 23 Sep 2004 18:11:08 +0000 (18:11 +0000)]
r2567: Patches from Lars Mueller <lmuelle at suse dot de>:

trivial fix for autoconf and autoheader versions with a
letter in the version string.  This happens in our current beta named
distribution tree.

trivial patch to fix the build with the upcoming libtool
version.  It will be mandatory to use --mode while using libtool.
(This used to be commit 80d591f8cc62d513eb99112e6533b93ee901d27d)

16 years agor2566: Fix creation of aliases via usrmgr. Winbind was too strict checking the type
Volker Lendecke [Thu, 23 Sep 2004 15:21:02 +0000 (15:21 +0000)]
r2566: Fix creation of aliases via usrmgr. Winbind was too strict checking the type
of sids.

Volker
(This used to be commit d3b2921a8fd86beb77eae45ef9cf1a846a93b199)

16 years agor2564: resurrecting smbd/tdbutil.c
Gerald Carter [Thu, 23 Sep 2004 12:18:33 +0000 (12:18 +0000)]
r2564: resurrecting smbd/tdbutil.c
(This used to be commit e61986a11ec69e2510ae1de38ea9c5df4d4804d9)

16 years agor2548: Fix for bug reported by Edward Spragins <spragins@gmail.com> - don't try to
Jeremy Allison [Thu, 23 Sep 2004 00:19:18 +0000 (00:19 +0000)]
r2548: Fix for bug reported by Edward Spragins <spragins@gmail.com> - don't try to
set security descriptors on shares where this has been turned off.
Jeremy.
(This used to be commit 9cbe685d02fa1d3778958a3ade4965b64e5d0169)

16 years agor2540: Fix it the way Henrik Nordstrom (the patch author) wants :-).
Jeremy Allison [Wed, 22 Sep 2004 23:27:20 +0000 (23:27 +0000)]
r2540: Fix it the way Henrik Nordstrom (the patch author) wants :-).
Jeremy.
(This used to be commit 45707b5700f8a7c422fca2d7c95f9fab50740f35)

16 years agor2528: Ensure MIN is defined as a macro so it's not undefined in the .so.
Jeremy Allison [Wed, 22 Sep 2004 17:58:45 +0000 (17:58 +0000)]
r2528: Ensure MIN is defined as a macro so it's not undefined in the .so.
Fix from Andreas <andreas@conectiva.com.br>.
Jeremy.
(This used to be commit b5edad8b6098abac9b197d70fe29fb514e625b34)

16 years agor2482: Fix from Arthur van Dongen <avdongen@xs4all.nl> to fix acces -> access typos.
Jeremy Allison [Wed, 22 Sep 2004 00:50:12 +0000 (00:50 +0000)]
r2482: Fix from Arthur van Dongen <avdongen@xs4all.nl> to fix acces -> access typos.
Jeremy.
(This used to be commit a278dca1b2c103f368d154aee2d3a1edd5604687)

16 years agor2481: Patch from Igor Belyi <sambauser@katehok.ac93.org>. Ensure pdb
Jeremy Allison [Wed, 22 Sep 2004 00:33:09 +0000 (00:33 +0000)]
r2481: Patch from Igor Belyi <sambauser@katehok.ac93.org>. Ensure pdb
user is deleted first before deleting UNIX user (LDAP backend
needs this ordering).
Jeremy.
(This used to be commit 2815b31e013e517a58027ba74f118209caf4d85f)

16 years agor2479: Stop attribute "modifyTimestamp" from being deleted.
Jeremy Allison [Tue, 21 Sep 2004 22:16:36 +0000 (22:16 +0000)]
r2479: Stop attribute "modifyTimestamp" from being deleted.
Jeremy.
(This used to be commit 0351bf8b03306246efc17e532ebe78ecdafb645d)

16 years agor2477: Document "--destination" for "net rpc [printer|share] migrate".
Günther Deschner [Tue, 21 Sep 2004 13:46:12 +0000 (13:46 +0000)]
r2477: Document "--destination" for "net rpc [printer|share] migrate".

Guenther
(This used to be commit 4aa670385f81ab3d90a2c5dd8ba6e0190f947452)

16 years agor2476: now that PRINTER_ATTRIBUTE_PUBLISHED does not get reset anymore, migrate
Günther Deschner [Tue, 21 Sep 2004 13:31:57 +0000 (13:31 +0000)]
r2476: now that PRINTER_ATTRIBUTE_PUBLISHED does not get reset anymore, migrate
the publishing-state for migrated printers as well.

Therefor added client-side-support for setprinter level 7.

Next will be a "net rpc printer publish"-command (just for completeness).

Guenther
(This used to be commit 224920738fdc65ef170152062177421cfed85bbf)

16 years agor2475: A more helpful debug-message when a connection to a dfs-proxy-share is
Günther Deschner [Tue, 21 Sep 2004 13:04:35 +0000 (13:04 +0000)]
r2475: A more helpful debug-message when a connection to a dfs-proxy-share is
failing.

Guenther
(This used to be commit 486bcff17faf8c7ecd9bf4bb9af244bc4bcdf843)

16 years agor2474: (re-)fix memleak (initially found by jra).
Günther Deschner [Tue, 21 Sep 2004 12:50:04 +0000 (12:50 +0000)]
r2474: (re-)fix memleak (initially found by jra).

heimdal 0.6.1rc3 had a bug causing winbindd to die, heimdal version
0.6.1 and higher have that fixed (thanks to Love from Heimdal).

SuSE has been informed about this possible pitfall, any other vendors
that ship with heimdal-0.6.1rc3 to be notified ?

Guenther
(This used to be commit 6239a5bec99c62032e0cde20679a71622dd7a059)

16 years agor2473: Convert internal data to UTF-8 before calling libxml2
Jelmer Vernooij [Tue, 21 Sep 2004 11:50:42 +0000 (11:50 +0000)]
r2473: Convert internal data to UTF-8 before calling libxml2
(This used to be commit 8be3fa5bfa80b51f30f1c93a7fc9e95e2b1996a7)

16 years agor2472: Fixed krb5_krbhost_get_addrinfo()-parameters and make failure
Günther Deschner [Tue, 21 Sep 2004 10:40:45 +0000 (10:40 +0000)]
r2472: Fixed krb5_krbhost_get_addrinfo()-parameters and make failure
of this call non-critical.

Thanks to Love for the patch and explaining the inner workings of
heimdal.

Guenther
(This used to be commit 4bd9d8240b571fdd8546af4eea3f4f148987d57c)

16 years agor2470: Fix bug 1797: winbind and nmbd ignored "-l" option.
Volker Lendecke [Tue, 21 Sep 2004 09:07:42 +0000 (09:07 +0000)]
r2470: Fix bug 1797: winbind and nmbd ignored "-l" option.

Thanks to Igor Zhbanov bsg@uniyar.ac.ru.

Volker
(This used to be commit 8a28475a0b7659cb0cdefe57edf801d9958c3755)

16 years agor2466: Fix memleak found by sean.chandler@verizon.net.
Volker Lendecke [Tue, 21 Sep 2004 07:55:49 +0000 (07:55 +0000)]
r2466: Fix memleak found by sean.chandler@verizon.net.

Thanks!

Volker
(This used to be commit 587d863ae87042e0193b8d27b52ab3f75c58974b)

16 years agor2453: I think this is the last lot of fixes to get shared libraries working on
Tim Potter [Tue, 21 Sep 2004 01:37:34 +0000 (01:37 +0000)]
r2453: I think this is the last lot of fixes to get shared libraries working on
HPUX.  This is Richard Allen's suggestion to get HPUX to use cc instead of
ld.

Also he added some missing $(DYNEXP) on link lines and removed the definition
of $(LINK) as it is no longer used in the Makefile.
(This used to be commit 9481f2a79e83b0dae9141f65ccc59e59bcf682e7)

16 years agor2451: Fix from Henrik Nordstrom <hno@squid-cache.org> to allow
Jeremy Allison [Mon, 20 Sep 2004 20:18:19 +0000 (20:18 +0000)]
r2451: Fix from Henrik Nordstrom <hno@squid-cache.org> to allow
winbindd to return the correct number of groups when the
groups array must be enlarged.
Jeremy.
(This used to be commit bcc769de4d60205209633887f2fb2f0ab6088cae)

16 years agor2450: don't limit the number of groups returned by winbindd_getgroups()
Gerald Carter [Mon, 20 Sep 2004 19:19:59 +0000 (19:19 +0000)]
r2450: don't limit the number of groups returned by winbindd_getgroups()
(This used to be commit 4ba98cb469ad938bbc2e46cffaa48cc1c46b8e4e)

16 years agor2444: Based on jmcd's patch, implement special lists for the ldap user attributes to
Volker Lendecke [Mon, 20 Sep 2004 11:02:14 +0000 (11:02 +0000)]
r2444: Based on jmcd's patch, implement special lists for the ldap user attributes to
delete.

Richard, IMHO this is the better solution to the problem you currently
have. Please review.

Thanks,

Volker
(This used to be commit 6957d6a8921fbd97747258249d99b505a79cfcb4)

16 years agor2440: Use sys_fork instead of fork for the dual daemon so that we get the
Volker Lendecke [Mon, 20 Sep 2004 09:48:46 +0000 (09:48 +0000)]
r2440: Use sys_fork instead of fork for the dual daemon so that we get the
correct debug pid in the logfiles.

Volker
(This used to be commit 410d2c3ebba71434ad92d4572fec64eea7b952cd)

16 years agor2420: Way back at the 1st SambaXP, Simo pointed out a subtle bug related to the
Christopher R. Hertel [Sun, 19 Sep 2004 21:25:24 +0000 (21:25 +0000)]
r2420: Way back at the 1st SambaXP, Simo pointed out a subtle bug related to the
interaction between the splay tree code and the code used to find a leaf
node.  The problem is rare, and with most sites using the newer hashing
algorithm it's probably not important to fix it.  I have fixed it,
however.
(This used to be commit b3997aeaf47d5cf0d5ed63038f3b22c9dfcdff4c)

16 years agor2413: Arggg. Stupid, stupid, stupid me ! I added a paranoia test
Jeremy Allison [Sun, 19 Sep 2004 01:16:45 +0000 (01:16 +0000)]
r2413: Arggg. Stupid, stupid, stupid me ! I added a paranoia test
case when I was developing the deferred open case and made it
too tight. It will fire (incorrectly) and panic when a client
does a second open for a file with a different mid (multiplex-id)
request. Doh ! This is a perfectly valid thing for a client to
do (have two pending opens with different mids outstanding on
the same file) and currently when the first pending open expires
with a share violation the paranoia code will panic smbd.

It's a rare condition, but obvious now I've looked at the
code.

Fix for bug #1743.

Jeremy.
(This used to be commit e1bf108ae965ae730c67524164fa36497ea905b5)

16 years agor2396: Fix bug found by Cornelio Bondad Jr <Corny.Bondad@hp.com>.
Jeremy Allison [Fri, 17 Sep 2004 21:20:32 +0000 (21:20 +0000)]
r2396: Fix bug found by Cornelio Bondad Jr <Corny.Bondad@hp.com>.
To correct “net rpc vampire” core dump.
Jeremy.
(This used to be commit cd910ffc510f2007c2619d7a4d31e5e41de7d1d1)

16 years agor2395: Patch from "Stefan (metze) Metzmacher" <metze@samba.org> to fix
Jeremy Allison [Fri, 17 Sep 2004 19:58:27 +0000 (19:58 +0000)]
r2395: Patch from "Stefan (metze) Metzmacher" <metze@samba.org> to fix
opening of quota file.
Jeremy.
(This used to be commit 9a6e331639d7aace294dd663de7d27912fcae146)

16 years agor2392: Steal the nicer error message from Samba4 :-).
Jeremy Allison [Fri, 17 Sep 2004 19:53:12 +0000 (19:53 +0000)]
r2392: Steal the nicer error message from Samba4 :-).
Jeremy.
(This used to be commit afa88868b76a6e825bc45f8d405d4b3f557fdfdb)

16 years agor2390: Update some URLs and locations in README
Jelmer Vernooij [Fri, 17 Sep 2004 17:31:31 +0000 (17:31 +0000)]
r2390: Update some URLs and locations in README
(This used to be commit 4e29698467d124663226929b485d27d3f67e0f8e)

16 years agor2388: fix client quota support
Stefan Metzmacher [Fri, 17 Sep 2004 15:09:20 +0000 (15:09 +0000)]
r2388: fix client quota support

for the client we need the windows path and for server we need unix path

metze
(This used to be commit 54fd28f5e7b70ce2b192c2037ce28da3fea9ef92)

16 years agor2378: Remove two confusing #defines
Volker Lendecke [Fri, 17 Sep 2004 09:18:02 +0000 (09:18 +0000)]
r2378: Remove two confusing #defines
(This used to be commit 639cb4ced6b6c08b0665890c815f2e1361e7879f)

16 years agor2374: Fix from Vince Brimhall vbrimhall@novell.com for
Jeremy Allison [Fri, 17 Sep 2004 01:13:47 +0000 (01:13 +0000)]
r2374: Fix from Vince Brimhall vbrimhall@novell.com for
ldapsam_compat. Be robust against NULL attributes.
Jeremy.
(This used to be commit 727fc341b578577c112e97b0ef6f4c7f8bd15f66)

16 years agor2373: Fix typo.
Jeremy Allison [Fri, 17 Sep 2004 00:53:17 +0000 (00:53 +0000)]
r2373: Fix typo.
Jeremy.
(This used to be commit b1033fc77c97f0d9b5613a0b9f7d45dcf58e6b56)

16 years agor2371: Fix for talking to OS/2 clients (max_mux ignored) by Guenter Kukkukk <guenter...
Jeremy Allison [Fri, 17 Sep 2004 00:49:41 +0000 (00:49 +0000)]
r2371: Fix for talking to OS/2 clients (max_mux ignored) by Guenter Kukkukk <guenter.kukkukk@kukkukk.com>.
Bugid #1590.
Jeremy.
(This used to be commit 330025d1a669de927a3879a9c3a9fc20e1be464f)

16 years agor2369: Fix from Richard Renard <rrenard@idealx.com> to fix usermgr and trust relation...
Jeremy Allison [Thu, 16 Sep 2004 22:08:26 +0000 (22:08 +0000)]
r2369: Fix from Richard Renard <rrenard@idealx.com> to fix usermgr and trust relationships.
Jeremy.
(This used to be commit b910e530027c19c4e505314a91ffcb72f20d8f09)

16 years agor2364: Include yp_prot.h before ypclnt.h as AIX 5.2 spits the dummy otherwise.
Tim Potter [Thu, 16 Sep 2004 02:49:01 +0000 (02:49 +0000)]
r2364: Include yp_prot.h before ypclnt.h as AIX 5.2 spits the dummy otherwise.
Bugzilla #1778.
(This used to be commit 0f1ffe0f304d367fa5db1cfd92a8f5e365233c1f)

16 years agor2363: Fix to make find_workgroup use the same truncation as
Jeremy Allison [Thu, 16 Sep 2004 00:25:04 +0000 (00:25 +0000)]
r2363: Fix to make find_workgroup use the same truncation as
create_workgroup (refactor to a common function).
Patch from Paul Szabo - psz@maths.usyd.edu.au.
Jeremy.
(This used to be commit b2b6d6e890813b0d222ac75efb95434ba8c70e46)

16 years agor2361: Fix the appalling toktocliplist() fn. Bug found by Luis Benvenutto.
Jeremy Allison [Wed, 15 Sep 2004 22:49:23 +0000 (22:49 +0000)]
r2361: Fix the appalling toktocliplist() fn. Bug found by Luis Benvenutto.
Jeremy.
(This used to be commit d434d8e2b47bc8553ee04bd7211f622e3fcbb7fb)

16 years agor2355: Now we've shipped 3.0.7, add in the DOS fix.
Jeremy Allison [Wed, 15 Sep 2004 20:33:03 +0000 (20:33 +0000)]
r2355: Now we've shipped 3.0.7, add in the DOS fix.
Jeremy.
(This used to be commit d6b26f9db76e81d65b7630e46af99fe03a982ec6)

16 years agor2351: Fix use of an uninitialized variable. valgrind is sooo useful.
Volker Lendecke [Wed, 15 Sep 2004 15:12:36 +0000 (15:12 +0000)]
r2351: Fix use of an uninitialized variable. valgrind is sooo useful.

Volker
(This used to be commit 11f617eafd5512dab89bc363662f8e6953c359d4)

16 years agor2348: fix segmention faults
Stefan Metzmacher [Wed, 15 Sep 2004 13:57:33 +0000 (13:57 +0000)]
r2348: fix segmention faults

in smbcquotas and smbcacls caused by setup_logging() (-r 1425)

metze
(This used to be commit 39f3f76ea2097c10799f0bef8717d3ac71cacaa8)

16 years agor2340: Solve the problem of user sids ending up with gid's and vice versa: This
Volker Lendecke [Wed, 15 Sep 2004 08:55:01 +0000 (08:55 +0000)]
r2340: Solve the problem of user sids ending up with gid's and vice versa: This
belongs into winbind itself, not into wbinfo.

Volker
(This used to be commit 75e5c13d5d4c1da9bbb60f4e93183995c05a89ac)

16 years agor2338: Remove lonely looking definition of DYNEXP for HPUX in the configure
Tim Potter [Wed, 15 Sep 2004 00:59:31 +0000 (00:59 +0000)]
r2338: Remove lonely looking definition of DYNEXP for HPUX in the configure
"CPPFLAG settings for strange OS's section".  DYNEXP should only be
set in the shared library configure section.
(This used to be commit 8d00f7310c934dcecac4b0af01e74836f62fa539)

16 years agor2334: Update LDSHFLAGS for HPUX as -Wl is not necessary as we are invoking LD
Tim Potter [Tue, 14 Sep 2004 01:49:50 +0000 (01:49 +0000)]
r2334: Update LDSHFLAGS for HPUX as -Wl is not necessary as we are invoking LD
directly.  Should fix #1731.
(This used to be commit 9f241a8f2a590acd31f59f689b7eb17b6ae4f3dd)

16 years agor2333: check the script is not a 0 lenght string
Simo Sorce [Tue, 14 Sep 2004 01:11:01 +0000 (01:11 +0000)]
r2333: check the script is not a 0 lenght string
(This used to be commit 05a80c37375b3186b02b8430033796ab7a7d68bb)

16 years agor2331: check password script code and example from trunk
Simo Sorce [Tue, 14 Sep 2004 00:21:11 +0000 (00:21 +0000)]
r2331: check password script code and example from trunk
(This used to be commit f836be323a233f3a28cbaa04c532e83ea98ead89)

16 years agor2317: Fixup error messages and reformat.
Jeremy Allison [Mon, 13 Sep 2004 08:52:24 +0000 (08:52 +0000)]
r2317: Fixup error messages and reformat.
Jeremy.
(This used to be commit 8ae10c74ec45f1493aa15ee812ff37b86c8fc439)

16 years agor2312: Fix for bugid #1667, smbpasswd file could be left locked on
Jeremy Allison [Mon, 13 Sep 2004 08:04:04 +0000 (08:04 +0000)]
r2312: Fix for bugid #1667, smbpasswd file could be left locked on
some error exits.
Jeremy.
(This used to be commit e2b0b9fb72559a9629b116a7e063de08a12e9eb1)

16 years agor2292: changing version to 3.0.8pre1
Gerald Carter [Sun, 12 Sep 2004 04:08:20 +0000 (04:08 +0000)]
r2292: changing version to 3.0.8pre1
(This used to be commit 98799dc78236a76506d2848b7434bd521c9aca8f)

16 years agor2279: Clarification changes only.
John Terpstra [Fri, 10 Sep 2004 16:15:29 +0000 (16:15 +0000)]
r2279: Clarification changes only.
(This used to be commit 6ed4d26b08f0fde400c37042f6012a25d095594d)

16 years agor2269: Copied from SAMBA_3_RELEASE 3.0.7 branch.
John Terpstra [Thu, 9 Sep 2004 16:06:21 +0000 (16:06 +0000)]
r2269: Copied from SAMBA_3_RELEASE 3.0.7 branch.
(This used to be commit c48151d013b81cbcd172d0259b1b653cba800716)

16 years agor2265: Volkers change to HEAD looks very good. Commit message
Jeremy Allison [Thu, 9 Sep 2004 10:02:44 +0000 (10:02 +0000)]
r2265: Volkers change to HEAD looks very good. Commit message
from HEAD follows :
While torturing winbind a bit I found the following unfortunate behaviour:

Sending multiple requests at a high rate for a slow operation exposed that no
response comes back until the last request in the queue has been
processed. This is an unfortunate result of serially going through all sockets> that have shown to be readable or writable. All client sockets become readable> at the same time, none of them is writable. We go through them, read the
request, process the complete request. Before we enter the select system call
the next time all requests have to have completed.

This patch optimizes this by first looking at the sockets for writability. A
write on a socket that came back from select does not block, so this
additional loop might have a non-zero cost, but it can't prevent other
operations from proceeding.

After a possibly long-running winbindd_process() we directly start select()
again. To avoid starvation the currently processed client is demoted to be the> last one in the list of clients.

Jeremy.
(This used to be commit bfdeb22c69d09eb73305b6034fa6d0ec67275789)

16 years agor2264: Fix for #1741. Define a struct nss_groupsbymem (thanks lukeh!) for
Tim Potter [Thu, 9 Sep 2004 03:40:27 +0000 (03:40 +0000)]
r2264: Fix for #1741.  Define a struct nss_groupsbymem (thanks lukeh!) for
HPUX 11 which doesn't have one of its own.
(This used to be commit 3d275d1eee9644651dcbb61a342648e878fe3506)

16 years agor2263: When testing whether building shared libraries actually works, use
Tim Potter [Thu, 9 Sep 2004 03:36:05 +0000 (03:36 +0000)]
r2263: When testing whether building shared libraries actually works, use
$SHLD and $LDSHFLAGS instead of $CC, $CPPFLAGS and $CFLAGS as this is
more likely to actually work.  Bugzilla #1731.

I'm checking this in to 3.0 so it can hit the build farm and flush out
any problems with other architectures.  With a bit of luck this should
go in to Samba 3.0.8.
(This used to be commit a754f29ef819e1cf7ea31c117e5ef1487cb5cb5e)