ira/wip.git
9 years agoѕ4: EDQUOT needs to be mapped to NT_STATUS_DISK_FULL
Björn Jacke [Wed, 10 Mar 2010 19:58:16 +0000 (20:58 +0100)]
ѕ4: EDQUOT needs to be mapped to NT_STATUS_DISK_FULL

9 years agos4:libnet - change variables to "unsigned" where needed
Matthias Dieter Wallnöfer [Wed, 10 Mar 2010 19:23:43 +0000 (20:23 +0100)]
s4:libnet - change variables to "unsigned" where needed

9 years agos4:libnet_become_dc - change counter variables to "unsigned" where they count LDB...
Matthias Dieter Wallnöfer [Wed, 10 Mar 2010 19:22:06 +0000 (20:22 +0100)]
s4:libnet_become_dc - change counter variables to "unsigned" where they count LDB objects

9 years agos4:winreg RPC - fix up the "QueryValue" call to work against the enhanced torture...
Matthias Dieter Wallnöfer [Wed, 10 Mar 2010 18:49:25 +0000 (19:49 +0100)]
s4:winreg RPC - fix up the "QueryValue" call to work against the enhanced torture test

Found out by gd's updated torture test.

9 years agos4:registry/ldb.c - if "name" isn't set we should return WERR_INVALID_PARAM
Matthias Dieter Wallnöfer [Wed, 10 Mar 2010 08:47:02 +0000 (09:47 +0100)]
s4:registry/ldb.c - if "name" isn't set we should return WERR_INVALID_PARAM

9 years agonsswitch: build libnss_winbind.so with SOVERSION = 2
Stefan Metzmacher [Tue, 9 Mar 2010 11:24:59 +0000 (12:24 +0100)]
nsswitch: build libnss_winbind.so with SOVERSION = 2

metze

9 years agonsswitch: don't use socket_wrapper for winbind client code
Stefan Metzmacher [Tue, 9 Mar 2010 09:29:33 +0000 (10:29 +0100)]
nsswitch: don't use socket_wrapper for winbind client code

metze

9 years agonsswitch: build libnss_winbindd.so only for the non merged build
Stefan Metzmacher [Tue, 9 Mar 2010 10:14:50 +0000 (11:14 +0100)]
nsswitch: build libnss_winbindd.so only for the non merged build

metze

9 years agos4:build/m4/public.m4: add realname argument to SMB_BUILD_LIBRARY()
Stefan Metzmacher [Tue, 9 Mar 2010 09:44:41 +0000 (10:44 +0100)]
s4:build/m4/public.m4: add realname argument to SMB_BUILD_LIBRARY()

metze

9 years agos4:rpc_server/wkssvc: don't reset [out,ref] pointer to 0
Stefan Metzmacher [Wed, 10 Mar 2010 13:12:28 +0000 (14:12 +0100)]
s4:rpc_server/wkssvc: don't reset [out,ref] pointer to 0

r->out.total_entries = 0; should be *r->out.total_entries = 0;

Otherwise we fail to marshall the reponse or crash if we run with
log level = 10 and trigger the ndr_print functions.

All out elements are already setup and initialized by the pidl generated code.

metze

9 years agos4:rpc_server/wkssvc: remove unneeded talloc_reference()
Stefan Metzmacher [Wed, 10 Mar 2010 13:10:13 +0000 (14:10 +0100)]
s4:rpc_server/wkssvc: remove unneeded talloc_reference()

metze

9 years agos4:rpc_server/wkssvc: avoid ZERO_STRUCT(r->out) and use already allocated [out,ref...
Stefan Metzmacher [Wed, 10 Mar 2010 13:08:34 +0000 (14:08 +0100)]
s4:rpc_server/wkssvc: avoid ZERO_STRUCT(r->out) and use already allocated [out,ref] memory

metze

9 years agos4:rpc_server/srvsvc: remove unused ZERO_STRUCT(r->out);
Stefan Metzmacher [Wed, 10 Mar 2010 12:59:37 +0000 (13:59 +0100)]
s4:rpc_server/srvsvc: remove unused ZERO_STRUCT(r->out);

Here it doesn't matter, but it's a bad example for other code
as it might reset the [out,ref] pointers which are already
generated by the pidl generated code.

metze

9 years agoidl: Regenerate DRSUAPI idl files
Kamen Mazdrashki [Fri, 5 Mar 2010 22:35:17 +0000 (00:35 +0200)]
idl: Regenerate DRSUAPI idl files

Signed-off-by: Stefan Metzmacher <metze@samba.org>
9 years agos4/idl: drsuapi_QuerySitesByCostCtr1 'unknown' member is now known
Kamen Mazdrashki [Fri, 5 Mar 2010 22:31:12 +0000 (00:31 +0200)]
s4/idl: drsuapi_QuerySitesByCostCtr1 'unknown' member is now known

and this it is a reserved fields for future flags - 'flags_reserver'
Must be 0 and is currently ignored.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
9 years agos4/idl: QuerySitesByCost - switch types should be unsigned
Kamen Mazdrashki [Thu, 4 Mar 2010 17:51:01 +0000 (19:51 +0200)]
s4/idl: QuerySitesByCost - switch types should be unsigned

Signed-off-by: Stefan Metzmacher <metze@samba.org>
9 years agos4/idl: DsGetMemberships2 - switch types should be unsigned
Kamen Mazdrashki [Thu, 4 Mar 2010 17:25:40 +0000 (19:25 +0200)]
s4/idl: DsGetMemberships2 - switch types should be unsigned

Signed-off-by: Stefan Metzmacher <metze@samba.org>
9 years agos4/drs: DsRemoveDSServer - Propagating IDL changes to source code
Kamen Mazdrashki [Fri, 5 Mar 2010 21:24:10 +0000 (23:24 +0200)]
s4/drs: DsRemoveDSServer - Propagating IDL changes to source code

Signed-off-by: Stefan Metzmacher <metze@samba.org>
9 years agos4/idl: DsRemoveDSServer - switch types should be unsigned
Kamen Mazdrashki [Fri, 5 Mar 2010 21:17:50 +0000 (23:17 +0200)]
s4/idl: DsRemoveDSServer - switch types should be unsigned

Signed-off-by: Stefan Metzmacher <metze@samba.org>
9 years agos4/drs: DsWriteAccountSpn - Propagating IDL changes to source code
Kamen Mazdrashki [Fri, 5 Mar 2010 21:04:52 +0000 (23:04 +0200)]
s4/drs: DsWriteAccountSpn - Propagating IDL changes to source code

Signed-off-by: Stefan Metzmacher <metze@samba.org>
9 years agos4/idl: DsWriteAccountSpn - switch types should be unsigned
Kamen Mazdrashki [Fri, 5 Mar 2010 21:03:21 +0000 (23:03 +0200)]
s4/idl: DsWriteAccountSpn - switch types should be unsigned

Changes also propagated into source code as they are
too minor to be done in separate commit

Signed-off-by: Stefan Metzmacher <metze@samba.org>
9 years agos3/drs: DsCrackNames - Propagating IDL changes to source code
Kamen Mazdrashki [Fri, 5 Mar 2010 20:50:57 +0000 (22:50 +0200)]
s3/drs: DsCrackNames - Propagating IDL changes to source code

Signed-off-by: Stefan Metzmacher <metze@samba.org>
9 years agos4/drs: DsCrackNames - Propagating IDL changes to source code
Kamen Mazdrashki [Fri, 5 Mar 2010 20:38:03 +0000 (22:38 +0200)]
s4/drs: DsCrackNames - Propagating IDL changes to source code

Signed-off-by: Stefan Metzmacher <metze@samba.org>
9 years agos4/idl: DsCrackNames - switch types should be unsigned
Kamen Mazdrashki [Fri, 5 Mar 2010 20:37:44 +0000 (22:37 +0200)]
s4/idl: DsCrackNames - switch types should be unsigned

Signed-off-by: Stefan Metzmacher <metze@samba.org>
9 years agos4/idl: DsGetMemberships - switch types should be unsigned
Kamen Mazdrashki [Thu, 4 Mar 2010 15:55:46 +0000 (17:55 +0200)]
s4/idl: DsGetMemberships - switch types should be unsigned

Signed-off-by: Stefan Metzmacher <metze@samba.org>
9 years agos4/idl: DsReplicaMod - switch types should be unsigned
Kamen Mazdrashki [Thu, 4 Mar 2010 15:53:03 +0000 (17:53 +0200)]
s4/idl: DsReplicaMod - switch types should be unsigned

Signed-off-by: Stefan Metzmacher <metze@samba.org>
9 years agos4/idl: DsReplicaDel - switch types should be unsigned
Kamen Mazdrashki [Thu, 4 Mar 2010 15:19:32 +0000 (17:19 +0200)]
s4/idl: DsReplicaDel - switch types should be unsigned

Signed-off-by: Stefan Metzmacher <metze@samba.org>
9 years agos4/idl: DsReplicaAdd - switch types should be unsigned
Kamen Mazdrashki [Thu, 4 Mar 2010 15:11:38 +0000 (17:11 +0200)]
s4/idl: DsReplicaAdd - switch types should be unsigned

Signed-off-by: Stefan Metzmacher <metze@samba.org>
9 years agos4/idl: DsReplicaUpdateRefs - switch types should be unsigned
Kamen Mazdrashki [Fri, 5 Mar 2010 19:30:40 +0000 (21:30 +0200)]
s4/idl: DsReplicaUpdateRefs - switch types should be unsigned

Signed-off-by: Stefan Metzmacher <metze@samba.org>
9 years agos3/drs: DsGetNCChanges - Propagating IDL changes to source code
Kamen Mazdrashki [Fri, 5 Mar 2010 19:58:01 +0000 (21:58 +0200)]
s3/drs: DsGetNCChanges - Propagating IDL changes to source code

Signed-off-by: Stefan Metzmacher <metze@samba.org>
9 years agos4/drs: DsGetNCChanges - Propagating IDL changes to source code
Kamen Mazdrashki [Fri, 5 Mar 2010 18:33:46 +0000 (20:33 +0200)]
s4/drs: DsGetNCChanges - Propagating IDL changes to source code

Signed-off-by: Stefan Metzmacher <metze@samba.org>
9 years agos4/idl: DsGetNCChanges - switch types should be unsigned
Kamen Mazdrashki [Fri, 5 Mar 2010 18:33:23 +0000 (20:33 +0200)]
s4/idl: DsGetNCChanges - switch types should be unsigned

Converting those types to unsigned should help in
creating DRSUAPI dissector for Wireshark also.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
9 years agos4/idl: drsuapi_DsReplicaSyncOptions flags are no more used
Kamen Mazdrashki [Wed, 3 Mar 2010 20:07:55 +0000 (22:07 +0200)]
s4/idl: drsuapi_DsReplicaSyncOptions flags are no more used

Signed-off-by: Stefan Metzmacher <metze@samba.org>
9 years agodoxygen: talloc_get_type name fixed in Doxygen documentation
Kamen Mazdrashki [Wed, 3 Mar 2010 20:07:12 +0000 (22:07 +0200)]
doxygen: talloc_get_type name fixed in Doxygen documentation

Signed-off-by: Stefan Metzmacher <metze@samba.org>
9 years agos3-winreg: add some debug statements to _winreg_QueryValue().
Günther Deschner [Wed, 10 Mar 2010 13:17:23 +0000 (14:17 +0100)]
s3-winreg: add some debug statements to _winreg_QueryValue().

Guenther

9 years agos4-smbtorture: do full winreg QueryValue test for values we created.
Günther Deschner [Wed, 10 Mar 2010 12:04:17 +0000 (13:04 +0100)]
s4-smbtorture: do full winreg QueryValue test for values we created.

Guenther

9 years agos4-smbtorture: check for non existing value under version key in RPC-WINREG.
Günther Deschner [Wed, 10 Mar 2010 11:54:17 +0000 (12:54 +0100)]
s4-smbtorture: check for non existing value under version key in RPC-WINREG.

Guenther

9 years agos3: Fix a long-standing problem with recycled PIDs
Volker Lendecke [Tue, 2 Mar 2010 16:02:01 +0000 (17:02 +0100)]
s3: Fix a long-standing problem with recycled PIDs

When a samba server process dies hard, it has no chance to clean up its entries
in locking.tdb, brlock.tdb, connections.tdb and sessionid.tdb.

For locking.tdb and brlock.tdb Samba is robust by checking every time we read
an entry from the database if the corresponding process still exists. If it
does not exist anymore, the entry is deleted. This is not 100% failsafe though:
On systems with a limited PID space there is a non-zero chance that between the
smbd's death and the fresh access, the PID is recycled by another long-running
process. This renders all files that had been locked by the killed smbd
potentially unusable until the new process also dies.

This patch is supposed to fix the problem the following way: Every process ID
in every database is augmented by a random 64-bit number that is stored in a
serverid.tdb. Whenever we need to check if a process still exists we know its
PID and the 64-bit number. We look up the PID in serverid.tdb and compare the
64-bit number. If it's the same, the process still is a valid smbd holding the
lock. If it is different, a new smbd has taken over.

I believe this is safe against an smbd that has died hard and the PID has been
taken over by a non-samba process. This process would not have registered
itself with a fresh 64-bit number in serverid.tdb, so the old one still exists
in serverid.tdb. We protect against this case by the parent smbd taking care of
deregistering PIDs from serverid.tdb and the fact that serverid.tdb is
CLEAR_IF_FIRST.

CLEAR_IF_FIRST does not work in a cluster, so the automatic cleanup does not
work when all smbds are restarted. For this, "net serverid wipe" has to be run
before smbd starts up. As a convenience, "net serverid wipedbs" also cleans up
sessionid.tdb and connections.tdb.

While there, this also cleans up overloading connections.tdb with all the
process entries just for messaging_send_all().

Volker

9 years agos3: Make TLDAP_IS_ALPHA and TLDAP_IS_ADH static functions
Volker Lendecke [Mon, 8 Mar 2010 06:24:03 +0000 (07:24 +0100)]
s3: Make TLDAP_IS_ALPHA and TLDAP_IS_ADH static functions

9 years agos3-passdb: Fix typo in debug message.
Karolin Seeger [Wed, 10 Mar 2010 11:07:44 +0000 (12:07 +0100)]
s3-passdb: Fix typo in debug message.

Karolin

9 years agos4-spoolss: remove unsed iconv handle from dcesrv_spoolss_GetPrinterData().
Günther Deschner [Wed, 10 Mar 2010 10:16:20 +0000 (11:16 +0100)]
s4-spoolss: remove unsed iconv handle from dcesrv_spoolss_GetPrinterData().

Guenther

9 years agos4:winreg RPC - don't crash when incoming data wasn't correctly specified
Matthias Dieter Wallnöfer [Wed, 10 Mar 2010 08:22:42 +0000 (09:22 +0100)]
s4:winreg RPC - don't crash when incoming data wasn't correctly specified

Also found by the WINREG torture test enhancements by gd.

9 years agos4:lib/registry/ldb.c - fix up registry backend to be more robust
Matthias Dieter Wallnöfer [Wed, 10 Mar 2010 08:10:53 +0000 (09:10 +0100)]
s4:lib/registry/ldb.c - fix up registry backend to be more robust

This should let the new WINREG tests written by gd at least pass against us.

9 years agoFix the shell script in the root case. When run as root, make test now detects CAP_DA...
Jeremy Allison [Wed, 10 Mar 2010 04:06:19 +0000 (20:06 -0800)]
Fix the shell script in the root case. When run as root, make test now detects CAP_DAC_OVERRIDE being left on in error.

Jeremy.

9 years agos4-smbtorture: disable winreg QueryValue test for today.
Günther Deschner [Wed, 10 Mar 2010 01:52:13 +0000 (02:52 +0100)]
s4-smbtorture: disable winreg QueryValue test for today.

wow, both s3 and s4 crash on full coverage winreg QueryValue testing.

Guenther

9 years agos4-smbtorture: fix some build warnings in RPC-SPOOLSS test.
Günther Deschner [Wed, 10 Mar 2010 01:50:32 +0000 (02:50 +0100)]
s4-smbtorture: fix some build warnings in RPC-SPOOLSS test.

Guenther

9 years agoAdd tests which, when run as root, will ensure we can't write
Jeremy Allison [Wed, 10 Mar 2010 00:36:48 +0000 (16:36 -0800)]
Add tests which, when run as root, will ensure we can't write
into a read-only directory, or read a owner-read-only file.

Jeremy.

9 years agos4-smbtorture: on HKLM hive test the well known CurrentVersion value.
Günther Deschner [Tue, 9 Mar 2010 23:43:57 +0000 (00:43 +0100)]
s4-smbtorture: on HKLM hive test the well known CurrentVersion value.

Guenther

9 years agos4-smbtorture: add full coverage test for winreg QueryValue calls.
Günther Deschner [Tue, 9 Mar 2010 23:17:59 +0000 (00:17 +0100)]
s4-smbtorture: add full coverage test for winreg QueryValue calls.

Guenther

9 years agos4-smbtorture: rework test_winreg_QueryValue in RPC-SPOOLSS-PRINTER once again.
Günther Deschner [Tue, 9 Mar 2010 23:16:46 +0000 (00:16 +0100)]
s4-smbtorture: rework test_winreg_QueryValue in RPC-SPOOLSS-PRINTER once again.

Guenther

9 years agos4-smbtorture: add tests for set and delete value in RPC-WINREG.
Günther Deschner [Tue, 9 Mar 2010 23:06:52 +0000 (00:06 +0100)]
s4-smbtorture: add tests for set and delete value in RPC-WINREG.

Guenther

9 years agoFix typo and convert spaces to tabs
Simo Sorce [Tue, 9 Mar 2010 21:40:55 +0000 (16:40 -0500)]
Fix typo and convert spaces to tabs

9 years agoFix typo
Simo Sorce [Tue, 9 Mar 2010 21:41:44 +0000 (16:41 -0500)]
Fix typo

9 years agoAllow "make test" to complete as root. Obviously only safe on tightly
Jeremy Allison [Tue, 9 Mar 2010 21:14:18 +0000 (13:14 -0800)]
Allow "make test" to complete as root. Obviously only safe on tightly
controlled developer machines.
Jeremy.

9 years agos3: Fix a NULL pointer dereference
Volker Lendecke [Tue, 9 Mar 2010 10:14:14 +0000 (11:14 +0100)]
s3: Fix a NULL pointer dereference

Found by Laurent Gaffie <laurent.gaffie@gmail.com>.

Thanks!

Volker

9 years agos4:ldb fix escape parsing
Simo Sorce [Mon, 8 Mar 2010 01:20:45 +0000 (20:20 -0500)]
s4:ldb fix escape parsing

sscanf can return also on short reads, in this case an invalid escape
sequence like '\1k' would be accepted, returning 1 as value and swallowing the
'k'. Use an auxiliar function to validate and convert hex escapes.

9 years agos3:tldap add own filter parsing
Simo Sorce [Mon, 8 Mar 2010 01:20:02 +0000 (20:20 -0500)]
s3:tldap add own filter parsing

Also add torture test to check filter parsing.

9 years agos4:winbind - use "unsigned" variables where possible
Matthias Dieter Wallnöfer [Tue, 9 Mar 2010 16:54:12 +0000 (17:54 +0100)]
s4:winbind - use "unsigned" variables where possible

9 years agos4:winbind/wb_cmd_getgroups.c - fix up warnings
Matthias Dieter Wallnöfer [Tue, 9 Mar 2010 16:52:10 +0000 (17:52 +0100)]
s4:winbind/wb_cmd_getgroups.c - fix up warnings

Also fix some indentations.

9 years agos4:unittest Fix unittest to reflect that wbinfo -r no longer fail
Matthieu Patou [Tue, 9 Mar 2010 12:35:54 +0000 (15:35 +0300)]
s4:unittest Fix unittest to reflect that wbinfo -r no longer fail

Signed-off-by: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
9 years agos4:winbind: stub implementation of WINBINDD_PAM_LOGOFF
Matthieu Patou [Wed, 3 Mar 2010 20:29:15 +0000 (23:29 +0300)]
s4:winbind: stub implementation of WINBINDD_PAM_LOGOFF

Signed-off-by: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
9 years agos4:winbind: Fix a misplaced returned info
Matthieu Patou [Wed, 3 Mar 2010 20:29:32 +0000 (23:29 +0300)]
s4:winbind: Fix a misplaced returned info

libwbclient expect to have in auth.exra_data the INFO3_TXT and in auth.unix_username the username

Signed-off-by: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
9 years agos4:winbind Implement logic for getgroups to work
Matthieu Patou [Thu, 4 Mar 2010 00:05:06 +0000 (03:05 +0300)]
s4:winbind Implement logic for getgroups to work

This function is called by the system everytime we do a id user or when we do wbinfo -r

Signed-off-by: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
9 years agos4:winbind: implement calls for allowing getent groups
Matthieu Patou [Wed, 3 Mar 2010 23:46:36 +0000 (02:46 +0300)]
s4:winbind: implement calls for allowing getent groups

This is to say getgrent and setgrent, and the associated technical objects (states, build directives,...) needed.

Signed-off-by: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
9 years agos4:torture/rpc/netlogon.c - "LogonGetDomainInfo" test - make it compatible against...
Matthias Dieter Wallnöfer [Wed, 17 Feb 2010 08:51:41 +0000 (09:51 +0100)]
s4:torture/rpc/netlogon.c - "LogonGetDomainInfo" test - make it compatible against Windows Server 2008

This is a reworked version of the mentioned test which passes against Windows
Server 2008. The previous version, also mainly written by me passed only against
Windows Server <= 2003.

9 years agos4:netlogon RPC - "LogonGetDomainInfo" - make the call compatible with >= Windows...
Matthias Dieter Wallnöfer [Fri, 5 Mar 2010 10:09:57 +0000 (11:09 +0100)]
s4:netlogon RPC - "LogonGetDomainInfo" - make the call compatible with >= Windows 2008

Add more security checks and other corrections to imitate Windows Server >= 2008.

9 years agolibcli/auth/schannel_state_tdb.c - fix an obviously wrong error handling
Matthias Dieter Wallnöfer [Tue, 9 Mar 2010 16:12:02 +0000 (17:12 +0100)]
libcli/auth/schannel_state_tdb.c - fix an obviously wrong error handling

9 years agos4-smbtorture: fix uninitialized variable in winreg QueryValue call.
Günther Deschner [Tue, 9 Mar 2010 15:10:40 +0000 (16:10 +0100)]
s4-smbtorture: fix uninitialized variable in winreg QueryValue call.

Guenther

9 years agos3: Fix a typo. Thanks to Christian Ambach for pointing me at it :-)
Volker Lendecke [Tue, 9 Mar 2010 14:36:08 +0000 (15:36 +0100)]
s3: Fix a typo. Thanks to Christian Ambach for pointing me at it :-)

9 years agoA helper function to get the Infrastructure DN.
Nadezhda Ivanova [Tue, 9 Mar 2010 12:56:46 +0000 (14:56 +0200)]
A helper function to get the Infrastructure DN.

9 years agoFixed a bug in acl tests - python error when we create user/group/ou with a descriptor.
Nadezhda Ivanova [Tue, 9 Mar 2010 11:53:41 +0000 (13:53 +0200)]
Fixed a bug in acl tests - python error when we create user/group/ou with a descriptor.

9 years agoAdded a check for permissions to modify the RDN attribute on rename.
Nadezhda Ivanova [Sun, 7 Mar 2010 19:42:53 +0000 (21:42 +0200)]
Added a check for permissions to modify the RDN attribute on rename.

Necessary because rdn module will be moved lower than acl in the stack.

9 years agos4:dsdb/dns: change callers of samba_runcmd()
Stefan Metzmacher [Thu, 25 Feb 2010 15:01:15 +0000 (16:01 +0100)]
s4:dsdb/dns: change callers of samba_runcmd()

metze

9 years agolib/util: change samba_runcmd() to use tevent_req _send/_recv
Stefan Metzmacher [Wed, 24 Feb 2010 11:43:45 +0000 (12:43 +0100)]
lib/util: change samba_runcmd() to use tevent_req _send/_recv

metze

9 years agoRevert "Fix bug #7067 - Linux asynchronous IO (aio) can cause smbd to fail to respond...
Karolin Seeger [Mon, 8 Mar 2010 19:34:39 +0000 (20:34 +0100)]
Revert "Fix bug #7067 - Linux asynchronous IO (aio) can cause smbd to fail to respond to a read or write."

This reverts commit a6ae7a552f851a399991262377cc0e062e40ac20.

This fixes bug #7222 (All users have full rigths on all shares) (CVE-2010-0728).
(cherry picked from commit 1c9494c76cc9686c61e0966f38528d3318f3176f)

9 years agos3:build: Fix automatic building of vfs_tsmsm if gpfs and dmapi are present.
Michael Adam [Mon, 8 Mar 2010 21:32:41 +0000 (22:32 +0100)]
s3:build: Fix automatic building of vfs_tsmsm if gpfs and dmapi are present.

Michael

9 years agos3:release-scripts: fix create-tarball to treat vendor patch level correctly
Michael Adam [Mon, 8 Mar 2010 22:37:21 +0000 (23:37 +0100)]
s3:release-scripts: fix create-tarball to treat vendor patch level correctly

9 years agosamba: remove Linux cifs-utils files from samba master branch
Jeff Layton [Mon, 8 Mar 2010 20:05:05 +0000 (15:05 -0500)]
samba: remove Linux cifs-utils files from samba master branch

This patch removes all of the files from the samba tree that should now
be provided by the cifs-utils package. It also drops a
"README.cifs-utils" into the topdir with a URL to the main cifs-utils
webpage. This is for people who don't want the lists and might be taken
by surprise by the change. That's optional, but I think it's a good idea
for a least a release or two.

Signed-off-by: Jeff Layton <jlayton@samba.org>
9 years agos4:"dns_update_list" file: install it properly into the private directory
Matthias Dieter Wallnöfer [Mon, 8 Mar 2010 19:36:16 +0000 (20:36 +0100)]
s4:"dns_update_list" file: install it properly into the private directory

This is what the "samba_dnsupdate" script requests (line 220).

9 years agoRevert "s4:script/installmisc.sh - install "dns_update_list" to target setup folder"
Matthias Dieter Wallnöfer [Mon, 8 Mar 2010 19:30:06 +0000 (20:30 +0100)]
Revert "s4:script/installmisc.sh - install "dns_update_list" to target setup folder"

This reverts commit b49276e291274652d46eed39249c07531e32b591.

9 years agoLDB:asq module - change counters to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Mon, 8 Mar 2010 17:01:32 +0000 (18:01 +0100)]
LDB:asq module - change counters to "unsigned" where appropriate

9 years agoLDB:sort module - change counters to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Mon, 8 Mar 2010 17:01:32 +0000 (18:01 +0100)]
LDB:sort module - change counters to "unsigned" where appropriate

9 years agoLDB:rdn name module - change counters to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Mon, 8 Mar 2010 17:01:32 +0000 (18:01 +0100)]
LDB:rdn name module - change counters to "unsigned" where appropriate

9 years agoLDB:paged searches module - change counters to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Mon, 8 Mar 2010 17:01:32 +0000 (18:01 +0100)]
LDB:paged searches module - change counters to "unsigned" where appropriate

9 years agoLDB:paged results module - change counters to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Mon, 8 Mar 2010 17:01:32 +0000 (18:01 +0100)]
LDB:paged results module - change counters to "unsigned" where appropriate

9 years agos3: add missing Makefile.in changes for vfs_crossrename
Björn Jacke [Mon, 8 Mar 2010 16:53:18 +0000 (17:53 +0100)]
s3: add missing Makefile.in changes for vfs_crossrename

9 years agos3: add man page for vfs_crossrename
Björn Jacke [Mon, 8 Mar 2010 11:38:38 +0000 (12:38 +0100)]
s3: add man page for vfs_crossrename

9 years agos3: add vfs_crossrename
Björn Jacke [Mon, 8 Mar 2010 11:59:40 +0000 (12:59 +0100)]
s3: add vfs_crossrename

this module adds optional server-side support for limited rename operations
beyond filesystem boundaries, which was the previously the default.

9 years agos3: remove cross-device rename support from vfs_default
Björn Jacke [Mon, 8 Mar 2010 11:52:13 +0000 (12:52 +0100)]
s3: remove cross-device rename support from vfs_default

cross-device rename support has some major limitations:

- on huge files clients will timeout or hang
- ACLs and EA information is not retained

Usually a client will have to handle this. A Windows Server with a reparse
point will also just return NT_STATUS_NOT_SAME_DEVICE. We will now by default
do the same.

I will add a vfs module which will restore the old cross-device renames.

9 years agosamba: remove cifs-utils tools from build systems
Jeff Layton [Mon, 8 Mar 2010 14:06:40 +0000 (09:06 -0500)]
samba: remove cifs-utils tools from build systems

Now that cifs-utils are their own project, we need to go ahead and pull
them out of the samba tree. This patch represents the first step toward
that end.

Remove the cifs-utilities from the source3 and source4 builds. Please
pay particular attention to the source4 piece. I'm not at all familiar
with the build system there, and would appreciate someone sanity
checking my changes.

It also adds a small README.cifs-utils file in the topdir. This is
optional, but I think it's a good idea to carry this for a release or
two.

Once this patch looks ok, I'll plan to do another patch to actually
remove the client dir and the relevant docs-xml files from the tree
altogether.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
9 years agoLDB:common - Change counters to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Fri, 6 Nov 2009 17:35:17 +0000 (18:35 +0100)]
LDB:common - Change counters to "unsigned" where appropriate

To count LDB objects use variables of type "unsigned (int)" or "long long int"
on binary or downto searches.

To count characters in strings use "size_t".

To calculate differences between pointers use "ptrdiff_t".

9 years agos4:LDB TDB index code - reintroduce accidentally removed code part
Matthias Dieter Wallnöfer [Mon, 8 Mar 2010 10:43:40 +0000 (11:43 +0100)]
s4:LDB TDB index code - reintroduce accidentally removed code part

This was removed by 95d726f3018ef5d249f89d56bde24b7ee0c24ecf. Sorry.

9 years agos4:ldb_ldap.c - fix indentation
Matthias Dieter Wallnöfer [Mon, 8 Mar 2010 08:58:28 +0000 (09:58 +0100)]
s4:ldb_ldap.c - fix indentation

9 years agoLDB:TDB backend - change counter variables to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Fri, 6 Nov 2009 17:35:17 +0000 (18:35 +0100)]
LDB:TDB backend - change counter variables to "unsigned" where appropriate

9 years agoLDB:SQLITE3 backend - change counter variables to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Fri, 6 Nov 2009 17:35:17 +0000 (18:35 +0100)]
LDB:SQLITE3 backend - change counter variables to "unsigned" where appropriate

9 years agoLDB:LDAP backend - change a counter variable to "unsigned"
Matthias Dieter Wallnöfer [Fri, 6 Nov 2009 17:35:17 +0000 (18:35 +0100)]
LDB:LDAP backend - change a counter variable to "unsigned"

9 years agoLDB:map - make LDB "signed-safe" on counter variables where appropriate
Matthias Dieter Wallnöfer [Fri, 6 Nov 2009 17:35:17 +0000 (18:35 +0100)]
LDB:map - make LDB "signed-safe" on counter variables where appropriate

9 years agos4:ldif_handlers - Change "unsigned int" to "uint32_t" which fits better here
Matthias Dieter Wallnöfer [Mon, 8 Mar 2010 07:02:32 +0000 (08:02 +0100)]
s4:ldif_handlers - Change "unsigned int" to "uint32_t" which fits better here

9 years agos4-gensec: Fixed wrong usage of error_string.
Andreas Schneider [Wed, 3 Mar 2010 14:15:03 +0000 (15:15 +0100)]
s4-gensec: Fixed wrong usage of error_string.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
9 years agos4:extended_dn_out LDB module - change counter variables to "unsigned" where appropriate
Matthias Dieter Wallnöfer [Sun, 7 Mar 2010 18:03:21 +0000 (19:03 +0100)]
s4:extended_dn_out LDB module - change counter variables to "unsigned" where appropriate