ira/wip.git
10 years agos4:upgradeschema.py Cleanup
Matthieu Patou [Tue, 24 Nov 2009 14:02:59 +0000 (17:02 +0300)]
s4:upgradeschema.py Cleanup

- remove some useless comments
- remove hardcoded paths

(commit message clarified by Andrew Bartlett)
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
10 years agoRemove call into reduce_name if case sensitive. This allows us to pass
Jeremy Allison [Wed, 25 Nov 2009 00:40:08 +0000 (16:40 -0800)]
Remove call into reduce_name if case sensitive. This allows us to pass
RAW-CHKPATH when case sensitive = yes, but isn't the correct way to do
it. I'm testing a larger patch to smbd/filename.c that should fix this
correctly, and will add a torture test to ensure RAW-CHKPATH is run against
a case sensitive share once this is done.
Jeremy.

10 years agos4:installmisc - install also the new "domainlevel" tool from the setup dir
Matthias Dieter Wallnöfer [Tue, 24 Nov 2009 21:24:00 +0000 (22:24 +0100)]
s4:installmisc - install also the new "domainlevel" tool from the setup dir

10 years agos4: Check SUN compiler and remove "-fullwarn" when using it
Brian Lu [Tue, 24 Nov 2009 21:10:22 +0000 (22:10 +0100)]
s4: Check SUN compiler and remove "-fullwarn" when using it

This option is only supported by "gcc".
For details consider https://bugzilla.samba.org/show_bug.cgi?id=6905

Signed-off-by: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
10 years agoAllow us to pass RAW-CHKPATH with FILE_FLAG_POSIX_SEMANTICS set or with
Jeremy Allison [Tue, 24 Nov 2009 22:05:56 +0000 (14:05 -0800)]
Allow us to pass RAW-CHKPATH with FILE_FLAG_POSIX_SEMANTICS set or with
wide links = no.
Jeremy.

10 years agoFix make test. Only do POSIX case conversion if FILE_FLAG_POSIX_SEMANTICS set. Doh !
Jeremy Allison [Tue, 24 Nov 2009 21:02:34 +0000 (13:02 -0800)]
Fix make test. Only do POSIX case conversion if FILE_FLAG_POSIX_SEMANTICS set. Doh !
Jeremy.

10 years agoRevert "s4-netlogon: always set the dNSHostName in GetDomainInfo"
Matthias Dieter Wallnöfer [Tue, 24 Nov 2009 19:30:07 +0000 (20:30 +0100)]
Revert "s4-netlogon: always set the dNSHostName in GetDomainInfo"

This reverts commit 87b6f2e863c6e117643ab6704e50167e849b69cc.

This was the cause of the breakage of the "LogonGetDomainInfo" testsuite. I
think my behaviour is more correct to Windows Server since the test works
against it (at least release 2003 R2).

One problem I discovered is that freshly joined workstations don't get their
DNS name into the directory. Therefore I think also another part (maybe another
RPC call) is able to do this.

10 years agos4:ldap.py - fix the schema update test on Windows Server
Matthias Dieter Wallnöfer [Tue, 24 Nov 2009 18:44:18 +0000 (19:44 +0100)]
s4:ldap.py - fix the schema update test on Windows Server

Apparently Windows Server (2003) doesn't like the comma delimiter here. I got
always error 16 ("LDB_NO_SUCH_ATTRIBUTE"). With this change the test works
again.

10 years agos4:libnet_become_dc - fix typo
Matthias Dieter Wallnöfer [Tue, 24 Nov 2009 18:17:08 +0000 (19:17 +0100)]
s4:libnet_become_dc - fix typo

10 years agos3: Always try SamLogonEx
Volker Lendecke [Tue, 24 Nov 2009 15:51:30 +0000 (16:51 +0100)]
s3: Always try SamLogonEx

Required for cluster systems working in a Samba domain. With NT4 this won't
work, but real NT4 DCs should not be around in environments that pay big bucks
for a cluster... And if they are, they can always install a Samba DC trusting
that NT4 domain.

10 years agos3-spoolss: re-arrange driver info level fillup functions.
Günther Deschner [Mon, 23 Nov 2009 14:31:58 +0000 (15:31 +0100)]
s3-spoolss: re-arrange driver info level fillup functions.

Guenther

10 years agos3-spoolss: fixes for _spoolss_EnumPrinterKey client and server.
Günther Deschner [Tue, 24 Nov 2009 14:22:04 +0000 (15:22 +0100)]
s3-spoolss: fixes for _spoolss_EnumPrinterKey client and server.

Thanks Metze for review!

Guenther

10 years agos3-registry: use push_reg_multi_sz() in registry_push_value().
Günther Deschner [Tue, 24 Nov 2009 14:26:32 +0000 (15:26 +0100)]
s3-registry: use push_reg_multi_sz() in registry_push_value().

Guenther

10 years agos3-registry: remove reg_pull_multi_sz().
Günther Deschner [Tue, 24 Nov 2009 14:26:08 +0000 (15:26 +0100)]
s3-registry: remove reg_pull_multi_sz().

Guenther

10 years agos3:torture: use timeval_current/timeval_elapsed instead of start_timer/end_timer
Stefan Metzmacher [Tue, 24 Nov 2009 09:59:09 +0000 (10:59 +0100)]
s3:torture: use timeval_current/timeval_elapsed instead of start_timer/end_timer

metze

10 years agos3:torture/nbio: use timeval_current/timeval_elapsed instead of start_timer/end_timer
Stefan Metzmacher [Tue, 24 Nov 2009 09:41:40 +0000 (10:41 +0100)]
s3:torture/nbio: use timeval_current/timeval_elapsed instead of start_timer/end_timer

metze

10 years agos3:dbwrap_torture: use timeval_current/timeval_elapsed instead of start_timer/end_timer
Stefan Metzmacher [Tue, 24 Nov 2009 09:36:52 +0000 (10:36 +0100)]
s3:dbwrap_torture: use timeval_current/timeval_elapsed instead of start_timer/end_timer

metze

10 years agoRAW-PING-PONG: use timeval_current/timeval_elapsed instead of start_timer/end_timer
Stefan Metzmacher [Tue, 24 Nov 2009 09:18:37 +0000 (10:18 +0100)]
RAW-PING-PONG: use timeval_current/timeval_elapsed instead of start_timer/end_timer

metze

10 years agos3:fix the merged build of bin/smbtorture4
Michael Adam [Tue, 24 Nov 2009 10:43:56 +0000 (11:43 +0100)]
s3:fix the merged build of bin/smbtorture4

Michael

10 years agodocs: Fix Bug 6922: Add Registry patchfile for Win7 domain join.
Günther Deschner [Tue, 24 Nov 2009 10:36:14 +0000 (11:36 +0100)]
docs: Fix Bug 6922: Add Registry patchfile for Win7 domain join.

Patchfile from SATOH Fumiyasu <fumiyas@osstech.co.jp>.

Thanks!

Guenther

10 years agoRestore NtCreateX case handling with FILE_FLAG_POSIX_SEMANTICS to the way
Jeremy Allison [Tue, 24 Nov 2009 05:06:54 +0000 (21:06 -0800)]
Restore NtCreateX case handling with FILE_FLAG_POSIX_SEMANTICS to the way
it worked in 3.3.x and 3.2.x. UCF_POSIX_PATHNAMES may no longer be needed,
as lp_posix_pathnames() being set isn't the same as case handling from
NtCreateX (lp_posix_pathnames() changes the STAT calls to LSTAT, not
the case semantics).
Jeremy.

10 years agos4:param remove reference to private header from source4/param/param.h
Brad Hards [Tue, 24 Nov 2009 02:43:59 +0000 (13:43 +1100)]
s4:param remove reference to private header from source4/param/param.h

source4/param/param.h has a

param.h is a public header (and parmlist isn't, even if the relative path
could work), so I suggest making it a forward declaration in the header, and
including parmlist.h in the implementation.

(commit message included from e-mail by Andrew Bartlett)
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
10 years agos4: Fix missing TLS dir when targetdir is not the default one
Matthieu Patou [Sun, 22 Nov 2009 17:51:24 +0000 (20:51 +0300)]
s4: Fix missing TLS dir when targetdir is not the default one

10 years agoRemove unused code.
Jeremy Allison [Tue, 24 Nov 2009 02:00:36 +0000 (18:00 -0800)]
Remove unused code.
Jeremy.

10 years agoheimdal Fix invalid format string
Andrew Bartlett [Tue, 24 Nov 2009 00:38:41 +0000 (11:38 +1100)]
heimdal Fix invalid format string

10 years agos4:dsdb Handle LDAP backends correctly with new samba_dsdb system
Andrew Bartlett [Tue, 24 Nov 2009 00:36:34 +0000 (11:36 +1100)]
s4:dsdb Handle LDAP backends correctly with new samba_dsdb system

The original code had the wrong module names, and use strcasecmp()
incorrectly.

Andrew Bartlett

10 years agos4:provision Move exceptions into a new file
Andrew Bartlett [Tue, 24 Nov 2009 00:09:30 +0000 (11:09 +1100)]
s4:provision Move exceptions into a new file

This allows provisionbackend and provision to both raise ProvisionException

10 years agos4:provision Don't bother with a template for the LDAP backend startup script.
Andrew Bartlett [Tue, 24 Nov 2009 00:00:12 +0000 (11:00 +1100)]
s4:provision Don't bother with a template for the LDAP backend startup script.

10 years agos4:provision Move secrets.ldb over to .c file module lists, like sam.ldb
Andrew Bartlett [Mon, 23 Nov 2009 23:36:28 +0000 (10:36 +1100)]
s4:provision Move secrets.ldb over to .c file module lists, like sam.ldb

10 years agos4:ldap.py - activate test for operational attributes
Matthias Dieter Wallnöfer [Sun, 22 Nov 2009 13:59:21 +0000 (14:59 +0100)]
s4:ldap.py - activate test for operational attributes

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
10 years agos4:operational LDB module - Prevent the modification of operational attributes
Andrew Bartlett [Mon, 23 Nov 2009 23:22:10 +0000 (10:22 +1100)]
s4:operational LDB module - Prevent the modification of operational attributes

(merged by Andrew Bartlett)

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
10 years agos4:ldap.py Add tests for subSchemaSubEntry
Andrew Bartlett [Mon, 23 Nov 2009 23:18:33 +0000 (10:18 +1100)]
s4:ldap.py Add tests for subSchemaSubEntry

10 years agos4:dsdb Use new helper function to obtain CN=Aggregate schema DN in schema_data
Andrew Bartlett [Mon, 23 Nov 2009 23:18:02 +0000 (10:18 +1100)]
s4:dsdb Use new helper function to obtain CN=Aggregate schema DN in schema_data

10 years agos4:dsdb Return the subSchemaSubEntry operational attribute on every object
Andrew Bartlett [Mon, 23 Nov 2009 23:17:18 +0000 (10:17 +1100)]
s4:dsdb Return the subSchemaSubEntry operational attribute on every object

10 years agos4:dsdb Add function to return the CN=Aggregate schema DN
Andrew Bartlett [Mon, 23 Nov 2009 23:16:56 +0000 (10:16 +1100)]
s4:dsdb Add function to return the CN=Aggregate schema DN

10 years agos4:provision Remove 'operational' from secrets.ldb module list
Andrew Bartlett [Mon, 23 Nov 2009 23:15:28 +0000 (10:15 +1100)]
s4:provision Remove 'operational' from secrets.ldb module list

10 years agoProper fix for #6898 - Samba duplicates file content on appending. Pointed out by...
Jeremy Allison [Mon, 23 Nov 2009 23:01:34 +0000 (15:01 -0800)]
Proper fix for #6898 - Samba duplicates file content on appending. Pointed out by Volker.Restores the pathname handling for FILE_FLAG_POSIX_SEMANTICS but still prevents the O_APPEND problems. Jeremy.

10 years agos3: add dbwrap_torture - a tool to stress test tdb transactions through dbwrap
Michael Adam [Fri, 20 Nov 2009 23:48:40 +0000 (00:48 +0100)]
s3: add dbwrap_torture - a tool to stress test tdb transactions through dbwrap

This can be used to also test tdb transactions on clustered installations
throught ctdb. The test is modeled after the ctdb_transaction.c test program
from the ctdb source code. It runs transactions in a tight loop on a test
database called "transactions.tdb" (by default), increasing a counter in each
iteration. In a clustered environment, a counter is maintained for each node.

Michael

10 years agos3:torture: move the torture-specific headers to new torture/torture.h
Michael Adam [Fri, 20 Nov 2009 16:47:21 +0000 (17:47 +0100)]
s3:torture: move the torture-specific headers to new torture/torture.h

Michael

10 years agos3:idmap_ldap: fix indentation: tab/space mixup
Michael Adam [Fri, 20 Nov 2009 14:03:59 +0000 (15:03 +0100)]
s3:idmap_ldap: fix indentation: tab/space mixup

Michael

10 years agoFix bug #6898 - Samba duplicates file content on appending
Jeremy Allison [Mon, 23 Nov 2009 18:09:47 +0000 (10:09 -0800)]
Fix bug #6898 - Samba duplicates file content on appending
Clients using a Windows open call should not be able to set
FILE_FLAG_POSIX_SEMANTICS in an open.
Jeremy.

10 years agos3-spoolss: Fix GetPrinter level 101.
Günther Deschner [Mon, 23 Nov 2009 15:54:34 +0000 (16:54 +0100)]
s3-spoolss: Fix GetPrinter level 101.

Guenther

10 years agoRevert "s3: Make the implicit reference to Protocol in mask_match() explicit"
Volker Lendecke [Mon, 23 Nov 2009 15:34:07 +0000 (16:34 +0100)]
Revert "s3: Make the implicit reference to Protocol in mask_match() explicit"

This reverts commit e23d8a3d1f558a7e98ef2afd71e1d15c5b3a71bc.

10 years agoRevert "s3: Make the implicit reference to Protocol in mask_match_list() explicit"
Volker Lendecke [Mon, 23 Nov 2009 15:34:00 +0000 (16:34 +0100)]
Revert "s3: Make the implicit reference to Protocol in mask_match_list() explicit"

This reverts commit 1e22899d268ae5a089f941a204413c07ee64fc78.

10 years agoRevert "s3: Make the implicit reference to Protocol in is_in_path() explicit"
Volker Lendecke [Mon, 23 Nov 2009 15:33:53 +0000 (16:33 +0100)]
Revert "s3: Make the implicit reference to Protocol in is_in_path() explicit"

This reverts commit f7b4151a64d8c6851e62255a7139fd00a5fc63a3.

10 years agoRevert "s3: Make the implicit reference to get_Protocol in lp_use_sendfile() explicit"
Volker Lendecke [Mon, 23 Nov 2009 15:33:45 +0000 (16:33 +0100)]
Revert "s3: Make the implicit reference to get_Protocol in lp_use_sendfile() explicit"

This reverts commit 6a149022976fe6a5579ec9afc7a4d2dcb44dc8af.

10 years agoRevert "s3: Move the global variable Protocol to struct smbd_server_connection"
Volker Lendecke [Mon, 23 Nov 2009 15:33:26 +0000 (16:33 +0100)]
Revert "s3: Move the global variable Protocol to struct smbd_server_connection"

This reverts commit c85a4c9ba4a7de65a7850f6f9708df66bd24deea.

10 years agos4:ldap.py - Add a check for the generated "schemaIDGUID"
Matthias Dieter Wallnöfer [Mon, 23 Nov 2009 15:20:07 +0000 (16:20 +0100)]
s4:ldap.py - Add a check for the generated "schemaIDGUID"

I've forgotten to add this when checking in the reworked SAMLDB module

10 years agos3-winbind: In _wbint_CheckMachineAccount, there is only one child domain ever
Volker Lendecke [Mon, 23 Nov 2009 12:58:23 +0000 (13:58 +0100)]
s3-winbind: In _wbint_CheckMachineAccount, there is only one child domain ever

10 years agos3: Move a variable declaration to its only use
Volker Lendecke [Mon, 23 Nov 2009 10:54:19 +0000 (11:54 +0100)]
s3: Move a variable declaration to its only use

10 years agos4:dsdb Move module configuration from each ldb into samba_dsdb.c
Andrew Bartlett [Mon, 23 Nov 2009 09:30:35 +0000 (20:30 +1100)]
s4:dsdb Move module configuration from each ldb into samba_dsdb.c

This makes getting the module order correct, the obligation of Samba4
developers, and not system administrators.  In particular, once an ldb
is updated to use only the 'samba_dsdb' module, no further changes to the
ldb should be required when upgrading to later Samba4 versions.

(thanks to metze for the suggestion of samba_dsdb as a long-term
stable name for the module)

Andrew Bartlett

10 years agos4:provision Simplify the module list
Andrew Bartlett [Fri, 20 Nov 2009 01:16:33 +0000 (12:16 +1100)]
s4:provision Simplify the module list

This makes the member server much more like the DC, the objectGUID
module replaces the repl_meta_data module.

We also generally rework the construction of the list, building a full
list in python, and then transforming it into a string, rather than
playing string concatonation games

Andrew Bartlett

10 years agos4/schema(tort): Refactor DSDB-SYNTAX test for better performance
Kamen Mazdrashki [Sun, 22 Nov 2009 20:21:12 +0000 (22:21 +0200)]
s4/schema(tort): Refactor DSDB-SYNTAX test for better performance

Test was implemented as a test fixture so that setup/teardown
occurs only once.
This should impact test performace as long as provision_get_schema()
is a slow function (especially when debugging)

10 years agos4/schema: Handle Object(OR-Name) syntax in extended_dn_out module
Kamen Mazdrashki [Sun, 22 Nov 2009 15:48:32 +0000 (17:48 +0200)]
s4/schema: Handle Object(OR-Name) syntax in extended_dn_out module

Windows displays attribute values with Object(OR-Name) syntax
in plain DN format when queried through LDAP.
Hence, we need to post-process such values specially
in extended_dn_out.c module so they are always shown as plain DN,
no matter what controls are passed for search request.

10 years agos4/schema: Object(OR-Name) syntax handling for DRS calls
Kamen Mazdrashki [Sun, 22 Nov 2009 12:41:25 +0000 (14:41 +0200)]
s4/schema: Object(OR-Name) syntax handling for DRS calls

OR-Name syntax through DRS calls looks like DN-Binary syntax

10 years agos4/schema(tort): Inject authOrig attribute into schema loaded for tests
Kamen Mazdrashki [Fri, 20 Nov 2009 01:07:41 +0000 (03:07 +0200)]
s4/schema(tort): Inject authOrig attribute into schema loaded for tests

10 years agos4/schema(tort): Add test for Object(OR-Name) syntax
Kamen Mazdrashki [Sun, 22 Nov 2009 12:46:09 +0000 (14:46 +0200)]
s4/schema(tort): Add test for Object(OR-Name) syntax

10 years agos4/schema(tort): Test LDB_SYNTAX_DN with extended_dn in [GUID;SID;DN] form
Kamen Mazdrashki [Fri, 20 Nov 2009 01:15:38 +0000 (03:15 +0200)]
s4/schema(tort): Test LDB_SYNTAX_DN with extended_dn in [GUID;SID;DN] form

10 years agos4/drs(tort): DSSYNC test to print what is different in drs_msg also
Kamen Mazdrashki [Mon, 16 Nov 2009 21:49:51 +0000 (23:49 +0200)]
s4/drs(tort): DSSYNC test to print what is different in drs_msg also

10 years agos4-smbtorture: fix spoolss_EnumPrinterKey client in RPC-SPOOLSS-WIN.
Günther Deschner [Mon, 23 Nov 2009 12:35:32 +0000 (13:35 +0100)]
s4-smbtorture: fix spoolss_EnumPrinterKey client in RPC-SPOOLSS-WIN.

Guenther

10 years agos3-printing: remove duplicate code while cleaning up driver structs.
Günther Deschner [Mon, 23 Nov 2009 11:57:46 +0000 (12:57 +0100)]
s3-printing: remove duplicate code while cleaning up driver structs.

Guenther

10 years agos3-spoolss: move more defines out of nt_printing.h to spoolss.idl where they belong.
Günther Deschner [Wed, 18 Nov 2009 14:39:52 +0000 (15:39 +0100)]
s3-spoolss: move more defines out of nt_printing.h to spoolss.idl where they belong.

Guenther

10 years agos3-printing: remove unused NT_PRINTER_DRIVER_INFO_LEVEL structs.
Günther Deschner [Tue, 17 Nov 2009 11:55:45 +0000 (12:55 +0100)]
s3-printing: remove unused NT_PRINTER_DRIVER_INFO_LEVEL structs.

Guenther

10 years agos3-printing: use spoolss types and structs while getting and deleting drivers.
Günther Deschner [Tue, 17 Nov 2009 11:54:02 +0000 (12:54 +0100)]
s3-printing: use spoolss types and structs while getting and deleting drivers.

Guenther

10 years agos3-printing: use spoolss types and structs while adding drivers.
Günther Deschner [Mon, 16 Nov 2009 14:52:31 +0000 (15:52 +0100)]
s3-printing: use spoolss types and structs while adding drivers.

Guenther

10 years agos4-smbtorture: add tests for spoolss_EnumPrinterKey to RPC-SPOOLSS-PRINTER.
Günther Deschner [Fri, 20 Nov 2009 15:33:29 +0000 (16:33 +0100)]
s4-smbtorture: add tests for spoolss_EnumPrinterKey to RPC-SPOOLSS-PRINTER.

Guenther

10 years agos3-spoolss: fix spoolss_EnumPrinterKey client and server code.
Günther Deschner [Fri, 20 Nov 2009 15:34:00 +0000 (16:34 +0100)]
s3-spoolss: fix spoolss_EnumPrinterKey client and server code.

Guenther

10 years agospoolss: fix spoolss_EnumPrinterKey IDL.
Günther Deschner [Fri, 20 Nov 2009 11:57:13 +0000 (12:57 +0100)]
spoolss: fix spoolss_EnumPrinterKey IDL.

Guenther

10 years agos3: Fix bug 6338 -- net rpc trustdom list always display "none"
Volker Lendecke [Sun, 22 Nov 2009 21:38:45 +0000 (22:38 +0100)]
s3: Fix bug 6338 -- net rpc trustdom list always display "none"

10 years agos4:netlogon RPC - Remove trailing whitespace
Matthias Dieter Wallnöfer [Sun, 22 Nov 2009 14:54:16 +0000 (15:54 +0100)]
s4:netlogon RPC - Remove trailing whitespace

10 years agos4:netlogon RPC - Fix up the error handling
Matthias Dieter Wallnöfer [Sun, 22 Nov 2009 14:51:18 +0000 (15:51 +0100)]
s4:netlogon RPC - Fix up the error handling

10 years agos4:netlogon RPC - Fix up a comment
Matthias Dieter Wallnöfer [Sun, 22 Nov 2009 14:50:36 +0000 (15:50 +0100)]
s4:netlogon RPC - Fix up a comment

Now we have Windows 7 released so don't refer to a beta anymore.

10 years agoFixed incorrect indentation.
Nadezhda Ivanova [Sun, 22 Nov 2009 11:36:35 +0000 (13:36 +0200)]
Fixed incorrect indentation.

10 years agos3: Fix some nonempty blank lines
Volker Lendecke [Sat, 21 Nov 2009 21:52:12 +0000 (22:52 +0100)]
s3: Fix some nonempty blank lines

10 years agos3: Remove a struct typedef
Volker Lendecke [Sat, 21 Nov 2009 20:36:01 +0000 (21:36 +0100)]
s3: Remove a struct typedef

10 years agos3: Make alloc_sub_basic() static
Volker Lendecke [Sat, 21 Nov 2009 19:23:35 +0000 (20:23 +0100)]
s3: Make alloc_sub_basic() static

10 years agos3: Move the global variable Protocol to struct smbd_server_connection
Volker Lendecke [Sat, 21 Nov 2009 18:57:41 +0000 (19:57 +0100)]
s3: Move the global variable Protocol to struct smbd_server_connection

10 years agos3: Make the implicit reference to get_Protocol in lp_use_sendfile() explicit
Volker Lendecke [Sat, 21 Nov 2009 18:37:27 +0000 (19:37 +0100)]
s3: Make the implicit reference to get_Protocol in lp_use_sendfile() explicit

10 years agos3: Make the implicit reference to Protocol in is_in_path() explicit
Volker Lendecke [Sat, 21 Nov 2009 18:26:25 +0000 (19:26 +0100)]
s3: Make the implicit reference to Protocol in is_in_path() explicit

10 years agos3: Make the implicit reference to Protocol in mask_match_list() explicit
Volker Lendecke [Sat, 21 Nov 2009 18:04:34 +0000 (19:04 +0100)]
s3: Make the implicit reference to Protocol in mask_match_list() explicit

10 years agos3: Make the implicit reference to Protocol in mask_match() explicit
Volker Lendecke [Sat, 21 Nov 2009 18:04:34 +0000 (19:04 +0100)]
s3: Make the implicit reference to Protocol in mask_match() explicit

10 years agomount.cifs: Fix a const error
Volker Lendecke [Sat, 21 Nov 2009 18:03:45 +0000 (19:03 +0100)]
mount.cifs: Fix a const error

10 years agos3: Fix some nonempty blank lines
Volker Lendecke [Sat, 21 Nov 2009 15:17:16 +0000 (16:17 +0100)]
s3: Fix some nonempty blank lines

10 years agos3: Avoid two calls to strcmp()
Volker Lendecke [Sat, 21 Nov 2009 15:15:16 +0000 (16:15 +0100)]
s3: Avoid two calls to strcmp()

10 years agos3: Fix a bool/enum mismatch
Volker Lendecke [Sat, 21 Nov 2009 15:10:52 +0000 (16:10 +0100)]
s3: Fix a bool/enum mismatch

10 years agos4:lsa RPC - Fix type of variable "atype"
Matthias Dieter Wallnöfer [Sat, 21 Nov 2009 18:49:56 +0000 (19:49 +0100)]
s4:lsa RPC - Fix type of variable "atype"

This is an unsigned 32bit integer.

10 years agos4:samr RPC - Use more LDB constants
Matthias Dieter Wallnöfer [Sat, 21 Nov 2009 18:25:42 +0000 (19:25 +0100)]
s4:samr RPC - Use more LDB constants

10 years agos4:lsa RPC - Use more LDB constants
Matthias Dieter Wallnöfer [Sat, 21 Nov 2009 18:46:25 +0000 (19:46 +0100)]
s4:lsa RPC - Use more LDB constants

And fix an obvious bug (call of "samdb_msg_add_delete")

10 years agoImplemented LDAP_SERVER_SD_FLAGS_OID on search requests.
Nadezhda Ivanova [Sat, 21 Nov 2009 16:40:51 +0000 (18:40 +0200)]
Implemented LDAP_SERVER_SD_FLAGS_OID on search requests.

10 years agos4:torture/smb2/oplock - Remove unneeded "status" redeclarations
Matthias Dieter Wallnöfer [Sat, 21 Nov 2009 16:33:04 +0000 (17:33 +0100)]
s4:torture/smb2/oplock - Remove unneeded "status" redeclarations

10 years agos4:torture/smb2/notify - Rename nested "fname" variable to prevent warnings
Matthias Dieter Wallnöfer [Sat, 21 Nov 2009 16:32:07 +0000 (17:32 +0100)]
s4:torture/smb2/notify - Rename nested "fname" variable to prevent warnings

10 years agos4:torture/raw/unlink - Remove unused variable and label
Matthias Dieter Wallnöfer [Sat, 21 Nov 2009 16:23:31 +0000 (17:23 +0100)]
s4:torture/raw/unlink - Remove unused variable and label

10 years agos4:torture/rpc/netlogon - Fix uninitialised variable
Matthias Dieter Wallnöfer [Sat, 21 Nov 2009 16:22:07 +0000 (17:22 +0100)]
s4:torture/rpc/netlogon - Fix uninitialised variable

10 years agos3: Convert cli_get_fs_attr_info to the async API
Volker Lendecke [Sat, 21 Nov 2009 12:46:52 +0000 (13:46 +0100)]
s3: Convert cli_get_fs_attr_info to the async API

10 years agos3: Tune if-conditions in a very hot codepath
Volker Lendecke [Sun, 15 Nov 2009 21:22:38 +0000 (22:22 +0100)]
s3: Tune if-conditions in a very hot codepath

This looks innocent, but it is visible in a netbench run.  Due to boolean
short-circuiting we don't have to execute the conditions on the right-hand side
of the &&. So putting the less likely condition left gains a bit.

10 years agos3: Remove a pointless memset
Volker Lendecke [Mon, 16 Nov 2009 07:54:55 +0000 (08:54 +0100)]
s3: Remove a pointless memset

We are assigning the complete structure now (we used to assign individual
fields), so this is obsolete.

10 years agos3: Cache brlock.tdb entries for the fast read&write strict locking code path
Volker Lendecke [Mon, 16 Nov 2009 08:40:47 +0000 (09:40 +0100)]
s3: Cache brlock.tdb entries for the fast read&write strict locking code path

For a netbench run this gains around 2% user-space CPU, fetching a 100MB file
takes around 4% less.

10 years agos4:WINREG RPC server - Cosmetic
Matthias Dieter Wallnöfer [Wed, 18 Nov 2009 07:53:22 +0000 (08:53 +0100)]
s4:WINREG RPC server - Cosmetic

10 years agontlm_auth: use data_blob_talloc() to allocate session key
Kai Blin [Wed, 18 Nov 2009 10:26:57 +0000 (11:26 +0100)]
ntlm_auth: use data_blob_talloc() to allocate session key

Thanks to Shibu Piriyath <shibunair80@ymail.com> for spotting the issue.

10 years agoFix logic bug where high bits tests was being
Jeremy Allison [Sat, 21 Nov 2009 01:23:20 +0000 (17:23 -0800)]
Fix logic bug where high bits tests was being
done on both Windows and POSIX mkdirs instead of
only on Windows mkdir (as intended). The variable
"file_attributes" had already had FILE_FLAG_POSIX_SEMANTICS
removed above in the function if it had already been set.
Jeremy.