ira/wip.git
8 years agos3-masktest: Fix cli_errstr() usage (part of bug #7864)
Björn Baumbach [Thu, 20 Jan 2011 13:08:42 +0000 (14:08 +0100)]
s3-masktest: Fix cli_errstr() usage (part of bug #7864)

Convert cli_errstr() to nt_errstr()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
8 years agos3-smbclient: Fix cli_errstr() usage (part of bug #7864)
Björn Baumbach [Mon, 17 Jan 2011 11:02:39 +0000 (12:02 +0100)]
s3-smbclient: Fix cli_errstr() usage (part of bug #7864)

Convert cli_errstr() to nt_errstr()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
8 years agos3-torture: Fix cli_errstr() usage (part of bug #7864)
Björn Baumbach [Mon, 17 Jan 2011 12:03:05 +0000 (13:03 +0100)]
s3-torture: Fix cli_errstr() usage (part of bug #7864)

Convert cli_errstr() to nt_errstr()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
8 years agos3-docs: fix deldriver option
Björn Baumbach [Mon, 17 Jan 2011 08:51:45 +0000 (09:51 +0100)]
s3-docs: fix deldriver option

Signed-off-by: Stefan Metzmacher <metze@samba.org>
8 years agos3-docs: add some long opts to smbclient(1) man
Björn Baumbach [Fri, 14 Jan 2011 11:35:55 +0000 (12:35 +0100)]
s3-docs: add some long opts to smbclient(1) man

Signed-off-by: Stefan Metzmacher <metze@samba.org>
8 years agos4-waf: Skip header-not-found cache if a library is specified, as it may provide
Jelmer Vernooij [Tue, 25 Jan 2011 02:09:27 +0000 (18:09 -0800)]
s4-waf: Skip header-not-found cache if a library is specified, as it may provide
additional C flags.

Tridge, please check.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Tue Jan 25 03:59:32 CET 2011 on sn-devel-104

8 years agos4-waf: Only show minversion when there was a minimum version specified.
Jelmer Vernooij [Tue, 25 Jan 2011 01:15:49 +0000 (17:15 -0800)]
s4-waf: Only show minversion when there was a minimum version specified.

8 years agoShow text output messages when interfacing with bzr.
Jelmer Vernooij [Tue, 25 Jan 2011 01:14:50 +0000 (17:14 -0800)]
Show text output messages when interfacing with bzr.

8 years agoremove unnecessary use of pass.
Jelmer Vernooij [Mon, 3 Jan 2011 05:54:07 +0000 (06:54 +0100)]
remove unnecessary use of pass.

8 years agos3-build: remove source4 include path for autoconf build as well.
Günther Deschner [Mon, 24 Jan 2011 15:55:05 +0000 (16:55 +0100)]
s3-build: remove source4 include path for autoconf build as well.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Jan 24 17:40:56 CET 2011 on sn-devel-104

8 years agos3-rpcclient: allow to define validation level for samlogon.
Günther Deschner [Fri, 21 Jan 2011 15:58:32 +0000 (16:58 +0100)]
s3-rpcclient: allow to define validation level for samlogon.

Guenther

8 years agos3-waf: fix lib/addns include path.
Günther Deschner [Mon, 24 Jan 2011 14:27:52 +0000 (15:27 +0100)]
s3-waf: fix lib/addns include path.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Jan 24 16:15:58 CET 2011 on sn-devel-104

8 years agos3-waf: no need anymore to include "source4" globally.
Günther Deschner [Mon, 24 Jan 2011 14:26:11 +0000 (15:26 +0100)]
s3-waf: no need anymore to include "source4" globally.

Guenther

8 years agolibcli/ldap: use lib/ldb_compat.h for the s3 build
Stefan Metzmacher [Mon, 24 Jan 2011 12:29:14 +0000 (13:29 +0100)]
libcli/ldap: use lib/ldb_compat.h for the s3 build

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Jan 24 14:55:50 CET 2011 on sn-devel-104

8 years agos3-winbind: fix winbindd_dual_pam_auth_samlogon() for NT4 domains.
Günther Deschner [Mon, 24 Jan 2011 10:48:36 +0000 (11:48 +0100)]
s3-winbind: fix winbindd_dual_pam_auth_samlogon() for NT4 domains.

After failing the netr_LogonSamLogonEx, we failed to retry with
netr_LogonSamLogon.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Jan 24 12:35:42 CET 2011 on sn-devel-104

8 years agoRevert "s3: Fix an infinite loop"
Volker Lendecke [Mon, 24 Jan 2011 08:25:01 +0000 (09:25 +0100)]
Revert "s3: Fix an infinite loop"

This reverts commit 61f7d7cdeccb1f733590e8bdb8229b32363a815e.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Jan 24 10:10:43 CET 2011 on sn-devel-104

8 years agos3: Fix an infinite loop
Volker Lendecke [Sun, 23 Jan 2011 08:12:43 +0000 (09:12 +0100)]
s3: Fix an infinite loop

If select returns EBADF (which should NEVER happen), then we loop infinitely
because the select masks seem all active.

I've been given an strace where smbd floods syslog with inotify-related
error messages. The strace shows that select returns EBADF, and we're calling
the inotify event callback. It then complains there's no data on the inotify
fd.

Metze, please check!

We might need to fix this in 3.4 and 3.5 as well. And we need to find the
deeper reason where we close a file descriptor and don't tell the events
system about it.

Volker

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Jan 23 10:05:39 CET 2011 on sn-devel-104

8 years agos3: Fix connecting to port-139 only servers
Volker Lendecke [Sat, 22 Jan 2011 15:22:42 +0000 (16:22 +0100)]
s3: Fix connecting to port-139 only servers

When the TCP RST came before the 5 msecs timeout kicked in, we
viewed this as final, as state->req_139 was not set yet.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Jan 22 17:42:41 CET 2011 on sn-devel-104

8 years agos4-repl_meta_data: replmd_update_is_newer() should not return true if metadata stamps...
Kamen Mazdrashki [Fri, 21 Jan 2011 20:51:05 +0000 (22:51 +0200)]
s4-repl_meta_data: replmd_update_is_newer() should not return true if metadata stamps are equal

Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Sat Jan 22 12:22:30 CET 2011 on sn-devel-104

8 years agos4-repl_meta_data: Print out what is wrong when we fail to modify object
Kamen Mazdrashki [Fri, 21 Jan 2011 00:39:23 +0000 (02:39 +0200)]
s4-repl_meta_data: Print out what is wrong when we fail to modify object

8 years agos4-repl_meta_data: We should not use USNs in metadata comparisons
Kamen Mazdrashki [Fri, 21 Jan 2011 00:38:25 +0000 (02:38 +0200)]
s4-repl_meta_data: We should not use USNs in metadata comparisons

If object is changed by same DC, then version should be incremented

8 years agos3-torture: fix uninitialized status code.
Günther Deschner [Fri, 21 Jan 2011 14:35:11 +0000 (15:35 +0100)]
s3-torture: fix uninitialized status code.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jan 21 16:52:34 CET 2011 on sn-devel-104

8 years agos3-rpc_client: fix dcerpc_try_samr_connects().
Günther Deschner [Fri, 21 Jan 2011 15:02:18 +0000 (16:02 +0100)]
s3-rpc_client: fix dcerpc_try_samr_connects().

Only return when both results are ok.

Guenther

8 years agos3-rpc_client: no need to include gen_ndr/cli_samr.h anymore.
Günther Deschner [Fri, 21 Jan 2011 15:00:31 +0000 (16:00 +0100)]
s3-rpc_client: no need to include gen_ndr/cli_samr.h anymore.

Guenther

8 years agos3-rpc_client: fix uninitialized variable found by -O3.
Günther Deschner [Fri, 21 Jan 2011 14:51:05 +0000 (15:51 +0100)]
s3-rpc_client: fix uninitialized variable found by -O3.

Guenther

8 years agos3-waf: remove RPCCLI_SPOOLSS subsystem.
Günther Deschner [Tue, 18 Jan 2011 22:16:42 +0000 (23:16 +0100)]
s3-waf: remove RPCCLI_SPOOLSS subsystem.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jan 21 16:06:40 CET 2011 on sn-devel-104

8 years agos3-build: remove RPCCLI_SPOOLSS subsystem.
Günther Deschner [Tue, 18 Jan 2011 22:16:24 +0000 (23:16 +0100)]
s3-build: remove RPCCLI_SPOOLSS subsystem.

Guenther

8 years agos3-rpcclient: prefer dcerpc_spoolss_X functions.
Günther Deschner [Tue, 18 Jan 2011 21:10:30 +0000 (22:10 +0100)]
s3-rpcclient: prefer dcerpc_spoolss_X functions.

Guenther

8 years agos3-rpc_client: prefer dcerpc_spoolss_X functions.
Günther Deschner [Tue, 18 Jan 2011 17:37:52 +0000 (18:37 +0100)]
s3-rpc_client: prefer dcerpc_spoolss_X functions.

Guenther

8 years agos3-lanman: remove trailing whitespace.
Günther Deschner [Tue, 18 Jan 2011 23:43:33 +0000 (00:43 +0100)]
s3-lanman: remove trailing whitespace.

Guenther

8 years agos3-rpc_client: Added dcerpc_try_samr_connects.
Andreas Schneider [Wed, 12 Jan 2011 14:51:49 +0000 (15:51 +0100)]
s3-rpc_client: Added dcerpc_try_samr_connects.

Autobuild-User: Andreas Schneider <asn@samba.org>
Autobuild-Date: Fri Jan 21 15:19:01 CET 2011 on sn-devel-104

8 years agos3-rpc_client: Rename get_query_dispinfo_params.
Andreas Schneider [Wed, 12 Jan 2011 14:36:19 +0000 (15:36 +0100)]
s3-rpc_client: Rename get_query_dispinfo_params.

8 years agos3-rpc_client: Added dcerpc_samr_chgpasswd_user3.
Andreas Schneider [Wed, 12 Jan 2011 14:14:35 +0000 (15:14 +0100)]
s3-rpc_client: Added dcerpc_samr_chgpasswd_user3.

8 years agos3-rpc_client: Added dcerpc_samr_chng_pswd_auth_crap.
Andreas Schneider [Wed, 12 Jan 2011 08:04:19 +0000 (09:04 +0100)]
s3-rpc_client: Added dcerpc_samr_chng_pswd_auth_crap.

8 years agos3-rpc_client: Added dcerpc_samr_chgpasswd_user2.
Andreas Schneider [Wed, 12 Jan 2011 07:46:28 +0000 (08:46 +0100)]
s3-rpc_client: Added dcerpc_samr_chgpasswd_user2.

8 years agos3-rpc_client: Added dcerpc_samr_chgpasswd_user.
Andreas Schneider [Tue, 11 Jan 2011 12:07:02 +0000 (13:07 +0100)]
s3-rpc_client: Added dcerpc_samr_chgpasswd_user.

8 years agos3-rpc_client: Added header information to cli_samr.h.
Andreas Schneider [Tue, 11 Jan 2011 11:56:44 +0000 (12:56 +0100)]
s3-rpc_client: Added header information to cli_samr.h.

8 years agos3-rpc_client: Added header information to cli_lsarpc.h.
Andreas Schneider [Tue, 11 Jan 2011 11:56:08 +0000 (12:56 +0100)]
s3-rpc_client: Added header information to cli_lsarpc.h.

8 years agos3:docs: document "winbind max domain connections"
Michael Adam [Fri, 21 Jan 2011 12:49:06 +0000 (13:49 +0100)]
s3:docs: document "winbind max domain connections"

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Fri Jan 21 14:33:57 CET 2011 on sn-devel-104

8 years agos3:winbind: Fork multiple children per domain
Volker Lendecke [Wed, 7 Apr 2010 15:45:12 +0000 (17:45 +0200)]
s3:winbind: Fork multiple children per domain

This makes us scale better with many simultaneous winbind requests,
some of which might be slow.

This implementation breaks offline logons, as the cached credentials are
maintained in a child (this needs fixing). So, if the offline logons are
active, only allow one DC connection.

Probably the offline logon and the scalable file server cases are
separate enough so that this patch is useful even with the restriction.

8 years agos3:printing: use dcerpc_spoolss_X() functions
Stefan Metzmacher [Sat, 15 Jan 2011 11:06:09 +0000 (12:06 +0100)]
s3:printing: use dcerpc_spoolss_X() functions

metze

Signed-off-by: Andreas Schneider <asn@samba.org>
Autobuild-User: Andreas Schneider <asn@samba.org>
Autobuild-Date: Fri Jan 21 13:14:49 CET 2011 on sn-devel-104

8 years agos3:srv_spoolss: use dcerpc_spoolss_X() functions
Stefan Metzmacher [Sat, 15 Jan 2011 10:55:39 +0000 (11:55 +0100)]
s3:srv_spoolss: use dcerpc_spoolss_X() functions

metze

Signed-off-by: Andreas Schneider <asn@samba.org>
8 years agos3:smbd: use dcerpc_spoolss_X() functions
Stefan Metzmacher [Sat, 15 Jan 2011 10:53:11 +0000 (11:53 +0100)]
s3:smbd: use dcerpc_spoolss_X() functions

metze

Signed-off-by: Andreas Schneider <asn@samba.org>
8 years agos3:net: use dcerpc_spoolss_X() functions
Stefan Metzmacher [Sat, 15 Jan 2011 10:50:59 +0000 (11:50 +0100)]
s3:net: use dcerpc_spoolss_X() functions

metze

Signed-off-by: Andreas Schneider <asn@samba.org>
8 years agos3:libads: use dcerpc_spoolss_X() functions
Stefan Metzmacher [Sat, 15 Jan 2011 10:44:23 +0000 (11:44 +0100)]
s3:libads: use dcerpc_spoolss_X() functions

metze

Signed-off-by: Andreas Schneider <asn@samba.org>
8 years agos3: Fix a deadlock between smbd and ctdbd
Volker Lendecke [Fri, 21 Jan 2011 09:30:13 +0000 (10:30 +0100)]
s3: Fix a deadlock between smbd and ctdbd

Do the notification after we released the share mode lock. Inside notify_fname
we take out another tdb lock. With ctdb also accessing our databases, this can
lead to deadlocks. Putting this notify after the TALLOC_FREE(lck) above we
avoid locking two records simultaneously. Notifies are async and informational
only, so calling the notify_fname without holding the share mode lock should
not do any harm.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Jan 21 12:29:21 CET 2011 on sn-devel-104

8 years agos3-spoolss: make it more obvious what winreg_create_printer() does.
Günther Deschner [Fri, 21 Jan 2011 09:38:23 +0000 (10:38 +0100)]
s3-spoolss: make it more obvious what winreg_create_printer() does.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Jan 21 11:43:29 CET 2011 on sn-devel-104

8 years agos3-rpcclient: rename duplicate enumkey command to winreg_enumkey.
Günther Deschner [Fri, 21 Jan 2011 09:34:38 +0000 (10:34 +0100)]
s3-rpcclient: rename duplicate enumkey command to winreg_enumkey.

Guenther

8 years agos3-spoolss: as smbtorture testing proves: devmode size is the size of the devicemode...
Günther Deschner [Wed, 19 Jan 2011 13:39:50 +0000 (14:39 +0100)]
s3-spoolss: as smbtorture testing proves: devmode size is the size of the devicemode minus the driverdata extra size.

Jeremy, please check.

Guenther

8 years agos4-smbtorture: make sure there is always driverextra data in spoolss devmode size...
Günther Deschner [Wed, 19 Jan 2011 13:39:36 +0000 (14:39 +0100)]
s4-smbtorture: make sure there is always driverextra data in spoolss devmode size tests.

Guenther

8 years agos3-spoolss: disallow storing an invalid devmode size.
Günther Deschner [Wed, 19 Jan 2011 12:49:51 +0000 (13:49 +0100)]
s3-spoolss: disallow storing an invalid devmode size.

Guenther

8 years agos4-smbtorture: add tests for the size member of spoolss devicemodes.
Günther Deschner [Wed, 19 Jan 2011 12:48:17 +0000 (13:48 +0100)]
s4-smbtorture: add tests for the size member of spoolss devicemodes.

Guenther

8 years agos4-smbtorture: prepare devicemode test for expected result tests.
Günther Deschner [Wed, 19 Jan 2011 12:44:46 +0000 (13:44 +0100)]
s4-smbtorture: prepare devicemode test for expected result tests.

Guenther

8 years agos4-smbtorture: add some paranoia checks for 0 sized devmodes.
Günther Deschner [Tue, 18 Jan 2011 23:15:09 +0000 (00:15 +0100)]
s4-smbtorture: add some paranoia checks for 0 sized devmodes.

Guenther

8 years agos3:vfs:shadow_copy2: fix indentation in _SHADOW2_NEXT_SMB_FNAME
Michael Adam [Fri, 21 Jan 2011 08:46:42 +0000 (09:46 +0100)]
s3:vfs:shadow_copy2: fix indentation in _SHADOW2_NEXT_SMB_FNAME

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Fri Jan 21 10:57:45 CET 2011 on sn-devel-104

8 years agos3:vfs:shadow_copy2: Fix shadow-copy module for drag&drop from a snapshot
Volker Lendecke [Thu, 16 Dec 2010 11:26:02 +0000 (04:26 -0700)]
s3:vfs:shadow_copy2: Fix shadow-copy module for drag&drop from a snapshot

We have to return NT_STATUS_NOT_SAME_DEVICE to trigger the Windows client to
start a copy itself. Unbeknownst to us via the ACLs snapshots are read-only, so
a rename would trigger a EACCES. Unfortunately the MacOS/X finder does not do
the smart NOT_SAME_DEVICE fallback that Windows does.

8 years agos3:registry correct a debug level
Christian Ambach [Thu, 9 Dec 2010 10:25:17 +0000 (11:25 +0100)]
s3:registry correct a debug level

this is not a level 0 message, move it to 10

8 years agos3:winbind: Protect against invalid winbindd_cache entries in lookuprids
Volker Lendecke [Tue, 23 Nov 2010 13:49:12 +0000 (14:49 +0100)]
s3:winbind: Protect against invalid winbindd_cache entries in lookuprids

8 years agos3-net: add roundtrip tests for registry import/export
Gregor Beck [Wed, 29 Sep 2010 13:13:55 +0000 (15:13 +0200)]
s3-net: add roundtrip tests for registry import/export

8 years agopackaging(RHEL-CTDB): explicitly build the tsm vfs module.
Volker Lendecke [Mon, 8 Mar 2010 16:59:35 +0000 (17:59 +0100)]
packaging(RHEL-CTDB): explicitly build the tsm vfs module.

8 years agos3: Fix the code to immediately disconnect from a non-working ctdbd
Volker Lendecke [Thu, 3 Dec 2009 00:55:52 +0000 (01:55 +0100)]
s3: Fix the code to immediately disconnect from a non-working ctdbd

8 years agos3:vfs:gpfs: fix logic when gpfs:winattr is false (the default!)
Rusty Russell [Fri, 20 Nov 2009 09:39:57 +0000 (10:39 +0100)]
s3:vfs:gpfs: fix logic when gpfs:winattr is false (the default!)

On my autocluster setup, it's not set.  Maybe it should be?  Otherwise
smbclient and some Windows client programs will get errors like:

        # smbclient //localhost/data -Uadministrator%XXX
        Domain=[VSOFS1] OS=[Unix] Server=[Samba 3.4.2-ctdb-10]
        smb: \> put /etc/resolv.conf resolv.conf
        NT_STATUS_ACCESS_DENIED closing remote file \resolv.conf
        smb: \>

Caused by attempting to update the time on close.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Michael Adam <obnox@samba.org>
8 years agopidl:Samba4/NDR/Client: remove compat mode for dcerpc_pipe based bindings
Stefan Metzmacher [Sat, 15 Jan 2011 07:59:16 +0000 (08:59 +0100)]
pidl:Samba4/NDR/Client: remove compat mode for dcerpc_pipe based bindings

The only consumer "openchange" uses the dcerpc_binding_handle based
functions now.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Jan 21 08:16:25 CET 2011 on sn-devel-104

8 years agos3:librpc: remove prototype of dcerpc_binding_handle_set_ref_alloc()
Stefan Metzmacher [Sat, 15 Jan 2011 07:55:28 +0000 (08:55 +0100)]
s3:librpc: remove prototype of dcerpc_binding_handle_set_ref_alloc()

This function doesn't exist anymore.

metze

8 years agoRemove all uses of "./" in pathnames - make canonical. This will become important...
Jeremy Allison [Fri, 21 Jan 2011 00:32:57 +0000 (16:32 -0800)]
Remove all uses of "./" in pathnames - make canonical. This will become important when we need to guarantee canonical names for hashing.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Jan 21 02:59:56 CET 2011 on sn-devel-104

8 years agoEnsure we don't use "./" in findfirst pathnames. Use a directory open of "." instead.
Jeremy Allison [Fri, 21 Jan 2011 00:30:28 +0000 (16:30 -0800)]
Ensure we don't use "./" in findfirst pathnames. Use a directory open of "." instead.

8 years agoMake processing of incoming stream rename paths common between reply_mv and ntrename...
Jeremy Allison [Fri, 21 Jan 2011 00:27:56 +0000 (16:27 -0800)]
Make processing of incoming stream rename paths common between reply_mv and ntrename. Ensure we don't depend on "./" in the streams module.

8 years agos4/wintest New ESXi configuration file
Zahari Zahariev [Thu, 20 Jan 2011 13:26:18 +0000 (15:26 +0200)]
s4/wintest New ESXi configuration file

This is a way to use wintest as it is unchanged and work with
ESXi virtualization solution instead of VirtualBox or KVM. As the
virtualization server is a remote Linux like machine I use 'sshpass'
wrapper SSH to execute stop/reset/revert commands.

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Jan 21 00:29:15 CET 2011 on sn-devel-104

8 years agos4-auth Remove special case for account_sid from auth_serversupplied_info
Andrew Bartlett [Thu, 20 Jan 2011 12:39:37 +0000 (23:39 +1100)]
s4-auth Remove special case for account_sid from auth_serversupplied_info

This makes everything reference a server_info->sids list, which is now
a struct dom_sid *, not a struct dom_sid **.  This is in keeping with
the other sid lists in the security_token etc.

In the process, I also tidy up the talloc tree (move more structures
under their logical parents) and check for some possible overflows in
situations with a pathological number of sids.

Andrew Bartlett

8 years agos4-gensec Add prototype for gensec_ntlmssp_init()
Andrew Bartlett [Thu, 20 Jan 2011 05:38:08 +0000 (16:38 +1100)]
s4-gensec Add prototype for gensec_ntlmssp_init()

Andrew Bartlett

8 years agolibcli/auth move ntlmssp_wrap() and ntlmssp_unwrap() into common code.
Andrew Bartlett [Thu, 20 Jan 2011 05:37:04 +0000 (16:37 +1100)]
libcli/auth move ntlmssp_wrap() and ntlmssp_unwrap() into common code.

The idea here is to allow the source3/libads/sasl.c code to call this
instead of the lower level ntlmssp_* functions.

Andrew Bartlett

8 years agos4:selftest: mark samba4.nbt.winsreplication.owned as knownfail
Stefan Metzmacher [Thu, 20 Jan 2011 07:43:27 +0000 (08:43 +0100)]
s4:selftest: mark samba4.nbt.winsreplication.owned as knownfail

This sometimes fails on a busy server.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Jan 20 09:29:12 CET 2011 on sn-devel-104

8 years agos4:selftest/skip: remove samba4.tokengroups.python
Stefan Metzmacher [Thu, 20 Jan 2011 07:34:28 +0000 (08:34 +0100)]
s4:selftest/skip: remove samba4.tokengroups.python

metze

8 years agos3:smbd: use anonymous_shared_free() for shared memory signing state
Stefan Metzmacher [Tue, 26 Oct 2010 20:49:46 +0000 (22:49 +0200)]
s3:smbd: use anonymous_shared_free() for shared memory signing state

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Jan 20 07:48:29 CET 2011 on sn-devel-104

8 years agolib/util: add tests for anonymous_shared_allocate/free()
Stefan Metzmacher [Tue, 18 Jan 2011 16:00:26 +0000 (17:00 +0100)]
lib/util: add tests for anonymous_shared_allocate/free()

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Jan 20 06:25:03 CET 2011 on sn-devel-104

8 years agolib/util: add anonymous_shared_free()
Stefan Metzmacher [Tue, 26 Oct 2010 20:45:19 +0000 (22:45 +0200)]
lib/util: add anonymous_shared_free()

metze

8 years agolib/util: s/allocate_anonymous_shared/anonymous_shared_allocate/
Stefan Metzmacher [Tue, 26 Oct 2010 20:41:46 +0000 (22:41 +0200)]
lib/util: s/allocate_anonymous_shared/anonymous_shared_allocate/

metze

8 years agolib/util: fix rounding to page size in allocate_anonymous_shared()
Stefan Metzmacher [Wed, 19 Jan 2011 16:55:13 +0000 (17:55 +0100)]
lib/util: fix rounding to page size in allocate_anonymous_shared()

metze

8 years agos4-selftest Remove knownfail for tokengroups test
Andrew Bartlett [Wed, 19 Jan 2011 21:28:04 +0000 (08:28 +1100)]
s4-selftest Remove knownfail for tokengroups test

The problem with this test (use of None rather than "" has been fixed)

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Jan 19 23:56:31 CET 2011 on sn-devel-104

8 years agos4-dsdb Don't use None as the input to the GENSEC loop in tokengroups test
Andrew Bartlett [Wed, 19 Jan 2011 20:20:06 +0000 (07:20 +1100)]
s4-dsdb Don't use None as the input to the GENSEC loop in tokengroups test

The input to gensec.update() should always be a string.

Andrew Bartlett

8 years agos3-param: Fixed code block in max_open_files().
Andreas Schneider [Wed, 19 Jan 2011 15:13:42 +0000 (16:13 +0100)]
s3-param: Fixed code block in max_open_files().

When the HAVE_GETRLIMIT and RLIMIT_NOFILE macros are defined the block
isn't closed.

Autobuild-User: Andreas Schneider <asn@samba.org>
Autobuild-Date: Wed Jan 19 23:10:50 CET 2011 on sn-devel-104

8 years agos3-smbd: Fixed a possible null pointer dereference.
Andreas Schneider [Wed, 19 Jan 2011 15:22:28 +0000 (16:22 +0100)]
s3-smbd: Fixed a possible null pointer dereference.

8 years agowafsamba: quote CPP and CC values when calling pidl
Stefan Metzmacher [Wed, 19 Jan 2011 15:53:39 +0000 (16:53 +0100)]
wafsamba: quote CPP and CC values when calling pidl

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Jan 19 20:23:50 CET 2011 on sn-devel-104

8 years agos4:selftest/skip: add samba4.tokengroups.python
Stefan Metzmacher [Wed, 19 Jan 2011 16:33:59 +0000 (17:33 +0100)]
s4:selftest/skip: add samba4.tokengroups.python

This fails randomly like this with an error (not a failure):

[651/695 in 27m37s] samba4.tokengroups.python(dc)
running client gensec_update
UNEXPECTED(error): samba4.tokengroups.python(dc).__main__.TokenTest.test_pac_groups
REASON: _StringException: _StringException: Content-Type: text/x-traceback;charset=utf8,language=python
traceback
1E2
Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/testtools/runtest.py", line 128, in _run_user
    return fn(*args)
  File "/usr/lib/python2.6/dist-packages/testtools/testcase.py", line 368, in _run_test_method
    testMethod()
  File "/memdisk/tridge/flakey/b2413/source4/source4/dsdb/tests/python/token_group.py", line 142, in test_pac_groups
    (client_finished, client_to_server) = gensec_client.update(server_to_client)
TypeError: expected a string
0

FAILED (0 failures and 1 errors in 0 testsuites)

A summary with detailed information can be found in:
  ./st/summary
test: running (/usr/bin/perl /memdisk/tridge/flakey/b2413/source4/source4/../selftest/selftest.pl --prefix=./st --builddir=. --srcdir=. --exclude=./selftest/skip --testlist="/usr/bin/python ./selftest/tests.py|"  --exclude=./selftest/slow --socket-wrapper  && touch ./st/st_done) | /usr/bin/python -u ../selftest/filter-subunit --expected-failures=./selftest/knownfail --fail-immediately | tee ./st/subunit | /usr/bin/python -u ../selftest/format-subunit --prefix=./st --immediate
ERROR: test failed with exit code 1

metze

8 years agos4-dsdb Add PAC validation test to tokengroups test.
Andrew Bartlett [Wed, 19 Jan 2011 11:29:49 +0000 (22:29 +1100)]
s4-dsdb Add PAC validation test to tokengroups test.

This confirms that the groups obtained from a Kerberos PAC match those
that a manual search of a target LDAP server would reveal.

This should allow mixing of a KDC specified by krb5.conf to test Samba
or Windows alternatly.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Jan 19 13:13:48 CET 2011 on sn-devel-104

8 years agos4-pyauth Fix AuthContext wrapper
Andrew Bartlett [Wed, 19 Jan 2011 11:29:08 +0000 (22:29 +1100)]
s4-pyauth Fix AuthContext wrapper

8 years agos4-auth Allow NULL methods to be specified to auth_context_create_methods()
Andrew Bartlett [Wed, 19 Jan 2011 11:27:51 +0000 (22:27 +1100)]
s4-auth Allow NULL methods to be specified to auth_context_create_methods()

This allows us to init an auth context that isn't going to do any NTLM
authentication, but is used by other subsystems.

Andrew Bartlett

8 years agos4-dsdb Add a test of the tokenGroups behaviour on the user's DN.
Andrew Bartlett [Wed, 19 Jan 2011 03:55:36 +0000 (14:55 +1100)]
s4-dsdb Add a test of the tokenGroups behaviour on the user's DN.

Andrew Bartlett

8 years agos4-gensec Remove special case 'for SASL' that is not required any more.
Andrew Bartlett [Wed, 19 Jan 2011 03:54:36 +0000 (14:54 +1100)]
s4-gensec Remove special case 'for SASL' that is not required any more.

I've examined the code paths involved, and it appears an alternative
fix has been made in the ldap_server/ldap_bind.c code, and there is no
code path that uses this behaviour.

Andrew Bartlett

8 years agotdb: Added doxygen documentation.
Andreas Schneider [Thu, 13 Jan 2011 16:30:52 +0000 (17:30 +0100)]
tdb: Added doxygen documentation.

Autobuild-User: Andreas Schneider <asn@samba.org>
Autobuild-Date: Wed Jan 19 11:26:34 CET 2011 on sn-devel-104

8 years agos3: Add wbinfo --dc-info
Volker Lendecke [Mon, 10 Jan 2011 16:25:00 +0000 (17:25 +0100)]
s3: Add wbinfo --dc-info

wbinfo --dc-info prints the current DC name and IP address. This helps
diagnosing problems that might happen when a later wbinfo --ping-dc fails.

This patch started out by using the SAF and NBT cache entires, but those are
relatively short-lived. So I decided to invent a new gencache entry with a very
long timeout. We need to go via the gencache because when for some reason a
winbind child process is stuck, we can't query it for the current DC it's
connected to. This must eventually go away again when we have a fully async
winbind.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Jan 19 08:40:28 CET 2011 on sn-devel-104

8 years agoAdd DELETE-LN test to show bug #7863 - Unlink may unlink wrong file when hardlinks...
Jeremy Allison [Wed, 19 Jan 2011 00:57:25 +0000 (16:57 -0800)]
Add DELETE-LN test to show bug #7863 - Unlink may unlink wrong file when hardlinks are involved

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Jan 19 03:06:32 CET 2011 on sn-devel-104

8 years agowaf: change private libraries to use the same soname as public libraries
Andrew Tridgell [Wed, 19 Jan 2011 00:04:05 +0000 (11:04 +1100)]
waf: change private libraries to use the same soname as public libraries

See
http://lists.samba.org/archive/samba-technical/2011-January/075816.html
for a description of the reason behind this change

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Wed Jan 19 02:21:06 CET 2011 on sn-devel-104

8 years agopygensec: remove special case handling for None for buffers
Andrew Tridgell [Tue, 18 Jan 2011 23:31:28 +0000 (10:31 +1100)]
pygensec: remove special case handling for None for buffers

always returning a buffer makes life easier for callers

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agoFix "net usersidlist" not to skip every other user
Olly Betts [Tue, 18 Jan 2011 10:07:13 +0000 (10:07 +0000)]
Fix "net usersidlist" not to skip every other user

Remove double increment from for loop over users in get_user_tokens(),
left over from when this used to be a while loop.  Bug was introduced
in 1e39a619.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Jan 19 01:34:29 CET 2011 on sn-devel-104

8 years agos3-winbind: no need to include ../librpc/gen_ndr/cli_lsa.h in
Günther Deschner [Tue, 18 Jan 2011 17:05:29 +0000 (18:05 +0100)]
s3-winbind: no need to include ../librpc/gen_ndr/cli_lsa.h in
winbindd/winbindd_msrpc.c.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Jan 19 00:37:46 CET 2011 on sn-devel-104

8 years agos3-rpc_client: no need to include ../librpc/gen_ndr/ndr_lsa_c.h anymore.
Günther Deschner [Tue, 18 Jan 2011 15:32:20 +0000 (16:32 +0100)]
s3-rpc_client: no need to include ../librpc/gen_ndr/ndr_lsa_c.h anymore.

Guenther

8 years agos3-netlogon: no need to include ../librpc/gen_ndr/ndr_lsa_c.h anymore.
Günther Deschner [Tue, 18 Jan 2011 15:32:05 +0000 (16:32 +0100)]
s3-netlogon: no need to include ../librpc/gen_ndr/ndr_lsa_c.h anymore.

Guenther

8 years agos3-netlogon: no need to include ../librpc/gen_ndr/cli_samr.h anymore.
Günther Deschner [Tue, 18 Jan 2011 13:27:17 +0000 (14:27 +0100)]
s3-netlogon: no need to include ../librpc/gen_ndr/cli_samr.h anymore.

Guenther

8 years agos3-net: use correct spoolss header in net rpc.
Günther Deschner [Tue, 18 Jan 2011 21:53:59 +0000 (22:53 +0100)]
s3-net: use correct spoolss header in net rpc.

Guenther