ira/wip.git
13 years agos3: OneFS implementation of change notify
Steven Danneman [Fri, 20 Feb 2009 21:25:17 +0000 (13:25 -0800)]
s3: OneFS implementation of change notify

The OneFS Samba implementation of change notify is modeled after the
usage of Linux's inotify kernel subsystem.  A single call is made
into the onefs.so VFS module to initialize kernel tracking of certain
file change events.  When these events occur a kernel notification is
sent to smbd and the notification event is translated and given to the
general Samba Change Notify layer through a callback function.

The most difficult aspect is converting an SMB CompletionFilter to
a matching ifs_event mask, and then back to an appropriate change
notify action.  Currently, not all possible cases are handled by the
this module, but the most prevalent ones, which are tested by
smbtorture, are implemented.

13 years agos3: Make change notify immediately return a catch-all packet on underlying error
Steven Danneman [Wed, 18 Feb 2009 00:20:18 +0000 (16:20 -0800)]
s3: Make change notify immediately return a catch-all packet on underlying error

* This allows a problem in the underlying CN backend to be bubbled up
  to the general CN layer so a catch-all reply can be returned
* We now also return a catch-all response immediately if the server-side
  event queue becomes too big

13 years agos3: Modifications to generic notify structures to allow implementation of OneFS notify.
Steven Danneman [Fri, 20 Feb 2009 21:23:53 +0000 (13:23 -0800)]
s3: Modifications to generic notify structures to allow implementation of OneFS notify.

The OneFS kernel based change notify system takes an fd of the directory
to watch in it's initialization syscall.  Since we already have this
directory open, this commit plumbs that fd down to the VFS layer via the
notify_entry struct.

We also need to know if the watch is taken out on a snapshot directory.
The full file_id struct is also passed down to make this determination.
The file_id marshalling wrappers are hand written here, but should
eventually be auto-generated by moving the struct file_id into the idl.

13 years agoAdded torture tests to RAW-NOTIFY
Steven Danneman [Fri, 20 Feb 2009 01:06:27 +0000 (17:06 -0800)]
Added torture tests to RAW-NOTIFY

* This adds a test to check the change notify behavior of the SMB server
  when more events have been generated than can be returned in a single
  change notify response.

* Second test makes sure the server doesn't return notification events
  for changes to the watched directory itself

13 years agoFix bug #6133 - Cannot delete non-ACL files on Solaris/ZFS/NFSv4 ACL filesystem.
Jeremy Allison [Fri, 20 Feb 2009 16:23:52 +0000 (08:23 -0800)]
Fix bug #6133 - Cannot delete non-ACL files on Solaris/ZFS/NFSv4 ACL filesystem.
As the NFSv4 ACL mapping code doesn't map write directory into the DELETE_CHILD
permission bit (which we require before allowing a delete) no one can delete
files without an explicit DELETE_CHILD bit set on the directory. Add this mapping.
Jeremy.

13 years agovariable grouping: just my OCD desire to keep similar things together
Derrell Lipman [Fri, 20 Feb 2009 14:51:36 +0000 (09:51 -0500)]
variable grouping: just my OCD desire to keep similar things together

13 years agoMake libsmbclient work with DFS
Bo Yang [Fri, 20 Feb 2009 04:00:46 +0000 (12:00 +0800)]
Make libsmbclient work with DFS

Signed-off-by: Derrell Lipman <derrell.lipman@unwireduniverse.com>
13 years agos3/docs: Add hint about getfattr in man vfs_acl_xattr.
Karolin Seeger [Fri, 20 Feb 2009 13:14:54 +0000 (14:14 +0100)]
s3/docs: Add hint about getfattr in man vfs_acl_xattr.

Karolin

13 years agos3/docs: Add man vfs_acl_tdb.
Karolin Seeger [Fri, 20 Feb 2009 12:32:44 +0000 (13:32 +0100)]
s3/docs: Add man vfs_acl_tdb.

Karolin

13 years agos3/docs: Add man vfs_acl_xattr.
Karolin Seeger [Fri, 20 Feb 2009 12:32:22 +0000 (13:32 +0100)]
s3/docs: Add man vfs_acl_xattr.

Karolin

13 years agos3/docs: Fix several typos.
Karolin Seeger [Fri, 20 Feb 2009 08:20:16 +0000 (09:20 +0100)]
s3/docs: Fix several typos.

This fixes bug #6127.
Thanks to Justin T Pryzby <justinpryzby [at] users.sourceforge.net>
for the review!

Karolin

13 years agos3 OneFS: Add shadow copy module
Tim Prouty [Wed, 18 Feb 2009 04:39:03 +0000 (20:39 -0800)]
s3 OneFS: Add shadow copy module

13 years agos3 OneFS: Add file_id_create implementation to take advantage of snapshots
Tim Prouty [Wed, 18 Feb 2009 02:38:58 +0000 (18:38 -0800)]
s3 OneFS: Add file_id_create implementation to take advantage of snapshots

13 years agos3: Change the vfs_GetWd cache to use the file_id struct
Tim Prouty [Tue, 17 Feb 2009 00:06:45 +0000 (16:06 -0800)]
s3: Change the vfs_GetWd cache to use the file_id struct

13 years agos3: Remove unused inform_level2_message struct
Tim Prouty [Mon, 16 Feb 2009 22:55:52 +0000 (14:55 -0800)]
s3: Remove unused inform_level2_message struct

13 years agos3: Add extid to the dev/inode pair
Tim Prouty [Mon, 16 Feb 2009 07:45:28 +0000 (23:45 -0800)]
s3: Add extid to the dev/inode pair

This extends the file_id struct to add an additional generic uint64_t
field: extid.  For backwards compatibility with dev/inodes stored in
xattr_tdbs and acl_tdbs, the ext id is ignored for these databases.
This patch should cause no functional change on systems that don't use
SMB_VFS_FILE_ID_CREATE to set the extid.

Existing code that uses the smb_share_mode library will need to be
updated to be compatibile with the new extid.

13 years agos3: Modify SMB_VFS_FILE_ID_CREATE to take a stat struct
Tim Prouty [Mon, 16 Feb 2009 07:38:53 +0000 (23:38 -0800)]
s3: Modify SMB_VFS_FILE_ID_CREATE to take a stat struct

Since file_id_create_dev is incompatible with the concept of file_ids,
it is now static and in the one file that needs it.

13 years agoFix printf warnings found on systems where time_t <> long int.
Jeremy Allison [Thu, 19 Feb 2009 21:36:20 +0000 (13:36 -0800)]
Fix printf warnings found on systems where time_t <> long int.
Jeremy.

13 years agoFix printf type warning.
Jeremy Allison [Thu, 19 Feb 2009 21:11:36 +0000 (13:11 -0800)]
Fix printf type warning.
Jeremy.

13 years agoFix an uninitialized variable
Volker Lendecke [Thu, 19 Feb 2009 19:59:31 +0000 (20:59 +0100)]
Fix an uninitialized variable

13 years agoFix a O(n^2) algorithm in regdb_fetch_keys()
Volker Lendecke [Thu, 19 Feb 2009 19:03:06 +0000 (20:03 +0100)]
Fix a O(n^2) algorithm in regdb_fetch_keys()

13 years agos3-spoolss: fix vista fallback in _spoolss_AddPrinterDriverEx.
Günther Deschner [Thu, 19 Feb 2009 18:02:48 +0000 (19:02 +0100)]
s3-spoolss: fix vista fallback in _spoolss_AddPrinterDriverEx.

Martin Zielinski, if you're reading this, please have a look. Vista nicely takes
just a WERR_UNKNOWN_LEVEL here and retries with a level 6 add.

Guenther

13 years agos3-spoolss: remove old spoolss_AddPrinterDriver{Ex}.
Günther Deschner [Wed, 18 Feb 2009 18:00:29 +0000 (19:00 +0100)]
s3-spoolss: remove old spoolss_AddPrinterDriver{Ex}.

Guenther

13 years agos3-spoolss: use pidl for _spoolss_AddPrinterDriver{Ex}.
Günther Deschner [Wed, 18 Feb 2009 17:59:43 +0000 (18:59 +0100)]
s3-spoolss: use pidl for _spoolss_AddPrinterDriver{Ex}.

Guenther

13 years agos3-spoolss: remove old spoolss_GetPrintProcessorDirectory.
Günther Deschner [Thu, 19 Feb 2009 09:44:42 +0000 (10:44 +0100)]
s3-spoolss: remove old spoolss_GetPrintProcessorDirectory.

Guenther

13 years agos3-spoolss: use pidl for _spoolss_GetPrintProcessorDirectory.
Günther Deschner [Thu, 19 Feb 2009 09:42:49 +0000 (10:42 +0100)]
s3-spoolss: use pidl for _spoolss_GetPrintProcessorDirectory.

Guenther.

13 years agos3-rpcclient: use rpccli_spoolss_GetPrintProcessorDirectory in rpcclient.
Günther Deschner [Thu, 19 Feb 2009 09:26:00 +0000 (10:26 +0100)]
s3-rpcclient: use rpccli_spoolss_GetPrintProcessorDirectory in rpcclient.

Guenther

13 years agos3-spoolss: fix _spoolss_GetPrinterDriverDirectory.
Günther Deschner [Thu, 19 Feb 2009 18:17:19 +0000 (19:17 +0100)]
s3-spoolss: fix _spoolss_GetPrinterDriverDirectory.

treat architecture correctly as it is a [unique] pointer, and newer
Windows versions sometimes send in an empty string.

Guenther

13 years agos3-rpcclient: use SPOOLSS_ARCHITECTURE_NT_X86 define in spoolss getdriverdir cmd.
Günther Deschner [Thu, 19 Feb 2009 16:41:10 +0000 (17:41 +0100)]
s3-rpcclient: use SPOOLSS_ARCHITECTURE_NT_X86 define in spoolss getdriverdir cmd.

Guenther

13 years agos3-spoolss: _spoolss_OpenPrinterEx needs to wipe out policy handle upon failure.
Günther Deschner [Thu, 19 Feb 2009 14:56:05 +0000 (15:56 +0100)]
s3-spoolss: _spoolss_OpenPrinterEx needs to wipe out policy handle upon failure.

Guenther

13 years agos3-spoolss: _spoolss_AddPrinterEx needs to wipe out policy handle upon failure.
Günther Deschner [Thu, 19 Feb 2009 16:40:21 +0000 (17:40 +0100)]
s3-spoolss: _spoolss_AddPrinterEx needs to wipe out policy handle upon failure.

Guenther

13 years agospoolss: add ndr_size_spoolss_StringArray to spoolss helper.
Günther Deschner [Thu, 19 Feb 2009 16:39:36 +0000 (17:39 +0100)]
spoolss: add ndr_size_spoolss_StringArray to spoolss helper.

Guenther

13 years agos3: re-run make samba3-idl.
Günther Deschner [Thu, 19 Feb 2009 16:59:51 +0000 (17:59 +0100)]
s3: re-run make samba3-idl.

Guenther

13 years agospoolss: remove gensize calculation from spoolss_StringArray. Thanks metze!
Günther Deschner [Thu, 19 Feb 2009 16:38:47 +0000 (17:38 +0100)]
spoolss: remove gensize calculation from spoolss_StringArray. Thanks metze!

Guenther

13 years agoFix a buffer handling bug when adding lots of registry keys
Volker Lendecke [Thu, 19 Feb 2009 13:16:44 +0000 (14:16 +0100)]
Fix a buffer handling bug when adding lots of registry keys

This is *ancient*... From 2002, and nobody noticed until someone added lots of
shares using net conf... :-)

13 years agos3: re-run make samba3-idl.
Günther Deschner [Thu, 19 Feb 2009 12:06:11 +0000 (13:06 +0100)]
s3: re-run make samba3-idl.

Guenther

13 years agospoolss: fill in spoolss_GetPrintProcessorDirectory.
Günther Deschner [Thu, 19 Feb 2009 09:45:12 +0000 (10:45 +0100)]
spoolss: fill in spoolss_GetPrintProcessorDirectory.

Guenther

13 years agos3-libnet: fix coverity #848 (UNINIT).
Günther Deschner [Thu, 19 Feb 2009 01:35:20 +0000 (02:35 +0100)]
s3-libnet: fix coverity #848 (UNINIT).

Guenther

13 years agos4:librpc/ndr: if uninitialized variable in string_array code
Stefan Metzmacher [Thu, 19 Feb 2009 10:12:33 +0000 (11:12 +0100)]
s4:librpc/ndr: if uninitialized variable in string_array code

metze

13 years agos3:librpc/ndr: if uninitialized variable in string_array code
Stefan Metzmacher [Thu, 19 Feb 2009 10:11:28 +0000 (11:11 +0100)]
s3:librpc/ndr: if uninitialized variable in string_array code

metze

13 years agolibrpc: rerun make idl
Stefan Metzmacher [Thu, 19 Feb 2009 10:11:04 +0000 (11:11 +0100)]
librpc: rerun make idl

13 years agopidl:NDR/Parser: don't call [noopnum] function when creating the ndr_interface_table
Stefan Metzmacher [Thu, 19 Feb 2009 09:32:48 +0000 (10:32 +0100)]
pidl:NDR/Parser: don't call [noopnum] function when creating the ndr_interface_table

metze

13 years agos3 OneFS: Fixes "inherit permissions" and "nt acl support" for Onefs.
Zack Kirsch [Wed, 18 Feb 2009 05:03:33 +0000 (21:03 -0800)]
s3 OneFS: Fixes "inherit permissions" and "nt acl support" for Onefs.

13 years agoS3: Dumb down debug spew in perfcount module code
todd stecher [Wed, 18 Feb 2009 08:02:51 +0000 (00:02 -0800)]
S3: Dumb down debug spew in perfcount module code

13 years agoS3: Make changes to perfcount API set for when a single request leads to multiple...
todd stecher [Tue, 17 Feb 2009 04:45:45 +0000 (20:45 -0800)]
S3: Make changes to perfcount API set for when a single request leads to multiple replies

(e.g. reply_echo). Change test and onefs modules to match new api set (thanks Volker!).

13 years agos4 torture: Add new test to create a file with a lot of streams
Tim Prouty [Tue, 23 Dec 2008 08:53:28 +0000 (00:53 -0800)]
s4 torture: Add new test to create a file with a lot of streams

This tests how streaminfo deals with large buffers

smbclient seems to have problems when the buffer size approaches the
max data size.  Also smbclient exposes no way to specify the max data
size that is sent in a trans2 request.  Instead it hardcodes in a much
larger max than windows uses.  For these reasons this test isn't
actually run, but is more of a reference for how windows handles
streaminfo buffers.

13 years agos3: Fix bug opening streams with truncating disposition
Tim Prouty [Thu, 19 Feb 2009 07:10:41 +0000 (23:10 -0800)]
s3: Fix bug opening streams with truncating disposition

Do not attempt to delete streams on a truncating open, if the name
we're opening is itself a stream.

Port 176e8857203944bc332844b700749120ce90c891 to standard open path

13 years agos4 torture: Add additional streams create disposition test
Tim Prouty [Thu, 19 Feb 2009 06:51:27 +0000 (22:51 -0800)]
s4 torture: Add additional streams create disposition test

13 years agos3: OneFS: Pass in the client's fnum to the ifs_cbrl syscall.
Zack Kirsch [Thu, 19 Feb 2009 04:39:20 +0000 (20:39 -0800)]
s3: OneFS: Pass in the client's fnum to the ifs_cbrl syscall.

13 years agos3: Fix OneFS bug opening streams with truncating disposition
Aravind Srinivasan [Thu, 19 Feb 2009 02:26:39 +0000 (18:26 -0800)]
s3: Fix OneFS bug opening streams with truncating disposition

Do not attempt to delete streams on a truncating open, if the name we're
opening is itself a stream

13 years agos3: Fix streams enumeration bug in OneFS implementation
Aravind Srinivasan [Thu, 19 Feb 2009 01:36:25 +0000 (17:36 -0800)]
s3: Fix streams enumeration bug in OneFS implementation

Previously, we didn’t call SMB_VFS_OPEN_DIR from the streams module,
instead we called fdopendir(). As a result we failed to populate the
dir_state list in the readdirplus module. So when we tried to view the
stream data, we will always returned NULL.

To solve this I separated onefs_opendir() and the initialization of
the dir_state list. This is done by introducing a new utility function
“onefs_rdp_add_dir_state()”, which initializes the dir_state structure
and adds it to the dir_state list.  This function is called from the
streams module before calling readdir().

13 years agoS3: Log warning in smbstatus about lack of pid in anonymous mode.
todd stecher [Thu, 12 Feb 2009 21:03:03 +0000 (13:03 -0800)]
S3: Log warning in smbstatus about lack of pid in anonymous mode.

13 years agoS3: Stop creating SMBD cores when failing to create a pipe.
todd stecher [Thu, 12 Feb 2009 08:11:38 +0000 (00:11 -0800)]
S3: Stop creating SMBD cores when failing to create a pipe.

This was uncovered when the MAX FD limit was hit, causing an instant core
and invoking error reporting. This fix causes SMBD to exit, but without
building a core.

13 years agoS3: Allow SMBD processes to survive in low memory condidtions
todd stecher [Wed, 18 Feb 2009 00:16:35 +0000 (16:16 -0800)]
S3: Allow SMBD processes to survive in low memory condidtions

This commit adds a configure argument which allows for setting MADV_PROTECT
in the madvise() API.  With this enabled the kernel won't kill SMBD when
it's running low on memory.

13 years agos3-spoolss: remove old spoolss_GetPrinterDriverDirectory.
Günther Deschner [Thu, 19 Feb 2009 00:59:57 +0000 (01:59 +0100)]
s3-spoolss: remove old spoolss_GetPrinterDriverDirectory.

Guenther

13 years agos3-spoolss: use pidl for _spoolss_GetPrinterDriverDirectory.
Günther Deschner [Thu, 19 Feb 2009 00:46:17 +0000 (01:46 +0100)]
s3-spoolss: use pidl for _spoolss_GetPrinterDriverDirectory.

Guenther

13 years agos3-rpcclient: use rpccli_spoolss_GetPrinterDriverDirectory in rpcclient.
Günther Deschner [Thu, 19 Feb 2009 00:55:39 +0000 (01:55 +0100)]
s3-rpcclient: use rpccli_spoolss_GetPrinterDriverDirectory in rpcclient.

Guenther

13 years agos3: re-run make samba3-idl.
Günther Deschner [Thu, 19 Feb 2009 01:05:38 +0000 (02:05 +0100)]
s3: re-run make samba3-idl.

Guenther

13 years agospoolss: make spoolss_DriverDirectoryInfo1 public and gensize.
Günther Deschner [Thu, 19 Feb 2009 00:46:49 +0000 (01:46 +0100)]
spoolss: make spoolss_DriverDirectoryInfo1 public and gensize.

Guenther

13 years agos3-spoolss: add support for "AddPort" via _spoolss_XcvData for Vista.
Günther Deschner [Wed, 18 Feb 2009 23:41:41 +0000 (00:41 +0100)]
s3-spoolss: add support for "AddPort" via _spoolss_XcvData for Vista.

Guenther

13 years agoInteresting C compiler you have there... :-)
Volker Lendecke [Wed, 18 Feb 2009 23:51:51 +0000 (00:51 +0100)]
Interesting C compiler you have there... :-)

13 years agos3: re-run make samba3-idl.
Günther Deschner [Wed, 18 Feb 2009 23:51:15 +0000 (00:51 +0100)]
s3: re-run make samba3-idl.

Guenther

13 years agospoolss: add spoolss_PortData2 (used by vista).
Günther Deschner [Wed, 18 Feb 2009 23:10:12 +0000 (00:10 +0100)]
spoolss: add spoolss_PortData2 (used by vista).

Guenther

13 years agospoolss: use spoolss access mask in OpenPrinter{Ex}.
Günther Deschner [Wed, 18 Feb 2009 23:09:30 +0000 (00:09 +0100)]
spoolss: use spoolss access mask in OpenPrinter{Ex}.

Guenther

13 years agoFix coverity CID-602. Possible use of uninitialized var.
Jeremy Allison [Wed, 18 Feb 2009 23:45:49 +0000 (15:45 -0800)]
Fix coverity CID-602. Possible use of uninitialized var.
Jeremy.

13 years agos4-smbtorture: enable spoolss_AddPrinterDriverEx ndr test.
Günther Deschner [Wed, 18 Feb 2009 19:35:48 +0000 (20:35 +0100)]
s4-smbtorture: enable spoolss_AddPrinterDriverEx ndr test.

Guenther

13 years agos3: re-run make samba3-idl.
Günther Deschner [Wed, 18 Feb 2009 19:21:09 +0000 (20:21 +0100)]
s3: re-run make samba3-idl.

Guenther

13 years agospoolss: fix idl for spoolss_AddPrinterDriver and spoolss_AddPrinterDriverEx.
Günther Deschner [Wed, 18 Feb 2009 17:10:31 +0000 (18:10 +0100)]
spoolss: fix idl for spoolss_AddPrinterDriver and spoolss_AddPrinterDriverEx.

Guenther

13 years agospoolss: add spoolss_AddDriverInfo8 (used by vista for adding drivers).
Günther Deschner [Wed, 18 Feb 2009 16:01:37 +0000 (17:01 +0100)]
spoolss: add spoolss_AddDriverInfo8 (used by vista for adding drivers).

Guenther

13 years agos3-spoolss: remove old spoolss_XcvData.
Günther Deschner [Tue, 17 Feb 2009 13:26:56 +0000 (14:26 +0100)]
s3-spoolss: remove old spoolss_XcvData.

Guenther

13 years agos3-spoolss: use pidl for _spoolss_XcvData.
Günther Deschner [Tue, 17 Feb 2009 13:23:56 +0000 (14:23 +0100)]
s3-spoolss: use pidl for _spoolss_XcvData.

Guenther

13 years agos3: re-run make samba3-idl.
Günther Deschner [Wed, 18 Feb 2009 15:10:40 +0000 (16:10 +0100)]
s3: re-run make samba3-idl.

Guenther

13 years agospoolss: fix spoolss_MonitorUi struct.
Günther Deschner [Wed, 18 Feb 2009 15:09:02 +0000 (16:09 +0100)]
spoolss: fix spoolss_MonitorUi struct.

Guenther

13 years agos3: re-run make samba3-idl.
Günther Deschner [Wed, 18 Feb 2009 13:47:33 +0000 (14:47 +0100)]
s3: re-run make samba3-idl.

Guenther

13 years agospoolss: add spoolss_MonitorUi struct.
Günther Deschner [Tue, 17 Feb 2009 13:21:16 +0000 (14:21 +0100)]
spoolss: add spoolss_MonitorUi struct.

Guenther

13 years agospoolss: add spoolss_PortData1.
Günther Deschner [Tue, 17 Feb 2009 10:31:23 +0000 (11:31 +0100)]
spoolss: add spoolss_PortData1.

Guenther

13 years agotevent: add tevent_wakeup_send/recv()
Stefan Metzmacher [Tue, 17 Feb 2009 09:22:33 +0000 (10:22 +0100)]
tevent: add tevent_wakeup_send/recv()

This can be used as tevent_req based timer event.

metze

13 years agotevent: rename tevent_req_set_timeout() => tevent_req_set_endtime()
Stefan Metzmacher [Tue, 17 Feb 2009 09:15:18 +0000 (10:15 +0100)]
tevent: rename tevent_req_set_timeout() => tevent_req_set_endtime()

This makes more clear what the function does.

metze

13 years agos4:netlogon: don't mix in and out negotiate_flags in dcesrv_netr_ServerAuthenticate()
Stefan Metzmacher [Wed, 18 Feb 2009 05:26:30 +0000 (06:26 +0100)]
s4:netlogon: don't mix in and out negotiate_flags in dcesrv_netr_ServerAuthenticate()

metze

13 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba into master-devel
Andrew Bartlett [Wed, 18 Feb 2009 06:47:43 +0000 (17:47 +1100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba into master-devel

13 years agopaper over failure to reprovision with os.unlink()
Andrew Bartlett [Wed, 18 Feb 2009 06:44:07 +0000 (17:44 +1100)]
paper over failure to reprovision with os.unlink()

We need to figure out why the deletes on the database fail, but for
now doing an unlink of templates_tdb isn't too bad.

Andrew Bartlett

13 years agoWorked around a problem with select/poll/epoll and gnutls
Andrew Tridgell [Wed, 18 Feb 2009 06:37:45 +0000 (17:37 +1100)]
Worked around a problem with select/poll/epoll and gnutls

Our packet layer relies on the event system reliably telling us when a
packet is available. When we are using a socket layer like TLS then
things get a bit trickier, as there may be bytes in the encryption
buffer which could be read even if there are no bytes at the socket
level. The GNUTLS library is supposed to prevent this happening by
always leaving some data at the socket level when there is data to be
processed in its buffers, but it seems that this is not always
reliable.

To work around this I have added a new packet option
packet_set_unreliable_select() which tells the packet layer to not
assume that the socket layer has a reliable select, and to instead
keep trying to read from the socket until it gets back no data. This
option is set for the ldap client and server when TLS is negotiated.

This seems to fix the problems with the ldaps tests.

13 years agofixed some of the TLS problems
Andrew Tridgell [Wed, 18 Feb 2009 03:46:57 +0000 (14:46 +1100)]
fixed some of the TLS problems

This fixes two things in the TLS support for Samba4. The first is to
use a somewhat more correct hostname instead of 'Samba' when
generating the test certificates. That allows TLS test clients (such
as gnutls-cli) to connect to Samba4 using auto-generated certificates.

The second fix is to add a call to gcry_control() to tell gcrypt to
use /dev/urandom instead of /dev/random (on systems that support
that). That means that test certificate generation is now very fast,
which was previously an impediment to putting the TLS tests on the
build farm.

13 years agoDon't miss an absolute pathname as a kerberos keytab path. From Glenn Machin <gmachin...
Jeremy Allison [Tue, 17 Feb 2009 23:54:33 +0000 (15:54 -0800)]
Don't miss an absolute pathname as a kerberos keytab path. From Glenn Machin <gmachin@sandia.gov>.
Jeremy.

13 years agoFix bug #6117 - Samba 3.3.0: pdbedit -a core dumps.
Jeremy Allison [Tue, 17 Feb 2009 21:43:58 +0000 (13:43 -0800)]
Fix bug #6117 - Samba 3.3.0: pdbedit -a core dumps.
Jeremy.

13 years agoFix warning about missmatch of uint32_t and size_t.
Jeremy Allison [Tue, 17 Feb 2009 21:18:10 +0000 (13:18 -0800)]
Fix warning about missmatch of uint32_t and size_t.
Jeremy.

13 years agodocs: extend the example in the idmp_rid manpage to configure 2 domains with rid
Michael Adam [Tue, 17 Feb 2009 07:59:27 +0000 (08:59 +0100)]
docs: extend the example in the idmp_rid manpage to configure 2 domains with rid

Michael

13 years agodocs: extend the idmap_rid manpage
Michael Adam [Tue, 17 Feb 2009 07:51:39 +0000 (08:51 +0100)]
docs: extend the idmap_rid manpage

Michael

13 years agos3:winbindd: make do_async_domain() static.
Michael Adam [Fri, 13 Feb 2009 15:40:17 +0000 (16:40 +0100)]
s3:winbindd: make do_async_domain() static.

Michael

13 years agos3:build: improve the check for a working krb5-config.
Michael Adam [Fri, 13 Feb 2009 12:02:23 +0000 (13:02 +0100)]
s3:build: improve the check for a working krb5-config.

Not only check if it exists and is executable, but also
check whether it accepts the command line "krb5-config --libs gssapi".

Chris Hoogendyk <hoogendyk@bio.umass.edu> has reported configure
failing on a Solaris machine due to krb5-config raising errors on
these options.

Michael

13 years agos4-smbtorture: fix spoolss test after count out,ref idl changes.
Günther Deschner [Mon, 16 Feb 2009 15:42:21 +0000 (16:42 +0100)]
s4-smbtorture: fix spoolss test after count out,ref idl changes.

Guenther

13 years agos4-spoolss: fix spoolss server after out,ref count pointer changes.
Günther Deschner [Mon, 16 Feb 2009 15:41:48 +0000 (16:41 +0100)]
s4-spoolss: fix spoolss server after out,ref count pointer changes.

Guenther

13 years agospoolss: fix spoolss helper for out ref count pointer.
Günther Deschner [Mon, 16 Feb 2009 15:40:54 +0000 (16:40 +0100)]
spoolss: fix spoolss helper for out ref count pointer.

Guenther

13 years agos3: re-run make samba3-idl.
Günther Deschner [Tue, 17 Feb 2009 15:15:32 +0000 (16:15 +0100)]
s3: re-run make samba3-idl.

Guenther

13 years agospoolss: in enum-calls make [out] count a ref pointer.
Günther Deschner [Mon, 16 Feb 2009 15:25:30 +0000 (16:25 +0100)]
spoolss: in enum-calls make [out] count a ref pointer.

Guenther

13 years agos3-spoolss: remove old spoolss_ResetPrinter.
Günther Deschner [Tue, 17 Feb 2009 03:29:27 +0000 (04:29 +0100)]
s3-spoolss: remove old spoolss_ResetPrinter.

Guenther

13 years agos3-spoolss: use pidl for _spoolss_ResetPrinter.
Günther Deschner [Tue, 17 Feb 2009 03:28:54 +0000 (04:28 +0100)]
s3-spoolss: use pidl for _spoolss_ResetPrinter.

Guenther

13 years agos3: re-run make samba3-idl.
Günther Deschner [Tue, 17 Feb 2009 09:52:04 +0000 (10:52 +0100)]
s3: re-run make samba3-idl.

Guenther

13 years agospoolss: fill in spoolss_ResetPrinter.
Günther Deschner [Tue, 17 Feb 2009 09:47:35 +0000 (10:47 +0100)]
spoolss: fill in spoolss_ResetPrinter.

Guenther

13 years agos3-netapi: fix Coverity #881 and #882.
Günther Deschner [Tue, 17 Feb 2009 09:14:58 +0000 (10:14 +0100)]
s3-netapi: fix Coverity #881 and #882.

Guenther