ira/wip.git
12 years agos4:dsdb Break up 'parse a DN from DRSUAPI' into a subfunction
Andrew Bartlett [Mon, 16 Nov 2009 07:35:08 +0000 (18:35 +1100)]
s4:dsdb Break up 'parse a DN from DRSUAPI' into a subfunction

This should make it easier to call this function from the DRS schema
load code, rather than duplicate it.

(we may do the same with other functions in future).

Andrew Bartlett

12 years agos4:dsdb Add 'dsdb_flags' to dsdb_module_search() to enable often-used features
Andrew Bartlett [Mon, 16 Nov 2009 07:32:17 +0000 (18:32 +1100)]
s4:dsdb Add 'dsdb_flags' to dsdb_module_search() to enable often-used features

These flags, also on dsdb_module_search_dn() allow us to add commonly
set controls to this pre-packaged blocking search, without rebuilding
the whole function in each caller.

Andrew Bartlett

12 years agoDon't overwrite a dynamic pointer with the address of a stack
Jeremy Allison [Mon, 16 Nov 2009 22:55:21 +0000 (14:55 -0800)]
Don't overwrite a dynamic pointer with the address of a stack
variable.
Jeremy.

12 years agos4:SAMLDB module
Matthias Dieter Wallnöfer [Mon, 16 Nov 2009 16:57:50 +0000 (17:57 +0100)]
s4:SAMLDB module

- Add more "\n" to make sure that error messages are displayed immediately
- Add a "NULL" in a attribute list

12 years agoRevert "s4:dsdb/repl/replicated_objects - Applicate also here the new "lDAPDisplayNam...
Matthias Dieter Wallnöfer [Mon, 16 Nov 2009 16:01:43 +0000 (17:01 +0100)]
Revert "s4:dsdb/repl/replicated_objects - Applicate also here the new "lDAPDisplayName" generator"

This reverts commit df95d5c29292968b465bff24c3cf78800677a4d4.

abartlet pointed out in a post on the samba-technical list that this isn't
necessary at all (lDAPDisplayName normalisation algorithm). Rather it breaks
functionality of the replication.

12 years agoREADME.Coding: add section about usage of helper variables
Stefan Metzmacher [Mon, 16 Nov 2009 09:52:27 +0000 (10:52 +0100)]
README.Coding: add section about usage of helper variables

metze

12 years agoREADME.Coding: fix error in "good example"
Stefan Metzmacher [Mon, 16 Nov 2009 09:51:31 +0000 (10:51 +0100)]
README.Coding: fix error in "good example"

metze

12 years agos3:libsmb: avoid passing a function call as function parameter
Stefan Metzmacher [Mon, 16 Nov 2009 08:59:58 +0000 (09:59 +0100)]
s3:libsmb: avoid passing a function call as function parameter

Using a helper variable makes it easier to "step" into the desired function
within gdb.

metze

12 years agos4:dsdb LDB attribute lists must always be a static const char **.
Andrew Bartlett [Sun, 15 Nov 2009 23:19:42 +0000 (10:19 +1100)]
s4:dsdb LDB attribute lists must always be a static const char **.

(If they are not, then due to the async code, they will cause a segfault as they reference a reclaimed portion of the stack).

Andrew Bartlett

12 years agos4:provision - Removed dependency on full Samba 3 schema from FDS
Endi S. Dewata [Fri, 13 Nov 2009 15:58:20 +0000 (09:58 -0600)]
s4:provision - Removed dependency on full Samba 3 schema from FDS

12 years agoFixed some major bugs in inheritance and access checks.
Nadezhda Ivanova [Sun, 15 Nov 2009 20:31:44 +0000 (22:31 +0200)]
Fixed some major bugs in inheritance and access checks.

Fixed sd creation not working on LDAP modify.
Fixed incorrect replacement of CO and CG.
Fixed incorrect access check on modify for SD modification.
Fixed failing sec_descriptor test and enabled it.
Fixed failing sd add test in ldap.python

12 years agos3: Remove two more DFSG-nonfree text documents at release time. (Debian bug
Jelmer Vernooij [Sun, 15 Nov 2009 19:52:11 +0000 (20:52 +0100)]
s3: Remove two more DFSG-nonfree text documents at release time. (Debian bug

12 years agoFix writing corrupt registries because of hardcoded version string in IDL.
Wilco Baan Hofman [Thu, 15 Oct 2009 11:18:52 +0000 (13:18 +0200)]
Fix writing corrupt registries because of hardcoded version string in IDL.

Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
12 years agoFix NULL pointer dereference in libgpo when listing Local Policy which has no securit...
Wilco Baan Hofman [Sat, 10 Oct 2009 22:12:28 +0000 (00:12 +0200)]
Fix NULL pointer dereference in libgpo when listing Local Policy which has no security descriptor.

Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
12 years agoFix writing corrupt REG_SZ to the registry.
Wilco Baan Hofman [Sat, 10 Oct 2009 19:42:27 +0000 (21:42 +0200)]
Fix writing corrupt REG_SZ to the registry.

Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
12 years agoFix trailing garbage in the hbin block.
Wilco Baan Hofman [Thu, 8 Oct 2009 10:36:30 +0000 (12:36 +0200)]
Fix trailing garbage in the hbin block.

This specifically fixes a problem showing extra bytes of garbage in list and
print in regshell, even though the vk.data_length has the correct size.

Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
12 years agoAdded tests for descriptor inheritance on ldap modify.
Zahari Zahariev [Sun, 15 Nov 2009 17:26:02 +0000 (19:26 +0200)]
Added tests for descriptor inheritance on ldap modify.

Fixed some expected owners and groups.

Signed-off-by: Nadezhda Ivanova <nadezhda.ivanova@postpath.com>
12 years agoldb:python bindings - add a context on "py_ldb_delete"
Matthias Dieter Wallnöfer [Sun, 15 Nov 2009 13:23:32 +0000 (14:23 +0100)]
ldb:python bindings - add a context on "py_ldb_delete"

So the converted DN will be freed after usage.

12 years agos4:ldap.py - enhance schema addition test
Matthias Dieter Wallnöfer [Fri, 13 Nov 2009 21:31:53 +0000 (22:31 +0100)]
s4:ldap.py - enhance schema addition test

Don't add only a new objectclass but also a new attribute. Plus let now the
server itself calculate the "lDAPDisplayName" attribute and compare the result.

12 years agos4:dsdb/repl/replicated_objects - Applicate also here the new "lDAPDisplayName" generator
Matthias Dieter Wallnöfer [Sat, 14 Nov 2009 19:14:45 +0000 (20:14 +0100)]
s4:dsdb/repl/replicated_objects - Applicate also here the new "lDAPDisplayName" generator

Also here we've to be sure to generate the attribute correctly if it doesn't
exist yet.

12 years agos4:SAMLDB module - Add support for required and generated schema attributes
Andrew Bartlett [Thu, 24 Sep 2009 04:14:37 +0000 (21:14 -0700)]
s4:SAMLDB module - Add support for required and generated schema attributes

This missing support found by Microsoft test suite at AD interop event.

Patch by Andrew Bartlett
Enhancements by Matthias Dieter Wallnöfer

12 years agos4:samdb util - add a call for generating a correct "lDAPDisplayName"
Matthias Dieter Wallnöfer [Sat, 14 Nov 2009 19:12:42 +0000 (20:12 +0100)]
s4:samdb util - add a call for generating a correct "lDAPDisplayName"

This is needed for the SAMLDB module enhancement regarding schema objects.
The algorithm in pseudo code is located in MS-ADTS 3.1.1.2.3.4.

12 years agos3: Fix a memleak in sys_popen
Volker Lendecke [Sat, 14 Nov 2009 16:23:08 +0000 (17:23 +0100)]
s3: Fix a memleak in sys_popen

Found with "dfree command" set

12 years agos4:ldap.py - Deactivates some at the moment pointless test parts
Matthias Dieter Wallnöfer [Sat, 14 Nov 2009 20:56:59 +0000 (21:56 +0100)]
s4:ldap.py - Deactivates some at the moment pointless test parts

I think those parts should be deactivated since they're result set checks for
lookups which are commented out already.

12 years agoMention typedef struct in README.Coding
Volker Lendecke [Sat, 14 Nov 2009 11:55:41 +0000 (12:55 +0100)]
Mention typedef struct in README.Coding

12 years agos3: Add min_setup, min_param and min_data to cli_trans_recv
Volker Lendecke [Sat, 14 Nov 2009 10:12:50 +0000 (11:12 +0100)]
s3: Add min_setup, min_param and min_data to cli_trans_recv

Every caller that expects to receive something needs to check if enough was
sent. Make this check mandatory for everyone.

Yes, this makes the parameter list for cli_trans a bit silly, but that's just
the way it is: A silly protocol request :-)

While there, convert some _done functions to tevent_req_simple_finish_ntstatus.

12 years agoAttempt to fix the s4 build -- we can not use map_nt_error_from_unix in lib/
Volker Lendecke [Sat, 14 Nov 2009 10:32:00 +0000 (11:32 +0100)]
Attempt to fix the s4 build -- we can not use map_nt_error_from_unix in lib/

12 years agos3: Convert cli_set_unix_extensions_capabilities_send to async
Volker Lendecke [Fri, 13 Nov 2009 23:40:21 +0000 (00:40 +0100)]
s3: Convert cli_set_unix_extensions_capabilities_send to async

12 years agoIntroduce tevent_req_poll_ntstatus
Volker Lendecke [Sat, 14 Nov 2009 09:01:44 +0000 (10:01 +0100)]
Introduce tevent_req_poll_ntstatus

12 years agoIntroduce tevent_req_simple_finish_ntstatus
Volker Lendecke [Sat, 14 Nov 2009 08:38:20 +0000 (09:38 +0100)]
Introduce tevent_req_simple_finish_ntstatus

12 years agos3: Tiny logic simplification
Volker Lendecke [Thu, 12 Nov 2009 19:44:37 +0000 (20:44 +0100)]
s3: Tiny logic simplification

12 years agos4-drs: DsExecuteKCC() implementation
Erick Nascimento [Wed, 11 Nov 2009 20:25:13 +0000 (18:25 -0200)]
s4-drs: DsExecuteKCC() implementation

I implemented the DsExecuteKCC() handling code on kccsrv_execute_kcc().

Signed-off-by: Andrew Tridgell <tridge@samba.org>
12 years agopam_winbind: fix a printf type mismatch warning
Björn Jacke [Sat, 14 Nov 2009 00:52:49 +0000 (01:52 +0100)]
pam_winbind: fix a printf type mismatch warning

12 years agos3:fix a comment typo
Michael Adam [Sat, 14 Nov 2009 00:23:05 +0000 (01:23 +0100)]
s3:fix a comment typo

Michael

12 years agos3:is_trusted_domain: shortcut if domain name == global_sam_name
Michael Adam [Sat, 14 Nov 2009 00:21:42 +0000 (01:21 +0100)]
s3:is_trusted_domain: shortcut if domain name == global_sam_name

A domain can't have a trust with itself.
This saves some roundtrips to the ldap server for ldapsam.

Michael

12 years agos3:is_trusted_domain: shortcut if domain name is NULL or empty
Michael Adam [Sat, 14 Nov 2009 00:12:22 +0000 (01:12 +0100)]
s3:is_trusted_domain: shortcut if domain name is NULL or empty

This saves some roundtrips to LDAP in an ldapsm setup.

Michael

12 years agos3:passdb: bump interface VERSION 18->19 (removed uid_to_rid)
Michael Adam [Sat, 14 Nov 2009 00:07:34 +0000 (01:07 +0100)]
s3:passdb: bump interface VERSION 18->19 (removed uid_to_rid)

Michael

12 years agos3:passdb: remove the uid_to_rid method - we only need uid_to_sid
Michael Adam [Sat, 14 Nov 2009 00:06:35 +0000 (01:06 +0100)]
s3:passdb: remove the uid_to_rid method - we only need uid_to_sid

Michael

12 years agos3:pdb_default_uid_to_sid: fix some debug statements.
Michael Adam [Fri, 13 Nov 2009 23:34:14 +0000 (00:34 +0100)]
s3:pdb_default_uid_to_sid: fix some debug statements.

Michael

12 years agos3/pam: move variable declaration into belonging ifdef section
Björn Jacke [Fri, 13 Nov 2009 22:32:04 +0000 (23:32 +0100)]
s3/pam: move variable declaration into belonging ifdef section

This fixes a unused variable 'addr' warning on some platforms

12 years agoadd e2fsprogs-devel as build dependency this is needed for AD because it contains...
Christian Ambach [Mon, 6 Jul 2009 12:08:57 +0000 (14:08 +0200)]
add e2fsprogs-devel as build dependency this is needed for AD because it contains libcom/libcom_err files and headers

Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
Signed-off-by: Michael Adam <obnox@samba.org>
12 years agopackaging(RHEL-CTDB): add the current githash to the rpm release number by default
Michael Adam [Wed, 4 Nov 2009 11:26:46 +0000 (12:26 +0100)]
packaging(RHEL-CTDB): add the current githash to the rpm release number by default

Disable this (to build a release-rpm) by calling

USE_GITHASH=no makerpms.sh

Michael

12 years agopackaging(RHEL-CTDB): enable parallel build
Michael Adam [Thu, 20 Aug 2009 11:37:11 +0000 (13:37 +0200)]
packaging(RHEL-CTDB): enable parallel build

Michael

12 years agopackaging(RHEL-CTDB): fix packaging of pam_winbind.mo file
Michael Adam [Thu, 20 Aug 2009 11:33:42 +0000 (13:33 +0200)]
packaging(RHEL-CTDB): fix packaging of pam_winbind.mo file

Michael

12 years agopackaging(RHEL-CTDB): move the idmap and nss_info modules to the common package
Michael Adam [Mon, 3 Aug 2009 13:30:42 +0000 (15:30 +0200)]
packaging(RHEL-CTDB): move the idmap and nss_info modules to the common package

In this layout, this is the package that contains winbindd related stuff.

Michael

12 years agopackaging(RHEL-CTDB): package the winbind_krb5_locator.so plugin
Michael Adam [Mon, 3 Aug 2009 12:32:52 +0000 (14:32 +0200)]
packaging(RHEL-CTDB): package the winbind_krb5_locator.so plugin

Michael

12 years agopackaging(RHEL-CTDB): package the manpage of the winbind_krb5_locator plugin
Michael Adam [Mon, 3 Aug 2009 12:05:42 +0000 (14:05 +0200)]
packaging(RHEL-CTDB): package the manpage of the winbind_krb5_locator plugin

Michael

12 years agopackaging(RHEL-CTDB): package the manpage of "ldbrename"
Michael Adam [Mon, 3 Aug 2009 12:04:33 +0000 (14:04 +0200)]
packaging(RHEL-CTDB): package the manpage of "ldbrename"

Michael

12 years agopackaging(RHEL-CTDB): package the manpage of "sharesec"
Michael Adam [Mon, 3 Aug 2009 12:04:09 +0000 (14:04 +0200)]
packaging(RHEL-CTDB): package the manpage of "sharesec"

Michael

12 years agopackaging(RHEL-CTDB): pam_winbindd man page has moved from section 7 to 8
Michael Adam [Mon, 3 Aug 2009 11:45:40 +0000 (13:45 +0200)]
packaging(RHEL-CTDB): pam_winbindd man page has moved from section 7 to 8

This due to updating the docs tarball to the 3.4 docs.

Michael

12 years agopackaging(RHEL-CTDB): disable the merged build.
Michael Adam [Wed, 1 Jul 2009 09:06:34 +0000 (11:06 +0200)]
packaging(RHEL-CTDB): disable the merged build.

Michael

12 years agopackaging(RHEL-CTDB): also pack libwbcient in winbind-32bit package
Michael Adam [Thu, 19 Mar 2009 23:47:45 +0000 (00:47 +0100)]
packaging(RHEL-CTDB): also pack libwbcient in winbind-32bit package

Michael

Signed-off-by: Michael Adam <obnox@samba.org>
12 years agopackaging(RHEL-CTDB): add new pam_winbind.mo to the common package
Michael Adam [Thu, 19 Mar 2009 23:30:35 +0000 (00:30 +0100)]
packaging(RHEL-CTDB): add new pam_winbind.mo to the common package

Michael

Signed-off-by: Michael Adam <obnox@samba.org>
12 years agopackaging(RHEL-CTDB): add new binary sharesec to the client package.
Michael Adam [Thu, 19 Mar 2009 23:28:36 +0000 (00:28 +0100)]
packaging(RHEL-CTDB): add new binary sharesec to the client package.

Michael

Signed-off-by: Michael Adam <obnox@samba.org>
12 years agopackaging(RHEL-CTDB): add new binary ldbrename to the common rpm
Michael Adam [Thu, 19 Mar 2009 23:26:11 +0000 (00:26 +0100)]
packaging(RHEL-CTDB): add new binary ldbrename to the common rpm

Michael

Signed-off-by: Michael Adam <obnox@samba.org>
12 years agopackaging(RHEL-CTDB): fix location of nsswitch/ directory for install
Michael Adam [Mon, 29 Jun 2009 15:07:14 +0000 (17:07 +0200)]
packaging(RHEL-CTDB): fix location of nsswitch/ directory for install

This has been moved to the top level directory in 3.4.

Michael

12 years agopackaging(RHEL-CTDB): don't pass CFLAGS to make.
Michael Adam [Mon, 29 Jun 2009 15:05:00 +0000 (17:05 +0200)]
packaging(RHEL-CTDB): don't pass CFLAGS to make.

This breaks the build since 3.3 since it overwrites the CFLAGS
set by configure.

Michael

12 years agopackaging(RHEL-CTDB): don't "make proto" any more.
Michael Adam [Mon, 29 Jun 2009 15:03:09 +0000 (17:03 +0200)]
packaging(RHEL-CTDB): don't "make proto" any more.

This has become unnecessary in 3.3

Michael

12 years agopackaging(RHEL-CTDB):makerpms.sh: replace source/ by source3/
Michael Adam [Tue, 23 Jun 2009 21:09:09 +0000 (23:09 +0200)]
packaging(RHEL-CTDB):makerpms.sh: replace source/ by source3/

Michael

12 years agopackaging(RHEL-CTDB):makespec.sh: fix detection of version
Michael Adam [Tue, 23 Jun 2009 21:06:40 +0000 (23:06 +0200)]
packaging(RHEL-CTDB):makespec.sh: fix detection of version

Michael

12 years agopackaging(RHEL-CTDB): makeversion.sh: v3-4-test uses source3 instead of source
Michael Adam [Tue, 23 Jun 2009 20:41:51 +0000 (22:41 +0200)]
packaging(RHEL-CTDB): makeversion.sh: v3-4-test uses source3 instead of source

Michael

12 years agopackaging(RHEL-CTDB): makerpms.sh: build winbind-32bit libs in the 64bit build
Michael Adam [Wed, 21 Jan 2009 08:49:12 +0000 (09:49 +0100)]
packaging(RHEL-CTDB): makerpms.sh: build winbind-32bit libs in the 64bit build

Michael
(cherry picked from commit a9a506b6640986548e2ae8540b7ae93960d6ece5)

12 years agopackaging(RHEL-CTDB): Build winbind-32bit package in the 64bit build
Michael Adam [Tue, 20 Jan 2009 18:47:28 +0000 (19:47 +0100)]
packaging(RHEL-CTDB): Build winbind-32bit package in the 64bit build

Michael
(cherry picked from commit f5cd88a25f360e6609dc5abe24247fab78af6854)

12 years agopackaging(RHEL-CTDB): extend makespec.sh to extract VENDOR_PATCH from version.h
Michael Adam [Wed, 21 Jan 2009 10:03:34 +0000 (11:03 +0100)]
packaging(RHEL-CTDB): extend makespec.sh to extract VENDOR_PATCH from version.h

Michael
(cherry picked from commit fc122aa276bce379b492e5bdf52ab3e03bc3737f)

12 years agopackaging(RHEL-CTDB): The former release number has basically moved into VERSION
Michael Adam [Wed, 21 Jan 2009 09:24:31 +0000 (10:24 +0100)]
packaging(RHEL-CTDB): The former release number has basically moved into VERSION

Michael

12 years agos3:smbd: also fill the memcache with sid<->id mappings in ldapsam_sid_to_id()
Michael Adam [Fri, 13 Nov 2009 15:16:50 +0000 (16:16 +0100)]
s3:smbd: also fill the memcache with sid<->id mappings in ldapsam_sid_to_id()

not only the persistent idmap cache.

Michael

12 years agos3:smbd: make idmap cache persistent for "ldapsam:trusted".
Michael Adam [Fri, 13 Nov 2009 14:51:33 +0000 (15:51 +0100)]
s3:smbd: make idmap cache persistent for "ldapsam:trusted".

This stores the mappings found in the idmap cache (which lives
inside gencache). This cache is already read in sid_to_Xid()
and Xid_to_sid() for ldapsam:trusted, this fills the opposite
direction, massively reducing the number of ldap roundtrips
across smbd restarts.

Michael

12 years agoutil: str_list_unique() bugfix
Kamen Mazdrashki [Fri, 13 Nov 2009 01:57:48 +0000 (03:57 +0200)]
util: str_list_unique() bugfix

j is actually the index of the last element in the list
size of the list though is j+1 <- to make room for the
terminating NULL element

12 years agoutil: str_list_unique_2() test implementation
Kamen Mazdrashki [Fri, 13 Nov 2009 01:56:07 +0000 (03:56 +0200)]
util: str_list_unique_2() test implementation

Difference with previous test for str_list_unique() is
that this test allows number of elements and number
of duplicates to be supplied on command line using
--option="list_unique:count=47"
--option="list_unique:dups=7"

12 years agos4:heimdal Import generated files from heimdal tree
Andrew Bartlett [Fri, 13 Nov 2009 02:50:25 +0000 (13:50 +1100)]
s4:heimdal Import generated files from heimdal tree

We should be able to rebuild these, but a cp is easier :-)

12 years agos4:heimdal: import lorikeet-heimdal-200911122202 (commit 9291fd2d101f3eecec550178634f...
Andrew Bartlett [Thu, 12 Nov 2009 23:51:14 +0000 (10:51 +1100)]
s4:heimdal: import lorikeet-heimdal-200911122202 (commit 9291fd2d101f3eecec550178634faa94ead3e9a1)

12 years agos4:heimdal: import lorikeet-heimdal-200909210500 (commit 290db8d23647a27c39b97c189a0b...
Andrew Bartlett [Mon, 21 Sep 2009 06:18:34 +0000 (23:18 -0700)]
s4:heimdal: import lorikeet-heimdal-200909210500 (commit 290db8d23647a27c39b97c189a0b2ef6ec21ca69)

12 years agoFix large paged search
Volker Lendecke [Mon, 18 May 2009 14:04:04 +0000 (16:04 +0200)]
Fix large paged search

Signed-off-by: Michael Adam <obnox@samba.org>
12 years agofix bogus "out of memory" winbind msg
Volker Lendecke [Wed, 13 May 2009 08:12:26 +0000 (10:12 +0200)]
fix bogus "out of memory" winbind msg

Signed-off-by: Michael Adam <obnox@samba.org>
12 years agos4-ldb: changed the DN checks for \n to warnings
Andrew Tridgell [Fri, 13 Nov 2009 08:31:40 +0000 (19:31 +1100)]
s4-ldb: changed the DN checks for \n to warnings

a \n is sometimes allowed in AD (eg in deleted DNs). Until we know
when is really is allowed, treat it as a warning only.

12 years agos4-ldb: make DN escaping/unescaping consistent
Andrew Tridgell [Fri, 13 Nov 2009 06:48:35 +0000 (17:48 +1100)]
s4-ldb: make DN escaping/unescaping consistent

The DN escape function was using the form \c where c is any
character. The unescape function was using \XX where XX is a 2 digit
hex number. The asymmetry led to quite a few problems when we start to
deal with DNs containing escape chars, such as CN=foo\0ADEL:XXX. The
result was a DN that was not accessible.

This patch changes the escaping to follow RFC2253 much more
closely. We accept either type of escape, and produce the two types of
escape, depending on the character being escaped

12 years agos3: Convert cli_unix_extensions_version to async
Volker Lendecke [Thu, 12 Nov 2009 22:07:21 +0000 (23:07 +0100)]
s3: Convert cli_unix_extensions_version to async

12 years agos3-rpcclient: use the parsed binding string flags for auth choice.
Günther Deschner [Thu, 12 Nov 2009 15:45:33 +0000 (16:45 +0100)]
s3-rpcclient: use the parsed binding string flags for auth choice.

This allows rpcclient to be called like this:

rpcclient ncacn_ip_tcp:w2k8r2[sign,seal] -U administrator%secret -c "dscracknames gd"

Guenther

12 years agoRemove unused variable warning.
Jeremy Allison [Thu, 12 Nov 2009 22:09:25 +0000 (14:09 -0800)]
Remove unused variable warning.
Jeremy.

12 years agoRemove erroneous 'presult = NULL' changes. Now presult only gets set
Jeremy Allison [Thu, 12 Nov 2009 21:59:25 +0000 (13:59 -0800)]
Remove erroneous 'presult = NULL' changes. Now presult only gets set
if NTSTATUS == OK.
Jeremy.

12 years agoRevert "Ensure every return path initializes presult as NULL."
Jeremy Allison [Thu, 12 Nov 2009 21:57:13 +0000 (13:57 -0800)]
Revert "Ensure every return path initializes presult as NULL."
Vl is correct, this is the wrong way to fix this.

This reverts commit 83c2c177a5e86d04da37384f1f04230c8274e1e6.

12 years agoEnsure all callers to the rpc_client/cli_pipe functions correctly
Jeremy Allison [Thu, 12 Nov 2009 21:56:33 +0000 (13:56 -0800)]
Ensure all callers to the rpc_client/cli_pipe functions correctly
initialize return variables.
Jeremy.

12 years agoFix bug 6891 - using windows explorer to change ownership on a folder fails with...
Jeremy Allison [Thu, 12 Nov 2009 21:08:04 +0000 (13:08 -0800)]
Fix bug 6891 - using windows explorer to change ownership on a folder fails with Bad File Descriptor.
Jeremy.

12 years agoEnsure every return path initializes presult as NULL.
Jeremy Allison [Thu, 12 Nov 2009 19:49:54 +0000 (11:49 -0800)]
Ensure every return path initializes presult as NULL.
Ensures no crashes in calling code that forgets to
init return as null.
Jeremy.

12 years agos4:heimdal_build: allow flex-2.5.35 with bison-2.3
Stefan Metzmacher [Mon, 9 Nov 2009 17:23:06 +0000 (18:23 +0100)]
s4:heimdal_build: allow flex-2.5.35 with bison-2.3

metze

12 years agos3-kerberos: remove smb_krb5_get_tkt_from_creds().
Günther Deschner [Thu, 12 Nov 2009 14:42:03 +0000 (15:42 +0100)]
s3-kerberos: remove smb_krb5_get_tkt_from_creds().

Now that cli_krb5_get_ticket() already handles S4U2SELF impersonation, remove
smb_krb5_get_tkt_from_creds() which is not required anymore.

Guenther

12 years agos3-kerberos: avoid using ERROR_TABLE_BASE_krb5 without checking.
Günther Deschner [Thu, 12 Nov 2009 14:40:42 +0000 (15:40 +0100)]
s3-kerberos: avoid using ERROR_TABLE_BASE_krb5 without checking.

Guenther

12 years agos4:dsdb Make callbacks in extended_dn_out clearer to follow
Andrew Bartlett [Thu, 12 Nov 2009 10:31:11 +0000 (21:31 +1100)]
s4:dsdb Make callbacks in extended_dn_out clearer to follow

12 years agos4:selftest Mark the RPC-DSSYNC test as knownfail for now
Andrew Bartlett [Thu, 12 Nov 2009 10:14:13 +0000 (21:14 +1100)]
s4:selftest Mark the RPC-DSSYNC test as knownfail for now

We need to work on the provision or LDB modules to avoid DN attributes
without GUIDs (caused because the target does not exist at creation
time).

Andrew Bartlett

12 years agos4:libcli/ldap Add 'relax' OID to known network representations
Andrew Bartlett [Thu, 12 Nov 2009 06:16:25 +0000 (17:16 +1100)]
s4:libcli/ldap Add 'relax' OID to known network representations

This patch, inspired by a patche by Endi S. Dewata
<edewata@redhat.com>, allows this control to be passed to the LDAP
backend.

Andrew Bartlett

12 years agos4:provision - Added LDBBackend and ExistingBackend.
Endi S. Dewata [Fri, 6 Nov 2009 04:29:55 +0000 (22:29 -0600)]
s4:provision - Added LDBBackend and ExistingBackend.

12 years agos4:provision - Added constructors for FDSBackend and OpenLDAPBackend.
Endi S. Dewata [Fri, 6 Nov 2009 03:55:34 +0000 (21:55 -0600)]
s4:provision - Added constructors for FDSBackend and OpenLDAPBackend.

12 years agos4:provision - Added setup() method in LDAPBackend.
Endi S. Dewata [Fri, 6 Nov 2009 00:49:37 +0000 (18:49 -0600)]
s4:provision - Added setup() method in LDAPBackend.

12 years agos4:provision - Moved provision_xxx_backend() into backend-specific provision() method.
Endi S. Dewata [Thu, 5 Nov 2009 23:36:34 +0000 (17:36 -0600)]
s4:provision - Moved provision_xxx_backend() into backend-specific provision() method.

12 years agos4:provision - Added start() method in LDAPBackend.
Endi S. Dewata [Thu, 5 Nov 2009 18:04:05 +0000 (12:04 -0600)]
s4:provision - Added start() method in LDAPBackend.

12 years agos4:provision - Added initial implementation of FDSBackend and OpenLDAPBackend.
Endi S. Dewata [Thu, 5 Nov 2009 17:15:55 +0000 (11:15 -0600)]
s4:provision - Added initial implementation of FDSBackend and OpenLDAPBackend.

12 years agos3: Fix debug messages in check_reduced_name
Volker Lendecke [Thu, 12 Nov 2009 10:07:15 +0000 (11:07 +0100)]
s3: Fix debug messages in check_reduced_name

12 years agocifs.upcall: Fix Bug #6868: support building with Heimdal we well as with MIT.
Günther Deschner [Wed, 11 Nov 2009 23:52:38 +0000 (00:52 +0100)]
cifs.upcall: Fix Bug #6868: support building with Heimdal we well as with MIT.

Guenther

12 years agos3-kerberos: add smb_krb5_principal_get_realm().
Günther Deschner [Wed, 11 Nov 2009 23:51:46 +0000 (00:51 +0100)]
s3-kerberos: add smb_krb5_principal_get_realm().

Guenther

12 years agos4:repl_meta_data Parse linked attributes with schema syntaxes
Andrew Bartlett [Thu, 12 Nov 2009 04:39:17 +0000 (15:39 +1100)]
s4:repl_meta_data Parse linked attributes with schema syntaxes

The bug here was that by assuming all linked attributes were 'normal
DNs', we would miss the binary portion of DN+Binary.

This patch then has us reparse the string to determine it's GUID, for
the GUID lookup, but maintains the binary porition into the on-disk
format.

Andrew Bartlett