ira/wip.git
13 years agoFix enumeration of forest trusts from our root domain.
Gerald W. Carter [Mon, 31 Mar 2008 18:39:54 +0000 (13:39 -0500)]
Fix enumeration of forest trusts from our root domain.

Do not overwrite the domain->domain_flags when setting infomation
in set_dc_type_and_flags_connect().
(This used to be commit 3414eac439b731ad7204b821ddc4fec54fe4435d)

13 years agoDIsplay the short domain name in "wbinfo -m " by default.
Gerald W. Carter [Thu, 27 Mar 2008 20:23:36 +0000 (15:23 -0500)]
DIsplay the short domain name in "wbinfo -m " by default.

This fixes wbinfo -m to make preexisting behavior.
Also adds the dns domain to the --verbose output.
(This used to be commit b68caaa81bd75bb882c9363612d11d49dd73cb6f)

13 years agoAugmented "wbinfo -m" to list additional information about the type, direction, and...
Steven Danneman [Tue, 25 Mar 2008 23:58:40 +0000 (16:58 -0700)]
Augmented "wbinfo -m" to list additional information about the type, direction, and transitivty of trusts.

* added several helper functions to convert the trust_flags field in the
winbindd_tdc_domain to more useful administrator ideas of trust type, trust
direction, and trust transitivity.

* converted winbindd_list_trusted_domains() to enumerate the trusted domain
cache, instead of the domain list, and return additional trust information to
the calling process

* modified wbinfo to pretty print this additional trust information when a new
--verbose switch is given with -m.  Thus "wbinfo -m" and "wbinfo -all-domains"
output as before, but "wbinfo --verbose -m" prints extra trust info.

* updated some comments and fixed typos
(This used to be commit e7827bb6afa264c12ecdc0858f49707ca3d6104f)

13 years agoForest root trust flags won't overwrite child trust flags
Steven Danneman [Tue, 25 Mar 2008 23:50:58 +0000 (16:50 -0700)]
Forest root trust flags won't overwrite child trust flags

* changed the behavior of winbind_ads.c:trusted_domains() to not overwrite
existing trust information if we're joined to a child domain, and querying the
forest root domain.  Previously if we were joined to a child domain, we'd
request all known trust information from this child domain (our primary domain)
and store it in the tdc.  We'd then request all trust information from our tree
root (to get the forests we transitively trust) and overwrite the existing trust
information we already had from the perspective of the tree root.

* updated several comments and fixed typos
(This used to be commit 6aac972d790ad5ca65096cb2e85e6819b60a5413)

13 years agotest: add (and unify) sectioning output of subtests in tests_all.sh
Michael Adam [Mon, 31 Mar 2008 11:51:49 +0000 (13:51 +0200)]
test: add (and unify) sectioning output of subtests in tests_all.sh

Michael
(This used to be commit d775194e9c7b75182c485fba427b20ec2bfcf16c)

13 years agotest: add possibility to select tests to run via tests_all.sh (make test)
Michael Adam [Mon, 31 Mar 2008 11:33:12 +0000 (13:33 +0200)]
test: add possibility to select tests to run via tests_all.sh (make test)

This allows to select the tests to run with tests_all.sh by setting
the environment variable "RUNTESTS". Example:

RUNTESTS="smbclient_s3_encrypted wbinfo_s3" make test

Michael
(This used to be commit bf4af79f050cceb6611a8aa3d893b59b816a41ce)

13 years agotest: in tests_all.sh, wrap calls to test scripts into shell functions.
Michael Adam [Mon, 31 Mar 2008 11:20:08 +0000 (13:20 +0200)]
test: in tests_all.sh, wrap calls to test scripts into shell functions.

This is in preparation for enabling running only selected test scripts
through "make test".

Michael
(This used to be commit ad1fbadf81c915425301ec495744c11f3103169f)

13 years agoregistry: reg_deletevalue should return error, when the value does not exist.
Michael Adam [Mon, 31 Mar 2008 15:20:07 +0000 (17:20 +0200)]
registry: reg_deletevalue should return error, when the value does not exist.

Michael
(This used to be commit 04b48984bbf84c55bb41a74a11cbcc7358377fed)

13 years agowbinfo: use wbcAllocateGid()
Stefan Metzmacher [Fri, 28 Mar 2008 18:39:43 +0000 (19:39 +0100)]
wbinfo: use wbcAllocateGid()

metze
(This used to be commit 960c069a2354e0803e2cbf22c26e1a9d0b657b79)

13 years agowbinfo: use wbcAllocateUid()
Stefan Metzmacher [Fri, 28 Mar 2008 18:39:16 +0000 (19:39 +0100)]
wbinfo: use wbcAllocateUid()

metze
(This used to be commit a7d735df292cee7dd6e23c7d2328481d57162904)

13 years agowbinfo: use wbcSidToGid()
Stefan Metzmacher [Fri, 28 Mar 2008 18:38:24 +0000 (19:38 +0100)]
wbinfo: use wbcSidToGid()

metze
(This used to be commit 43df48bdca1a71fa44b24bb3917869f886555d9c)

13 years agowbinfo: use wbcSidToUid()
Stefan Metzmacher [Fri, 28 Mar 2008 18:37:50 +0000 (19:37 +0100)]
wbinfo: use wbcSidToUid()

metze
(This used to be commit a25b39cac1716323154dd30acb30180d3273587b)

13 years agowbinfo: use wbcGitToSid()
Stefan Metzmacher [Fri, 28 Mar 2008 18:37:02 +0000 (19:37 +0100)]
wbinfo: use wbcGitToSid()

metze
(This used to be commit 9936d861a1c1163ce6fd079211b50fd9b52bc05d)

13 years agowbinfo: use wbcUidToSid()
Stefan Metzmacher [Fri, 28 Mar 2008 18:34:10 +0000 (19:34 +0100)]
wbinfo: use wbcUidToSid()

metze
(This used to be commit 4766ebf7ac8d33f9cd0f983ecdc54ef44959648b)

13 years agowbinfo: use wbcPing()
Stefan Metzmacher [Fri, 28 Mar 2008 18:01:54 +0000 (19:01 +0100)]
wbinfo: use wbcPing()

metze
(This used to be commit 9a2f0b21925e630fa9b268cedbc19cf814686b42)

13 years agobuild: fix configure option --with-static-libs=libXYZ
Michael Adam [Mon, 31 Mar 2008 09:58:35 +0000 (11:58 +0200)]
build: fix configure option --with-static-libs=libXYZ

This should not prevent building but linking of shared lib for
subsystem XYZ (example --with-static-libs=libtdb).

m4 quotation is tricky...

Michael
(This used to be commit 4d0a5d5c93ddab444a0097e1c56e4363574cb2b6)

13 years agoRevert "regdb: use dbwrap->fetch() instead of fetch_locked() for readonly access"
Michael Adam [Sun, 30 Mar 2008 00:25:45 +0000 (01:25 +0100)]
Revert "regdb: use dbwrap->fetch() instead of fetch_locked() for readonly access"

This reverts commit 4e2be189e97f653b75bd88135a631ce0f42db267.

Metze, this broke the registry (reg_api layer), but I don't yet know
exactly how and why. By the way, the locks there had the purpose of
fetching the seqnum that really matches the data.

This needs some more thought / debugging. But I wanted to have
the tree in a working state again.

Michael
(This used to be commit 5c28c74aa06a82559f498373b3d6e9892d5c2cbe)

13 years agoFix a segfault (an uninitialized variable)
Volker Lendecke [Sat, 29 Mar 2008 11:23:26 +0000 (12:23 +0100)]
Fix a segfault (an uninitialized variable)
(This used to be commit 75eb30884a83266fd7331d8f1e3905a0245bb3d8)

13 years agowinbindd_cache: add missing validation function for pwinfo cache entry
Michael Adam [Sat, 29 Mar 2008 00:05:17 +0000 (01:05 +0100)]
winbindd_cache: add missing validation function for pwinfo cache entry

Michael
(This used to be commit 6d3fc63bfab06346fa57719e8747397873a3c46d)

13 years agoFix missing '&&'.
Jeremy Allison [Sat, 29 Mar 2008 00:32:52 +0000 (17:32 -0700)]
Fix missing '&&'.
Jeremy.
(This used to be commit 251df53811e4272b629575a4b50c29a99715ccf9)

13 years agoMerge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Sat, 29 Mar 2008 00:31:33 +0000 (17:31 -0700)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
(This used to be commit 985bd1e642b6e54f1bc95cd4cfcceb96107e383d)

13 years agoOnly allow sendfile on non-stream fsp's. Should fix make test for streams
Jeremy Allison [Sat, 29 Mar 2008 00:31:06 +0000 (17:31 -0700)]
Only allow sendfile on non-stream fsp's. Should fix make test for streams
as sendfile isn't implemented in the streams vfs modules yet.
Jeremy.
(This used to be commit eef53e9603d4f3d892ffe00b061def5d717ca481)

13 years agoZero initial return_authenticator in net rpc samdump.
Günther Deschner [Fri, 28 Mar 2008 23:49:09 +0000 (00:49 +0100)]
Zero initial return_authenticator in net rpc samdump.

Guenther
(This used to be commit 73ead752c5ec7104ea0eed7d963dc36467c81981)

13 years agoDon't let winbind getgroups crash when we have no gids in the token.
Günther Deschner [Fri, 28 Mar 2008 23:47:42 +0000 (00:47 +0100)]
Don't let winbind getgroups crash when we have no gids in the token.

Guenther
(This used to be commit 6a576cfe9b87e69af6acbe9abc04124b8b743fd3)

13 years agoRe-run make idl.
Günther Deschner [Fri, 28 Mar 2008 22:46:26 +0000 (23:46 +0100)]
Re-run make idl.

Guenther
(This used to be commit 58018ad7f65409d971e5db7165f1b32b572cc275)

13 years agoFill in netr_NegotiateFlags.
Günther Deschner [Fri, 28 Mar 2008 22:44:43 +0000 (23:44 +0100)]
Fill in netr_NegotiateFlags.

Guenther
(This used to be commit 1cd1c27a0e5aa87682820c8dd81188b7bcc6551a)

13 years agoAdd some paranoia fixes for _wkssvc_NetrJoinDomain2/UnjoinDomain2.
Günther Deschner [Fri, 28 Mar 2008 22:39:57 +0000 (23:39 +0100)]
Add some paranoia fixes for _wkssvc_NetrJoinDomain2/UnjoinDomain2.

Guenther
(This used to be commit 72101a7d0868b19a413b17f8142637f92c6cdad5)

13 years agomapping_ldb: fix memory leak in group enumeration
Stefan Metzmacher [Fri, 28 Mar 2008 14:06:56 +0000 (15:06 +0100)]
mapping_ldb: fix memory leak in group enumeration

metze
(This used to be commit 235c056a0ecbb70b21a2572d42c32067dd699988)

13 years agoFix bug #5326 - OS/2 servers give strange "high word" replies for print jobs.
Jeremy Allison [Fri, 28 Mar 2008 17:12:07 +0000 (10:12 -0700)]
Fix bug #5326 - OS/2 servers give strange "high word" replies for print jobs.
Jeremy.
(This used to be commit d090d25cb702965b3d5e4635a26a06f2b62d235d)

13 years agoSupport "net ads join" format while joining to a specific ou.
Günther Deschner [Fri, 28 Mar 2008 15:39:02 +0000 (16:39 +0100)]
Support "net ads join" format while joining to a specific ou.

libnetjoin now supports Computers/Servers/Unix as well as
ou=Computers,ou=Servers,ou=Unix,dc=ber,dc=realm,dc=com.

Guenther
(This used to be commit c0be84c96d8133c6b77d1f0efe41f5f2373febb3)

13 years agoAdd ads_check_ou_dn().
Günther Deschner [Fri, 28 Mar 2008 15:33:54 +0000 (16:33 +0100)]
Add ads_check_ou_dn().

Guenther
(This used to be commit 380e9d26db5341d10807ccbfb413d0f53d3ffc71)

13 years agoAdd a talloc context parameter to current_timestring() to fix memleaks.
Michael Adam [Fri, 28 Mar 2008 14:49:13 +0000 (15:49 +0100)]
Add a talloc context parameter to current_timestring() to fix memleaks.

current_timestring used to return a string talloced to talloc_tos().
When called by DEBUG from a TALLOC_FREE, this produced messages
"no talloc stackframe around, leaking memory". For example when
used from net conf.

This also adds a temporary talloc context to alloc_sub_basic().
For this purpose, the exit strategy is slightly altered: a common
exit point is used for success and failure.

Michael
(This used to be commit 16b5800d4e3a8b88bac67b2550d14e0aaaa302a9)

13 years agosrv_winreg: add a debug message to _winreg_CreateKey().
Michael Adam [Fri, 28 Mar 2008 14:39:52 +0000 (15:39 +0100)]
srv_winreg: add a debug message to _winreg_CreateKey().

Michael
(This used to be commit 971f6749ed23523f6eafe5136f6d4c920c20aec4)

13 years agonet: add a "net registry" subcommand to locally access the registry.
Michael Adam [Fri, 28 Mar 2008 00:21:49 +0000 (01:21 +0100)]
net: add a "net registry" subcommand to locally access the registry.

The interface is like that of net rpc registry.
Access is direct local access to the registry tdb through reg_api.

Michael
(This used to be commit 3250068eb980bd0489f814f702401cdc9c925a8d)

13 years agoMore ssize_t->SMB_OFF_T
Volker Lendecke [Fri, 28 Mar 2008 14:21:14 +0000 (15:21 +0100)]
More ssize_t->SMB_OFF_T
(This used to be commit 8dd6458049d1b9d6849730ac19c39b049a68f302)

13 years agolibreplace(samba4): let LIBREPLACE depend on LIBREPLACE_NETWORK for now
Stefan Metzmacher [Fri, 28 Mar 2008 06:56:20 +0000 (07:56 +0100)]
libreplace(samba4): let LIBREPLACE depend on LIBREPLACE_NETWORK for now

This should fix the build on solaris.
Later this needs better fixing...

metze
(cherry picked from commit 89b7955733c34e9699a3b43ee54de92cb9469b90)
(This used to be commit fcb497951a86551ce9c4be7b352335dad3be127a)

13 years agowbinfo: use wbcDomainInfo()
Stefan Metzmacher [Mon, 24 Mar 2008 20:05:30 +0000 (21:05 +0100)]
wbinfo: use wbcDomainInfo()

metze
(This used to be commit 7714f9232110b2ee50e6ba8371f0bc23b83717a6)

13 years agowbinfo: use wbcGetgrnam()
Stefan Metzmacher [Mon, 24 Mar 2008 19:44:34 +0000 (20:44 +0100)]
wbinfo: use wbcGetgrnam()

metze
(This used to be commit 8945dce4a18874bdf1a57f1ff8116a66a6f699a0)

13 years agowbinfo: use wbcListUsers() and wbcListGroups()
Stefan Metzmacher [Mon, 24 Mar 2008 19:32:14 +0000 (20:32 +0100)]
wbinfo: use wbcListUsers() and wbcListGroups()

metze
(This used to be commit 5a0ae1ad0c36e5ef97008a2c6bc2a921ca6538bd)

13 years agowbinfo: use wbcLookupUserSids()
Stefan Metzmacher [Sun, 23 Mar 2008 21:41:45 +0000 (22:41 +0100)]
wbinfo: use wbcLookupUserSids()

metze
(This used to be commit ff16b66631bc93909c0e7adf9e6bb1cf1d641ffd)

13 years agolibwbclient: remove prototype of non existing wbcDomainSequenceNumbers()
Stefan Metzmacher [Mon, 24 Mar 2008 20:07:01 +0000 (21:07 +0100)]
libwbclient: remove prototype of non existing wbcDomainSequenceNumbers()

metze
(This used to be commit 7a4de23aa318bd24948e576a5582a5c74d335154)

13 years agolibwbclient: add wbcListUsers() and wbcListGroups()
Stefan Metzmacher [Mon, 24 Mar 2008 19:31:37 +0000 (20:31 +0100)]
libwbclient: add wbcListUsers() and wbcListGroups()

metze
(This used to be commit df127f0b40d36ea8ee605c24ea88558c7d40a7fe)

13 years agolibwbclient: add wbcLookupUserSids()
Stefan Metzmacher [Fri, 21 Mar 2008 09:18:54 +0000 (10:18 +0100)]
libwbclient: add wbcLookupUserSids()

metze
(This used to be commit 38007a387a1f1b53877ef9ea518f83ecf026f4f3)

13 years agoAdd Support for DOMAIN\DCNAME syntax in libnetjoin.
Günther Deschner [Fri, 28 Mar 2008 13:13:27 +0000 (14:13 +0100)]
Add Support for DOMAIN\DCNAME syntax in libnetjoin.
This format is used by Windows to enforce joining to a specific DC.

Guenther
(This used to be commit cc654892c0d76dea001cd8f7bd6f50cf9e89e9c9)

13 years agoLet libnetjoin find the dc in wkssvc NetrJoinDomain2/UnjoinDomain2.
Günther Deschner [Fri, 28 Mar 2008 12:53:33 +0000 (13:53 +0100)]
Let libnetjoin find the dc in wkssvc NetrJoinDomain2/UnjoinDomain2.

Guenther
(This used to be commit 9e7d673ac44f500863bcbd0198452adc7c5027f9)

13 years agoCheck for buffer in decode_wkssvc_join_password_buffer.
Günther Deschner [Fri, 28 Mar 2008 12:40:13 +0000 (13:40 +0100)]
Check for buffer in decode_wkssvc_join_password_buffer.

Guenther
(This used to be commit 2134d80c05fd7a37f44317335b40d7961c429c7b)

13 years agoFix a segfault
Volker Lendecke [Fri, 28 Mar 2008 09:34:37 +0000 (10:34 +0100)]
Fix a segfault
(This used to be commit 40d1d64c6a2ae128eb3fce0e7f5351b0c5942f30)

13 years agoFix a confusing variable name
Volker Lendecke [Fri, 28 Mar 2008 11:05:54 +0000 (12:05 +0100)]
Fix a confusing variable name
(This used to be commit 32c992e9573c9af34cd142393287e2f3538d2dd9)

13 years agoFix a memory leak
Volker Lendecke [Thu, 27 Mar 2008 21:54:10 +0000 (22:54 +0100)]
Fix a memory leak
(This used to be commit ce1bd43cdae63ff05aefaded419388e7b9e3ba9a)

13 years agoMake some fns static
Volker Lendecke [Wed, 26 Mar 2008 17:39:11 +0000 (18:39 +0100)]
Make some fns static
(This used to be commit e04fc36f223d8d905a930c077a6cf6c48ee57af7)

13 years agoprintclose has only 1 vwv
Volker Lendecke [Wed, 26 Mar 2008 17:33:38 +0000 (18:33 +0100)]
printclose has only 1 vwv
(This used to be commit 99d980125054cbfef8ec85a31e83aa18a6e0bce3)

13 years agoRemove unneeded pack_dsdcinfo/unpack_dsdcinfo.
Günther Deschner [Fri, 28 Mar 2008 12:37:25 +0000 (13:37 +0100)]
Remove unneeded pack_dsdcinfo/unpack_dsdcinfo.

Guenther
(This used to be commit 34dd8f32e1b7fe256ab5dfde5ef5bb8abeec121a)

13 years agoUse NDR for netr_DsRGetDCNameInfo un-/marshalling in dsgetdcname.
Günther Deschner [Fri, 28 Mar 2008 12:36:31 +0000 (13:36 +0100)]
Use NDR for netr_DsRGetDCNameInfo un-/marshalling in dsgetdcname.

Guenther
(This used to be commit 7fa53911054a39681df3f08d19aad92f60d59e28)

13 years agoRe-run make idl.
Günther Deschner [Fri, 28 Mar 2008 12:31:40 +0000 (13:31 +0100)]
Re-run make idl.

Guenther
(This used to be commit f8835462f2b88daa687edc79378511ffcb30905d)

13 years agoMake netr_DsRGetDCNameInfo public.
Günther Deschner [Fri, 28 Mar 2008 12:30:13 +0000 (13:30 +0100)]
Make netr_DsRGetDCNameInfo public.

Guenther
(This used to be commit 62c876080c1f3afdd143d1f7f66529827b0f2990)

13 years agoFix blob used in pull_netr_AcctLockStr().
Günther Deschner [Fri, 28 Mar 2008 08:56:21 +0000 (09:56 +0100)]
Fix blob used in pull_netr_AcctLockStr().
Thanks metze.

Guenther
(This used to be commit 565a30ac3208d89de617b28f4553911484033253)

13 years agoRe-run make idl.
Günther Deschner [Fri, 28 Mar 2008 08:55:18 +0000 (09:55 +0100)]
Re-run make idl.

Guenther
(This used to be commit 3219ed785330bbfac39aa738e8fc9cb0d7165f58)

13 years agoRename string to array in lsa_BinaryString.
Günther Deschner [Fri, 28 Mar 2008 08:53:37 +0000 (09:53 +0100)]
Rename string to array in lsa_BinaryString.

Guenther
(This used to be commit a4ffaff2e177a09b4f44a30f322dd9668ccbd380)

13 years agoMerge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Thu, 27 Mar 2008 23:48:44 +0000 (16:48 -0700)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
(This used to be commit 64d4f290cf0aad962a0a3356473632a58e0e34df)

13 years agoFix up the comments on security=share to explain we're
Jeremy Allison [Thu, 27 Mar 2008 23:08:39 +0000 (16:08 -0700)]
Fix up the comments on security=share to explain we're
ignoring passwords.
Jeremy.
(This used to be commit e7b6ea46532a26611dfd9d9e2727d52ba6a9cf50)

13 years agoMake sure to zero the returned handle in _svcctl_CloseServiceHandle().
Günther Deschner [Thu, 27 Mar 2008 21:55:20 +0000 (22:55 +0100)]
Make sure to zero the returned handle in _svcctl_CloseServiceHandle().

Guenther
(This used to be commit 84a079af490cb135dd557091932ea079e1d7ff5b)

13 years agoFix for termination problems when no interfaces found - bug #5267.
Jeremy Allison [Thu, 27 Mar 2008 21:23:20 +0000 (14:23 -0700)]
Fix for termination problems when no interfaces found - bug #5267.
Jeremy.
(This used to be commit 4b03f4eb2da7a523967ace3d13e79406ade07d47)

13 years agoRemove last reference to rpc_netlogon.h.
Günther Deschner [Thu, 27 Mar 2008 21:18:04 +0000 (22:18 +0100)]
Remove last reference to rpc_netlogon.h.

Guenther
(This used to be commit 085887eed71ed1ffdb30100d83763e671ea10eee)

13 years agoRemove unused marshalling for Netlogon Lockout String.
Günther Deschner [Thu, 27 Mar 2008 20:58:11 +0000 (21:58 +0100)]
Remove unused marshalling for Netlogon Lockout String.

Guenther
(This used to be commit d87133d0516294e7d5f123e3bb2e93c179c72677)

13 years agoRe-add support for display and vampire of account policies in "net".
Günther Deschner [Thu, 27 Mar 2008 20:55:42 +0000 (21:55 +0100)]
Re-add support for display and vampire of account policies in "net".

Guenther
(This used to be commit c61499ce02355f5969fa0475ed6e3c278995ecdb)

13 years agoMinor fix for net rpc samdump.
Günther Deschner [Thu, 27 Mar 2008 20:04:31 +0000 (21:04 +0100)]
Minor fix for net rpc samdump.

Guenther
(This used to be commit 2f5e25be276135e9cb4cc0c44ec573d466def66e)

13 years agore-run make idl.
Günther Deschner [Thu, 27 Mar 2008 17:48:28 +0000 (18:48 +0100)]
re-run make idl.

Guenther
(This used to be commit e048780163f95fb7c2d337606794e1aa3c8b4b79)

13 years agoFill in netr_AcctLockStr and use lsa_BinaryString in netlogon delta.
Günther Deschner [Thu, 27 Mar 2008 17:43:58 +0000 (18:43 +0100)]
Fill in netr_AcctLockStr and use lsa_BinaryString in netlogon delta.

Guenther
(This used to be commit f98e7909238bd253436076377a7e6b8fb1cb49a9)

13 years agoAdd lsa_BinaryString.
Günther Deschner [Thu, 27 Mar 2008 17:40:17 +0000 (18:40 +0100)]
Add lsa_BinaryString.

Guenther
(This used to be commit c73ff43e8f68600d6bd67c875d40bec2ec02b6dd)

13 years agoregdb: use == 0 (instead of != -1) as indicator for success of dbwrap_trans_[delete...
Michael Adam [Thu, 27 Mar 2008 17:01:43 +0000 (18:01 +0100)]
regdb: use == 0 (instead of != -1) as indicator for success of dbwrap_trans_[delete|store]()

Michael
(This used to be commit 7dcd0c1e539df9ff1768a9c878b6687b9e1bfeac)

13 years agodbwrap: fix dbwrap_trans_[delete|store]() to stop when transaction_start() failed.
Michael Adam [Thu, 27 Mar 2008 17:00:25 +0000 (18:00 +0100)]
dbwrap: fix dbwrap_trans_[delete|store]() to stop when transaction_start() failed.

Michael
(This used to be commit ab0aaed907fef233998ff0841d30eabef3263ee8)

13 years agoregdb: use != 0 instead of == -1 check for transaction_[commit|cancel]
Michael Adam [Thu, 27 Mar 2008 16:44:36 +0000 (17:44 +0100)]
regdb: use != 0 instead of == -1 check for transaction_[commit|cancel]

Michael
(This used to be commit b6ceeaabae94b86fe79d6a60e497fb472ca23021)

13 years agopdb_tdb: use db_open_trans()
Stefan Metzmacher [Thu, 27 Mar 2008 15:57:10 +0000 (16:57 +0100)]
pdb_tdb: use db_open_trans()

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit 9925cc01a2a4739d6cde5991eb0d0b79ae13353b)

13 years agopdb_tdb: use db_sam->transaction_start(db_sam) != 0 consistent
Stefan Metzmacher [Thu, 27 Mar 2008 15:55:35 +0000 (16:55 +0100)]
pdb_tdb: use db_sam->transaction_start(db_sam) != 0 consistent

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit 3bf9ab640e9a79157fcfee0b5d0cde5badc92755)

13 years agopassdb/secrets: use db_open_trans()
Stefan Metzmacher [Thu, 27 Mar 2008 15:57:30 +0000 (16:57 +0100)]
passdb/secrets: use db_open_trans()

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit b61b8ca4944f399216d8e67a48ea7d259258b432)

13 years agopassdb/secrets: it's enough to use traverse_read() in secrets_trusted_domains()
Stefan Metzmacher [Thu, 20 Mar 2008 13:26:46 +0000 (14:26 +0100)]
passdb/secrets: it's enough to use traverse_read() in secrets_trusted_domains()

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit 729f7b9ff30e81537a7257daeaa1728c7ae96853)

13 years agoregdb: use db_open_trans()
Stefan Metzmacher [Thu, 27 Mar 2008 15:57:51 +0000 (16:57 +0100)]
regdb: use db_open_trans()

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit a77b5b91dd439b5965fef17f2b2ff98fefd77dbb)

13 years agoregdb: use regdb->transaction_start(regdb) != 0 consistent
Stefan Metzmacher [Thu, 27 Mar 2008 15:56:38 +0000 (16:56 +0100)]
regdb: use regdb->transaction_start(regdb) != 0 consistent

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit 093c3bced96c934419af69cc065a240368027dcf)

13 years agoregdb: use dbwrap->fetch() instead of fetch_locked() for readonly access
Stefan Metzmacher [Wed, 26 Mar 2008 20:24:17 +0000 (21:24 +0100)]
regdb: use dbwrap->fetch() instead of fetch_locked() for readonly access

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit 4e2be189e97f653b75bd88135a631ce0f42db267)

13 years agoregdb: use dbwrap_trans_store_int32
Stefan Metzmacher [Wed, 26 Mar 2008 20:25:06 +0000 (21:25 +0100)]
regdb: use dbwrap_trans_store_int32

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit 9620696083473e3a98b46dd90b3b4aa287580940)

13 years agodbwrap: add db_open_trans()
Stefan Metzmacher [Thu, 27 Mar 2008 15:08:21 +0000 (16:08 +0100)]
dbwrap: add db_open_trans()

This should be used when transactions are wanted.
For now it's just a wrapper of db_open(), but this
will change.

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit 74a070b8a24fea1009e557f711b76fc14e8961dc)

13 years agodbwrap: add dbwrap_trans_store_int32()
Stefan Metzmacher [Thu, 27 Mar 2008 14:59:58 +0000 (15:59 +0100)]
dbwrap: add dbwrap_trans_store_int32()

metze

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(This used to be commit f05e889bc05a816aef5b9ce4f22267e977dade01)

13 years agoFix typo.
Günther Deschner [Thu, 27 Mar 2008 17:05:02 +0000 (18:05 +0100)]
Fix typo.

Guenther
(This used to be commit fed644372916a5e565e4f5352aab61b39a3a42a0)

13 years agoNdr pull and push errors are worth to be logged with 1 at least.
Günther Deschner [Thu, 27 Mar 2008 15:44:37 +0000 (16:44 +0100)]
Ndr pull and push errors are worth to be logged with 1 at least.

Guenther
(This used to be commit 3426f13f3bbcb5cae3f2e6aac9e2d04174e5bdc0)

13 years agoOnly add WBFLAG_PAM_CONTACT_TRUSTDOM when performing a krb5 auth request.
Gerald W. Carter [Thu, 27 Mar 2008 16:57:26 +0000 (11:57 -0500)]
Only add WBFLAG_PAM_CONTACT_TRUSTDOM when performing a krb5 auth request.

NTLM logons must go against our DC.
(This used to be commit 2e24f7c0243c67a00102c11258cfa6f61caf499f)

13 years agoDon't fill password policy structure for any domain other than our own.
Gerald W. Carter [Thu, 27 Mar 2008 16:56:29 +0000 (11:56 -0500)]
Don't fill password policy structure for any domain other than our own.

The samr connects will fail.  This is not independent of the CONTACT_TRUSTDOM
flag neede by krb5 logins.
(This used to be commit 4de4949e3bfcfb2169c329f19cb76936d9043d50)

13 years agoFix wbinfo -a trusted\\user%password on a Samba DC with trusts
Volker Lendecke [Thu, 27 Mar 2008 12:00:23 +0000 (13:00 +0100)]
Fix wbinfo -a trusted\\user%password on a Samba DC with trusts

Winbind can't be allowed to connect to the local smbd.
(This used to be commit 0d617f639a3c9c52e4327aed4bd02d9e8e7312a2)

13 years agoRemove unused DS_DOMAIN_CONTROLLER_INFO struct.
Günther Deschner [Thu, 27 Mar 2008 11:05:01 +0000 (12:05 +0100)]
Remove unused DS_DOMAIN_CONTROLLER_INFO struct.

Guenther
(This used to be commit 7eb4f6f6f9f27cda3d512f4042e36d70d0b26b6b)

13 years agoFix samlogon rpc client & server.
Günther Deschner [Thu, 27 Mar 2008 12:03:12 +0000 (13:03 +0100)]
Fix samlogon rpc client & server.

Guenther
(This used to be commit 0aaf975560dce3b4e58ab71687c3412c0c2a72cf)

13 years agoRe-run make idl.
Günther Deschner [Thu, 27 Mar 2008 11:57:03 +0000 (12:57 +0100)]
Re-run make idl.

Guenther
(This used to be commit 3f5fa596632077b0ffed1046d0a2fb6a011b16ea)

13 years agoMove netr_LogonLevel flags to IDL, rename old one to netr_LogonInfo.
Günther Deschner [Thu, 27 Mar 2008 11:03:20 +0000 (12:03 +0100)]
Move netr_LogonLevel flags to IDL, rename old one to netr_LogonInfo.

Guenther
(This used to be commit 1fc98ee431d3ebe0c5d8bed55dcb788c16228ddd)

13 years agoMove DSGETDC_VALID_FLAGS to IDL.
Günther Deschner [Thu, 27 Mar 2008 11:04:22 +0000 (12:04 +0100)]
Move DSGETDC_VALID_FLAGS to IDL.

Guenther
(This used to be commit a14b00ee19c6dc23ff687e57e8e6340702056317)

13 years agoMove LOGON_KRB5_FAIL_CLOCK_SKEW to winbindd_pam.
Günther Deschner [Thu, 27 Mar 2008 11:02:18 +0000 (12:02 +0100)]
Move LOGON_KRB5_FAIL_CLOCK_SKEW to winbindd_pam.

Guenther
(This used to be commit fa64c76ac8e54f385f277b5b39be70075b2eeee0)

13 years agoMove the known NETLOGON_CONTROL reply flags to IDL.
Günther Deschner [Thu, 27 Mar 2008 11:01:13 +0000 (12:01 +0100)]
Move the known NETLOGON_CONTROL reply flags to IDL.

Guenther
(This used to be commit 4bf2a17c2b9abff45afd50ea93b96b2a080d9168)

13 years agoMove inline comment about MSV1_0 flags to IDL.
Günther Deschner [Thu, 27 Mar 2008 10:58:19 +0000 (11:58 +0100)]
Move inline comment about MSV1_0 flags to IDL.

Guenther
(This used to be commit b22167fb608d3948f1473a5f3dee9e8d18e282e3)

13 years agolibwbclient: fix Coverity ID 536 remove duplicate error path (dead code).
Michael Adam [Thu, 27 Mar 2008 10:51:31 +0000 (11:51 +0100)]
libwbclient: fix Coverity ID 536 remove duplicate error path (dead code).

I leave the more explicit error path in the "if (cmd == 0)" block.

Michael
(This used to be commit 2ae19b5fb89e0a992962af14a81b641bf13b7892)

13 years agolibreplace: fix coverity ID 517 - untangle close from open in test/os2_delete.c
Michael Adam [Thu, 27 Mar 2008 10:26:33 +0000 (11:26 +0100)]
libreplace: fix coverity ID 517 - untangle close from open in test/os2_delete.c

This is not a proper bug but the code is clearer now
and we are tracking failure of open separate from that of close.

Michael
(This used to be commit 451fc9ae05f841883081a334e179cf31625a772c)

13 years agoRe-run make idl.
Günther Deschner [Thu, 27 Mar 2008 10:04:01 +0000 (11:04 +0100)]
Re-run make idl.

Guenther
(This used to be commit e16ca32b8e0485ceafee6a2ff62dc88e96329ec4)

13 years agoUse netr_LogonControlCode in netr_LogonControl2().
Günther Deschner [Thu, 27 Mar 2008 10:01:55 +0000 (11:01 +0100)]
Use netr_LogonControlCode in netr_LogonControl2().

Guenther
(This used to be commit 8474ef334fd0ff05ee67a49ad7c39687117b49d9)

13 years agoposix_acls: clarify loop condition code, removing unneeded counter variable.
Michael Adam [Thu, 27 Mar 2008 09:09:24 +0000 (10:09 +0100)]
posix_acls: clarify loop condition code, removing unneeded counter variable.

Coverity ID 545 falsely classified this as a NULL dereferencing bug.
By putting the loop of walking the list of aces more naturely not using
additional counters, it becomes much more obvious that it is not entered
when dir_ace == NULL.

The same modifications are done for the file_ace loop.

Michael
(This used to be commit 6dab6cf0647d7db01e5e472f8b5cf21395b7dbf0)