ira/wip.git
10 years agos3: Remove some unnecessary variables from libsmb/conn_cache.c
Volker Lendecke [Thu, 24 Dec 2009 12:47:35 +0000 (13:47 +0100)]
s3: Remove some unnecessary variables from libsmb/conn_cache.c

10 years agos3: Fix a comment in conn_cache.c
Volker Lendecke [Thu, 24 Dec 2009 12:46:16 +0000 (13:46 +0100)]
s3: Fix a comment in conn_cache.c

10 years agos3: Fix a 64-bit error
Volker Lendecke [Thu, 24 Dec 2009 12:40:24 +0000 (13:40 +0100)]
s3: Fix a 64-bit error

10 years agos3: Remove some pointless SMB_ASSERTs
Volker Lendecke [Thu, 24 Dec 2009 12:36:00 +0000 (13:36 +0100)]
s3: Remove some pointless SMB_ASSERTs

10 years agos3: Remove some pointless casts
Volker Lendecke [Thu, 24 Dec 2009 12:14:18 +0000 (13:14 +0100)]
s3: Remove some pointless casts

10 years agoAttempt to fix one of the last two bugs with the full Windows ACL support.
Jeremy Allison [Thu, 24 Dec 2009 01:19:22 +0000 (17:19 -0800)]
Attempt to fix one of the last two bugs with the full Windows ACL support.

When returning an underlying ACL on a directory, normally on a
POSIX system it has no inheritable entries, which breaks the
Windows ACL when a user does a get/set of a Windows ACL on a
POSIX directory with no existing stored Windows ACL from
the Windows ACL editor. What happens is any new entry added
by the user gets set inheritable, but none of the others
entries are (as returned by default). So any new files then
only inherit the single new ACE entry (the one marked inheritable
by the ACL editor).

Fix this by faking up a default 3 element inheritable ACL that
represents what a user creating a POSIX file or directory will
get by default from the smbd code.

Jeremy.

10 years agoThe posix acl version of set_nt_acl() could set the stat_ex
Jeremy Allison [Thu, 24 Dec 2009 01:17:48 +0000 (17:17 -0800)]
The posix acl version of set_nt_acl() could set the stat_ex
struct in the fsp->fsp_name pointer incorrectly for a directory.

Fix this. Make map_canon_ace_perms() public.

Jeremy.

10 years agos4:cleanups More trailing spaces and tabs
Simo Sorce [Wed, 23 Dec 2009 20:17:16 +0000 (15:17 -0500)]
s4:cleanups More trailing spaces and tabs

10 years agos4:cleanups remove trailing spaces and tabs
Simo Sorce [Wed, 23 Dec 2009 20:08:02 +0000 (15:08 -0500)]
s4:cleanups remove trailing spaces and tabs

10 years agodoc: update mount.cifs man page with nounix option
Suresh Jayaraman [Wed, 23 Dec 2009 16:41:39 +0000 (11:41 -0500)]
doc: update mount.cifs man page with nounix option

Change since last post:
- fix build error due to superfluous </para> tag.
- ensure it builds fine.

Also add a section on INODE NUMBERS that discusses inode numbers more
thoroughly and add reference to it in "nounix" and "noserverino"
options.

Thanks to Jeff Layton for explaining those details.

Signed-off-by: Suresh Jayaraman <sjayaraman@suse.de>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
10 years agos4:ldb Fix declaration in the middle of the code
Simo Sorce [Wed, 23 Dec 2009 15:33:26 +0000 (10:33 -0500)]
s4:ldb Fix declaration in the middle of the code

10 years agos4: Fix the build
Simo Sorce [Wed, 23 Dec 2009 15:28:14 +0000 (10:28 -0500)]
s4: Fix the build

10 years agos4: tests controls parsing and using for ldbadd/ldbedit/ldbmodify
Matthieu Patou [Sat, 5 Dec 2009 14:56:35 +0000 (17:56 +0300)]
s4: tests controls parsing and using for ldbadd/ldbedit/ldbmodify

10 years agos4: make ldbadd/ldbmodify/ldbdelete really use the --controls switch
Matthieu Patou [Tue, 22 Dec 2009 17:44:19 +0000 (20:44 +0300)]
s4: make ldbadd/ldbmodify/ldbdelete really use the --controls switch

10 years agos3: wbinfo --ping-dc is not cacheable
Volker Lendecke [Wed, 23 Dec 2009 12:10:55 +0000 (13:10 +0100)]
s3: wbinfo --ping-dc is not cacheable

10 years agos3: Remove some unused code
Volker Lendecke [Wed, 23 Dec 2009 10:48:33 +0000 (11:48 +0100)]
s3: Remove some unused code

10 years agos3: Remove unused sendto_child()
Volker Lendecke [Wed, 23 Dec 2009 10:39:10 +0000 (11:39 +0100)]
s3: Remove unused sendto_child()

10 years agos3-net: use generated krb5.conf in 'net ads testjoin'
Günther Deschner [Wed, 16 Dec 2009 20:22:50 +0000 (21:22 +0100)]
s3-net: use generated krb5.conf in 'net ads testjoin'

Guenther

10 years agos3-docs: mention -M option and remove nonexisting -G option in pdbedit manpage.
Günther Deschner [Wed, 23 Dec 2009 09:33:13 +0000 (10:33 +0100)]
s3-docs: mention -M option and remove nonexisting -G option in pdbedit manpage.

Guenther

10 years agos3:ntlmssp: only include ntlmssp.h where actually needed
Andrew Bartlett [Tue, 22 Dec 2009 07:50:55 +0000 (18:50 +1100)]
s3:ntlmssp: only include ntlmssp.h where actually needed

Andrew Bartlett

10 years agos3:ntlmssp: remove the typedef NTLMSSP_STATE
Andrew Bartlett [Tue, 22 Dec 2009 07:50:55 +0000 (18:50 +1100)]
s3:ntlmssp: remove the typedef NTLMSSP_STATE

Andrew Bartlett

10 years agos3:ntlmssp: move to C99 integer types in ntlmssp.h
Andrew Bartlett [Tue, 22 Dec 2009 07:50:55 +0000 (18:50 +1100)]
s3:ntlmssp: move to C99 integer types in ntlmssp.h

Andrew Bartlett

10 years agos3:ntlmssp: rename enum NTLMSSP_ROLE into enum ntlmssp_role
Andrew Bartlett [Tue, 22 Dec 2009 07:50:55 +0000 (18:50 +1100)]
s3:ntlmssp: rename enum NTLMSSP_ROLE into enum ntlmssp_role

Andrew Bartlett

10 years agolibcli/auth Make gd's NDR NTLMSSP parsers helpers common
Andrew Bartlett [Tue, 22 Dec 2009 07:20:02 +0000 (18:20 +1100)]
libcli/auth Make gd's NDR NTLMSSP parsers helpers common

(but not built in Samba4 for now)

10 years agos3: Restore correct timeouts for SMB requests
Volker Lendecke [Tue, 22 Dec 2009 15:06:17 +0000 (16:06 +0100)]
s3: Restore correct timeouts for SMB requests

10 years agos3: Remove a pointless else branch
Volker Lendecke [Tue, 22 Dec 2009 13:07:52 +0000 (14:07 +0100)]
s3: Remove a pointless else branch

10 years agos3: Move smb_splice_chain to smbd/process.c, its only user
Volker Lendecke [Tue, 22 Dec 2009 12:53:13 +0000 (13:53 +0100)]
s3: Move smb_splice_chain to smbd/process.c, its only user

10 years agos4:gensec Don't give a warning when Windows client connects with NTLM
Andrew Bartlett [Tue, 8 Dec 2009 05:50:18 +0000 (16:50 +1100)]
s4:gensec Don't give a warning when Windows client connects with NTLM

We have had the workaround for a long time, but at the time the log
warnings remained.

Andrew Bartlett

10 years agos4:auth Change 'get_challenge' API to be more like Samba3
Andrew Bartlett [Mon, 14 Dec 2009 09:32:47 +0000 (20:32 +1100)]
s4:auth Change 'get_challenge' API to be more like Samba3

It is just easier to fill in the known to be 8 byte challenge than
stuff about with allocated pointers.

Andrew Bartlett

10 years agos4:auth generate the prototype file in the right place
Andrew Bartlett [Tue, 22 Dec 2009 06:21:06 +0000 (17:21 +1100)]
s4:auth generate the prototype file in the right place

10 years agoSamba4 and LDB requires talloc 2.0.1
Andrew Bartlett [Fri, 18 Dec 2009 04:30:41 +0000 (15:30 +1100)]
Samba4 and LDB requires talloc 2.0.1

reported by ewoud@kohlvanwijngaarden.nl

10 years agoFix bug reported in mangle_hash code (no bugid yet).
Jeremy Allison [Tue, 22 Dec 2009 01:46:32 +0000 (17:46 -0800)]
Fix bug reported in mangle_hash code (no bugid yet).

Don't change the contents of a const string via a pointer
alias (or if you do, change it back.....).

Jeremy.

10 years agos4 torture: Add RAW-OPLOCK-EXCLUSIVE7 which is similar to BATCH19
Tim Prouty [Wed, 2 Dec 2009 19:39:50 +0000 (11:39 -0800)]
s4 torture: Add RAW-OPLOCK-EXCLUSIVE7 which is similar to BATCH19

10 years agos4 torture: Update raw oplock to use win7 as the baseline for rename oplock break...
Tim Prouty [Wed, 2 Dec 2009 01:40:30 +0000 (17:40 -0800)]
s4 torture: Update raw oplock to use win7 as the baseline for rename oplock break behavior

10 years agos4 torture: Be more permissive with share modes for oplock testing
Tim Prouty [Mon, 21 Dec 2009 22:48:43 +0000 (14:48 -0800)]
s4 torture: Be more permissive with share modes for oplock testing

Share modes are tested elsewhere, and there is currently an outstanding
issue about share mode contention for nt-passthrough levels:

http://lists.samba.org/archive/cifs-protocol/2009-December/001227.html

10 years agos4 torture: Do a better job of closing open files in RAW-OPLOCK.
Tim Prouty [Mon, 21 Dec 2009 22:38:45 +0000 (14:38 -0800)]
s4 torture: Do a better job of closing open files in RAW-OPLOCK.

10 years agoparam: Fix build on systems without ldb installed.
Jelmer Vernooij [Tue, 22 Dec 2009 00:24:58 +0000 (01:24 +0100)]
param: Fix build on systems without ldb installed.

10 years agoprovision/pyldb: Avoid linking in static python ldb module.
Jelmer Vernooij [Sun, 20 Dec 2009 17:31:27 +0000 (18:31 +0100)]
provision/pyldb: Avoid linking in static python ldb module.

10 years agoldb_wrap: Fix compilation when using system ldb.
Jelmer Vernooij [Sun, 20 Dec 2009 17:05:38 +0000 (18:05 +0100)]
ldb_wrap: Fix compilation when using system ldb.

10 years agotdb: Also build and install tdb manpages from standalone tdb.
Jelmer Vernooij [Sun, 20 Dec 2009 17:01:24 +0000 (18:01 +0100)]
tdb: Also build and install tdb manpages from standalone tdb.

10 years agotdb: Fix formatting of API check file.
Jelmer Vernooij [Sun, 20 Dec 2009 16:51:07 +0000 (17:51 +0100)]
tdb: Fix formatting of API check file.

10 years agoFix initialisation of TypeObject samba.param.LoadparmService.
Jelmer Vernooij [Sun, 20 Dec 2009 16:49:48 +0000 (17:49 +0100)]
Fix initialisation of TypeObject samba.param.LoadparmService.

Found by Ricardo Jorge <rvelhote@gmail.com>.

10 years agos3:winbind: Add a lower-cost alternative to wbinfo -t: wbinfo --ping-dc
Volker Lendecke [Mon, 21 Dec 2009 20:50:43 +0000 (21:50 +0100)]
s3:winbind: Add a lower-cost alternative to wbinfo -t: wbinfo --ping-dc

This just does a NULL RPC call through an existing NETLOGON connection. If
someone knows an operation that "just works" and does not return NOT_SUPPORTED,
please tell me :-)

10 years agos3:winbindd: Fix a brown paper bag bug in wbinfo -t ...
Volker Lendecke [Mon, 21 Dec 2009 21:34:55 +0000 (22:34 +0100)]
s3:winbindd: Fix a brown paper bag bug in wbinfo -t ...

10 years agoRename reply_doserror() -> reply_force_doserror().
Jeremy Allison [Mon, 21 Dec 2009 19:16:38 +0000 (11:16 -0800)]
Rename reply_doserror() -> reply_force_doserror().

Rewrite all calls to reply_nterror(NT_STATUS_DOS()) to
reply_force_doserror() and update the comment in smbd/error.c

Jeremy.

10 years agoRemove all calls to reply_doserror - turn them into
Jeremy Allison [Mon, 21 Dec 2009 19:05:25 +0000 (11:05 -0800)]
Remove all calls to reply_doserror - turn them into
correct reply_nterror calls. Next rename reply_doserror ->
reply_force_doserror and plumb in when NT_STATUS_DOS is
used.
Jeremy.

10 years agoRename 282 -> ERReasnotsupported.
Jeremy Allison [Mon, 21 Dec 2009 19:05:11 +0000 (11:05 -0800)]
Rename 282 -> ERReasnotsupported.
Jeremy.

10 years agos3-docs: mention long and undocumented option names in rpcclient manpage.
Günther Deschner [Mon, 21 Dec 2009 16:30:07 +0000 (17:30 +0100)]
s3-docs: mention long and undocumented option names in rpcclient manpage.

Guenther

10 years agos3-docs: mention long and undocumented option names in smbcacls manpage.
Günther Deschner [Mon, 21 Dec 2009 16:18:53 +0000 (17:18 +0100)]
s3-docs: mention long and undocumented option names in smbcacls manpage.

Guenther

10 years agos3-docs: mention long and undocumented option names in smbclient manpage.
Günther Deschner [Mon, 21 Dec 2009 15:24:31 +0000 (16:24 +0100)]
s3-docs: mention long and undocumented option names in smbclient manpage.

Guenther

10 years agos3-docs: mention -O, --stdout in smbget manpage.
Günther Deschner [Mon, 21 Dec 2009 15:07:42 +0000 (16:07 +0100)]
s3-docs: mention -O, --stdout in smbget manpage.

Guenther

10 years agos3-docs: mention long option names in smbtree manpage.
Günther Deschner [Mon, 21 Dec 2009 15:04:49 +0000 (16:04 +0100)]
s3-docs: mention long option names in smbtree manpage.

Guenther

10 years agos3-docs: mention long and undocumented option names in pdbedit manpage.
Günther Deschner [Thu, 17 Dec 2009 14:51:36 +0000 (15:51 +0100)]
s3-docs: mention long and undocumented option names in pdbedit manpage.

Guenther

10 years agos3-docs: mention all long option names in samba.entities file.
Günther Deschner [Mon, 21 Dec 2009 15:04:06 +0000 (16:04 +0100)]
s3-docs: mention all long option names in samba.entities file.

Guenther

10 years agos3-docs: not working for SuSE anymore...
Günther Deschner [Mon, 21 Dec 2009 14:41:13 +0000 (15:41 +0100)]
s3-docs: not working for SuSE anymore...

Guenther

10 years agos3: Shrink winbindd_proto.h a bit
Volker Lendecke [Mon, 21 Dec 2009 14:27:39 +0000 (15:27 +0100)]
s3: Shrink winbindd_proto.h a bit

10 years agos3: Fix some nonempty blank lines
Volker Lendecke [Mon, 21 Dec 2009 14:11:55 +0000 (15:11 +0100)]
s3: Fix some nonempty blank lines

10 years agos3: Remove unused get_sam_group_entries
Volker Lendecke [Mon, 21 Dec 2009 14:02:56 +0000 (15:02 +0100)]
s3: Remove unused get_sam_group_entries

10 years agos3: Remove unused winbindd_dual_getsidaliases
Volker Lendecke [Mon, 21 Dec 2009 14:01:44 +0000 (15:01 +0100)]
s3: Remove unused winbindd_dual_getsidaliases

10 years agos3: Remove an unused struct definition
Volker Lendecke [Mon, 21 Dec 2009 13:59:11 +0000 (14:59 +0100)]
s3: Remove an unused struct definition

10 years agos3: Remove unused winbindd_dual_getuserdomgroups
Volker Lendecke [Mon, 21 Dec 2009 13:58:21 +0000 (14:58 +0100)]
s3: Remove unused winbindd_dual_getuserdomgroups

10 years agos3: Remove unused winbindd_dual_getdcname
Volker Lendecke [Mon, 21 Dec 2009 13:57:03 +0000 (14:57 +0100)]
s3: Remove unused winbindd_dual_getdcname

10 years agos3: Remove unused winbindd_dual_lookupname
Volker Lendecke [Mon, 21 Dec 2009 13:55:02 +0000 (14:55 +0100)]
s3: Remove unused winbindd_dual_lookupname

10 years agos3: Remove unused winbindd_dual_lookupsid
Volker Lendecke [Mon, 21 Dec 2009 13:54:15 +0000 (14:54 +0100)]
s3: Remove unused winbindd_dual_lookupsid

10 years agos3: Remove unused winbindd_dual_userinfo
Volker Lendecke [Mon, 21 Dec 2009 13:49:48 +0000 (14:49 +0100)]
s3: Remove unused winbindd_dual_userinfo

10 years agos3: Remove some unused dual functions
Volker Lendecke [Mon, 21 Dec 2009 13:47:57 +0000 (14:47 +0100)]
s3: Remove some unused dual functions

10 years agos3: Remove unused do_async
Volker Lendecke [Mon, 21 Dec 2009 13:42:18 +0000 (14:42 +0100)]
s3: Remove unused do_async

10 years agos3: Remove unused winbindd_gid2sid_async
Volker Lendecke [Mon, 21 Dec 2009 13:40:09 +0000 (14:40 +0100)]
s3: Remove unused winbindd_gid2sid_async

10 years agos3: Remove unused winbindd_uid2sid_async
Volker Lendecke [Mon, 21 Dec 2009 13:39:36 +0000 (14:39 +0100)]
s3: Remove unused winbindd_uid2sid_async

10 years agos3: Remove unused winbindd_sid2gid_async
Volker Lendecke [Mon, 21 Dec 2009 13:38:31 +0000 (14:38 +0100)]
s3: Remove unused winbindd_sid2gid_async

10 years agos3: Remove unused winbindd_sid2uid_async
Volker Lendecke [Mon, 21 Dec 2009 13:37:54 +0000 (14:37 +0100)]
s3: Remove unused winbindd_sid2uid_async

10 years agos3: Remove unused do_async_domain
Volker Lendecke [Mon, 21 Dec 2009 13:36:24 +0000 (14:36 +0100)]
s3: Remove unused do_async_domain

10 years agos3: Remove unused query_user_async
Volker Lendecke [Mon, 21 Dec 2009 13:34:15 +0000 (14:34 +0100)]
s3: Remove unused query_user_async

10 years agos3: Remove unused winbindd_getsidaliases_async
Volker Lendecke [Mon, 21 Dec 2009 13:33:26 +0000 (14:33 +0100)]
s3: Remove unused winbindd_getsidaliases_async

10 years agos3: Remove unused winbindd_lookupname_async
Volker Lendecke [Mon, 21 Dec 2009 13:32:34 +0000 (14:32 +0100)]
s3: Remove unused winbindd_lookupname_async

10 years agos3: Remove unused winbindd_lookupsid_async
Volker Lendecke [Mon, 21 Dec 2009 13:31:31 +0000 (14:31 +0100)]
s3: Remove unused winbindd_lookupsid_async

10 years agos4-schema: fixed the sorting of schema attributes
Andrew Tridgell [Mon, 21 Dec 2009 12:36:23 +0000 (23:36 +1100)]
s4-schema: fixed the sorting of schema attributes

another case of unsigned int subtracting breaking sorts. This one
surfaced now as attributeID_id now can be larger than 2^31

10 years agos4-torture: update uuid_compare test for new behaviour
Andrew Tridgell [Mon, 21 Dec 2009 12:19:08 +0000 (23:19 +1100)]
s4-torture: update uuid_compare test for new behaviour

10 years agos4-drs: Implement constraints on ATTID values in prefixMap
Kamen Mazdrashki [Fri, 18 Dec 2009 23:49:31 +0000 (01:49 +0200)]
s4-drs: Implement constraints on ATTID values in prefixMap

Ref: MS-ADTS, 3.1.1.2.6 ATTRTYP

Signed-off-by: Andrew Tridgell <tridge@samba.org>
10 years agos4-tort: Test handling of different ATTID values in prefixMap interface.
Kamen Mazdrashki [Fri, 18 Dec 2009 23:48:41 +0000 (01:48 +0200)]
s4-tort: Test handling of different ATTID values in prefixMap interface.

It turns out ATTID values are separated in ranges.
Ref: MS-ADTS, 3.1.1.2.6 ATTRTYP

Signed-off-by: Andrew Tridgell <tridge@samba.org>
10 years agoAdapted acl module to skip checks if as_system control is provided.
Nadezhda Ivanova [Fri, 18 Dec 2009 16:00:15 +0000 (18:00 +0200)]
Adapted acl module to skip checks if as_system control is provided.

Signed-off-by: Andrew Tridgell <tridge@samba.org>
10 years agos4-drs: Save prefix map using LDB_CONTROL_AS_SYSTEM control
Kamen Mazdrashki [Fri, 18 Dec 2009 16:15:49 +0000 (18:15 +0200)]
s4-drs: Save prefix map using LDB_CONTROL_AS_SYSTEM control

Signed-off-by: Andrew Tridgell <tridge@samba.org>
10 years agos4-dsdb-util: Execute ldb_request using LDB_CONTROL_AS_SYSTEM
Kamen Mazdrashki [Fri, 18 Dec 2009 16:14:38 +0000 (18:14 +0200)]
s4-dsdb-util: Execute ldb_request using LDB_CONTROL_AS_SYSTEM

This function is intended to be used when data needs
to be modified skipping access checks.

Signed-off-by: Andrew Tridgell <tridge@samba.org>
10 years agos4-dsdb-util: Utility function to process ldb_request in transaction
Kamen Mazdrashki [Fri, 18 Dec 2009 16:11:48 +0000 (18:11 +0200)]
s4-dsdb-util: Utility function to process ldb_request in transaction

This function is to be used later for manually crafted
ldb_requests from within dsdb layer

Signed-off-by: Andrew Tridgell <tridge@samba.org>
10 years agos4-schema: Implement msDS-IntId attribute generation
Kamen Mazdrashki [Fri, 18 Dec 2009 01:46:39 +0000 (03:46 +0200)]
s4-schema: Implement msDS-IntId attribute generation

Signed-off-by: Andrew Tridgell <tridge@samba.org>
10 years agos4-schema: Constraints on msDS-IntId attribute
Kamen Mazdrashki [Thu, 17 Dec 2009 21:26:47 +0000 (23:26 +0200)]
s4-schema: Constraints on msDS-IntId attribute

This attribute can not be modified on existing schema object.

msDS-IntId is not allowed during attribute creation also.

Signed-off-by: Andrew Tridgell <tridge@samba.org>
10 years agos4-schema: Set ATTID in schema cache from "msDS-IntId"
Kamen Mazdrashki [Fri, 18 Dec 2009 02:08:52 +0000 (04:08 +0200)]
s4-schema: Set ATTID in schema cache from "msDS-IntId"

According to http://msdn.microsoft.com/en-us/library/cc223224%28PROT.13%29.aspx
some Attributes OIDs may not use prefixMap.
Setting ATTID in Schema Cache here should work, although
this code snippet should be moved in separate function.

Signed-off-by: Andrew Tridgell <tridge@samba.org>
10 years agoRevert "s4-drs: cope with bogus empty attributes from w2k8-r2"
Kamen Mazdrashki [Fri, 18 Dec 2009 01:58:29 +0000 (03:58 +0200)]
Revert "s4-drs: cope with bogus empty attributes from w2k8-r2"

This reverts commit 1287c1d115fb7e8f3954bc05ff65007968403a9c.

Next patch should fix the "not recognized ATTIDs" problem

Signed-off-by: Andrew Tridgell <tridge@samba.org>
10 years agos4-tort: Tests for "msDS-IntId" attribute implemented
Kamen Mazdrashki [Thu, 17 Dec 2009 17:27:47 +0000 (19:27 +0200)]
s4-tort: Tests for "msDS-IntId" attribute implemented

Signed-off-by: Andrew Tridgell <tridge@samba.org>
10 years agos4-tort: Move Schema tests from ldap.py into separate module
Kamen Mazdrashki [Sun, 13 Dec 2009 23:52:18 +0000 (01:52 +0200)]
s4-tort: Move Schema tests from ldap.py into separate module

Signed-off-by: Andrew Tridgell <tridge@samba.org>
10 years agos4-drs: Fix bug - prefixMap is not updated when adding new OIDs.
Kamen Mazdrashki [Fri, 18 Dec 2009 01:53:13 +0000 (03:53 +0200)]
s4-drs: Fix bug - prefixMap is not updated when adding new OIDs.

The bug is that prefixMap is updated only memory when
adding new Classs/Attribute that has and OID not in
prefixMap already.

Signed-off-by: Andrew Tridgell <tridge@samba.org>
10 years agos4-drstest: Don't remove temp LDB so it can be reviewed if necessary
Kamen Mazdrashki [Fri, 4 Dec 2009 01:58:59 +0000 (03:58 +0200)]
s4-drstest: Don't remove temp LDB so it can be reviewed if necessary

This test makes temp directory which is not removed
so why not just leave LDB also.

Signed-off-by: Andrew Tridgell <tridge@samba.org>
10 years agos4-repl: give a reason why the prepare commit failed
Andrew Tridgell [Mon, 21 Dec 2009 09:58:09 +0000 (20:58 +1100)]
s4-repl: give a reason why the prepare commit failed

10 years agos4-kcc: don't crash with a NULL ntds connection list
Andrew Tridgell [Mon, 21 Dec 2009 09:57:21 +0000 (20:57 +1100)]
s4-kcc: don't crash with a NULL ntds connection list

10 years agos4-repl: only try to replicate for NCs that we are a master for
Andrew Tridgell [Sun, 20 Dec 2009 00:06:23 +0000 (11:06 +1100)]
s4-repl: only try to replicate for NCs that we are a master for

10 years agos4-torture: another unsigned comparison bug
Andrew Tridgell [Sat, 19 Dec 2009 23:27:17 +0000 (10:27 +1100)]
s4-torture: another unsigned comparison bug

10 years agos4-schema: a unsigned comparison bug in the schema code
Andrew Tridgell [Sat, 19 Dec 2009 23:26:21 +0000 (10:26 +1100)]
s4-schema: a unsigned comparison bug in the schema code

10 years agos4-drs: another two unsigned comparison bugs
Andrew Tridgell [Sat, 19 Dec 2009 23:26:06 +0000 (10:26 +1100)]
s4-drs: another two unsigned comparison bugs

10 years agolibrpc: fixed the GUID_compare() function
Andrew Tridgell [Sat, 19 Dec 2009 23:25:46 +0000 (10:25 +1100)]
librpc: fixed the GUID_compare() function

When comparing two unsigned values you can't just subtract
them.

Imagine you are comparing: "uint32_t u1" and "uint32_t u2". If you use
"u1 - u2" and u2 is zero, then the signed integer result will depend
on the top bit of u1.

This error occurs in a few places in Samba. For DRS replication it
resulted in corrupt uptodateness vectors.

10 years agos4-repl: lower debug level of a common message
Andrew Tridgell [Sat, 19 Dec 2009 12:32:48 +0000 (23:32 +1100)]
s4-repl: lower debug level of a common message