ira/wip.git
13 years agoRelease still reachable memory if the smbclient context is freed.
Andreas Schneider [Tue, 15 Jul 2008 12:57:32 +0000 (14:57 +0200)]
Release still reachable memory if the smbclient context is freed.

Signed-off-by: Andreas Schneider <anschneider@suse.de>
(This used to be commit 7a65053bc8579b4f56045fb2c658a91a4af0dfea)

13 years agoFix from Volodymyr Khomenko <Volodymyr.Khomenko@exanet.com>. Make ntimes
Jeremy Allison [Tue, 15 Jul 2008 22:26:36 +0000 (15:26 -0700)]
Fix from Volodymyr Khomenko <Volodymyr.Khomenko@exanet.com>. Make ntimes
function more like POSIX and allow NULL arg. Help vfs developers.
Jeremy.
(This used to be commit 613f2849ad2dc25fe2e5f8a76d69797b5b302bb9)

13 years agoFix swat. Bug #5613.
Jeremy Allison [Tue, 15 Jul 2008 21:37:48 +0000 (14:37 -0700)]
Fix swat. Bug #5613.
Jeremy
(This used to be commit 15920f838835f5dbbac8712202267c2a99237686)

13 years agofix build warning.
Günther Deschner [Tue, 15 Jul 2008 21:05:13 +0000 (23:05 +0200)]
fix build warning.

Guenther
(This used to be commit 507660706901a79544d436046127947e4baa7e52)

13 years agonetapi: fix vim(?)-typo
Michael Adam [Tue, 15 Jul 2008 20:46:12 +0000 (22:46 +0200)]
netapi: fix vim(?)-typo

Michael
(This used to be commit 7a7bddd75413dba3c0c43fab68a115cf0445f12b)

13 years agonetapi: Correctly increase idx when displaying user information
Kai Blin [Wed, 9 Jul 2008 08:39:24 +0000 (10:39 +0200)]
netapi: Correctly increase idx when displaying user information
(This used to be commit 5fad9de2507b88820149def31faa28e5e45f7b5f)

13 years agodbwrap: don't panic in db_open_trans() if called with TDB_CLEAR_IF_FIRST.
Michael Adam [Tue, 15 Jul 2008 14:43:26 +0000 (16:43 +0200)]
dbwrap: don't panic in db_open_trans() if called with TDB_CLEAR_IF_FIRST.

return NULL instead and leave appropriated measures to the caller.

Michael
(This used to be commit 1002507b56a13420d8178c5397610edd839a7584)

13 years agodbwrap: don't panic in db_open_trans() when attaching to ctdb fails.
Michael Adam [Tue, 15 Jul 2008 13:27:46 +0000 (15:27 +0200)]
dbwrap: don't panic in db_open_trans() when attaching to ctdb fails.

Michael
(This used to be commit 308fc7d5bf5f5ccfc73677b052a4e6ecede25921)

13 years agodbwrap: don't panic in db_open() when attaching to ctdb fails.
Michael Adam [Tue, 15 Jul 2008 13:27:14 +0000 (15:27 +0200)]
dbwrap: don't panic in db_open() when attaching to ctdb fails.

Michael
(This used to be commit b9c008d9bd8b8119007e7ad03a40235998af4f5c)

13 years agoregistry: bump debug level to 1 in regdb_init() if storing version string fails.
Michael Adam [Tue, 15 Jul 2008 12:25:00 +0000 (14:25 +0200)]
registry: bump debug level to 1 in regdb_init() if storing version string fails.

Higher level callers should take care of level 0 messages.

Michael
(This used to be commit b5829e04eaf2408858b34f53b849aaf8b969a925)

13 years agoregistry: bump debug level to 1 in regdb_init() if opening the registry fails.
Michael Adam [Tue, 15 Jul 2008 12:22:55 +0000 (14:22 +0200)]
registry: bump debug level to 1 in regdb_init() if opening the registry fails.

Higher level callers take care of level 0 messages or more drastic measures.

Michael
(This used to be commit 111d802b5c0dfdf556f736b6c53df74e077a6238)

13 years agodbwrap: when clustering = yes, don't fall back to db_open_tdb in db_open_trans.
Michael Adam [Mon, 14 Jul 2008 08:53:06 +0000 (10:53 +0200)]
dbwrap: when clustering = yes, don't fall back to db_open_tdb in db_open_trans.

Michael
(This used to be commit 013d29c70438bfd43bd11cbb13ba707b256f9b18)

13 years agodbwrap: when clustering = yes, don't fall back to db_open_tdb in db_open
Michael Adam [Mon, 14 Jul 2008 08:43:28 +0000 (10:43 +0200)]
dbwrap: when clustering = yes, don't fall back to db_open_tdb in db_open

Michael
(This used to be commit 33188a991f7e2f8dc1b5beed1dde1b7f77403e1a)

13 years agotestparm: allow the default debug level of 2 to be changed from the command line.
Michael Adam [Tue, 15 Jul 2008 09:26:43 +0000 (11:26 +0200)]
testparm: allow the default debug level of 2 to be changed from the command line.

Michael
(This used to be commit 5a0883a7f28538fad542293e1d9361e8c4bed1fd)

13 years agopopt: add a popt_common_debuglevel set of options providing -d|--debuglevel
Michael Adam [Tue, 15 Jul 2008 09:26:11 +0000 (11:26 +0200)]
popt: add a popt_common_debuglevel set of options providing -d|--debuglevel

Michael
(This used to be commit e7d08b673066a63aaa7ab54ac59566ae8a975672)

13 years agotestparm: refactor the per-share logic checks out into do_per_share_checks().
Michael Adam [Tue, 15 Jul 2008 11:01:54 +0000 (13:01 +0200)]
testparm: refactor the per-share logic checks out into do_per_share_checks().

Just to enhance clearness of the code.

Michael
(This used to be commit cd5d13dec0153c64d541e85bd13138b738cf50af)

13 years agotestparm: skip the per-share logic checks when --skip-logic-checks is specified.
Michael Adam [Tue, 15 Jul 2008 10:55:57 +0000 (12:55 +0200)]
testparm: skip the per-share logic checks when --skip-logic-checks is specified.

Michael
(This used to be commit 6cafee7e6ae02a32a9f2ddf313d2a20224fa22fe)

13 years agotestparm: rename -g|--skip-global-ckecks to -l|--skip-logic-checks
Michael Adam [Tue, 15 Jul 2008 10:52:25 +0000 (12:52 +0200)]
testparm: rename -g|--skip-global-ckecks to -l|--skip-logic-checks

as suggested by Karolin.

That is what it really means. And per-share logic tests will be
disabled by the same switch, too...

Michael
(This used to be commit 5b8a4c33482917a1ef7071df224957ba831d853a)

13 years agotestsuite: fix bug #5594 by using the new --skip-global-ckecks switch
Michael Adam [Mon, 14 Jul 2008 22:27:01 +0000 (00:27 +0200)]
testsuite: fix bug #5594 by using the new --skip-global-ckecks switch

Michael
(This used to be commit 32f4b1443af12026c419684be45a7d8b96ccfaac)

13 years agotestparm: add a switch --skip-global-checks.
Michael Adam [Mon, 14 Jul 2008 22:17:58 +0000 (00:17 +0200)]
testparm: add a switch --skip-global-checks.

This allows for successfully calling testparm without the need
to "make install" before. Without this, testparm fails with
the message that the lock directory does not exist...

Michael
(This used to be commit eeb018fad65c19804a4e96ea949fc2c64883439e)

13 years agobuild: use $(PAM_WINBIND_EXTRA_LIBS) instead of @PAM_WINBIND_EXTRA_LIBS@ in rules.
Michael Adam [Mon, 14 Jul 2008 16:09:06 +0000 (18:09 +0200)]
build: use $(PAM_WINBIND_EXTRA_LIBS) instead of @PAM_WINBIND_EXTRA_LIBS@ in rules.

Eliminate more potential traps for picky makes.

Michael
(This used to be commit 8897aaec32ef7cb4dab37a70754c8596409fed00)

13 years agobuild: use $(WINBIND_NSS_PTHREAD) instead of @WINBIND_NSS_PTHREAD@ in rules.
Michael Adam [Mon, 14 Jul 2008 16:08:31 +0000 (18:08 +0200)]
build: use $(WINBIND_NSS_PTHREAD) instead of @WINBIND_NSS_PTHREAD@ in rules.

Eliminate more potential traps for picky makes.

Michael
(This used to be commit bf619d019225a7aaf17e213e65c5734e68094142)

13 years agobuild: use $(WINBIND_NSS_EXTRA_LIBS) instead of @WINBIND_NSS_EXTRA_LIBS@ in rules.
Michael Adam [Mon, 14 Jul 2008 16:07:27 +0000 (18:07 +0200)]
build: use $(WINBIND_NSS_EXTRA_LIBS) instead of @WINBIND_NSS_EXTRA_LIBS@ in rules.

Eliminate more potential traps for picky makes.

Michael
(This used to be commit 603b83c980a73e13f7dad35a28830105358c7544)

13 years agobuild: use $(LDAP_LIBS) instead of @LDAP_LIBS@ in rules.
Michael Adam [Mon, 14 Jul 2008 16:06:39 +0000 (18:06 +0200)]
build: use $(LDAP_LIBS) instead of @LDAP_LIBS@ in rules.

Eliminate more potential traps for picky makes.

Michael
(This used to be commit 1f0feb3d12aa93400e8ba604df36a00d7cfaa07a)

13 years agobuild: use $(LIBNETAPI_LIBS) instead of @LIBNETAPI_LIBS@ in rules.
Michael Adam [Mon, 14 Jul 2008 16:06:05 +0000 (18:06 +0200)]
build: use $(LIBNETAPI_LIBS) instead of @LIBNETAPI_LIBS@ in rules.

Eliminate more potential traps for picky makes.

Michael
(This used to be commit cd3c667bdaa8c2b09debbfd8c3389cf9f6d690e9)

13 years agobuild: link in $(WINBIND_LIBS) instead of @LIBWBCLIENT_SHARED@
Michael Adam [Mon, 14 Jul 2008 16:04:53 +0000 (18:04 +0200)]
build: link in $(WINBIND_LIBS) instead of @LIBWBCLIENT_SHARED@

This should fix some more picky makes when not building @LIBWBCLINET_SHARED@
Moreover, we want to link against -lwbclient, not against bin/libwbclient.so
anyways.

Michael
(This used to be commit 73582e4c5168301696cdca569167402f17a67218)

13 years agobuild: use $(LIBTDB_LIBS) instead of @LIBTDB_LIBS@ in rules.
Michael Adam [Mon, 14 Jul 2008 16:02:08 +0000 (18:02 +0200)]
build: use $(LIBTDB_LIBS) instead of @LIBTDB_LIBS@ in rules.

Eliminate more potential traps for picky makes.

Michael
(This used to be commit 4330a2ab1308bd2b1508d5126146742540219520)

13 years agobuild: use $(LIBTALLOC_LIBS) instead of @LIBTALLOC_LIBS@ in rules.
Michael Adam [Mon, 14 Jul 2008 16:00:50 +0000 (18:00 +0200)]
build: use $(LIBTALLOC_LIBS) instead of @LIBTALLOC_LIBS@ in rules.

Eliminate more potential traps for picky makes.

Michael
(This used to be commit 1719fd3ccc110b90908410c07aee862a8758e683)

13 years agobuild: use $(POPT_LIBS) instad of @POPT_LIBS@ in rules.
Michael Adam [Mon, 14 Jul 2008 15:58:53 +0000 (17:58 +0200)]
build: use $(POPT_LIBS) instad of @POPT_LIBS@ in rules.

Eliminate more potential traps for picky makes.

Michael
(This used to be commit 87f56f28800d2045e70739a8edcd359ddee662a7)

13 years agobuild: use $(WINBIND_LIBS) instead of @WINBIND_LIBS@ in rules.
Michael Adam [Mon, 14 Jul 2008 15:55:48 +0000 (17:55 +0200)]
build: use $(WINBIND_LIBS) instead of @WINBIND_LIBS@ in rules.

This fixes the build on systems with picky make, where
libwbclient is not built as a shared library, since the
expansion of @WINBIND_LIBS@ will result in an empty line
in the rule with just the leading tabs/spaces.

Michael
(This used to be commit aff6822c3ab3ea46d928570f03f681f53ccf3d50)

13 years agoAdd fix from Simo for bug #5540 - missing code to substitute
Jeremy Allison [Mon, 14 Jul 2008 19:40:33 +0000 (12:40 -0700)]
Add fix from Simo for bug #5540 - missing code to substitute
%u. Make this the same as other uses.
Jeremy.
(This used to be commit c4a137e9789b06047ce53e5828fb5e1bb76aca06)

13 years agoFix typo.
Karolin Seeger [Mon, 14 Jul 2008 14:40:36 +0000 (16:40 +0200)]
Fix typo.

retieve -> retrieve

Karolin
(This used to be commit 37c64130701ab13b6f34998ac17fec2d128c2e08)

13 years agoFix regression introduced with 4086ef15b395f1a536fb669af2103a33ecc14de4
Simo Sorce [Sun, 13 Jul 2008 01:28:18 +0000 (21:28 -0400)]
Fix regression introduced with 4086ef15b395f1a536fb669af2103a33ecc14de4
We must not return an error here just because we are offline.
We must instead fix the mappings to the best of our knowledge
(ie mark as mapped, expired ones, and as unmapped, unknown ones)
(This used to be commit 4436272dd4d6cdd223b1dc3d217a97cbe3bc887b)

13 years agoRemove one nested level by reversing if condition
Simo Sorce [Sun, 13 Jul 2008 01:23:16 +0000 (21:23 -0400)]
Remove one nested level by reversing if condition
(This used to be commit 657a2f20dd4d422d45d7e054f463641cdff16816)

13 years agoAdd back mem leak fixes
Simo Sorce [Sun, 13 Jul 2008 01:13:44 +0000 (21:13 -0400)]
Add back mem leak fixes
(This used to be commit 2adea093c5709e128bdde1e37c6a897db7cbc3b1)

13 years agoMake again idmap_init static
Simo Sorce [Sun, 13 Jul 2008 01:13:05 +0000 (21:13 -0400)]
Make again idmap_init static
(This used to be commit e113b7c13f2457676fdec9e52f09046286e25b60)

13 years agoRemove an unused extern reference in vfs_aixacl2.c
Volker Lendecke [Sun, 6 Jul 2008 10:19:28 +0000 (12:19 +0200)]
Remove an unused extern reference in vfs_aixacl2.c
(This used to be commit 1dfb9242d1b6000d4b75327adf1a0a0882f3ea6c)

13 years agoRevert "Fix two memory leaks in an error path in idmap.c"
Volker Lendecke [Fri, 11 Jul 2008 15:46:09 +0000 (17:46 +0200)]
Revert "Fix two memory leaks in an error path in idmap.c"

This reverts commit 7cec389e19323e99b6b6258e539be9d1fd65810f.
(This used to be commit d0b34cbb4eba2b6543402af2c9f95407546cefad)

13 years agoRevert "Make idmap_init() static"
Volker Lendecke [Fri, 11 Jul 2008 15:46:00 +0000 (17:46 +0200)]
Revert "Make idmap_init() static"

This reverts commit c8d1bbfddce41cd6bf37dd0a622ef3437a24b492.
(This used to be commit 5cded3da00c0af40a98d86011507553f97fe6a22)

13 years agoRevert "Fix typo"
Volker Lendecke [Fri, 11 Jul 2008 15:45:54 +0000 (17:45 +0200)]
Revert "Fix typo"

This reverts commit fe58926283b51910d8587e32bb11aa681b9a27d3.
(This used to be commit fe216bff1d7d805403cbfb3eaf381c2a57a254d7)

13 years agoRevert "Fix a debug msg, this was probably a leftover from gencache"
Volker Lendecke [Fri, 11 Jul 2008 15:45:46 +0000 (17:45 +0200)]
Revert "Fix a debug msg, this was probably a leftover from gencache"

This reverts commit daa171552dc00d9602a05ba199c9a3ff24c802f5.
(This used to be commit b826420c3adfd24a01080d25f8a61d33d05722c8)

13 years agoRevert "Fix indentation"
Volker Lendecke [Fri, 11 Jul 2008 15:45:40 +0000 (17:45 +0200)]
Revert "Fix indentation"

This reverts commit 954556b527aa652f9a46f0d48834e92befb3c5f9.
(This used to be commit 1b1124bcb9043deb495897467e4cd3ae8a07784b)

13 years agoRevert "Fix nonempty whitespace only lines"
Volker Lendecke [Fri, 11 Jul 2008 15:45:31 +0000 (17:45 +0200)]
Revert "Fix nonempty whitespace only lines"

This reverts commit 0da9d0d0f9662d8bd2f370f764d5a875e11b3068.
(This used to be commit b2f7bd6a05afcbba076f78d0caeaf154854db7de)

13 years agoRevert "fix typos"
Volker Lendecke [Fri, 11 Jul 2008 15:45:23 +0000 (17:45 +0200)]
Revert "fix typos"

This reverts commit e0957c6f4b1e81c27fda1de7fb7cbc9c585f5ac9.
(This used to be commit 0d2fc3c394d300d906cdcd14f1abf8e6f84beff7)

13 years agoRevert "Fix nonempty whitespace only lines"
Volker Lendecke [Fri, 11 Jul 2008 15:45:16 +0000 (17:45 +0200)]
Revert "Fix nonempty whitespace only lines"

This reverts commit cc77db2acbc35cea58576f1e28c7a760a5e31609.
(This used to be commit ed5b516c2027d78011cdaa7cbbc01bb01e766381)

13 years agoRevert "Tiny logic simplification: Remove an unnecessary else branch"
Volker Lendecke [Fri, 11 Jul 2008 15:45:09 +0000 (17:45 +0200)]
Revert "Tiny logic simplification: Remove an unnecessary else branch"

This reverts commit 6009ae329375b1c40e3d00df977ddccc8b5cc176.
(This used to be commit b71ce00796efdd27b593bbbc36f5cbba23fe9240)

13 years agoRevert "Fix typo"
Volker Lendecke [Fri, 11 Jul 2008 15:45:03 +0000 (17:45 +0200)]
Revert "Fix typo"

This reverts commit fe79c8a5b726754703626ca0bff57074274c98c7.
(This used to be commit 62835f8d7e824a5d469ec5f79e4db739e6602f4f)

13 years agoRevert "Make use of sid_check_is_in_unix_users/groups"
Volker Lendecke [Fri, 11 Jul 2008 15:44:52 +0000 (17:44 +0200)]
Revert "Make use of sid_check_is_in_unix_users/groups"

This reverts commit cd8e63b2b45402091d6d328b3c6ca593fc19ac92.
(This used to be commit 061e55d4f48d269dc45fad6739e0872501b9433d)

13 years agoRevert "Don't scream, better explain a bit in comments"
Volker Lendecke [Fri, 11 Jul 2008 15:44:44 +0000 (17:44 +0200)]
Revert "Don't scream, better explain a bit in comments"

This reverts commit dcc39ed00453a075b23daece2844ca4817bfbfaf.
(This used to be commit 26ca09a3570a0df051d042bef586ea57ad9f198c)

13 years agoRevert "Fix indentation"
Volker Lendecke [Fri, 11 Jul 2008 15:44:35 +0000 (17:44 +0200)]
Revert "Fix indentation"

This reverts commit c4e6de9e34e1ff76552ce6d4e72b343fb5f33306.
(This used to be commit fa9b128e93cca45b9516917f73f586197e7637f3)

13 years agoRevert "Pass NULL to gencache_get when we are not interested in the timeout value"
Volker Lendecke [Fri, 11 Jul 2008 15:44:25 +0000 (17:44 +0200)]
Revert "Pass NULL to gencache_get when we are not interested in the timeout value"

This reverts commit 16062dfc3dcc8f1ca0024a3ae21effb889c7ffc0.
(This used to be commit 114ca8577568cdb5a81d8734f1d1d096f1b36c36)

13 years agoRevert "Return timed out entries from gencache_get if timeout param != NULL"
Volker Lendecke [Fri, 11 Jul 2008 15:44:15 +0000 (17:44 +0200)]
Revert "Return timed out entries from gencache_get if timeout param != NULL"

This reverts commit 2954b2be563149380e1fae7fe088b98d6cbd42e7.
(This used to be commit 77ab2fb306a7ad59447a3e1591c2af03447e09c5)

13 years agoRevert "Remove gencache_[un]lock_entry"
Volker Lendecke [Fri, 11 Jul 2008 15:44:09 +0000 (17:44 +0200)]
Revert "Remove gencache_[un]lock_entry"

This reverts commit 7a5a575ffe5196caecedc93970a25abfbe6f8059.
(This used to be commit 62e444dd50ae974c2ab9a553cdf7f188a8f2c538)

13 years agoRevert "Remove an unused variable"
Volker Lendecke [Fri, 11 Jul 2008 15:43:54 +0000 (17:43 +0200)]
Revert "Remove an unused variable"

This reverts commit 454cb852e06fa3d8bdd0eebb3ebdb24b3d74ecd0.
(This used to be commit cae8ec3199d5b0ffe0bfb6f15adaa5a12343c763)

13 years agoRevert "Simplify idmap_cache_build_[s]idkey a bit"
Volker Lendecke [Fri, 11 Jul 2008 15:43:42 +0000 (17:43 +0200)]
Revert "Simplify idmap_cache_build_[s]idkey a bit"

This reverts commit 80932c0266ef73b8d0462c078a053444fff47f32.
(This used to be commit 847609a148b653b9e3a24b2bc9e1636c6ef0db84)

13 years agoRevert "Simplify idmap_cache_set() a bit"
Volker Lendecke [Fri, 11 Jul 2008 15:43:25 +0000 (17:43 +0200)]
Revert "Simplify idmap_cache_set() a bit"

This reverts commit 55b976ba93462c6885e8d89edd13c32fb5529944.
(This used to be commit 23edc4ec0ab1de60a864de01c0ff90ea1378231d)

13 years agoRevert "IDMAP_READ_CACHE_DATA_FMT_TEMPLATE is unused, remove it"
Volker Lendecke [Fri, 11 Jul 2008 15:43:17 +0000 (17:43 +0200)]
Revert "IDMAP_READ_CACHE_DATA_FMT_TEMPLATE is unused, remove it"

This reverts commit 2396d5d5d2f453f097f8ce77b640ad7e1d7e7c4c.
(This used to be commit 447d77949f99fdc5fc2bea6ddc27176d3a0871a9)

13 years agoRevert "Slightly increase the default idmap cache time"
Volker Lendecke [Fri, 11 Jul 2008 15:43:07 +0000 (17:43 +0200)]
Revert "Slightly increase the default idmap cache time"

This reverts commit 448836d44d0468a74b962ba3c0b7d51de236374f.
(This used to be commit a9b29ab6b7503d6d30553a17219603a4f4cd3df9)

13 years agoRevert "Convert idmap_cache to gencache"
Volker Lendecke [Fri, 11 Jul 2008 15:42:58 +0000 (17:42 +0200)]
Revert "Convert idmap_cache to gencache"

This reverts commit 0bf0434f22b0ea46fda3ccc4dd612adbc88dd4f2.
(This used to be commit cc536677735ecc318cbd2176ce53b124f44d85a0)

13 years agoRevert "Make use of ADD_TO_ARRAY"
Volker Lendecke [Fri, 11 Jul 2008 15:42:48 +0000 (17:42 +0200)]
Revert "Make use of ADD_TO_ARRAY"

This reverts commit 81f334bd6da601a040f754c46705cfa2fd4f8c45.
(This used to be commit d4d106776af3f475d46a4dd78794b7b48a3572af)

13 years agoRevert "Tiny logic simplification -- remove an else branch"
Volker Lendecke [Fri, 11 Jul 2008 15:42:40 +0000 (17:42 +0200)]
Revert "Tiny logic simplification -- remove an else branch"

This reverts commit 01c8c7bbf6163d5c7733db0d8ecbccfe7e4fec7d.
(This used to be commit b0fe0c7ac18d4f47ad4a218114de7bab7a3f19de)

13 years agobuild: fix build of libaddns shared lib : it needs socket_wrapper.
Michael Adam [Fri, 11 Jul 2008 13:35:24 +0000 (15:35 +0200)]
build: fix build of libaddns shared lib : it needs socket_wrapper.

Michael
(This used to be commit 58bc04b31b15c36505c5ecb2d8373e9033972390)

13 years agobuild: fix build of libaddns shared lib. symbols file was missing.
Michael Adam [Fri, 11 Jul 2008 12:38:22 +0000 (14:38 +0200)]
build: fix build of libaddns shared lib. symbols file was missing.

This symbols file is checked because mksyms script currently does
not support headers without exportet symbols...

Michael
(This used to be commit 1fa57b47e8f8da33a5713096c187bafb3a6c5b79)

13 years agoFix the build of nfs4_acls.c
Volker Lendecke [Fri, 11 Jul 2008 11:03:42 +0000 (13:03 +0200)]
Fix the build of nfs4_acls.c
(This used to be commit 2abb7cd867be307e56c02087e700189b17efb894)

13 years agoAdd XATTR_NTACL_NAME constant.
Jeremy Allison [Fri, 11 Jul 2008 00:19:01 +0000 (17:19 -0700)]
Add XATTR_NTACL_NAME constant.
Jeremy.
(This used to be commit 9c21756f9e841fd996590619b5eedc659f849626)

13 years agoMerge branch 'v3-3-test' of ssh://jra@git.samba.org/data/git/samba into v3-3-test
Jeremy Allison [Thu, 10 Jul 2008 22:25:40 +0000 (15:25 -0700)]
Merge branch 'v3-3-test' of ssh://jra@git.samba.org/data/git/samba into v3-3-test
(This used to be commit 593d855128d4119c21b2b15bfb9369b760504f86)

13 years agoFix realpath() check so that it doesn't generate a core() when it fails.
Zach Loafman [Thu, 10 Jul 2008 18:45:48 +0000 (18:45 +0000)]
Fix realpath() check so that it doesn't generate a core() when it fails.
(This used to be commit 5fdbf89c898efff57c65061ea2c360d2cd91bcec)

13 years agodocs: fix the specified default of "password server" - it is *, not "".
Michael Adam [Thu, 10 Jul 2008 21:49:58 +0000 (23:49 +0200)]
docs: fix the specified default of "password server" - it is *, not "".

Michael
(This used to be commit d7f759d302612ef9eb0bba022f3b3e1dd433f843)

13 years agoFix some memleaks regarding trustdom passwords
Volker Lendecke [Thu, 10 Jul 2008 16:21:03 +0000 (18:21 +0200)]
Fix some memleaks regarding trustdom passwords
(This used to be commit 3d2913d599a4cd773614110ec7b7493aa7adb547)

13 years agoFix some uninitialized variable references via ndr_print
Volker Lendecke [Thu, 10 Jul 2008 16:20:30 +0000 (18:20 +0200)]
Fix some uninitialized variable references via ndr_print
(This used to be commit 26fb3fea812867f8b0dfe6a1be59e4922ed86e45)

13 years agoFix a segfault in base64_encode_data_blob
Volker Lendecke [Thu, 10 Jul 2008 16:12:24 +0000 (18:12 +0200)]
Fix a segfault in base64_encode_data_blob

We did not allocate enough memory for the \0 and a = at the end
(This used to be commit ea110de1dc6257b78631b7d83b7bbb728180c1a1)

13 years agobuild: remove SHLIBS variable, and distribute deps for shlibs and test_shlibs target
Michael Adam [Thu, 10 Jul 2008 14:25:21 +0000 (16:25 +0200)]
build: remove SHLIBS variable, and distribute deps for shlibs and test_shlibs target

Michael
(This used to be commit 939e75126ebfcd9124781b5d70a68886c4bf9a54)

13 years agobuild: create a new uninstalllibs target and use it in "make uninstall"
Michael Adam [Thu, 10 Jul 2008 13:51:14 +0000 (15:51 +0200)]
build: create a new uninstalllibs target and use it in "make uninstall"

Michael
(This used to be commit 73a3e4e1eaa408ef0ddbbb8aa0113fdc869057bb)

13 years agobuild: distribute the libs target over the library-specific sections.
Michael Adam [Thu, 10 Jul 2008 13:49:44 +0000 (15:49 +0200)]
build: distribute the libs target over the library-specific sections.

Michael
(This used to be commit 18b932c980f2acdf9b5569cf61afece28c02abf5)

13 years agobuild: use the libs target instead of the LIBRARIES variable as dependecy for "all".
Michael Adam [Thu, 10 Jul 2008 13:01:56 +0000 (15:01 +0200)]
build: use the libs target instead of the LIBRARIES variable as dependecy for "all".

Michael
(This used to be commit 991c3fefa850c0b48111c6c5bacae14163872b58)

13 years agobuild: distribute the cleanlibs target over the library-specific sections.
Michael Adam [Thu, 10 Jul 2008 12:58:36 +0000 (14:58 +0200)]
build: distribute the cleanlibs target over the library-specific sections.

Michael
(This used to be commit 2588c399a0df99a87cf7c749133bceb6aa34a21a)

13 years agobuild: introduce a installibs target and use it in "make install"
Michael Adam [Thu, 10 Jul 2008 12:15:39 +0000 (14:15 +0200)]
build: introduce a installibs target and use it in "make install"

The target is distributed over the library-specific sections.

Michael
(This used to be commit 0afe205a7da4103a4fcfdd24f45a164493e3b9b8)

13 years agodocs: fix the net conf section of net(8) to mention "config backend = registry".
Michael Adam [Thu, 10 Jul 2008 12:05:33 +0000 (14:05 +0200)]
docs: fix the net conf section of net(8) to mention "config backend = registry".

Michael
(This used to be commit c2e9d82d9497f0d245a46c5c82ff15306788109e)

13 years agodocs: fix VERSION section in the net(8) manpage.
Michael Adam [Thu, 10 Jul 2008 11:50:04 +0000 (13:50 +0200)]
docs: fix VERSION section in the net(8) manpage.

It still said for version 3.0 ..

Michael
(This used to be commit 93887f2e42bf4e632dab716deda6d2951dbd1f2a)

13 years agodocs: update the section about net conf in the net(8) manpage.
Michael Adam [Thu, 10 Jul 2008 11:46:25 +0000 (13:46 +0200)]
docs: update the section about net conf in the net(8) manpage.

The description of the "net conf {get,set,del}includes" commands was missing.

Michael
(This used to be commit 671988c7b5891deeca23e2305fe101a3be1a44d2)

13 years agoman pages: Add missing whitespace.
Karolin Seeger [Thu, 10 Jul 2008 09:23:59 +0000 (11:23 +0200)]
man pages: Add missing whitespace.

Karolin
(This used to be commit 5ba418d8bd7bd9a678853b23b0928da4f8693bcf)

13 years agoA brown paper bag bug fix for "net sam rights"
Volker Lendecke [Thu, 10 Jul 2008 09:11:53 +0000 (11:11 +0200)]
A brown paper bag bug fix for "net sam rights"
(This used to be commit 8a455b012827cfb917473a160c5710a90490451a)

13 years agoGive a nice error message if trying to join with a non-privileged user
Volker Lendecke [Thu, 10 Jul 2008 08:47:46 +0000 (10:47 +0200)]
Give a nice error message if trying to join with a non-privileged user
(This used to be commit 347772fc39d9c7a96fcc72c9707696cc6abd89d7)

13 years agoAdd in the IDL to store a NT Security descriptor in
Jeremy Allison [Wed, 9 Jul 2008 23:54:38 +0000 (16:54 -0700)]
Add in the IDL to store a NT Security descriptor in
a blob. Use the same format as S4, but a new version
as we'll need to store the timestamp to check for
validity against the POSIX st_ctime.
Jeremy.
(This used to be commit 5c4ce1dac3769bfe533a4ea778c916d117603603)

13 years agoFix alignment problems on sparc, bug 5512
Volker Lendecke [Fri, 4 Jul 2008 07:28:04 +0000 (09:28 +0200)]
Fix alignment problems on sparc, bug 5512

Patch successfully tested by Christoph Kaegi <kaph@zhaw.ch>, thanks.
(cherry picked from commit 9f8df16f476c49da85000b7365c8a6e33b8b71fc)
(This used to be commit 82ed19ff64fc815a8ca9fbd7d3331671ecf5d12b)

13 years agoRevert "tdbtool: fix off-by-one error in argument length. (bug #2344)"
Michael Adam [Wed, 9 Jul 2008 10:48:05 +0000 (12:48 +0200)]
Revert "tdbtool: fix off-by-one error in argument length. (bug #2344)"

This reverts commit fafb8ad2b81b9a46cf8259bedc1dca5023b06115.

This fix is not valid:

1. convert_string() is not only used for key strings but also for data.

2. Some databases use string_tdb_data() i.e. non-null-terminated strings
   as keynames and others (like the one I was using), use
   string_term_tdb_data(), i.e. zero-terminated key strings.

After discussion with Metze, the easiest (and proper way) to
handle this is to specify key names as "keyname\0" for databases
which use string_term_tdb_data().

Sorry for the noise...

Michael
(cherry picked from commit 17c012c4645f4e9542537c15f80d9b4e74304d11)
(This used to be commit 42c953c106b3da90e8c3452c4a246392502c200d)

13 years agoregistry: fix logic in deleting subkeys record in regdb_fetch_keys().
Michael Adam [Wed, 9 Jul 2008 08:40:39 +0000 (10:40 +0200)]
registry: fix logic in deleting subkeys record in regdb_fetch_keys().

Don't cancel on NT_STATUS_NOT_FOUND error from dbwrap_delete_bystring().
So deletion of an "incomlete" registry key, i.e. one with an entry in
the list of subkeys of its parent key but not a subkey list of its own,
works again.

Michael
(This used to be commit 75be2116ac2589aaf69038a4115197f40e4b16a5)

13 years agoregistry: improve logic for deleting value records in regdb_store_keys().
Michael Adam [Wed, 9 Jul 2008 08:39:00 +0000 (10:39 +0200)]
registry: improve logic for deleting value records in regdb_store_keys().

Don't ignore all errors from dbwrap_delete_bystring() but
only NT_STATUS_NOT_FOUND.

Michael
(This used to be commit d7ec9b2d52d1eddd98eba222f723fb6cdff4541f)

13 years agoMerge branch 'v3-3-test' of ssh://git.samba.org/data/git/samba into v3-3-test
Derrell Lipman [Wed, 9 Jul 2008 00:44:57 +0000 (20:44 -0400)]
Merge branch 'v3-3-test' of ssh://git.samba.org/data/git/samba into v3-3-test
(This used to be commit 2dab9ad77954dc608f8910bf4d3cb92fcaad5cb6)

13 years ago[BUG 5580] Allow access to DFS shares via libsmbclient
Derrell Lipman [Wed, 9 Jul 2008 00:44:39 +0000 (20:44 -0400)]
[BUG 5580] Allow access to DFS shares via libsmbclient

Brian Sheehan provided a nice patch intended for the 3.0 code base.  This
commit applies a similar patch for the 3.3 code base.  It adds a new public
function to libsmbclient -- smbc_set_credentials() -- that may be called from
the authentication callback when DFS referrals are in use.

Derrell
(This used to be commit 888f922bd0d1c84a687d404e95ae314a9dd0aee1)

13 years agoMinor style correction
Zach Loafman [Tue, 8 Jul 2008 02:30:47 +0000 (19:30 -0700)]
Minor style correction

Set sin[6]_family instead of ss_family in in[6]_addr_to_sockaddr_storage
so that assignments look like they're going to the same place.
(This used to be commit 3d19112f645fb0f4bb6b644207ed2cee0b6b3ea9)

13 years agotestsuite: fix another expr typo in net registry test script.
Michael Adam [Tue, 8 Jul 2008 22:33:54 +0000 (00:33 +0200)]
testsuite: fix another expr typo in net registry test script.

Michael
(This used to be commit 73312e4e21b6d14363bd0987e0c9716c4ec91834)

13 years agotestsuite: fix expr typo in net registry testscript.
Michael Adam [Tue, 8 Jul 2008 22:33:14 +0000 (00:33 +0200)]
testsuite: fix expr typo in net registry testscript.

Michael
(This used to be commit 5b6c32160a5d8fafc807fbefb66aa8c98662baae)

13 years agoregistry: fetch regdb_fetch_keys() when a key exists but not its subkey-record.
Michael Adam [Tue, 8 Jul 2008 15:10:01 +0000 (17:10 +0200)]
registry: fetch regdb_fetch_keys() when a key exists but not its subkey-record.

According to the new policy a key (that is not a base key) exists,
iff it exists in the subkey list of its parent key.

Usually this subkeylist is present, but in a transaction-less
dbwrap backend (ctdb), a failing write can leave an "incomplete"
key without its own subkeylist-record. (Otherwise such an
incomplete key can be generated with e.g. tdbtool.)
For such a key net registry enumerate (e.g.) would fail.
This commit fixes this behaviour of regdb_fetch_keys().

Michael
(This used to be commit f329aaf0452cc9bbad9fb6f67dac00bf8d1ef128)

13 years agobuild: move definition of LIBADDNS_OBJ back up to LIBADDNS_OBJ0
Michael Adam [Tue, 8 Jul 2008 15:00:07 +0000 (17:00 +0200)]
build: move definition of LIBADDNS_OBJ back up to LIBADDNS_OBJ0

to keep stuff together...

Michael
(This used to be commit 22735ee14a244dbda768c26dbe83a1b2aa3c03ec)

13 years agobuild: fix build of smbget by moving LIBSMBCLIENT_OBJ* defs up again
Michael Adam [Tue, 8 Jul 2008 14:55:52 +0000 (16:55 +0200)]
build: fix build of smbget by moving LIBSMBCLIENT_OBJ* defs up again

to their original place. The problem was that LIBSMCLIENT_OBJ1 is used
in SMBGET_OBJ and that the difinition of LIBSMBCLIENT_OBJ1 was moved
below the bin/smbget target. Somehow it had worked for me.

Thanks to Derrell for pointing that out.

Michael
(This used to be commit c4e51f5e761ab23fa08197fa9a52af6db4ab839d)

13 years agotdbtool: fix off-by-one error in argument length. (bug #2344)
Michael Adam [Tue, 8 Jul 2008 13:33:36 +0000 (15:33 +0200)]
tdbtool: fix off-by-one error in argument length. (bug #2344)

This prevented all commands operating on keys (all non-traverse commands)
in tdbtool to fail with a "fetch failed" or "delete failed" message.

It seems that it fixes bug #2344 ...

Apparently this bug was introduced with 94e53472666ed in 2005.
Either nobody is using tdbtool or else tdb_find() has become
more strict about the key legth in the meantime. :-)

Michael
(This used to be commit 9be6b46f7715cdc7f77308d7613e8df73effe3c1)

13 years agoFix option processing in smbcacls - add POPT_COMMON_CONNECTION.
Jeremy Allison [Mon, 7 Jul 2008 22:51:08 +0000 (15:51 -0700)]
Fix option processing in smbcacls - add POPT_COMMON_CONNECTION.
Jeremy.
(This used to be commit 599d5f75c703a4cae3da87eb09b6a46285f6b074)

13 years agobuild: fix creation of libsmbclient.a - don't link in libtalloc.a
Michael Adam [Mon, 7 Jul 2008 16:32:50 +0000 (18:32 +0200)]
build: fix creation of libsmbclient.a - don't link in libtalloc.a

a step in fixing bug #5590

Michael
(This used to be commit bae7bd4bba4d49edec9cb58d47c1cb82aba16c6b)

13 years agobuild: fix creation of libaddns.a - don't link in libtalloc.a
Michael Adam [Mon, 7 Jul 2008 16:30:12 +0000 (18:30 +0200)]
build: fix creation of libaddns.a - don't link in libtalloc.a

a step in fixing bug #5590

Michael
(This used to be commit 4d6edcb2c8bd516e09a864d1990675ba9bcec796)