20 years agoChanges from APPLIANCE_HEAD:
David O'Neill [Mon, 4 Dec 2000 16:57:17 +0000 (16:57 +0000)]
Changes from APPLIANCE_HEAD:
    - clean up yodl doc for the -U changes, update man and html versions
      (docs/yodldocs/smbclient.1.yo docs/htmldocs/smbclient.1.html
(This used to be commit 3483be1d76fe0dae770bdf8ad97bab81645e5fbf)

20 years agofixed a typo
Andrew Tridgell [Mon, 4 Dec 2000 07:39:22 +0000 (07:39 +0000)]
fixed a typo
(This used to be commit c9e4dea1cbcf6aa748f5cb10f226345dd2f1adbf)

20 years agoadded a comment
Andrew Tridgell [Mon, 4 Dec 2000 07:38:06 +0000 (07:38 +0000)]
added a comment
(This used to be commit 032442802f73948e3af2c86fee0d58f82e47f673)

20 years agofixed the parsing again and got setting acls working with w2k
Andrew Tridgell [Mon, 4 Dec 2000 07:27:35 +0000 (07:27 +0000)]
fixed the parsing again and got setting acls working with w2k
(This used to be commit 374d08be6443738d6a450801866fd6e046322e2c)

20 years agopass the desired access into cli_nt_create()
Andrew Tridgell [Mon, 4 Dec 2000 07:26:56 +0000 (07:26 +0000)]
pass the desired access into cli_nt_create()
(This used to be commit a2d07994e0376a8d530d262573c96710bdff2236)

20 years agoAdded some cli_errstr() calls.
Tim Potter [Mon, 4 Dec 2000 06:46:52 +0000 (06:46 +0000)]
Added some cli_errstr() calls.
(This used to be commit faaa71a032bc27d073c39da42fc2928ea3226698)

20 years agoRemoved lsa lookup warnings (I'll remember).
Tim Potter [Mon, 4 Dec 2000 06:43:36 +0000 (06:43 +0000)]
Removed lsa lookup warnings (I'll remember).

Print an error if -M refers to a non-existent ACL.
(This used to be commit ee6f5a9672795c884cabe80e98e5b0fb3c793539)

20 years agofixed setting ACLs on directories
Andrew Tridgell [Mon, 4 Dec 2000 06:39:31 +0000 (06:39 +0000)]
fixed setting ACLs on directories
(This used to be commit 117956ecb1878f09708a5dc76ec81ad3cfa8d809)

20 years agofixed indentation
Andrew Tridgell [Mon, 4 Dec 2000 06:39:14 +0000 (06:39 +0000)]
fixed indentation
(This used to be commit b7a1c00bed5f0650783c8d7397c11aa2ac59aa04)

20 years agoMask value now displayed as READ/CHANGE/FULL for standard permissions, or
Tim Potter [Mon, 4 Dec 2000 06:14:28 +0000 (06:14 +0000)]
Mask value now displayed as READ/CHANGE/FULL for standard permissions, or
RWXDPO for special permissions.

Append 0x to values printed as hex.

Spruced up the help message.
(This used to be commit 8a20318c5626f7328fd911144c54fe92426532c5)

20 years agoremoved SACL support (as it doesn't work with w2k if you ask for
Andrew Tridgell [Mon, 4 Dec 2000 04:58:40 +0000 (04:58 +0000)]
removed SACL support (as it doesn't work with w2k if you ask for
(This used to be commit 52b27d75e12eeeb52b3a93952900809c2ee0b992)

20 years agodocument -U change
Andrew Tridgell [Mon, 4 Dec 2000 04:27:53 +0000 (04:27 +0000)]
document -U change
(This used to be commit 309fab281d569f325615dd2ae71af554b88601c9)

20 years agoin cli_session_setup() accept usernames of the form DOMAIN/USER or
Andrew Tridgell [Mon, 4 Dec 2000 04:26:22 +0000 (04:26 +0000)]
in cli_session_setup() accept usernames of the form DOMAIN/USER or

this means all our tools can now put the domain name in the -U option
(This used to be commit bac1c76f03b6b848fa2e942b12c646aed58bee12)

20 years agosigned/unsigned warning fixed
Andrew Tridgell [Mon, 4 Dec 2000 03:27:02 +0000 (03:27 +0000)]
signed/unsigned warning fixed
(This used to be commit 71adecd163b13169d359b69f61e8e70e2f140277)

20 years agoc++ style comments are NOT allowed
Andrew Tridgell [Mon, 4 Dec 2000 03:01:31 +0000 (03:01 +0000)]
c++ style comments are NOT allowed
(This used to be commit 8b3c1f4455b7db440911960298f772c4db3d8112)

20 years agofixed acls set bug
Andrew Tridgell [Mon, 4 Dec 2000 02:01:57 +0000 (02:01 +0000)]
fixed acls set bug
(This used to be commit 44524958ed3a0d56b0504b044bf640ceffebb704)

20 years agonew proto
Andrew Tridgell [Mon, 4 Dec 2000 02:01:12 +0000 (02:01 +0000)]
new proto
(This used to be commit 27c676cb3b43344ce4ceb167322c98027b9c1e4e)

20 years agono longer pass the type to make_sec_desc(), instead the type is
Andrew Tridgell [Mon, 4 Dec 2000 01:58:22 +0000 (01:58 +0000)]
no longer pass the type to make_sec_desc(), instead the type is
derived from the other arguments
(This used to be commit 9ec4b1fa48fbae937fdf78db06005a7b0cd52d89)

20 years agoReformatted to look nicer on 80-character screen.
Tim Potter [Mon, 4 Dec 2000 01:52:54 +0000 (01:52 +0000)]
Reformatted to look nicer on 80-character screen.

Replaced 8-bit ascii characters with appropriate 7-bit ones.
(This used to be commit cfe4cb5dfaabde8eee0ec20d938cf58a891286a3)

20 years agofixed SACL bug
Andrew Tridgell [Mon, 4 Dec 2000 00:35:31 +0000 (00:35 +0000)]
fixed SACL bug
(This used to be commit 077ee4a7ac7fa8f274269bfc5130d5abff9f35e0)

20 years ago- with -D only delete first match
Andrew Tridgell [Mon, 4 Dec 2000 00:33:08 +0000 (00:33 +0000)]
- with -D only delete first match
- fixed delete bug
(This used to be commit 1e0d5f069592ebce58c35e95b0dcdbc5516dd268)

20 years agoFixed some debugging code.
Tim Potter [Mon, 4 Dec 2000 00:07:27 +0000 (00:07 +0000)]
Fixed some debugging code.
(This used to be commit 369a378b3390b060a676c67950f020c4d147fe6d)

20 years ago- added help
Andrew Tridgell [Sun, 3 Dec 2000 12:41:28 +0000 (12:41 +0000)]
- added help
- added add/modify/delete/set as separate operations
(This used to be commit cb324b53c61ee7e4bf0aa5d1fb773672a2674c0f)

20 years agonew protos
Andrew Tridgell [Sun, 3 Dec 2000 11:05:30 +0000 (11:05 +0000)]
new protos
(This used to be commit 0a990f02d0e25c0f854d6caa3e9c3bc7329697c7)

20 years agocleaner parsing and default handling
Andrew Tridgell [Sun, 3 Dec 2000 11:05:11 +0000 (11:05 +0000)]
cleaner parsing and default handling
(This used to be commit f8dbd2b799545a8e1e33eceb6739b5b606cdc4b9)

20 years agochanged an error message
Andrew Tridgell [Sun, 3 Dec 2000 11:04:45 +0000 (11:04 +0000)]
changed an error message
(This used to be commit f9f14a4293cecb738f733c6c845275619f7bec40)

20 years ago- better parsing
Andrew Tridgell [Sun, 3 Dec 2000 08:35:11 +0000 (08:35 +0000)]
- better parsing
- started to add non-numeric support
(This used to be commit fd4c03aef692cd8ef9a29b60a4d66fe898430317)

20 years agogetting/setting acls now works. The SIDs are still numeric, the next
Andrew Tridgell [Sun, 3 Dec 2000 07:36:15 +0000 (07:36 +0000)]
getting/setting acls now works. The SIDs are still numeric, the next
step is to support usernames etc
(This used to be commit 6cea1647fcbc6f5a903c691273dcec44fcda1fc4)

20 years agoadded basic ability to dump remote file acls
Andrew Tridgell [Sun, 3 Dec 2000 05:24:16 +0000 (05:24 +0000)]
added basic ability to dump remote file acls
(This used to be commit c6c90dc8e163d874748e2020cc140134cffcfe32)

20 years agomake sure we don't duplicate object files
Andrew Tridgell [Sun, 3 Dec 2000 05:23:46 +0000 (05:23 +0000)]
make sure we don't duplicate object files
(This used to be commit 976b9f6264c1a5af996777ff1d71db0f762cfa9b)

20 years agonew proto
Andrew Tridgell [Sun, 3 Dec 2000 02:20:33 +0000 (02:20 +0000)]
new proto
(This used to be commit 2f21a0b10007056d0c359a0edb869f47c897ee7c)

20 years agoa prootype program for querying/setting a security decsriptor on a
Andrew Tridgell [Sun, 3 Dec 2000 02:19:27 +0000 (02:19 +0000)]
a prootype program for querying/setting a security decsriptor on a
remote machine

it is by no means complete, expect more commits soon
(This used to be commit f2f9859b700085cce0ed0c12d8780ad554255ea4)

20 years ago- added client support for nttrans calls
Andrew Tridgell [Sun, 3 Dec 2000 02:18:14 +0000 (02:18 +0000)]
- added client support for nttrans calls
- added a cli_ function for querying a security descriptor on a remote file
(This used to be commit e21994ff9d512d1c9d6d360e930809b135df4cf7)

20 years agosplit the RPC_PARSE object into two pieces. The first is included as
Andrew Tridgell [Sun, 3 Dec 2000 02:15:58 +0000 (02:15 +0000)]
split the RPC_PARSE object into two pieces. The first is included as
part of LIBSMB and the latter is used by parts of samba that know
about the pwd backends
(This used to be commit 3420b52da5957b5bbf0704d1e386349a061f86cf)

20 years agoAdded print_freelist command.
Jeremy Allison [Sat, 2 Dec 2000 01:04:11 +0000 (01:04 +0000)]
Added print_freelist command.
(This used to be commit ee89ca9e68abb23fc26cd1378e02e56d0d725e55)

20 years agochange the split threahold for the free list to prevent freelist
Andrew Tridgell [Sat, 2 Dec 2000 00:53:03 +0000 (00:53 +0000)]
change the split threahold for the free list to prevent freelist
(This used to be commit b64e1ae69314ae110c548f57810c34e620d57075)

20 years agofixed messaging bug - use strlen() instead of sizeof() in key length
Andrew Tridgell [Sat, 2 Dec 2000 00:51:50 +0000 (00:51 +0000)]
fixed messaging bug - use strlen() instead of sizeof() in key length
(This used to be commit 1d63160c751fa968e3a7618d1feb84a9feaa13dc)

20 years agoAllow zero length smb.conf files.
Tim Potter [Fri, 1 Dec 2000 04:10:54 +0000 (04:10 +0000)]
Allow zero length smb.conf files.
(This used to be commit 46007a541cd2497c14659a10ba24a6d0a375ac5a)

20 years agoRun configure script using dirname of $0. This allows configure.developer
Tim Potter [Fri, 1 Dec 2000 01:22:17 +0000 (01:22 +0000)]
Run configure script using dirname of $0.  This allows configure.developer
to be run when the build directory != source directory.
(This used to be commit 697e8e6de50ca4d1a37ec89330a6916429fd9a89)

20 years agoUse lp_codepagedir() instead of CODEPAGEDIR when loading the unicode map.
Tim Potter [Fri, 1 Dec 2000 01:14:55 +0000 (01:14 +0000)]
Use lp_codepagedir() instead of CODEPAGEDIR when loading the unicode map.
Found by Joseph Cheek <>
(This used to be commit ec74fdc631fbd5f0b5450df02acb9cd98c153823)

20 years agoCode to read & return POSIX ACLs as NT ACLs. Close to test on Linux.
Jeremy Allison [Fri, 1 Dec 2000 00:32:25 +0000 (00:32 +0000)]
Code to read & return POSIX ACLs as NT ACLs. Close to test on Linux.
(This used to be commit 52e9311bc2a837d1f4791f36c3477c430f841378)

20 years agoKeep syncing up POSIX ACL work...
Jeremy Allison [Thu, 30 Nov 2000 19:31:04 +0000 (19:31 +0000)]
Keep syncing up POSIX ACL work...
(This used to be commit 8f0062b873b2f4e8b27bb937ad213c4aa29443a7)

20 years agoWork in progress, doesn't compile. Adding the POSIX ACL mapping....
Jeremy Allison [Thu, 30 Nov 2000 01:00:36 +0000 (01:00 +0000)]
Work in progress, doesn't compile. Adding the POSIX ACL mapping....
(This used to be commit bcac4ede7608a91643f5fcd034f6b273a45b5c7a)

20 years agoalignment issues.
Jean-Fran├žois Micouleau [Wed, 29 Nov 2000 14:39:06 +0000 (14:39 +0000)]
alignment issues.

I hate that job ...

(This used to be commit 97e3b293569cebd91b5f2b37a7578e2e2779ceb0)

20 years agoFirst Release of the DocBook 'source'.
David Bannon [Tue, 28 Nov 2000 23:35:03 +0000 (23:35 +0000)]
First Release of the DocBook 'source'.
(This used to be commit 6cb727c033822e3e5ff3edc532457df8258beefd)

20 years agoinclude/dlinklist.h: Added '{' '}' around DLIST_PROMOTE so it can be used as a single
Jeremy Allison [Tue, 28 Nov 2000 22:17:44 +0000 (22:17 +0000)]
include/dlinklist.h: Added '{' '}' around DLIST_PROMOTE so it can be used as a single
statement after an 'if'. Tracking this down took 4 hours from my life and ANDREW I WANT
THEM BACK !!!!! :-).
include/smb.h smbd/password.c: Fixed the bug veritas reported with realloc of the validated_users
array growing without bounds. This is now a linked list as god (Andrew) intended :-).
(This used to be commit 346f2f9206b9b4ed123e2a61c0a48de630397b8a)

20 years agoPDC docs, made from DocBook source, comments ?
David Bannon [Tue, 28 Nov 2000 06:18:04 +0000 (06:18 +0000)]
PDC docs, made from DocBook source, comments ?
(This used to be commit 551a0eebb7c2d71bdc2b340c4d6244a840ac6958)

20 years agoRan DFS on Linux and found that readlink() on Linux does not append NUL
Shirish Kalele [Tue, 28 Nov 2000 00:26:42 +0000 (00:26 +0000)]
Ran DFS on Linux and found that readlink() on Linux does not append NUL
to the link read. So add a NUL..
(This used to be commit 04ebcf954c7568fc16ff4a75b31715d6b0a34aa4)

20 years agopassdb/secrets.c passdb/smbpassfile.c smbd/server.c : Actually *use* the code
Jeremy Allison [Mon, 27 Nov 2000 23:59:42 +0000 (23:59 +0000)]
passdb/secrets.c passdb/smbpassfile.c smbd/server.c : Actually *use* the code
written to transition from an old DOMAIN.MACHINE.MAC file to secrets.tdb.
printing/nt_printing.c: Fix case insensitive name lookups for driver files.
John - this should fix the Win9x/WinME problem correctly.
(This used to be commit 8f3332a9acf413ac5d12053ca5c52733a4e946cc)

20 years agoFixed messaging so main smbd can get lib/message.c messages.
Jeremy Allison [Mon, 27 Nov 2000 21:37:07 +0000 (21:37 +0000)]
Fixed messaging so main smbd can get lib/message.c messages.
(This used to be commit 349d58fb5758cebc5a8575f80103150b8cd0a080)

20 years agoRemoved unnessesary init.
Jeremy Allison [Mon, 27 Nov 2000 19:14:10 +0000 (19:14 +0000)]
Removed unnessesary init.
(This used to be commit 2a797f9aa26b2d0c703b9d67f6e1ec97e4f408d2)

20 years agofixed a potential locking deadlock in tdb
Andrew Tridgell [Mon, 27 Nov 2000 06:35:12 +0000 (06:35 +0000)]
fixed a potential locking deadlock in tdb
(This used to be commit 03453e2ae557d7fa119338b71744822093d2f38a)

20 years agoThis should fix Office failing to print to "FILE:".
Jeremy Allison [Fri, 24 Nov 2000 19:53:38 +0000 (19:53 +0000)]
This should fix Office failing to print to "FILE:".
(This used to be commit a08b08f7782234f26b2656a229007a411c6fb521)

20 years agoTar fixes from Craig Barratt
Jeremy Allison [Wed, 22 Nov 2000 23:06:29 +0000 (23:06 +0000)]
Tar fixes from Craig Barratt
(This used to be commit cf05709ec394d6cac14577c033d658bdc4506208)

20 years agoo fixed logon script problems (wrong len in reply to net_sam_logon for
Gerald Carter [Wed, 22 Nov 2000 19:51:41 +0000 (19:51 +0000)]
o fixed logon script problems (wrong len in reply to net_sam_logon for
  a few strings).  I was the one who broke it obviously.

o changed a few more defaults in the smbpasswd backend with
  respect to times.  Now the logon time becomes '0' and the
  pass_can_change_time is set ot the same as pass_last_set_time

o change Get_Pwnam() call in local_lookup_name to sys_getpwnam()
  as it did not seem necessary to try case permutations in the

  Tim,  I think this was your code, so you might want to double
  check me.

-- jerry
(This used to be commit 37a665002c5cd7908c13d306f61af272a899dbc8)

20 years agoFree talloc'ed memory from the main smbd. Patch from Rich Bollinger, Elliott Company
Jeremy Allison [Wed, 22 Nov 2000 19:42:54 +0000 (19:42 +0000)]
Free talloc'ed memory from the main smbd. Patch from Rich Bollinger, Elliott Company
(This used to be commit e041b144b2c7c6c9fdd6cd20256a197876aaf353)

20 years agoChanges from APPLIANCE_HEAD:
David O'Neill [Wed, 22 Nov 2000 16:19:07 +0000 (16:19 +0000)]
Changes from APPLIANCE_HEAD:
    - Add code to test equivalence of private data in NT_DEVICEMODE
(This used to be commit 684981851ffa3b51e78a6fd5960e219823eb90d5)

20 years agoADDPRINTERDRIVER info level 6 fix - this is dynamic depending
Jeremy Allison [Wed, 22 Nov 2000 01:26:09 +0000 (01:26 +0000)]
ADDPRINTERDRIVER info level 6 fix - this is dynamic depending
on a field in the struct - that's why it was so hard to find.
(This used to be commit 0ab6eb01b0d15e5eb744333d2bd79c27451f50e3)

20 years agoDon't forget to convert into UNIX character set before calling
Jeremy Allison [Tue, 21 Nov 2000 22:37:03 +0000 (22:37 +0000)]
Don't forget to convert into UNIX character set before calling
(This used to be commit 00cd72c385f1e5d075dbacf834b68769b5ac38f3)

20 years agocombined 2 if statments which used the same condition
Gerald Carter [Tue, 21 Nov 2000 06:05:08 +0000 (06:05 +0000)]
combined 2 if statments which used the same condition

-- jerry
(This used to be commit 445fd1dbd8bb93f56f20b5dd9e9d5b018147b21d)

20 years agomake proto
Gerald Carter [Tue, 21 Nov 2000 06:01:53 +0000 (06:01 +0000)]
make proto
(This used to be commit e0a02249d394a530d911d9b650c6eb56c188a6d8)

20 years agoAnother large patch for the passdb rewrite.
Gerald Carter [Tue, 21 Nov 2000 05:55:16 +0000 (05:55 +0000)]
Another large patch for the passdb rewrite.

  o added BOOL own_memory flag in SAM_ACCOUNT so we could
    use static memory for string pointer assignment or
    allocate a new string

  o added a reference TDB passdb backend.  This is only a reference
    and should not be used in production because
- RID's are generated using the same algorithm as with smbpasswd
  - a TDB can only have one key (w/o getting into problems) and we
  need three.  Therefore the pdb_sam-getpwuid() and
  pdb_getsampwrid() functions are interative searches :-(

    we need transaction support, multiple indexes, and a nice open
    source DBM.  The Berkeley DB (from seems to fit
    this criteria now)

  o added a new parameter "private dir" as many places in the code were
    using lp_smb_passwd_file() and chopping off the filename part.
    This makes more sense to me and I will docuement it in the man pages

  o Ran through Insure-lite and corrected memory leaks.  Need for
    a public flogging this time Jeremy (-:

-- jerry
(This used to be commit 4792029a2991bd84251d152a62b1033dec62cee2)

20 years agoFix for off-by-one StrnCpy.
Jeremy Allison [Tue, 21 Nov 2000 02:38:22 +0000 (02:38 +0000)]
Fix for off-by-one StrnCpy.
(This used to be commit 63cafb34b39443d03d17ae01b47adc0926b05fe2)

20 years agoFix for updating of print queues changed from a local box. Essentially,
Jeremy Allison [Tue, 21 Nov 2000 00:30:15 +0000 (00:30 +0000)]
Fix for updating of print queues changed from a local box. Essentially,
this makes sure that the change messages sent to ourselves are handled
synchronously w.r.t. other smb packets incoming.
(This used to be commit 78a13074455618308d048d1c69f62e660988eb90)

20 years agoFix from John Reilly for equivalence tests.
Jeremy Allison [Fri, 17 Nov 2000 23:10:56 +0000 (23:10 +0000)]
Fix from John Reilly for equivalence tests.
(This used to be commit b456274a7ba22d512bab5ede979cd9363398825b)

20 years agowe don't need the separate lp_status() connection records any more
Andrew Tridgell [Fri, 17 Nov 2000 03:31:03 +0000 (03:31 +0000)]
we don't need the separate lp_status() connection records any more
(This used to be commit 209e20365e562371aafafea301b4ffecc3d4c3ed)

20 years agofixed the problem with messages not getting through
Andrew Tridgell [Fri, 17 Nov 2000 03:15:18 +0000 (03:15 +0000)]
fixed the problem with messages not getting through

the problem had nothing to do with being your own pid, it was instead
a problem with IPC$ connections not being registered in the
connections database and an incorrect test for -1 in the messaging

These changes also mean that IPC$ shares now show up in
smbstatus. That is probably a good thing.
(This used to be commit 3575ad10985a18f897e38179ca69fa9a49a7ea02)

20 years agoFix for memory leak when adding driver.
Jeremy Allison [Fri, 17 Nov 2000 02:22:35 +0000 (02:22 +0000)]
Fix for memory leak when adding driver.
(This used to be commit eeab4e0290f9df84025e91c85d27b21e0c02781f)

20 years agosupport smbcontrol sending messages to itself (for testing purposes)
Andrew Tridgell [Fri, 17 Nov 2000 01:20:03 +0000 (01:20 +0000)]
support smbcontrol sending messages to itself (for testing purposes)
(This used to be commit 5dfae86dab50fba1890d0ce33fa9d68f12bc0bfa)

20 years agosave and restore errno in select
Andrew Tridgell [Fri, 17 Nov 2000 01:05:50 +0000 (01:05 +0000)]
save and restore errno in select
(This used to be commit 34f0379096d0701c74a51c51649ffe4cb1a24291)

20 years agoDelete queue on empty.
Jeremy Allison [Fri, 17 Nov 2000 00:48:02 +0000 (00:48 +0000)]
Delete queue on empty.
(This used to be commit 6e18a2aa58bc485e3c803ff357acc1b7fe6d95e1)

20 years agoJohn Reillys fix for de-registering broadcast names (NT doesn't do this).
Jeremy Allison [Fri, 17 Nov 2000 00:33:06 +0000 (00:33 +0000)]
John Reillys fix for de-registering broadcast names (NT doesn't do this).
(This used to be commit 245907f2affb530237809b81b8748f7f0a1e4502)

20 years agoFix for incorrect break using wrong offset when updating a form.
Jeremy Allison [Fri, 17 Nov 2000 00:31:29 +0000 (00:31 +0000)]
Fix for incorrect break using wrong offset when updating a form.
(This used to be commit 365c76e39d2397a12ac6785a51c4d1529527a356)

20 years agothe duplicate checking code will cause unaligned accesses on non-intel
Andrew Tridgell [Fri, 17 Nov 2000 00:08:42 +0000 (00:08 +0000)]
the duplicate checking code will cause unaligned accesses on non-intel
processors. Fixed.
(This used to be commit 64d38c24100cb3409b38b9923734f2a6202bdc2a)

20 years agouse process_exists() not kill(pid, 0)
Andrew Tridgell [Fri, 17 Nov 2000 00:02:16 +0000 (00:02 +0000)]
use process_exists() not kill(pid, 0)
(This used to be commit 30048cff12e03c95ef43ba4ee16af1df2de9dbc8)

20 years agoFix for a problem with the new messaging system. If a sender is using the
Jeremy Allison [Thu, 16 Nov 2000 21:38:24 +0000 (21:38 +0000)]
Fix for a problem with the new messaging system. If a sender is using the
messaging system as a notification mechanism, and the speed of notification
greatly exceeds the speed of message recovery, then you get a massively (>75Mb)
growing tdb. If the message is a simple notification, then the message is
static, and you only need one of them in transit to a target process at
any one time.
This patch adds a BOOL "allow_duplicates" to the message_send_XX primitives.
If set to False, then before sending a message the sender checks the existing
message queue for a target pid for a duplicate of this message, and doesn't
add to it if one already exists.
Also added code into msgtest.c to test this.
(This used to be commit 3aa7995660395ecb85c8e35b638fa9fbbb952558)

20 years agoFix for plaintext passwords from Pat Sandfort @ HP.
Jeremy Allison [Thu, 16 Nov 2000 21:33:21 +0000 (21:33 +0000)]
Fix for plaintext passwords from Pat Sandfort @ HP.
(This used to be commit b8753b92fbeb1d6768d0559e12ff2aa1d0148419)

20 years agoFix from Jim McDonough @ IBM for OS/2 clients.
Jeremy Allison [Thu, 16 Nov 2000 19:08:55 +0000 (19:08 +0000)]
Fix from Jim McDonough @ IBM for OS/2 clients.
(This used to be commit f571e1efd01c7b1b500a833df3bd074a8c4c65ec)

20 years agoChanges from APPLIANCE_HEAD:
David O'Neill [Thu, 16 Nov 2000 18:54:42 +0000 (18:54 +0000)]
Changes from APPLIANCE_HEAD:
- add empty README file for vlp.  Blame Tim.  =)
(This used to be commit 0ee469f566dbfdac1769fefbb5e61ce39d267872)

20 years agoOk - fixed a bug in our levelII oplock code. We need to break a level II on
Jeremy Allison [Thu, 16 Nov 2000 00:59:18 +0000 (00:59 +0000)]
Ok - fixed a bug in our levelII oplock code. We need to break a level II on
a byte range lock (write lock only, but Win2k breaks on read lock also so I
do the same) - if you think about why, this is obvious. Also fixed our client
code to do level II oplocks, if requested, and fixed the code where we would
assume the client wanted level II if it advertised itself as being level II
capable - it may not want that.
(This used to be commit 213cd0b5192307cd4b0026cae94b2f52fb1b0c02)

20 years agoUninitialized memory read fixes.
Jeremy Allison [Wed, 15 Nov 2000 02:39:11 +0000 (02:39 +0000)]
Uninitialized memory read fixes.
open_file_shared takes a DOS pathname, not a UNIX one.
(This used to be commit b2b59b93ff1c5bdc43b099e2db1ee86fe8514152)

20 years agoTuyrn debug timestamps on by default.
Jeremy Allison [Wed, 15 Nov 2000 01:11:38 +0000 (01:11 +0000)]
Tuyrn debug timestamps on by default.
Add Tim's lpq race fix.
(This used to be commit d43405bc47c95bf8c906035cba23bf95d252d13b)

20 years agoMerge from appliance head of JR's changes for driver versioning.
Jeremy Allison [Tue, 14 Nov 2000 21:56:32 +0000 (21:56 +0000)]
Merge from appliance head of JR's changes for driver versioning.
(This used to be commit cdbd2e99775642dc2e92004be9014bf38a92d80f)

20 years ago- fix "declaration of 'time' shadows global declaration" warning.
David O'Neill [Tue, 14 Nov 2000 15:50:30 +0000 (15:50 +0000)]
- fix "declaration of 'time' shadows global declaration" warning.
(This used to be commit 92ff07132b3834b469ad7bb73d6e714b175a12af)

20 years agoChanges from APPLIANCE_HEAD:
David O'Neill [Tue, 14 Nov 2000 15:26:53 +0000 (15:26 +0000)]
Changes from APPLIANCE_HEAD:
- merged Tim's vlp (virtual lp) test program.  Enable it with
      -DDEVELOPER or by using ./configure.developer
  (source/include/smb.h source/configure.developer
   source/printing/lpq_parse.c source/param/loadparm.c
   testsuite/printing/.cvsignore testsuite/printing/Makefile.vlp
(This used to be commit fbcf83140da1823e74f63227f0a95d07c6e76764)

20 years agoprinting/nt_printing.c: After long soul searching and making both Andrew and my
Jeremy Allison [Tue, 14 Nov 2000 02:14:58 +0000 (02:14 +0000)]
printing/nt_printing.c: After long soul searching and making both Andrew and my
life a misery, here is the only possible null driver fix we have found.
This *SUCKS*.
rpc_server/srv_spoolss_nt.c: Correct printername search. Correct portname reply
Correct attributes reply. Removal of unused temp variable.
(This used to be commit 06e71c9f8be20b84e33e143c3d0b7904225efb45)

20 years agoFixed the cut-n-paste bugs in the new passdb backend code that leaked memory.
Jeremy Allison [Tue, 14 Nov 2000 01:40:40 +0000 (01:40 +0000)]
Fixed the cut-n-paste bugs in the new passdb backend code that leaked memory.
(This used to be commit 55c6acce26a26af68149865dafb42e5a03b497e0)

20 years agoTims fixes for non-local lookup.
Jeremy Allison [Mon, 13 Nov 2000 23:37:53 +0000 (23:37 +0000)]
Tims fixes for non-local lookup.
(This used to be commit 38e04c43cc2ce8479b8cc3ff0f87d3d150d9af83)

20 years agoLarge commit which restructures the local password storage API.
Gerald Carter [Mon, 13 Nov 2000 23:03:34 +0000 (23:03 +0000)]
Large commit which restructures the local password storage API.
Currently the only backend which works is smbpasswd (tdb, LDAP, and NIS+)
are broken, but they were somewhat broken before. :)

The following functions implement the storage manipulation interface

/*The following definitions come from  passdb/pdb_smbpasswd.c  */

BOOL pdb_setsampwent (BOOL update);
void pdb_endsampwent (void);
SAM_ACCOUNT* pdb_getsampwent (void);
SAM_ACCOUNT* pdb_getsampwnam (char *username);
SAM_ACCOUNT* pdb_getsampwuid (uid_t uid);
SAM_ACCOUNT* pdb_getsampwrid (uint32 rid);
BOOL pdb_add_sam_account (SAM_ACCOUNT *sampass);
BOOL pdb_update_sam_account (SAM_ACCOUNT *sampass, BOOL override);
BOOL pdb_delete_sam_account (char* username);

There is also a host of pdb_set..() and pdb_get..() functions for
manipulating SAM_ACCOUNT struct members.  Note that the struct
passdb_ops {} has gone away.  Also notice that struct smb_passwd
(formally in smb.h) has been moved to passdb/pdb_smbpasswd.c
and is not accessed outisde of static internal functions in this
file.  All local password searches should make use of the the SAM_ACCOUNT
struct and the previously mentioned functions.

I'll write some documentation for this later.  The next step is to fix
the TDB passdb backend, then work on spliting the backends out into
share libraries, and finally get the LDAP backend going.

What works and may not:

o domain logons from Win9x  works
o domain logons from WinNT 4 works
o user and group enumeration
as implemented by Tim works
o file and print access works
o changing password from
Win9x & NT ummm...i'll fix this tonight :)

If I broke anything else, just yell and I'll fix it.  I think it
should be fairly quite.

-- jerry
(This used to be commit 0b92d0838ebdbe24f34f17e313ecbf61a0301389)

20 years agoFetch authentication info before actually using it.
Tim Potter [Sat, 11 Nov 2000 01:21:31 +0000 (01:21 +0000)]
Fetch authentication info before actually using it.
(This used to be commit 600eb0eb0036631b7e6d8aa7cddbc378368c002c)

20 years agoMerge of Herb's profiling code.
Jeremy Allison [Sat, 11 Nov 2000 00:33:33 +0000 (00:33 +0000)]
Merge of Herb's profiling code.
(This used to be commit 3be056c71aa8e0a4ba70d397107199004bdb7d3f)

20 years agoMerge in Herb's changes from 2.2.
Jeremy Allison [Fri, 10 Nov 2000 22:07:57 +0000 (22:07 +0000)]
Merge in Herb's changes from 2.2.
(This used to be commit 24d76c5fbda29d89c96d7c22193ec2eb93ad3887)

20 years agoAdded Tim's changes to lock DB during update.
Jeremy Allison [Fri, 10 Nov 2000 22:05:08 +0000 (22:05 +0000)]
Added Tim's changes to lock DB during update.
(This used to be commit f25b5798b8610de9748ae90ea1bf813b125f517d)

20 years agorpc_parse/parse_spoolss.c: Updated comment for old version of W2K.
Jeremy Allison [Fri, 10 Nov 2000 21:24:09 +0000 (21:24 +0000)]
rpc_parse/parse_spoolss.c: Updated comment for old version of W2K.
tdb/tdbutil.c: With varargs uint16 is cast to (int).
(This used to be commit 98764c5df9f363780427a423ead0913f7b2a0905)

20 years agoprinting/nt_printing.c: use getpwuid not smbgetpwuid. Canonicalize printernames.
Jeremy Allison [Fri, 10 Nov 2000 19:36:34 +0000 (19:36 +0000)]
printing/nt_printing.c: use getpwuid not smbgetpwuid. Canonicalize printernames.
printing/printing.c: Insure fix for malloc of zero.
rpc_parse/parse_misc.c: Enusre UNISTR's are zero filled.
rpc_parse/parse_spoolss.c: Correct INFO_6 - differs between pre-releases of W2K and shipping build.
rpc_server/srv_spoolss_nt.c: Canonicalize printernames.
(This used to be commit b17e23a8ff2b44540726968355a4b7e26f244f3b)

20 years agoFix from John E. Malmberg <> for -1 return in interfaces scan.
Jeremy Allison [Fri, 10 Nov 2000 19:02:32 +0000 (19:02 +0000)]
Fix from John E. Malmberg <> for -1 return in interfaces scan.
(This used to be commit 4d25a53c36ad2c33cc2ecaf1486e18f1536eff95)

20 years agoadded more explanation about the required permissions (and authorization)
Gerald Carter [Fri, 10 Nov 2000 15:33:15 +0000 (15:33 +0000)]
added more explanation about the required permissions (and authorization)
in order to add printer drivers to a samba server.

(This used to be commit b4e2fc0bd223993e61f215c89167e8549254c214)

20 years agominor update to help file
Herb Lewis [Thu, 9 Nov 2000 21:23:51 +0000 (21:23 +0000)]
minor update to help file
(This used to be commit 99b764e1c7d508e0caf2ffa82f279dff4fbb5aac)

20 years agorestructure PCP metrics (merge from 2.2 branch)
Herb Lewis [Thu, 9 Nov 2000 20:45:09 +0000 (20:45 +0000)]
restructure PCP metrics (merge from 2.2 branch)
(This used to be commit dc725c2256ff5f3d8ac37fe33cfa1685194f7f46)

20 years agoan attempt to get the handling of fields in printer info structures
Andrew Tridgell [Wed, 8 Nov 2000 03:12:16 +0000 (03:12 +0000)]
an attempt to get the handling of fields in printer info structures
consistent. Still working with Jeremy on this, there is probably more
to be done
(This used to be commit c4bb9c598cf9781d48bc123a8cbbed9c2049bf89)