ira/wip.git
11 years agolib/registry/util.c - Reorder the registry datatypes of the conversion functions
Matthias Dieter Wallnöfer [Sun, 29 Nov 2009 13:55:20 +0000 (14:55 +0100)]
lib/registry/util.c - Reorder the registry datatypes of the conversion functions

This is absolutely cosmetic and makes the code easier to comprehend.

11 years agoRevert "s4:registry/util - Don't include the trailing '\0' in the internal data forma...
Matthias Dieter Wallnöfer [Sun, 29 Nov 2009 13:42:31 +0000 (14:42 +0100)]
Revert "s4:registry/util - Don't include the trailing '\0' in the internal data format but add it on the back-conversion to a string"

This reverts commit 7d400715e9af2056690c03a1a2f45c7f343fa313.

"convert_string_talloc_convenience" does always add the NULL termination. Didn't
know that. Thanks Jelmer for pointing out!

11 years agos3: Restore "fake directory create times" as a share parameter
Volker Lendecke [Fri, 27 Nov 2009 14:44:50 +0000 (15:44 +0100)]
s3: Restore "fake directory create times" as a share parameter

11 years agos3: "copy_reg" only looks at mode, uid, gid, atime and mtime (no birthtime)
Volker Lendecke [Fri, 27 Nov 2009 14:10:23 +0000 (15:10 +0100)]
s3: "copy_reg" only looks at mode, uid, gid, atime and mtime (no birthtime)

11 years agos3: Pass up fake_dir_create_times from atalk_build_paths
Volker Lendecke [Fri, 27 Nov 2009 13:58:46 +0000 (14:58 +0100)]
s3: Pass up fake_dir_create_times from atalk_build_paths

The callers only look at the mode

11 years agos3: Move directory_exist_stat to testparm.c, it only looks at the mode
Volker Lendecke [Fri, 27 Nov 2009 12:19:30 +0000 (13:19 +0100)]
s3: Move directory_exist_stat to testparm.c, it only looks at the mode

11 years agos3: Pass fake_dir_create_times down to file_exist_stat, none of the callers look...
Volker Lendecke [Fri, 27 Nov 2009 12:17:05 +0000 (13:17 +0100)]
s3: Pass fake_dir_create_times down to file_exist_stat, none of the callers look at the mtime

11 years agos3: "startsmbfilepwent" only looks at the inode -- is that enough?
Volker Lendecke [Fri, 27 Nov 2009 12:12:40 +0000 (13:12 +0100)]
s3: "startsmbfilepwent" only looks at the inode -- is that enough?

11 years agos3: "get_file_size" only looks at the size
Volker Lendecke [Fri, 27 Nov 2009 12:11:17 +0000 (13:11 +0100)]
s3: "get_file_size" only looks at the size

11 years agos3: "socket_exist" only looks at the mode
Volker Lendecke [Fri, 27 Nov 2009 12:10:48 +0000 (13:10 +0100)]
s3: "socket_exist" only looks at the mode

11 years agos3: "sys_path_to_bdev" only looks at the devicenumber
Volker Lendecke [Fri, 27 Nov 2009 12:08:51 +0000 (13:08 +0100)]
s3: "sys_path_to_bdev" only looks at the devicenumber

11 years agos3: "check_log_size" only looks at the size
Volker Lendecke [Fri, 27 Nov 2009 12:07:54 +0000 (13:07 +0100)]
s3: "check_log_size" only looks at the size

11 years agos3: "regf_hbin_allocate" only looks at the size
Volker Lendecke [Fri, 27 Nov 2009 12:07:12 +0000 (13:07 +0100)]
s3: "regf_hbin_allocate" only looks at the size

11 years agos3: "read_block" only looks at the size
Volker Lendecke [Fri, 27 Nov 2009 12:06:44 +0000 (13:06 +0100)]
s3: "read_block" only looks at the size

11 years agos3: "write_block" does not use the sbuf at all
Volker Lendecke [Fri, 27 Nov 2009 12:06:14 +0000 (13:06 +0100)]
s3: "write_block" does not use the sbuf at all

11 years agos3: "net_conf_addshare" only looks at the mode
Volker Lendecke [Fri, 27 Nov 2009 12:05:16 +0000 (13:05 +0100)]
s3: "net_conf_addshare" only looks at the mode

11 years agos3: "net_usershare_add" only looks at the mode, device and inode
Volker Lendecke [Fri, 27 Nov 2009 12:04:38 +0000 (13:04 +0100)]
s3: "net_usershare_add" only looks at the mode, device and inode

11 years agos3: "net_usershare_add" only looks at the device and inode
Volker Lendecke [Fri, 27 Nov 2009 12:04:18 +0000 (13:04 +0100)]
s3: "net_usershare_add" only looks at the device and inode

11 years agos3: "net_usershare_add" only looks at the mode and uid
Volker Lendecke [Fri, 27 Nov 2009 12:03:09 +0000 (13:03 +0100)]
s3: "net_usershare_add" only looks at the mode and uid

11 years agos3: "count_num_usershares" only looks at the mode
Volker Lendecke [Fri, 27 Nov 2009 12:02:26 +0000 (13:02 +0100)]
s3: "count_num_usershares" only looks at the mode

11 years agos3: "info_fn" only looks at the mode and uid
Volker Lendecke [Fri, 27 Nov 2009 12:01:46 +0000 (13:01 +0100)]
s3: "info_fn" only looks at the mode and uid

11 years agos3: "get_share_list" only looks at the mode and uid
Volker Lendecke [Fri, 27 Nov 2009 12:00:51 +0000 (13:00 +0100)]
s3: "get_share_list" only looks at the mode and uid

11 years agos3: "cgi_download" only looks at the mode and size
Volker Lendecke [Fri, 27 Nov 2009 12:00:10 +0000 (13:00 +0100)]
s3: "cgi_download" only looks at the mode and size

11 years agos3: "print_job_end" only looks at the size
Volker Lendecke [Fri, 27 Nov 2009 11:59:11 +0000 (12:59 +0100)]
s3: "print_job_end" only looks at the size

11 years agos3: "check_magic" only looks at the size
Volker Lendecke [Fri, 27 Nov 2009 11:58:26 +0000 (12:58 +0100)]
s3: "check_magic" only looks at the size

11 years agos3: "disk_quotas" only looks at the devicenumber
Volker Lendecke [Fri, 27 Nov 2009 11:57:43 +0000 (12:57 +0100)]
s3: "disk_quotas" only looks at the devicenumber

11 years agos3: "load_usershare_shares" only looks at the mode and uid
Volker Lendecke [Fri, 27 Nov 2009 11:53:48 +0000 (12:53 +0100)]
s3: "load_usershare_shares" only looks at the mode and uid

11 years agos3: "load_usershare_service" only looks at the mode and uid
Volker Lendecke [Fri, 27 Nov 2009 11:53:23 +0000 (12:53 +0100)]
s3: "load_usershare_service" only looks at the mode and uid

11 years agos3: "usershare_exists" only looks at the mode and mtime
Volker Lendecke [Fri, 27 Nov 2009 11:52:31 +0000 (12:52 +0100)]
s3: "usershare_exists" only looks at the mode and mtime

11 years agos3: "process_usershare_file" only looks at the dev, ino, mode and size
Volker Lendecke [Fri, 27 Nov 2009 11:51:56 +0000 (12:51 +0100)]
s3: "process_usershare_file" only looks at the dev, ino, mode and size

11 years agos3: "process_usershare_file" only looks at the mode and size
Volker Lendecke [Fri, 27 Nov 2009 11:51:04 +0000 (12:51 +0100)]
s3: "process_usershare_file" only looks at the mode and size

11 years agos3: "parse_usershare_file" only looks at the mode and uid
Volker Lendecke [Fri, 27 Nov 2009 11:49:42 +0000 (12:49 +0100)]
s3: "parse_usershare_file" only looks at the mode and uid

11 years agos3: "tar_parseargs" only looks at the mtime
Volker Lendecke [Fri, 27 Nov 2009 11:48:33 +0000 (12:48 +0100)]
s3: "tar_parseargs" only looks at the mtime

11 years agos3: "dotareof" only looks at the file type
Volker Lendecke [Fri, 27 Nov 2009 11:47:57 +0000 (12:47 +0100)]
s3: "dotareof" only looks at the file type

11 years agos3: client "newer" does not look at the create timestamp
Volker Lendecke [Fri, 27 Nov 2009 11:44:33 +0000 (12:44 +0100)]
s3: client "newer" does not look at the create timestamp

11 years agos3: Pass the "fake dir create times" parameter to sys_*stat
Volker Lendecke [Fri, 27 Nov 2009 11:42:39 +0000 (12:42 +0100)]
s3: Pass the "fake dir create times" parameter to sys_*stat

Step 0 to restore it as a per-share paramter

11 years agos4:upgrade_from_s3 - Move it back to "setup"
Matthias Dieter Wallnöfer [Sat, 28 Nov 2009 18:23:08 +0000 (19:23 +0100)]
s4:upgrade_from_s3 - Move it back to "setup"

Suggested by Jelmer

11 years agos4:setup/provision - Rework
Matthias Dieter Wallnöfer [Sat, 28 Nov 2009 16:03:57 +0000 (17:03 +0100)]
s4:setup/provision - Rework

- Revert change in "ask" - was previously correct
- Readd accidentally removed checks for non-null realm and domainname
- On interactive mode perform only one "ask" call per question
- Inform the user about the unset administrator password

11 years agos4:upgrade.py - remove my copyright
Matthias Dieter Wallnöfer [Sat, 28 Nov 2009 17:48:47 +0000 (18:48 +0100)]
s4:upgrade.py - remove my copyright

First I wanted to add also other changes but then I didn't introduce them.
Therefore remove my copyright again.

11 years agos4:upgrade.py - readd accidentally removed empty lines
Matthias Dieter Wallnöfer [Sat, 28 Nov 2009 15:59:18 +0000 (16:59 +0100)]
s4:upgrade.py - readd accidentally removed empty lines

Jelmer pointed out that this is against the PEP8 norm

11 years agos4:samba3.py/upgrade.py: Revert
Matthias Dieter Wallnöfer [Sat, 28 Nov 2009 14:28:45 +0000 (15:28 +0100)]
s4:samba3.py/upgrade.py: Revert

This reverts commit 2175c0ed0649d545ea833d50e8d33fbee9051c35.
This reverts commit 6c3e2417a0639cd7c367de93615c422cf5217456.
This reverts commit dbb8989e05ac3189a5eca11fa40d572388ea02fc.
This reverts commit 82adfa39b75aa628c88f828278c6ac09335d1a49.
This reverts commit f299efa8f05c6a5b739222bdf75690a4591d3650.

After a small discussion with Jelmer we agreed that this isn't the right way
to fix the problem. We should wait for a real patch rather to rely on temporal
hacks.

11 years agos4-ldb: make it much easier to use common ldb controls
Andrew Tridgell [Sat, 28 Nov 2009 06:35:36 +0000 (17:35 +1100)]
s4-ldb: make it much easier to use common ldb controls

11 years agos4-drs: cope with bogus empty attributes from w2k8-r2
Andrew Tridgell [Sat, 28 Nov 2009 02:27:06 +0000 (13:27 +1100)]
s4-drs: cope with bogus empty attributes from w2k8-r2

w2k8-r2 sometimes sends empty attributes with completely bogus attrid
values in a DRS replication response. This allows us to continue with
the vampire operation despite these broken elements.

11 years agos4: fix SD update and password change in upgrade script
Matthieu Patou [Fri, 27 Nov 2009 14:37:14 +0000 (17:37 +0300)]
s4: fix SD update and password change in upgrade script

- reserve a new Samba OID for recalculate SD control
- fix the update SD function
- fix handling of kvno in the update_machine_account_password function
- fix handling of handles in RPC winreg server

Signed-off-by: Andrew Tridgell <tridge@samba.org>
11 years agos4:WINREG RPC server - add another "talloc_unlink" in "DeleteKey"
Matthias Dieter Wallnöfer [Wed, 18 Nov 2009 07:48:30 +0000 (08:48 +0100)]
s4:WINREG RPC server - add another "talloc_unlink" in "DeleteKey"

Also here we waste memory - therefore free the pointless handle after the delete.

11 years agos4:WINREG RPC server - Reintroduce the free operation on "CloseKey"
Matthias Dieter Wallnöfer [Wed, 18 Nov 2009 09:24:09 +0000 (10:24 +0100)]
s4:WINREG RPC server - Reintroduce the free operation on "CloseKey"

Better use "talloc_unlink" here Since we could have more than one reference.

11 years agos4-smbtorture: more and stricter tests for printer and data keys in RPC-SPOOLSS.
Günther Deschner [Fri, 27 Nov 2009 22:14:27 +0000 (23:14 +0100)]
s4-smbtorture: more and stricter tests for printer and data keys in RPC-SPOOLSS.

Guenther

11 years agos4:provision.py - remove hardcoded SIDs and RIDs
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 21:39:52 +0000 (22:39 +0100)]
s4:provision.py - remove hardcoded SIDs and RIDs

After rework of the SDDL modules this is possible. In future: Never hardcode
them anymore! Always use the abbreviations.

11 years agos4:security/sddl - rework of the security descriptor abbreviations
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 21:37:52 +0000 (22:37 +0100)]
s4:security/sddl - rework of the security descriptor abbreviations

- Reoder them
- Add some new ones (needed for the security descriptor in the provision script)

11 years agosecurity.idl - Add some more wellknown SIDs/RIDs
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 21:36:59 +0000 (22:36 +0100)]
security.idl - Add some more wellknown SIDs/RIDs

11 years agos4:registry/util - Don't include the trailing '\0' in the internal data format but...
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 20:14:44 +0000 (21:14 +0100)]
s4:registry/util - Don't include the trailing '\0' in the internal data format but add it on the back-conversion to a string

As far as I know the registry library saves all data (including) strings without
the null termination. So do it also here in a similar way.

11 years agos4:net utility - add a notice for the "help" operation and format it's output of...
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 19:26:17 +0000 (20:26 +0100)]
s4:net utility - add a notice for the "help" operation and format it's output of the command list better

11 years agos3-kerberos: fix the build on Mac OS X 10.6.2.
Günther Deschner [Fri, 27 Nov 2009 19:08:44 +0000 (20:08 +0100)]
s3-kerberos: fix the build on Mac OS X 10.6.2.

Guenther

11 years agos4:samba3.py - deactivate also the assertion on line 599
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 19:02:25 +0000 (20:02 +0100)]
s4:samba3.py - deactivate also the assertion on line 599

11 years agos3-kerberos: add a missing reference to authdata headers.
Günther Deschner [Fri, 27 Nov 2009 17:51:56 +0000 (18:51 +0100)]
s3-kerberos: add a missing reference to authdata headers.

Guenther

11 years agos3-kerberos: do not include authdata headers before including krb5 headers.
Günther Deschner [Fri, 27 Nov 2009 17:30:18 +0000 (18:30 +0100)]
s3-kerberos: do not include authdata headers before including krb5 headers.

Guenther

11 years agos3-spoolss: simplify _spoolss_EnumPrinterKey a little more.
Günther Deschner [Thu, 26 Nov 2009 18:01:54 +0000 (19:01 +0100)]
s3-spoolss: simplify _spoolss_EnumPrinterKey a little more.

Guenther

11 years agos4:winbind - Fix it another time up
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 16:45:20 +0000 (17:45 +0100)]
s4:winbind - Fix it another time up

The first fix attempt did break some configurations (incl. "make test").
This now is the right fix with the right comment.

11 years agos4:provision.py - cosmetic
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 16:39:02 +0000 (17:39 +0100)]
s4:provision.py - cosmetic

11 years agos4:samba3.py (and test) - deactivate the tests until those parameters are fixed
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 15:39:27 +0000 (16:39 +0100)]
s4:samba3.py (and test) - deactivate the tests until those parameters are fixed

11 years agos4:upgrade.py - Umlaut problem
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 15:35:28 +0000 (16:35 +0100)]
s4:upgrade.py - Umlaut problem

11 years agos4:tests.sh - Make also here the change from "upgrade" to "upgrade_from_s3"
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 15:34:44 +0000 (16:34 +0100)]
s4:tests.sh - Make also here the change from "upgrade" to "upgrade_from_s3"

11 years agos3-kerberos: only use krb5 headers where required.
Günther Deschner [Fri, 27 Nov 2009 14:52:57 +0000 (15:52 +0100)]
s3-kerberos: only use krb5 headers where required.

This seems to be the only way to deal with mixed heimdal/MIT setups during
merged build.

Guenther

11 years agomisc: mark winreg_Data little-endian except for a REG_DWORD_BIG_ENDIAN.
Günther Deschner [Fri, 27 Nov 2009 10:18:30 +0000 (11:18 +0100)]
misc: mark winreg_Data little-endian except for a REG_DWORD_BIG_ENDIAN.

Guenther

11 years agopidl: fix handling of output arguments in s3 client stubs.
Günther Deschner [Fri, 27 Nov 2009 15:06:40 +0000 (16:06 +0100)]
pidl: fix handling of output arguments in s3 client stubs.

a20e095 used (uint8_t) instead of (uint8_t *).

Guenther

11 years agos4:upgrade.py - rework to make the upgrade s3 -> s4 possible again
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 14:50:26 +0000 (15:50 +0100)]
s4:upgrade.py - rework to make the upgrade s3 -> s4 possible again

Able to read basic settings "workgroup", "realm", "netbios name" and the
function mode from the s3 "smb.conf" and use them for the provision of s4.

11 years agos4:upgrade_from_s3 - Fix message outputs
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 14:49:18 +0000 (15:49 +0100)]
s4:upgrade_from_s3 - Fix message outputs

The quiet parameter was interpreted in the reverse manner.

11 years agos4:upgrade.py - the import of WINS databases don't seem to work always
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 14:02:18 +0000 (15:02 +0100)]
s4:upgrade.py - the import of WINS databases don't seem to work always

Disable it for now until the cause has been found

11 years agos4:samba3.py - ignore comments in "smb.conf" files
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 14:00:41 +0000 (15:00 +0100)]
s4:samba3.py - ignore comments in "smb.conf" files

11 years agos4:samba3.py - don't read those informations out from the TDB
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 13:59:12 +0000 (14:59 +0100)]
s4:samba3.py - don't read those informations out from the TDB

At the moment those three calls are broken

11 years agos4:samba3.py - support the TDB version 3
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 13:58:37 +0000 (14:58 +0100)]
s4:samba3.py - support the TDB version 3

11 years agos4:provision - Fix up the provision of "standalone" and "member" mode
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 13:48:58 +0000 (14:48 +0100)]
s4:provision - Fix up the provision of "standalone" and "member" mode

Both modes weren't possible anymore since 1.) the secrets entry wasn't created,
2.) a lookup in winbindd was done using "lp_workgroup()" rather than
"lp_sam_name()" (since on the mentioned two configurations we use the netbios
name as domainname - and not the workgroup).

11 years agos4:provision.py - cosmetic output correction
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 12:07:52 +0000 (13:07 +0100)]
s4:provision.py - cosmetic output correction

11 years agos4:setup/provision - make the interactive mode work again
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 12:02:31 +0000 (13:02 +0100)]
s4:setup/provision - make the interactive mode work again

11 years agos4:WHATSNEW4.txt - Add also here a comment about the "upgrade_from_s3" script
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 10:07:11 +0000 (11:07 +0100)]
s4:WHATSNEW4.txt - Add also here a comment about the "upgrade_from_s3" script

11 years agos4:howto.txt - add a notice about the upgrade possibilities and fix line spaces
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 10:02:20 +0000 (11:02 +0100)]
s4:howto.txt - add a notice about the upgrade possibilities and fix line spaces

11 years agos4:upgrade script - rename it to "upgrade_from_s3" and do some rework
Matthias Dieter Wallnöfer [Fri, 27 Nov 2009 09:50:03 +0000 (10:50 +0100)]
s4:upgrade script - rename it to "upgrade_from_s3" and do some rework

- Give a better name to the script
- Move it to the location where also "upgradeprovision" resides
- Fix up trailing whitespaces and tabs

11 years agos3-nsstest: drastically shrink size and dependencies of nsstest binary.
Günther Deschner [Thu, 25 Jun 2009 16:18:50 +0000 (18:18 +0200)]
s3-nsstest: drastically shrink size and dependencies of nsstest binary.

The size went down from 6.4M to 104K on my box.

Guenther

11 years agos4-install: old systems don't have sed -i
Andrew Tridgell [Fri, 27 Nov 2009 08:58:00 +0000 (19:58 +1100)]
s4-install: old systems don't have sed -i

surprisingly, this failure came from SLES8. I didn't realise that the
-i option was so new!

11 years agos4-selftest: s4 passes all the SMB2-LOCK tests now
Andrew Tridgell [Fri, 27 Nov 2009 08:11:28 +0000 (19:11 +1100)]
s4-selftest: s4 passes all the SMB2-LOCK tests now

11 years agos4-torture: fixed error code for s4 in SMB2-LOCK test
Andrew Tridgell [Fri, 27 Nov 2009 08:10:50 +0000 (19:10 +1100)]
s4-torture: fixed error code for s4 in SMB2-LOCK test

s4 returns NETWORK_NAME_DELETED if you attempt to use an invalid tree connection
for a lock. This test (correctly I think) happens before we validate the file handle.
That implies that when you pass both a closed handle and a invalid tree you
should get NT_STATUS_NETWORK_NAME_DELETED.

11 years agos4-ntvfs: win7 does not check for the NONE smb2 lock flag on unlock
Andrew Tridgell [Fri, 27 Nov 2009 08:09:10 +0000 (19:09 +1100)]
s4-ntvfs: win7 does not check for the NONE smb2 lock flag on unlock

11 years agos4-selftest: s4 passes this test now
Andrew Tridgell [Fri, 27 Nov 2009 07:10:01 +0000 (18:10 +1100)]
s4-selftest: s4 passes this test now

11 years agos4-torture: mark s4 as doing valid lock range tests on SMB
Andrew Tridgell [Fri, 27 Nov 2009 07:09:50 +0000 (18:09 +1100)]
s4-torture: mark s4 as doing valid lock range tests on SMB

11 years agos4-ntvfs: move valid lock range test from smb2 layer to generic code
Andrew Tridgell [Fri, 27 Nov 2009 07:08:51 +0000 (18:08 +1100)]
s4-ntvfs: move valid lock range test from smb2 layer to generic code

win7 also fails invalid lock ranges on SMB

11 years agos4:smb_server/smb2: don't reset highest_smb2_seqnum on SMB2 Cancel
Stefan Metzmacher [Thu, 26 Nov 2009 13:18:50 +0000 (14:18 +0100)]
s4:smb_server/smb2: don't reset highest_smb2_seqnum on SMB2 Cancel

metze

11 years agos4-torture: fixed expected error codes for s4 in SMB2-LOCK
Andrew Tridgell [Fri, 27 Nov 2009 03:54:22 +0000 (14:54 +1100)]
s4-torture: fixed expected error codes for s4 in SMB2-LOCK

I think the error/success codes returned by windows for these tests
are quite bogus. The ones s4 gives are much more reasonable. The
locking ones returning NT_STATUS_SUCCESS could lead to data loss, as
an application thinks it has a file locked correctly when it fact it
doesn't, so it could do an unsafe modify.

11 years agos4-drstest: don't use getenv("LDB_URL") in test suites
Andrew Tridgell [Fri, 27 Nov 2009 03:42:05 +0000 (14:42 +1100)]
s4-drstest: don't use getenv("LDB_URL") in test suites

I was stumped for a while as to why the drs test suite was failing for
me. It turned out that it looked for LDB_URL in the environment, and
used it if set. I had it set in my terminal, and it was happily
munching on my sam.ldb while testing. Quite a cute bug really :-)

11 years agos4-pvfs: fixed access check failure in SFILEINFO test
Andrew Tridgell [Fri, 27 Nov 2009 03:22:29 +0000 (14:22 +1100)]
s4-pvfs: fixed access check failure in SFILEINFO test

matching windows behaviour is not always the right thing to do!

11 years agos4-ldb: improve detection of whether the server has a GC port
Andrew Tridgell [Fri, 27 Nov 2009 03:20:47 +0000 (14:20 +1100)]
s4-ldb: improve detection of whether the server has a GC port

We were trying to open $SERVER:3268 regardless, which could result in
creating a file called "localdc1:3268", which led to subsequent test
failures

11 years agos4-ldb: better to test for valid arguments in ldb library than commandline
Andrew Tridgell [Fri, 27 Nov 2009 03:18:39 +0000 (14:18 +1100)]
s4-ldb: better to test for valid arguments in ldb library than commandline

We were testing for valid DNs in ldbrename in the command line
tool. This hid a bug in the ldb library where we caught a bad DN in
the objectclass module rather than in the main ldb code. It is better
to do validation of the DNs passed on the command line in the library
code, as this gives us more consistent error handling between the
programming APIs for ldb and the command line.

11 years agos4-smb2: SMB2 uses NT_STATUS_CANCELLED for cancelled locks
Andrew Tridgell [Thu, 26 Nov 2009 06:38:50 +0000 (17:38 +1100)]
s4-smb2: SMB2 uses NT_STATUS_CANCELLED for cancelled locks

11 years agos4-smb2: sequence numbers are not checked in SMB2_OP_CANCEL
Andrew Tridgell [Thu, 26 Nov 2009 06:38:11 +0000 (17:38 +1100)]
s4-smb2: sequence numbers are not checked in SMB2_OP_CANCEL

11 years agotorture: fixed SMB2-LOCK valgrind error
Andrew Tridgell [Thu, 26 Nov 2009 06:03:20 +0000 (17:03 +1100)]
torture: fixed SMB2-LOCK valgrind error

11 years agos4-smb2: check for invalid SMB2 lock ranges
Andrew Tridgell [Thu, 26 Nov 2009 05:53:51 +0000 (16:53 +1100)]
s4-smb2: check for invalid SMB2 lock ranges

11 years agos4-smb2: check for an invalid lock flags combination
Andrew Tridgell [Thu, 26 Nov 2009 05:35:03 +0000 (16:35 +1100)]
s4-smb2: check for an invalid lock flags combination

UNLOCK with FAIL_IMMEDIATELY is not allowed

11 years agos4-install: fixed install path for python scripts
Andrew Tridgell [Thu, 26 Nov 2009 02:06:01 +0000 (13:06 +1100)]
s4-install: fixed install path for python scripts

when we install python scripts we need to fix the internal path used
to find modules. We also need to install the scripts in the right
place. Most of them should go in $SBINDIR not share/setup/

11 years agos4:upgradeprovision Rework update_machine_account_password() tranactions
Andrew Bartlett [Thu, 26 Nov 2009 21:10:54 +0000 (08:10 +1100)]
s4:upgradeprovision Rework update_machine_account_password() tranactions

This balances the transaction_begin() and transactin_prepare_commit() calls

Andrew Bartlett

11 years agos4:dsdb Don't segfault with ldb_transaction_prepare_commit() without begin()
Andrew Bartlett [Thu, 26 Nov 2009 21:05:59 +0000 (08:05 +1100)]
s4:dsdb Don't segfault with ldb_transaction_prepare_commit() without begin()

It is up to other modules to complain if
ldb_transaction_prepare_commit() is called before
ldb_transaction_begin_transaction()

Andrew Bartlett

11 years agos4:upgradeprovision add 'exit $failed' to blackbox test
Andrew Bartlett [Thu, 26 Nov 2009 11:01:54 +0000 (22:01 +1100)]
s4:upgradeprovision add 'exit $failed' to blackbox test